s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol...
authorJeremy Allison <jra@samba.org>
Tue, 26 Nov 2019 20:53:09 +0000 (12:53 -0800)
committerKarolin Seeger <kseeger@samba.org>
Mon, 16 Dec 2019 08:22:36 +0000 (08:22 +0000)
commit2757c0711d02c2135afb161dac70d2150b18190b
tree79e39e320b8a8cd43152679a9f2e639940f2f0d5
parentd8d661aabfdb04b8a472b85e6cc3fba0dd490c23
s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds.

Otherwise we can end up with negprot.done set, but
without smbXsrv_connection_init_tables() being called.

This can cause a client self-crash.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec  4 21:27:24 UTC 2019 on sn-devel-184

(cherry picked from commit 8db0c1bff6f42feabd2e4d9dfb13ae12cc29607b)
selftest/knownfail.d/smb1_fuzz_smbd [deleted file]
source3/smbd/negprot.c