Don't go past the end of a page in a NetScaler file.
authorGuy Harris <guy@alum.mit.edu>
Thu, 2 Mar 2017 03:53:29 +0000 (19:53 -0800)
committerGuy Harris <guy@alum.mit.edu>
Thu, 2 Mar 2017 03:54:04 +0000 (03:54 +0000)
commit19c51d27b9cabf7b811d6c60e42a59330235c2de
tree5c0c9dbd28e117481c7582c4e4f79af9a5b75ebe
parent929e0e897cc857dc11cffc612c4eb8030cbb0e2d
Don't go past the end of a page in a NetScaler file.

Records in a properly formatted NetScaler file shouldn't go past the end
of a page, but nothing guarantees that a NetScaler file will be properly
formatted.

NetScaler 3.x files allow record bodies to go past the end of a page,
but 1.x and 2.x files don't, so treat record headers that go past the
end of a page, and record bodies in 1.x and 2.x files that go past the
end of a page, as errors.

Clean up some stuff while we're at it.

Bug: 13430
Change-Id: I3b1d56086e3bb14b246406f306e3d730df337561
Reviewed-on: https://code.wireshark.org/review/20326
Reviewed-by: Guy Harris <guy@alum.mit.edu>
wiretap/netscaler.c