git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d2720a9) | patch
s3:utils: Use ‘int’ for popt parameters
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 1 May 2023 03:36:53 +0000 (15:36 +1200)
committerJeremy Allison <jra@samba.org>
Thu, 4 May 2023 00:34:32 +0000 (00:34 +0000)
commit11f36804629f54bc812331eabb862bd0fd637dae
tree9000c010f5c52e09b99c2ff2de42256034e8f056tree
parentd2720a9e788f6870b7c68a1126820b15a8db811dcommit | diff
s3:utils: Use ‘int’ for popt parameters

Previously we were handing the addresses of bool parameters to popt for
POPT_ARG_NONE parameters. This is not supported, and popt was returning
POPT_ERROR_BADOPERATION for these parameters (not bundled popt, though,
nor on Debian or Ubuntu). Using integers instead ensures that these
addresses are aligned and sized as popt expects.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl@samba.org>
source3/utils/smbget.c diff | blob | history
Samba Shared Repository