swrap: Fix strict aliasing issues in swrap_pcap_packet_init()
[socket_wrapper.git] / src / socket_wrapper.c
index ed42b2d2bbdac169123648b6a4e142ecda1ba175..193f1f0672d2e0d883a4aeaaeba2fb29e238b1b4 100644 (file)
@@ -1,8 +1,11 @@
 /*
- * Copyright (c) 2005-2008 Jelmer Vernooij <jelmer@samba.org>
- * Copyright (C) 2006-2014 Stefan Metzmacher <metze@samba.org>
- * Copyright (C) 2013-2014 Andreas Schneider <asn@samba.org>
+ * BSD 3-Clause License
  *
+ * Copyright (c) 2005-2008, Jelmer Vernooij <jelmer@samba.org>
+ * Copyright (c) 2006-2018, Stefan Metzmacher <metze@samba.org>
+ * Copyright (c) 2013-2018, Andreas Schneider <asn@samba.org>
+ * Copyright (c) 2014-2017, Michael Adam <obnox@samba.org>
+ * Copyright (c) 2016-2018, Anoop C S <anoopcs@redhat.com>
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -31,7 +34,6 @@
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
- *
  */
 
 /*
@@ -142,6 +144,10 @@ enum swrap_dbglvl_e {
        } while(0)
 #endif
 
+#ifndef SAFE_FREE
+#define SAFE_FREE(x) do { if ((x) != NULL) {free(x); (x)=NULL;} } while(0)
+#endif
+
 #ifndef discard_const
 #define discard_const(ptr) ((void *)((uintptr_t)(ptr)))
 #endif
@@ -169,97 +175,26 @@ enum swrap_dbglvl_e {
 # endif
 #endif
 
-/* Macros for accessing mutexes */
-# define SWRAP_LOCK(m) do { \
-       pthread_mutex_lock(&(m ## _mutex)); \
-} while(0)
-
-# define SWRAP_UNLOCK(m) do { \
-       pthread_mutex_unlock(&(m ## _mutex)); \
-} while(0)
-
 /* Add new global locks here please */
 # define SWRAP_LOCK_ALL \
-       SWRAP_LOCK(libc_symbol_binding); \
+       swrap_mutex_lock(&libc_symbol_binding_mutex); \
 
 # define SWRAP_UNLOCK_ALL \
-       SWRAP_UNLOCK(libc_symbol_binding); \
+       swrap_mutex_unlock(&libc_symbol_binding_mutex); \
 
 #define SOCKET_INFO_CONTAINER(si) \
        (struct socket_info_container *)(si)
 
 #define SWRAP_LOCK_SI(si) do { \
        struct socket_info_container *sic = SOCKET_INFO_CONTAINER(si); \
-       pthread_mutex_lock(&sic->meta.mutex); \
+       swrap_mutex_lock(&sic->meta.mutex); \
 } while(0)
 
 #define SWRAP_UNLOCK_SI(si) do { \
        struct socket_info_container *sic = SOCKET_INFO_CONTAINER(si); \
-       pthread_mutex_unlock(&sic->meta.mutex); \
+       swrap_mutex_unlock(&sic->meta.mutex); \
 } while(0)
 
-#define DLIST_ADD(list, item) do { \
-       if (!(list)) { \
-               (item)->prev    = NULL; \
-               (item)->next    = NULL; \
-               (list)          = (item); \
-       } else { \
-               (item)->prev    = NULL; \
-               (item)->next    = (list); \
-               (list)->prev    = (item); \
-               (list)          = (item); \
-       } \
-} while (0)
-
-#define SWRAP_DLIST_ADD(list, item) do { \
-       SWRAP_LOCK(list); \
-       DLIST_ADD(list, item); \
-       SWRAP_UNLOCK(list); \
-} while (0)
-
-#define DLIST_REMOVE(list, item) do { \
-       if ((list) == (item)) { \
-               (list)          = (item)->next; \
-               if (list) { \
-                       (list)->prev    = NULL; \
-               } \
-       } else { \
-               if ((item)->prev) { \
-                       (item)->prev->next      = (item)->next; \
-               } \
-               if ((item)->next) { \
-                       (item)->next->prev      = (item)->prev; \
-               } \
-       } \
-       (item)->prev    = NULL; \
-       (item)->next    = NULL; \
-} while (0)
-
-#define SWRAP_DLIST_REMOVE(list,item) do { \
-       SWRAP_LOCK(list); \
-       DLIST_REMOVE(list, item); \
-       SWRAP_UNLOCK(list); \
-} while (0)
-
-#define DLIST_ADD_AFTER(list, item, el) do { \
-       if ((list) == NULL || (el) == NULL) { \
-               DLIST_ADD(list, item); \
-       } else { \
-               (item)->prev = (el); \
-               (item)->next = (el)->next; \
-               (el)->next = (item); \
-               if ((item)->next != NULL) { \
-                       (item)->next->prev = (item); \
-               } \
-       } \
-} while (0)
-
-#define SWRAP_DLIST_ADD_AFTER(list, item, el) do { \
-       SWRAP_LOCK(list); \
-       DLIST_ADD_AFTER(list, item, el); \
-       SWRAP_UNLOCK(list); \
-} while (0)
-
 #if defined(HAVE_GETTIMEOFDAY_TZ) || defined(HAVE_GETTIMEOFDAY_TZ_VOID)
 #define swrapGetTimeOfDay(tval) gettimeofday(tval,NULL)
 #else
@@ -288,7 +223,6 @@ enum swrap_dbglvl_e {
 
 #define SOCKET_MAX_SOCKETS 1024
 
-
 /*
  * Maximum number of socket_info structures that can
  * be used. Can be overriden by the environment variable
@@ -296,7 +230,7 @@ enum swrap_dbglvl_e {
  */
 #define SOCKET_WRAPPER_MAX_SOCKETS_DEFAULT 65535
 
-#define SOCKET_WRAPPER_MAX_SOCKETS_LIMIT 256000
+#define SOCKET_WRAPPER_MAX_SOCKETS_LIMIT 262140
 
 /* This limit is to avoid broadcast sendto() needing to stat too many
  * files.  It may be raised (with a performance cost) to up to 254
@@ -316,17 +250,6 @@ struct swrap_address {
        } sa;
 };
 
-struct socket_info_fd {
-       struct socket_info_fd *prev, *next;
-       int fd;
-
-       /*
-        * Points to corresponding index in array of
-        * socket_info structures
-        */
-       int si_index;
-};
-
 int first_free;
 
 struct socket_info
@@ -369,37 +292,39 @@ struct socket_info_container
 };
 
 static struct socket_info_container *sockets;
-static size_t max_sockets = 0;
+
+static size_t socket_info_max = 0;
 
 /*
- * While socket file descriptors are passed among different processes, the
- * numerical value gets changed. So its better to store it locally to each
- * process rather than including it within socket_info which will be shared.
+ * Allocate the socket array always on the limit value. We want it to be
+ * at least bigger than the default so if we reach the limit we can
+ * still deal with duplicate fds pointing to the same socket_info.
  */
-static struct socket_info_fd *socket_fds;
+static size_t socket_fds_max = SOCKET_WRAPPER_MAX_SOCKETS_LIMIT;
+
+/* Hash table to map fds to corresponding socket_info index */
+static int *socket_fds_idx;
 
-/* The mutex for accessing the global libc.symbols */
+/* Mutex to synchronize access to global libc.symbols */
 static pthread_mutex_t libc_symbol_binding_mutex = PTHREAD_MUTEX_INITIALIZER;
 
-/* The mutex for syncronizing the port selection during swrap_auto_bind() */
-static pthread_mutex_t autobind_start_mutex = PTHREAD_MUTEX_INITIALIZER;
+/* Mutex for syncronizing port selection during swrap_auto_bind() */
+static pthread_mutex_t autobind_start_mutex;
 
-/*
- * Global mutex to guard the initialization of array of socket_info structures.
- */
-static pthread_mutex_t sockets_mutex = PTHREAD_MUTEX_INITIALIZER;
+/* Mutex to guard the initialization of array of socket_info structures */
+static pthread_mutex_t sockets_mutex;
 
-/*
- * Global mutex to protect modification of the socket_fds linked
- * list structure by different threads within a process.
- */
-static pthread_mutex_t socket_fds_mutex = PTHREAD_MUTEX_INITIALIZER;
+/* Mutex to guard the socket reset in swrap_close() and swrap_remove_stale() */
+static pthread_mutex_t socket_reset_mutex;
 
-/*
- * Global mutex to synchronize the query for first free index in array of
- * socket_info structures by different threads within a process.
- */
-static pthread_mutex_t first_free_mutex = PTHREAD_MUTEX_INITIALIZER;
+/* Mutex to synchronize access to first free index in socket_info array */
+static pthread_mutex_t first_free_mutex;
+
+/* Mutex to synchronize access to packet capture dump file */
+static pthread_mutex_t pcap_dump_mutex;
+
+/* Mutex for synchronizing mtu value fetch*/
+static pthread_mutex_t mtu_update_mutex;
 
 /* Function prototypes */
 
@@ -408,6 +333,19 @@ bool socket_wrapper_enabled(void);
 void swrap_constructor(void) CONSTRUCTOR_ATTRIBUTE;
 void swrap_destructor(void) DESTRUCTOR_ATTRIBUTE;
 
+#ifndef HAVE_GETPROGNAME
+static const char *getprogname(void)
+{
+#if defined(HAVE_PROGRAM_INVOCATION_SHORT_NAME)
+       return program_invocation_short_name;
+#elif defined(HAVE_GETEXECNAME)
+       return getexecname();
+#else
+       return NULL;
+#endif /* HAVE_PROGRAM_INVOCATION_SHORT_NAME */
+}
+#endif /* HAVE_GETPROGNAME */
+
 static void swrap_log(enum swrap_dbglvl_e dbglvl, const char *func, const char *format, ...) PRINTF_ATTRIBUTE(3, 4);
 # define SWRAP_LOG(dbglvl, ...) swrap_log((dbglvl), __func__, __VA_ARGS__)
 
@@ -420,6 +358,7 @@ static void swrap_log(enum swrap_dbglvl_e dbglvl,
        const char *d;
        unsigned int lvl = 0;
        const char *prefix = "SWRAP";
+       const char *progname = getprogname();
 
        d = getenv("SOCKET_WRAPPER_DEBUGLEVEL");
        if (d != NULL) {
@@ -449,9 +388,17 @@ static void swrap_log(enum swrap_dbglvl_e dbglvl,
                        break;
        }
 
+       if (progname == NULL) {
+               progname = "<unknown>";
+       }
+
        fprintf(stderr,
-               "%s(%d) - %s: %s\n",
-               prefix, (int)getpid(), func, buffer);
+               "%s[%s (%u)] - %s: %s\n",
+               prefix,
+               progname,
+               (unsigned int)getpid(),
+               func,
+               buffer);
 }
 
 /*********************************************************
@@ -608,7 +555,7 @@ struct swrap {
 static struct swrap swrap;
 
 /* prototypes */
-static const char *socket_wrapper_dir(void);
+static char *socket_wrapper_dir(void);
 
 #define LIBC_NAME "libc.so"
 
@@ -640,12 +587,29 @@ static void *swrap_load_lib_handle(enum swrap_lib lib)
        int i;
 
 #ifdef RTLD_DEEPBIND
-       flags |= RTLD_DEEPBIND;
+       const char *env_preload = getenv("LD_PRELOAD");
+       const char *env_deepbind = getenv("SOCKET_WRAPPER_DISABLE_DEEPBIND");
+       bool enable_deepbind = true;
+
+       /* Don't do a deepbind if we run with libasan */
+       if (env_preload != NULL && strlen(env_preload) < 1024) {
+               const char *p = strstr(env_preload, "libasan.so");
+               if (p != NULL) {
+                       enable_deepbind = false;
+               }
+       }
+
+       if (env_deepbind != NULL && strlen(env_deepbind) >= 1) {
+               enable_deepbind = false;
+       }
+
+       if (enable_deepbind) {
+               flags |= RTLD_DEEPBIND;
+       }
 #endif
 
        switch (lib) {
        case SWRAP_LIBNSL:
-               FALL_THROUGH;
        case SWRAP_LIBSOCKET:
 #ifdef HAVE_LIBSOCKET
                handle = swrap.libc.socket_handle;
@@ -664,7 +628,6 @@ static void *swrap_load_lib_handle(enum swrap_lib lib)
                }
                break;
 #endif
-               FALL_THROUGH;
        case SWRAP_LIBC:
                handle = swrap.libc.handle;
 #ifdef LIBC_SO
@@ -728,34 +691,62 @@ static void *_swrap_bind_symbol(enum swrap_lib lib, const char *fn_name)
        return func;
 }
 
+static void swrap_mutex_lock(pthread_mutex_t *mutex)
+{
+       int ret;
+
+       ret = pthread_mutex_lock(mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR, "Couldn't lock pthread mutex - %s",
+                         strerror(ret));
+       }
+}
+
+static void swrap_mutex_unlock(pthread_mutex_t *mutex)
+{
+       int ret;
+
+       ret = pthread_mutex_unlock(mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR, "Couldn't unlock pthread mutex - %s",
+                         strerror(ret));
+       }
+}
+
+/*
+ * These macros have a thread race condition on purpose!
+ *
+ * This is an optimization to avoid locking each time we check if the symbol is
+ * bound.
+ */
 #define swrap_bind_symbol_libc(sym_name) \
        if (swrap.libc.symbols._libc_##sym_name.obj == NULL) { \
-               SWRAP_LOCK(libc_symbol_binding); \
+               swrap_mutex_lock(&libc_symbol_binding_mutex); \
                if (swrap.libc.symbols._libc_##sym_name.obj == NULL) { \
                        swrap.libc.symbols._libc_##sym_name.obj = \
                                _swrap_bind_symbol(SWRAP_LIBC, #sym_name); \
                } \
-               SWRAP_UNLOCK(libc_symbol_binding); \
+               swrap_mutex_unlock(&libc_symbol_binding_mutex); \
        }
 
 #define swrap_bind_symbol_libsocket(sym_name) \
        if (swrap.libc.symbols._libc_##sym_name.obj == NULL) { \
-               SWRAP_LOCK(libc_symbol_binding); \
+               swrap_mutex_lock(&libc_symbol_binding_mutex); \
                if (swrap.libc.symbols._libc_##sym_name.obj == NULL) { \
                        swrap.libc.symbols._libc_##sym_name.obj = \
                                _swrap_bind_symbol(SWRAP_LIBSOCKET, #sym_name); \
                } \
-               SWRAP_UNLOCK(libc_symbol_binding); \
+               swrap_mutex_unlock(&libc_symbol_binding_mutex); \
        }
 
 #define swrap_bind_symbol_libnsl(sym_name) \
        if (swrap.libc.symbols._libc_##sym_name.obj == NULL) { \
-               SWRAP_LOCK(libc_symbol_binding); \
+               swrap_mutex_lock(&libc_symbol_binding_mutex); \
                if (swrap.libc.symbols._libc_##sym_name.obj == NULL) { \
                        swrap.libc.symbols._libc_##sym_name.obj = \
                                _swrap_bind_symbol(SWRAP_LIBNSL, #sym_name); \
                } \
-               SWRAP_UNLOCK(libc_symbol_binding); \
+               swrap_mutex_unlock(&libc_symbol_binding_mutex); \
        }
 
 /****************************************************************************
@@ -1291,19 +1282,25 @@ static void swrap_set_next_free(struct socket_info *si, int next_free)
        sic->meta.next_free = next_free;
 }
 
-static const char *socket_wrapper_dir(void)
+static char *socket_wrapper_dir(void)
 {
-       const char *s = getenv("SOCKET_WRAPPER_DIR");
+       char *swrap_dir = NULL;
+       char *s = getenv("SOCKET_WRAPPER_DIR");
+
        if (s == NULL) {
                return NULL;
        }
-       /* TODO use realpath(3) here, when we add support for threads */
-       if (strncmp(s, "./", 2) == 0) {
-               s += 2;
+
+       swrap_dir = realpath(s, NULL);
+       if (swrap_dir == NULL) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Unable to resolve socket_wrapper dir path: %s",
+                         strerror(errno));
+               return NULL;
        }
 
-       SWRAP_LOG(SWRAP_LOG_TRACE, "socket_wrapper_dir: %s", s);
-       return s;
+       SWRAP_LOG(SWRAP_LOG_TRACE, "socket_wrapper_dir: %s", swrap_dir);
+       return swrap_dir;
 }
 
 static unsigned int socket_wrapper_mtu(void)
@@ -1313,8 +1310,10 @@ static unsigned int socket_wrapper_mtu(void)
        const char *s;
        char *endp;
 
+       swrap_mutex_lock(&mtu_update_mutex);
+
        if (max_mtu != 0) {
-               return max_mtu;
+               goto done;
        }
 
        max_mtu = SOCKET_WRAPPER_MTU_DEFAULT;
@@ -1335,20 +1334,44 @@ static unsigned int socket_wrapper_mtu(void)
        max_mtu = tmp;
 
 done:
+       swrap_mutex_unlock(&mtu_update_mutex);
        return max_mtu;
 }
 
+static int socket_wrapper_init_mutex(pthread_mutex_t *m)
+{
+       pthread_mutexattr_t ma;
+       int ret;
+
+       ret = pthread_mutexattr_init(&ma);
+       if (ret != 0) {
+               return ret;
+       }
+
+       ret = pthread_mutexattr_settype(&ma, PTHREAD_MUTEX_ERRORCHECK);
+       if (ret != 0) {
+               goto done;
+       }
+
+       ret = pthread_mutex_init(m, &ma);
+
+done:
+       pthread_mutexattr_destroy(&ma);
+
+       return ret;
+}
+
 static size_t socket_wrapper_max_sockets(void)
 {
        const char *s;
-       unsigned long tmp;
+       size_t tmp;
        char *endp;
 
-       if (max_sockets != 0) {
-               return max_sockets;
+       if (socket_info_max != 0) {
+               return socket_info_max;
        }
 
-       max_sockets = SOCKET_WRAPPER_MAX_SOCKETS_DEFAULT;
+       socket_info_max = SOCKET_WRAPPER_MAX_SOCKETS_DEFAULT;
 
        s = getenv("SOCKET_WRAPPER_MAX_SOCKETS");
        if (s == NULL || s[0] == '\0') {
@@ -1359,29 +1382,68 @@ static size_t socket_wrapper_max_sockets(void)
        if (s == endp) {
                goto done;
        }
-       if (tmp == 0 || tmp > SOCKET_WRAPPER_MAX_SOCKETS_LIMIT) {
+       if (tmp == 0) {
+               tmp = SOCKET_WRAPPER_MAX_SOCKETS_DEFAULT;
                SWRAP_LOG(SWRAP_LOG_ERROR,
-                         "Invalid number of sockets specified, using default.");
-               goto done;
+                         "Invalid number of sockets specified, "
+                         "using default (%zu)",
+                         tmp);
+       }
+
+       if (tmp > SOCKET_WRAPPER_MAX_SOCKETS_LIMIT) {
+               tmp = SOCKET_WRAPPER_MAX_SOCKETS_LIMIT;
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Invalid number of sockets specified, "
+                         "using maximum (%zu).",
+                         tmp);
        }
 
-       max_sockets = tmp;
+       socket_info_max = tmp;
 
 done:
-       return max_sockets;
+       return socket_info_max;
+}
+
+static void socket_wrapper_init_fds_idx(void)
+{
+       int *tmp = NULL;
+       size_t i;
+
+       if (socket_fds_idx != NULL) {
+               return;
+       }
+
+       tmp = (int *)calloc(socket_fds_max, sizeof(int));
+       if (tmp == NULL) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Failed to allocate socket fds index array: %s",
+                         strerror(errno));
+               exit(-1);
+       }
+
+       for (i = 0; i < socket_fds_max; i++) {
+               tmp[i] = -1;
+       }
+
+       socket_fds_idx = tmp;
 }
 
 static void socket_wrapper_init_sockets(void)
 {
+       size_t max_sockets;
        size_t i;
+       int ret;
 
-       SWRAP_LOCK(sockets);
+       swrap_mutex_lock(&sockets_mutex);
 
        if (sockets != NULL) {
-               SWRAP_UNLOCK(sockets);
+               swrap_mutex_unlock(&sockets_mutex);
                return;
        }
 
+       socket_wrapper_init_fds_idx();
+
+       /* Needs to be called inside the sockets_mutex lock here. */
        max_sockets = socket_wrapper_max_sockets();
 
        sockets = (struct socket_info_container *)calloc(max_sockets,
@@ -1389,35 +1451,68 @@ static void socket_wrapper_init_sockets(void)
 
        if (sockets == NULL) {
                SWRAP_LOG(SWRAP_LOG_ERROR,
-                         "Failed to allocate sockets array.\n");
-               SWRAP_UNLOCK(sockets);
+                         "Failed to allocate sockets array: %s",
+                         strerror(errno));
+               swrap_mutex_unlock(&sockets_mutex);
                exit(-1);
        }
 
-       SWRAP_LOCK(first_free);
+       swrap_mutex_lock(&first_free_mutex);
 
        first_free = 0;
 
        for (i = 0; i < max_sockets; i++) {
                swrap_set_next_free(&sockets[i].info, i+1);
-               sockets[i].meta.mutex = (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER;
+               ret = socket_wrapper_init_mutex(&sockets[i].meta.mutex);
+               if (ret != 0) {
+                       SWRAP_LOG(SWRAP_LOG_ERROR,
+                                 "Failed to initialize pthread mutex");
+                       goto done;
+               }
        }
 
        /* mark the end of the free list */
        swrap_set_next_free(&sockets[max_sockets-1].info, -1);
 
-       SWRAP_UNLOCK(first_free);
-       SWRAP_UNLOCK(sockets);
+       ret = socket_wrapper_init_mutex(&autobind_start_mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Failed to initialize pthread mutex");
+               goto done;
+       }
+
+       ret = socket_wrapper_init_mutex(&pcap_dump_mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Failed to initialize pthread mutex");
+               goto done;
+       }
+
+       ret = socket_wrapper_init_mutex(&mtu_update_mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Failed to initialize pthread mutex");
+               goto done;
+       }
+
+done:
+       swrap_mutex_unlock(&first_free_mutex);
+       swrap_mutex_unlock(&sockets_mutex);
+       if (ret != 0) {
+               exit(-1);
+       }
 }
 
 bool socket_wrapper_enabled(void)
 {
-       const char *s = socket_wrapper_dir();
+       char *s = socket_wrapper_dir();
 
        if (s == NULL) {
                return false;
        }
 
+       SAFE_FREE(s);
+
        socket_wrapper_init_sockets();
 
        return true;
@@ -1438,6 +1533,54 @@ static unsigned int socket_wrapper_default_iface(void)
        return 1;/* 127.0.0.1 */
 }
 
+static void set_socket_info_index(int fd, int idx)
+{
+       socket_fds_idx[fd] = idx;
+       /* This builtin issues a full memory barrier. */
+       __sync_synchronize();
+}
+
+static void reset_socket_info_index(int fd)
+{
+       set_socket_info_index(fd, -1);
+}
+
+static int find_socket_info_index(int fd)
+{
+       if (fd < 0) {
+               return -1;
+       }
+
+       if (socket_fds_idx == NULL) {
+               return -1;
+       }
+
+       if ((size_t)fd >= socket_fds_max) {
+               /*
+                * Do not add a log here as some applications do stupid things
+                * like:
+                *
+                *     for (fd = 0; fd <= getdtablesize(); fd++) {
+                *         close(fd)
+                *     };
+                *
+                * This would produce millions of lines of debug messages.
+                */
+#if 0
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Looking for a socket info for the fd %d is over the "
+                         "max socket index limit of %zu.",
+                         fd,
+                         socket_fds_max);
+#endif
+               return -1;
+       }
+
+       /* This builtin issues a full memory barrier. */
+       __sync_synchronize();
+       return socket_fds_idx[fd];
+}
+
 static int swrap_add_socket_info(struct socket_info *si_input)
 {
        struct socket_info *si = NULL;
@@ -1448,7 +1591,7 @@ static int swrap_add_socket_info(struct socket_info *si_input)
                return -1;
        }
 
-       SWRAP_LOCK(first_free);
+       swrap_mutex_lock(&first_free_mutex);
        if (first_free == -1) {
                errno = ENFILE;
                goto out;
@@ -1466,32 +1609,30 @@ static int swrap_add_socket_info(struct socket_info *si_input)
        SWRAP_UNLOCK_SI(si);
 
 out:
-       SWRAP_UNLOCK(first_free);
+       swrap_mutex_unlock(&first_free_mutex);
 
        return si_index;
 }
 
 static int swrap_create_socket(struct socket_info *si, int fd)
 {
-       struct socket_info_fd *fi = NULL;
        int idx;
 
-       fi = (struct socket_info_fd *)calloc(1, sizeof(struct socket_info_fd));
-       if (fi == NULL) {
-               errno = ENOMEM;
+       if ((size_t)fd >= socket_fds_max) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "The max socket index limit of %zu has been reached, "
+                         "trying to add %d",
+                         socket_fds_max,
+                         fd);
                return -1;
        }
 
        idx = swrap_add_socket_info(si);
        if (idx == -1) {
-               free(fi);
                return -1;
        }
 
-       fi->fd = fd;
-       fi->si_index = idx;
-
-       SWRAP_DLIST_ADD(socket_fds, fi);
+       set_socket_info_index(fd, idx);
 
        return idx;
 }
@@ -1577,6 +1718,7 @@ static int convert_in_un_remote(struct socket_info *si, const struct sockaddr *i
        unsigned int prt;
        unsigned int iface;
        int is_bcast = 0;
+       char *swrap_dir = NULL;
 
        if (bcast) *bcast = 0;
 
@@ -1675,18 +1817,23 @@ static int convert_in_un_remote(struct socket_info *si, const struct sockaddr *i
                return -1;
        }
 
+       swrap_dir = socket_wrapper_dir();
+
        if (is_bcast) {
-               snprintf(un->sun_path, sizeof(un->sun_path), "%s/EINVAL",
-                        socket_wrapper_dir());
+               snprintf(un->sun_path, sizeof(un->sun_path),
+                        "%s/EINVAL", swrap_dir);
                SWRAP_LOG(SWRAP_LOG_DEBUG, "un path [%s]", un->sun_path);
+               SAFE_FREE(swrap_dir);
                /* the caller need to do more processing */
                return 0;
        }
 
        snprintf(un->sun_path, sizeof(un->sun_path), "%s/"SOCKET_FORMAT,
-                socket_wrapper_dir(), type, iface, prt);
+                swrap_dir, type, iface, prt);
        SWRAP_LOG(SWRAP_LOG_DEBUG, "un path [%s]", un->sun_path);
 
+       SAFE_FREE(swrap_dir);
+
        return 0;
 }
 
@@ -1698,6 +1845,7 @@ static int convert_in_un_alloc(struct socket_info *si, const struct sockaddr *in
        unsigned int iface;
        struct stat st;
        int is_bcast = 0;
+       char *swrap_dir = NULL;
 
        if (bcast) *bcast = 0;
 
@@ -1839,11 +1987,13 @@ static int convert_in_un_alloc(struct socket_info *si, const struct sockaddr *in
                return -1;
        }
 
+       swrap_dir = socket_wrapper_dir();
+
        if (prt == 0) {
                /* handle auto-allocation of ephemeral ports */
                for (prt = 5001; prt < 10000; prt++) {
                        snprintf(un->sun_path, sizeof(un->sun_path), "%s/"SOCKET_FORMAT,
-                                socket_wrapper_dir(), type, iface, prt);
+                                swrap_dir, type, iface, prt);
                        if (stat(un->sun_path, &st) == 0) continue;
 
                        set_port(si->family, prt, &si->myname);
@@ -1851,44 +2001,21 @@ static int convert_in_un_alloc(struct socket_info *si, const struct sockaddr *in
 
                        break;
                }
+
                if (prt == 10000) {
                        errno = ENFILE;
+                       SAFE_FREE(swrap_dir);
                        return -1;
                }
        }
 
        snprintf(un->sun_path, sizeof(un->sun_path), "%s/"SOCKET_FORMAT,
-                socket_wrapper_dir(), type, iface, prt);
+                swrap_dir, type, iface, prt);
        SWRAP_LOG(SWRAP_LOG_DEBUG, "un path [%s]", un->sun_path);
-       return 0;
-}
 
-static struct socket_info_fd *find_socket_info_fd(int fd)
-{
-       struct socket_info_fd *f;
-
-       SWRAP_LOCK(socket_fds);
-
-       for (f = socket_fds; f; f = f->next) {
-               if (f->fd == fd) {
-                       break;
-               }
-       }
+       SAFE_FREE(swrap_dir);
 
-       SWRAP_UNLOCK(socket_fds);
-
-       return f;
-}
-
-static int find_socket_info_index(int fd)
-{
-       struct socket_info_fd *fi = find_socket_info_fd(fd);
-
-       if (fi == NULL) {
-               return -1;
-       }
-
-       return fi->si_index;
+       return 0;
 }
 
 static struct socket_info *find_socket_info(int fd)
@@ -1915,7 +2042,7 @@ static bool check_addr_port_in_use(const struct sockaddr *sa, socklen_t len)
                        return false;
                }
                break;
-#if HAVE_IPV6
+#ifdef HAVE_IPV6
        case AF_INET6:
                if (len < sizeof(struct sockaddr_in6)) {
                        return false;
@@ -1962,7 +2089,7 @@ static bool check_addr_port_in_use(const struct sockaddr *sa, socklen_t len)
                        return true;
                        break;
                }
-#if HAVE_IPV6
+#ifdef HAVE_IPV6
                case AF_INET6: {
                        struct sockaddr_in6 *sin1, *sin2;
 
@@ -1996,31 +2123,28 @@ static bool check_addr_port_in_use(const struct sockaddr *sa, socklen_t len)
 
 static void swrap_remove_stale(int fd)
 {
-       struct socket_info_fd *fi = find_socket_info_fd(fd);
        struct socket_info *si;
        int si_index;
 
-       if (fi == NULL) {
+       SWRAP_LOG(SWRAP_LOG_TRACE, "remove stale wrapper for %d", fd);
+
+       swrap_mutex_lock(&socket_reset_mutex);
+
+       si_index = find_socket_info_index(fd);
+       if (si_index == -1) {
+               swrap_mutex_unlock(&socket_reset_mutex);
                return;
        }
 
-       SWRAP_LOG(SWRAP_LOG_TRACE, "remove stale wrapper for %d", fd);
-
-       si_index = fi->si_index;
+       reset_socket_info_index(fd);
 
        si = swrap_get_socket_info(si_index);
 
-       SWRAP_LOCK(first_free);
+       swrap_mutex_lock(&first_free_mutex);
        SWRAP_LOCK_SI(si);
 
-       SWRAP_DLIST_REMOVE(socket_fds, fi);
-
-       swrap_set_next_free(si, first_free);
-       first_free = si_index;
        swrap_dec_refcount(si);
 
-       free(fi);
-
        if (swrap_get_refcount(si) > 0) {
                goto out;
        }
@@ -2029,9 +2153,13 @@ static void swrap_remove_stale(int fd)
                unlink(si->un_addr.sun_path);
        }
 
+       swrap_set_next_free(si, first_free);
+       first_free = si_index;
+
 out:
        SWRAP_UNLOCK_SI(si);
-       SWRAP_UNLOCK(first_free);
+       swrap_mutex_unlock(&first_free_mutex);
+       swrap_mutex_unlock(&socket_reset_mutex);
 }
 
 static int sockaddr_convert_to_un(struct socket_info *si,
@@ -2333,14 +2461,20 @@ static uint8_t *swrap_pcap_packet_init(struct timeval *tval,
                                       int unreachable,
                                       size_t *_packet_len)
 {
-       uint8_t *base;
-       uint8_t *buf;
-       struct swrap_packet_frame *frame;
-       union swrap_packet_ip *ip;
+       uint8_t *base = NULL;
+       uint8_t *buf = NULL;
+       union {
+               uint8_t *ptr;
+               struct swrap_packet_frame *frame;
+       } f;
+       union {
+               uint8_t *ptr;
+               union swrap_packet_ip *ip;
+       } i;
        union swrap_packet_payload *pay;
        size_t packet_len;
        size_t alloc_len;
-       size_t nonwire_len = sizeof(*frame);
+       size_t nonwire_len = sizeof(struct swrap_packet_frame);
        size_t wire_hdr_len = 0;
        size_t wire_len = 0;
        size_t ip_hdr_len = 0;
@@ -2362,7 +2496,7 @@ static uint8_t *swrap_pcap_packet_init(struct timeval *tval,
                dest_in = (const struct sockaddr_in *)(const void *)dest;
                src_port = src_in->sin_port;
                dest_port = dest_in->sin_port;
-               ip_hdr_len = sizeof(ip->v4);
+               ip_hdr_len = sizeof(i.ip->v4);
                break;
 #ifdef HAVE_IPV6
        case AF_INET6:
@@ -2370,7 +2504,7 @@ static uint8_t *swrap_pcap_packet_init(struct timeval *tval,
                dest_in6 = (const struct sockaddr_in6 *)(const void *)dest;
                src_port = src_in6->sin6_port;
                dest_port = dest_in6->sin6_port;
-               ip_hdr_len = sizeof(ip->v6);
+               ip_hdr_len = sizeof(i.ip->v6);
                break;
 #endif
        default:
@@ -2411,7 +2545,6 @@ static uint8_t *swrap_pcap_packet_init(struct timeval *tval,
                if (wire_len > 64 ) {
                        icmp_truncate_len = wire_len - 64;
                }
-               wire_hdr_len += icmp_hdr_len;
                wire_len += icmp_hdr_len;
        }
 
@@ -2427,39 +2560,40 @@ static uint8_t *swrap_pcap_packet_init(struct timeval *tval,
        }
 
        buf = base;
+       f.ptr = buf;
+
+       f.frame->seconds                = tval->tv_sec;
+       f.frame->micro_seconds  = tval->tv_usec;
+       f.frame->recorded_length        = wire_len - icmp_truncate_len;
+       f.frame->full_length    = wire_len - icmp_truncate_len;
 
-       frame = (struct swrap_packet_frame *)(void *)buf;
-       frame->seconds          = tval->tv_sec;
-       frame->micro_seconds    = tval->tv_usec;
-       frame->recorded_length  = wire_len - icmp_truncate_len;
-       frame->full_length      = wire_len - icmp_truncate_len;
        buf += SWRAP_PACKET_FRAME_SIZE;
 
-       ip = (union swrap_packet_ip *)(void *)buf;
+       i.ptr = buf;
        switch (src->sa_family) {
        case AF_INET:
-               ip->v4.ver_hdrlen       = 0x45; /* version 4 and 5 * 32 bit words */
-               ip->v4.tos              = 0x00;
-               ip->v4.packet_length    = htons(wire_len - icmp_truncate_len);
-               ip->v4.identification   = htons(0xFFFF);
-               ip->v4.flags            = 0x40; /* BIT 1 set - means don't fragment */
-               ip->v4.fragment         = htons(0x0000);
-               ip->v4.ttl              = 0xFF;
-               ip->v4.protocol         = protocol;
-               ip->v4.hdr_checksum     = htons(0x0000);
-               ip->v4.src_addr         = src_in->sin_addr.s_addr;
-               ip->v4.dest_addr        = dest_in->sin_addr.s_addr;
+               i.ip->v4.ver_hdrlen     = 0x45; /* version 4 and 5 * 32 bit words */
+               i.ip->v4.tos            = 0x00;
+               i.ip->v4.packet_length  = htons(wire_len - icmp_truncate_len);
+               i.ip->v4.identification = htons(0xFFFF);
+               i.ip->v4.flags          = 0x40; /* BIT 1 set - means don't fragment */
+               i.ip->v4.fragment       = htons(0x0000);
+               i.ip->v4.ttl            = 0xFF;
+               i.ip->v4.protocol       = protocol;
+               i.ip->v4.hdr_checksum   = htons(0x0000);
+               i.ip->v4.src_addr       = src_in->sin_addr.s_addr;
+               i.ip->v4.dest_addr      = dest_in->sin_addr.s_addr;
                buf += SWRAP_PACKET_IP_V4_SIZE;
                break;
 #ifdef HAVE_IPV6
        case AF_INET6:
-               ip->v6.ver_prio         = 0x60; /* version 4 and 5 * 32 bit words */
-               ip->v6.flow_label_high  = 0x00;
-               ip->v6.flow_label_low   = 0x0000;
-               ip->v6.payload_length   = htons(wire_len - icmp_truncate_len); /* TODO */
-               ip->v6.next_header      = protocol;
-               memcpy(ip->v6.src_addr, src_in6->sin6_addr.s6_addr, 16);
-               memcpy(ip->v6.dest_addr, dest_in6->sin6_addr.s6_addr, 16);
+               i.ip->v6.ver_prio               = 0x60; /* version 4 and 5 * 32 bit words */
+               i.ip->v6.flow_label_high        = 0x00;
+               i.ip->v6.flow_label_low = 0x0000;
+               i.ip->v6.payload_length = htons(wire_len - icmp_truncate_len); /* TODO */
+               i.ip->v6.next_header    = protocol;
+               memcpy(i.ip->v6.src_addr, src_in6->sin6_addr.s6_addr, 16);
+               memcpy(i.ip->v6.dest_addr, dest_in6->sin6_addr.s6_addr, 16);
                buf += SWRAP_PACKET_IP_V6_SIZE;
                break;
 #endif
@@ -2473,21 +2607,23 @@ static uint8_t *swrap_pcap_packet_init(struct timeval *tval,
                        pay->icmp4.code         = 0x01; /* host unreachable */
                        pay->icmp4.checksum     = htons(0x0000);
                        pay->icmp4.unused       = htonl(0x00000000);
+
                        buf += SWRAP_PACKET_PAYLOAD_ICMP4_SIZE;
 
                        /* set the ip header in the ICMP payload */
-                       ip = (union swrap_packet_ip *)(void *)buf;
-                       ip->v4.ver_hdrlen       = 0x45; /* version 4 and 5 * 32 bit words */
-                       ip->v4.tos              = 0x00;
-                       ip->v4.packet_length    = htons(wire_len - icmp_hdr_len);
-                       ip->v4.identification   = htons(0xFFFF);
-                       ip->v4.flags            = 0x40; /* BIT 1 set - means don't fragment */
-                       ip->v4.fragment         = htons(0x0000);
-                       ip->v4.ttl              = 0xFF;
-                       ip->v4.protocol         = icmp_protocol;
-                       ip->v4.hdr_checksum     = htons(0x0000);
-                       ip->v4.src_addr         = dest_in->sin_addr.s_addr;
-                       ip->v4.dest_addr        = src_in->sin_addr.s_addr;
+                       i.ptr = buf;
+                       i.ip->v4.ver_hdrlen     = 0x45; /* version 4 and 5 * 32 bit words */
+                       i.ip->v4.tos            = 0x00;
+                       i.ip->v4.packet_length  = htons(wire_len - icmp_hdr_len);
+                       i.ip->v4.identification = htons(0xFFFF);
+                       i.ip->v4.flags          = 0x40; /* BIT 1 set - means don't fragment */
+                       i.ip->v4.fragment       = htons(0x0000);
+                       i.ip->v4.ttl            = 0xFF;
+                       i.ip->v4.protocol       = icmp_protocol;
+                       i.ip->v4.hdr_checksum   = htons(0x0000);
+                       i.ip->v4.src_addr       = dest_in->sin_addr.s_addr;
+                       i.ip->v4.dest_addr      = src_in->sin_addr.s_addr;
+
                        buf += SWRAP_PACKET_IP_V4_SIZE;
 
                        src_port = dest_in->sin_port;
@@ -2502,14 +2638,15 @@ static uint8_t *swrap_pcap_packet_init(struct timeval *tval,
                        buf += SWRAP_PACKET_PAYLOAD_ICMP6_SIZE;
 
                        /* set the ip header in the ICMP payload */
-                       ip = (union swrap_packet_ip *)(void *)buf;
-                       ip->v6.ver_prio         = 0x60; /* version 4 and 5 * 32 bit words */
-                       ip->v6.flow_label_high  = 0x00;
-                       ip->v6.flow_label_low   = 0x0000;
-                       ip->v6.payload_length   = htons(wire_len - icmp_truncate_len); /* TODO */
-                       ip->v6.next_header      = protocol;
-                       memcpy(ip->v6.src_addr, dest_in6->sin6_addr.s6_addr, 16);
-                       memcpy(ip->v6.dest_addr, src_in6->sin6_addr.s6_addr, 16);
+                       i.ptr = buf;
+                       i.ip->v6.ver_prio               = 0x60; /* version 4 and 5 * 32 bit words */
+                       i.ip->v6.flow_label_high        = 0x00;
+                       i.ip->v6.flow_label_low = 0x0000;
+                       i.ip->v6.payload_length = htons(wire_len - icmp_truncate_len); /* TODO */
+                       i.ip->v6.next_header    = protocol;
+                       memcpy(i.ip->v6.src_addr, dest_in6->sin6_addr.s6_addr, 16);
+                       memcpy(i.ip->v6.dest_addr, src_in6->sin6_addr.s6_addr, 16);
+
                        buf += SWRAP_PACKET_IP_V6_SIZE;
 
                        src_port = dest_in6->sin6_port;
@@ -2889,9 +3026,11 @@ static void swrap_pcap_dump_packet(struct socket_info *si,
        size_t packet_len = 0;
        int fd;
 
+       swrap_mutex_lock(&pcap_dump_mutex);
+
        file_name = swrap_pcap_init_file();
        if (!file_name) {
-               return;
+               goto done;
        }
 
        packet = swrap_pcap_marshall_packet(si,
@@ -2901,18 +3040,21 @@ static void swrap_pcap_dump_packet(struct socket_info *si,
                                            len,
                                            &packet_len);
        if (packet == NULL) {
-               return;
+               goto done;
        }
 
        fd = swrap_pcap_get_fd(file_name);
        if (fd != -1) {
                if (write(fd, packet, packet_len) != (ssize_t)packet_len) {
                        free(packet);
-                       return;
+                       goto done;
                }
        }
 
        free(packet);
+
+done:
+       swrap_mutex_unlock(&pcap_dump_mutex);
 }
 
 /****************************************************************************
@@ -3048,6 +3190,7 @@ static int swrap_socket(int family, int type, int protocol)
                memcpy(&si->myname.sa.in, &sin, si->myname.sa_socklen);
                break;
        }
+#ifdef HAVE_IPV6
        case AF_INET6: {
                struct sockaddr_in6 sin6 = {
                        .sin6_family = AF_INET6,
@@ -3057,6 +3200,7 @@ static int swrap_socket(int family, int type, int protocol)
                memcpy(&si->myname.sa.in6, &sin6, si->myname.sa_socklen);
                break;
        }
+#endif
        default:
                errno = EINVAL;
                return -1;
@@ -3068,9 +3212,10 @@ static int swrap_socket(int family, int type, int protocol)
        }
 
        SWRAP_LOG(SWRAP_LOG_TRACE,
-                 "Created %s socket for protocol %s",
+                 "Created %s socket for protocol %s, fd=%d",
                  family == AF_INET ? "IPv4" : "IPv6",
-                 real_type == SOCK_DGRAM ? "UDP" : "TCP");
+                 real_type == SOCK_DGRAM ? "UDP" : "TCP",
+                 fd);
 
        return fd;
 }
@@ -3340,8 +3485,9 @@ static int swrap_auto_bind(int fd, struct socket_info *si, int family)
        int ret;
        int port;
        struct stat st;
+       char *swrap_dir = NULL;
 
-       SWRAP_LOCK(autobind_start);
+       swrap_mutex_lock(&autobind_start_mutex);
 
        if (autobind_start_init != 1) {
                autobind_start_init = 1;
@@ -3425,11 +3571,13 @@ static int swrap_auto_bind(int fd, struct socket_info *si, int family)
                autobind_start = 10000;
        }
 
+       swrap_dir = socket_wrapper_dir();
+
        for (i = 0; i < SOCKET_MAX_SOCKETS; i++) {
                port = autobind_start + i;
                snprintf(un_addr.sa.un.sun_path, sizeof(un_addr.sa.un.sun_path),
-                        "%s/"SOCKET_FORMAT, socket_wrapper_dir(),
-                        type, socket_wrapper_default_iface(), port);
+                        "%s/"SOCKET_FORMAT, swrap_dir, type,
+                        socket_wrapper_default_iface(), port);
                if (stat(un_addr.sa.un.sun_path, &st) == 0) continue;
 
                ret = libc_bind(fd, &un_addr.sa.s, un_addr.sa_socklen);
@@ -3461,7 +3609,8 @@ static int swrap_auto_bind(int fd, struct socket_info *si, int family)
        ret = 0;
 
 done:
-       SWRAP_UNLOCK(autobind_start);
+       SAFE_FREE(swrap_dir);
+       swrap_mutex_unlock(&autobind_start_mutex);
        return ret;
 }
 
@@ -4646,6 +4795,11 @@ static ssize_t swrap_sendmsg_before(int fd,
                for (i = 0; i < (size_t)msg->msg_iovlen; i++) {
                        size_t nlen;
                        nlen = len + msg->msg_iov[i].iov_len;
+                       if (nlen < len) {
+                               /* overflow */
+                               errno = EMSGSIZE;
+                               goto out;
+                       }
                        if (nlen > mtu) {
                                break;
                        }
@@ -4701,13 +4855,14 @@ static ssize_t swrap_sendmsg_before(int fd,
                if (si->bound == 0) {
                        ret = swrap_auto_bind(fd, si, si->family);
                        if (ret == -1) {
+                               SWRAP_UNLOCK_SI(si);
                                if (errno == ENOTSOCK) {
                                        swrap_remove_stale(fd);
                                        ret = -ENOTSOCK;
                                } else {
                                        SWRAP_LOG(SWRAP_LOG_ERROR, "swrap_sendmsg_before failed");
                                }
-                               goto out;
+                               return ret;
                        }
                }
 
@@ -4911,6 +5066,7 @@ static int swrap_recvmsg_before(int fd,
                if (si->bound == 0) {
                        ret = swrap_auto_bind(fd, si, si->family);
                        if (ret == -1) {
+                               SWRAP_UNLOCK_SI(si);
                                /*
                                 * When attempting to read or write to a
                                 * descriptor, if an underlying autobind fails
@@ -4924,7 +5080,7 @@ static int swrap_recvmsg_before(int fd,
                                        SWRAP_LOG(SWRAP_LOG_ERROR,
                                                  "swrap_recvmsg_before failed");
                                }
-                               goto out;
+                               return ret;
                        }
                }
                break;
@@ -5190,7 +5346,7 @@ static ssize_t swrap_sendto(int s, const void *buf, size_t len, int flags,
        msg.msg_namelen = tolen;       /* size of address */
        msg.msg_iov = &tmp;            /* scatter/gather array */
        msg.msg_iovlen = 1;            /* # elements in msg_iov */
-#if HAVE_STRUCT_MSGHDR_MSG_CONTROL
+#ifdef HAVE_STRUCT_MSGHDR_MSG_CONTROL
        msg.msg_control = NULL;        /* ancillary data, see below */
        msg.msg_controllen = 0;        /* ancillary data buffer len */
        msg.msg_flags = 0;             /* flags on received message */
@@ -5216,14 +5372,16 @@ static ssize_t swrap_sendto(int s, const void *buf, size_t len, int flags,
                unsigned int iface;
                unsigned int prt = ntohs(((const struct sockaddr_in *)(const void *)to)->sin_port);
                char type;
+               char *swrap_dir = NULL;
 
                type = SOCKET_TYPE_CHAR_UDP;
 
+               swrap_dir = socket_wrapper_dir();
+
                for(iface=0; iface <= MAX_WRAPPED_INTERFACES; iface++) {
                        snprintf(un_addr.sa.un.sun_path,
                                 sizeof(un_addr.sa.un.sun_path),
-                                "%s/"SOCKET_FORMAT,
-                                socket_wrapper_dir(), type, iface, prt);
+                                "%s/"SOCKET_FORMAT, swrap_dir, type, iface, prt);
                        if (stat(un_addr.sa.un.sun_path, &st) != 0) continue;
 
                        /* ignore the any errors in broadcast sends */
@@ -5235,6 +5393,8 @@ static ssize_t swrap_sendto(int s, const void *buf, size_t len, int flags,
                                    un_addr.sa_socklen);
                }
 
+               SAFE_FREE(swrap_dir);
+
                SWRAP_LOCK_SI(si);
 
                swrap_pcap_dump_packet(si, to, SWRAP_SENDTO, buf, len);
@@ -5421,7 +5581,7 @@ static ssize_t swrap_write(int s, const void *buf, size_t len)
        msg.msg_namelen = 0;           /* size of address */
        msg.msg_iov = &tmp;            /* scatter/gather array */
        msg.msg_iovlen = 1;            /* # elements in msg_iov */
-#if HAVE_STRUCT_MSGHDR_MSG_CONTROL
+#ifdef HAVE_STRUCT_MSGHDR_MSG_CONTROL
        msg.msg_control = NULL;        /* ancillary data, see below */
        msg.msg_controllen = 0;        /* ancillary data buffer len */
        msg.msg_flags = 0;             /* flags on received message */
@@ -5472,7 +5632,7 @@ static ssize_t swrap_send(int s, const void *buf, size_t len, int flags)
        msg.msg_namelen = 0;           /* size of address */
        msg.msg_iov = &tmp;            /* scatter/gather array */
        msg.msg_iovlen = 1;            /* # elements in msg_iov */
-#if HAVE_STRUCT_MSGHDR_MSG_CONTROL
+#ifdef HAVE_STRUCT_MSGHDR_MSG_CONTROL
        msg.msg_control = NULL;        /* ancillary data, see below */
        msg.msg_controllen = 0;        /* ancillary data buffer len */
        msg.msg_flags = 0;             /* flags on received message */
@@ -5695,6 +5855,7 @@ static ssize_t swrap_sendmsg(int s, const struct msghdr *omsg, int flags)
                off_t ofs = 0;
                size_t avail = 0;
                size_t remain;
+               char *swrap_dir = NULL;
 
                for (i = 0; i < (size_t)msg.msg_iovlen; i++) {
                        avail += msg.msg_iov[i].iov_len;
@@ -5720,9 +5881,11 @@ static ssize_t swrap_sendmsg(int s, const struct msghdr *omsg, int flags)
 
                type = SOCKET_TYPE_CHAR_UDP;
 
+               swrap_dir = socket_wrapper_dir();
+
                for(iface=0; iface <= MAX_WRAPPED_INTERFACES; iface++) {
                        snprintf(un_addr.sun_path, sizeof(un_addr.sun_path), "%s/"SOCKET_FORMAT,
-                                socket_wrapper_dir(), type, iface, prt);
+                                swrap_dir, type, iface, prt);
                        if (stat(un_addr.sun_path, &st) != 0) continue;
 
                        msg.msg_name = &un_addr;           /* optional address */
@@ -5732,6 +5895,8 @@ static ssize_t swrap_sendmsg(int s, const struct msghdr *omsg, int flags)
                        libc_sendmsg(s, &msg, flags);
                }
 
+               SAFE_FREE(swrap_dir);
+
                SWRAP_LOCK_SI(si);
 
                swrap_pcap_dump_packet(si, to, SWRAP_SENDTO, buf, len);
@@ -5836,7 +6001,7 @@ static ssize_t swrap_writev(int s, const struct iovec *vector, int count)
        msg.msg_namelen = 0;           /* size of address */
        msg.msg_iov = discard_const_p(struct iovec, vector); /* scatter/gather array */
        msg.msg_iovlen = count;        /* # elements in msg_iov */
-#if HAVE_STRUCT_MSGHDR_MSG_CONTROL
+#ifdef HAVE_STRUCT_MSGHDR_MSG_CONTROL
        msg.msg_control = NULL;        /* ancillary data, see below */
        msg.msg_controllen = 0;        /* ancillary data buffer len */
        msg.msg_flags = 0;             /* flags on received message */
@@ -5868,32 +6033,29 @@ ssize_t writev(int s, const struct iovec *vector, int count)
 
 static int swrap_close(int fd)
 {
-       struct socket_info_fd *fi = find_socket_info_fd(fd);
        struct socket_info *si = NULL;
        int si_index;
        int ret;
 
-       if (fi == NULL) {
+       swrap_mutex_lock(&socket_reset_mutex);
+
+       si_index = find_socket_info_index(fd);
+       if (si_index == -1) {
+               swrap_mutex_unlock(&socket_reset_mutex);
                return libc_close(fd);
        }
 
-       si_index = fi->si_index;
+       reset_socket_info_index(fd);
+
        si = swrap_get_socket_info(si_index);
 
-       SWRAP_LOCK(first_free);
+       swrap_mutex_lock(&first_free_mutex);
        SWRAP_LOCK_SI(si);
 
-       SWRAP_DLIST_REMOVE(socket_fds, fi);
-
        ret = libc_close(fd);
 
-       swrap_set_next_free(si, first_free);
-       first_free = si_index;
-
        swrap_dec_refcount(si);
 
-       free(fi);
-
        if (swrap_get_refcount(si) > 0) {
                /* there are still references left */
                goto out;
@@ -5912,9 +6074,13 @@ static int swrap_close(int fd)
                unlink(si->un_addr.sun_path);
        }
 
+       swrap_set_next_free(si, first_free);
+       first_free = si_index;
+
 out:
        SWRAP_UNLOCK_SI(si);
-       SWRAP_UNLOCK(first_free);
+       swrap_mutex_unlock(&first_free_mutex);
+       swrap_mutex_unlock(&socket_reset_mutex);
 
        return ret;
 }
@@ -5931,25 +6097,18 @@ int close(int fd)
 static int swrap_dup(int fd)
 {
        struct socket_info *si;
-       struct socket_info_fd *src_fi, *fi;
+       int dup_fd, idx;
 
-       src_fi = find_socket_info_fd(fd);
-       if (src_fi == NULL) {
+       idx = find_socket_info_index(fd);
+       if (idx == -1) {
                return libc_dup(fd);
        }
 
-       si = swrap_get_socket_info(src_fi->si_index);
-
-       fi = (struct socket_info_fd *)calloc(1, sizeof(struct socket_info_fd));
-       if (fi == NULL) {
-               errno = ENOMEM;
-               return -1;
-       }
+       si = swrap_get_socket_info(idx);
 
-       fi->fd = libc_dup(fd);
-       if (fi->fd == -1) {
+       dup_fd = libc_dup(fd);
+       if (dup_fd == -1) {
                int saved_errno = errno;
-               free(fi);
                errno = saved_errno;
                return -1;
        }
@@ -5957,15 +6116,15 @@ static int swrap_dup(int fd)
        SWRAP_LOCK_SI(si);
 
        swrap_inc_refcount(si);
-       fi->si_index = src_fi->si_index;
 
        SWRAP_UNLOCK_SI(si);
 
        /* Make sure we don't have an entry for the fd */
-       swrap_remove_stale(fi->fd);
+       swrap_remove_stale(dup_fd);
 
-       SWRAP_DLIST_ADD_AFTER(socket_fds, fi, src_fi);
-       return fi->fd;
+       set_socket_info_index(dup_fd, idx);
+
+       return dup_fd;
 }
 
 int dup(int fd)
@@ -5980,14 +6139,14 @@ int dup(int fd)
 static int swrap_dup2(int fd, int newfd)
 {
        struct socket_info *si;
-       struct socket_info_fd *src_fi, *fi;
+       int dup_fd, idx;
 
-       src_fi = find_socket_info_fd(fd);
-       if (src_fi == NULL) {
+       idx = find_socket_info_index(fd);
+       if (idx == -1) {
                return libc_dup2(fd, newfd);
        }
 
-       si = swrap_get_socket_info(src_fi->si_index);
+       si = swrap_get_socket_info(idx);
 
        if (fd == newfd) {
                /*
@@ -6005,16 +6164,9 @@ static int swrap_dup2(int fd, int newfd)
                swrap_close(newfd);
        }
 
-       fi = (struct socket_info_fd *)calloc(1, sizeof(struct socket_info_fd));
-       if (fi == NULL) {
-               errno = ENOMEM;
-               return -1;
-       }
-
-       fi->fd = libc_dup2(fd, newfd);
-       if (fi->fd == -1) {
+       dup_fd = libc_dup2(fd, newfd);
+       if (dup_fd == -1) {
                int saved_errno = errno;
-               free(fi);
                errno = saved_errno;
                return -1;
        }
@@ -6022,15 +6174,15 @@ static int swrap_dup2(int fd, int newfd)
        SWRAP_LOCK_SI(si);
 
        swrap_inc_refcount(si);
-       fi->si_index = src_fi->si_index;
 
        SWRAP_UNLOCK_SI(si);
 
        /* Make sure we don't have an entry for the fd */
-       swrap_remove_stale(fi->fd);
+       swrap_remove_stale(dup_fd);
+
+       set_socket_info_index(dup_fd, idx);
 
-       SWRAP_DLIST_ADD_AFTER(socket_fds, fi, src_fi);
-       return fi->fd;
+       return dup_fd;
 }
 
 int dup2(int fd, int newfd)
@@ -6044,29 +6196,21 @@ int dup2(int fd, int newfd)
 
 static int swrap_vfcntl(int fd, int cmd, va_list va)
 {
-       struct socket_info_fd *src_fi, *fi;
        struct socket_info *si;
-       int rc;
+       int rc, dup_fd, idx;
 
-       src_fi = find_socket_info_fd(fd);
-       if (src_fi == NULL) {
+       idx = find_socket_info_index(fd);
+       if (idx == -1) {
                return libc_vfcntl(fd, cmd, va);
        }
 
-       si = swrap_get_socket_info(src_fi->si_index);
+       si = swrap_get_socket_info(idx);
 
        switch (cmd) {
        case F_DUPFD:
-               fi = (struct socket_info_fd *)calloc(1, sizeof(struct socket_info_fd));
-               if (fi == NULL) {
-                       errno = ENOMEM;
-                       return -1;
-               }
-
-               fi->fd = libc_vfcntl(fd, cmd, va);
-               if (fi->fd == -1) {
+               dup_fd = libc_vfcntl(fd, cmd, va);
+               if (dup_fd == -1) {
                        int saved_errno = errno;
-                       free(fi);
                        errno = saved_errno;
                        return -1;
                }
@@ -6074,16 +6218,15 @@ static int swrap_vfcntl(int fd, int cmd, va_list va)
                SWRAP_LOCK_SI(si);
 
                swrap_inc_refcount(si);
-               fi->si_index = src_fi->si_index;
 
                SWRAP_UNLOCK_SI(si);
 
                /* Make sure we don't have an entry for the fd */
-               swrap_remove_stale(fi->fd);
+               swrap_remove_stale(dup_fd);
 
-               SWRAP_DLIST_ADD_AFTER(socket_fds, fi, src_fi);
+               set_socket_info_index(dup_fd, idx);
 
-               rc = fi->fd;
+               rc = dup_fd;
                break;
        default:
                rc = libc_vfcntl(fd, cmd, va);
@@ -6173,6 +6316,8 @@ static void swrap_thread_child(void)
  ***************************/
 void swrap_constructor(void)
 {
+       int ret;
+
        /*
        * If we hold a lock and the application forks, then the child
        * is not able to unlock the mutex and we are in a deadlock.
@@ -6181,6 +6326,27 @@ void swrap_constructor(void)
        pthread_atfork(&swrap_thread_prepare,
                       &swrap_thread_parent,
                       &swrap_thread_child);
+
+       ret = socket_wrapper_init_mutex(&sockets_mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Failed to initialize pthread mutex");
+               exit(-1);
+       }
+
+       ret = socket_wrapper_init_mutex(&socket_reset_mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Failed to initialize pthread mutex");
+               exit(-1);
+       }
+
+       ret = socket_wrapper_init_mutex(&first_free_mutex);
+       if (ret != 0) {
+               SWRAP_LOG(SWRAP_LOG_ERROR,
+                         "Failed to initialize pthread mutex");
+               exit(-1);
+       }
 }
 
 /****************************
@@ -6193,14 +6359,18 @@ void swrap_constructor(void)
  */
 void swrap_destructor(void)
 {
-       struct socket_info_fd *s = socket_fds;
+       size_t i;
 
-       while (s != NULL) {
-               swrap_close(s->fd);
-               s = socket_fds;
+       if (socket_fds_idx != NULL) {
+               for (i = 0; i < socket_fds_max; ++i) {
+                       if (socket_fds_idx[i] != -1) {
+                               swrap_close(i);
+                       }
+               }
+               SAFE_FREE(socket_fds_idx);
        }
 
-       free(sockets);
+       SAFE_FREE(sockets);
 
        if (swrap.libc.handle != NULL) {
                dlclose(swrap.libc.handle);