s4: fix SD update and password change in upgrade script
[kamenim/samba.git] / source4 / libcli / ldap / ldap_controls.c
index 487ea61222ff0eb4cf81e352e0e5f5b1a3277d1f..0ea80a648e0e0533a287a819e3bf7ea6df8eb967 100644 (file)
 #include "libcli/ldap/ldap_proto.h"
 #include "dsdb/samdb/samdb.h"
 
-struct control_handler {
-       const char *oid;
-       bool (*decode)(void *mem_ctx, DATA_BLOB in, void *_out);
-       bool (*encode)(void *mem_ctx, void *in, DATA_BLOB *out);
-};
-
 static bool decode_server_sort_response(void *mem_ctx, DATA_BLOB in, void *_out)
 {
        void **out = (void **)_out;
@@ -132,9 +126,9 @@ static bool decode_server_sort_request(void *mem_ctx, DATA_BLOB in, void *_out)
                        }
                }
 
-               if (asn1_peek_tag(data, ASN1_BOOLEAN)) {
+               if (asn1_peek_tag(data, ASN1_CONTEXT_SIMPLE(1))) {
                        bool reverse;
-                       if (!asn1_read_BOOLEAN(data, &reverse)) {
+                       if (!asn1_read_BOOLEAN_context(data, &reverse, 1)) {
                        return false;
                        }
                        lssc[num]->reverse = reverse;
@@ -220,7 +214,7 @@ static bool decode_sd_flags_request(void *mem_ctx, DATA_BLOB in, void *_out)
                return false;
        }
 
-       if (!asn1_read_Integer(data, &(lsdfc->secinfo_flags))) {
+       if (!asn1_read_Integer(data, (int *) &(lsdfc->secinfo_flags))) {
                return false;
        }
 
@@ -254,7 +248,7 @@ static bool decode_search_options_request(void *mem_ctx, DATA_BLOB in, void *_ou
                return false;
        }
 
-       if (!asn1_read_Integer(data, &(lsoc->search_options))) {
+       if (!asn1_read_Integer(data, (int *) &(lsoc->search_options))) {
                return false;
        }
 
@@ -435,7 +429,6 @@ static bool decode_asq_control(void *mem_ctx, DATA_BLOB in, void *_out)
 
 static bool decode_domain_scope_request(void *mem_ctx, DATA_BLOB in, void *_out)
 {
-       void **out = (void **)_out;
        if (in.length != 0) {
                return false;
        }
@@ -445,7 +438,6 @@ static bool decode_domain_scope_request(void *mem_ctx, DATA_BLOB in, void *_out)
 
 static bool decode_notification_request(void *mem_ctx, DATA_BLOB in, void *_out)
 {
-       void **out = (void **)_out;
        if (in.length != 0) {
                return false;
        }
@@ -455,7 +447,24 @@ static bool decode_notification_request(void *mem_ctx, DATA_BLOB in, void *_out)
 
 static bool decode_show_deleted_request(void *mem_ctx, DATA_BLOB in, void *_out)
 {
-       void **out = (void **)_out;
+       if (in.length != 0) {
+               return false;
+       }
+
+       return true;
+}
+
+static bool decode_show_recycled_request(void *mem_ctx, DATA_BLOB in, void *_out)
+{
+       if (in.length != 0) {
+               return false;
+       }
+
+       return true;
+}
+
+static bool decode_show_deactivated_link_request(void *mem_ctx, DATA_BLOB in, void *_out)
+{
        if (in.length != 0) {
                return false;
        }
@@ -465,7 +474,6 @@ static bool decode_show_deleted_request(void *mem_ctx, DATA_BLOB in, void *_out)
 
 static bool decode_permissive_modify_request(void *mem_ctx, DATA_BLOB in, void *_out)
 {
-       void **out = (void **)_out;
        if (in.length != 0) {
                return false;
        }
@@ -475,7 +483,6 @@ static bool decode_permissive_modify_request(void *mem_ctx, DATA_BLOB in, void *
 
 static bool decode_manageDSAIT_request(void *mem_ctx, DATA_BLOB in, void *_out)
 {
-       void **out = (void **)_out;
        if (in.length != 0) {
                return false;
        }
@@ -699,6 +706,13 @@ static bool encode_server_sort_request(void *mem_ctx, void *in, DATA_BLOB *out)
                return false;
        }
 
+       /*
+         RFC2891 section 1.1:
+           SortKeyList ::= SEQUENCE OF SEQUENCE {
+             attributeType   AttributeDescription,
+             orderingRule    [0] MatchingRuleId OPTIONAL,
+             reverseOrder    [1] BOOLEAN DEFAULT FALSE }
+       */
        for (num = 0; lssc[num]; num++) {
                if (!asn1_push_tag(data, ASN1_SEQUENCE(0))) {
                        return false;
@@ -715,7 +729,7 @@ static bool encode_server_sort_request(void *mem_ctx, void *in, DATA_BLOB *out)
                }
 
                if (lssc[num]->reverse) {
-                       if (!asn1_write_BOOLEAN(data, lssc[num]->reverse)) {
+                       if (!asn1_write_BOOLEAN_context(data, lssc[num]->reverse, 1)) {
                                return false;
                        }
                }
@@ -965,6 +979,26 @@ static bool encode_show_deleted_request(void *mem_ctx, void *in, DATA_BLOB *out)
        return true;
 }
 
+static bool encode_show_recycled_request(void *mem_ctx, void *in, DATA_BLOB *out)
+{
+       if (in) {
+               return false;
+       }
+
+       *out = data_blob(NULL, 0);
+       return true;
+}
+
+static bool encode_show_deactivated_link_request(void *mem_ctx, void *in, DATA_BLOB *out)
+{
+       if (in) {
+               return false;
+       }
+
+       *out = data_blob(NULL, 0);
+       return true;
+}
+
 static bool encode_permissive_modify_request(void *mem_ctx, void *in, DATA_BLOB *out)
 {
        if (in) {
@@ -1149,6 +1183,7 @@ static bool encode_openldap_dereference(void *mem_ctx, void *in, DATA_BLOB *out)
 
 static bool decode_openldap_dereference(void *mem_ctx, DATA_BLOB in, void *_out)
 {
+       void **out = (void **)_out;
        struct asn1_data *data = asn1_init(mem_ctx);
        struct dsdb_openldap_dereference_result_control *control;
        struct dsdb_openldap_dereference_result **r = NULL;
@@ -1216,7 +1251,45 @@ static bool decode_openldap_dereference(void *mem_ctx, DATA_BLOB in, void *_out)
        return true;
 }
 
-struct control_handler ldap_known_controls[] = {
+static bool encode_relax_request(void *mem_ctx, void *in, DATA_BLOB *out)
+{
+       if (in) {
+               return false;
+       }
+
+       *out = data_blob(NULL, 0);
+       return true;
+}
+
+static bool decode_relax_request(void *mem_ctx, DATA_BLOB in, void *_out)
+{
+       if (in.length != 0) {
+               return false;
+       }
+
+       return true;
+}
+
+static bool encode_recalculate_sd_request(void *mem_ctx, void *in, DATA_BLOB *out)
+{
+       if (in) {
+               return false;
+       }
+
+       *out = data_blob(NULL, 0);
+       return true;
+}
+
+static bool decode_recalculate_sd_request(void *mem_ctx, DATA_BLOB in, void *_out)
+{
+       if (in.length != 0) {
+               return false;
+       }
+
+       return true;
+}
+
+static const struct ldap_control_handler ldap_known_controls[] = {
        { "1.2.840.113556.1.4.319", decode_paged_results_request, encode_paged_results_request },
        { "1.2.840.113556.1.4.529", decode_extended_dn_request, encode_extended_dn_request },
        { "1.2.840.113556.1.4.473", decode_server_sort_request, encode_server_sort_request },
@@ -1225,6 +1298,8 @@ struct control_handler ldap_known_controls[] = {
        { "1.2.840.113556.1.4.841", decode_dirsync_request, encode_dirsync_request },
        { "1.2.840.113556.1.4.528", decode_notification_request, encode_notification_request },
        { "1.2.840.113556.1.4.417", decode_show_deleted_request, encode_show_deleted_request },
+       { "1.2.840.113556.1.4.2064", decode_show_recycled_request, encode_show_recycled_request },
+       { "1.2.840.113556.1.4.2065", decode_show_deactivated_link_request, encode_show_deactivated_link_request },
        { "1.2.840.113556.1.4.1413", decode_permissive_modify_request, encode_permissive_modify_request },
        { "1.2.840.113556.1.4.801", decode_sd_flags_request, encode_sd_flags_request },
        { "1.2.840.113556.1.4.1339", decode_domain_scope_request, encode_domain_scope_request },
@@ -1236,125 +1311,14 @@ struct control_handler ldap_known_controls[] = {
        { "1.3.6.1.4.1.7165.4.3.2", NULL, NULL },
 /* DSDB_EXTENDED_REPLICATED_OBJECTS_OID is internal only, and has no network representation */
        { "1.3.6.1.4.1.7165.4.4.1", NULL, NULL },
+       { LDB_CONTROL_RECALCULATE_SD_OID,  decode_recalculate_sd_request, encode_recalculate_sd_request},
        { DSDB_OPENLDAP_DEREFERENCE_CONTROL, decode_openldap_dereference, encode_openldap_dereference},
+       { LDB_CONTROL_RELAX_OID, decode_relax_request, encode_relax_request },
        { NULL, NULL, NULL }
 };
 
-bool ldap_decode_control_value(void *mem_ctx, DATA_BLOB value, struct ldb_control *ctrl)
-{
-       int i;
-
-       for (i = 0; ldap_known_controls[i].oid != NULL; i++) {
-               if (strcmp(ldap_known_controls[i].oid, ctrl->oid) == 0) {
-                       if (!ldap_known_controls[i].decode || !ldap_known_controls[i].decode(mem_ctx, value, &ctrl->data)) {
-                               return false;
-                       }
-                       break;
-               }
-       }
-       if (ldap_known_controls[i].oid == NULL) {
-               return false;
-       }
-
-       return true;
-}
-
-bool ldap_decode_control_wrapper(void *mem_ctx, struct asn1_data *data, struct ldb_control *ctrl, DATA_BLOB *value)
+const struct ldap_control_handler *samba_ldap_control_handlers(void)
 {
-       DATA_BLOB oid;
-
-       if (!asn1_start_tag(data, ASN1_SEQUENCE(0))) {
-               return false;
-       }
-
-       if (!asn1_read_OctetString(data, mem_ctx, &oid)) {
-               return false;
-       }
-       ctrl->oid = talloc_strndup(mem_ctx, (char *)oid.data, oid.length);
-       if (!ctrl->oid) {
-               return false;
-       }
-
-       if (asn1_peek_tag(data, ASN1_BOOLEAN)) {
-               bool critical;
-               if (!asn1_read_BOOLEAN(data, &critical)) {
-                       return false;
-               }
-               ctrl->critical = critical;
-       } else {
-               ctrl->critical = false;
-       }
-
-       ctrl->data = NULL;
-
-       if (!asn1_peek_tag(data, ASN1_OCTET_STRING)) {
-               *value = data_blob(NULL, 0);
-               goto end_tag;
-       }
-
-       if (!asn1_read_OctetString(data, mem_ctx, value)) {
-               return false;
-       }
-
-end_tag:
-       if (!asn1_end_tag(data)) {
-               return false;
-       }
-
-       return true;
+       return ldap_known_controls;
 }
 
-bool ldap_encode_control(void *mem_ctx, struct asn1_data *data, struct ldb_control *ctrl)
-{
-       DATA_BLOB value;
-       int i;
-
-       for (i = 0; ldap_known_controls[i].oid != NULL; i++) {
-               if (strcmp(ldap_known_controls[i].oid, ctrl->oid) == 0) {
-                       if (!ldap_known_controls[i].encode) {
-                               if (ctrl->critical) {
-                                       return false;
-                               } else {
-                                       /* not encoding this control */
-                                       return true;
-                               }
-                       }
-                       if (!ldap_known_controls[i].encode(mem_ctx, ctrl->data, &value)) {
-                               return false;
-                       }
-                       break;
-               }
-       }
-       if (ldap_known_controls[i].oid == NULL) {
-               return false;
-       }
-
-       if (!asn1_push_tag(data, ASN1_SEQUENCE(0))) {
-               return false;
-       }
-
-       if (!asn1_write_OctetString(data, ctrl->oid, strlen(ctrl->oid))) {
-               return false;
-       }
-
-       if (ctrl->critical) {
-               if (!asn1_write_BOOLEAN(data, ctrl->critical)) {
-                       return false;
-               }
-       }
-
-       if (!ctrl->data) {
-               goto pop_tag;
-       }
-
-       if (!asn1_write_OctetString(data, value.data, value.length)) {
-               return false;
-       }
-
-pop_tag:
-       if (!asn1_pop_tag(data)) {
-               return false;
-       }
-
-       return true;
-}