dlist: remove unneeded type argument from DLIST_ADD_END()
[samba.git] / source4 / ldap_server / ldap_backend.c
index b180e0ed73783e99683b0a44813f7bfb4e32b01b..7efb7ed4521c13a3d706c338f55b52194a5219b5 100644 (file)
@@ -23,6 +23,7 @@
 #include "../lib/util/dlinklist.h"
 #include "auth/credentials/credentials.h"
 #include "auth/gensec/gensec.h"
+#include "auth/gensec/gensec_internal.h" /* TODO: remove this */
 #include "param/param.h"
 #include "smbd/service_stream.h"
 #include "dsdb/samdb/samdb.h"
@@ -169,12 +170,8 @@ static int map_ldb_error(TALLOC_CTX *mem_ctx, int ldb_err,
        }
 
        *errstring = talloc_asprintf(mem_ctx, "%08X: %s", W_ERROR_V(err),
-               ldb_strerror(ldb_err));
-       if (add_err_string != NULL) {
-               *errstring = talloc_asprintf(mem_ctx, "%s - %s", *errstring,
-                                            add_err_string);
-       }
-       
+               add_err_string != NULL ? add_err_string : ldb_strerror(ldb_err));
+
        /* result is 1:1 for now */
        return ldb_err;
 }
@@ -195,8 +192,8 @@ NTSTATUS ldapsrv_backend_Init(struct ldapsrv_connection *conn)
 
        if (conn->server_credentials) {
                char **sasl_mechs = NULL;
-               struct gensec_security_ops **backends = gensec_security_all();
-               struct gensec_security_ops **ops
+               const struct gensec_security_ops * const *backends = gensec_security_all();
+               const struct gensec_security_ops **ops
                        = gensec_use_kerberos_mechs(conn, backends, conn->server_credentials);
                unsigned int i, j = 0;
                for (i = 0; ops && ops[i]; i++) {
@@ -229,6 +226,9 @@ NTSTATUS ldapsrv_backend_Init(struct ldapsrv_connection *conn)
                ldb_set_opaque(conn->ldb, "supportedSASLMechanisms", sasl_mechs);
        }
 
+       ldb_set_opaque(conn->ldb, "remoteAddress",
+                      conn->connection->remote_address);
+
        return NT_STATUS_OK;
 }
 
@@ -255,7 +255,7 @@ struct ldapsrv_reply *ldapsrv_init_reply(struct ldapsrv_call *call, uint8_t type
 
 void ldapsrv_queue_reply(struct ldapsrv_call *call, struct ldapsrv_reply *reply)
 {
-       DLIST_ADD_END(call->replies, reply, struct ldapsrv_reply *);
+       DLIST_ADD_END(call->replies, reply);
 }
 
 static NTSTATUS ldapsrv_unwilling(struct ldapsrv_call *call, int error)
@@ -285,7 +285,7 @@ static NTSTATUS ldapsrv_unwilling(struct ldapsrv_call *call, int error)
 static int ldapsrv_add_with_controls(struct ldapsrv_call *call,
                                     const struct ldb_message *message,
                                     struct ldb_control **controls,
-                                    void *context)
+                                    struct ldb_result *res)
 {
        struct ldb_context *ldb = call->conn->ldb;
        struct ldb_request *req;
@@ -299,12 +299,17 @@ static int ldapsrv_add_with_controls(struct ldapsrv_call *call,
        ret = ldb_build_add_req(&req, ldb, ldb,
                                        message,
                                        controls,
-                                       context,
+                                       res,
                                        ldb_modify_default_callback,
                                        NULL);
 
        if (ret != LDB_SUCCESS) return ret;
 
+       if (call->conn->global_catalog) {
+               return ldb_error(ldb, LDB_ERR_UNWILLING_TO_PERFORM, "modify forbidden on global catalog port");
+       }
+       ldb_request_add_control(req, DSDB_CONTROL_NO_GLOBAL_CATALOG, false, NULL);
+
        ret = ldb_transaction_start(ldb);
        if (ret != LDB_SUCCESS) {
                return ret;
@@ -336,7 +341,7 @@ static int ldapsrv_add_with_controls(struct ldapsrv_call *call,
 static int ldapsrv_mod_with_controls(struct ldapsrv_call *call,
                                     const struct ldb_message *message,
                                     struct ldb_control **controls,
-                                    void *context)
+                                    struct ldb_result *res)
 {
        struct ldb_context *ldb = call->conn->ldb;
        struct ldb_request *req;
@@ -350,7 +355,7 @@ static int ldapsrv_mod_with_controls(struct ldapsrv_call *call,
        ret = ldb_build_mod_req(&req, ldb, ldb,
                                        message,
                                        controls,
-                                       context,
+                                       res,
                                        ldb_modify_default_callback,
                                        NULL);
 
@@ -358,6 +363,11 @@ static int ldapsrv_mod_with_controls(struct ldapsrv_call *call,
                return ret;
        }
 
+       if (call->conn->global_catalog) {
+               return ldb_error(ldb, LDB_ERR_UNWILLING_TO_PERFORM, "modify forbidden on global catalog port");
+       }
+       ldb_request_add_control(req, DSDB_CONTROL_NO_GLOBAL_CATALOG, false, NULL);
+
        ret = ldb_transaction_start(ldb);
        if (ret != LDB_SUCCESS) {
                return ret;
@@ -389,7 +399,7 @@ static int ldapsrv_mod_with_controls(struct ldapsrv_call *call,
 static int ldapsrv_del_with_controls(struct ldapsrv_call *call,
                                     struct ldb_dn *dn,
                                     struct ldb_control **controls,
-                                    void *context)
+                                    struct ldb_result *res)
 {
        struct ldb_context *ldb = call->conn->ldb;
        struct ldb_request *req;
@@ -398,12 +408,17 @@ static int ldapsrv_del_with_controls(struct ldapsrv_call *call,
        ret = ldb_build_del_req(&req, ldb, ldb,
                                        dn,
                                        controls,
-                                       context,
+                                       res,
                                        ldb_modify_default_callback,
                                        NULL);
 
        if (ret != LDB_SUCCESS) return ret;
 
+       if (call->conn->global_catalog) {
+               return ldb_error(ldb, LDB_ERR_UNWILLING_TO_PERFORM, "modify forbidden on global catalog port");
+       }
+       ldb_request_add_control(req, DSDB_CONTROL_NO_GLOBAL_CATALOG, false, NULL);
+
        ret = ldb_transaction_start(ldb);
        if (ret != LDB_SUCCESS) {
                return ret;
@@ -435,7 +450,7 @@ static int ldapsrv_rename_with_controls(struct ldapsrv_call *call,
                                        struct ldb_dn *olddn,
                                        struct ldb_dn *newdn,
                                        struct ldb_control **controls,
-                                       void *context)
+                                       struct ldb_result *res)
 {
        struct ldb_context *ldb = call->conn->ldb;
        struct ldb_request *req;
@@ -444,13 +459,18 @@ static int ldapsrv_rename_with_controls(struct ldapsrv_call *call,
        ret = ldb_build_rename_req(&req, ldb, ldb,
                                        olddn,
                                        newdn,
-                                       NULL,
-                                       context,
+                                       controls,
+                                       res,
                                        ldb_modify_default_callback,
                                        NULL);
 
        if (ret != LDB_SUCCESS) return ret;
 
+       if (call->conn->global_catalog) {
+               return ldb_error(ldb, LDB_ERR_UNWILLING_TO_PERFORM, "modify forbidden on global catalog port");
+       }
+       ldb_request_add_control(req, DSDB_CONTROL_NO_GLOBAL_CATALOG, false, NULL);
+
        ret = ldb_transaction_start(ldb);
        if (ret != LDB_SUCCESS) {
                return ret;
@@ -582,6 +602,8 @@ static NTSTATUS ldapsrv_SearchRequest(struct ldapsrv_call *call)
                        search_options->search_options = LDB_SEARCH_OPTION_PHANTOM_ROOT;
                        ldb_request_add_control(lreq, LDB_CONTROL_SEARCH_OPTIONS_OID, false, search_options);
                }
+       } else {
+               ldb_request_add_control(lreq, DSDB_CONTROL_NO_GLOBAL_CATALOG, false, NULL);
        }
 
        extended_dn_control = ldb_request_get_control(lreq, LDB_CONTROL_EXTENDED_DN_OID);
@@ -1144,6 +1166,9 @@ NTSTATUS ldapsrv_do_call(struct ldapsrv_call *call)
 {
        unsigned int i;
        struct ldap_message *msg = call->request;
+       struct ldb_context *samdb = call->conn->ldb;
+       NTSTATUS status;
+       time_t *lastts;
        /* Check for undecoded critical extensions */
        for (i=0; msg->controls && msg->controls[i]; i++) {
                if (!msg->controls_decoded[i] && 
@@ -1162,9 +1187,11 @@ NTSTATUS ldapsrv_do_call(struct ldapsrv_call *call)
        case LDAP_TAG_SearchRequest:
                return ldapsrv_SearchRequest(call);
        case LDAP_TAG_ModifyRequest:
-               return ldapsrv_ModifyRequest(call);
+               status = ldapsrv_ModifyRequest(call);
+               break;
        case LDAP_TAG_AddRequest:
-               return ldapsrv_AddRequest(call);
+               status = ldapsrv_AddRequest(call);
+               break;
        case LDAP_TAG_DelRequest:
                return ldapsrv_DelRequest(call);
        case LDAP_TAG_ModifyDNRequest:
@@ -1178,4 +1205,22 @@ NTSTATUS ldapsrv_do_call(struct ldapsrv_call *call)
        default:
                return ldapsrv_unwilling(call, LDAP_PROTOCOL_ERROR);
        }
+
+       if (NT_STATUS_IS_OK(status)) {
+               lastts = (time_t *)ldb_get_opaque(samdb, DSDB_OPAQUE_LAST_SCHEMA_UPDATE_MSG_OPAQUE_NAME);
+               if (lastts && !*lastts) {
+                       DEBUG(10, ("Schema update now was requested, "
+                               "fullfilling the request ts = %d\n",
+                               (int)*lastts));
+                       /*
+                       * Just requesting the schema will do the trick
+                       * as the delay for reload is experied, we will have a reload
+                       * from the schema as expected as we are not yet in a transaction!
+                       */
+                       dsdb_get_schema(samdb, NULL);
+                       *lastts = time(NULL);
+                       ldb_set_opaque(samdb, DSDB_OPAQUE_LAST_SCHEMA_UPDATE_MSG_OPAQUE_NAME, lastts);
+               }
+       }
+       return status;
 }