s4:kdc Only get the lp_ctx once for a LDB_fetch()
[samba.git] / source4 / kdc / hdb-samba4.c
index 818c4a12fda753c297bf00d268020a99e343df9d..367eee5f14be0fed79c173c1d733da3abca16afe 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 1999-2001, 2003, PADL Software Pty Ltd.
- * Copyright (c) 2004, Andrew Bartlett <abartlet@samba.org>.
+ * Copyright (c) 2004-2009, Andrew Bartlett <abartlet@samba.org>.
  * Copyright (c) 2004, Stefan Metzmacher <metze@samba.org>
  * All rights reserved.
  *
 #include "lib/ldb/include/ldb.h"
 #include "lib/ldb/include/ldb_errors.h"
 #include "librpc/gen_ndr/netlogon.h"
+#include "libcli/security/security.h"
 #include "auth/auth.h"
 #include "auth/credentials/credentials.h"
 #include "auth/auth_sam.h"
-#include "util/util_ldb.h"
+#include "../lib/util/util_ldb.h"
 #include "dsdb/samdb/samdb.h"
 #include "librpc/ndr/libndr.h"
 #include "librpc/gen_ndr/ndr_drsblobs.h"
@@ -62,12 +63,6 @@ enum trust_direction {
        OUTBOUND = LSA_TRUST_DIRECTION_OUTBOUND
 };
 
-static const char *realm_ref_attrs[] = {
-       "nCName", 
-       "dnsRoot", 
-       NULL
-};
-
 static const char *trust_attrs[] = {
        "trustPartner",
        "trustAuthIncoming",
@@ -186,9 +181,9 @@ static HDBFlags uf2HDBFlags(krb5_context context, int userAccountControl, enum h
        return flags;
 }
 
-static int hdb_ldb_destructor(struct hdb_ldb_private *private)
+static int hdb_ldb_destructor(struct hdb_ldb_private *p)
 {
-    hdb_entry_ex *entry_ex = private->entry_ex;
+    hdb_entry_ex *entry_ex = p->entry_ex;
     free_hdb_entry(&entry_ex->entry);
     return 0;
 }
@@ -277,34 +272,33 @@ static krb5_error_code LDB_message2entry_keys(krb5_context context,
        if (scpk) {
                DATA_BLOB blob;
 
-               blob = strhex_to_data_blob(scpk->data);
+               blob = strhex_to_data_blob(mem_ctx, scpk->data);
                if (!blob.data) {
                        ret = ENOMEM;
                        goto out;
                }
-               talloc_steal(mem_ctx, blob.data);
 
                /* we cannot use ndr_pull_struct_blob_all() here, as w2k and w2k3 add padding bytes */
                ndr_err = ndr_pull_struct_blob(&blob, mem_ctx, iconv_convenience, &_pkb,
                                               (ndr_pull_flags_fn_t)ndr_pull_package_PrimaryKerberosBlob);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-                       krb5_set_error_string(context, "LDB_message2entry_keys: could not parse package_PrimaryKerberosBlob");
-                       krb5_warnx(context, "LDB_message2entry_keys: could not parse package_PrimaryKerberosBlob");
                        ret = EINVAL;
+                       krb5_set_error_message(context, ret, "LDB_message2entry_keys: could not parse package_PrimaryKerberosBlob");
+                       krb5_warnx(context, "LDB_message2entry_keys: could not parse package_PrimaryKerberosBlob");
                        goto out;
                }
 
                if (newer_keys && _pkb.version != 4) {
-                       krb5_set_error_string(context, "LDB_message2entry_keys: Primary:Kerberos-Newer-Keys not version 4");
-                       krb5_warnx(context, "LDB_message2entry_keys: Primary:Kerberos-Newer-Keys not version 4");
                        ret = EINVAL;
+                       krb5_set_error_message(context, ret, "LDB_message2entry_keys: Primary:Kerberos-Newer-Keys not version 4");
+                       krb5_warnx(context, "LDB_message2entry_keys: Primary:Kerberos-Newer-Keys not version 4");
                        goto out;
                }
 
                if (!newer_keys && _pkb.version != 3) {
-                       krb5_set_error_string(context, "LDB_message2entry_keys: could not parse Primary:Kerberos not version 3");
-                       krb5_warnx(context, "LDB_message2entry_keys: could not parse Primary:Kerberos not version 3");
                        ret = EINVAL;
+                       krb5_set_error_message(context, ret, "LDB_message2entry_keys: could not parse Primary:Kerberos not version 3");
+                       krb5_warnx(context, "LDB_message2entry_keys: could not parse Primary:Kerberos not version 3");
                        goto out;
                }
 
@@ -491,33 +485,36 @@ out:
  * Construct an hdb_entry from a directory entry.
  */
 static krb5_error_code LDB_message2entry(krb5_context context, HDB *db, 
+                                        struct loadparm_context *lp_ctx, 
                                         TALLOC_CTX *mem_ctx, krb5_const_principal principal,
-                                        enum hdb_ldb_ent_type ent_type, 
+                                        enum hdb_ldb_ent_type ent_type,
+                                        struct ldb_dn *realm_dn,
                                         struct ldb_message *msg,
-                                        struct ldb_message *realm_ref_msg,
                                         hdb_entry_ex *entry_ex)
 {
        unsigned int userAccountControl;
        int i;
        krb5_error_code ret = 0;
        krb5_boolean is_computer = FALSE;
-       const char *dnsdomain = ldb_msg_find_attr_as_string(realm_ref_msg, "dnsRoot", NULL);
-       char *realm = strupper_talloc(mem_ctx, dnsdomain);
-       struct loadparm_context *lp_ctx = ldb_get_opaque((struct ldb_context *)db->hdb_db, "loadparm");
-       struct ldb_dn *domain_dn = samdb_result_dn((struct ldb_context *)db->hdb_db,
-                                                       mem_ctx,
-                                                       realm_ref_msg,
-                                                       "nCName",
-                                                       ldb_dn_new(mem_ctx, (struct ldb_context *)db->hdb_db, NULL));
-
-       struct hdb_ldb_private *private;
+       char *realm = strupper_talloc(mem_ctx, lp_realm(lp_ctx));
+
+       struct hdb_ldb_private *p;
        NTTIME acct_expiry;
+       NTSTATUS status;
 
+       uint32_t rid;
        struct ldb_message_element *objectclasses;
        struct ldb_val computer_val;
+       const char *samAccountName = ldb_msg_find_attr_as_string(msg, "samAccountName", NULL);
        computer_val.data = discard_const_p(uint8_t,"computer");
        computer_val.length = strlen((const char *)computer_val.data);
        
+       if (!samAccountName) {
+               ret = ENOENT;
+               krb5_set_error_message(context, ret, "LDB_message2entry: no samAccountName present");
+               goto out;
+       }
+
        objectclasses = ldb_msg_find_element(msg, "objectClass");
        
        if (objectclasses && ldb_msg_find_val(objectclasses, &computer_val)) {
@@ -527,24 +524,29 @@ static krb5_error_code LDB_message2entry(krb5_context context, HDB *db,
        memset(entry_ex, 0, sizeof(*entry_ex));
 
        if (!realm) {
-               krb5_set_error_string(context, "talloc_strdup: out of memory");
                ret = ENOMEM;
+               krb5_set_error_message(context, ret, "talloc_strdup: out of memory");
                goto out;
        }
                        
-       private = talloc(mem_ctx, struct hdb_ldb_private);
-       if (!private) {
+       p = talloc(mem_ctx, struct hdb_ldb_private);
+       if (!p) {
                ret = ENOMEM;
                goto out;
        }
 
-       private->entry_ex = entry_ex;
-       private->iconv_convenience = lp_iconv_convenience(lp_ctx);
-       private->netbios_name = lp_netbios_name(lp_ctx);
+       p->entry_ex = entry_ex;
+       p->iconv_convenience = lp_iconv_convenience(lp_ctx);
+       p->lp_ctx = lp_ctx;
+       p->realm_dn = talloc_reference(p, realm_dn);
+       if (!p->realm_dn) {
+               ret = ENOMEM;
+               goto out;
+       }
 
-       talloc_set_destructor(private, hdb_ldb_destructor);
+       talloc_set_destructor(p, hdb_ldb_destructor);
 
-       entry_ex->ctx = private;
+       entry_ex->ctx = p;
        entry_ex->free_entry = hdb_ldb_free_entry;
 
        userAccountControl = ldb_msg_find_attr_as_uint(msg, "userAccountControl", 0);
@@ -552,19 +554,11 @@ static krb5_error_code LDB_message2entry(krb5_context context, HDB *db,
        
        entry_ex->entry.principal = malloc(sizeof(*(entry_ex->entry.principal)));
        if (ent_type == HDB_SAMBA4_ENT_TYPE_ANY && principal == NULL) {
-               const char *samAccountName = ldb_msg_find_attr_as_string(msg, "samAccountName", NULL);
-               if (!samAccountName) {
-                       krb5_set_error_string(context, "LDB_message2entry: no samAccountName present");
-                       ret = ENOENT;
-                       goto out;
-               }
-               samAccountName = ldb_msg_find_attr_as_string(msg, "samAccountName", NULL);
                krb5_make_principal(context, &entry_ex->entry.principal, realm, samAccountName, NULL);
        } else {
-               char *strdup_realm;
                ret = copy_Principal(principal, entry_ex->entry.principal);
                if (ret) {
-                       krb5_clear_error_string(context);
+                       krb5_clear_error_message(context);
                        goto out;
                }
 
@@ -575,66 +569,94 @@ static krb5_error_code LDB_message2entry(krb5_context context, HDB *db,
                 * we determine from our records */
                
                /* this has to be with malloc() */
-               strdup_realm = strdup(realm);
-               if (!strdup_realm) {
-                       ret = ENOMEM;
-                       krb5_clear_error_string(context);
-                       goto out;
-               }
-               free(*krb5_princ_realm(context, entry_ex->entry.principal));
-               krb5_princ_set_realm(context, entry_ex->entry.principal, &strdup_realm);
+               krb5_principal_set_realm(context, entry_ex->entry.principal, realm);
        }
 
+       /* First try and figure out the flags based on the userAccountControl */
        entry_ex->entry.flags = uf2HDBFlags(context, userAccountControl, ent_type);
 
-       if (ent_type == HDB_SAMBA4_ENT_TYPE_KRBTGT) {
-               entry_ex->entry.flags.invalid = 0;
-               entry_ex->entry.flags.server = 1;
-               entry_ex->entry.flags.forwardable = 1;
-               entry_ex->entry.flags.ok_as_delegate = 1;
-       }
+       /* Windows 2008 seems to enforce this (very sensible) rule by
+        * default - don't allow offline attacks on a user's password
+        * by asking for a ticket to them as a service (encrypted with
+        * their probably patheticly insecure password) */
 
-       if (lp_parm_bool(lp_ctx, NULL, "kdc", "require spn for service", true)) {
+       if (entry_ex->entry.flags.server
+           && lp_parm_bool(lp_ctx, NULL, "kdc", "require spn for service", true)) {
                if (!is_computer && !ldb_msg_find_attr_as_string(msg, "servicePrincipalName", NULL)) {
                        entry_ex->entry.flags.server = 0;
                }
        }
 
-       /* use 'whenCreated' */
-       entry_ex->entry.created_by.time = ldb_msg_find_krb5time_ldap_time(msg, "whenCreated", 0);
-       /* use '???' */
-       entry_ex->entry.created_by.principal = NULL;
+       {
+               /* These (created_by, modified_by) parts of the entry are not relevant for Samba4's use
+                * of the Heimdal KDC.  They are stored in a the traditional
+                * DB for audit purposes, and still form part of the structure
+                * we must return */
+               
+               /* use 'whenCreated' */
+               entry_ex->entry.created_by.time = ldb_msg_find_krb5time_ldap_time(msg, "whenCreated", 0);
+               /* use '???' */
+               entry_ex->entry.created_by.principal = NULL;
+               
+               entry_ex->entry.modified_by = (Event *) malloc(sizeof(Event));
+               if (entry_ex->entry.modified_by == NULL) {
+                       ret = ENOMEM;
+                       krb5_set_error_message(context, ret, "malloc: out of memory");
+                       goto out;
+               }
+               
+               /* use 'whenChanged' */
+               entry_ex->entry.modified_by->time = ldb_msg_find_krb5time_ldap_time(msg, "whenChanged", 0);
+               /* use '???' */
+               entry_ex->entry.modified_by->principal = NULL;
+       }
 
-       entry_ex->entry.modified_by = (Event *) malloc(sizeof(Event));
-       if (entry_ex->entry.modified_by == NULL) {
-               krb5_set_error_string(context, "malloc: out of memory");
-               ret = ENOMEM;
+
+       /* The lack of password controls etc applies to krbtgt by
+        * virtue of being that particular RID */
+       status = dom_sid_split_rid(NULL, samdb_result_dom_sid(mem_ctx, msg, "objectSid"), NULL, &rid);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               ret = EINVAL;
                goto out;
        }
 
-       /* use 'whenChanged' */
-       entry_ex->entry.modified_by->time = ldb_msg_find_krb5time_ldap_time(msg, "whenChanged", 0);
-       /* use '???' */
-       entry_ex->entry.modified_by->principal = NULL;
+       if (rid == DOMAIN_RID_KRBTGT) {
+               entry_ex->entry.valid_end = NULL;
+               entry_ex->entry.pw_end = NULL;
 
-       entry_ex->entry.valid_start = NULL;
+               entry_ex->entry.flags.invalid = 0;
+               entry_ex->entry.flags.server = 1;
 
-       acct_expiry = samdb_result_account_expires(msg);
-       if (acct_expiry == 0x7FFFFFFFFFFFFFFFULL) {
-               entry_ex->entry.valid_end = NULL;
-       } else {
-               entry_ex->entry.valid_end = malloc(sizeof(*entry_ex->entry.valid_end));
-               if (entry_ex->entry.valid_end == NULL) {
-                       ret = ENOMEM;
-                       goto out;
+               /* Don't mark all requests for the krbtgt/realm as
+                * 'change password', as otherwise we could get into
+                * trouble, and not enforce the password expirty.
+                * Instead, only do it when request is for the kpasswd service */
+               if (ent_type == HDB_SAMBA4_ENT_TYPE_SERVER
+                   && principal->name.name_string.len == 2
+                   && (strcmp(principal->name.name_string.val[0], "kadmin") == 0)
+                   && (strcmp(principal->name.name_string.val[1], "changepw") == 0)
+                   && lp_is_my_domain_or_realm(lp_ctx, principal->realm)) {
+                       entry_ex->entry.flags.change_pw = 1;
                }
-               *entry_ex->entry.valid_end = nt_time_to_unix(acct_expiry);
-       }
+               entry_ex->entry.flags.client = 0;
+               entry_ex->entry.flags.forwardable = 1;
+               entry_ex->entry.flags.ok_as_delegate = 1;
+       } else if (entry_ex->entry.flags.server && ent_type == HDB_SAMBA4_ENT_TYPE_SERVER) {
+               /* The account/password expiry only applies when the account is used as a
+                * client (ie password login), not when used as a server */
+
+               /* Make very well sure we don't use this for a client,
+                * it could bypass the password restrictions */
+               entry_ex->entry.flags.client = 0;
+
+               entry_ex->entry.valid_end = NULL;
+               entry_ex->entry.pw_end = NULL;
 
-       if (ent_type != HDB_SAMBA4_ENT_TYPE_KRBTGT) {
+       } else {
                NTTIME must_change_time
                        = samdb_result_force_password_change((struct ldb_context *)db->hdb_db, mem_ctx, 
-                                                            domain_dn, msg);
+                                                            realm_dn, msg);
                if (must_change_time == 0x7FFFFFFFFFFFFFFFULL) {
                        entry_ex->entry.pw_end = NULL;
                } else {
@@ -645,10 +667,22 @@ static krb5_error_code LDB_message2entry(krb5_context context, HDB *db,
                        }
                        *entry_ex->entry.pw_end = nt_time_to_unix(must_change_time);
                }
-       } else {
-               entry_ex->entry.pw_end = NULL;
+
+               acct_expiry = samdb_result_account_expires(msg);
+               if (acct_expiry == 0x7FFFFFFFFFFFFFFFULL) {
+                       entry_ex->entry.valid_end = NULL;
+               } else {
+                       entry_ex->entry.valid_end = malloc(sizeof(*entry_ex->entry.valid_end));
+                       if (entry_ex->entry.valid_end == NULL) {
+                               ret = ENOMEM;
+                               goto out;
+                       }
+                       *entry_ex->entry.valid_end = nt_time_to_unix(acct_expiry);
+               }
        }
-                       
+
+       entry_ex->entry.valid_start = NULL;
+
        entry_ex->entry.max_life = NULL;
 
        entry_ex->entry.max_renew = NULL;
@@ -656,7 +690,7 @@ static krb5_error_code LDB_message2entry(krb5_context context, HDB *db,
        entry_ex->entry.generation = NULL;
 
        /* Get keys from the db */
-       ret = LDB_message2entry_keys(context, private->iconv_convenience, private, msg, userAccountControl, entry_ex);
+       ret = LDB_message2entry_keys(context, p->iconv_convenience, p, msg, userAccountControl, entry_ex);
        if (ret) {
                /* Could be bougus data in the entry, or out of memory */
                goto out;
@@ -664,14 +698,14 @@ static krb5_error_code LDB_message2entry(krb5_context context, HDB *db,
 
        entry_ex->entry.etypes = malloc(sizeof(*(entry_ex->entry.etypes)));
        if (entry_ex->entry.etypes == NULL) {
-               krb5_clear_error_string(context);
+               krb5_clear_error_message(context);
                ret = ENOMEM;
                goto out;
        }
        entry_ex->entry.etypes->len = entry_ex->entry.keys.len;
        entry_ex->entry.etypes->val = calloc(entry_ex->entry.etypes->len, sizeof(int));
        if (entry_ex->entry.etypes->val == NULL) {
-               krb5_clear_error_string(context);
+               krb5_clear_error_message(context);
                ret = ENOMEM;
                goto out;
        }
@@ -680,9 +714,8 @@ static krb5_error_code LDB_message2entry(krb5_context context, HDB *db,
        }
 
 
-       private->msg = talloc_steal(private, msg);
-       private->realm_ref_msg = talloc_steal(private, realm_ref_msg);
-       private->samdb = (struct ldb_context *)db->hdb_db;
+       p->msg = talloc_steal(p, msg);
+       p->samdb = (struct ldb_context *)db->hdb_db;
        
 out:
        if (ret != 0) {
@@ -702,36 +735,36 @@ static krb5_error_code LDB_trust_message2entry(krb5_context context, HDB *db,
                                               struct loadparm_context *lp_ctx,
                                               TALLOC_CTX *mem_ctx, krb5_const_principal principal,
                                               enum trust_direction direction,
+                                              struct ldb_dn *realm_dn,
                                               struct ldb_message *msg,
                                               hdb_entry_ex *entry_ex)
 {
        
        const char *dnsdomain;
        char *realm;
-       char *strdup_realm;
        DATA_BLOB password_utf16;
        struct samr_Password password_hash;
        const struct ldb_val *password_val;
        struct trustAuthInOutBlob password_blob;
-       struct hdb_ldb_private *private;
+       struct hdb_ldb_private *p;
 
        enum ndr_err_code ndr_err;
        int i, ret, trust_direction_flags;
-       uint32_t kvno;
 
-       private = talloc(mem_ctx, struct hdb_ldb_private);
-       if (!private) {
+       p = talloc(mem_ctx, struct hdb_ldb_private);
+       if (!p) {
                ret = ENOMEM;
                goto out;
        }
 
-       private->entry_ex = entry_ex;
-       private->iconv_convenience = lp_iconv_convenience(lp_ctx);
-       private->netbios_name = lp_netbios_name(lp_ctx);
+       p->entry_ex = entry_ex;
+       p->iconv_convenience = lp_iconv_convenience(lp_ctx);
+       p->lp_ctx = lp_ctx;
+       p->realm_dn = realm_dn;
 
-       talloc_set_destructor(private, hdb_ldb_destructor);
+       talloc_set_destructor(p, hdb_ldb_destructor);
 
-       entry_ex->ctx = private;
+       entry_ex->ctx = p;
        entry_ex->free_entry = hdb_ldb_free_entry;
 
        /* use 'whenCreated' */
@@ -758,13 +791,14 @@ static krb5_error_code LDB_trust_message2entry(krb5_context context, HDB *db,
                goto out;
        }
 
-       ndr_err = ndr_pull_struct_blob_all(password_val, mem_ctx, private->iconv_convenience, &password_blob,
+       ndr_err = ndr_pull_struct_blob(password_val, mem_ctx, p->iconv_convenience, &password_blob,
                                           (ndr_pull_flags_fn_t)ndr_pull_trustAuthInOutBlob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                ret = EINVAL;
                goto out;
        }
 
+       entry_ex->entry.kvno = -1;
        for (i=0; i < password_blob.count; i++) {
                if (password_blob.current->array[i].AuthType == TRUST_AUTH_TYPE_VERSION) {
                        entry_ex->entry.kvno = password_blob.current->array[i].AuthInfo.version.version;
@@ -813,9 +847,11 @@ static krb5_error_code LDB_trust_message2entry(krb5_context context, HDB *db,
                entry_ex->entry.keys.len++;
        }
                
+       entry_ex->entry.principal = malloc(sizeof(*(entry_ex->entry.principal)));
+
        ret = copy_Principal(principal, entry_ex->entry.principal);
        if (ret) {
-               krb5_clear_error_string(context);
+               krb5_clear_error_message(context);
                goto out;
        }
        
@@ -825,16 +861,7 @@ static krb5_error_code LDB_trust_message2entry(krb5_context context, HDB *db,
         * replace the client principal's realm with the one
         * we determine from our records */
        
-       /* this has to be with malloc() */
-       strdup_realm = strdup(realm);
-       if (!strdup_realm) {
-               ret = ENOMEM;
-               krb5_clear_error_string(context);
-               goto out;
-       }
-       free(*krb5_princ_realm(context, entry_ex->entry.principal));
-       krb5_princ_set_realm(context, entry_ex->entry.principal, &strdup_realm);
-       
+       krb5_principal_set_realm(context, entry_ex->entry.principal, realm);
        entry_ex->entry.flags = int2HDBFlags(0);
        entry_ex->entry.flags.immutable = 1;
        entry_ex->entry.flags.invalid = 0;
@@ -851,14 +878,14 @@ static krb5_error_code LDB_trust_message2entry(krb5_context context, HDB *db,
 
        entry_ex->entry.etypes = malloc(sizeof(*(entry_ex->entry.etypes)));
        if (entry_ex->entry.etypes == NULL) {
-               krb5_clear_error_string(context);
+               krb5_clear_error_message(context);
                ret = ENOMEM;
                goto out;
        }
        entry_ex->entry.etypes->len = entry_ex->entry.keys.len;
        entry_ex->entry.etypes->val = calloc(entry_ex->entry.etypes->len, sizeof(int));
        if (entry_ex->entry.etypes->val == NULL) {
-               krb5_clear_error_string(context);
+               krb5_clear_error_message(context);
                ret = ENOMEM;
                goto out;
        }
@@ -867,9 +894,8 @@ static krb5_error_code LDB_trust_message2entry(krb5_context context, HDB *db,
        }
 
 
-       private->msg = talloc_steal(private, msg);
-       private->realm_ref_msg = NULL;
-       private->samdb = (struct ldb_context *)db->hdb_db;
+       p->msg = talloc_steal(p, msg);
+       p->samdb = (struct ldb_context *)db->hdb_db;
        
 out:
        if (ret != 0) {
@@ -883,82 +909,14 @@ out:
 
 }
 
-static krb5_error_code LDB_lookup_principal(krb5_context context, struct ldb_context *ldb_ctx,                                         
-                                           TALLOC_CTX *mem_ctx,
-                                           krb5_const_principal principal,
-                                           enum hdb_ldb_ent_type ent_type,
-                                           struct ldb_dn *realm_dn,
-                                           struct ldb_message ***pmsg)
-{
-       krb5_error_code ret;
-       int lret;
-       char *filter = NULL;
-       const char * const *princ_attrs = user_attrs;
-
-       char *short_princ;
-       char *short_princ_talloc;
-
-       struct ldb_result *res = NULL;
-
-       ret = krb5_unparse_name_flags(context, principal,  KRB5_PRINCIPAL_UNPARSE_NO_REALM, &short_princ);
-
-       if (ret != 0) {
-               krb5_set_error_string(context, "LDB_lookup_principal: could not parse principal");
-               krb5_warnx(context, "LDB_lookup_principal: could not parse principal");
-               return ret;
-       }
-
-       short_princ_talloc = talloc_strdup(mem_ctx, short_princ);
-       free(short_princ);
-       if (!short_princ_talloc) {
-               krb5_set_error_string(context, "LDB_lookup_principal: talloc_strdup() failed!");
-               return ENOMEM;
-       }
-
-       switch (ent_type) {
-       case HDB_SAMBA4_ENT_TYPE_CLIENT:
-       case HDB_SAMBA4_ENT_TYPE_TRUST:
-       case HDB_SAMBA4_ENT_TYPE_ANY:
-               /* Can't happen */
-               return EINVAL;
-       case HDB_SAMBA4_ENT_TYPE_KRBTGT:
-               filter = talloc_asprintf(mem_ctx, "(&(objectClass=user)(samAccountName=%s))", 
-                                        KRB5_TGS_NAME);
-               break;
-       case HDB_SAMBA4_ENT_TYPE_SERVER:
-               filter = talloc_asprintf(mem_ctx, "(&(objectClass=user)(samAccountName=%s))", 
-                                        short_princ_talloc);
-               break;
-       }
-
-       if (!filter) {
-               krb5_set_error_string(context, "talloc_asprintf: out of memory");
-               return ENOMEM;
-       }
-
-       lret = ldb_search(ldb_ctx, mem_ctx, &res, realm_dn,
-                         LDB_SCOPE_SUBTREE, princ_attrs, "%s", filter);
-       if (lret != LDB_SUCCESS) {
-               DEBUG(3, ("Failed to search for %s: %s\n", filter, ldb_errstring(ldb_ctx)));
-               return HDB_ERR_NOENTRY;
-       } else if (res->count == 0 || res->count > 1) {
-               DEBUG(3, ("Failed find a single entry for %s: got %d\n", filter, res->count));
-               talloc_free(res);
-               return HDB_ERR_NOENTRY;
-       }
-       talloc_steal(mem_ctx, res->msgs);
-       *pmsg = res->msgs;
-       talloc_free(res);
-       return 0;
-}
-
 static krb5_error_code LDB_lookup_trust(krb5_context context, struct ldb_context *ldb_ctx,                                     
                                        TALLOC_CTX *mem_ctx,
                                        const char *realm,
                                        struct ldb_dn *realm_dn,
-                                       struct ldb_message ***pmsg)
+                                       struct ldb_message **pmsg)
 {
        int lret;
+       krb5_error_code ret;
        char *filter = NULL;
        const char * const *attrs = trust_attrs;
 
@@ -966,8 +924,9 @@ static krb5_error_code LDB_lookup_trust(krb5_context context, struct ldb_context
        filter = talloc_asprintf(mem_ctx, "(&(objectClass=trustedDomain)(|(flatname=%s)(trustPartner=%s)))", realm, realm);
 
        if (!filter) {
-               krb5_set_error_string(context, "talloc_asprintf: out of memory");
-               return ENOMEM;
+               ret = ENOMEM;
+               krb5_set_error_message(context, ret, "talloc_asprintf: out of memory");
+               return ret;
        }
 
        lret = ldb_search(ldb_ctx, mem_ctx, &res,
@@ -982,51 +941,18 @@ static krb5_error_code LDB_lookup_trust(krb5_context context, struct ldb_context
                return HDB_ERR_NOENTRY;
        }
        talloc_steal(mem_ctx, res->msgs);
-       *pmsg = res->msgs;
+       *pmsg = res->msgs[0];
        talloc_free(res);
        return 0;
 }
 
-static krb5_error_code LDB_lookup_realm(krb5_context context, struct ldb_context *ldb_ctx, 
-                                       TALLOC_CTX *mem_ctx,
-                                       const char *realm,
-                                       struct ldb_message ***pmsg)
-{
-       int ret;
-       struct ldb_result *cross_ref_res;
-       struct ldb_dn *partitions_basedn = samdb_partitions_dn(ldb_ctx, mem_ctx);
-
-       ret = ldb_search(ldb_ctx, mem_ctx, &cross_ref_res,
-                       partitions_basedn, LDB_SCOPE_SUBTREE, realm_ref_attrs,
-                       "(&(&(|(&(dnsRoot=%s)(nETBIOSName=*))(nETBIOSName=%s))(objectclass=crossRef))(ncName=*))",
-                       realm, realm);
-
-       if (ret != LDB_SUCCESS) {
-               DEBUG(3, ("Failed to search to lookup realm(%s): %s\n", realm, ldb_errstring(ldb_ctx)));
-               talloc_free(cross_ref_res);
-               return HDB_ERR_NOENTRY;
-       } else if (cross_ref_res->count == 0 || cross_ref_res->count > 1) {
-               DEBUG(3, ("Failed find a single entry for realm %s: got %d\n", realm, cross_ref_res->count));
-               talloc_free(cross_ref_res);
-               return HDB_ERR_NOENTRY;
-       }
-
-       if (pmsg) {
-               *pmsg = cross_ref_res->msgs;
-               talloc_steal(mem_ctx, cross_ref_res->msgs);
-       }
-       talloc_free(cross_ref_res);
-
-       return 0;
-}
-
-
 static krb5_error_code LDB_open(krb5_context context, HDB *db, int flags, mode_t mode)
 {
        if (db->hdb_master_key_set) {
+               krb5_error_code ret = HDB_ERR_NOENTRY;
                krb5_warnx(context, "LDB_open: use of a master key incompatible with LDB\n");
-               krb5_set_error_string(context, "LDB_open: use of a master key incompatible with LDB\n");
-               return HDB_ERR_NOENTRY;
+               krb5_set_error_message(context, ret, "LDB_open: use of a master key incompatible with LDB\n");
+               return ret;
        }               
 
        return 0;
@@ -1053,15 +979,16 @@ static krb5_error_code LDB_rename(krb5_context context, HDB *db, const char *new
 }
 
 static krb5_error_code LDB_fetch_client(krb5_context context, HDB *db, 
+                                       struct loadparm_context *lp_ctx, 
                                        TALLOC_CTX *mem_ctx, 
                                        krb5_const_principal principal,
                                        unsigned flags,
                                        hdb_entry_ex *entry_ex) {
        NTSTATUS nt_status;
        char *principal_string;
+       struct ldb_dn *realm_dn;
        krb5_error_code ret;
-       struct ldb_message **msg = NULL;
-       struct ldb_message **realm_ref_msg = NULL;
+       struct ldb_message *msg = NULL;
 
        ret = krb5_unparse_name(context, principal, &principal_string);
        
@@ -1071,7 +998,7 @@ static krb5_error_code LDB_fetch_client(krb5_context context, HDB *db,
        
        nt_status = sam_get_results_principal((struct ldb_context *)db->hdb_db,
                                              mem_ctx, principal_string, 
-                                             &msg, &realm_ref_msg);
+                                             &realm_dn, &msg);
        free(principal_string);
        if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_SUCH_USER)) {
                return HDB_ERR_NOENTRY;
@@ -1081,23 +1008,22 @@ static krb5_error_code LDB_fetch_client(krb5_context context, HDB *db,
                return EINVAL;
        }
        
-       ret = LDB_message2entry(context, db, mem_ctx, 
+       ret = LDB_message2entry(context, db, lp_ctx, mem_ctx, 
                                principal, HDB_SAMBA4_ENT_TYPE_CLIENT,
-                               msg[0], realm_ref_msg[0], entry_ex);
+                               realm_dn, msg, entry_ex);
        return ret;
 }
 
 static krb5_error_code LDB_fetch_krbtgt(krb5_context context, HDB *db, 
+                                       struct loadparm_context *lp_ctx, 
                                        TALLOC_CTX *mem_ctx, 
                                        krb5_const_principal principal,
                                        unsigned flags,
                                        hdb_entry_ex *entry_ex)
 {
        krb5_error_code ret;
-       struct ldb_message **msg = NULL;
-       struct ldb_message **realm_ref_msg_1 = NULL;
-       struct ldb_message **realm_ref_msg_2 = NULL;
-       struct ldb_dn *realm_dn;
+       struct ldb_message *msg = NULL;
+       struct ldb_dn *realm_dn = ldb_get_default_basedn(db->hdb_db);
        const char *realm;
 
        krb5_principal alloc_principal = NULL;
@@ -1109,21 +1035,36 @@ static krb5_error_code LDB_fetch_krbtgt(krb5_context context, HDB *db,
 
        /* krbtgt case.  Either us or a trusted realm */
 
-       if ((LDB_lookup_realm(context, (struct ldb_context *)db->hdb_db,
-                             mem_ctx, principal->realm, &realm_ref_msg_1) == 0)
-           && (LDB_lookup_realm(context, (struct ldb_context *)db->hdb_db,
-                                mem_ctx, principal->name.name_string.val[1], &realm_ref_msg_2) == 0)
-           && (ldb_dn_compare(realm_ref_msg_1[0]->dn, realm_ref_msg_1[0]->dn) == 0)) {
+       if (lp_is_my_domain_or_realm(lp_ctx, principal->realm)
+           && lp_is_my_domain_or_realm(lp_ctx, principal->name.name_string.val[1])) {
                /* us */                
                /* Cludge, cludge cludge.  If the realm part of krbtgt/realm,
                 * is in our db, then direct the caller at our primary
                 * krbtgt */
+
+               int lret;
+               char *realm_fixed;
+               const char * const *princ_attrs = user_attrs;
                
-               const char *dnsdomain = ldb_msg_find_attr_as_string(realm_ref_msg_1[0], "dnsRoot", NULL);
-               char *realm_fixed = strupper_talloc(mem_ctx, dnsdomain);
+               lret = gendb_search_single_extended_dn(db->hdb_db, mem_ctx, 
+                                                      realm_dn, LDB_SCOPE_SUBTREE,
+                                                      &msg, princ_attrs, 
+                                                      "(&(objectClass=user)(samAccountName=krbtgt))"); 
+               if (lret == LDB_ERR_NO_SUCH_OBJECT) {
+                       krb5_warnx(context, "LDB_fetch: could not find own KRBTGT in DB!");
+                       krb5_set_error_message(context, HDB_ERR_NOENTRY, "LDB_fetch: could not find own KRBTGT in DB!");
+                       return HDB_ERR_NOENTRY;
+               } else if (lret != LDB_SUCCESS) {
+                       krb5_warnx(context, "LDB_fetch: could not find own KRBTGT in DB: %s", ldb_errstring(db->hdb_db));
+                       krb5_set_error_message(context, HDB_ERR_NOENTRY, "LDB_fetch: could not find own KRBTGT in DB: %s", ldb_errstring(db->hdb_db));
+                       return HDB_ERR_NOENTRY;
+               }
+               
+               realm_fixed = strupper_talloc(mem_ctx, lp_realm(lp_ctx));
                if (!realm_fixed) {
-                       krb5_set_error_string(context, "strupper_talloc: out of memory");
-                       return ENOMEM;
+                       ret = ENOMEM;
+                       krb5_set_error_message(context, ret, "strupper_talloc: out of memory");
+                       return ret;
                }
                
                ret = krb5_copy_principal(context, principal, &alloc_principal);
@@ -1135,34 +1076,23 @@ static krb5_error_code LDB_fetch_krbtgt(krb5_context context, HDB *db,
                alloc_principal->name.name_string.val[1] = strdup(realm_fixed);
                talloc_free(realm_fixed);
                if (!alloc_principal->name.name_string.val[1]) {
-                       krb5_set_error_string(context, "LDB_fetch: strdup() failed!");
-                       return ENOMEM;
+                       ret = ENOMEM;
+                       krb5_set_error_message(context, ret, "LDB_fetch: strdup() failed!");
+                       return ret;
                }
                principal = alloc_principal;
-               realm_dn = samdb_result_dn((struct ldb_context *)db->hdb_db, mem_ctx, realm_ref_msg_1[0], "nCName", NULL);
-               
-               ret = LDB_lookup_principal(context, (struct ldb_context *)db->hdb_db, 
-                                          mem_ctx, 
-                                          principal, HDB_SAMBA4_ENT_TYPE_KRBTGT, realm_dn, &msg);
-               
-               if (ret != 0) {
-                       krb5_warnx(context, "LDB_fetch: could not find principal in DB");
-                       krb5_set_error_string(context, "LDB_fetch: could not find principal in DB");
-                       return ret;
-               }
-               
-               ret = LDB_message2entry(context, db, mem_ctx, 
+
+               ret = LDB_message2entry(context, db, lp_ctx, mem_ctx, 
                                        principal, HDB_SAMBA4_ENT_TYPE_KRBTGT, 
-                                       msg[0], realm_ref_msg_1[0], entry_ex);
+                                       realm_dn, msg, entry_ex);
                if (ret != 0) {
-                       krb5_warnx(context, "LDB_fetch: message2entry failed"); 
+                       krb5_warnx(context, "LDB_fetch: self krbtgt message2entry failed");     
                }
                return ret;
 
        } else {
                enum trust_direction direction = UNKNOWN;
 
-               struct loadparm_context *lp_ctx = talloc_get_type(ldb_get_opaque(db->hdb_db, "loadparm"), struct loadparm_context);
                /* Either an inbound or outbound trust */
 
                if (strcasecmp(lp_realm(lp_ctx), principal->realm) == 0) {
@@ -1185,15 +1115,15 @@ static krb5_error_code LDB_fetch_krbtgt(krb5_context context, HDB *db,
                
                if (ret != 0) {
                        krb5_warnx(context, "LDB_fetch: could not find principal in DB");
-                       krb5_set_error_string(context, "LDB_fetch: could not find principal in DB");
+                       krb5_set_error_message(context, ret, "LDB_fetch: could not find principal in DB");
                        return ret;
                }
                
                ret = LDB_trust_message2entry(context, db, lp_ctx, mem_ctx, 
                                              principal, direction, 
-                                             msg[0], entry_ex);
+                                             realm_dn, msg, entry_ex);
                if (ret != 0) {
-                       krb5_warnx(context, "LDB_fetch: message2entry failed"); 
+                       krb5_warnx(context, "LDB_fetch: trust_message2entry failed");   
                }
                return ret;
 
@@ -1205,6 +1135,7 @@ static krb5_error_code LDB_fetch_krbtgt(krb5_context context, HDB *db,
 }
 
 static krb5_error_code LDB_fetch_server(krb5_context context, HDB *db, 
+                                       struct loadparm_context *lp_ctx,
                                        TALLOC_CTX *mem_ctx, 
                                        krb5_const_principal principal,
                                        unsigned flags,
@@ -1212,14 +1143,13 @@ static krb5_error_code LDB_fetch_server(krb5_context context, HDB *db,
 {
        krb5_error_code ret;
        const char *realm;
-       struct ldb_message **msg = NULL;
-       struct ldb_message **realm_ref_msg = NULL;
-       struct ldb_dn *partitions_basedn = samdb_partitions_dn(db->hdb_db, mem_ctx);
+       struct ldb_message *msg = NULL;
+       struct ldb_dn *realm_dn;
        if (principal->name.name_string.len >= 2) {
                /* 'normal server' case */
                int ldb_ret;
                NTSTATUS nt_status;
-               struct ldb_dn *user_dn, *domain_dn;
+               struct ldb_dn *user_dn;
                char *principal_string;
                
                ret = krb5_unparse_name_flags(context, principal, 
@@ -1234,54 +1164,60 @@ static krb5_error_code LDB_fetch_server(krb5_context context, HDB *db,
                 * referral instead */
                nt_status = crack_service_principal_name((struct ldb_context *)db->hdb_db,
                                                         mem_ctx, principal_string, 
-                                                        &user_dn, &domain_dn);
+                                                        &user_dn, &realm_dn);
                free(principal_string);
                
                if (!NT_STATUS_IS_OK(nt_status)) {
                        return HDB_ERR_NOENTRY;
                }
                
-               ldb_ret = gendb_search_dn((struct ldb_context *)db->hdb_db,
-                                         mem_ctx, user_dn, &msg, user_attrs);
-               
-               if (ldb_ret != 1) {
-                       return HDB_ERR_NOENTRY;
-               }
-               
-               ldb_ret = gendb_search((struct ldb_context *)db->hdb_db,
-                                      mem_ctx, partitions_basedn, &realm_ref_msg, realm_ref_attrs, 
-                                      "ncName=%s", ldb_dn_get_linearized(domain_dn));
-               
-               if (ldb_ret != 1) {
+               ldb_ret = gendb_search_single_extended_dn((struct ldb_context *)db->hdb_db,
+                                                         mem_ctx, 
+                                                         user_dn, LDB_SCOPE_BASE,
+                                                         &msg, user_attrs,
+                                                         "(objectClass=*)");
+               if (ldb_ret != LDB_SUCCESS) {
                        return HDB_ERR_NOENTRY;
                }
                
        } else {
-               struct ldb_dn *realm_dn;
+               int lret;
+               char *filter = NULL;
+               const char * const *princ_attrs = user_attrs;
+               char *short_princ;
                /* server as client principal case, but we must not lookup userPrincipalNames */
-
+               realm_dn = ldb_get_default_basedn(db->hdb_db);
                realm = krb5_principal_get_realm(context, principal);
                
-               ret = LDB_lookup_realm(context, (struct ldb_context *)db->hdb_db, 
-                                      mem_ctx, realm, &realm_ref_msg);
-               if (ret != 0) {
-                       return HDB_ERR_NOENTRY;
-               }
-               
-               realm_dn = samdb_result_dn((struct ldb_context *)db->hdb_db, mem_ctx, realm_ref_msg[0], "nCName", NULL);
+               /* TODO: Check if it is our realm, otherwise give referall */
                
-               ret = LDB_lookup_principal(context, (struct ldb_context *)db->hdb_db, 
-                                          mem_ctx, 
-                                          principal, HDB_SAMBA4_ENT_TYPE_SERVER, realm_dn, &msg);
+               ret = krb5_unparse_name_flags(context, principal,  KRB5_PRINCIPAL_UNPARSE_NO_REALM, &short_princ);
                
                if (ret != 0) {
+                       krb5_set_error_message(context, ret, "LDB_lookup_principal: could not parse principal");
+                       krb5_warnx(context, "LDB_lookup_principal: could not parse principal");
                        return ret;
                }
+               
+               lret = gendb_search_single_extended_dn(db->hdb_db, mem_ctx, 
+                                                      realm_dn, LDB_SCOPE_SUBTREE,
+                                                      &msg, princ_attrs, "(&(objectClass=user)(samAccountName=%s))", 
+                                                      ldb_binary_encode_string(mem_ctx, short_princ));
+               free(short_princ);
+               if (lret == LDB_ERR_NO_SUCH_OBJECT) {
+                       DEBUG(3, ("Failed find a entry for %s\n", filter));
+                       return HDB_ERR_NOENTRY;
+               }
+               if (lret != LDB_SUCCESS) {
+                       DEBUG(3, ("Failed single search for for %s - %s\n", 
+                                 filter, ldb_errstring(db->hdb_db)));
+                       return HDB_ERR_NOENTRY;
+               }
        }
 
-       ret = LDB_message2entry(context, db, mem_ctx, 
+       ret = LDB_message2entry(context, db, lp_ctx, mem_ctx, 
                                principal, HDB_SAMBA4_ENT_TYPE_SERVER,
-                               msg[0], realm_ref_msg[0], entry_ex);
+                               realm_dn, msg, entry_ex);
        if (ret != 0) {
                krb5_warnx(context, "LDB_fetch: message2entry failed"); 
        }
@@ -1295,29 +1231,30 @@ static krb5_error_code LDB_fetch(krb5_context context, HDB *db,
                                 hdb_entry_ex *entry_ex)
 {
        krb5_error_code ret = HDB_ERR_NOENTRY;
-
        TALLOC_CTX *mem_ctx = talloc_named(db, 0, "LDB_fetch context");
+       struct loadparm_context *lp_ctx = talloc_get_type(ldb_get_opaque(db->hdb_db, "loadparm"), struct loadparm_context);
 
        if (!mem_ctx) {
-               krb5_set_error_string(context, "LDB_fetch: talloc_named() failed!");
-               return ENOMEM;
+               ret = ENOMEM;
+               krb5_set_error_message(context, ret, "LDB_fetch: talloc_named() failed!");
+               return ret;
        }
 
        if (flags & HDB_F_GET_CLIENT) {
-               ret = LDB_fetch_client(context, db, mem_ctx, principal, flags, entry_ex);
+               ret = LDB_fetch_client(context, db, lp_ctx, mem_ctx, principal, flags, entry_ex);
                if (ret != HDB_ERR_NOENTRY) goto done;
        }
        if (flags & HDB_F_GET_SERVER) {
                /* krbtgt fits into this situation for trusted realms, and for resolving different versions of our own realm name */
-               ret = LDB_fetch_krbtgt(context, db, mem_ctx, principal, flags, entry_ex);
+               ret = LDB_fetch_krbtgt(context, db, lp_ctx, mem_ctx, principal, flags, entry_ex);
                if (ret != HDB_ERR_NOENTRY) goto done;
 
                /* We return 'no entry' if it does not start with krbtgt/, so move to the common case quickly */
-               ret = LDB_fetch_server(context, db, mem_ctx, principal, flags, entry_ex);
+               ret = LDB_fetch_server(context, db, lp_ctx, mem_ctx, principal, flags, entry_ex);
                if (ret != HDB_ERR_NOENTRY) goto done;
        }
        if (flags & HDB_F_GET_KRBTGT) {
-               ret = LDB_fetch_krbtgt(context, db, mem_ctx, principal, flags, entry_ex);
+               ret = LDB_fetch_krbtgt(context, db, lp_ctx, mem_ctx, principal, flags, entry_ex);
                if (ret != HDB_ERR_NOENTRY) goto done;
        }
 
@@ -1338,10 +1275,11 @@ static krb5_error_code LDB_remove(krb5_context context, HDB *db, krb5_const_prin
 
 struct hdb_ldb_seq {
        struct ldb_context *ctx;
+       struct loadparm_context *lp_ctx;
        int index;
        int count;
        struct ldb_message **msgs;
-       struct ldb_message **realm_ref_msgs;
+       struct ldb_dn *realm_dn;
 };
 
 static krb5_error_code LDB_seq(krb5_context context, HDB *db, unsigned flags, hdb_entry_ex *entry)
@@ -1359,15 +1297,16 @@ static krb5_error_code LDB_seq(krb5_context context, HDB *db, unsigned flags, hd
        mem_ctx = talloc_named(priv, 0, "LDB_seq context");
 
        if (!mem_ctx) {
-               krb5_set_error_string(context, "LDB_seq: talloc_named() failed!");
-               return ENOMEM;
+               ret = ENOMEM;
+               krb5_set_error_message(context, ret, "LDB_seq: talloc_named() failed!");
+               return ret;
        }
 
        if (priv->index < priv->count) {
-               ret = LDB_message2entry(context, db, mem_ctx, 
+               ret = LDB_message2entry(context, db, priv->lp_ctx, 
+                                       mem_ctx, 
                                        NULL, HDB_SAMBA4_ENT_TYPE_ANY, 
-                                       priv->msgs[priv->index++], 
-                                       priv->realm_ref_msgs[0], entry);
+                                       priv->realm_dn, priv->msgs[priv->index++], entry);
        } else {
                ret = HDB_ERR_NOENTRY;
        }
@@ -1386,11 +1325,11 @@ static krb5_error_code LDB_firstkey(krb5_context context, HDB *db, unsigned flag
                                        hdb_entry_ex *entry)
 {
        struct ldb_context *ldb_ctx = (struct ldb_context *)db->hdb_db;
+       struct loadparm_context *lp_ctx = talloc_get_type(ldb_get_opaque(ldb_ctx, "loadparm"), 
+                                                         struct loadparm_context);
        struct hdb_ldb_seq *priv = (struct hdb_ldb_seq *)db->hdb_dbc;
        char *realm;
-       struct ldb_dn *realm_dn = NULL;
        struct ldb_result *res = NULL;
-       struct ldb_message **realm_ref_msgs = NULL;
        krb5_error_code ret;
        TALLOC_CTX *mem_ctx;
        int lret;
@@ -1402,21 +1341,24 @@ static krb5_error_code LDB_firstkey(krb5_context context, HDB *db, unsigned flag
 
        priv = (struct hdb_ldb_seq *) talloc(db, struct hdb_ldb_seq);
        if (!priv) {
-               krb5_set_error_string(context, "talloc: out of memory");
-               return ENOMEM;
+               ret = ENOMEM;
+               krb5_set_error_message(context, ret, "talloc: out of memory");
+               return ret;
        }
 
        priv->ctx = ldb_ctx;
+       priv->lp_ctx = lp_ctx;
        priv->index = 0;
        priv->msgs = NULL;
-       priv->realm_ref_msgs = NULL;
+       priv->realm_dn = ldb_get_default_basedn(ldb_ctx);
        priv->count = 0;
 
        mem_ctx = talloc_named(priv, 0, "LDB_firstkey context");
 
        if (!mem_ctx) {
-               krb5_set_error_string(context, "LDB_firstkey: talloc_named() failed!");
-               return ENOMEM;
+               ret = ENOMEM;
+               krb5_set_error_message(context, ret, "LDB_firstkey: talloc_named() failed!");
+               return ret;
        }
 
        ret = krb5_get_default_realm(context, &realm);
@@ -1425,23 +1367,8 @@ static krb5_error_code LDB_firstkey(krb5_context context, HDB *db, unsigned flag
                return ret;
        }
                
-       ret = LDB_lookup_realm(context, (struct ldb_context *)db->hdb_db, 
-                              mem_ctx, realm, &realm_ref_msgs);
-
-       free(realm);
-
-       if (ret != 0) {
-               talloc_free(priv);
-               krb5_warnx(context, "LDB_firstkey: could not find realm\n");
-               return HDB_ERR_NOENTRY;
-       }
-
-       realm_dn = samdb_result_dn((struct ldb_context *)db->hdb_db, mem_ctx, realm_ref_msgs[0], "nCName", NULL);
-
-       priv->realm_ref_msgs = talloc_steal(priv, realm_ref_msgs);
-
        lret = ldb_search(ldb_ctx, priv, &res,
-                         realm_dn, LDB_SCOPE_SUBTREE, user_attrs,
+                         priv->realm_dn, LDB_SCOPE_SUBTREE, user_attrs,
                          "(objectClass=user)");
 
        if (lret != LDB_SUCCESS) {
@@ -1484,7 +1411,7 @@ static krb5_error_code LDB_destroy(krb5_context context, HDB *db)
  * code */
 
 NTSTATUS kdc_hdb_samba4_create(TALLOC_CTX *mem_ctx, 
-                           struct event_context *ev_ctx, 
+                           struct tevent_context *ev_ctx, 
                            struct loadparm_context *lp_ctx,
                            krb5_context context, struct HDB **db, const char *arg)
 {
@@ -1492,7 +1419,7 @@ NTSTATUS kdc_hdb_samba4_create(TALLOC_CTX *mem_ctx,
        struct auth_session_info *session_info;
        *db = talloc(mem_ctx, HDB);
        if (!*db) {
-               krb5_set_error_string(context, "malloc: out of memory");
+               krb5_set_error_message(context, ENOMEM, "malloc: out of memory");
                return NT_STATUS_NO_MEMORY;
        }
 
@@ -1547,7 +1474,7 @@ krb5_error_code hdb_samba4_create(krb5_context context, struct HDB **db, const c
 {
        NTSTATUS nt_status;
        /* The global kdc_mem_ctx and kdc_lp_ctx, Disgusting, ugly hack, but it means one less private hook */
-       nt_status = kdc_hdb_samba4_create(kdc_mem_ctx, event_context_find(kdc_mem_ctx), kdc_lp_ctx, 
+       nt_status = kdc_hdb_samba4_create(kdc_mem_ctx, kdc_ev_ctx, kdc_lp_ctx,
                                          context, db, arg);
 
        if (NT_STATUS_IS_OK(nt_status)) {