s4-cldap: Set DS_DNS_CONTROLLER bit if we are running RPC dnsserver
[kai/samba.git] / source4 / cldap_server / netlogon.c
index d4242061f45cd90e178a21da43c678b1e1e94fac..e9ec0745f4164b7a9f1132958f066976602bedf6 100644 (file)
 */
 
 #include "includes.h"
-#include "lib/ldb/include/ldb.h"
-#include "lib/ldb/include/ldb_errors.h"
+#include <ldb.h>
+#include <ldb_errors.h>
 #include "lib/events/events.h"
-#include "lib/socket/socket.h"
 #include "smbd/service_task.h"
 #include "cldap_server/cldap_server.h"
 #include "librpc/gen_ndr/ndr_misc.h"
 #include "system/network.h"
 #include "lib/socket/netif.h"
 #include "param/param.h"
+#include "../lib/tsocket/tsocket.h"
+#include "libds/common/flag_mapping.h"
+#include "lib/util/util_net.h"
+
 /*
   fill in the cldap netlogon union for a given version
 */
@@ -50,121 +53,69 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                                         const char *src_address,
                                         uint32_t version,
                                         struct loadparm_context *lp_ctx,
-                                        struct netlogon_samlogon_response *netlogon)
+                                        struct netlogon_samlogon_response *netlogon,
+                                        bool fill_on_blank_request)
 {
-       const char *ref_attrs[] = {"nETBIOSName", "dnsRoot", "ncName", NULL};
        const char *dom_attrs[] = {"objectGUID", NULL};
        const char *none_attrs[] = {NULL};
-       struct ldb_result *ref_res = NULL, *dom_res = NULL, *user_res = NULL;
+       struct ldb_result *dom_res = NULL, *user_res = NULL;
        int ret;
-       const char **services = lp_server_services(lp_ctx);
+       const char **services = lpcfg_server_services(lp_ctx);
+       const char **rpc_services = lpcfg_dcerpc_endpoint_servers(lp_ctx);
        uint32_t server_type;
        const char *pdc_name;
        struct GUID domain_uuid;
-       const char *realm;
        const char *dns_domain;
+       const char *forest_domain;
        const char *pdc_dns_name;
        const char *flatname;
        const char *server_site;
        const char *client_site;
        const char *pdc_ip;
-       struct ldb_dn *partitions_basedn;
+       struct ldb_dn *domain_dn = NULL;
        struct interface *ifaces;
-       bool user_known;
+       bool user_known, am_rodc;
        NTSTATUS status;
 
-       partitions_basedn = samdb_partitions_dn(sam_ctx, mem_ctx);
-
-       /* the domain has an optional trailing . */
+       /* the domain parameter could have an optional trailing "." */
        if (domain && domain[strlen(domain)-1] == '.') {
                domain = talloc_strndup(mem_ctx, domain, strlen(domain)-1);
+               NT_STATUS_HAVE_NO_MEMORY(domain);
        }
 
-       if (domain) {
-               struct ldb_dn *dom_dn;
-               /* try and find the domain */
-
-               ret = ldb_search_exp_fmt(sam_ctx, mem_ctx, &ref_res, 
-                                        partitions_basedn, LDB_SCOPE_ONELEVEL, 
-                                        ref_attrs, 
-                                        "(&(&(objectClass=crossRef)(dnsRoot=%s))(nETBIOSName=*))",
-                                        ldb_binary_encode_string(mem_ctx, domain));
-       
-               if (ret != LDB_SUCCESS) {
-                       DEBUG(2,("Unable to find referece to '%s' in sam: %s\n",
-                                domain, 
-                                ldb_errstring(sam_ctx)));
-                       return NT_STATUS_NO_SUCH_DOMAIN;
-               } else if (ref_res->count == 1) {
-                       talloc_steal(mem_ctx, dom_res);
-                       dom_dn = ldb_msg_find_attr_as_dn(sam_ctx, mem_ctx, ref_res->msgs[0], "ncName");
-                       if (!dom_dn) {
-                               return NT_STATUS_NO_SUCH_DOMAIN;
-                       }
-                       ret = ldb_search(sam_ctx, dom_dn,
-                                        LDB_SCOPE_BASE, "objectClass=domain", 
-                                        dom_attrs, &dom_res);
-                       if (ret != LDB_SUCCESS) {
-                               DEBUG(2,("Error finding domain '%s'/'%s' in sam: %s\n", domain, ldb_dn_get_linearized(dom_dn), ldb_errstring(sam_ctx)));
-                               return NT_STATUS_NO_SUCH_DOMAIN;
-                       }
-                       talloc_steal(mem_ctx, dom_res);
-                       if (dom_res->count != 1) {
-                               DEBUG(2,("Error finding domain '%s'/'%s' in sam\n", domain, ldb_dn_get_linearized(dom_dn)));
-                               return NT_STATUS_NO_SUCH_DOMAIN;
-                       }
-               } else if (ref_res->count > 1) {
-                       talloc_free(ref_res);
-                       return NT_STATUS_NO_SUCH_DOMAIN;
-               }
+       /* Lookup using long or short domainname */
+       if (domain && (strcasecmp_m(domain, lpcfg_dnsdomain(lp_ctx)) == 0)) {
+               domain_dn = ldb_get_default_basedn(sam_ctx);
        }
-
-       if (netbios_domain) {
-               struct ldb_dn *dom_dn;
-               /* try and find the domain */
-
-               ret = ldb_search_exp_fmt(sam_ctx, mem_ctx, &ref_res, 
-                                        partitions_basedn, LDB_SCOPE_ONELEVEL, 
-                                        ref_attrs, 
-                                        "(&(objectClass=crossRef)(ncName=*)(nETBIOSName=%s))",
-                                        ldb_binary_encode_string(mem_ctx, netbios_domain));
-       
+       if (netbios_domain && (strcasecmp_m(netbios_domain, lpcfg_sam_name(lp_ctx)) == 0)) {
+               domain_dn = ldb_get_default_basedn(sam_ctx);
+       }
+       if (domain_dn) {
+               const char *domain_identifier = domain != NULL ? domain
+                                                       : netbios_domain;
+               ret = ldb_search(sam_ctx, mem_ctx, &dom_res,
+                                domain_dn, LDB_SCOPE_BASE, dom_attrs,
+                                "objectClass=domain");
                if (ret != LDB_SUCCESS) {
-                       DEBUG(2,("Unable to find referece to '%s' in sam: %s\n",
-                                netbios_domain, 
+                       DEBUG(2,("Error finding domain '%s'/'%s' in sam: %s\n",
+                                domain_identifier,
+                                ldb_dn_get_linearized(domain_dn),
                                 ldb_errstring(sam_ctx)));
                        return NT_STATUS_NO_SUCH_DOMAIN;
-               } else if (ref_res->count == 1) {
-                       talloc_steal(mem_ctx, dom_res);
-                       dom_dn = ldb_msg_find_attr_as_dn(sam_ctx, mem_ctx, ref_res->msgs[0], "ncName");
-                       if (!dom_dn) {
-                               return NT_STATUS_NO_SUCH_DOMAIN;
-                       }
-                       ret = ldb_search(sam_ctx, dom_dn,
-                                        LDB_SCOPE_BASE, "objectClass=domain", 
-                                        dom_attrs, &dom_res);
-                       if (ret != LDB_SUCCESS) {
-                               DEBUG(2,("Error finding domain '%s'/'%s' in sam: %s\n", domain, ldb_dn_get_linearized(dom_dn), ldb_errstring(sam_ctx)));
-                               return NT_STATUS_NO_SUCH_DOMAIN;
-                       }
-                       talloc_steal(mem_ctx, dom_res);
-                       if (dom_res->count != 1) {
-                               DEBUG(2,("Error finding domain '%s'/'%s' in sam\n", domain, ldb_dn_get_linearized(dom_dn)));
-                               return NT_STATUS_NO_SUCH_DOMAIN;
-                       }
-               } else if (ref_res->count > 1) {
-                       talloc_free(ref_res);
+               }
+               if (dom_res->count != 1) {
+                       DEBUG(2,("Error finding domain '%s'/'%s' in sam\n",
+                                domain_identifier,
+                                ldb_dn_get_linearized(domain_dn)));
                        return NT_STATUS_NO_SUCH_DOMAIN;
                }
        }
 
-       if ((dom_res == NULL || dom_res->count == 0) && (domain_guid || domain_sid)) {
-               ref_res = NULL;
-
+       /* Lookup using GUID or SID */
+       if ((dom_res == NULL) && (domain_guid || domain_sid)) {
                if (domain_guid) {
                        struct GUID binary_guid;
                        struct ldb_val guid_val;
-                       enum ndr_err_code ndr_err;
 
                        /* By this means, we ensure we don't have funny stuff in the GUID */
 
@@ -174,73 +125,62 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                        }
 
                        /* And this gets the result into the binary format we want anyway */
-                       ndr_err = ndr_push_struct_blob(&guid_val, mem_ctx, NULL, &binary_guid,
-                                                      (ndr_push_flags_fn_t)ndr_push_GUID);
-                       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-                               return NT_STATUS_INVALID_PARAMETER;
+                       status = GUID_to_ndr_blob(&binary_guid, mem_ctx, &guid_val);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               return status;
                        }
-                       ret = ldb_search_exp_fmt(sam_ctx, mem_ctx, &dom_res,
+                       ret = ldb_search(sam_ctx, mem_ctx, &dom_res,
                                                 NULL, LDB_SCOPE_SUBTREE, 
                                                 dom_attrs, 
-                                                "(&(objectCategory=Domain-DNS)(objectGUID=%s))", 
+                                                "(&(objectCategory=DomainDNS)(objectGUID=%s))", 
                                                 ldb_binary_encode(mem_ctx, guid_val));
                } else { /* domain_sid case */
-                       struct dom_sid *sid;
-                       struct ldb_val sid_val;
-                       enum ndr_err_code ndr_err;
-                       
-                       /* Rather than go via the string, just push into the NDR form */
-                       ndr_err = ndr_push_struct_blob(&sid_val, mem_ctx, NULL, &sid,
-                                                      (ndr_push_flags_fn_t)ndr_push_dom_sid);
-                       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-                               return NT_STATUS_INVALID_PARAMETER;
-                       }
-
-                       ret = ldb_search_exp_fmt(sam_ctx, mem_ctx, &dom_res,
-                                                NULL, LDB_SCOPE_SUBTREE, 
-                                                dom_attrs, 
-                                                "(&(objectCategory=Domain-DNS)(objectSID=%s))", 
-                                                ldb_binary_encode(mem_ctx, sid_val));
+                       ret = ldb_search(sam_ctx, mem_ctx, &dom_res,
+                                        NULL, LDB_SCOPE_SUBTREE,
+                                        dom_attrs,
+                                        "(&(objectCategory=DomainDNS)(objectSid=%s))",
+                                        dom_sid_string(mem_ctx, domain_sid));
                }
                
                if (ret != LDB_SUCCESS) {
-                       DEBUG(2,("Unable to find referece to GUID '%s' or SID %s in sam: %s\n",
+                       DEBUG(2,("Unable to find a correct reference to GUID '%s' or SID '%s' in sam: %s\n",
                                 domain_guid, dom_sid_string(mem_ctx, domain_sid),
                                 ldb_errstring(sam_ctx)));
                        return NT_STATUS_NO_SUCH_DOMAIN;
                } else if (dom_res->count == 1) {
-                       /* try and find the domain */
-                       ret = ldb_search_exp_fmt(sam_ctx, mem_ctx, &ref_res,
-                                                partitions_basedn, LDB_SCOPE_ONELEVEL, 
-                                                ref_attrs, 
-                                                "(&(objectClass=crossRef)(ncName=%s))", 
-                                                ldb_dn_get_linearized(dom_res->msgs[0]->dn));
-                       
-                       if (ret != LDB_SUCCESS) {
-                               DEBUG(2,("Unable to find referece to '%s' in sam: %s\n",
-                                        ldb_dn_get_linearized(dom_res->msgs[0]->dn), 
-                                        ldb_errstring(sam_ctx)));
-                               return NT_STATUS_NO_SUCH_DOMAIN;
-                               
-                       } else if (ref_res->count != 1) {
-                               DEBUG(2,("Unable to find referece to '%s' in sam\n",
-                                        ldb_dn_get_linearized(dom_res->msgs[0]->dn)));
+                       /* Ok, now just check it is our domain */
+                       if (ldb_dn_compare(ldb_get_default_basedn(sam_ctx),
+                                          dom_res->msgs[0]->dn) != 0) {
+                               DEBUG(2,("The GUID '%s' or SID '%s' doesn't identify our domain\n",
+                                        domain_guid,
+                                        dom_sid_string(mem_ctx, domain_sid)));
                                return NT_STATUS_NO_SUCH_DOMAIN;
                        }
-               } else if (dom_res->count > 1) {
-                       talloc_free(ref_res);
+               } else {
+                       DEBUG(2,("Unable to find a correct reference to GUID '%s' or SID '%s' in sam\n",
+                                domain_guid, dom_sid_string(mem_ctx, domain_sid)));
                        return NT_STATUS_NO_SUCH_DOMAIN;
                }
        }
 
-
-       if ((ref_res == NULL || ref_res->count == 0)) {
-               DEBUG(2,("Unable to find domain reference with name %s or GUID {%s}\n", domain, domain_guid));
-               return NT_STATUS_NO_SUCH_DOMAIN;
+       if (dom_res == NULL && fill_on_blank_request) {
+               /* blank inputs gives our domain - tested against
+                  w2k8r2. Without this ADUC on Win7 won't start */
+               domain_dn = ldb_get_default_basedn(sam_ctx);
+               ret = ldb_search(sam_ctx, mem_ctx, &dom_res,
+                                domain_dn, LDB_SCOPE_BASE, dom_attrs,
+                                "objectClass=domain");
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(2,("Error finding domain '%s'/'%s' in sam: %s\n",
+                                lpcfg_dnsdomain(lp_ctx),
+                                ldb_dn_get_linearized(domain_dn),
+                                ldb_errstring(sam_ctx)));
+                       return NT_STATUS_NO_SUCH_DOMAIN;
+               }
        }
 
-       if ((dom_res == NULL || dom_res->count == 0)) {
-               DEBUG(2,("Unable to find domain with name %s or GUID {%s}\n", domain, domain_guid));
+        if (dom_res == NULL) {
+               DEBUG(2,(__location__ ": Unable to get domain information with no inputs\n"));
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
 
@@ -260,16 +200,16 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                acct_control = acct_control & (ACB_TEMPDUP | ACB_NORMAL | ACB_DOMTRUST | ACB_WSTRUST | ACB_SVRTRUST);
 
                /* We must exclude disabled accounts, but otherwise do the bitwise match the client asked for */
-               ret = ldb_search_exp_fmt(sam_ctx, mem_ctx, &user_res,
+               ret = ldb_search(sam_ctx, mem_ctx, &user_res,
                                         dom_res->msgs[0]->dn, LDB_SCOPE_SUBTREE, 
                                         none_attrs, 
                                         "(&(objectClass=user)(samAccountName=%s)"
                                         "(!(userAccountControl:" LDB_OID_COMPARATOR_AND ":=%u))"
                                         "(userAccountControl:" LDB_OID_COMPARATOR_OR ":=%u))", 
                                         ldb_binary_encode_string(mem_ctx, user),
-                                        UF_ACCOUNTDISABLE, samdb_acb2uf(acct_control));
+                                        UF_ACCOUNTDISABLE, ds_acb2uf(acct_control));
                if (ret != LDB_SUCCESS) {
-                       DEBUG(2,("Unable to find referece to user '%s' with ACB 0x%8x under %s: %s\n",
+                       DEBUG(2,("Unable to find reference to user '%s' with ACB 0x%8x under %s: %s\n",
                                 user, acct_control, ldb_dn_get_linearized(dom_res->msgs[0]->dn),
                                 ldb_errstring(sam_ctx)));
                        return NT_STATUS_NO_SUCH_USER;
@@ -284,47 +224,70 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
        }
                
        server_type      = 
-               NBT_SERVER_DS | NBT_SERVER_TIMESERV |
-               NBT_SERVER_CLOSEST | NBT_SERVER_WRITABLE | 
-               NBT_SERVER_GOOD_TIMESERV | NBT_SERVER_DS_DNS_CONTR |
-               NBT_SERVER_DS_DNS_DOMAIN;
+               DS_SERVER_DS | DS_SERVER_TIMESERV |
+               DS_SERVER_GOOD_TIMESERV;
 
        if (samdb_is_pdc(sam_ctx)) {
-               server_type |= NBT_SERVER_PDC;
+               server_type |= DS_SERVER_PDC;
+       }
+
+       if (dsdb_functional_level(sam_ctx) >= DS_DOMAIN_FUNCTION_2008) {
+               server_type |= DS_SERVER_FULL_SECRET_DOMAIN_6;
        }
 
        if (samdb_is_gc(sam_ctx)) {
-               server_type |= NBT_SERVER_GC;
+               server_type |= DS_SERVER_GC;
        }
 
        if (str_list_check(services, "ldap")) {
-               server_type |= NBT_SERVER_LDAP;
+               server_type |= DS_SERVER_LDAP;
        }
 
        if (str_list_check(services, "kdc")) {
-               server_type |= NBT_SERVER_KDC;
+               server_type |= DS_SERVER_KDC;
+       }
+
+       if (str_list_check(rpc_services, "dnsserver")) {
+               server_type |= DS_DNS_CONTROLLER;
        }
 
-       if (!ldb_dn_compare_base(ldb_get_root_basedn(sam_ctx), ldb_get_default_basedn(sam_ctx))) {
-               server_type |= NBT_SERVER_DS_DNS_FOREST;
+       if (samdb_rodc(sam_ctx, &am_rodc) == LDB_SUCCESS && !am_rodc) {
+               server_type |= DS_SERVER_WRITABLE;
        }
 
-       pdc_name         = talloc_asprintf(mem_ctx, "\\\\%s", lp_netbios_name(lp_ctx));
+       pdc_name         = talloc_asprintf(mem_ctx, "\\\\%s",
+                                          lpcfg_netbios_name(lp_ctx));
+       NT_STATUS_HAVE_NO_MEMORY(pdc_name);
        domain_uuid      = samdb_result_guid(dom_res->msgs[0], "objectGUID");
-       realm            = samdb_result_string(ref_res->msgs[0], "dnsRoot", lp_realm(lp_ctx));
-       dns_domain       = samdb_result_string(ref_res->msgs[0], "dnsRoot", lp_realm(lp_ctx));
+       dns_domain       = lpcfg_dnsdomain(lp_ctx);
+       forest_domain    = samdb_forest_name(sam_ctx, mem_ctx);
+       NT_STATUS_HAVE_NO_MEMORY(forest_domain);
        pdc_dns_name     = talloc_asprintf(mem_ctx, "%s.%s", 
                                           strlower_talloc(mem_ctx, 
-                                                          lp_netbios_name(lp_ctx)), 
+                                                          lpcfg_netbios_name(lp_ctx)),
                                           dns_domain);
+       NT_STATUS_HAVE_NO_MEMORY(pdc_dns_name);
+       flatname         = lpcfg_workgroup(lp_ctx);
+
+       server_site      = samdb_server_site_name(sam_ctx, mem_ctx);
+       NT_STATUS_HAVE_NO_MEMORY(server_site);
+       client_site      = samdb_client_site_name(sam_ctx, mem_ctx,
+                                                 src_address, NULL);
+       NT_STATUS_HAVE_NO_MEMORY(client_site);
+       if (strcasecmp(server_site, client_site) == 0) {
+               server_type |= DS_SERVER_CLOSEST;
+       }
 
-       flatname         = samdb_result_string(ref_res->msgs[0], "nETBIOSName", 
-                                              lp_workgroup(lp_ctx));
-       /* FIXME: Hardcoded site names */
-       server_site      = "Default-First-Site-Name";
-       client_site      = "Default-First-Site-Name";
-       load_interfaces(mem_ctx, lp_interfaces(lp_ctx), &ifaces);
-       pdc_ip           = iface_best_ip(ifaces, src_address);
+       load_interface_list(mem_ctx, lp_ctx, &ifaces);
+       if (src_address) {
+               pdc_ip = iface_list_best_ip(ifaces, src_address);
+       } else {
+               pdc_ip = iface_list_first_v4(ifaces);
+       }
+       if (pdc_ip == NULL || !is_ipaddress_v4(pdc_ip)) {
+               /* this matches windows behaviour */
+               pdc_ip = "127.0.0.1";
+       }
 
        ZERO_STRUCTP(netlogon);
 
@@ -335,68 +298,67 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
 
                /* could check if the user exists */
                if (user_known) {
-                       netlogon->nt5_ex.command      = LOGON_SAM_LOGON_RESPONSE_EX;
+                       netlogon->data.nt5_ex.command      = LOGON_SAM_LOGON_RESPONSE_EX;
                } else {
-                       netlogon->nt5_ex.command      = LOGON_SAM_LOGON_USER_UNKNOWN_EX;
+                       netlogon->data.nt5_ex.command      = LOGON_SAM_LOGON_USER_UNKNOWN_EX;
                }
-               netlogon->nt5_ex.server_type  = server_type;
-               netlogon->nt5_ex.domain_uuid  = domain_uuid;
-               netlogon->nt5_ex.forest       = realm;
-               netlogon->nt5_ex.dns_domain   = dns_domain;
-               netlogon->nt5_ex.pdc_dns_name = pdc_dns_name;
-               netlogon->nt5_ex.domain       = flatname;
-               netlogon->nt5_ex.pdc_name     = lp_netbios_name(lp_ctx);
-               netlogon->nt5_ex.user_name    = user;
-               netlogon->nt5_ex.server_site  = server_site;
-               netlogon->nt5_ex.client_site  = client_site;
-
+               netlogon->data.nt5_ex.pdc_name     = pdc_name;
+               netlogon->data.nt5_ex.user_name    = user;
+               netlogon->data.nt5_ex.domain_name  = flatname;
+               netlogon->data.nt5_ex.domain_uuid  = domain_uuid;
+               netlogon->data.nt5_ex.forest       = forest_domain;
+               netlogon->data.nt5_ex.dns_domain   = dns_domain;
+               netlogon->data.nt5_ex.pdc_dns_name = pdc_dns_name;
+               netlogon->data.nt5_ex.server_site  = server_site;
+               netlogon->data.nt5_ex.client_site  = client_site;
                if (version & NETLOGON_NT_VERSION_5EX_WITH_IP) {
-                       /* Clearly this needs to be fixed up for IPv6 */
+                       /* note that this is always a IPV4 address */
                        extra_flags = NETLOGON_NT_VERSION_5EX_WITH_IP;
-                       netlogon->nt5_ex.sockaddr.sa_family    = 2;
-                       netlogon->nt5_ex.sockaddr.pdc_ip       = pdc_ip;
-                       netlogon->nt5_ex.sockaddr.remaining = data_blob_talloc_zero(mem_ctx, 8);
+                       netlogon->data.nt5_ex.sockaddr.sockaddr_family    = 2;
+                       netlogon->data.nt5_ex.sockaddr.pdc_ip       = pdc_ip;
+                       netlogon->data.nt5_ex.sockaddr.remaining = data_blob_talloc_zero(mem_ctx, 8);
                }
-               netlogon->nt5_ex.nt_version   = NETLOGON_NT_VERSION_1|NETLOGON_NT_VERSION_5EX|extra_flags;
-               netlogon->nt5_ex.lmnt_token   = 0xFFFF;
-               netlogon->nt5_ex.lm20_token   = 0xFFFF;
+               netlogon->data.nt5_ex.server_type  = server_type;
+               netlogon->data.nt5_ex.nt_version   = NETLOGON_NT_VERSION_1|NETLOGON_NT_VERSION_5EX|extra_flags;
+               netlogon->data.nt5_ex.lmnt_token   = 0xFFFF;
+               netlogon->data.nt5_ex.lm20_token   = 0xFFFF;
 
        } else if (version & NETLOGON_NT_VERSION_5) {
                netlogon->ntver = NETLOGON_NT_VERSION_5;
 
                /* could check if the user exists */
                if (user_known) {
-                       netlogon->nt5.command      = LOGON_SAM_LOGON_RESPONSE;
+                       netlogon->data.nt5.command      = LOGON_SAM_LOGON_RESPONSE;
                } else {
-                       netlogon->nt5.command      = LOGON_SAM_LOGON_USER_UNKNOWN;
+                       netlogon->data.nt5.command      = LOGON_SAM_LOGON_USER_UNKNOWN;
                }
-               netlogon->nt5.pdc_name     = pdc_name;
-               netlogon->nt5.user_name    = user;
-               netlogon->nt5.domain_name  = flatname;
-               netlogon->nt5.domain_uuid  = domain_uuid;
-               netlogon->nt5.forest       = realm;
-               netlogon->nt5.dns_domain   = dns_domain;
-               netlogon->nt5.pdc_dns_name = pdc_dns_name;
-               netlogon->nt5.pdc_ip       = pdc_ip;
-               netlogon->nt5.server_type  = server_type;
-               netlogon->nt5.nt_version   = NETLOGON_NT_VERSION_1|NETLOGON_NT_VERSION_5;
-               netlogon->nt5.lmnt_token   = 0xFFFF;
-               netlogon->nt5.lm20_token   = 0xFFFF;
+               netlogon->data.nt5.pdc_name     = pdc_name;
+               netlogon->data.nt5.user_name    = user;
+               netlogon->data.nt5.domain_name  = flatname;
+               netlogon->data.nt5.domain_uuid  = domain_uuid;
+               netlogon->data.nt5.forest       = forest_domain;
+               netlogon->data.nt5.dns_domain   = dns_domain;
+               netlogon->data.nt5.pdc_dns_name = pdc_dns_name;
+               netlogon->data.nt5.pdc_ip       = pdc_ip;
+               netlogon->data.nt5.server_type  = server_type;
+               netlogon->data.nt5.nt_version   = NETLOGON_NT_VERSION_1|NETLOGON_NT_VERSION_5;
+               netlogon->data.nt5.lmnt_token   = 0xFFFF;
+               netlogon->data.nt5.lm20_token   = 0xFFFF;
 
        } else /* (version & NETLOGON_NT_VERSION_1) and all other cases */ {
                netlogon->ntver = NETLOGON_NT_VERSION_1;
                /* could check if the user exists */
                if (user_known) {
-                       netlogon->nt4.command      = LOGON_SAM_LOGON_RESPONSE;
+                       netlogon->data.nt4.command      = LOGON_SAM_LOGON_RESPONSE;
                } else {
-                       netlogon->nt4.command      = LOGON_SAM_LOGON_USER_UNKNOWN;
+                       netlogon->data.nt4.command      = LOGON_SAM_LOGON_USER_UNKNOWN;
                }
-               netlogon->nt4.server      = pdc_name;
-               netlogon->nt4.user_name   = user;
-               netlogon->nt4.domain      = flatname;
-               netlogon->nt4.nt_version  = NETLOGON_NT_VERSION_1;
-               netlogon->nt4.lmnt_token  = 0xFFFF;
-               netlogon->nt4.lm20_token  = 0xFFFF;
+               netlogon->data.nt4.pdc_name    = pdc_name;
+               netlogon->data.nt4.user_name   = user;
+               netlogon->data.nt4.domain_name = flatname;
+               netlogon->data.nt4.nt_version  = NETLOGON_NT_VERSION_1;
+               netlogon->data.nt4.lmnt_token  = 0xFFFF;
+               netlogon->data.nt4.lm20_token  = 0xFFFF;
        }
 
        return NT_STATUS_OK;
@@ -406,25 +368,24 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
 /*
   handle incoming cldap requests
 */
-void cldapd_netlogon_request(struct cldap_socket *cldap, 
+void cldapd_netlogon_request(struct cldap_socket *cldap,
+                            struct cldapd_server *cldapd,
+                            TALLOC_CTX *tmp_ctx,
                             uint32_t message_id,
                             struct ldb_parse_tree *tree,
-                            struct socket_address *src)
+                            struct tsocket_address *src)
 {
-       struct cldapd_server *cldapd = talloc_get_type(cldap->incoming.private, struct cldapd_server);
-       int i;
+       unsigned int i;
        const char *domain = NULL;
        const char *host = NULL;
        const char *user = NULL;
        const char *domain_guid = NULL;
-       const char *domain_sid = NULL;
+       struct dom_sid *domain_sid = NULL;
        int acct_control = -1;
        int version = -1;
        struct netlogon_samlogon_response netlogon;
        NTSTATUS status = NT_STATUS_INVALID_PARAMETER;
 
-       TALLOC_CTX *tmp_ctx = talloc_new(cldap);
-
        if (tree->operation != LDB_OP_AND) goto failed;
 
        /* extract the query elements */
@@ -451,9 +412,19 @@ void cldapd_netlogon_request(struct cldap_socket *cldap,
                        }
                }
                if (strcasecmp(t->u.equality.attr, "DomainSid") == 0) {
-                       domain_sid = talloc_strndup(tmp_ctx, 
-                                                   (const char *)t->u.equality.value.data,
-                                                   t->u.equality.value.length);
+                       enum ndr_err_code ndr_err;
+
+                       domain_sid = talloc(tmp_ctx, struct dom_sid);
+                       if (domain_sid == NULL) {
+                               goto failed;
+                       }
+                       ndr_err = ndr_pull_struct_blob(&t->u.equality.value,
+                                                      domain_sid, domain_sid,
+                                                      (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+                       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                               talloc_free(domain_sid);
+                               goto failed;
+                       }
                }
                if (strcasecmp(t->u.equality.attr, "User") == 0) {
                        user = talloc_strndup(tmp_ctx, 
@@ -470,8 +441,8 @@ void cldapd_netlogon_request(struct cldap_socket *cldap,
                }
        }
 
-       if (domain_guid == NULL && domain == NULL) {
-               domain = lp_realm(cldapd->task->lp_ctx);
+       if ((domain == NULL) && (domain_guid == NULL) && (domain_sid == NULL)) {
+               domain = lpcfg_dnsdomain(cldapd->task->lp_ctx);
        }
 
        if (version == -1) {
@@ -481,25 +452,26 @@ void cldapd_netlogon_request(struct cldap_socket *cldap,
        DEBUG(5,("cldap netlogon query domain=%s host=%s user=%s version=%d guid=%s\n",
                 domain, host, user, version, domain_guid));
 
-       status = fill_netlogon_samlogon_response(cldapd->samctx, tmp_ctx, domain, NULL, NULL, domain_guid,
-                                                user, acct_control, src->addr, 
-                                                version, cldapd->task->lp_ctx, &netlogon);
+       status = fill_netlogon_samlogon_response(cldapd->samctx, tmp_ctx,
+                                                domain, NULL, domain_sid,
+                                                domain_guid,
+                                                user, acct_control,
+                                                tsocket_address_inet_addr_string(src, tmp_ctx),
+                                                version, cldapd->task->lp_ctx,
+                                                &netlogon, false);
        if (!NT_STATUS_IS_OK(status)) {
                goto failed;
        }
 
-       status = cldap_netlogon_reply(cldap, message_id, src, version,
-                                     &netlogon);
+       status = cldap_netlogon_reply(cldap, message_id, src, version, &netlogon);
        if (!NT_STATUS_IS_OK(status)) {
                goto failed;
        }
 
-       talloc_free(tmp_ctx);
        return;
        
 failed:
        DEBUG(2,("cldap netlogon query failed domain=%s host=%s version=%d - %s\n",
                 domain, host, version, nt_errstr(status)));
-       talloc_free(tmp_ctx);
-       cldap_empty_reply(cldap, message_id, src);      
+       cldap_empty_reply(cldap, message_id, src);
 }