s4:netlogon RPC server - DsRGetDcNameEx - set the DNS name flags correctly
[obnox/samba/samba-obnox.git] / source4 / cldap_server / netlogon.c
index 1993c1f7dbaf950da62d87ca849b3f000a0e76a4..9d9f45e8bb0279d200884019c0a4a2ade893082f 100644 (file)
@@ -21,8 +21,8 @@
 */
 
 #include "includes.h"
-#include "lib/ldb/include/ldb.h"
-#include "lib/ldb/include/ldb_errors.h"
+#include <ldb.h>
+#include <ldb_errors.h>
 #include "lib/events/events.h"
 #include "smbd/service_task.h"
 #include "cldap_server/cldap_server.h"
@@ -36,6 +36,8 @@
 #include "lib/socket/netif.h"
 #include "param/param.h"
 #include "../lib/tsocket/tsocket.h"
+#include "libds/common/flag_mapping.h"
+#include "lib/util/util_net.h"
 
 /*
   fill in the cldap netlogon union for a given version
@@ -51,13 +53,14 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                                         const char *src_address,
                                         uint32_t version,
                                         struct loadparm_context *lp_ctx,
-                                        struct netlogon_samlogon_response *netlogon)
+                                        struct netlogon_samlogon_response *netlogon,
+                                        bool fill_on_blank_request)
 {
        const char *dom_attrs[] = {"objectGUID", NULL};
        const char *none_attrs[] = {NULL};
        struct ldb_result *dom_res = NULL, *user_res = NULL;
        int ret;
-       const char **services = lp_server_services(lp_ctx);
+       const char **services = lpcfg_server_services(lp_ctx);
        uint32_t server_type;
        const char *pdc_name;
        struct GUID domain_uuid;
@@ -70,7 +73,7 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
        const char *pdc_ip;
        struct ldb_dn *domain_dn = NULL;
        struct interface *ifaces;
-       bool user_known;
+       bool user_known, am_rodc;
        NTSTATUS status;
 
        /* the domain parameter could have an optional trailing "." */
@@ -80,10 +83,10 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
        }
 
        /* Lookup using long or short domainname */
-       if (domain && (strcasecmp_m(domain, lp_dnsdomain(lp_ctx)) == 0)) {
+       if (domain && (strcasecmp_m(domain, lpcfg_dnsdomain(lp_ctx)) == 0)) {
                domain_dn = ldb_get_default_basedn(sam_ctx);
        }
-       if (netbios_domain && (strcasecmp_m(netbios_domain, lp_sam_name(lp_ctx)) == 0)) {
+       if (netbios_domain && (strcasecmp_m(netbios_domain, lpcfg_sam_name(lp_ctx)) == 0)) {
                domain_dn = ldb_get_default_basedn(sam_ctx);
        }
        if (domain_dn) {
@@ -131,22 +134,11 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                                                 "(&(objectCategory=DomainDNS)(objectGUID=%s))", 
                                                 ldb_binary_encode(mem_ctx, guid_val));
                } else { /* domain_sid case */
-                       struct dom_sid *sid;
-                       struct ldb_val sid_val;
-                       enum ndr_err_code ndr_err;
-                       
-                       /* Rather than go via the string, just push into the NDR form */
-                       ndr_err = ndr_push_struct_blob(&sid_val, mem_ctx, NULL, &sid,
-                                                      (ndr_push_flags_fn_t)ndr_push_dom_sid);
-                       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-                               return NT_STATUS_INVALID_PARAMETER;
-                       }
-
                        ret = ldb_search(sam_ctx, mem_ctx, &dom_res,
-                                                NULL, LDB_SCOPE_SUBTREE, 
-                                                dom_attrs, 
-                                                "(&(objectCategory=DomainDNS)(objectSID=%s))", 
-                                                ldb_binary_encode(mem_ctx, sid_val));
+                                        NULL, LDB_SCOPE_SUBTREE,
+                                        dom_attrs,
+                                        "(&(objectCategory=DomainDNS)(objectSid=%s))",
+                                        dom_sid_string(mem_ctx, domain_sid));
                }
                
                if (ret != LDB_SUCCESS) {
@@ -170,8 +162,24 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                }
        }
 
-       if (dom_res == NULL) {
-               DEBUG(2,("Unable to get domain informations if no parameter of the list [long domainname, short domainname, GUID, SID] was specified!\n"));
+       if (dom_res == NULL && fill_on_blank_request) {
+               /* blank inputs gives our domain - tested against
+                  w2k8r2. Without this ADUC on Win7 won't start */
+               domain_dn = ldb_get_default_basedn(sam_ctx);
+               ret = ldb_search(sam_ctx, mem_ctx, &dom_res,
+                                domain_dn, LDB_SCOPE_BASE, dom_attrs,
+                                "objectClass=domain");
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(2,("Error finding domain '%s'/'%s' in sam: %s\n",
+                                lpcfg_dnsdomain(lp_ctx),
+                                ldb_dn_get_linearized(domain_dn),
+                                ldb_errstring(sam_ctx)));
+                       return NT_STATUS_NO_SUCH_DOMAIN;
+               }
+       }
+
+        if (dom_res == NULL) {
+               DEBUG(2,(__location__ ": Unable to get domain information with no inputs\n"));
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
 
@@ -216,14 +224,8 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                
        server_type      = 
                DS_SERVER_DS | DS_SERVER_TIMESERV |
-               DS_SERVER_CLOSEST | DS_SERVER_WRITABLE | 
                DS_SERVER_GOOD_TIMESERV;
 
-#if 0
-       /* w2k8-r2 as a DC does not claim these */
-       server_type |= DS_DNS_CONTROLLER | DS_DNS_DOMAIN;
-#endif
-
        if (samdb_is_pdc(sam_ctx)) {
                server_type |= DS_SERVER_PDC;
        }
@@ -244,33 +246,43 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                server_type |= DS_SERVER_KDC;
        }
 
-#if 0
-       /* w2k8-r2 as a sole DC does not claim this */
-       if (ldb_dn_compare(ldb_get_root_basedn(sam_ctx), ldb_get_default_basedn(sam_ctx)) == 0) {
-               server_type |= DS_DNS_FOREST_ROOT;
+       if (samdb_rodc(sam_ctx, &am_rodc) == LDB_SUCCESS && !am_rodc) {
+               server_type |= DS_SERVER_WRITABLE;
        }
-#endif
 
        pdc_name         = talloc_asprintf(mem_ctx, "\\\\%s",
-                                          lp_netbios_name(lp_ctx));
+                                          lpcfg_netbios_name(lp_ctx));
        NT_STATUS_HAVE_NO_MEMORY(pdc_name);
        domain_uuid      = samdb_result_guid(dom_res->msgs[0], "objectGUID");
-       dns_domain       = lp_dnsdomain(lp_ctx);
+       dns_domain       = lpcfg_dnsdomain(lp_ctx);
        forest_domain    = samdb_forest_name(sam_ctx, mem_ctx);
        NT_STATUS_HAVE_NO_MEMORY(forest_domain);
        pdc_dns_name     = talloc_asprintf(mem_ctx, "%s.%s", 
                                           strlower_talloc(mem_ctx, 
-                                                          lp_netbios_name(lp_ctx)), 
+                                                          lpcfg_netbios_name(lp_ctx)),
                                           dns_domain);
        NT_STATUS_HAVE_NO_MEMORY(pdc_dns_name);
-       flatname         = lp_sam_name(lp_ctx);
+       flatname         = lpcfg_workgroup(lp_ctx);
+
        server_site      = samdb_server_site_name(sam_ctx, mem_ctx);
        NT_STATUS_HAVE_NO_MEMORY(server_site);
        client_site      = samdb_client_site_name(sam_ctx, mem_ctx,
                                                  src_address, NULL);
        NT_STATUS_HAVE_NO_MEMORY(client_site);
-       load_interfaces(mem_ctx, lp_interfaces(lp_ctx), &ifaces);
-       pdc_ip           = iface_best_ip(ifaces, src_address);
+       if (strcasecmp(server_site, client_site) == 0) {
+               server_type |= DS_SERVER_CLOSEST;
+       }
+
+       load_interface_list(mem_ctx, lp_ctx, &ifaces);
+       if (src_address) {
+               pdc_ip = iface_list_best_ip(ifaces, src_address);
+       } else {
+               pdc_ip = iface_list_first_v4(ifaces);
+       }
+       if (pdc_ip == NULL || !is_ipaddress_v4(pdc_ip)) {
+               /* this matches windows behaviour */
+               pdc_ip = "127.0.0.1";
+       }
 
        ZERO_STRUCTP(netlogon);
 
@@ -285,24 +297,23 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                } else {
                        netlogon->data.nt5_ex.command      = LOGON_SAM_LOGON_USER_UNKNOWN_EX;
                }
-               netlogon->data.nt5_ex.server_type  = server_type;
+               netlogon->data.nt5_ex.pdc_name     = pdc_name;
+               netlogon->data.nt5_ex.user_name    = user;
+               netlogon->data.nt5_ex.domain_name  = flatname;
                netlogon->data.nt5_ex.domain_uuid  = domain_uuid;
                netlogon->data.nt5_ex.forest       = forest_domain;
                netlogon->data.nt5_ex.dns_domain   = dns_domain;
                netlogon->data.nt5_ex.pdc_dns_name = pdc_dns_name;
-               netlogon->data.nt5_ex.domain       = flatname;
-               netlogon->data.nt5_ex.pdc_name     = lp_netbios_name(lp_ctx);
-               netlogon->data.nt5_ex.user_name    = user;
                netlogon->data.nt5_ex.server_site  = server_site;
                netlogon->data.nt5_ex.client_site  = client_site;
-
                if (version & NETLOGON_NT_VERSION_5EX_WITH_IP) {
-                       /* Clearly this needs to be fixed up for IPv6 */
+                       /* note that this is always a IPV4 address */
                        extra_flags = NETLOGON_NT_VERSION_5EX_WITH_IP;
                        netlogon->data.nt5_ex.sockaddr.sockaddr_family    = 2;
                        netlogon->data.nt5_ex.sockaddr.pdc_ip       = pdc_ip;
                        netlogon->data.nt5_ex.sockaddr.remaining = data_blob_talloc_zero(mem_ctx, 8);
                }
+               netlogon->data.nt5_ex.server_type  = server_type;
                netlogon->data.nt5_ex.nt_version   = NETLOGON_NT_VERSION_1|NETLOGON_NT_VERSION_5EX|extra_flags;
                netlogon->data.nt5_ex.lmnt_token   = 0xFFFF;
                netlogon->data.nt5_ex.lm20_token   = 0xFFFF;
@@ -337,9 +348,9 @@ NTSTATUS fill_netlogon_samlogon_response(struct ldb_context *sam_ctx,
                } else {
                        netlogon->data.nt4.command      = LOGON_SAM_LOGON_USER_UNKNOWN;
                }
-               netlogon->data.nt4.server      = pdc_name;
+               netlogon->data.nt4.pdc_name    = pdc_name;
                netlogon->data.nt4.user_name   = user;
-               netlogon->data.nt4.domain      = flatname;
+               netlogon->data.nt4.domain_name = flatname;
                netlogon->data.nt4.nt_version  = NETLOGON_NT_VERSION_1;
                netlogon->data.nt4.lmnt_token  = 0xFFFF;
                netlogon->data.nt4.lm20_token  = 0xFFFF;
@@ -364,7 +375,7 @@ void cldapd_netlogon_request(struct cldap_socket *cldap,
        const char *host = NULL;
        const char *user = NULL;
        const char *domain_guid = NULL;
-       const char *domain_sid = NULL;
+       struct dom_sid *domain_sid = NULL;
        int acct_control = -1;
        int version = -1;
        struct netlogon_samlogon_response netlogon;
@@ -396,9 +407,19 @@ void cldapd_netlogon_request(struct cldap_socket *cldap,
                        }
                }
                if (strcasecmp(t->u.equality.attr, "DomainSid") == 0) {
-                       domain_sid = talloc_strndup(tmp_ctx, 
-                                                   (const char *)t->u.equality.value.data,
-                                                   t->u.equality.value.length);
+                       enum ndr_err_code ndr_err;
+
+                       domain_sid = talloc(tmp_ctx, struct dom_sid);
+                       if (domain_sid == NULL) {
+                               goto failed;
+                       }
+                       ndr_err = ndr_pull_struct_blob(&t->u.equality.value,
+                                                      domain_sid, domain_sid,
+                                                      (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+                       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                               talloc_free(domain_sid);
+                               goto failed;
+                       }
                }
                if (strcasecmp(t->u.equality.attr, "User") == 0) {
                        user = talloc_strndup(tmp_ctx, 
@@ -415,8 +436,8 @@ void cldapd_netlogon_request(struct cldap_socket *cldap,
                }
        }
 
-       if (domain_guid == NULL && domain == NULL) {
-               domain = lp_dnsdomain(cldapd->task->lp_ctx);
+       if ((domain == NULL) && (domain_guid == NULL) && (domain_sid == NULL)) {
+               domain = lpcfg_dnsdomain(cldapd->task->lp_ctx);
        }
 
        if (version == -1) {
@@ -426,18 +447,18 @@ void cldapd_netlogon_request(struct cldap_socket *cldap,
        DEBUG(5,("cldap netlogon query domain=%s host=%s user=%s version=%d guid=%s\n",
                 domain, host, user, version, domain_guid));
 
-       status = fill_netlogon_samlogon_response(cldapd->samctx, tmp_ctx, domain, NULL, NULL, domain_guid,
+       status = fill_netlogon_samlogon_response(cldapd->samctx, tmp_ctx,
+                                                domain, NULL, domain_sid,
+                                                domain_guid,
                                                 user, acct_control,
                                                 tsocket_address_inet_addr_string(src, tmp_ctx),
-                                                version, cldapd->task->lp_ctx, &netlogon);
+                                                version, cldapd->task->lp_ctx,
+                                                &netlogon, false);
        if (!NT_STATUS_IS_OK(status)) {
                goto failed;
        }
 
-       status = cldap_netlogon_reply(cldap,
-                                     lp_iconv_convenience(cldapd->task->lp_ctx),
-                                     message_id, src, version,
-                                     &netlogon);
+       status = cldap_netlogon_reply(cldap, message_id, src, version, &netlogon);
        if (!NT_STATUS_IS_OK(status)) {
                goto failed;
        }