Add an async wb request loop
[samba.git] / source3 / winbindd / winbindd.c
index 2b25616cf765755cfb77ac7752965f8cd00d3842..d4d54e31f62c670d046afb6099681e44411c4f8c 100644 (file)
@@ -24,6 +24,7 @@
 
 #include "includes.h"
 #include "winbindd.h"
+#include "../../nsswitch/libwbclient/wbc_async.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_WINBIND
@@ -504,9 +505,26 @@ static struct winbindd_dispatch_table {
        { WINBINDD_NUM_CMDS, NULL, "NONE" }
 };
 
+struct winbindd_async_dispatch_table {
+       enum winbindd_cmd cmd;
+       const char *cmd_name;
+       struct tevent_req *(*send_req)(TALLOC_CTX *mem_ctx,
+                                      struct tevent_context *ev,
+                                      struct winbindd_request *request);
+       NTSTATUS (*recv_req)(struct tevent_req *req, TALLOC_CTX *mem_ctx,
+                            struct winbindd_response **presp);
+};
+
+static struct winbindd_async_dispatch_table async_nonpriv_table[] = {
+       { 0, NULL, NULL, NULL }
+};
+
+static void wb_request_done(struct tevent_req *req);
+
 static void process_request(struct winbindd_cli_state *state)
 {
        struct winbindd_dispatch_table *table = dispatch_table;
+       struct winbindd_async_dispatch_table *atable;
 
        ZERO_STRUCT(state->response);
 
@@ -518,132 +536,68 @@ static void process_request(struct winbindd_cli_state *state)
                return;
 
        /* Remember who asked us. */
-       state->pid = state->request.pid;
+       state->pid = state->request->pid;
 
        /* Process command */
 
-       for (table = dispatch_table; table->fn; table++) {
-               if (state->request.cmd == table->cmd) {
-                       DEBUG(10,("process_request: request fn %s\n",
-                                 table->winbindd_cmd_name ));
-                       table->fn(state);
+       for (atable = async_nonpriv_table; atable->send_req; atable += 1) {
+               if (state->request->cmd == atable->cmd) {
                        break;
                }
        }
 
-       if (!table->fn) {
-               DEBUG(10,("process_request: unknown request fn number %d\n",
-                         (int)state->request.cmd ));
-               request_error(state);
-       }
-}
-
-/*
- * A list of file descriptors being monitored by select in the main processing
- * loop. winbindd_fd_event->handler is called whenever the socket is readable/writable.
- */
-
-static struct winbindd_fd_event *fd_events = NULL;
-
-void add_fd_event(struct winbindd_fd_event *ev)
-{
-       struct winbindd_fd_event *match;
-
-       /* only add unique winbindd_fd_event structs */
-
-       for (match=fd_events; match; match=match->next ) {
-#ifdef DEVELOPER
-               SMB_ASSERT( match != ev );
-#else
-               if ( match == ev )
-                       return;
-#endif
-       }
-
-       DLIST_ADD(fd_events, ev);
-}
-
-void remove_fd_event(struct winbindd_fd_event *ev)
-{
-       DLIST_REMOVE(fd_events, ev);
-}
-
-/*
- * Handler for winbindd_fd_events to complete a read/write request, set up by
- * setup_async_read/setup_async_write.
- */
-
-static void rw_callback(struct winbindd_fd_event *event, int flags)
-{
-       size_t todo;
-       ssize_t done = 0;
+       if (atable->send_req != NULL) {
+               struct tevent_req *req;
 
-       todo = event->length - event->done;
+               DEBUG(10, ("process_request: Handling async request %s\n",
+                          atable->cmd_name));
 
-       if (event->flags & EVENT_FD_WRITE) {
-               SMB_ASSERT(flags == EVENT_FD_WRITE);
-               done = sys_write(event->fd,
-                                &((char *)event->data)[event->done],
-                                todo);
-
-               if (done <= 0) {
-                       event->flags = 0;
-                       event->finished(event->private_data, False);
+               req = atable->send_req(state->mem_ctx, winbind_event_context(),
+                                      state->request);
+               if (req == NULL) {
+                       DEBUG(0, ("process_request: atable->send failed for "
+                                 "%s\n", atable->cmd_name));
+                       request_error(state);
                        return;
                }
+               tevent_req_set_callback(req, wb_request_done, state);
+               state->recv_fn = atable->recv_req;
+               return;
        }
 
-       if (event->flags & EVENT_FD_READ) {
-               SMB_ASSERT(flags == EVENT_FD_READ);
-               done = sys_read(event->fd, &((char *)event->data)[event->done],
-                               todo);
-
-               if (done <= 0) {
-                       event->flags = 0;
-                       event->finished(event->private_data, False);
-                       return;
+       for (table = dispatch_table; table->fn; table++) {
+               if (state->request->cmd == table->cmd) {
+                       DEBUG(10,("process_request: request fn %s\n",
+                                 table->winbindd_cmd_name ));
+                       table->fn(state);
+                       break;
                }
        }
 
-       event->done += done;
-
-       if (event->done == event->length) {
-               event->flags = 0;
-               event->finished(event->private_data, True);
+       if (!table->fn) {
+               DEBUG(10,("process_request: unknown request fn number %d\n",
+                         (int)state->request->cmd ));
+               request_error(state);
        }
 }
 
-/*
- * Request an async read/write on a winbindd_fd_event structure. (*finished) is called
- * when the request is completed or an error had occurred.
- */
-
-void setup_async_read(struct winbindd_fd_event *event, void *data, size_t length,
-                     void (*finished)(void *private_data, bool success),
-                     void *private_data)
-{
-       SMB_ASSERT(event->flags == 0);
-       event->data = data;
-       event->length = length;
-       event->done = 0;
-       event->handler = rw_callback;
-       event->finished = finished;
-       event->private_data = private_data;
-       event->flags = EVENT_FD_READ;
-}
-
-void setup_async_write(struct winbindd_fd_event *event, void *data, size_t length,
-                      void (*finished)(void *private_data, bool success),
-                      void *private_data)
+static void wb_request_done(struct tevent_req *req)
 {
-       SMB_ASSERT(event->flags == 0);
-       event->data = data;
-       event->length = length;
-       event->done = 0;
-       event->handler = rw_callback;
-       event->finished = finished;
-       event->private_data = private_data;
-       event->flags = EVENT_FD_WRITE;
+       struct winbindd_cli_state *state = tevent_req_callback_data(
+               req, struct winbindd_cli_state);
+       NTSTATUS status;
+       struct winbindd_response *response;
+
+       status = state->recv_fn(req, state->mem_ctx, &response);
+       TALLOC_FREE(req);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("returning %s\n", nt_errstr(status)));
+               request_error(state);
+       }
+       state->response = *response;
+       state->response.result = WINBINDD_PENDING;
+       state->response.length = sizeof(struct winbindd_response);
+       request_ok(state);
 }
 
 /*
@@ -656,58 +610,52 @@ void setup_async_write(struct winbindd_fd_event *event, void *data, size_t lengt
  * to call request_finished which schedules sending the response.
  */
 
-static void request_len_recv(void *private_data, bool success);
-static void request_recv(void *private_data, bool success);
-static void request_main_recv(void *private_data, bool success);
 static void request_finished(struct winbindd_cli_state *state);
-static void response_main_sent(void *private_data, bool success);
-static void response_extra_sent(void *private_data, bool success);
 
-static void response_extra_sent(void *private_data, bool success)
+static void winbind_client_request_read(struct tevent_req *req);
+static void winbind_client_response_written(struct tevent_req *req);
+
+static void request_finished(struct winbindd_cli_state *state)
 {
-       struct winbindd_cli_state *state =
-               talloc_get_type_abort(private_data, struct winbindd_cli_state);
+       struct tevent_req *req;
 
-       TALLOC_FREE(state->mem_ctx);
+       TALLOC_FREE(state->request);
 
-       if (!success) {
-               state->finished = True;
+       req = wb_resp_write_send(state, winbind_event_context(),
+                                state->out_queue, state->sock,
+                                &state->response);
+       if (req == NULL) {
+               state->finished = true;
                return;
        }
-
-       setup_async_read(&state->fd_event, &state->request, sizeof(uint32),
-                        request_len_recv, state);
+       tevent_req_set_callback(req, winbind_client_response_written, state);
 }
 
-static void response_main_sent(void *private_data, bool success)
+static void winbind_client_response_written(struct tevent_req *req)
 {
-       struct winbindd_cli_state *state =
-               talloc_get_type_abort(private_data, struct winbindd_cli_state);
-
-       if (!success) {
-               state->finished = True;
+       struct winbindd_cli_state *state = tevent_req_callback_data(
+               req, struct winbindd_cli_state);
+       ssize_t ret;
+       int err;
+
+       ret = wb_resp_write_recv(req, &err);
+       TALLOC_FREE(req);
+       if (ret == -1) {
+               DEBUG(2, ("Could not write response to client: %s\n",
+                         strerror(err)));
+               state->finished = true;
                return;
        }
 
-       if (state->response.length == sizeof(state->response)) {
-               TALLOC_FREE(state->mem_ctx);
+       TALLOC_FREE(state->mem_ctx);
 
-               setup_async_read(&state->fd_event, &state->request,
-                                sizeof(uint32), request_len_recv, state);
+       req = wb_req_read_send(state, winbind_event_context(), state->sock,
+                              WINBINDD_MAX_EXTRA_DATA);
+       if (req == NULL) {
+               state->finished = true;
                return;
        }
-
-       setup_async_write(&state->fd_event, state->response.extra_data.data,
-                         state->response.length - sizeof(state->response),
-                         response_extra_sent, state);
-}
-
-static void request_finished(struct winbindd_cli_state *state)
-{
-       /* Make sure request.extra_data is freed when finish processing a request */
-       SAFE_FREE(state->request.extra_data.data);
-       setup_async_write(&state->fd_event, &state->response,
-                         sizeof(state->response), response_main_sent, state);
+       tevent_req_set_callback(req, winbind_client_request_read, state);
 }
 
 void request_error(struct winbindd_cli_state *state)
@@ -724,90 +672,13 @@ void request_ok(struct winbindd_cli_state *state)
        request_finished(state);
 }
 
-static void request_len_recv(void *private_data, bool success)
-{
-       struct winbindd_cli_state *state =
-               talloc_get_type_abort(private_data, struct winbindd_cli_state);
-
-       if (!success) {
-               state->finished = True;
-               return;
-       }
-
-       if (*(uint32 *)(void *)(&state->request) != sizeof(state->request)) {
-               DEBUG(0,("request_len_recv: Invalid request size received: %d (expected %u)\n",
-                        *(uint32_t *)(void *)(&state->request),
-                        (uint32_t)sizeof(state->request)));
-               state->finished = True;
-               return;
-       }
-
-       setup_async_read(&state->fd_event,
-                        (uint32 *)(void *)(&state->request)+1,
-                        sizeof(state->request) - sizeof(uint32),
-                        request_main_recv, state);
-}
-
-static void request_main_recv(void *private_data, bool success)
-{
-       struct winbindd_cli_state *state =
-               talloc_get_type_abort(private_data, struct winbindd_cli_state);
-
-       if (!success) {
-               state->finished = True;
-               return;
-       }
-
-       if (state->request.extra_len == 0) {
-               state->request.extra_data.data = NULL;
-               request_recv(state, True);
-               return;
-       }
-
-       if ((!state->privileged) &&
-           (state->request.extra_len > WINBINDD_MAX_EXTRA_DATA)) {
-               DEBUG(3, ("Got request with %d bytes extra data on "
-                         "unprivileged socket\n", (int)state->request.extra_len));
-               state->request.extra_data.data = NULL;
-               state->finished = True;
-               return;
-       }
-
-       state->request.extra_data.data =
-               SMB_MALLOC_ARRAY(char, state->request.extra_len + 1);
-
-       if (state->request.extra_data.data == NULL) {
-               DEBUG(0, ("malloc failed\n"));
-               state->finished = True;
-               return;
-       }
-
-       /* Ensure null termination */
-       state->request.extra_data.data[state->request.extra_len] = '\0';
-
-       setup_async_read(&state->fd_event, state->request.extra_data.data,
-                        state->request.extra_len, request_recv, state);
-}
-
-static void request_recv(void *private_data, bool success)
-{
-       struct winbindd_cli_state *state =
-               talloc_get_type_abort(private_data, struct winbindd_cli_state);
-
-       if (!success) {
-               state->finished = True;
-               return;
-       }
-
-       process_request(state);
-}
-
 /* Process a new connection by adding it to the client connection list */
 
 static void new_connection(int listen_sock, bool privileged)
 {
        struct sockaddr_un sunaddr;
        struct winbindd_cli_state *state;
+       struct tevent_req *req;
        socklen_t len;
        int sock;
 
@@ -834,22 +705,48 @@ static void new_connection(int listen_sock, bool privileged)
 
        state->sock = sock;
 
+       state->out_queue = tevent_queue_create(state, "winbind client reply");
+       if (state->out_queue == NULL) {
+               close(sock);
+               TALLOC_FREE(state);
+               return;
+       }
+
        state->last_access = time(NULL);        
 
        state->privileged = privileged;
 
-       state->fd_event.fd = state->sock;
-       state->fd_event.flags = 0;
-       add_fd_event(&state->fd_event);
-
-       setup_async_read(&state->fd_event, &state->request, sizeof(uint32),
-                        request_len_recv, state);
+       req = wb_req_read_send(state, winbind_event_context(), state->sock,
+                              WINBINDD_MAX_EXTRA_DATA);
+       if (req == NULL) {
+               TALLOC_FREE(state);
+               close(sock);
+               return;
+       }
+       tevent_req_set_callback(req, winbind_client_request_read, state);
 
        /* Add to connection list */
 
        winbindd_add_client(state);
 }
 
+static void winbind_client_request_read(struct tevent_req *req)
+{
+       struct winbindd_cli_state *state = tevent_req_callback_data(
+               req, struct winbindd_cli_state);
+       ssize_t ret;
+       int err;
+
+       ret = wb_req_read_recv(req, state, &state->request, &err);
+       if (ret == -1) {
+               DEBUG(2, ("Could not read client request: %s\n",
+                         strerror(err)));
+               state->finished = true;
+               return;
+       }
+       process_request(state);
+}
+
 /* Remove a client connection from client connection list */
 
 static void remove_client(struct winbindd_cli_state *state)
@@ -887,8 +784,6 @@ static void remove_client(struct winbindd_cli_state *state)
 
        TALLOC_FREE(state->mem_ctx);
 
-       remove_fd_event(&state->fd_event);
-
        /* Remove from list and free */
 
        winbindd_remove_client(state);
@@ -905,7 +800,6 @@ static bool remove_idle_client(void)
 
        for (state = winbindd_client_list(); state; state = state->next) {
                if (state->response.result != WINBINDD_PENDING &&
-                   state->fd_event.flags == EVENT_FD_READ &&
                    !state->getpwent_state && !state->getgrent_state) {
                        nidle++;
                        if (!last_access || state->last_access < last_access) {
@@ -1021,7 +915,6 @@ failed:
 
 static void process_loop(void)
 {
-       struct winbindd_fd_event *ev;
        fd_set r_fds, w_fds;
        int maxfd = 0, selret;
        struct timeval timeout, ev_timeout;
@@ -1048,17 +941,6 @@ static void process_loop(void)
                timeout = timeval_min(&timeout, &ev_timeout);
        }
 
-       for (ev = fd_events; ev; ev = ev->next) {
-               if (ev->flags & EVENT_FD_READ) {
-                       FD_SET(ev->fd, &r_fds);
-                       maxfd = MAX(ev->fd, maxfd);
-               }
-               if (ev->flags & EVENT_FD_WRITE) {
-                       FD_SET(ev->fd, &w_fds);
-                       maxfd = MAX(ev->fd, maxfd);
-               }
-       }
-
        /* Call select */
 
        selret = sys_select(maxfd + 1, &r_fds, &w_fds, NULL, &timeout);
@@ -1082,19 +964,6 @@ static void process_loop(void)
 
        run_events(winbind_event_context(), selret, &r_fds, &w_fds);
 
-       ev = fd_events;
-       while (ev != NULL) {
-               struct winbindd_fd_event *next = ev->next;
-               int flags = 0;
-               if (FD_ISSET(ev->fd, &r_fds))
-                       flags |= EVENT_FD_READ;
-               if (FD_ISSET(ev->fd, &w_fds))
-                       flags |= EVENT_FD_WRITE;
-               if (flags)
-                       ev->handler(ev, flags);
-               ev = next;
-       }
-
        return;
 
  no_fds_ready: