smbcacls: Move StringToSid to common file
[samba.git] / source3 / utils / smbcacls.c
index 63858ea08dff11847074d2045b8115d837a20e04..778d30d4548b5b9a2d18d1990f767348124494a0 100644 (file)
@@ -1,43 +1,47 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
    ACL get/set utility
-   
+
    Copyright (C) Andrew Tridgell 2000
    Copyright (C) Tim Potter      2000
    Copyright (C) Jeremy Allison  2000
    Copyright (C) Jelmer Vernooij 2003
-   
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 #include "popt_common.h"
+#include "rpc_client/cli_pipe.h"
 #include "../librpc/gen_ndr/ndr_lsa.h"
 #include "rpc_client/cli_lsarpc.h"
 #include "../libcli/security/security.h"
-
-extern bool AllowDebugChange;
+#include "libsmb/libsmb.h"
+#include "libsmb/clirap.h"
+#include "passdb/machine_sid.h"
+#include "../librpc/gen_ndr/ndr_lsa_c.h"
+#include "util_sd.h"
 
 static int test_args;
 
 #define CREATE_ACCESS_READ READ_CONTROL_ACCESS
 
-/* numeric is set when the user wants numeric SIDs and ACEs rather
-   than going via LSA calls to resolve them */
-static int numeric;
-
 static int sddl;
+static int query_sec_info = -1;
+static int set_sec_info = -1;
+
+static const char *domain_sid = NULL;
 
 enum acl_mode {SMB_ACL_SET, SMB_ACL_DELETE, SMB_ACL_MODIFY, SMB_ACL_ADD };
 enum chown_mode {REQUEST_NONE, REQUEST_CHOWN, REQUEST_CHGRP, REQUEST_INHERIT};
@@ -51,162 +55,96 @@ struct perm_value {
 /* These values discovered by inspection */
 
 static const struct perm_value special_values[] = {
-       { "R", 0x00120089 },
-       { "W", 0x00120116 },
-       { "X", 0x001200a0 },
-       { "D", 0x00010000 },
-       { "P", 0x00040000 },
-       { "O", 0x00080000 },
+       { "R", SEC_RIGHTS_FILE_READ },
+       { "W", SEC_RIGHTS_FILE_WRITE },
+       { "X", SEC_RIGHTS_FILE_EXECUTE },
+       { "D", SEC_STD_DELETE },
+       { "P", SEC_STD_WRITE_DAC },
+       { "O", SEC_STD_WRITE_OWNER },
        { NULL, 0 },
 };
 
 static const struct perm_value standard_values[] = {
-       { "READ",   0x001200a9 },
-       { "CHANGE", 0x001301bf },
-       { "FULL",   0x001f01ff },
+       { "READ",   SEC_RIGHTS_DIR_READ|SEC_DIR_TRAVERSE },
+       { "CHANGE", SEC_RIGHTS_DIR_READ|SEC_STD_DELETE|\
+         SEC_RIGHTS_DIR_WRITE|SEC_DIR_TRAVERSE },
+       { "FULL",   SEC_RIGHTS_DIR_ALL },
        { NULL, 0 },
 };
 
-/* Open cli connection and policy handle */
-
-static NTSTATUS cli_lsa_lookup_sid(struct cli_state *cli,
-                                  const struct dom_sid *sid,
-                                  TALLOC_CTX *mem_ctx,
-                                  enum lsa_SidType *type,
-                                  char **domain, char **name)
+static NTSTATUS cli_lsa_lookup_domain_sid(struct cli_state *cli,
+                                         struct dom_sid *sid)
 {
-       uint16 orig_cnum = cli->cnum;
-       struct rpc_pipe_client *p = NULL;
+       union lsa_PolicyInformation *info = NULL;
+       uint16 orig_cnum = cli_state_get_tid(cli);
+       struct rpc_pipe_client *rpc_pipe = NULL;
        struct policy_handle handle;
-       NTSTATUS status;
+       NTSTATUS status, result;
        TALLOC_CTX *frame = talloc_stackframe();
-       enum lsa_SidType *types;
-       char **domains;
-       char **names;
 
-       status = cli_tcon_andx(cli, "IPC$", "?????", "", 0);
+       status = cli_tree_connect(cli, "IPC$", "?????", "", 0);
        if (!NT_STATUS_IS_OK(status)) {
-               return status;
+               goto done;
        }
 
-       status = cli_rpc_pipe_open_noauth(cli, &ndr_table_lsarpc.syntax_id,
-                                         &p);
+       status = cli_rpc_pipe_open_noauth(cli, &ndr_table_lsarpc, &rpc_pipe);
        if (!NT_STATUS_IS_OK(status)) {
-               goto fail;
+               goto tdis;
        }
 
-       status = rpccli_lsa_open_policy(p, talloc_tos(), True,
+       status = rpccli_lsa_open_policy(rpc_pipe, frame, True,
                                        GENERIC_EXECUTE_ACCESS, &handle);
        if (!NT_STATUS_IS_OK(status)) {
-               goto fail;
+               goto tdis;
        }
 
-       status = rpccli_lsa_lookup_sids(p, talloc_tos(), &handle, 1, sid,
-                                       &domains, &names, &types);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto fail;
-       }
+       status = dcerpc_lsa_QueryInfoPolicy2(rpc_pipe->binding_handle,
+                                            frame, &handle,
+                                            LSA_POLICY_INFO_DOMAIN,
+                                            &info, &result);
 
-       *type = types[0];
-       *domain = talloc_move(mem_ctx, &domains[0]);
-       *name = talloc_move(mem_ctx, &names[0]);
-
-       status = NT_STATUS_OK;
- fail:
-       TALLOC_FREE(p);
-       cli_tdis(cli);
-       cli->cnum = orig_cnum;
-       TALLOC_FREE(frame);
-       return status;
-}
-
-static NTSTATUS cli_lsa_lookup_name(struct cli_state *cli,
-                                   const char *name,
-                                   enum lsa_SidType *type,
-                                   struct dom_sid *sid)
-{
-       uint16 orig_cnum = cli->cnum;
-       struct rpc_pipe_client *p;
-       struct policy_handle handle;
-       NTSTATUS status;
-       TALLOC_CTX *frame = talloc_stackframe();
-       struct dom_sid *sids;
-       enum lsa_SidType *types;
-
-       status = cli_tcon_andx(cli, "IPC$", "?????", "", 0);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
+       if (any_nt_status_not_ok(status, result, &status)) {
+               goto tdis;
        }
 
-       status = cli_rpc_pipe_open_noauth(cli, &ndr_table_lsarpc.syntax_id,
-                                         &p);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto fail;
-       }
+       *sid = *info->domain.sid;
 
-       status = rpccli_lsa_open_policy(p, talloc_tos(), True,
-                                       GENERIC_EXECUTE_ACCESS, &handle);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto fail;
-       }
-
-       status = rpccli_lsa_lookup_names(p, talloc_tos(), &handle, 1, &name,
-                                        NULL, 1, &sids, &types);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto fail;
-       }
-
-       *type = types[0];
-       *sid = sids[0];
-
-       status = NT_STATUS_OK;
- fail:
-       TALLOC_FREE(p);
+tdis:
+       TALLOC_FREE(rpc_pipe);
        cli_tdis(cli);
-       cli->cnum = orig_cnum;
+done:
+       cli_state_set_tid(cli, orig_cnum);
        TALLOC_FREE(frame);
        return status;
 }
 
-/* convert a SID to a string, either numeric or username/group */
-static void SidToString(struct cli_state *cli, fstring str, const struct dom_sid *sid)
+static struct dom_sid *get_domain_sid(struct cli_state *cli)
 {
-       char *domain = NULL;
-       char *name = NULL;
-       enum lsa_SidType type;
        NTSTATUS status;
 
-       sid_to_fstring(str, sid);
-
-       if (numeric) {
-               return;
-       }
-
-       status = cli_lsa_lookup_sid(cli, sid, talloc_tos(), &type,
-                                   &domain, &name);
-
-       if (!NT_STATUS_IS_OK(status)) {
-               return;
+       struct dom_sid *sid = talloc(talloc_tos(), struct dom_sid);
+       if (sid == NULL) {
+               DEBUG(0, ("Out of memory\n"));
+               return NULL;
        }
 
-       if (*domain) {
-               slprintf(str, sizeof(fstring) - 1, "%s%s%s",
-                       domain, lp_winbind_separator(), name);
+       if (domain_sid) {
+               if (!dom_sid_parse(domain_sid, sid)) {
+                       DEBUG(0,("failed to parse domain sid\n"));
+                       TALLOC_FREE(sid);
+               }
        } else {
-               fstrcpy(str, name);
-       }
-}
+               status = cli_lsa_lookup_domain_sid(cli, sid);
 
-/* convert a string to a SID, either numeric or username/group */
-static bool StringToSid(struct cli_state *cli, struct dom_sid *sid, const char *str)
-{
-       enum lsa_SidType type;
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0,("failed to lookup domain sid: %s\n", nt_errstr(status)));
+                       TALLOC_FREE(sid);
+               }
 
-       if (strncmp(str, "S-", 2) == 0) {
-               return string_to_sid(sid, str);
        }
 
-       return NT_STATUS_IS_OK(cli_lsa_lookup_name(cli, str, &type, sid));
+       DEBUG(2,("Domain SID: %s\n", sid_string_dbg(sid)));
+       return sid;
 }
 
 static void print_ace_flags(FILE *f, uint8_t flags)
@@ -270,14 +208,15 @@ static void print_ace_flags(FILE *f, uint8_t flags)
 }
 
 /* print an ACE on a FILE, using either numeric or ascii representation */
-static void print_ace(struct cli_state *cli, FILE *f, struct security_ace *ace)
+static void print_ace(struct cli_state *cli, FILE *f, struct security_ace *ace,
+                     bool numeric)
 {
        const struct perm_value *v;
        fstring sidstr;
        int do_print = 0;
        uint32 got_mask;
 
-       SidToString(cli, sidstr, &ace->trustee);
+       SidToString(cli, sidstr, &ace->trustee, numeric);
 
        fprintf(f, "%s:", sidstr);
 
@@ -358,7 +297,12 @@ static bool parse_ace_flags(const char *str, unsigned int *pflags)
                        return false;
                }
 
-               if (*p != '|' && *p != '\0') {
+               switch (*p) {
+               case '|':
+                       p++;
+               case '\0':
+                       continue;
+               default:
                        return false;
                }
        }
@@ -398,7 +342,7 @@ static bool parse_ace(struct cli_state *cli, struct security_ace *ace,
        p++;
        /* Try to parse numeric form */
 
-       if (sscanf(p, "%i/%i/%i", &atype, &aflags, &amask) == 3 &&
+       if (sscanf(p, "%u/%u/%u", &atype, &aflags, &amask) == 3 &&
            StringToSid(cli, &sid, str)) {
                goto done;
        }
@@ -461,7 +405,7 @@ static bool parse_ace(struct cli_state *cli, struct security_ace *ace,
                        return False;
                }
        } else {
-               if (!sscanf(tok, "%i", &aflags)) {
+               if (!sscanf(tok, "%u", &aflags)) {
                        printf("ACE '%s': bad integer flags entry at '%s'\n",
                                orig_str, tok);
                        SAFE_FREE(str);
@@ -479,7 +423,7 @@ static bool parse_ace(struct cli_state *cli, struct security_ace *ace,
        }
 
        if (strncmp(tok, "0x", 2) == 0) {
-               if (sscanf(tok, "%i", &amask) != 1) {
+               if (sscanf(tok, "%u", &amask) != 1) {
                        printf("ACE '%s': bad hex number at '%s'\n",
                                orig_str, tok);
                        SAFE_FREE(str);
@@ -625,20 +569,63 @@ static struct security_descriptor *sec_desc_parse(TALLOC_CTX *ctx, struct cli_st
        return ret;
 }
 
+static const struct {
+       uint16_t mask;
+       const char *str;
+       const char *desc;
+} sec_desc_ctrl_bits[] = {
+       {SEC_DESC_OWNER_DEFAULTED,       "OD", "Owner Defaulted"},
+       {SEC_DESC_GROUP_DEFAULTED,       "GD", "Group Defaulted"},
+       {SEC_DESC_DACL_PRESENT,          "DP", "DACL Present"},
+       {SEC_DESC_DACL_DEFAULTED,        "DD", "DACL Defaulted"},
+       {SEC_DESC_SACL_PRESENT,          "SP", "SACL Present"},
+       {SEC_DESC_SACL_DEFAULTED,        "SD", "SACL Defaulted"},
+       {SEC_DESC_DACL_TRUSTED,          "DT", "DACL Trusted"},
+       {SEC_DESC_SERVER_SECURITY,       "SS", "Server Security"},
+       {SEC_DESC_DACL_AUTO_INHERIT_REQ, "DR", "DACL Inheritance Required"},
+       {SEC_DESC_SACL_AUTO_INHERIT_REQ, "SR", "SACL Inheritance Required"},
+       {SEC_DESC_DACL_AUTO_INHERITED,   "DI", "DACL Auto Inherited"},
+       {SEC_DESC_SACL_AUTO_INHERITED,   "SI", "SACL Auto Inherited"},
+       {SEC_DESC_DACL_PROTECTED,        "PD", "DACL Protected"},
+       {SEC_DESC_SACL_PROTECTED,        "PS", "SACL Protected"},
+       {SEC_DESC_RM_CONTROL_VALID,      "RM", "RM Control Valid"},
+       {SEC_DESC_SELF_RELATIVE ,        "SR", "Self Relative"},
+};
+
+static void print_acl_ctrl(FILE *file, uint16_t ctrl, bool numeric)
+{
+       int i;
+       const char* separator = "";
+
+       fprintf(file, "CONTROL:");
+       if (numeric) {
+               fprintf(file, "0x%x\n", ctrl);
+               return;
+       }
+
+       for (i = ARRAY_SIZE(sec_desc_ctrl_bits) - 1; i >= 0; i--) {
+               if (ctrl & sec_desc_ctrl_bits[i].mask) {
+                       fprintf(file, "%s%s", separator, sec_desc_ctrl_bits[i].str);
+                       separator = "|";
+               }
+       }
+       fputc('\n', file);
+}
 
 /* print a ascii version of a security descriptor on a FILE handle */
-static void sec_desc_print(struct cli_state *cli, FILE *f, struct security_descriptor *sd)
+static void sec_desc_print(struct cli_state *cli, FILE *f,
+                          struct security_descriptor *sd, bool numeric)
 {
        fstring sidstr;
        uint32 i;
 
        fprintf(f, "REVISION:%d\n", sd->revision);
-       fprintf(f, "CONTROL:0x%x\n", sd->type);
+       print_acl_ctrl(f, sd->type, numeric);
 
        /* Print owner and group sid */
 
        if (sd->owner_sid) {
-               SidToString(cli, sidstr, sd->owner_sid);
+               SidToString(cli, sidstr, sd->owner_sid, numeric);
        } else {
                fstrcpy(sidstr, "");
        }
@@ -646,7 +633,7 @@ static void sec_desc_print(struct cli_state *cli, FILE *f, struct security_descr
        fprintf(f, "OWNER:%s\n", sidstr);
 
        if (sd->group_sid) {
-               SidToString(cli, sidstr, sd->group_sid);
+               SidToString(cli, sidstr, sd->group_sid, numeric);
        } else {
                fstrcpy(sidstr, "");
        }
@@ -657,7 +644,7 @@ static void sec_desc_print(struct cli_state *cli, FILE *f, struct security_descr
        for (i = 0; sd->dacl && i < sd->dacl->num_aces; i++) {
                struct security_ace *ace = &sd->dacl->aces[i];
                fprintf(f, "ACL:");
-               print_ace(cli, f, ace);
+               print_ace(cli, f, ace, numeric);
                fprintf(f, "\n");
        }
 
@@ -669,21 +656,25 @@ get fileinfo for filename
 static uint16 get_fileinfo(struct cli_state *cli, const char *filename)
 {
        uint16_t fnum = (uint16_t)-1;
-       uint16 mode;
+       uint16 mode = 0;
+       NTSTATUS status;
 
        /* The desired access below is the only one I could find that works
           with NT4, W2KP and Samba */
 
-       if (!NT_STATUS_IS_OK(cli_ntcreate(cli, filename, 0, CREATE_ACCESS_READ,
-                                          0, FILE_SHARE_READ|FILE_SHARE_WRITE,
-                                          FILE_OPEN, 0x0, 0x0, &fnum))) {
-               printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
+       status = cli_ntcreate(cli, filename, 0, CREATE_ACCESS_READ,
+                             0, FILE_SHARE_READ|FILE_SHARE_WRITE,
+                             FILE_OPEN, 0x0, 0x0, &fnum, NULL);
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Failed to open %s: %s\n", filename, nt_errstr(status));
+               return 0;
        }
 
-       if (!cli_qfileinfo(cli, fnum, &mode, NULL, NULL, NULL,
-                                             NULL, NULL, NULL)) {
+       status = cli_qfileinfo_basic(cli, fnum, &mode, NULL, NULL, NULL,
+                                    NULL, NULL, NULL);
+       if (!NT_STATUS_IS_OK(status)) {
                printf("Failed to file info %s: %s\n", filename,
-                                                       cli_errstr(cli));
+                      nt_errstr(status));
         }
 
        cli_close(cli, fnum);
@@ -698,23 +689,43 @@ static struct security_descriptor *get_secdesc(struct cli_state *cli, const char
 {
        uint16_t fnum = (uint16_t)-1;
        struct security_descriptor *sd;
+       NTSTATUS status;
+       uint32_t sec_info;
+       uint32_t desired_access = 0;
 
-       /* The desired access below is the only one I could find that works
-          with NT4, W2KP and Samba */
+       if (query_sec_info == -1) {
+               sec_info = SECINFO_OWNER | SECINFO_GROUP | SECINFO_DACL;
+       } else {
+               sec_info = query_sec_info;
+       }
+
+       if (sec_info & (SECINFO_OWNER | SECINFO_GROUP | SECINFO_DACL)) {
+               desired_access |= SEC_STD_READ_CONTROL;
+       }
+       if (sec_info & SECINFO_SACL) {
+               desired_access |= SEC_FLAG_SYSTEM_SECURITY;
+       }
 
-       if (!NT_STATUS_IS_OK(cli_ntcreate(cli, filename, 0, CREATE_ACCESS_READ,
-                                          0, FILE_SHARE_READ|FILE_SHARE_WRITE,
-                                          FILE_OPEN, 0x0, 0x0, &fnum))) {
-               printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
+       if (desired_access == 0) {
+               desired_access |= SEC_STD_READ_CONTROL;
+       }
+
+       status = cli_ntcreate(cli, filename, 0, desired_access,
+                             0, FILE_SHARE_READ|FILE_SHARE_WRITE,
+                             FILE_OPEN, 0x0, 0x0, &fnum, NULL);
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Failed to open %s: %s\n", filename, nt_errstr(status));
                return NULL;
        }
 
-       sd = cli_query_secdesc(cli, fnum, talloc_tos());
+       status = cli_query_security_descriptor(cli, fnum, sec_info,
+                                              talloc_tos(), &sd);
 
        cli_close(cli, fnum);
 
-       if (!sd) {
-               printf("Failed to get security descriptor\n");
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Failed to get security descriptor: %s\n",
+                      nt_errstr(status));
                return NULL;
        }
         return sd;
@@ -728,21 +739,53 @@ static bool set_secdesc(struct cli_state *cli, const char *filename,
 {
        uint16_t fnum = (uint16_t)-1;
         bool result=true;
+       NTSTATUS status;
+       uint32_t desired_access = 0;
+       uint32_t sec_info;
 
-       /* The desired access below is the only one I could find that works
-          with NT4, W2KP and Samba */
+       if (set_sec_info == -1) {
+               sec_info = 0;
 
-       if (!NT_STATUS_IS_OK(cli_ntcreate(cli, filename, 0,
-                                          WRITE_DAC_ACCESS|WRITE_OWNER_ACCESS,
-                                          0, FILE_SHARE_READ|FILE_SHARE_WRITE,
-                                          FILE_OPEN, 0x0, 0x0, &fnum))) {
-               printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
+               if (sd->dacl || (sd->type & SEC_DESC_DACL_PRESENT)) {
+                       sec_info |= SECINFO_DACL;
+               }
+               if (sd->sacl || (sd->type & SEC_DESC_SACL_PRESENT)) {
+                       sec_info |= SECINFO_SACL;
+               }
+               if (sd->owner_sid) {
+                       sec_info |= SECINFO_OWNER;
+               }
+               if (sd->group_sid) {
+                       sec_info |= SECINFO_GROUP;
+               }
+       } else {
+               sec_info = set_sec_info;
+       }
+
+       /* Make the desired_access more specific. */
+       if (sec_info & SECINFO_DACL) {
+               desired_access |= SEC_STD_WRITE_DAC;
+       }
+       if (sec_info & SECINFO_SACL) {
+               desired_access |= SEC_FLAG_SYSTEM_SECURITY;
+       }
+       if (sec_info & (SECINFO_OWNER | SECINFO_GROUP)) {
+               desired_access |= SEC_STD_WRITE_OWNER;
+       }
+
+       status = cli_ntcreate(cli, filename, 0,
+                             desired_access,
+                             0, FILE_SHARE_READ|FILE_SHARE_WRITE,
+                             FILE_OPEN, 0x0, 0x0, &fnum, NULL);
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Failed to open %s: %s\n", filename, nt_errstr(status));
                return false;
        }
 
-       if (!cli_set_secdesc(cli, fnum, sd)) {
+       status = cli_set_security_descriptor(cli, fnum, sec_info, sd);
+       if (!NT_STATUS_IS_OK(status)) {
                printf("ERROR: security description set failed: %s\n",
-                       cli_errstr(cli));
+                       nt_errstr(status));
                result=false;
        }
 
@@ -753,27 +796,31 @@ static bool set_secdesc(struct cli_state *cli, const char *filename,
 /*****************************************************
 dump the acls for a file
 *******************************************************/
-static int cacl_dump(struct cli_state *cli, const char *filename)
+static int cacl_dump(struct cli_state *cli, const char *filename, bool numeric)
 {
-       int result = EXIT_FAILED;
        struct security_descriptor *sd;
 
-       if (test_args)
+       if (test_args) {
                return EXIT_OK;
+       }
 
        sd = get_secdesc(cli, filename);
+       if (sd == NULL) {
+               return EXIT_FAILED;
+       }
 
-       if (sd) {
-               if (sddl) {
-                       printf("%s\n", sddl_encode(talloc_tos(), sd,
-                                          get_global_sam_sid()));
-               } else {
-                       sec_desc_print(cli, stdout, sd);
+       if (sddl) {
+               char *str = sddl_encode(talloc_tos(), sd, get_domain_sid(cli));
+               if (str == NULL) {
+                       return EXIT_FAILED;
                }
-               result = EXIT_OK;
+               printf("%s\n", str);
+               TALLOC_FREE(str);
+       } else {
+               sec_desc_print(cli, stdout, sd, numeric);
        }
 
-       return result;
+       return EXIT_OK;
 }
 
 /***************************************************** 
@@ -797,7 +844,7 @@ static int owner_set(struct cli_state *cli, enum chown_mode change_mode,
                return EXIT_FAILED;
        }
 
-       sd = make_sec_desc(talloc_tos(),old->revision, old->type,
+       sd = make_sec_desc(talloc_tos(),old->revision, SEC_DESC_SELF_RELATIVE,
                                (change_mode == REQUEST_CHOWN) ? &sid : NULL,
                                (change_mode == REQUEST_CHGRP) ? &sid : NULL,
                           NULL, NULL, &sd_size);
@@ -820,7 +867,7 @@ static int owner_set(struct cli_state *cli, enum chown_mode change_mode,
 
 static int ace_compare(struct security_ace *ace1, struct security_ace *ace2)
 {
-       if (sec_ace_equal(ace1, ace2))
+       if (security_ace_equal(ace1, ace2))
                return 0;
 
        if ((ace1->flags & SEC_ACE_FLAG_INHERITED_ACE) &&
@@ -859,7 +906,8 @@ static void sort_acl(struct security_acl *the_acl)
        TYPESAFE_QSORT(the_acl->aces, the_acl->num_aces, ace_compare);
 
        for (i=1;i<the_acl->num_aces;) {
-               if (sec_ace_equal(&the_acl->aces[i-1], &the_acl->aces[i])) {
+               if (security_ace_equal(&the_acl->aces[i-1],
+                                      &the_acl->aces[i])) {
                        int j;
                        for (j=i; j<the_acl->num_aces-1; j++) {
                                the_acl->aces[j] = the_acl->aces[j+1];
@@ -876,7 +924,7 @@ set the ACLs on a file given an ascii description
 *******************************************************/
 
 static int cacl_set(struct cli_state *cli, const char *filename,
-                   char *the_acl, enum acl_mode mode)
+                   char *the_acl, enum acl_mode mode, bool numeric)
 {
        struct security_descriptor *sd, *old;
        uint32 i, j;
@@ -884,7 +932,7 @@ static int cacl_set(struct cli_state *cli, const char *filename,
        int result = EXIT_OK;
 
        if (sddl) {
-               sd = sddl_decode(talloc_tos(), the_acl, get_global_sam_sid());
+               sd = sddl_decode(talloc_tos(), the_acl, get_domain_sid(cli));
        } else {
                sd = sec_desc_parse(talloc_tos(), cli, the_acl);
        }
@@ -905,8 +953,8 @@ static int cacl_set(struct cli_state *cli, const char *filename,
                        bool found = False;
 
                        for (j=0;old->dacl && j<old->dacl->num_aces;j++) {
-                               if (sec_ace_equal(&sd->dacl->aces[i],
-                                                 &old->dacl->aces[j])) {
+                               if (security_ace_equal(&sd->dacl->aces[i],
+                                                      &old->dacl->aces[j])) {
                                        uint32 k;
                                        for (k=j; k<old->dacl->num_aces-1;k++) {
                                                old->dacl->aces[k] = old->dacl->aces[k+1];
@@ -919,7 +967,8 @@ static int cacl_set(struct cli_state *cli, const char *filename,
 
                        if (!found) {
                                printf("ACL for ACE:");
-                               print_ace(cli, stdout, &sd->dacl->aces[i]);
+                               print_ace(cli, stdout, &sd->dacl->aces[i],
+                                         numeric);
                                printf(" not found\n");
                        }
                }
@@ -941,7 +990,8 @@ static int cacl_set(struct cli_state *cli, const char *filename,
                                fstring str;
 
                                SidToString(cli, str,
-                                           &sd->dacl->aces[i].trustee);
+                                           &sd->dacl->aces[i].trustee,
+                                           numeric);
                                printf("ACL for SID %s not found\n", str);
                        }
                }
@@ -1026,12 +1076,15 @@ static int inherit(struct cli_state *cli, const char *filename,
                        }
                        string_replace(parentname, '/', '\\');
                        parent = get_secdesc(cli,parentname);
+                       if (parent == NULL) {
+                               return EXIT_FAILED;
+                       }
                        for (i=0;i<parent->dacl->num_aces;i++) {
                                struct security_ace *ace=&parent->dacl->aces[i];
                                /* Add inherited flag to all aces */
                                ace->flags=ace->flags|
                                           SEC_ACE_FLAG_INHERITED_ACE;
-                               if ((oldattr & aDIR) == aDIR) {
+                               if ((oldattr & FILE_ATTRIBUTE_DIRECTORY) == FILE_ATTRIBUTE_DIRECTORY) {
                                        if ((ace->flags & SEC_ACE_FLAG_CONTAINER_INHERIT) ==
                                            SEC_ACE_FLAG_CONTAINER_INHERIT) {
                                                add_ace(&old->dacl, ace);
@@ -1113,12 +1166,9 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
                                     const char *server, const char *share)
 {
        struct cli_state *c = NULL;
-       struct sockaddr_storage ss;
        NTSTATUS nt_status;
        uint32_t flags = 0;
 
-       zero_sockaddr(&ss);
-
        if (get_cmdline_auth_info_use_kerberos(auth_info)) {
                flags |= CLI_FULL_CONNECTION_USE_KERBEROS |
                         CLI_FULL_CONNECTION_FALLBACK_AFTER_KERBEROS;
@@ -1131,15 +1181,14 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
 
        set_cmdline_auth_info_getpass(auth_info);
 
-       nt_status = cli_full_connection(&c, global_myname(), server, 
-                               &ss, 0,
+       nt_status = cli_full_connection(&c, lp_netbios_name(), server,
+                               NULL, 0,
                                share, "?????",
                                get_cmdline_auth_info_username(auth_info),
                                lp_workgroup(),
                                get_cmdline_auth_info_password(auth_info),
                                flags,
-                               get_cmdline_auth_info_signing_state(auth_info),
-                               NULL);
+                               get_cmdline_auth_info_signing_state(auth_info));
        if (!NT_STATUS_IS_OK(nt_status)) {
                DEBUG(0,("cli_full_connection failed! (%s)\n", nt_errstr(nt_status)));
                return NULL;
@@ -1163,8 +1212,9 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
 /****************************************************************************
   main program
 ****************************************************************************/
- int main(int argc, const char *argv[])
+int main(int argc, char *argv[])
 {
+       const char **argv_const = discard_const_p(const char *, argv);
        char *share;
        int opt;
        enum acl_mode mode = SMB_ACL_SET;
@@ -1174,6 +1224,10 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
        char *path;
        char *filename = NULL;
        poptContext pc;
+       /* numeric is set when the user wants numeric SIDs and ACEs rather
+          than going via LSA calls to resolve them */
+       int numeric;
+
        struct poptOption long_options[] = {
                POPT_AUTOHELP
                { "delete", 'D', POPT_ARG_STRING, NULL, 'D', "Delete an acl", "ACL" },
@@ -1185,7 +1239,15 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
                { "inherit", 'I', POPT_ARG_STRING, NULL, 'I', "Inherit allow|remove|copy" },
                { "numeric", 0, POPT_ARG_NONE, &numeric, 1, "Don't resolve sids or masks to names" },
                { "sddl", 0, POPT_ARG_NONE, &sddl, 1, "Output and input acls in sddl format" },
+               { "query-security-info", 0, POPT_ARG_INT, &query_sec_info, 1,
+                 "The security-info flags for queries"
+               },
+               { "set-security-info", 0, POPT_ARG_INT, &set_sec_info, 1,
+                 "The security-info flags for modifications"
+               },
                { "test-args", 't', POPT_ARG_NONE, &test_args, 1, "Test arguments"},
+               { "domain-sid", 0, POPT_ARG_STRING, &domain_sid, 0, "Domain SID for sddl", "SID"},
+               { "max-protocol", 'm', POPT_ARG_STRING, NULL, 'm', "Set the max protocol level", "LEVEL" },
                POPT_COMMON_SAMBA
                POPT_COMMON_CONNECTION
                POPT_COMMON_CREDENTIALS
@@ -1198,20 +1260,14 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
        char *server;
        struct user_auth_info *auth_info;
 
-       load_case_tables();
-
+       smb_init_locale();
 
        /* set default debug level to 1 regardless of what smb.conf sets */
-       setup_logging( "smbcacls", True );
-       DEBUGLEVEL_CLASS[DBGC_ALL] = 1;
-       dbf = x_stderr;
-       x_setbuf( x_stderr, NULL );
-       AllowDebugChange = false;
+       setup_logging( "smbcacls", DEBUG_STDERR);
+       lp_set_cmdline("log level", "1");
 
        setlinebuf(stdout);
 
-       lp_load(get_dyn_CONFIGFILE(),True,False,False,True);
-       load_interfaces();
 
        auth_info = user_auth_info_init(frame);
        if (auth_info == NULL) {
@@ -1219,7 +1275,7 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
        }
        popt_common_set_auth_info(auth_info);
 
-       pc = poptGetContext("smbcacls", argc, argv, long_options, 0);
+       pc = poptGetContext("smbcacls", argc, argv_const, long_options, 0);
 
        poptSetOtherOptionHelp(pc, "//server1/share1 filename\nACLs look like: "
                "'ACL:user:[ALLOWED|DENIED]/flags/permissions'");
@@ -1260,6 +1316,9 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
                        owner_username = poptGetOptArg(pc);
                        change_mode = REQUEST_INHERIT;
                        break;
+               case 'm':
+                       lp_set_cmdline("client max protocol", poptGetOptArg(pc));
+                       break;
                }
        }
 
@@ -1279,11 +1338,17 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
                return -1;
        }
 
+       lp_load_global(get_dyn_CONFIGFILE());
+       load_interfaces();
+
        filename = talloc_strdup(frame, poptGetArg(pc));
        if (!filename) {
                return -1;
        }
 
+       poptFreeContext(pc);
+       popt_burn_cmdline_password(argc, argv);
+
        string_replace(path,'/','\\');
 
        server = talloc_strdup(frame, path+2);
@@ -1325,9 +1390,9 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
        } else if (change_mode != REQUEST_NONE) {
                result = owner_set(cli, change_mode, filename, owner_username);
        } else if (the_acl) {
-               result = cacl_set(cli, filename, the_acl, mode);
+               result = cacl_set(cli, filename, the_acl, mode, numeric);
        } else {
-               result = cacl_dump(cli, filename);
+               result = cacl_dump(cli, filename, numeric);
        }
 
        TALLOC_FREE(frame);