smbd: Log smb2 requests returning !OK with higher log level
[obnox/samba/samba-obnox.git] / source3 / smbd / smb2_server.c
index 16c6fd4134864939833cacf8bc60ecdaa7e493a6..a53ddf8527d81fa8aaa79e0a43eeca1a1a25fdc5 100644 (file)
 #include "smbprofile.h"
 #include "../lib/util/bitmap.h"
 #include "../librpc/gen_ndr/krb5pac.h"
+#include "lib/util/iov_buf.h"
 #include "auth.h"
+#include "lib/crypto/sha512.h"
 
 static void smbd_smb2_connection_handler(struct tevent_context *ev,
                                         struct tevent_fd *fde,
                                         uint16_t flags,
                                         void *private_data);
-static NTSTATUS smbd_smb2_flush_send_queue(struct smbd_server_connection *sconn);
+static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn);
 
 static const struct smbd_smb2_dispatch_table {
        uint16_t opcode;
@@ -114,7 +116,7 @@ static const struct smbd_smb2_dispatch_table {
                _OP(SMB2_OP_KEEPALIVE),
                .as_root = true,
        },{
-               _OP(SMB2_OP_FIND),
+               _OP(SMB2_OP_QUERY_DIRECTORY),
                .need_session = true,
                .need_tcon = true,
                .fileid_ofs = 0x08,
@@ -198,10 +200,8 @@ bool smbd_is_smb2_header(const uint8_t *inbuf, size_t size)
        return true;
 }
 
-static NTSTATUS smbd_initialize_smb2(struct smbd_server_connection *sconn)
+static NTSTATUS smbd_initialize_smb2(struct smbXsrv_connection *xconn)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
-
        TALLOC_FREE(xconn->transport.fde);
 
        xconn->smb2.credits.seq_low = 0;
@@ -214,12 +214,12 @@ static NTSTATUS smbd_initialize_smb2(struct smbd_server_connection *sconn)
                return NT_STATUS_NO_MEMORY;
        }
 
-       xconn->transport.fde = tevent_add_fd(sconn->ev_ctx,
-                                       sconn,
+       xconn->transport.fde = tevent_add_fd(xconn->ev_ctx,
+                                       xconn,
                                        xconn->transport.sock,
                                        TEVENT_FD_READ,
                                        smbd_smb2_connection_handler,
-                                       sconn);
+                                       xconn);
        if (xconn->transport.fde == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -238,16 +238,22 @@ static NTSTATUS smbd_initialize_smb2(struct smbd_server_connection *sconn)
        buf[3] = (len)&0xFF; \
 } while (0)
 
-static void smb2_setup_nbt_length(struct iovec *vector, int count)
+static bool smb2_setup_nbt_length(struct iovec *vector, int count)
 {
-       size_t len = 0;
-       int i;
+       ssize_t len;
 
-       for (i=1; i < count; i++) {
-               len += vector[i].iov_len;
+       if (count == 0) {
+               return false;
+       }
+
+       len = iov_buflen(vector+1, count-1);
+
+       if ((len == -1) || (len > 0xFFFFFF)) {
+               return false;
        }
 
        _smb2_setlen(vector[0].iov_base, len);
+       return true;
 }
 
 static int smbd_smb2_request_destructor(struct smbd_smb2_request *req)
@@ -294,7 +300,7 @@ static struct smbd_smb2_request *smbd_smb2_request_allocate(TALLOC_CTX *mem_ctx)
        return req;
 }
 
-static NTSTATUS smbd_smb2_inbuf_parse_compound(struct smbXsrv_connection *conn,
+static NTSTATUS smbd_smb2_inbuf_parse_compound(struct smbXsrv_connection *xconn,
                                               NTTIME now,
                                               uint8_t *buf,
                                               size_t buflen,
@@ -351,19 +357,19 @@ static NTSTATUS smbd_smb2_inbuf_parse_compound(struct smbXsrv_connection *conn,
                        NTSTATUS status;
                        size_t enc_len;
 
-                       if (conn->protocol < PROTOCOL_SMB2_24) {
+                       if (xconn->protocol < PROTOCOL_SMB2_24) {
                                DEBUG(10, ("Got SMB2_TRANSFORM header, "
                                           "but dialect[0x%04X] is used\n",
-                                          conn->smb2.server.dialect));
+                                          xconn->smb2.server.dialect));
                                goto inval;
                        }
 
-                       if (!(conn->smb2.server.capabilities & SMB2_CAP_ENCRYPTION)) {
+                       if (xconn->smb2.server.cipher == 0) {
                                DEBUG(10, ("Got SMB2_TRANSFORM header, "
                                           "but not negotiated "
                                           "client[0x%08X] server[0x%08X]\n",
-                                          conn->smb2.client.capabilities,
-                                          conn->smb2.server.capabilities));
+                                          xconn->smb2.client.capabilities,
+                                          xconn->smb2.server.capabilities));
                                goto inval;
                        }
 
@@ -387,7 +393,8 @@ static NTSTATUS smbd_smb2_inbuf_parse_compound(struct smbXsrv_connection *conn,
                                goto inval;
                        }
 
-                       status = smb2srv_session_lookup(conn, uid, now, &s);
+                       status = smb2srv_session_lookup_conn(xconn, uid, now,
+                                                            &s);
                        if (s == NULL) {
                                DEBUG(1, ("invalid session[%llu] in "
                                          "SMB2_TRANSFORM header\n",
@@ -402,7 +409,7 @@ static NTSTATUS smbd_smb2_inbuf_parse_compound(struct smbXsrv_connection *conn,
                        tf_iov[1].iov_len = enc_len;
 
                        status = smb2_signing_decrypt_pdu(s->global->decryption_key,
-                                                         conn->protocol,
+                                                         xconn->smb2.server.cipher,
                                                          tf_iov, 2);
                        if (!NT_STATUS_IS_OK(status)) {
                                TALLOC_FREE(iov_alloc);
@@ -507,25 +514,26 @@ inval:
        return NT_STATUS_INVALID_PARAMETER;
 }
 
-static NTSTATUS smbd_smb2_request_create(struct smbd_server_connection *sconn,
-                                        uint8_t *inbuf, size_t size,
+static NTSTATUS smbd_smb2_request_create(struct smbXsrv_connection *xconn,
+                                        const uint8_t *_inpdu, size_t size,
                                         struct smbd_smb2_request **_req)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        struct smbd_smb2_request *req;
        uint32_t protocol_version;
+       uint8_t *inpdu = NULL;
        const uint8_t *inhdr = NULL;
        uint16_t cmd;
        uint32_t next_command_ofs;
        NTSTATUS status;
        NTTIME now;
 
-       if (size < (4 + SMB2_HDR_BODY + 2)) {
+       if (size < (SMB2_HDR_BODY + 2)) {
                DEBUG(0,("Invalid SMB2 packet length count %ld\n", (long)size));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       inhdr = inbuf + 4;
+       inhdr = _inpdu;
 
        protocol_version = IVAL(inhdr, SMB2_HDR_PROTOCOL_ID);
        if (protocol_version != SMB2_MAGIC) {
@@ -553,16 +561,20 @@ static NTSTATUS smbd_smb2_request_create(struct smbd_server_connection *sconn,
                return NT_STATUS_NO_MEMORY;
        }
        req->sconn = sconn;
+       req->xconn = xconn;
 
-       talloc_steal(req, inbuf);
+       inpdu = talloc_memdup(req, _inpdu, size);
+       if (inpdu == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        req->request_time = timeval_current();
        now = timeval_to_nttime(&req->request_time);
 
-       status = smbd_smb2_inbuf_parse_compound(sconn->conn,
+       status = smbd_smb2_inbuf_parse_compound(xconn,
                                                now,
-                                               inbuf + NBT_HDR_SIZE,
-                                               size - NBT_HDR_SIZE,
+                                               inpdu,
+                                               size,
                                                req, &req->in.vector,
                                                &req->in.vector_count);
        if (!NT_STATUS_IS_OK(status)) {
@@ -576,10 +588,9 @@ static NTSTATUS smbd_smb2_request_create(struct smbd_server_connection *sconn,
        return NT_STATUS_OK;
 }
 
-static bool smb2_validate_sequence_number(struct smbd_server_connection *sconn,
+static bool smb2_validate_sequence_number(struct smbXsrv_connection *xconn,
                                          uint64_t message_id, uint64_t seq_id)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
        struct bitmap *credits_bm = xconn->smb2.credits.bitmap;
        unsigned int offset;
        uint64_t seq_tmp;
@@ -652,10 +663,9 @@ static bool smb2_validate_sequence_number(struct smbd_server_connection *sconn,
        return true;
 }
 
-static bool smb2_validate_message_id(struct smbd_server_connection *sconn,
-                               const uint8_t *inhdr)
+static bool smb2_validate_message_id(struct smbXsrv_connection *xconn,
+                                    const uint8_t *inhdr)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
        uint64_t message_id = BVAL(inhdr, SMB2_HDR_MESSAGE_ID);
        uint16_t opcode = SVAL(inhdr, SMB2_HDR_OPCODE);
        uint16_t credit_charge = 1;
@@ -710,7 +720,7 @@ static bool smb2_validate_message_id(struct smbd_server_connection *sconn,
                           credit_charge,
                           (unsigned long long)id));
 
-               ok = smb2_validate_sequence_number(sconn, message_id, id);
+               ok = smb2_validate_sequence_number(xconn, message_id, id);
                if (!ok) {
                        return false;
                }
@@ -754,7 +764,7 @@ static NTSTATUS smbd_smb2_request_validate(struct smbd_smb2_request *req)
                        return NT_STATUS_INVALID_PARAMETER;
                }
 
-               if (!smb2_validate_message_id(req->sconn, inhdr)) {
+               if (!smb2_validate_message_id(req->xconn, inhdr)) {
                        return NT_STATUS_INVALID_PARAMETER;
                }
        }
@@ -762,11 +772,10 @@ static NTSTATUS smbd_smb2_request_validate(struct smbd_smb2_request *req)
        return NT_STATUS_OK;
 }
 
-static void smb2_set_operation_credit(struct smbd_server_connection *sconn,
-                       const struct iovec *in_vector,
-                       struct iovec *out_vector)
+static void smb2_set_operation_credit(struct smbXsrv_connection *xconn,
+                                     const struct iovec *in_vector,
+                                     struct iovec *out_vector)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
        const uint8_t *inhdr = (const uint8_t *)in_vector->iov_base;
        uint8_t *outhdr = (uint8_t *)out_vector->iov_base;
        uint16_t credit_charge = 1;
@@ -802,13 +811,14 @@ static void smb2_set_operation_credit(struct smbd_server_connection *sconn,
 
        cmd = SVAL(inhdr, SMB2_HDR_OPCODE);
        credits_requested = SVAL(inhdr, SMB2_HDR_CREDIT);
+       credits_requested = MAX(credits_requested, 1);
        out_flags = IVAL(outhdr, SMB2_HDR_FLAGS);
        out_status = NT_STATUS(IVAL(outhdr, SMB2_HDR_STATUS));
 
        SMB_ASSERT(xconn->smb2.credits.max >= xconn->smb2.credits.granted);
 
        if (xconn->smb2.credits.max < credit_charge) {
-               smbd_server_connection_terminate(sconn,
+               smbd_server_connection_terminate(xconn,
                        "client error: credit charge > max credits\n");
                return;
        }
@@ -820,7 +830,9 @@ static void smb2_set_operation_credit(struct smbd_server_connection *sconn,
                 * credits on the final response.
                 */
                credits_granted = 0;
-       } else if (credits_requested > 0) {
+       } else {
+               uint16_t additional_possible =
+                       xconn->smb2.credits.max - credit_charge;
                uint16_t additional_max = 0;
                uint16_t additional_credits = credits_requested - 1;
 
@@ -846,14 +858,10 @@ static void smb2_set_operation_credit(struct smbd_server_connection *sconn,
                        break;
                }
 
+               additional_max = MIN(additional_max, additional_possible);
                additional_credits = MIN(additional_credits, additional_max);
 
                credits_granted = credit_charge + additional_credits;
-       } else if (xconn->smb2.credits.granted == 0) {
-               /*
-                * Make sure the client has always at least one credit
-                */
-               credits_granted = 1;
        }
 
        /*
@@ -912,7 +920,7 @@ static void smb2_calculate_credits(const struct smbd_smb2_request *inreq,
                struct iovec *outhdr_v = SMBD_SMB2_IDX_HDR_IOV(outreq,out,idx);
                uint8_t *outhdr = (uint8_t *)outhdr_v->iov_base;
 
-               smb2_set_operation_credit(outreq->sconn, inhdr_v, outhdr_v);
+               smb2_set_operation_credit(outreq->xconn, inhdr_v, outhdr_v);
 
                /* To match Windows, count up what we
                   just granted. */
@@ -939,11 +947,12 @@ DATA_BLOB smbd_smb2_generate_outbody(struct smbd_smb2_request *req, size_t size)
 
 static NTSTATUS smbd_smb2_request_setup_out(struct smbd_smb2_request *req)
 {
-       struct smbXsrv_connection *xconn = req->sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        TALLOC_CTX *mem_ctx;
        struct iovec *vector;
        int count;
        int idx;
+       bool ok;
 
        count = req->in.vector_count;
        if (count <= ARRAY_SIZE(req->out._vector)) {
@@ -1035,14 +1044,17 @@ static NTSTATUS smbd_smb2_request_setup_out(struct smbd_smb2_request *req)
        req->out.vector_count = count;
 
        /* setup the length of the NBT packet */
-       smb2_setup_nbt_length(req->out.vector, req->out.vector_count);
+       ok = smb2_setup_nbt_length(req->out.vector, req->out.vector_count);
+       if (!ok) {
+               return NT_STATUS_INVALID_PARAMETER_MIX;
+       }
 
        DLIST_ADD_END(xconn->smb2.requests, req, struct smbd_smb2_request *);
 
        return NT_STATUS_OK;
 }
 
-void smbd_server_connection_terminate_ex(struct smbd_server_connection *sconn,
+void smbd_server_connection_terminate_ex(struct smbXsrv_connection *xconn,
                                         const char *reason,
                                         const char *location)
 {
@@ -1152,18 +1164,19 @@ static bool dup_smb2_vec4(TALLOC_CTX *ctx,
 
 static struct smbd_smb2_request *dup_smb2_req(const struct smbd_smb2_request *req)
 {
-       struct smbXsrv_connection *xconn = req->sconn->conn;
        struct smbd_smb2_request *newreq = NULL;
        struct iovec *outvec = NULL;
        int count = req->out.vector_count;
        int i;
+       bool ok;
 
-       newreq = smbd_smb2_request_allocate(xconn);
+       newreq = smbd_smb2_request_allocate(req->xconn);
        if (!newreq) {
                return NULL;
        }
 
        newreq->sconn = req->sconn;
+       newreq->xconn = req->xconn;
        newreq->session = req->session;
        newreq->do_encryption = req->do_encryption;
        newreq->do_signing = req->do_signing;
@@ -1195,22 +1208,26 @@ static struct smbd_smb2_request *dup_smb2_req(const struct smbd_smb2_request *re
                return NULL;
        }
 
-       smb2_setup_nbt_length(newreq->out.vector,
-               newreq->out.vector_count);
+       ok = smb2_setup_nbt_length(newreq->out.vector,
+                                  newreq->out.vector_count);
+       if (!ok) {
+               TALLOC_FREE(newreq);
+               return NULL;
+       }
 
        return newreq;
 }
 
 static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request *req)
 {
-       struct smbd_server_connection *sconn = req->sconn;
-       struct smbXsrv_connection *conn = req->sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        int first_idx = 1;
        struct iovec *firsttf = NULL;
        struct iovec *outhdr_v = NULL;
        uint8_t *outhdr = NULL;
        struct smbd_smb2_request *nreq = NULL;
        NTSTATUS status;
+       bool ok;
 
        /* Create a new smb2 request we'll use
           for the interim return. */
@@ -1223,8 +1240,11 @@ static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request
           ones we'll be using for the async reply. */
        nreq->out.vector_count -= SMBD_SMB2_NUM_IOV_PER_REQ;
 
-       smb2_setup_nbt_length(nreq->out.vector,
-               nreq->out.vector_count);
+       ok = smb2_setup_nbt_length(nreq->out.vector,
+                                  nreq->out.vector_count);
+       if (!ok) {
+               return NT_STATUS_INVALID_PARAMETER_MIX;
+       }
 
        /* Step back to the previous reply. */
        nreq->current_idx -= SMBD_SMB2_NUM_IOV_PER_REQ;
@@ -1251,7 +1271,7 @@ static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request
         */
        if (firsttf->iov_len == SMB2_TF_HDR_SIZE) {
                status = smb2_signing_encrypt_pdu(req->first_key,
-                                       conn->protocol,
+                                       xconn->smb2.server.cipher,
                                        firsttf,
                                        nreq->out.vector_count - first_idx);
                if (!NT_STATUS_IS_OK(status)) {
@@ -1259,7 +1279,7 @@ static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request
                }
        } else if (req->last_key.length > 0) {
                status = smb2_signing_sign_pdu(req->last_key,
-                                              conn->protocol,
+                                              xconn->protocol,
                                               outhdr_v,
                                               SMBD_SMB2_NUM_IOV_PER_REQ - 1);
                if (!NT_STATUS_IS_OK(status)) {
@@ -1270,10 +1290,10 @@ static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request
        nreq->queue_entry.mem_ctx = nreq;
        nreq->queue_entry.vector = nreq->out.vector;
        nreq->queue_entry.count = nreq->out.vector_count;
-       DLIST_ADD_END(conn->smb2.send_queue, &nreq->queue_entry, NULL);
-       conn->smb2.send_queue_len++;
+       DLIST_ADD_END(xconn->smb2.send_queue, &nreq->queue_entry, NULL);
+       xconn->smb2.send_queue_len++;
 
-       status = smbd_smb2_flush_send_queue(sconn);
+       status = smbd_smb2_flush_send_queue(xconn);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
@@ -1282,7 +1302,6 @@ static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request
 }
 
 struct smbd_smb2_request_pending_state {
-        struct smbd_server_connection *sconn;
        struct smbd_smb2_send_queue queue_entry;
         uint8_t buf[NBT_HDR_SIZE + SMB2_TF_HDR_SIZE + SMB2_HDR_BODY + 0x08 + 1];
         struct iovec vector[1 + SMBD_SMB2_NUM_IOV_PER_REQ];
@@ -1330,12 +1349,11 @@ NTSTATUS smbd_smb2_request_pending_queue(struct smbd_smb2_request *req,
 
        if (req->in.vector_count > req->current_idx + SMBD_SMB2_NUM_IOV_PER_REQ) {
                /*
-                * We're trying to go async in a compound
-                * request chain.
-                * This is only allowed for opens that
-                * cause an oplock break, otherwise it
-                * is not allowed. See [MS-SMB2].pdf
-                * note <194> on Section 3.3.5.2.7.
+                * We're trying to go async in a compound request
+                * chain. This is only allowed for opens that cause an
+                * oplock break or for the last operation in the
+                * chain, otherwise it is not allowed. See
+                * [MS-SMB2].pdf note <206> on Section 3.3.5.2.7.
                 */
                const uint8_t *inhdr = SMBD_SMB2_IN_HDR_PTR(req);
 
@@ -1422,6 +1440,60 @@ NTSTATUS smbd_smb2_request_pending_queue(struct smbd_smb2_request *req,
        return NT_STATUS_OK;
 }
 
+static DATA_BLOB smbd_smb2_signing_key(struct smbXsrv_session *session,
+                                      struct smbXsrv_connection *xconn)
+{
+       struct smbXsrv_channel_global0 *c = NULL;
+       NTSTATUS status;
+       DATA_BLOB key = data_blob_null;
+
+       status = smbXsrv_session_find_channel(session, xconn, &c);
+       if (NT_STATUS_IS_OK(status)) {
+               key = c->signing_key;
+       }
+
+       if (key.length == 0) {
+               key = session->global->signing_key;
+       }
+
+       return key;
+}
+
+static NTSTATUS smb2_get_new_nonce(struct smbXsrv_session *session,
+                                  uint64_t *new_nonce_high,
+                                  uint64_t *new_nonce_low)
+{
+       uint64_t nonce_high;
+       uint64_t nonce_low;
+
+       session->nonce_low += 1;
+       if (session->nonce_low == 0) {
+               session->nonce_low += 1;
+               session->nonce_high += 1;
+       }
+
+       /*
+        * CCM and GCM algorithms must never have their
+        * nonce wrap, or the security of the whole
+        * communication and the keys is destroyed.
+        * We must drop the connection once we have
+        * transfered too much data.
+        *
+        * NOTE: We assume nonces greater than 8 bytes.
+        */
+       if (session->nonce_high >= session->nonce_high_max) {
+               return NT_STATUS_ENCRYPTION_FAILED;
+       }
+
+       nonce_high = session->nonce_high_random;
+       nonce_high += session->nonce_high;
+       nonce_low = session->nonce_low;
+
+       *new_nonce_high = nonce_high;
+       *new_nonce_low = nonce_low;
+       return NT_STATUS_OK;
+}
+
 static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
                                            struct tevent_timer *te,
                                            struct timeval current_time,
@@ -1430,8 +1502,7 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
        struct smbd_smb2_request *req =
                talloc_get_type_abort(private_data,
                struct smbd_smb2_request);
-       struct smbd_server_connection *sconn = req->sconn;
-       struct smbXsrv_connection *xconn = sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        struct smbd_smb2_request_pending_state *state = NULL;
        uint8_t *outhdr = NULL;
        const uint8_t *inhdr = NULL;
@@ -1447,6 +1518,7 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
        uint64_t nonce_low = 0;
        uint64_t async_id = 0;
        NTSTATUS status;
+       bool ok;
 
        TALLOC_FREE(req->async_te);
 
@@ -1473,13 +1545,12 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
         * of this fact sometime when refactoring. JRA.
         */
 
-       state = talloc_zero(req->sconn, struct smbd_smb2_request_pending_state);
+       state = talloc_zero(req->xconn, struct smbd_smb2_request_pending_state);
        if (state == NULL) {
-               smbd_server_connection_terminate(req->sconn,
+               smbd_server_connection_terminate(xconn,
                                                 nt_errstr(NT_STATUS_NO_MEMORY));
                return;
        }
-       state->sconn = req->sconn;
 
        tf = state->buf + NBT_HDR_SIZE;
        tf_len = SMB2_TF_HDR_SIZE;
@@ -1489,15 +1560,13 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
        dyn = body + 8;
 
        if (req->do_encryption) {
-               struct smbXsrv_session *x = req->session;
-
-               nonce_high = x->nonce_high;
-               nonce_low = x->nonce_low;
-
-               x->nonce_low += 1;
-               if (x->nonce_low == 0) {
-                       x->nonce_low += 1;
-                       x->nonce_high += 1;
+               status = smb2_get_new_nonce(req->session,
+                                           &nonce_high,
+                                           &nonce_low);
+               if (!NT_STATUS_IS_OK(status)) {
+                       smbd_server_connection_terminate(xconn,
+                                                        nt_errstr(status));
+                       return;
                }
        }
 
@@ -1549,12 +1618,18 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
        state->vector[1+SMBD_SMB2_DYN_IOV_OFS].iov_base  = dyn;
        state->vector[1+SMBD_SMB2_DYN_IOV_OFS].iov_len   = 1;
 
-       smb2_setup_nbt_length(state->vector, 1 + SMBD_SMB2_NUM_IOV_PER_REQ);
+       ok = smb2_setup_nbt_length(state->vector,
+                                  1 + SMBD_SMB2_NUM_IOV_PER_REQ);
+       if (!ok) {
+               smbd_server_connection_terminate(
+                       xconn, nt_errstr(NT_STATUS_INTERNAL_ERROR));
+               return;
+       }
 
        /* Ensure we correctly go through crediting. Grant
           the credits now, and zero credits on the final
           response. */
-       smb2_set_operation_credit(req->sconn,
+       smb2_set_operation_credit(req->xconn,
                        SMBD_SMB2_IN_HDR_IOV(req),
                        &state->vector[1+SMBD_SMB2_HDR_IOV_OFS]);
 
@@ -1576,24 +1651,24 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
                DATA_BLOB encryption_key = x->global->encryption_key;
 
                status = smb2_signing_encrypt_pdu(encryption_key,
-                                       xconn->protocol,
+                                       xconn->smb2.server.cipher,
                                        &state->vector[1+SMBD_SMB2_TF_IOV_OFS],
                                        SMBD_SMB2_NUM_IOV_PER_REQ);
                if (!NT_STATUS_IS_OK(status)) {
-                       smbd_server_connection_terminate(req->sconn,
+                       smbd_server_connection_terminate(xconn,
                                                nt_errstr(status));
                        return;
                }
        } else if (req->do_signing) {
                struct smbXsrv_session *x = req->session;
-               DATA_BLOB signing_key = x->global->channels[0].signing_key;
+               DATA_BLOB signing_key = smbd_smb2_signing_key(x, xconn);
 
                status = smb2_signing_sign_pdu(signing_key,
                                        xconn->protocol,
                                        &state->vector[1+SMBD_SMB2_HDR_IOV_OFS],
                                        SMBD_SMB2_NUM_IOV_PER_REQ - 1);
                if (!NT_STATUS_IS_OK(status)) {
-                       smbd_server_connection_terminate(req->sconn,
+                       smbd_server_connection_terminate(xconn,
                                                nt_errstr(status));
                        return;
                }
@@ -1605,9 +1680,9 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
        DLIST_ADD_END(xconn->smb2.send_queue, &state->queue_entry, NULL);
        xconn->smb2.send_queue_len++;
 
-       status = smbd_smb2_flush_send_queue(sconn);
+       status = smbd_smb2_flush_send_queue(xconn);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn,
+               smbd_server_connection_terminate(xconn,
                                                 nt_errstr(status));
                return;
        }
@@ -1615,8 +1690,7 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
 
 static NTSTATUS smbd_smb2_request_process_cancel(struct smbd_smb2_request *req)
 {
-       struct smbd_server_connection *sconn = req->sconn;
-       struct smbXsrv_connection *xconn = sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        struct smbd_smb2_request *cur;
        const uint8_t *inhdr;
        uint32_t flags;
@@ -1759,10 +1833,26 @@ static NTSTATUS smbd_smb2_request_check_session(struct smbd_smb2_request *req)
 
        req->last_session_id = 0;
 
-       /* lookup an existing session */
-       status = smb2srv_session_lookup(req->sconn->conn,
-                                       in_session_id, now,
-                                       &session);
+       /* look an existing session up */
+       switch (in_opcode) {
+       case SMB2_OP_SESSSETUP:
+               /*
+                * For a session bind request, we don't have the
+                * channel set up at this point yet, so we defer
+                * the verification that the connection belongs
+                * to the session to the session setup code, which
+                * can look at the session binding flags.
+                */
+               status = smb2srv_session_lookup_client(req->xconn->client,
+                                                      in_session_id, now,
+                                                      &session);
+               break;
+       default:
+               status = smb2srv_session_lookup_conn(req->xconn,
+                                                    in_session_id, now,
+                                                    &session);
+               break;
+       }
        if (session) {
                req->session = session;
                req->last_session_id = in_session_id;
@@ -1802,8 +1892,8 @@ static NTSTATUS smbd_smb2_request_check_session(struct smbd_smb2_request *req)
                return NT_STATUS_INVALID_HANDLE;
        }
 
-       if (in_session_id != req->sconn->conn->last_session_id) {
-               req->sconn->conn->last_session_id = in_session_id;
+       if (in_session_id != req->xconn->client->last_session_id) {
+               req->xconn->client->last_session_id = in_session_id;
                set_current_user_info(session_info->unix_info->sanitized_username,
                                      session_info->unix_info->unix_name,
                                      session_info->info->domain_name);
@@ -1815,7 +1905,7 @@ static NTSTATUS smbd_smb2_request_check_session(struct smbd_smb2_request *req)
 NTSTATUS smbd_smb2_request_verify_creditcharge(struct smbd_smb2_request *req,
                                                uint32_t data_length)
 {
-       struct smbXsrv_connection *xconn = req->sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        uint16_t needed_charge;
        uint16_t credit_charge = 1;
        const uint8_t *inhdr;
@@ -1914,7 +2004,7 @@ NTSTATUS smbd_smb2_request_verify_sizes(struct smbd_smb2_request *req,
 
 NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
 {
-       struct smbXsrv_connection *conn = req->sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        const struct smbd_smb2_dispatch_table *call = NULL;
        const struct iovec *intf_v = SMBD_SMB2_IN_TF_IOV(req);
        const uint8_t *inhdr;
@@ -1927,10 +2017,13 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
        NTSTATUS return_value;
        struct smbXsrv_session *x = NULL;
        bool signing_required = false;
+       bool encryption_desired = false;
        bool encryption_required = false;
 
        inhdr = SMBD_SMB2_IN_HDR_PTR(req);
 
+       DO_PROFILE_INC(request);
+
        /* TODO: verify more things */
 
        flags = IVAL(inhdr, SMB2_HDR_FLAGS);
@@ -1940,7 +2033,7 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                smb2_opcode_name(opcode),
                (unsigned long long)mid));
 
-       if (conn->protocol >= PROTOCOL_SMB2_02) {
+       if (xconn->protocol >= PROTOCOL_SMB2_02) {
                /*
                 * once the protocol is negotiated
                 * SMB2_OP_NEGPROT is not allowed anymore
@@ -1972,16 +2065,13 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
        x = req->session;
        if (x != NULL) {
                signing_required = x->global->signing_required;
+               encryption_desired = x->encryption_desired;
                encryption_required = x->global->encryption_required;
-
-               if (opcode == SMB2_OP_SESSSETUP &&
-                   x->global->channels[0].signing_key.length) {
-                       signing_required = true;
-               }
        }
 
        req->do_signing = false;
        req->do_encryption = false;
+       req->was_encrypted = false;
        if (intf_v->iov_len == SMB2_TF_HDR_SIZE) {
                const uint8_t *intf = SMBD_SMB2_IN_TF_PTR(req);
                uint64_t tf_session_id = BVAL(intf, SMB2_TF_SESSION_ID);
@@ -2003,10 +2093,10 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                                        NT_STATUS_ACCESS_DENIED);
                }
 
-               req->do_encryption = true;
+               req->was_encrypted = true;
        }
 
-       if (encryption_required && !req->do_encryption) {
+       if (encryption_required && !req->was_encrypted) {
                return smbd_smb2_request_error(req,
                                NT_STATUS_ACCESS_DENIED);
        }
@@ -2019,6 +2109,14 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
        allowed_flags = SMB2_HDR_FLAG_CHAINED |
                        SMB2_HDR_FLAG_SIGNED |
                        SMB2_HDR_FLAG_DFS;
+       if (xconn->protocol >= PROTOCOL_SMB3_11) {
+               allowed_flags |= SMB2_HDR_FLAG_PRIORITY_MASK;
+       }
+       if (opcode == SMB2_OP_NEGPROT) {
+               if (lp_server_max_protocol() >= PROTOCOL_SMB3_11) {
+                       allowed_flags |= SMB2_HDR_FLAG_PRIORITY_MASK;
+               }
+       }
        if (opcode == SMB2_OP_CANCEL) {
                allowed_flags |= SMB2_HDR_FLAG_ASYNC;
        }
@@ -2038,10 +2136,10 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                req->compat_chain_fsp = NULL;
        }
 
-       if (req->do_encryption) {
+       if (req->was_encrypted) {
                signing_required = false;
        } else if (signing_required || (flags & SMB2_HDR_FLAG_SIGNED)) {
-               DATA_BLOB signing_key;
+               DATA_BLOB signing_key = data_blob_null;
 
                if (x == NULL) {
                        /*
@@ -2063,7 +2161,7 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                        return smbd_smb2_request_error(req, status);
                }
 
-               signing_key = x->global->channels[0].signing_key;
+               signing_key = smbd_smb2_signing_key(x, xconn);
 
                /*
                 * If we have a signing key, we should
@@ -2074,7 +2172,7 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                }
 
                status = smb2_signing_check_pdu(signing_key,
-                                               conn->protocol,
+                                               xconn->protocol,
                                                SMBD_SMB2_IN_HDR_IOV(req),
                                                SMBD_SMB2_NUM_IOV_PER_REQ - 1);
                if (!NT_STATUS_IS_OK(status)) {
@@ -2124,15 +2222,22 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                if (!NT_STATUS_IS_OK(status)) {
                        return smbd_smb2_request_error(req, status);
                }
+               if (req->tcon->encryption_desired) {
+                       encryption_desired = true;
+               }
                if (req->tcon->global->encryption_required) {
                        encryption_required = true;
                }
-               if (encryption_required && !req->do_encryption) {
+               if (encryption_required && !req->was_encrypted) {
                        return smbd_smb2_request_error(req,
                                NT_STATUS_ACCESS_DENIED);
                }
        }
 
+       if (req->was_encrypted || encryption_desired) {
+               req->do_encryption = true;
+       }
+
        if (call->fileid_ofs != 0) {
                size_t needed = call->fileid_ofs + 16;
                const uint8_t *body = SMBD_SMB2_IN_BODY_PTR(req);
@@ -2177,157 +2282,127 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                SMB_ASSERT(call->need_tcon);
        }
 
+#define _INBYTES(_r) \
+       iov_buflen(SMBD_SMB2_IN_HDR_IOV(_r), SMBD_SMB2_NUM_IOV_PER_REQ-1)
+
        switch (opcode) {
        case SMB2_OP_NEGPROT:
-               {
-                       START_PROFILE(smb2_negprot);
-                       return_value = smbd_smb2_request_process_negprot(req);
-                       END_PROFILE(smb2_negprot);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_negprot, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_negprot(req);
                break;
 
        case SMB2_OP_SESSSETUP:
-               {
-                       START_PROFILE(smb2_sesssetup);
-                       return_value = smbd_smb2_request_process_sesssetup(req);
-                       END_PROFILE(smb2_sesssetup);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_sesssetup, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_sesssetup(req);
                break;
 
        case SMB2_OP_LOGOFF:
-               {
-                       START_PROFILE(smb2_logoff);
-                       return_value = smbd_smb2_request_process_logoff(req);
-                       END_PROFILE(smb2_logoff);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_logoff, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_logoff(req);
                break;
 
        case SMB2_OP_TCON:
-               {
-                       START_PROFILE(smb2_tcon);
-                       return_value = smbd_smb2_request_process_tcon(req);
-                       END_PROFILE(smb2_tcon);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_tcon, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_tcon(req);
                break;
 
        case SMB2_OP_TDIS:
-               {
-                       START_PROFILE(smb2_tdis);
-                       return_value = smbd_smb2_request_process_tdis(req);
-                       END_PROFILE(smb2_tdis);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_tdis, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_tdis(req);
                break;
 
        case SMB2_OP_CREATE:
-               {
-                       START_PROFILE(smb2_create);
-                       return_value = smbd_smb2_request_process_create(req);
-                       END_PROFILE(smb2_create);
+               if (req->subreq == NULL) {
+                       SMBPROFILE_IOBYTES_ASYNC_START(smb2_create, profile_p,
+                                                      req->profile, _INBYTES(req));
+               } else {
+                       SMBPROFILE_IOBYTES_ASYNC_SET_BUSY(req->profile);
                }
+               return_value = smbd_smb2_request_process_create(req);
                break;
 
        case SMB2_OP_CLOSE:
-               {
-                       START_PROFILE(smb2_close);
-                       return_value = smbd_smb2_request_process_close(req);
-                       END_PROFILE(smb2_close);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_close, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_close(req);
                break;
 
        case SMB2_OP_FLUSH:
-               {
-                       START_PROFILE(smb2_flush);
-                       return_value = smbd_smb2_request_process_flush(req);
-                       END_PROFILE(smb2_flush);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_flush, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_flush(req);
                break;
 
        case SMB2_OP_READ:
-               {
-                       START_PROFILE(smb2_read);
-                       return_value = smbd_smb2_request_process_read(req);
-                       END_PROFILE(smb2_read);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_read, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_read(req);
                break;
 
        case SMB2_OP_WRITE:
-               {
-                       START_PROFILE(smb2_write);
-                       return_value = smbd_smb2_request_process_write(req);
-                       END_PROFILE(smb2_write);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_write, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_write(req);
                break;
 
        case SMB2_OP_LOCK:
-               {
-                       START_PROFILE(smb2_lock);
-                       return_value = smbd_smb2_request_process_lock(req);
-                       END_PROFILE(smb2_lock);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_lock, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_lock(req);
                break;
 
        case SMB2_OP_IOCTL:
-               {
-                       START_PROFILE(smb2_ioctl);
-                       return_value = smbd_smb2_request_process_ioctl(req);
-                       END_PROFILE(smb2_ioctl);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_ioctl, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_ioctl(req);
                break;
 
        case SMB2_OP_CANCEL:
-               {
-                       START_PROFILE(smb2_cancel);
-                       return_value = smbd_smb2_request_process_cancel(req);
-                       END_PROFILE(smb2_cancel);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_cancel, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_cancel(req);
+               SMBPROFILE_IOBYTES_ASYNC_END(req->profile, 0);
                break;
 
        case SMB2_OP_KEEPALIVE:
-               {
-                       START_PROFILE(smb2_keepalive);
-                       return_value = smbd_smb2_request_process_keepalive(req);
-                       END_PROFILE(smb2_keepalive);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_keepalive, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_keepalive(req);
                break;
 
-       case SMB2_OP_FIND:
-               {
-                       START_PROFILE(smb2_find);
-                       return_value = smbd_smb2_request_process_find(req);
-                       END_PROFILE(smb2_find);
-               }
+       case SMB2_OP_QUERY_DIRECTORY:
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_find, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_query_directory(req);
                break;
 
        case SMB2_OP_NOTIFY:
-               {
-                       START_PROFILE(smb2_notify);
-                       return_value = smbd_smb2_request_process_notify(req);
-                       END_PROFILE(smb2_notify);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_notify, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_notify(req);
                break;
 
        case SMB2_OP_GETINFO:
-               {
-                       START_PROFILE(smb2_getinfo);
-                       return_value = smbd_smb2_request_process_getinfo(req);
-                       END_PROFILE(smb2_getinfo);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_getinfo, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_getinfo(req);
                break;
 
        case SMB2_OP_SETINFO:
-               {
-                       START_PROFILE(smb2_setinfo);
-                       return_value = smbd_smb2_request_process_setinfo(req);
-                       END_PROFILE(smb2_setinfo);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_setinfo, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_setinfo(req);
                break;
 
        case SMB2_OP_BREAK:
-               {
-                       START_PROFILE(smb2_break);
-                       return_value = smbd_smb2_request_process_break(req);
-                       END_PROFILE(smb2_break);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_break, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_break(req);
                break;
 
        default:
@@ -2339,13 +2414,13 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
 
 static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
 {
-       struct smbd_server_connection *sconn = req->sconn;
-       struct smbXsrv_connection *conn = req->sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        int first_idx = 1;
        struct iovec *firsttf = SMBD_SMB2_IDX_TF_IOV(req,out,first_idx);
        struct iovec *outhdr = SMBD_SMB2_OUT_HDR_IOV(req);
        struct iovec *outdyn = SMBD_SMB2_OUT_DYN_IOV(req);
        NTSTATUS status;
+       bool ok;
 
        req->subreq = NULL;
        TALLOC_FREE(req->async_te);
@@ -2359,17 +2434,14 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                DATA_BLOB encryption_key = req->session->global->encryption_key;
                uint8_t *tf;
                uint64_t session_id = req->session->global->session_wire_id;
-               struct smbXsrv_session *x = req->session;
                uint64_t nonce_high;
                uint64_t nonce_low;
 
-               nonce_high = x->nonce_high;
-               nonce_low = x->nonce_low;
-
-               x->nonce_low += 1;
-               if (x->nonce_low == 0) {
-                       x->nonce_low += 1;
-                       x->nonce_high += 1;
+               status = smb2_get_new_nonce(req->session,
+                                           &nonce_high,
+                                           &nonce_low);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
 
                /*
@@ -2416,7 +2488,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                 * with the last signing key we remembered.
                 */
                status = smb2_signing_sign_pdu(req->last_key,
-                                              conn->protocol,
+                                              xconn->protocol,
                                               lasthdr,
                                               SMBD_SMB2_NUM_IOV_PER_REQ - 1);
                if (!NT_STATUS_IS_OK(status)) {
@@ -2427,6 +2499,9 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                data_blob_clear_free(&req->last_key);
        }
 
+       SMBPROFILE_IOBYTES_ASYNC_END(req->profile,
+               iov_buflen(outhdr, SMBD_SMB2_NUM_IOV_PER_REQ-1));
+
        req->current_idx += SMBD_SMB2_NUM_IOV_PER_REQ;
 
        if (req->current_idx < req->out.vector_count) {
@@ -2445,7 +2520,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
 
                if (req->do_signing && firsttf->iov_len == 0) {
                        struct smbXsrv_session *x = req->session;
-                       DATA_BLOB signing_key = x->global->channels[0].signing_key;
+                       DATA_BLOB signing_key = smbd_smb2_signing_key(x, xconn);
 
                        /*
                         * we need to remember the signing key
@@ -2470,7 +2545,10 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                req->compound_related = false;
        }
 
-       smb2_setup_nbt_length(req->out.vector, req->out.vector_count);
+       ok = smb2_setup_nbt_length(req->out.vector, req->out.vector_count);
+       if (!ok) {
+               return NT_STATUS_INVALID_PARAMETER_MIX;
+       }
 
        /* Set credit for these operations (zero credits if this
           is a final reply for an async operation). */
@@ -2481,7 +2559,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
         */
        if (firsttf->iov_len == SMB2_TF_HDR_SIZE) {
                status = smb2_signing_encrypt_pdu(req->first_key,
-                                       conn->protocol,
+                                       xconn->smb2.server.cipher,
                                        firsttf,
                                        req->out.vector_count - first_idx);
                if (!NT_STATUS_IS_OK(status)) {
@@ -2489,10 +2567,10 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                }
        } else if (req->do_signing) {
                struct smbXsrv_session *x = req->session;
-               DATA_BLOB signing_key = x->global->channels[0].signing_key;
+               DATA_BLOB signing_key = smbd_smb2_signing_key(x, xconn);
 
                status = smb2_signing_sign_pdu(signing_key,
-                                              conn->protocol,
+                                              xconn->protocol,
                                               outhdr,
                                               SMBD_SMB2_NUM_IOV_PER_REQ - 1);
                if (!NT_STATUS_IS_OK(status)) {
@@ -2503,6 +2581,33 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                data_blob_clear_free(&req->first_key);
        }
 
+       if (req->preauth != NULL) {
+               struct hc_sha512state sctx;
+               int i;
+
+               samba_SHA512_Init(&sctx);
+               samba_SHA512_Update(&sctx, req->preauth->sha512_value,
+                                   sizeof(req->preauth->sha512_value));
+               for (i = 1; i < req->in.vector_count; i++) {
+                       samba_SHA512_Update(&sctx,
+                                           req->in.vector[i].iov_base,
+                                           req->in.vector[i].iov_len);
+               }
+               samba_SHA512_Final(req->preauth->sha512_value, &sctx);
+
+               samba_SHA512_Init(&sctx);
+               samba_SHA512_Update(&sctx, req->preauth->sha512_value,
+                                   sizeof(req->preauth->sha512_value));
+               for (i = 1; i < req->out.vector_count; i++) {
+                       samba_SHA512_Update(&sctx,
+                                           req->out.vector[i].iov_base,
+                                           req->out.vector[i].iov_len);
+               }
+               samba_SHA512_Final(req->preauth->sha512_value, &sctx);
+
+               req->preauth = NULL;
+       }
+
        /* I am a sick, sick man... :-). Sendfile hack ... JRA. */
        if (req->out.vector_count < (2*SMBD_SMB2_NUM_IOV_PER_REQ) &&
            outdyn->iov_base == NULL && outdyn->iov_len != 0) {
@@ -2515,15 +2620,15 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
         * We're done with this request -
         * move it off the "being processed" queue.
         */
-       DLIST_REMOVE(conn->smb2.requests, req);
+       DLIST_REMOVE(xconn->smb2.requests, req);
 
        req->queue_entry.mem_ctx = req;
        req->queue_entry.vector = req->out.vector;
        req->queue_entry.count = req->out.vector_count;
-       DLIST_ADD_END(conn->smb2.send_queue, &req->queue_entry, NULL);
-       conn->smb2.send_queue_len++;
+       DLIST_ADD_END(xconn->smb2.send_queue, &req->queue_entry, NULL);
+       xconn->smb2.send_queue_len++;
 
-       status = smbd_smb2_flush_send_queue(sconn);
+       status = smbd_smb2_flush_send_queue(xconn);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
@@ -2531,7 +2636,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
        return NT_STATUS_OK;
 }
 
-static NTSTATUS smbd_smb2_request_next_incoming(struct smbd_server_connection *sconn);
+static NTSTATUS smbd_smb2_request_next_incoming(struct smbXsrv_connection *xconn);
 
 void smbd_smb2_request_dispatch_immediate(struct tevent_context *ctx,
                                        struct tevent_immediate *im,
@@ -2539,7 +2644,7 @@ void smbd_smb2_request_dispatch_immediate(struct tevent_context *ctx,
 {
        struct smbd_smb2_request *req = talloc_get_type_abort(private_data,
                                        struct smbd_smb2_request);
-       struct smbd_server_connection *sconn = req->sconn;
+       struct smbXsrv_connection *xconn = req->xconn;
        NTSTATUS status;
 
        TALLOC_FREE(im);
@@ -2552,13 +2657,13 @@ void smbd_smb2_request_dispatch_immediate(struct tevent_context *ctx,
 
        status = smbd_smb2_request_dispatch(req);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 
-       status = smbd_smb2_request_next_incoming(sconn);
+       status = smbd_smb2_request_next_incoming(xconn);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 }
@@ -2606,8 +2711,13 @@ NTSTATUS smbd_smb2_request_done_ex(struct smbd_smb2_request *req,
                outdyn_v->iov_len = 0;
        }
 
-       /* see if we need to recalculate the offset to the next response */
-       if (next_command_ofs > 0) {
+       /*
+        * See if we need to recalculate the offset to the next response
+        *
+        * Note that all responses may require padding (including the very last
+        * one).
+        */
+       if (req->out.vector_count >= (2 * SMBD_SMB2_NUM_IOV_PER_REQ)) {
                next_command_ofs  = SMB2_HDR_BODY;
                next_command_ofs += SMBD_SMB2_OUT_BODY_LEN(req);
                next_command_ofs += SMBD_SMB2_OUT_DYN_LEN(req);
@@ -2661,8 +2771,11 @@ NTSTATUS smbd_smb2_request_done_ex(struct smbd_smb2_request *req,
                next_command_ofs += pad_size;
        }
 
-       SIVAL(outhdr, SMB2_HDR_NEXT_COMMAND, next_command_ofs);
-
+       if ((req->current_idx + SMBD_SMB2_NUM_IOV_PER_REQ) >= req->out.vector_count) {
+               SIVAL(outhdr, SMB2_HDR_NEXT_COMMAND, 0);
+       } else {
+               SIVAL(outhdr, SMB2_HDR_NEXT_COMMAND, next_command_ofs);
+       }
        return smbd_smb2_request_reply(req);
 }
 
@@ -2671,15 +2784,15 @@ NTSTATUS smbd_smb2_request_error_ex(struct smbd_smb2_request *req,
                                    DATA_BLOB *info,
                                    const char *location)
 {
-       struct smbXsrv_connection *xconn = req->sconn->conn;
+       struct smbXsrv_connection *xconn = req->xconn;
        DATA_BLOB body;
        DATA_BLOB _dyn;
        uint8_t *outhdr = SMBD_SMB2_OUT_HDR_PTR(req);
        size_t unread_bytes = smbd_smb2_unread_bytes(req);
 
-       DEBUG(10,("smbd_smb2_request_error_ex: idx[%d] status[%s] |%s| at %s\n",
-                 req->current_idx, nt_errstr(status), info ? " +info" : "",
-                 location));
+       DBG_NOTICE("smbd_smb2_request_error_ex: idx[%d] status[%s] |%s| "
+                  "at %s\n", req->current_idx, nt_errstr(status),
+                  info ? " +info" : "", location);
 
        if (unread_bytes) {
                /* Recvfile error. Drain incoming socket. */
@@ -2732,7 +2845,6 @@ NTSTATUS smbd_smb2_request_error_ex(struct smbd_smb2_request *req,
 
 
 struct smbd_smb2_send_break_state {
-       struct smbd_server_connection *sconn;
        struct smbd_smb2_send_queue queue_entry;
        uint8_t nbt_hdr[NBT_HDR_SIZE];
        uint8_t tf[SMB2_TF_HDR_SIZE];
@@ -2741,49 +2853,51 @@ struct smbd_smb2_send_break_state {
        uint8_t body[1];
 };
 
-static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
+static NTSTATUS smbd_smb2_send_break(struct smbXsrv_connection *xconn,
                                     struct smbXsrv_session *session,
                                     struct smbXsrv_tcon *tcon,
                                     const uint8_t *body,
                                     size_t body_len)
 {
        struct smbd_smb2_send_break_state *state;
-       struct smbXsrv_connection *conn = sconn->conn;
-       bool do_encryption = session->global->encryption_required;
+       bool do_encryption = false;
+       uint64_t session_wire_id = 0;
        uint64_t nonce_high = 0;
        uint64_t nonce_low = 0;
        NTSTATUS status;
        size_t statelen;
+       bool ok;
 
-       if (tcon->global->encryption_required) {
-               do_encryption = true;
+       if (session != NULL) {
+               session_wire_id = session->global->session_wire_id;
+               do_encryption = session->encryption_desired;
+               if (tcon->encryption_desired) {
+                       do_encryption = true;
+               }
        }
 
        statelen = offsetof(struct smbd_smb2_send_break_state, body) +
                body_len;
 
-       state = talloc_zero_size(sconn, statelen);
+       state = talloc_zero_size(xconn, statelen);
        if (state == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
        talloc_set_name_const(state, "struct smbd_smb2_send_break_state");
-       state->sconn = sconn;
 
        if (do_encryption) {
-               nonce_high = session->nonce_high;
-               nonce_low = session->nonce_low;
-
-               session->nonce_low += 1;
-               if (session->nonce_low == 0) {
-                       session->nonce_low += 1;
-                       session->nonce_high += 1;
+               status = smb2_get_new_nonce(session,
+                                           &nonce_high,
+                                           &nonce_low);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
        }
 
        SIVAL(state->tf, SMB2_TF_PROTOCOL_ID, SMB2_TF_MAGIC);
        SBVAL(state->tf, SMB2_TF_NONCE+0, nonce_low);
        SBVAL(state->tf, SMB2_TF_NONCE+8, nonce_high);
-       SBVAL(state->tf, SMB2_TF_SESSION_ID, session->global->session_wire_id);
+       SBVAL(state->tf, SMB2_TF_SESSION_ID, session_wire_id);
 
        SIVAL(state->hdr, 0,                            SMB2_MAGIC);
        SSVAL(state->hdr, SMB2_HDR_LENGTH,              SMB2_HDR_BODY);
@@ -2832,13 +2946,17 @@ static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
         * state->vector[1+SMBD_SMB2_DYN_IOV_OFS] is NULL by talloc_zero above
         */
 
-       smb2_setup_nbt_length(state->vector, 1 + SMBD_SMB2_NUM_IOV_PER_REQ);
+       ok = smb2_setup_nbt_length(state->vector,
+                                  1 + SMBD_SMB2_NUM_IOV_PER_REQ);
+       if (!ok) {
+               return NT_STATUS_INVALID_PARAMETER_MIX;
+       }
 
        if (do_encryption) {
                DATA_BLOB encryption_key = session->global->encryption_key;
 
                status = smb2_signing_encrypt_pdu(encryption_key,
-                                       conn->protocol,
+                                       xconn->smb2.server.cipher,
                                        &state->vector[1+SMBD_SMB2_TF_IOV_OFS],
                                        SMBD_SMB2_NUM_IOV_PER_REQ);
                if (!NT_STATUS_IS_OK(status)) {
@@ -2849,10 +2967,10 @@ static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
        state->queue_entry.mem_ctx = state;
        state->queue_entry.vector = state->vector;
        state->queue_entry.count = ARRAY_SIZE(state->vector);
-       DLIST_ADD_END(conn->smb2.send_queue, &state->queue_entry, NULL);
-       conn->smb2.send_queue_len++;
+       DLIST_ADD_END(xconn->smb2.send_queue, &state->queue_entry, NULL);
+       xconn->smb2.send_queue_len++;
 
-       status = smbd_smb2_flush_send_queue(sconn);
+       status = smbd_smb2_flush_send_queue(xconn);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
@@ -2860,7 +2978,7 @@ static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
        return NT_STATUS_OK;
 }
 
-NTSTATUS smbd_smb2_send_oplock_break(struct smbd_server_connection *sconn,
+NTSTATUS smbd_smb2_send_oplock_break(struct smbXsrv_connection *xconn,
                                     struct smbXsrv_session *session,
                                     struct smbXsrv_tcon *tcon,
                                     struct smbXsrv_open *op,
@@ -2875,7 +2993,30 @@ NTSTATUS smbd_smb2_send_oplock_break(struct smbd_server_connection *sconn,
        SBVAL(body, 0x08, op->global->open_persistent_id);
        SBVAL(body, 0x10, op->global->open_volatile_id);
 
-       return smbd_smb2_send_break(sconn, session, tcon, body, sizeof(body));
+       return smbd_smb2_send_break(xconn, session, tcon, body, sizeof(body));
+}
+
+NTSTATUS smbd_smb2_send_lease_break(struct smbXsrv_connection *xconn,
+                                   uint16_t new_epoch,
+                                   uint32_t lease_flags,
+                                   struct smb2_lease_key *lease_key,
+                                   uint32_t current_lease_state,
+                                   uint32_t new_lease_state)
+{
+       uint8_t body[0x2c];
+
+       SSVAL(body, 0x00, sizeof(body));
+       SSVAL(body, 0x02, new_epoch);
+       SIVAL(body, 0x04, lease_flags);
+       SBVAL(body, 0x08, lease_key->data[0]);
+       SBVAL(body, 0x10, lease_key->data[1]);
+       SIVAL(body, 0x18, current_lease_state);
+       SIVAL(body, 0x1c, new_lease_state);
+       SIVAL(body, 0x20, 0);           /* BreakReason, MUST be 0 */
+       SIVAL(body, 0x24, 0);           /* AccessMaskHint, MUST be 0 */
+       SIVAL(body, 0x28, 0);           /* ShareMaskHint, MUST be 0 */
+
+       return smbd_smb2_send_break(xconn, NULL, NULL, body, sizeof(body));
 }
 
 static bool is_smb2_recvfile_write(struct smbd_smb2_request_read_state *state)
@@ -2929,7 +3070,7 @@ static bool is_smb2_recvfile_write(struct smbd_smb2_request_read_state *state)
        file_id_persistent      = BVAL(body, 0x10);
        file_id_volatile        = BVAL(body, 0x18);
 
-       status = smb2srv_open_lookup(state->req->sconn->conn,
+       status = smb2srv_open_lookup(state->req->xconn,
                                     file_id_persistent,
                                     file_id_volatile,
                                     0, /* now */
@@ -2959,9 +3100,9 @@ static bool is_smb2_recvfile_write(struct smbd_smb2_request_read_state *state)
        return true;
 }
 
-static NTSTATUS smbd_smb2_request_next_incoming(struct smbd_server_connection *sconn)
+static NTSTATUS smbd_smb2_request_next_incoming(struct smbXsrv_connection *xconn)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        struct smbd_smb2_request_read_state *state = &xconn->smb2.request_read_state;
        size_t max_send_queue_len;
        size_t cur_send_queue_len;
@@ -3000,6 +3141,7 @@ static NTSTATUS smbd_smb2_request_next_incoming(struct smbd_server_connection *s
                return NT_STATUS_NO_MEMORY;
        }
        state->req->sconn = sconn;
+       state->req->xconn = xconn;
        state->min_recv_size = lp_min_receive_file_size();
 
        TEVENT_FD_READABLE(xconn->transport.fde);
@@ -3007,48 +3149,58 @@ static NTSTATUS smbd_smb2_request_next_incoming(struct smbd_server_connection *s
        return NT_STATUS_OK;
 }
 
-void smbd_smb2_first_negprot(struct smbd_server_connection *sconn,
-                            uint8_t *inbuf, size_t size)
+void smbd_smb2_first_negprot(struct smbXsrv_connection *xconn,
+                            const uint8_t *inpdu, size_t size)
 {
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        NTSTATUS status;
        struct smbd_smb2_request *req = NULL;
 
        DEBUG(10,("smbd_smb2_first_negprot: packet length %u\n",
                 (unsigned int)size));
 
-       status = smbd_initialize_smb2(sconn);
+       status = smbd_initialize_smb2(xconn);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 
-       status = smbd_smb2_request_create(sconn, inbuf, size, &req);
+       status = smbd_smb2_request_create(xconn, inpdu, size, &req);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 
        status = smbd_smb2_request_validate(req);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 
        status = smbd_smb2_request_setup_out(req);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 
+#ifdef WITH_PROFILE
+       /*
+        * this was already counted at the SMB1 layer =>
+        * smbd_smb2_request_dispatch() should not count it twice.
+        */
+       if (profile_p->values.request_stats.count > 0) {
+               profile_p->values.request_stats.count--;
+       }
+#endif
        status = smbd_smb2_request_dispatch(req);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 
-       status = smbd_smb2_request_next_incoming(sconn);
+       status = smbd_smb2_request_next_incoming(xconn);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 
@@ -3106,9 +3258,8 @@ static int socket_error_from_errno(int ret,
        return sys_errno;
 }
 
-static NTSTATUS smbd_smb2_flush_send_queue(struct smbd_server_connection *sconn)
+static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
        int ret;
        int err;
        bool retry;
@@ -3120,8 +3271,10 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbd_server_connection *sconn)
 
        while (xconn->smb2.send_queue != NULL) {
                struct smbd_smb2_send_queue *e = xconn->smb2.send_queue;
+               bool ok;
 
                if (e->sendfile_header != NULL) {
+                       NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                        size_t size = 0;
                        size_t i = 0;
                        uint8_t *buf;
@@ -3149,6 +3302,7 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbd_server_connection *sconn)
 
                        e->sendfile_header->data = buf;
                        e->sendfile_header->length = size;
+                       e->sendfile_status = &status;
                        e->count = 0;
 
                        xconn->smb2.send_queue_len--;
@@ -3158,6 +3312,10 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbd_server_connection *sconn)
                         * the destructor.
                         */
                        talloc_free(e->mem_ctx);
+
+                       if (!NT_STATUS_IS_OK(status)) {
+                               return status;
+                       }
                        continue;
                }
 
@@ -3175,31 +3333,10 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbd_server_connection *sconn)
                if (err != 0) {
                        return map_nt_error_from_unix_common(err);
                }
-               while (ret > 0) {
-                       if (ret < e->vector[0].iov_len) {
-                               uint8_t *base;
-                               base = (uint8_t *)e->vector[0].iov_base;
-                               base += ret;
-                               e->vector[0].iov_base = (void *)base;
-                               e->vector[0].iov_len -= ret;
-                               break;
-                       }
-                       ret -= e->vector[0].iov_len;
-                       e->vector += 1;
-                       e->count -= 1;
-               }
 
-               /*
-                * there're maybe some empty vectors at the end
-                * which we need to skip, otherwise we would get
-                * ret == 0 from the readv() call and return EPIPE
-                */
-               while (e->count > 0) {
-                       if (e->vector[0].iov_len > 0) {
-                               break;
-                       }
-                       e->vector += 1;
-                       e->count -= 1;
+               ok = iov_advance(&e->vector, &e->count, ret);
+               if (!ok) {
+                       return NT_STATUS_INTERNAL_ERROR;
                }
 
                if (e->count > 0) {
@@ -3216,10 +3353,10 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbd_server_connection *sconn)
        return NT_STATUS_OK;
 }
 
-static NTSTATUS smbd_smb2_io_handler(struct smbd_server_connection *sconn,
+static NTSTATUS smbd_smb2_io_handler(struct smbXsrv_connection *xconn,
                                     uint16_t fde_flags)
 {
-       struct smbXsrv_connection *xconn = sconn->conn;
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        struct smbd_smb2_request_read_state *state = &xconn->smb2.request_read_state;
        struct smbd_smb2_request *req = NULL;
        size_t min_recvfile_size = UINT32_MAX;
@@ -3239,7 +3376,7 @@ static NTSTATUS smbd_smb2_io_handler(struct smbd_server_connection *sconn,
        }
 
        if (fde_flags & TEVENT_FD_WRITE) {
-               status = smbd_smb2_flush_send_queue(sconn);
+               status = smbd_smb2_flush_send_queue(xconn);
                if (!NT_STATUS_IS_OK(status)) {
                        return status;
                }
@@ -3381,7 +3518,7 @@ got_full:
        req->request_time = timeval_current();
        now = timeval_to_nttime(&req->request_time);
 
-       status = smbd_smb2_inbuf_parse_compound(req->sconn->conn,
+       status = smbd_smb2_inbuf_parse_compound(xconn,
                                                now,
                                                state->pktbuf,
                                                state->pktlen,
@@ -3437,7 +3574,7 @@ got_full:
                check_log_size();
        }
 
-       status = smbd_smb2_request_next_incoming(sconn);
+       status = smbd_smb2_request_next_incoming(xconn);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
@@ -3450,14 +3587,14 @@ static void smbd_smb2_connection_handler(struct tevent_context *ev,
                                         uint16_t flags,
                                         void *private_data)
 {
-       struct smbd_server_connection *sconn =
+       struct smbXsrv_connection *xconn =
                talloc_get_type_abort(private_data,
-               struct smbd_server_connection);
+               struct smbXsrv_connection);
        NTSTATUS status;
 
-       status = smbd_smb2_io_handler(sconn, flags);
+       status = smbd_smb2_io_handler(xconn, flags);
        if (!NT_STATUS_IS_OK(status)) {
-               smbd_server_connection_terminate(sconn, nt_errstr(status));
+               smbd_server_connection_terminate(xconn, nt_errstr(status));
                return;
        }
 }