smbd: Add missing include for iov_buflen().
[obnox/samba/samba-obnox.git] / source3 / smbd / smb2_server.c
index d9e6a7644d5984335570b4d04ba971e5b7383876..4a2c87541451b1ad905cdef2806de08055c01550 100644 (file)
@@ -28,6 +28,7 @@
 #include "smbprofile.h"
 #include "../lib/util/bitmap.h"
 #include "../librpc/gen_ndr/krb5pac.h"
+#include "lib/iov_buf.h"
 #include "auth.h"
 
 static void smbd_smb2_connection_handler(struct tevent_context *ev,
@@ -356,7 +357,7 @@ static NTSTATUS smbd_smb2_inbuf_parse_compound(struct smbXsrv_connection *xconn,
                                goto inval;
                        }
 
-                       if (!(xconn->smb2.server.capabilities & SMB2_CAP_ENCRYPTION)) {
+                       if (xconn->smb2.server.cipher == 0) {
                                DEBUG(10, ("Got SMB2_TRANSFORM header, "
                                           "but not negotiated "
                                           "client[0x%08X] server[0x%08X]\n",
@@ -400,7 +401,7 @@ static NTSTATUS smbd_smb2_inbuf_parse_compound(struct smbXsrv_connection *xconn,
                        tf_iov[1].iov_len = enc_len;
 
                        status = smb2_signing_decrypt_pdu(s->global->decryption_key,
-                                                         xconn->protocol,
+                                                         xconn->smb2.server.cipher,
                                                          tf_iov, 2);
                        if (!NT_STATUS_IS_OK(status)) {
                                TALLOC_FREE(iov_alloc);
@@ -509,7 +510,7 @@ static NTSTATUS smbd_smb2_request_create(struct smbXsrv_connection *xconn,
                                         const uint8_t *_inpdu, size_t size,
                                         struct smbd_smb2_request **_req)
 {
-       struct smbd_server_connection *sconn = xconn->sconn;
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        struct smbd_smb2_request *req;
        uint32_t protocol_version;
        uint8_t *inpdu = NULL;
@@ -1250,7 +1251,7 @@ static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request
         */
        if (firsttf->iov_len == SMB2_TF_HDR_SIZE) {
                status = smb2_signing_encrypt_pdu(req->first_key,
-                                       xconn->protocol,
+                                       xconn->smb2.server.cipher,
                                        firsttf,
                                        nreq->out.vector_count - first_idx);
                if (!NT_STATUS_IS_OK(status)) {
@@ -1420,6 +1421,25 @@ NTSTATUS smbd_smb2_request_pending_queue(struct smbd_smb2_request *req,
        return NT_STATUS_OK;
 }
 
+static DATA_BLOB smbd_smb2_signing_key(struct smbXsrv_session *session,
+                                      struct smbXsrv_connection *xconn)
+{
+       struct smbXsrv_channel_global0 *c = NULL;
+       NTSTATUS status;
+       DATA_BLOB key = data_blob_null;
+
+       status = smbXsrv_session_find_channel(session, xconn, &c);
+       if (NT_STATUS_IS_OK(status)) {
+               key = c->signing_key;
+       }
+
+       if (key.length == 0) {
+               key = session->global->signing_key;
+       }
+
+       return key;
+}
+
 static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
                                            struct tevent_timer *te,
                                            struct timeval current_time,
@@ -1572,7 +1592,7 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
                DATA_BLOB encryption_key = x->global->encryption_key;
 
                status = smb2_signing_encrypt_pdu(encryption_key,
-                                       xconn->protocol,
+                                       xconn->smb2.server.cipher,
                                        &state->vector[1+SMBD_SMB2_TF_IOV_OFS],
                                        SMBD_SMB2_NUM_IOV_PER_REQ);
                if (!NT_STATUS_IS_OK(status)) {
@@ -1582,7 +1602,7 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
                }
        } else if (req->do_signing) {
                struct smbXsrv_session *x = req->session;
-               DATA_BLOB signing_key = x->global->channels[0].signing_key;
+               DATA_BLOB signing_key = smbd_smb2_signing_key(x, xconn);
 
                status = smb2_signing_sign_pdu(signing_key,
                                        xconn->protocol,
@@ -1797,8 +1817,8 @@ static NTSTATUS smbd_smb2_request_check_session(struct smbd_smb2_request *req)
                return NT_STATUS_INVALID_HANDLE;
        }
 
-       if (in_session_id != req->xconn->last_session_id) {
-               req->xconn->last_session_id = in_session_id;
+       if (in_session_id != req->xconn->client->last_session_id) {
+               req->xconn->client->last_session_id = in_session_id;
                set_current_user_info(session_info->unix_info->sanitized_username,
                                      session_info->unix_info->unix_name,
                                      session_info->info->domain_name);
@@ -1926,6 +1946,8 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
 
        inhdr = SMBD_SMB2_IN_HDR_PTR(req);
 
+       DO_PROFILE_INC(request);
+
        /* TODO: verify more things */
 
        flags = IVAL(inhdr, SMB2_HDR_FLAGS);
@@ -1970,7 +1992,7 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                encryption_required = x->global->encryption_required;
 
                if (opcode == SMB2_OP_SESSSETUP &&
-                   x->global->channels[0].signing_key.length) {
+                   x->global->signing_key.length > 0) {
                        signing_required = true;
                }
        }
@@ -2036,7 +2058,7 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
        if (req->do_encryption) {
                signing_required = false;
        } else if (signing_required || (flags & SMB2_HDR_FLAG_SIGNED)) {
-               DATA_BLOB signing_key;
+               DATA_BLOB signing_key = data_blob_null;
 
                if (x == NULL) {
                        /*
@@ -2058,7 +2080,7 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                        return smbd_smb2_request_error(req, status);
                }
 
-               signing_key = x->global->channels[0].signing_key;
+               signing_key = smbd_smb2_signing_key(x, xconn);
 
                /*
                 * If we have a signing key, we should
@@ -2172,157 +2194,127 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
                SMB_ASSERT(call->need_tcon);
        }
 
+#define _INBYTES(_r) \
+       iov_buflen(SMBD_SMB2_IN_HDR_IOV(_r), SMBD_SMB2_NUM_IOV_PER_REQ-1)
+
        switch (opcode) {
        case SMB2_OP_NEGPROT:
-               {
-                       START_PROFILE(smb2_negprot);
-                       return_value = smbd_smb2_request_process_negprot(req);
-                       END_PROFILE(smb2_negprot);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_negprot, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_negprot(req);
                break;
 
        case SMB2_OP_SESSSETUP:
-               {
-                       START_PROFILE(smb2_sesssetup);
-                       return_value = smbd_smb2_request_process_sesssetup(req);
-                       END_PROFILE(smb2_sesssetup);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_sesssetup, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_sesssetup(req);
                break;
 
        case SMB2_OP_LOGOFF:
-               {
-                       START_PROFILE(smb2_logoff);
-                       return_value = smbd_smb2_request_process_logoff(req);
-                       END_PROFILE(smb2_logoff);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_logoff, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_logoff(req);
                break;
 
        case SMB2_OP_TCON:
-               {
-                       START_PROFILE(smb2_tcon);
-                       return_value = smbd_smb2_request_process_tcon(req);
-                       END_PROFILE(smb2_tcon);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_tcon, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_tcon(req);
                break;
 
        case SMB2_OP_TDIS:
-               {
-                       START_PROFILE(smb2_tdis);
-                       return_value = smbd_smb2_request_process_tdis(req);
-                       END_PROFILE(smb2_tdis);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_tdis, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_tdis(req);
                break;
 
        case SMB2_OP_CREATE:
-               {
-                       START_PROFILE(smb2_create);
-                       return_value = smbd_smb2_request_process_create(req);
-                       END_PROFILE(smb2_create);
+               if (req->subreq == NULL) {
+                       SMBPROFILE_IOBYTES_ASYNC_START(smb2_create, profile_p,
+                                                      req->profile, _INBYTES(req));
+               } else {
+                       SMBPROFILE_IOBYTES_ASYNC_SET_BUSY(req->profile);
                }
+               return_value = smbd_smb2_request_process_create(req);
                break;
 
        case SMB2_OP_CLOSE:
-               {
-                       START_PROFILE(smb2_close);
-                       return_value = smbd_smb2_request_process_close(req);
-                       END_PROFILE(smb2_close);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_close, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_close(req);
                break;
 
        case SMB2_OP_FLUSH:
-               {
-                       START_PROFILE(smb2_flush);
-                       return_value = smbd_smb2_request_process_flush(req);
-                       END_PROFILE(smb2_flush);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_flush, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_flush(req);
                break;
 
        case SMB2_OP_READ:
-               {
-                       START_PROFILE(smb2_read);
-                       return_value = smbd_smb2_request_process_read(req);
-                       END_PROFILE(smb2_read);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_read, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_read(req);
                break;
 
        case SMB2_OP_WRITE:
-               {
-                       START_PROFILE(smb2_write);
-                       return_value = smbd_smb2_request_process_write(req);
-                       END_PROFILE(smb2_write);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_write, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_write(req);
                break;
 
        case SMB2_OP_LOCK:
-               {
-                       START_PROFILE(smb2_lock);
-                       return_value = smbd_smb2_request_process_lock(req);
-                       END_PROFILE(smb2_lock);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_lock, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_lock(req);
                break;
 
        case SMB2_OP_IOCTL:
-               {
-                       START_PROFILE(smb2_ioctl);
-                       return_value = smbd_smb2_request_process_ioctl(req);
-                       END_PROFILE(smb2_ioctl);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_ioctl, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_ioctl(req);
                break;
 
        case SMB2_OP_CANCEL:
-               {
-                       START_PROFILE(smb2_cancel);
-                       return_value = smbd_smb2_request_process_cancel(req);
-                       END_PROFILE(smb2_cancel);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_cancel, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_cancel(req);
+               SMBPROFILE_IOBYTES_ASYNC_END(req->profile, 0);
                break;
 
        case SMB2_OP_KEEPALIVE:
-               {
-                       START_PROFILE(smb2_keepalive);
-                       return_value = smbd_smb2_request_process_keepalive(req);
-                       END_PROFILE(smb2_keepalive);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_keepalive, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_keepalive(req);
                break;
 
        case SMB2_OP_FIND:
-               {
-                       START_PROFILE(smb2_find);
-                       return_value = smbd_smb2_request_process_find(req);
-                       END_PROFILE(smb2_find);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_find, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_find(req);
                break;
 
        case SMB2_OP_NOTIFY:
-               {
-                       START_PROFILE(smb2_notify);
-                       return_value = smbd_smb2_request_process_notify(req);
-                       END_PROFILE(smb2_notify);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_notify, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_notify(req);
                break;
 
        case SMB2_OP_GETINFO:
-               {
-                       START_PROFILE(smb2_getinfo);
-                       return_value = smbd_smb2_request_process_getinfo(req);
-                       END_PROFILE(smb2_getinfo);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_getinfo, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_getinfo(req);
                break;
 
        case SMB2_OP_SETINFO:
-               {
-                       START_PROFILE(smb2_setinfo);
-                       return_value = smbd_smb2_request_process_setinfo(req);
-                       END_PROFILE(smb2_setinfo);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_setinfo, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_setinfo(req);
                break;
 
        case SMB2_OP_BREAK:
-               {
-                       START_PROFILE(smb2_break);
-                       return_value = smbd_smb2_request_process_break(req);
-                       END_PROFILE(smb2_break);
-               }
+               SMBPROFILE_IOBYTES_ASYNC_START(smb2_break, profile_p,
+                                              req->profile, _INBYTES(req));
+               return_value = smbd_smb2_request_process_break(req);
                break;
 
        default:
@@ -2421,6 +2413,9 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                data_blob_clear_free(&req->last_key);
        }
 
+       SMBPROFILE_IOBYTES_ASYNC_END(req->profile,
+               iov_buflen(outhdr, SMBD_SMB2_NUM_IOV_PER_REQ-1));
+
        req->current_idx += SMBD_SMB2_NUM_IOV_PER_REQ;
 
        if (req->current_idx < req->out.vector_count) {
@@ -2439,7 +2434,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
 
                if (req->do_signing && firsttf->iov_len == 0) {
                        struct smbXsrv_session *x = req->session;
-                       DATA_BLOB signing_key = x->global->channels[0].signing_key;
+                       DATA_BLOB signing_key = smbd_smb2_signing_key(x, xconn);
 
                        /*
                         * we need to remember the signing key
@@ -2475,7 +2470,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
         */
        if (firsttf->iov_len == SMB2_TF_HDR_SIZE) {
                status = smb2_signing_encrypt_pdu(req->first_key,
-                                       xconn->protocol,
+                                       xconn->smb2.server.cipher,
                                        firsttf,
                                        req->out.vector_count - first_idx);
                if (!NT_STATUS_IS_OK(status)) {
@@ -2483,7 +2478,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
                }
        } else if (req->do_signing) {
                struct smbXsrv_session *x = req->session;
-               DATA_BLOB signing_key = x->global->channels[0].signing_key;
+               DATA_BLOB signing_key = smbd_smb2_signing_key(x, xconn);
 
                status = smb2_signing_sign_pdu(signing_key,
                                               xconn->protocol,
@@ -2734,28 +2729,32 @@ struct smbd_smb2_send_break_state {
        uint8_t body[1];
 };
 
-static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
+static NTSTATUS smbd_smb2_send_break(struct smbXsrv_connection *xconn,
                                     struct smbXsrv_session *session,
                                     struct smbXsrv_tcon *tcon,
                                     const uint8_t *body,
                                     size_t body_len)
 {
        struct smbd_smb2_send_break_state *state;
-       struct smbXsrv_connection *xconn = sconn->conn;
-       bool do_encryption = session->global->encryption_required;
+       bool do_encryption = false;
+       uint64_t session_wire_id = 0;
        uint64_t nonce_high = 0;
        uint64_t nonce_low = 0;
        NTSTATUS status;
        size_t statelen;
 
-       if (tcon->global->encryption_required) {
-               do_encryption = true;
+       if (session != NULL) {
+               session_wire_id = session->global->session_wire_id;
+               do_encryption = session->global->encryption_required;
+               if (tcon->global->encryption_required) {
+                       do_encryption = true;
+               }
        }
 
        statelen = offsetof(struct smbd_smb2_send_break_state, body) +
                body_len;
 
-       state = talloc_zero_size(sconn, statelen);
+       state = talloc_zero_size(xconn, statelen);
        if (state == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -2775,7 +2774,7 @@ static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
        SIVAL(state->tf, SMB2_TF_PROTOCOL_ID, SMB2_TF_MAGIC);
        SBVAL(state->tf, SMB2_TF_NONCE+0, nonce_low);
        SBVAL(state->tf, SMB2_TF_NONCE+8, nonce_high);
-       SBVAL(state->tf, SMB2_TF_SESSION_ID, session->global->session_wire_id);
+       SBVAL(state->tf, SMB2_TF_SESSION_ID, session_wire_id);
 
        SIVAL(state->hdr, 0,                            SMB2_MAGIC);
        SSVAL(state->hdr, SMB2_HDR_LENGTH,              SMB2_HDR_BODY);
@@ -2830,7 +2829,7 @@ static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
                DATA_BLOB encryption_key = session->global->encryption_key;
 
                status = smb2_signing_encrypt_pdu(encryption_key,
-                                       xconn->protocol,
+                                       xconn->smb2.server.cipher,
                                        &state->vector[1+SMBD_SMB2_TF_IOV_OFS],
                                        SMBD_SMB2_NUM_IOV_PER_REQ);
                if (!NT_STATUS_IS_OK(status)) {
@@ -2852,7 +2851,7 @@ static NTSTATUS smbd_smb2_send_break(struct smbd_server_connection *sconn,
        return NT_STATUS_OK;
 }
 
-NTSTATUS smbd_smb2_send_oplock_break(struct smbd_server_connection *sconn,
+NTSTATUS smbd_smb2_send_oplock_break(struct smbXsrv_connection *xconn,
                                     struct smbXsrv_session *session,
                                     struct smbXsrv_tcon *tcon,
                                     struct smbXsrv_open *op,
@@ -2867,7 +2866,30 @@ NTSTATUS smbd_smb2_send_oplock_break(struct smbd_server_connection *sconn,
        SBVAL(body, 0x08, op->global->open_persistent_id);
        SBVAL(body, 0x10, op->global->open_volatile_id);
 
-       return smbd_smb2_send_break(sconn, session, tcon, body, sizeof(body));
+       return smbd_smb2_send_break(xconn, session, tcon, body, sizeof(body));
+}
+
+NTSTATUS smbd_smb2_send_lease_break(struct smbXsrv_connection *xconn,
+                                   uint16_t new_epoch,
+                                   uint32_t lease_flags,
+                                   struct smb2_lease_key *lease_key,
+                                   uint32_t current_lease_state,
+                                   uint32_t new_lease_state)
+{
+       uint8_t body[0x2c];
+
+       SSVAL(body, 0x00, sizeof(body));
+       SSVAL(body, 0x02, new_epoch);
+       SIVAL(body, 0x04, lease_flags);
+       SBVAL(body, 0x08, lease_key->data[0]);
+       SBVAL(body, 0x10, lease_key->data[1]);
+       SIVAL(body, 0x18, current_lease_state);
+       SIVAL(body, 0x1c, new_lease_state);
+       SIVAL(body, 0x20, 0);           /* BreakReason, MUST be 0 */
+       SIVAL(body, 0x24, 0);           /* AccessMaskHint, MUST be 0 */
+       SIVAL(body, 0x28, 0);           /* ShareMaskHint, MUST be 0 */
+
+       return smbd_smb2_send_break(xconn, NULL, NULL, body, sizeof(body));
 }
 
 static bool is_smb2_recvfile_write(struct smbd_smb2_request_read_state *state)
@@ -2953,7 +2975,7 @@ static bool is_smb2_recvfile_write(struct smbd_smb2_request_read_state *state)
 
 static NTSTATUS smbd_smb2_request_next_incoming(struct smbXsrv_connection *xconn)
 {
-       struct smbd_server_connection *sconn = xconn->sconn;
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        struct smbd_smb2_request_read_state *state = &xconn->smb2.request_read_state;
        size_t max_send_queue_len;
        size_t cur_send_queue_len;
@@ -3003,7 +3025,7 @@ static NTSTATUS smbd_smb2_request_next_incoming(struct smbXsrv_connection *xconn
 void smbd_smb2_first_negprot(struct smbXsrv_connection *xconn,
                             const uint8_t *inpdu, size_t size)
 {
-       struct smbd_server_connection *sconn = xconn->sconn;
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        NTSTATUS status;
        struct smbd_smb2_request *req = NULL;
 
@@ -3034,6 +3056,15 @@ void smbd_smb2_first_negprot(struct smbXsrv_connection *xconn,
                return;
        }
 
+#ifdef WITH_PROFILE
+       /*
+        * this was already counted at the SMB1 layer =>
+        * smbd_smb2_request_dispatch() should not count it twice.
+        */
+       if (profile_p->request_stats.count > 0) {
+               profile_p->request_stats.count--;
+       }
+#endif
        status = smbd_smb2_request_dispatch(req);
        if (!NT_STATUS_IS_OK(status)) {
                smbd_server_connection_terminate(xconn, nt_errstr(status));
@@ -3115,6 +3146,7 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn)
                struct smbd_smb2_send_queue *e = xconn->smb2.send_queue;
 
                if (e->sendfile_header != NULL) {
+                       NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                        size_t size = 0;
                        size_t i = 0;
                        uint8_t *buf;
@@ -3142,6 +3174,7 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn)
 
                        e->sendfile_header->data = buf;
                        e->sendfile_header->length = size;
+                       e->sendfile_status = &status;
                        e->count = 0;
 
                        xconn->smb2.send_queue_len--;
@@ -3151,6 +3184,10 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn)
                         * the destructor.
                         */
                        talloc_free(e->mem_ctx);
+
+                       if (!NT_STATUS_IS_OK(status)) {
+                               return status;
+                       }
                        continue;
                }
 
@@ -3212,7 +3249,7 @@ static NTSTATUS smbd_smb2_flush_send_queue(struct smbXsrv_connection *xconn)
 static NTSTATUS smbd_smb2_io_handler(struct smbXsrv_connection *xconn,
                                     uint16_t fde_flags)
 {
-       struct smbd_server_connection *sconn = xconn->sconn;
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        struct smbd_smb2_request_read_state *state = &xconn->smb2.request_read_state;
        struct smbd_smb2_request *req = NULL;
        size_t min_recvfile_size = UINT32_MAX;