Ensure vfs_chown_fsp() is safe against races.
[samba.git] / source3 / smbd / open.c
index f8e1927bd48488326035bd8d2aafc88cd54e9b9b..14e6bf9b4e6570ae9ad9a027e2c03591e41846a4 100644 (file)
@@ -4,56 +4,60 @@
    Copyright (C) Andrew Tridgell 1992-1998
    Copyright (C) Jeremy Allison 2001-2004
    Copyright (C) Volker Lendecke 2005
-   
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
+#include "system/filesys.h"
+#include "printing.h"
+#include "smbd/smbd.h"
 #include "smbd/globals.h"
+#include "fake_file.h"
+#include "../libcli/security/security.h"
+#include "../librpc/gen_ndr/ndr_security.h"
+#include "auth.h"
+#include "messages.h"
 
 extern const struct generic_mapping file_generic_mapping;
 
 struct deferred_open_record {
-       bool delayed_for_oplocks;
-       struct file_id id;
+        bool delayed_for_oplocks;
+        struct file_id id;
 };
 
-static NTSTATUS create_file_unixpath(connection_struct *conn,
-                                    struct smb_request *req,
-                                    struct smb_filename *smb_fname,
-                                    uint32_t access_mask,
-                                    uint32_t share_access,
-                                    uint32_t create_disposition,
-                                    uint32_t create_options,
-                                    uint32_t file_attributes,
-                                    uint32_t oplock_request,
-                                    uint64_t allocation_size,
-                                    struct security_descriptor *sd,
-                                    struct ea_list *ea_list,
-
-                                    files_struct **result,
-                                    int *pinfo);
-
 /****************************************************************************
  SMB1 file varient of se_access_check. Never test FILE_READ_ATTRIBUTES.
 ****************************************************************************/
 
-NTSTATUS smb1_file_se_access_check(const struct security_descriptor *sd,
-                          const NT_USER_TOKEN *token,
-                          uint32_t access_desired,
-                          uint32_t *access_granted)
+NTSTATUS smb1_file_se_access_check(struct connection_struct *conn,
+                               const struct security_descriptor *sd,
+                               const struct security_token *token,
+                               uint32_t access_desired,
+                               uint32_t *access_granted)
 {
+       *access_granted = 0;
+
+       if (get_current_uid(conn) == (uid_t)0) {
+               /* I'm sorry sir, I didn't know you were root... */
+               *access_granted = access_desired;
+               if (access_desired & SEC_FLAG_MAXIMUM_ALLOWED) {
+                       *access_granted |= FILE_GENERIC_ALL;
+               }
+               return NT_STATUS_OK;
+       }
+
        return se_access_check(sd,
                                token,
                                (access_desired & ~FILE_READ_ATTRIBUTES),
@@ -71,40 +75,27 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
 {
        /* Check if we have rights to open. */
        NTSTATUS status;
-       struct security_descriptor *sd;
-
-       *access_granted = 0;
-
-       if (conn->server_info->utok.uid == 0 || conn->admin_user) {
-               /* I'm sorry sir, I didn't know you were root... */
-               *access_granted = access_mask;
-               if (access_mask & SEC_FLAG_MAXIMUM_ALLOWED) {
-                       *access_granted |= FILE_GENERIC_ALL;
-               }
-               return NT_STATUS_OK;
-       }
+       struct security_descriptor *sd = NULL;
 
        status = SMB_VFS_GET_NT_ACL(conn, smb_fname->base_name,
-                       (OWNER_SECURITY_INFORMATION |
-                       GROUP_SECURITY_INFORMATION |
-                       DACL_SECURITY_INFORMATION),&sd);
+                       (SECINFO_OWNER |
+                       SECINFO_GROUP |
+                       SECINFO_DACL),&sd);
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("smbd_check_open_rights: Could not get acl "
                        "on %s: %s\n",
                        smb_fname_str_dbg(smb_fname),
                        nt_errstr(status)));
-               TALLOC_FREE(sd);
                return status;
        }
 
-       status = smb1_file_se_access_check(sd,
-                               conn->server_info->ptok,
+       status = smb1_file_se_access_check(conn,
+                               sd,
+                               get_current_nttok(conn),
                                access_mask,
                                access_granted);
 
-       TALLOC_FREE(sd);
-
        DEBUG(10,("smbd_check_open_rights: file %s requesting "
                "0x%x returning 0x%x (%s)\n",
                smb_fname_str_dbg(smb_fname),
@@ -112,6 +103,16 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
                (unsigned int)*access_granted,
                nt_errstr(status) ));
 
+       if (!NT_STATUS_IS_OK(status)) {
+               if (DEBUGLEVEL >= 10) {
+                       DEBUG(10,("smbd_check_open_rights: acl for %s is:\n",
+                               smb_fname_str_dbg(smb_fname) ));
+                       NDR_PRINT_DEBUG(security_descriptor, sd);
+               }
+       }
+
+       TALLOC_FREE(sd);
+
        return status;
 }
 
@@ -120,11 +121,11 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
 ****************************************************************************/
 
 static NTSTATUS fd_open(struct connection_struct *conn,
-                   struct smb_filename *smb_fname,
                    files_struct *fsp,
                    int flags,
                    mode_t mode)
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        NTSTATUS status = NT_STATUS_OK;
 
 #ifdef O_NOFOLLOW
@@ -170,6 +171,9 @@ NTSTATUS fd_close(files_struct *fsp)
 {
        int ret;
 
+       if (fsp->dptr) {
+               dptr_CloseDir(fsp);
+       }
        if (fsp->fh->fd == -1) {
                return NT_STATUS_OK; /* What we used to call a stat open. */
        }
@@ -210,6 +214,17 @@ void change_file_owner_to_parent(connection_struct *conn,
                         "directory %s. Error was %s\n",
                         smb_fname_str_dbg(smb_fname_parent),
                         strerror(errno)));
+               TALLOC_FREE(smb_fname_parent);
+               return;
+       }
+
+       if (smb_fname_parent->st.st_ex_uid == fsp->fsp_name->st.st_ex_uid) {
+               /* Already this uid - no need to change. */
+               DEBUG(10,("change_file_owner_to_parent: file %s "
+                       "is already owned by uid %d\n",
+                       fsp_str_dbg(fsp),
+                       (int)fsp->fsp_name->st.st_ex_uid ));
+               TALLOC_FREE(smb_fname_parent);
                return;
        }
 
@@ -222,12 +237,12 @@ void change_file_owner_to_parent(connection_struct *conn,
                         "was %s\n", fsp_str_dbg(fsp),
                         (unsigned int)smb_fname_parent->st.st_ex_uid,
                         strerror(errno) ));
+       } else {
+               DEBUG(10,("change_file_owner_to_parent: changed new file %s to "
+                       "parent directory uid %u.\n", fsp_str_dbg(fsp),
+                       (unsigned int)smb_fname_parent->st.st_ex_uid));
        }
 
-       DEBUG(10,("change_file_owner_to_parent: changed new file %s to "
-                 "parent directory uid %u.\n", fsp_str_dbg(fsp),
-                 (unsigned int)smb_fname_parent->st.st_ex_uid));
-
        TALLOC_FREE(smb_fname_parent);
 }
 
@@ -310,8 +325,18 @@ NTSTATUS change_dir_owner_to_parent(connection_struct *conn,
                goto chdir;
        }
 
+       if (smb_fname_parent->st.st_ex_uid == smb_fname_cwd->st.st_ex_uid) {
+               /* Already this uid - no need to change. */
+               DEBUG(10,("change_dir_owner_to_parent: directory %s "
+                       "is already owned by uid %d\n",
+                       fname,
+                       (int)smb_fname_cwd->st.st_ex_uid ));
+               status = NT_STATUS_OK;
+               goto chdir;
+       }
+
        become_root();
-       ret = SMB_VFS_CHOWN(conn, ".", smb_fname_parent->st.st_ex_uid,
+       ret = SMB_VFS_LCHOWN(conn, ".", smb_fname_parent->st.st_ex_uid,
                            (gid_t)-1);
        unbecome_root();
        if (ret == -1) {
@@ -321,13 +346,12 @@ NTSTATUS change_dir_owner_to_parent(connection_struct *conn,
                          "Error was %s\n", fname,
                          (unsigned int)smb_fname_parent->st.st_ex_uid,
                          strerror(errno) ));
-               goto chdir;
+       } else {
+               DEBUG(10,("change_dir_owner_to_parent: changed ownership of new "
+                       "directory %s to parent directory uid %u.\n",
+                       fname, (unsigned int)smb_fname_parent->st.st_ex_uid ));
        }
 
-       DEBUG(10,("change_dir_owner_to_parent: changed ownership of new "
-                 "directory %s to parent directory uid %u.\n",
-                 fname, (unsigned int)smb_fname_parent->st.st_ex_uid ));
-
  chdir:
        vfs_ChDir(conn,saved_dir);
  out:
@@ -344,16 +368,16 @@ static NTSTATUS open_file(files_struct *fsp,
                          connection_struct *conn,
                          struct smb_request *req,
                          const char *parent_dir,
-                         struct smb_filename *smb_fname,
                          int flags,
                          mode_t unx_mode,
                          uint32 access_mask, /* client requested access mask. */
                          uint32 open_access_mask) /* what we're actually using in the open. */
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        NTSTATUS status = NT_STATUS_OK;
        int accmode = (flags & O_ACCMODE);
        int local_flags = flags;
-       bool file_existed = VALID_STAT(smb_fname->st);
+       bool file_existed = VALID_STAT(fsp->fsp_name->st);
 
        fsp->fh->fd = -1;
        errno = EPERM;
@@ -444,7 +468,7 @@ static NTSTATUS open_file(files_struct *fsp,
                }
 
                /* Actually do the open */
-               status = fd_open(conn, smb_fname, fsp, local_flags, unx_mode);
+               status = fd_open(conn, fsp, local_flags, unx_mode);
                if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(3,("Error opening file %s (%s) (local_flags=%d) "
                                 "(flags=%d)\n", smb_fname_str_dbg(smb_fname),
@@ -605,26 +629,20 @@ static NTSTATUS open_file(files_struct *fsp,
                fsp->can_write = (access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) ?
                        True : False;
        }
-       fsp->print_file = False;
+       fsp->print_file = NULL;
        fsp->modified = False;
        fsp->sent_oplock_break = NO_BREAK_SENT;
        fsp->is_directory = False;
        if (conn->aio_write_behind_list &&
            is_in_path(smb_fname->base_name, conn->aio_write_behind_list,
-                      get_Protocol(conn->sconn), conn->case_sensitive)) {
+                      conn->case_sensitive)) {
                fsp->aio_write_behind = True;
        }
-       status = fsp_set_smb_fname(fsp, smb_fname);
-       if (!NT_STATUS_IS_OK(status)) {
-               fd_close(fsp);
-               errno = map_errno_from_nt_status(status);
-               return status;
-       }
 
        fsp->wcp = NULL; /* Write cache pointer. */
 
        DEBUG(2,("%s opened file %s read=%s write=%s (numopen=%d)\n",
-                conn->server_info->unix_name,
+                conn->session_info->unix_name,
                 smb_fname_str_dbg(smb_fname),
                 BOOLSTR(fsp->can_read), BOOLSTR(fsp->can_write),
                 conn->num_files_open));
@@ -719,7 +737,7 @@ sa = 0x%x, share = 0x%x\n", (num), (unsigned int)(am), (unsigned int)(right), (u
                   share_access, FILE_SHARE_WRITE);
        CHECK_MASK(2, access_mask, FILE_WRITE_DATA | FILE_APPEND_DATA,
                   entry->share_access, FILE_SHARE_WRITE);
-       
+
        CHECK_MASK(3, entry->access_mask, FILE_READ_DATA | FILE_EXECUTE,
                   share_access, FILE_SHARE_READ);
        CHECK_MASK(4, access_mask, FILE_READ_DATA | FILE_EXECUTE,
@@ -735,7 +753,8 @@ sa = 0x%x, share = 0x%x\n", (num), (unsigned int)(am), (unsigned int)(right), (u
 }
 
 #if defined(DEVELOPER)
-static void validate_my_share_entries(int num,
+static void validate_my_share_entries(struct smbd_server_connection *sconn,
+                                     int num,
                                      struct share_mode_entry *share_entry)
 {
        files_struct *fsp;
@@ -757,7 +776,7 @@ static void validate_my_share_entries(int num,
                return;
        }
 
-       fsp = file_find_dif(share_entry->id,
+       fsp = file_find_dif(sconn, share_entry->id,
                            share_entry->share_file_id);
        if (!fsp) {
                DEBUG(0,("validate_my_share_entries: PANIC : %s\n",
@@ -817,6 +836,7 @@ bool is_stat_open(uint32 access_mask)
 
 static NTSTATUS open_mode_check(connection_struct *conn,
                                struct share_mode_lock *lck,
+                               uint32_t name_hash,
                                uint32 access_mask,
                                uint32 share_access,
                                uint32 create_options,
@@ -832,7 +852,7 @@ static NTSTATUS open_mode_check(connection_struct *conn,
 
        /* A delete on close prohibits everything */
 
-       if (lck->delete_on_close) {
+       if (is_delete_on_close_set(lck, name_hash)) {
                return NT_STATUS_DELETE_PENDING;
        }
 
@@ -845,10 +865,11 @@ static NTSTATUS open_mode_check(connection_struct *conn,
        /*
         * Check if the share modes will give us access.
         */
-       
+
 #if defined(DEVELOPER)
        for(i = 0; i < lck->num_share_modes; i++) {
-               validate_my_share_entries(i, &lck->share_modes[i]);
+               validate_my_share_entries(conn->sconn, i,
+                                         &lck->share_modes[i]);
        }
 #endif
 
@@ -870,7 +891,7 @@ static NTSTATUS open_mode_check(connection_struct *conn,
                        return NT_STATUS_SHARING_VIOLATION;
                }
        }
-       
+
        return NT_STATUS_OK;
 }
 
@@ -886,7 +907,7 @@ static bool is_delete_request(files_struct *fsp) {
 
 static NTSTATUS send_break_message(files_struct *fsp,
                                        struct share_mode_entry *exclusive,
-                                       uint16 mid,
+                                       uint64_t mid,
                                        int oplock_request)
 {
        NTSTATUS status;
@@ -903,10 +924,11 @@ static NTSTATUS send_break_message(files_struct *fsp,
           don't want this set in the share mode struct pointed to by lck. */
 
        if (oplock_request & FORCE_OPLOCK_BREAK_TO_NONE) {
-               SSVAL(msg,6,exclusive->op_type | FORCE_OPLOCK_BREAK_TO_NONE);
+               SSVAL(msg,OP_BREAK_MSG_OP_TYPE_OFFSET,
+                       exclusive->op_type | FORCE_OPLOCK_BREAK_TO_NONE);
        }
 
-       status = messaging_send_buf(smbd_messaging_context(), exclusive->pid,
+       status = messaging_send_buf(fsp->conn->sconn->msg_ctx, exclusive->pid,
                                    MSG_SMB_BREAK_REQUEST,
                                    (uint8 *)msg,
                                    MSG_SMB_SHARE_MODE_ENTRY_SIZE);
@@ -919,93 +941,152 @@ static NTSTATUS send_break_message(files_struct *fsp,
 }
 
 /*
- * 1) No files open at all or internal open: Grant whatever the client wants.
- *
- * 2) Exclusive (or batch) oplock around: If the requested access is a delete
- *    request, break if the oplock around is a batch oplock. If it's another
- *    requested access type, break.
- *
- * 3) Only level2 around: Grant level2 and do nothing else.
+ * Return share_mode_entry pointers for :
+ * 1). Batch oplock entry.
+ * 2). Batch or exclusive oplock entry (may be identical to #1).
+ * bool have_level2_oplock
+ * bool have_no_oplock.
+ * Do internal consistency checks on the share mode for a file.
  */
 
-static bool delay_for_oplocks(struct share_mode_lock *lck,
-                             files_struct *fsp,
-                             uint16 mid,
-                             int pass_number,
-                             int oplock_request)
+static void find_oplock_types(struct share_mode_lock *lck,
+                               struct share_mode_entry **pp_batch,
+                               struct share_mode_entry **pp_ex_or_batch,
+                               bool *got_level2,
+                               bool *got_no_oplock)
 {
        int i;
-       struct share_mode_entry *exclusive = NULL;
-       bool valid_entry = false;
-       bool have_level2 = false;
-       bool have_a_none_oplock = false;
-       bool allow_level2 = (global_client_caps & CAP_LEVEL_II_OPLOCKS) &&
-                           lp_level2_oplocks(SNUM(fsp->conn));
 
-       if (oplock_request & INTERNAL_OPEN_ONLY) {
-               fsp->oplock_type = NO_OPLOCK;
-       }
-
-       if ((oplock_request & INTERNAL_OPEN_ONLY) || is_stat_open(fsp->access_mask)) {
-               return false;
-       }
+       *pp_batch = NULL;
+       *pp_ex_or_batch = NULL;
+       *got_level2 = false;
+       *got_no_oplock = false;
 
        for (i=0; i<lck->num_share_modes; i++) {
-
                if (!is_valid_share_mode_entry(&lck->share_modes[i])) {
                        continue;
                }
 
-               /* At least one entry is not an invalid or deferred entry. */
-               valid_entry = true;
-
-               if (pass_number == 1) {
-                       if (BATCH_OPLOCK_TYPE(lck->share_modes[i].op_type)) {
-                               SMB_ASSERT(exclusive == NULL);
-                               exclusive = &lck->share_modes[i];
+               if (BATCH_OPLOCK_TYPE(lck->share_modes[i].op_type)) {
+                       /* batch - can only be one. */
+                       if (*pp_ex_or_batch || *pp_batch || *got_level2 || *got_no_oplock) {
+                               smb_panic("Bad batch oplock entry.");
                        }
-               } else {
-                       if (EXCLUSIVE_OPLOCK_TYPE(lck->share_modes[i].op_type)) {
-                               SMB_ASSERT(exclusive == NULL);
-                               exclusive = &lck->share_modes[i];
+                       *pp_batch = &lck->share_modes[i];
+               }
+
+               if (EXCLUSIVE_OPLOCK_TYPE(lck->share_modes[i].op_type)) {
+                       /* Exclusive or batch - can only be one. */
+                       if (*pp_ex_or_batch || *got_level2 || *got_no_oplock) {
+                               smb_panic("Bad exclusive or batch oplock entry.");
                        }
+                       *pp_ex_or_batch = &lck->share_modes[i];
                }
 
                if (LEVEL_II_OPLOCK_TYPE(lck->share_modes[i].op_type)) {
-                       SMB_ASSERT(exclusive == NULL);
-                       have_level2 = true;
+                       if (*pp_batch || *pp_ex_or_batch) {
+                               smb_panic("Bad levelII oplock entry.");
+                       }
+                       *got_level2 = true;
                }
 
                if (lck->share_modes[i].op_type == NO_OPLOCK) {
-                       have_a_none_oplock = true;
+                       if (*pp_batch || *pp_ex_or_batch) {
+                               smb_panic("Bad no oplock entry.");
+                       }
+                       *got_no_oplock = true;
                }
        }
+}
+
+static bool delay_for_batch_oplocks(files_struct *fsp,
+                                       uint64_t mid,
+                                       int oplock_request,
+                                       struct share_mode_entry *batch_entry)
+{
+       if ((oplock_request & INTERNAL_OPEN_ONLY) || is_stat_open(fsp->access_mask)) {
+               return false;
+       }
+
+       if (batch_entry != NULL) {
+               /* Found a batch oplock */
+               send_break_message(fsp, batch_entry, mid, oplock_request);
+               return true;
+       }
+       return false;
+}
+
+static bool delay_for_exclusive_oplocks(files_struct *fsp,
+                                       uint64_t mid,
+                                       int oplock_request,
+                                       struct share_mode_entry *ex_entry)
+{
+       if ((oplock_request & INTERNAL_OPEN_ONLY) || is_stat_open(fsp->access_mask)) {
+               return false;
+       }
 
-       if (exclusive != NULL) { /* Found an exclusive oplock */
+       if (ex_entry != NULL) {
+               /* Found an exclusive or batch oplock */
                bool delay_it = is_delete_request(fsp) ?
-                               BATCH_OPLOCK_TYPE(exclusive->op_type) : true;
-               SMB_ASSERT(!have_level2);
+                               BATCH_OPLOCK_TYPE(ex_entry->op_type) : true;
                if (delay_it) {
-                       send_break_message(fsp, exclusive, mid, oplock_request);
+                       send_break_message(fsp, ex_entry, mid, oplock_request);
                        return true;
                }
        }
+       return false;
+}
+
+static bool file_has_brlocks(files_struct *fsp)
+{
+       struct byte_range_lock *br_lck;
+
+       br_lck = brl_get_locks_readonly(fsp);
+       if (!br_lck)
+               return false;
+
+       return br_lck->num_locks > 0 ? true : false;
+}
+
+static void grant_fsp_oplock_type(files_struct *fsp,
+                               int oplock_request,
+                               bool got_level2_oplock,
+                               bool got_a_none_oplock)
+{
+       bool allow_level2 = (global_client_caps & CAP_LEVEL_II_OPLOCKS) &&
+                           lp_level2_oplocks(SNUM(fsp->conn));
+
+       /* Start by granting what the client asked for,
+          but ensure no SAMBA_PRIVATE bits can be set. */
+       fsp->oplock_type = (oplock_request & ~SAMBA_PRIVATE_OPLOCK_MASK);
+
+       if (oplock_request & INTERNAL_OPEN_ONLY) {
+               /* No oplocks on internal open. */
+               fsp->oplock_type = NO_OPLOCK;
+               DEBUG(10,("grant_fsp_oplock_type: oplock type 0x%x on file %s\n",
+                       fsp->oplock_type, fsp_str_dbg(fsp)));
+               return;
+       } else if (lp_locking(fsp->conn->params) && file_has_brlocks(fsp)) {
+               DEBUG(10,("grant_fsp_oplock_type: file %s has byte range locks\n",
+                       fsp_str_dbg(fsp)));
+               fsp->oplock_type = NO_OPLOCK;
+       }
+
+       if (is_stat_open(fsp->access_mask)) {
+               /* Leave the value already set. */
+               DEBUG(10,("grant_fsp_oplock_type: oplock type 0x%x on file %s\n",
+                       fsp->oplock_type, fsp_str_dbg(fsp)));
+               return;
+       }
 
        /*
         * Match what was requested (fsp->oplock_type) with
         * what was found in the existing share modes.
         */
 
-       if (!valid_entry) {
-               /* All entries are placeholders or deferred.
-                * Directly grant whatever the client wants. */
-               if (fsp->oplock_type == NO_OPLOCK) {
-                       /* Store a level2 oplock, but don't tell the client */
-                       fsp->oplock_type = FAKE_LEVEL_II_OPLOCK;
-               }
-       } else if (have_a_none_oplock) {
+       if (got_a_none_oplock) {
                fsp->oplock_type = NO_OPLOCK;
-       } else if (have_level2) {
+       } else if (got_level2_oplock) {
                if (fsp->oplock_type == NO_OPLOCK ||
                                fsp->oplock_type == FAKE_LEVEL_II_OPLOCK) {
                        /* Store a level2 oplock, but don't tell the client */
@@ -1014,8 +1095,13 @@ static bool delay_for_oplocks(struct share_mode_lock *lck,
                        fsp->oplock_type = LEVEL_II_OPLOCK;
                }
        } else {
-               /* This case can never happen. */
-               SMB_ASSERT(1);
+               /* All share_mode_entries are placeholders or deferred.
+                * Silently upgrade to fake levelII if the client didn't
+                * ask for an oplock. */
+               if (fsp->oplock_type == NO_OPLOCK) {
+                       /* Store a level2 oplock, but don't tell the client */
+                       fsp->oplock_type = FAKE_LEVEL_II_OPLOCK;
+               }
        }
 
        /*
@@ -1026,11 +1112,8 @@ static bool delay_for_oplocks(struct share_mode_lock *lck,
                fsp->oplock_type = FAKE_LEVEL_II_OPLOCK;
        }
 
-       DEBUG(10,("delay_for_oplocks: oplock type 0x%x on file %s\n",
+       DEBUG(10,("grant_fsp_oplock_type: oplock type 0x%x on file %s\n",
                  fsp->oplock_type, fsp_str_dbg(fsp)));
-
-       /* No delay. */
-       return false;
 }
 
 bool request_timed_out(struct timeval request_time,
@@ -1065,7 +1148,8 @@ static void defer_open(struct share_mode_lock *lck,
 
                if (procid_is_me(&e->pid) && (e->op_mid == req->mid)) {
                        DEBUG(0, ("Trying to defer an already deferred "
-                                 "request: mid=%d, exiting\n", req->mid));
+                               "request: mid=%llu, exiting\n",
+                               (unsigned long long)req->mid));
                        exit_server("attempt to defer a deferred request");
                }
        }
@@ -1073,16 +1157,17 @@ static void defer_open(struct share_mode_lock *lck,
        /* End paranoia check */
 
        DEBUG(10,("defer_open_sharing_error: time [%u.%06u] adding deferred "
-                 "open entry for mid %u\n",
+                 "open entry for mid %llu\n",
                  (unsigned int)request_time.tv_sec,
                  (unsigned int)request_time.tv_usec,
-                 (unsigned int)req->mid));
+                 (unsigned long long)req->mid));
 
-       if (!push_deferred_smb_message(req, request_time, timeout,
-                                      (char *)state, sizeof(*state))) {
-               exit_server("push_deferred_smb_message failed");
+       if (!push_deferred_open_message_smb(req, request_time, timeout,
+                                      state->id, (char *)state, sizeof(*state))) {
+               exit_server("push_deferred_open_message_smb failed");
        }
-       add_deferred_open(lck, req->mid, request_time, state->id);
+       add_deferred_open(lck, req->mid, request_time,
+                         sconn_server_id(req->sconn), state->id);
 }
 
 
@@ -1154,7 +1239,7 @@ NTSTATUS fcb_or_dos_open(struct smb_request *req,
        DEBUG(5,("fcb_or_dos_open: attempting old open semantics for "
                 "file %s.\n", smb_fname_str_dbg(smb_fname)));
 
-       for(fsp = file_find_di_first(id); fsp;
+       for(fsp = file_find_di_first(conn->sconn, id); fsp;
            fsp = file_find_di_next(fsp)) {
 
                DEBUG(10,("fcb_or_dos_open: checking file %s, fd = %d, "
@@ -1204,12 +1289,14 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                                 uint32 *paccess_mask,
                                 uint32 *pshare_mode,
                                 uint32 *pcreate_disposition,
-                                uint32 *pcreate_options)
+                                uint32 *pcreate_options,
+                                uint32_t *pprivate_flags)
 {
        uint32 access_mask;
        uint32 share_mode;
        uint32 create_disposition;
        uint32 create_options = FILE_NON_DIRECTORY_FILE;
+       uint32_t private_flags = 0;
 
        DEBUG(10,("map_open_params_to_ntcreate: fname = %s, deny_mode = 0x%x, "
                  "open_func = 0x%x\n",
@@ -1248,7 +1335,7 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                case OPENX_FILE_EXISTS_OPEN|OPENX_FILE_CREATE_IF_NOT_EXIST:
                        create_disposition = FILE_OPEN_IF;
                        break;
-       
+
                case OPENX_FILE_EXISTS_TRUNCATE:
                        create_disposition = FILE_OVERWRITE;
                        break;
@@ -1267,7 +1354,7 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                                  "open_func 0x%x\n", (unsigned int)open_func));
                        return False;
        }
+
        /* Create the NT compatible share modes. */
        switch (GET_DENY_MODE(deny_mode)) {
                case DENY_ALL:
@@ -1287,7 +1374,7 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                        break;
 
                case DENY_DOS:
-                       create_options |= NTCREATEX_OPTIONS_PRIVATE_DENY_DOS;
+                       private_flags |= NTCREATEX_OPTIONS_PRIVATE_DENY_DOS;
                        if (is_executable(smb_fname->base_name)) {
                                share_mode = FILE_SHARE_READ|FILE_SHARE_WRITE;
                        } else {
@@ -1300,7 +1387,7 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                        break;
 
                case DENY_FCB:
-                       create_options |= NTCREATEX_OPTIONS_PRIVATE_DENY_FCB;
+                       private_flags |= NTCREATEX_OPTIONS_PRIVATE_DENY_FCB;
                        share_mode = FILE_SHARE_NONE;
                        break;
 
@@ -1312,12 +1399,13 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
 
        DEBUG(10,("map_open_params_to_ntcreate: file %s, access_mask = 0x%x, "
                  "share_mode = 0x%x, create_disposition = 0x%x, "
-                 "create_options = 0x%x\n",
+                 "create_options = 0x%x private_flags = 0x%x\n",
                  smb_fname_str_dbg(smb_fname),
                  (unsigned int)access_mask,
                  (unsigned int)share_mode,
                  (unsigned int)create_disposition,
-                 (unsigned int)create_options ));
+                 (unsigned int)create_options,
+                 (unsigned int)private_flags));
 
        if (paccess_mask) {
                *paccess_mask = access_mask;
@@ -1331,6 +1419,9 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
        if (pcreate_options) {
                *pcreate_options = create_options;
        }
+       if (pprivate_flags) {
+               *pprivate_flags = private_flags;
+       }
 
        return True;
 
@@ -1399,9 +1490,9 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
                        uint32_t access_granted = 0;
 
                        status = SMB_VFS_GET_NT_ACL(conn, smb_fname->base_name,
-                                       (OWNER_SECURITY_INFORMATION |
-                                       GROUP_SECURITY_INFORMATION |
-                                       DACL_SECURITY_INFORMATION),&sd);
+                                       (SECINFO_OWNER |
+                                       SECINFO_GROUP |
+                                       SECINFO_DACL),&sd);
 
                        if (!NT_STATUS_IS_OK(status)) {
                                DEBUG(10, ("calculate_access_mask: Could not get acl "
@@ -1411,8 +1502,9 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
                                return NT_STATUS_ACCESS_DENIED;
                        }
 
-                       status = smb1_file_se_access_check(sd,
-                                       conn->server_info->ptok,
+                       status = smb1_file_se_access_check(conn,
+                                       sd,
+                                       get_current_nttok(conn),
                                        access_mask,
                                        &access_granted);
 
@@ -1435,13 +1527,29 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
        return NT_STATUS_OK;
 }
 
+/****************************************************************************
+ Remove the deferred open entry under lock.
+****************************************************************************/
+
+void remove_deferred_open_entry(struct file_id id, uint64_t mid,
+                               struct server_id pid)
+{
+       struct share_mode_lock *lck = get_share_mode_lock(talloc_tos(), id,
+                       NULL, NULL, NULL);
+       if (lck == NULL) {
+               DEBUG(0, ("could not get share mode lock\n"));
+       } else {
+               del_deferred_open_entry(lck, mid, pid);
+               TALLOC_FREE(lck);
+       }
+}
+
 /****************************************************************************
  Open a file with a share mode. Passed in an already created files_struct *.
 ****************************************************************************/
 
 static NTSTATUS open_file_ntcreate(connection_struct *conn,
                            struct smb_request *req,
-                           struct smb_filename *smb_fname,
                            uint32 access_mask,         /* access bits (FILE_READ_DATA etc.) */
                            uint32 share_access,        /* share constants (FILE_SHARE_READ etc) */
                            uint32 create_disposition,  /* FILE_OPEN_IF etc. */
@@ -1449,9 +1557,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                            uint32 new_dos_attributes,  /* attributes used for new file. */
                            int oplock_request,         /* internal Samba oplock codes. */
                                                        /* Information (FILE_EXISTS etc.) */
+                           uint32_t private_flags,     /* Samba specific flags. */
                            int *pinfo,
                            files_struct *fsp)
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        int flags=0;
        int flags2=0;
        bool file_existed = VALID_STAT(smb_fname->st);
@@ -1465,7 +1575,6 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        mode_t unx_mode = (mode_t)0;
        int info;
        uint32 existing_dos_attributes = 0;
-       struct pending_message_list *pml = NULL;
        struct timeval request_time = timeval_zero();
        struct share_mode_lock *lck = NULL;
        uint32 open_access_mask = access_mask;
@@ -1474,6 +1583,12 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
        ZERO_STRUCT(id);
 
+       /* Windows allows a new file to be created and
+          silently removes a FILE_ATTRIBUTE_DIRECTORY
+          sent by the client. Do the same. */
+
+       new_dos_attributes &= ~FILE_ATTRIBUTE_DIRECTORY;
+
        if (conn->printer) {
                /*
                 * Printers are handled completely differently.
@@ -1493,8 +1608,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return NT_STATUS_INTERNAL_ERROR;
                }
 
-               return print_fsp_open(req, conn, smb_fname->base_name,
-                                     req->vuid, fsp);
+               return print_spool_open(fsp, smb_fname->base_name,
+                                       req->vuid);
        }
 
        if (!parent_dirname(talloc_tos(), smb_fname->base_name, &parent_dir,
@@ -1516,10 +1631,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        DEBUG(10, ("open_file_ntcreate: fname=%s, dos_attrs=0x%x "
                   "access_mask=0x%x share_access=0x%x "
                   "create_disposition = 0x%x create_options=0x%x "
-                  "unix mode=0%o oplock_request=%d\n",
+                  "unix mode=0%o oplock_request=%d private_flags = 0x%x\n",
                   smb_fname_str_dbg(smb_fname), new_dos_attributes,
                   access_mask, share_access, create_disposition,
-                  create_options, (unsigned int)unx_mode, oplock_request));
+                  create_options, (unsigned int)unx_mode, oplock_request,
+                  (unsigned int)private_flags));
 
        if ((req == NULL) && ((oplock_request & INTERNAL_OPEN_ONLY) == 0)) {
                DEBUG(0, ("No smb request but not an internal only open!\n"));
@@ -1530,29 +1646,25 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * Only non-internal opens can be deferred at all
         */
 
-       if ((req != NULL)
-           && ((pml = get_open_deferred_message(req->mid)) != NULL)) {
-               struct deferred_open_record *state =
-                       (struct deferred_open_record *)pml->private_data.data;
+       if (req) {
+               void *ptr;
+               if (get_deferred_open_message_state(req,
+                               &request_time,
+                               &ptr)) {
 
-               /* Remember the absolute time of the original
-                  request with this mid. We'll use it later to
-                  see if this has timed out. */
+                       struct deferred_open_record *state = (struct deferred_open_record *)ptr;
+                       /* Remember the absolute time of the original
+                          request with this mid. We'll use it later to
+                          see if this has timed out. */
 
-               request_time = pml->request_time;
+                       /* Remove the deferred open entry under lock. */
+                       remove_deferred_open_entry(
+                               state->id, req->mid,
+                               sconn_server_id(req->sconn));
 
-               /* Remove the deferred open entry under lock. */
-               lck = get_share_mode_lock(talloc_tos(), state->id, NULL, NULL,
-                                         NULL);
-               if (lck == NULL) {
-                       DEBUG(0, ("could not get share mode lock\n"));
-               } else {
-                       del_deferred_open_entry(lck, req->mid);
-                       TALLOC_FREE(lck);
+                       /* Ensure we don't reprocess this message. */
+                       remove_deferred_open_message_smb(req->mid);
                }
-
-               /* Ensure we don't reprocess this message. */
-               remove_deferred_open_smb_message(req->mid);
        }
 
        status = check_name(conn, smb_fname->base_name);
@@ -1568,9 +1680,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        }
 
        /* ignore any oplock requests if oplocks are disabled */
-       if (!lp_oplocks(SNUM(conn)) || global_client_failed_oplock_break ||
-           is_in_path(smb_fname->base_name, conn->veto_oplock_list,
-                      get_Protocol(conn->sconn), conn->case_sensitive)) {
+       if (!lp_oplocks(SNUM(conn)) ||
+           IS_VETO_OPLOCK_PATH(conn, smb_fname->base_name)) {
                /* Mask off everything except the private Samba bits. */
                oplock_request &= SAMBA_PRIVATE_OPLOCK_MASK;
        }
@@ -1714,7 +1825,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                /* DENY_DOS opens are always underlying read-write on the
                   file handle, no matter what the requested access mask
                    says. */
-               if ((create_options & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS) ||
+               if ((private_flags & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS) ||
                        access_mask & (FILE_READ_ATTRIBUTES|FILE_READ_DATA|FILE_READ_EA|FILE_EXECUTE)) {
                        flags = O_RDWR;
                } else {
@@ -1763,7 +1874,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
        fsp->file_id = vfs_file_id_from_sbuf(conn, &smb_fname->st);
        fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
+       fsp->fh->private_options = private_flags;
        fsp->access_mask = open_access_mask; /* We change this to the
                                              * requested access_mask after
                                              * the open is done. */
@@ -1777,6 +1888,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        }
 
        if (file_existed) {
+               struct share_mode_entry *batch_entry = NULL;
+               struct share_mode_entry *exclusive_entry = NULL;
+               bool got_level2_oplock = false;
+               bool got_a_none_oplock = false;
+
                struct timespec old_write_time = smb_fname->st.st_ex_mtime;
                id = vfs_file_id_from_sbuf(conn, &smb_fname->st);
 
@@ -1789,10 +1905,19 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return NT_STATUS_SHARING_VIOLATION;
                }
 
+               /* Get the types we need to examine. */
+               find_oplock_types(lck,
+                               &batch_entry,
+                               &exclusive_entry,
+                               &got_level2_oplock,
+                               &got_a_none_oplock);
+
                /* First pass - send break only on batch oplocks. */
-               if ((req != NULL)
-                   && delay_for_oplocks(lck, fsp, req->mid, 1,
-                                        oplock_request)) {
+               if ((req != NULL) &&
+                               delay_for_batch_oplocks(fsp,
+                                       req->mid,
+                                       oplock_request,
+                                       batch_entry)) {
                        schedule_defer_open(lck, request_time, req);
                        TALLOC_FREE(lck);
                        return NT_STATUS_SHARING_VIOLATION;
@@ -1800,7 +1925,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
                /* Use the client requested access mask here, not the one we
                 * open with. */
-               status = open_mode_check(conn, lck, access_mask, share_access,
+               status = open_mode_check(conn, lck, fsp->name_hash,
+                                       access_mask, share_access,
                                         create_options, &file_existed);
 
                if (NT_STATUS_IS_OK(status)) {
@@ -1808,9 +1934,12 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                         * status again. */
                        /* Second pass - send break for both batch or
                         * exclusive oplocks. */
-                       if ((req != NULL)
-                            && delay_for_oplocks(lck, fsp, req->mid, 2,
-                                                 oplock_request)) {
+                       if ((req != NULL) &&
+                                       delay_for_exclusive_oplocks(
+                                               fsp,
+                                               req->mid,
+                                               oplock_request,
+                                               exclusive_entry)) {
                                schedule_defer_open(lck, request_time, req);
                                TALLOC_FREE(lck);
                                return NT_STATUS_SHARING_VIOLATION;
@@ -1823,6 +1952,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return status;
                }
 
+               grant_fsp_oplock_type(fsp,
+                                oplock_request,
+                                got_level2_oplock,
+                                got_a_none_oplock);
+
                if (!NT_STATUS_IS_OK(status)) {
                        uint32 can_access_mask;
                        bool can_access = True;
@@ -1831,7 +1965,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
                        /* Check if this can be done with the deny_dos and fcb
                         * calls. */
-                       if (create_options &
+                       if (private_flags &
                            (NTCREATEX_OPTIONS_PRIVATE_DENY_DOS|
                             NTCREATEX_OPTIONS_PRIVATE_DENY_FCB)) {
                                if (req == NULL) {
@@ -1957,7 +2091,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
         if ((flags2 & O_CREAT) && lp_inherit_acls(SNUM(conn)) &&
            (def_acl = directory_has_default_acl(conn, parent_dir))) {
-               unx_mode = 0777;
+               unx_mode = (0777 & lp_create_mask(SNUM(conn)));
        }
 
        DEBUG(4,("calling open_file with flags=0x%X flags2=0x%X mode=0%o, "
@@ -1970,7 +2104,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * open_file strips any O_TRUNC flags itself.
         */
 
-       fsp_open = open_file(fsp, conn, req, parent_dir, smb_fname,
+       fsp_open = open_file(fsp, conn, req, parent_dir,
                             flags|flags2, unx_mode, access_mask,
                             open_access_mask);
 
@@ -1982,6 +2116,10 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        }
 
        if (!file_existed) {
+               struct share_mode_entry *batch_entry = NULL;
+               struct share_mode_entry *exclusive_entry = NULL;
+               bool got_level2_oplock = false;
+               bool got_a_none_oplock = false;
                struct timespec old_write_time = smb_fname->st.st_ex_mtime;
                /*
                 * Deal with the race condition where two smbd's detect the
@@ -2012,17 +2150,27 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return NT_STATUS_SHARING_VIOLATION;
                }
 
+               /* Get the types we need to examine. */
+               find_oplock_types(lck,
+                               &batch_entry,
+                               &exclusive_entry,
+                               &got_level2_oplock,
+                               &got_a_none_oplock);
+
                /* First pass - send break only on batch oplocks. */
-               if ((req != NULL)
-                   && delay_for_oplocks(lck, fsp, req->mid, 1,
-                                        oplock_request)) {
+               if ((req != NULL) &&
+                               delay_for_batch_oplocks(fsp,
+                                       req->mid,
+                                       oplock_request,
+                                       batch_entry)) {
                        schedule_defer_open(lck, request_time, req);
                        TALLOC_FREE(lck);
                        fd_close(fsp);
                        return NT_STATUS_SHARING_VIOLATION;
                }
 
-               status = open_mode_check(conn, lck, access_mask, share_access,
+               status = open_mode_check(conn, lck, fsp->name_hash,
+                                       access_mask, share_access,
                                         create_options, &file_existed);
 
                if (NT_STATUS_IS_OK(status)) {
@@ -2030,9 +2178,12 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                         * status again. */
                        /* Second pass - send break for both batch or
                         * exclusive oplocks. */
-                       if ((req != NULL)
-                           && delay_for_oplocks(lck, fsp, req->mid, 2,
-                                                oplock_request)) {
+                       if ((req != NULL) &&
+                                       delay_for_exclusive_oplocks(
+                                               fsp,
+                                               req->mid,
+                                               oplock_request,
+                                               exclusive_entry)) {
                                schedule_defer_open(lck, request_time, req);
                                TALLOC_FREE(lck);
                                fd_close(fsp);
@@ -2063,6 +2214,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return status;
                }
 
+               grant_fsp_oplock_type(fsp,
+                                oplock_request,
+                                got_level2_oplock,
+                                got_a_none_oplock);
+
                /*
                 * We exit this block with the share entry *locked*.....
                 */
@@ -2112,7 +2268,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * If requested, truncate the file.
         */
 
-       if (flags2&O_TRUNC) {
+       if (file_existed && (flags2&O_TRUNC)) {
                /*
                 * We are modifing the file after open - update the stat
                 * struct..
@@ -2126,13 +2282,22 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                }
        }
 
-       /* Record the options we were opened with. */
-       fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
        /*
         * According to Samba4, SEC_FILE_READ_ATTRIBUTE is always granted,
+        * but we don't have to store this - just ignore it on access check.
         */
-       fsp->access_mask = access_mask | FILE_READ_ATTRIBUTES;
+       if (conn->sconn->using_smb2) {
+               /*
+                * SMB2 doesn't return it (according to Microsoft tests).
+                * Test Case: TestSuite_ScenarioNo009GrantedAccessTestS0
+                * File created with access = 0x7 (Read, Write, Delete)
+                * Query Info on file returns 0x87 (Read, Write, Delete, Read Attributes)
+                */
+               fsp->access_mask = access_mask;
+       } else {
+               /* But SMB1 does. */
+               fsp->access_mask = access_mask | FILE_READ_ATTRIBUTES;
+       }
 
        if (file_existed) {
                /* stat opens on existing files don't get oplocks. */
@@ -2159,7 +2324,10 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         */
 
        if (!set_file_oplock(fsp, fsp->oplock_type)) {
-               /* Could not get the kernel oplock */
+               /*
+                * Could not get the kernel oplock or there are byte-range
+                * locks on the file.
+                */
                fsp->oplock_type = NO_OPLOCK;
        }
 
@@ -2167,13 +2335,13 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                new_file_created = True;
        }
 
-       set_share_mode(lck, fsp, conn->server_info->utok.uid, 0,
+       set_share_mode(lck, fsp, get_current_uid(conn), 0,
                       fsp->oplock_type);
 
        /* Handle strange delete on close create semantics. */
        if (create_options & FILE_DELETE_ON_CLOSE) {
 
-               status = can_set_delete_on_close(fsp, True, new_dos_attributes);
+               status = can_set_delete_on_close(fsp, new_dos_attributes);
 
                if (!NT_STATUS_IS_OK(status)) {
                        /* Remember to delete the mode we just added. */
@@ -2201,6 +2369,15 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                }
        }
 
+       /* Determine sparse flag. */
+       if (posix_open) {
+               /* POSIX opens are sparse by default. */
+               fsp->is_sparse = true;
+       } else {
+               fsp->is_sparse = (file_existed &&
+                       (existing_dos_attributes & FILE_ATTRIBUTE_SPARSE));
+       }
+
        /*
         * Take care of inherited ACLs on created files - if default ACL not
         * selected.
@@ -2249,7 +2426,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        /* If this is a successful open, we must remove any deferred open
         * records. */
        if (req != NULL) {
-               del_deferred_open_entry(lck, req->mid);
+               del_deferred_open_entry(lck, req->mid,
+                                       sconn_server_id(req->sconn));
        }
        TALLOC_FREE(lck);
 
@@ -2261,23 +2439,15 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
  Open a file for for write to ensure that we can fchmod it.
 ****************************************************************************/
 
-NTSTATUS open_file_fchmod(struct smb_request *req, connection_struct *conn,
+NTSTATUS open_file_fchmod(connection_struct *conn,
                          struct smb_filename *smb_fname,
                          files_struct **result)
 {
-       files_struct *fsp = NULL;
-       NTSTATUS status;
-
        if (!VALID_STAT(smb_fname->st)) {
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       status = file_new(req, conn, &fsp);
-       if(!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-        status = SMB_VFS_CREATE_FILE(
+        return SMB_VFS_CREATE_FILE(
                conn,                                   /* conn */
                NULL,                                   /* req */
                0,                                      /* root_dir_fid */
@@ -2288,36 +2458,13 @@ NTSTATUS open_file_fchmod(struct smb_request *req, connection_struct *conn,
                FILE_OPEN,                              /* create_disposition*/
                0,                                      /* create_options */
                0,                                      /* file_attributes */
-               0,                                      /* oplock_request */
+               INTERNAL_OPEN_ONLY,                     /* oplock_request */
                0,                                      /* allocation_size */
+               0,                                      /* private_flags */
                NULL,                                   /* sd */
                NULL,                                   /* ea_list */
-               &fsp,                                   /* result */
+               result,                                 /* result */
                NULL);                                  /* pinfo */
-
-       /*
-        * This is not a user visible file open.
-        * Don't set a share mode.
-        */
-
-       if (!NT_STATUS_IS_OK(status)) {
-               file_free(req, fsp);
-               return status;
-       }
-
-       *result = fsp;
-       return NT_STATUS_OK;
-}
-
-/****************************************************************************
- Close the fchmod file fd - ensure no locks are lost.
-****************************************************************************/
-
-NTSTATUS close_file_fchmod(struct smb_request *req, files_struct *fsp)
-{
-       NTSTATUS status = fd_close(fsp);
-       file_free(req, fsp);
-       return status;
 }
 
 static NTSTATUS mkdir_internal(connection_struct *conn,
@@ -2412,6 +2559,22 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
        return NT_STATUS_OK;
 }
 
+/****************************************************************************
+ Ensure we didn't get symlink raced on opening a directory.
+****************************************************************************/
+
+bool check_same_stat(const SMB_STRUCT_STAT *sbuf1,
+                       const SMB_STRUCT_STAT *sbuf2)
+{
+       if (sbuf1->st_ex_uid != sbuf2->st_ex_uid ||
+                       sbuf1->st_ex_gid != sbuf2->st_ex_gid ||
+                       sbuf1->st_ex_dev != sbuf2->st_ex_dev ||
+                       sbuf1->st_ex_ino != sbuf2->st_ex_ino) {
+               return false;
+       }
+       return true;
+}
+
 /****************************************************************************
  Open a directory from an NT SMB call.
 ****************************************************************************/
@@ -2436,6 +2599,9 @@ static NTSTATUS open_directory(connection_struct *conn,
 
        SMB_ASSERT(!is_ntfs_stream_smb_fname(smb_dname));
 
+       /* Ensure we have a directory attribute. */
+       file_attributes |= FILE_ATTRIBUTE_DIRECTORY;
+
        DEBUG(5,("open_directory: opening directory %s, access_mask = 0x%x, "
                 "share_access = 0x%x create_options = 0x%x, "
                 "create_disposition = 0x%x, file_attributes = 0x%x\n",
@@ -2464,8 +2630,9 @@ static NTSTATUS open_directory(connection_struct *conn,
                return status;
        }
 
-       /* We need to support SeSecurityPrivilege for this. */
-       if (access_mask & SEC_FLAG_SYSTEM_SECURITY) {
+       if ((access_mask & SEC_FLAG_SYSTEM_SECURITY) &&
+                       !security_token_has_privilege(get_current_nttok(conn),
+                                       SEC_PRIV_SECURITY)) {
                DEBUG(10, ("open_directory: open on %s "
                        "failed - SEC_FLAG_SYSTEM_SECURITY denied.\n",
                        smb_fname_str_dbg(smb_dname)));
@@ -2475,16 +2642,11 @@ static NTSTATUS open_directory(connection_struct *conn,
        switch( create_disposition ) {
                case FILE_OPEN:
 
-                       info = FILE_WAS_OPENED;
-
-                       /*
-                        * We want to follow symlinks here.
-                        */
-
-                       if (SMB_VFS_STAT(conn, smb_dname) != 0) {
-                               return map_nt_error_from_unix(errno);
+                       if (!dir_existed) {
+                               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
                        }
-                               
+
+                       info = FILE_WAS_OPENED;
                        break;
 
                case FILE_CREATE:
@@ -2524,7 +2686,6 @@ static NTSTATUS open_directory(connection_struct *conn,
                                info = FILE_WAS_OPENED;
                                status = NT_STATUS_OK;
                        }
-                               
                        break;
 
                case FILE_SUPERSEDE:
@@ -2584,7 +2745,7 @@ static NTSTATUS open_directory(connection_struct *conn,
        /*
         * Setup the files_struct for it.
         */
-       
+
        fsp->mode = smb_dname->st.st_ex_mode;
        fsp->file_id = vfs_file_id_from_sbuf(conn, &smb_dname->st);
        fsp->vuid = req ? req->vuid : UID_FIELD_INVALID;
@@ -2594,12 +2755,12 @@ static NTSTATUS open_directory(connection_struct *conn,
        fsp->can_write = False;
 
        fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
+       fsp->fh->private_options = 0;
        /*
         * According to Samba4, SEC_FILE_READ_ATTRIBUTE is always granted,
         */
        fsp->access_mask = access_mask | FILE_READ_ATTRIBUTES;
-       fsp->print_file = False;
+       fsp->print_file = NULL;
        fsp->modified = False;
        fsp->oplock_type = NO_OPLOCK;
        fsp->sent_oplock_break = NO_BREAK_SENT;
@@ -2607,38 +2768,75 @@ static NTSTATUS open_directory(connection_struct *conn,
        fsp->posix_open = (file_attributes & FILE_FLAG_POSIX_SEMANTICS) ? True : False;
        status = fsp_set_smb_fname(fsp, smb_dname);
        if (!NT_STATUS_IS_OK(status)) {
+               file_free(req, fsp);
                return status;
        }
 
        mtimespec = smb_dname->st.st_ex_mtime;
 
+#ifdef O_DIRECTORY
+       status = fd_open(conn, fsp, O_RDONLY|O_DIRECTORY, 0);
+#else
+       /* POSIX allows us to open a directory with O_RDONLY. */
+       status = fd_open(conn, fsp, O_RDONLY, 0);
+#endif
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(5, ("open_directory: Could not open fd for "
+                       "%s (%s)\n",
+                       smb_fname_str_dbg(smb_dname),
+                       nt_errstr(status)));
+               file_free(req, fsp);
+               return status;
+       }
+
+       status = vfs_stat_fsp(fsp);
+       if (!NT_STATUS_IS_OK(status)) {
+               fd_close(fsp);
+               file_free(req, fsp);
+               return status;
+       }
+
+       /* Ensure there was no race condition. */
+       if (!check_same_stat(&smb_dname->st, &fsp->fsp_name->st)) {
+               DEBUG(5,("open_directory: stat struct differs for "
+                       "directory %s.\n",
+                       smb_fname_str_dbg(smb_dname)));
+               fd_close(fsp);
+               file_free(req, fsp);
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
        lck = get_share_mode_lock(talloc_tos(), fsp->file_id,
                                  conn->connectpath, smb_dname, &mtimespec);
 
        if (lck == NULL) {
                DEBUG(0, ("open_directory: Could not get share mode lock for "
                          "%s\n", smb_fname_str_dbg(smb_dname)));
+               fd_close(fsp);
                file_free(req, fsp);
                return NT_STATUS_SHARING_VIOLATION;
        }
 
-       status = open_mode_check(conn, lck, access_mask, share_access,
+       status = open_mode_check(conn, lck, fsp->name_hash,
+                               access_mask, share_access,
                                 create_options, &dir_existed);
 
        if (!NT_STATUS_IS_OK(status)) {
                TALLOC_FREE(lck);
+               fd_close(fsp);
                file_free(req, fsp);
                return status;
        }
 
-       set_share_mode(lck, fsp, conn->server_info->utok.uid, 0, NO_OPLOCK);
+       set_share_mode(lck, fsp, get_current_uid(conn), 0, NO_OPLOCK);
 
        /* For directories the delete on close bit at open time seems
           always to be honored on close... See test 19 in Samba4 BASE-DELETE. */
        if (create_options & FILE_DELETE_ON_CLOSE) {
-               status = can_set_delete_on_close(fsp, True, 0);
+               status = can_set_delete_on_close(fsp, 0);
                if (!NT_STATUS_IS_OK(status) && !NT_STATUS_EQUAL(status, NT_STATUS_DIRECTORY_NOT_EMPTY)) {
                        TALLOC_FREE(lck);
+                       fd_close(fsp);
                        file_free(req, fsp);
                        return status;
                }
@@ -2678,6 +2876,7 @@ NTSTATUS create_directory(connection_struct *conn, struct smb_request *req,
                FILE_ATTRIBUTE_DIRECTORY,               /* file_attributes */
                0,                                      /* oplock_request */
                0,                                      /* allocation_size */
+               0,                                      /* private_flags */
                NULL,                                   /* sd */
                NULL,                                   /* ea_list */
                &fsp,                                   /* result */
@@ -2701,6 +2900,7 @@ void msg_file_was_renamed(struct messaging_context *msg,
                          struct server_id server_id,
                          DATA_BLOB *data)
 {
+       struct smbd_server_connection *sconn;
        files_struct *fsp;
        char *frm = (char *)data->data;
        struct file_id id;
@@ -2711,6 +2911,12 @@ void msg_file_was_renamed(struct messaging_context *msg,
        size_t sp_len, bn_len;
        NTSTATUS status;
 
+       sconn = msg_ctx_to_sconn(msg);
+       if (sconn == NULL) {
+               DEBUG(1, ("could not find sconn\n"));
+               return;
+       }
+
        if (data->data == NULL
            || data->length < MSG_FILE_RENAMED_MIN_SIZE + 2) {
                 DEBUG(0, ("msg_file_was_renamed: Got invalid msg len %d\n",
@@ -2742,7 +2948,8 @@ void msg_file_was_renamed(struct messaging_context *msg,
                sharepath, smb_fname_str_dbg(smb_fname),
                file_id_string_tos(&id)));
 
-       for(fsp = file_find_di_first(id); fsp; fsp = file_find_di_next(fsp)) {
+       for(fsp = file_find_di_first(sconn, id); fsp;
+           fsp = file_find_di_next(fsp)) {
                if (memcmp(fsp->conn->connectpath, sharepath, sp_len) == 0) {
 
                        DEBUG(10,("msg_file_was_renamed: renaming file fnum %d from %s -> %s\n",
@@ -2771,52 +2978,6 @@ void msg_file_was_renamed(struct messaging_context *msg,
        return;
 }
 
-struct case_semantics_state {
-       connection_struct *conn;
-       bool case_sensitive;
-       bool case_preserve;
-       bool short_case_preserve;
-};
-
-/****************************************************************************
- Restore case semantics.
-****************************************************************************/
-static int restore_case_semantics(struct case_semantics_state *state)
-{
-       state->conn->case_sensitive = state->case_sensitive;
-       state->conn->case_preserve = state->case_preserve;
-       state->conn->short_case_preserve = state->short_case_preserve;
-       return 0;
-}
-
-/****************************************************************************
- Save case semantics.
-****************************************************************************/
-struct case_semantics_state *set_posix_case_semantics(TALLOC_CTX *mem_ctx,
-                                                     connection_struct *conn)
-{
-       struct case_semantics_state *result;
-
-       if (!(result = talloc(mem_ctx, struct case_semantics_state))) {
-               DEBUG(0, ("talloc failed\n"));
-               return NULL;
-       }
-
-       result->conn = conn;
-       result->case_sensitive = conn->case_sensitive;
-       result->case_preserve = conn->case_preserve;
-       result->short_case_preserve = conn->short_case_preserve;
-
-       /* Set to POSIX. */
-       conn->case_sensitive = True;
-       conn->case_preserve = True;
-       conn->short_case_preserve = True;
-
-       talloc_set_destructor(result, restore_case_semantics);
-
-       return result;
-}
-
 /*
  * If a main file is opened for delete, all streams need to be checked for
  * !FILE_SHARE_DELETE. Do this by opening with DELETE_ACCESS.
@@ -2893,10 +3054,11 @@ NTSTATUS open_streams_for_delete(connection_struct *conn,
                         (FILE_SHARE_READ |     /* share_access */
                             FILE_SHARE_WRITE | FILE_SHARE_DELETE),
                         FILE_OPEN,             /* create_disposition*/
-                        NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE, /* create_options */
+                        0,                     /* create_options */
                         FILE_ATTRIBUTE_NORMAL, /* file_attributes */
                         0,                     /* oplock_request */
                         0,                     /* allocation_size */
+                        NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE, /* private_flags */
                         NULL,                  /* sd */
                         NULL,                  /* ea_list */
                         &streams[i],           /* result */
@@ -2946,6 +3108,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                     uint32_t file_attributes,
                                     uint32_t oplock_request,
                                     uint64_t allocation_size,
+                                    uint32_t private_flags,
                                     struct security_descriptor *sd,
                                     struct ea_list *ea_list,
 
@@ -2960,7 +3123,8 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
        DEBUG(10,("create_file_unixpath: access_mask = 0x%x "
                  "file_attributes = 0x%x, share_access = 0x%x, "
                  "create_disposition = 0x%x create_options = 0x%x "
-                 "oplock_request = 0x%x ea_list = 0x%p, sd = 0x%p, "
+                 "oplock_request = 0x%x private_flags = 0x%x "
+                 "ea_list = 0x%p, sd = 0x%p, "
                  "fname = %s\n",
                  (unsigned int)access_mask,
                  (unsigned int)file_attributes,
@@ -2968,6 +3132,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                  (unsigned int)create_disposition,
                  (unsigned int)create_options,
                  (unsigned int)oplock_request,
+                 (unsigned int)private_flags,
                  ea_list, sd, smb_fname_str_dbg(smb_fname)));
 
        if (create_options & FILE_OPEN_BY_FILE_ID) {
@@ -3009,7 +3174,6 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
        if (lp_acl_check_permissions(SNUM(conn))
            && (create_disposition != FILE_CREATE)
-           && (share_access & FILE_SHARE_DELETE)
            && (access_mask & DELETE_ACCESS)
            && (!(can_delete_file_in_directory(conn, smb_fname) ||
                 can_access_file_acl(conn, smb_fname, DELETE_ACCESS)))) {
@@ -3020,33 +3184,19 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                goto fail;
        }
 
-#if 0
-       /* We need to support SeSecurityPrivilege for this. */
        if ((access_mask & SEC_FLAG_SYSTEM_SECURITY) &&
-           !user_has_privileges(current_user.nt_user_token,
-                                &se_security)) {
-               status = NT_STATUS_PRIVILEGE_NOT_HELD;
-               goto fail;
-       }
-#else
-       /* We need to support SeSecurityPrivilege for this. */
-       if (access_mask & SEC_FLAG_SYSTEM_SECURITY) {
-               status = NT_STATUS_PRIVILEGE_NOT_HELD;
-               goto fail;
-       }
-       /* Don't allow a SACL set from an NTtrans create until we
-        * support SeSecurityPrivilege. */
-       if (!VALID_STAT(smb_fname->st) &&
-                       lp_nt_acl_support(SNUM(conn)) &&
-                       sd && (sd->sacl != NULL)) {
+                       !security_token_has_privilege(get_current_nttok(conn),
+                                       SEC_PRIV_SECURITY)) {
+               DEBUG(10, ("create_file_unixpath: open on %s "
+                       "failed - SEC_FLAG_SYSTEM_SECURITY denied.\n",
+                       smb_fname_str_dbg(smb_fname)));
                status = NT_STATUS_PRIVILEGE_NOT_HELD;
                goto fail;
        }
-#endif
 
        if ((conn->fs_capabilities & FILE_NAMED_STREAMS)
            && is_ntfs_stream_smb_fname(smb_fname)
-           && (!(create_options & NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE))) {
+           && (!(private_flags & NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE))) {
                uint32 base_create_disposition;
                struct smb_filename *smb_fname_base = NULL;
 
@@ -3084,7 +3234,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                              | FILE_SHARE_WRITE
                                              | FILE_SHARE_DELETE,
                                              base_create_disposition,
-                                             0, 0, 0, 0, NULL, NULL,
+                                             0, 0, 0, 0, 0, NULL, NULL,
                                              &base_fsp, NULL);
                TALLOC_FREE(smb_fname_base);
 
@@ -3138,6 +3288,11 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                        goto fail;
                }
 
+               status = fsp_set_smb_fname(fsp, smb_fname);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto fail;
+               }
+
                /*
                 * We're opening the stream element of a base_fsp
                 * we already opened. Set up the base_fsp pointer.
@@ -3148,13 +3303,13 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
                status = open_file_ntcreate(conn,
                                            req,
-                                           smb_fname,
                                            access_mask,
                                            share_access,
                                            create_disposition,
                                            create_options,
                                            file_attributes,
                                            oplock_request,
+                                           private_flags,
                                            &info,
                                            fsp);
 
@@ -3222,10 +3377,10 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                security_acl_map_generic(sd->dacl, &file_generic_mapping);
                security_acl_map_generic(sd->sacl, &file_generic_mapping);
 
-               if (sec_info_sent & (OWNER_SECURITY_INFORMATION|
-                                       GROUP_SECURITY_INFORMATION|
-                                       DACL_SECURITY_INFORMATION|
-                                       SACL_SECURITY_INFORMATION)) {
+               if (sec_info_sent & (SECINFO_OWNER|
+                                       SECINFO_GROUP|
+                                       SECINFO_DACL|
+                                       SECINFO_SACL)) {
                        status = SMB_VFS_FSET_NT_ACL(fsp, sec_info_sent, sd);
                }
 
@@ -3238,7 +3393,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
        if ((ea_list != NULL) &&
            ((info == FILE_WAS_CREATED) || (info == FILE_WAS_OVERWRITTEN))) {
-               status = set_ea(conn, fsp, smb_fname, ea_list);
+               status = set_ea(conn, fsp, fsp->fsp_name, ea_list);
                if (!NT_STATUS_IS_OK(status)) {
                        goto fail;
                }
@@ -3309,7 +3464,8 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 NTSTATUS get_relative_fid_filename(connection_struct *conn,
                                   struct smb_request *req,
                                   uint16_t root_dir_fid,
-                                  struct smb_filename *smb_fname)
+                                  const struct smb_filename *smb_fname,
+                                  struct smb_filename **smb_fname_out)
 {
        files_struct *dir_fsp;
        char *parent_fname = NULL;
@@ -3397,19 +3553,27 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
                }
        }
 
-       new_base_name = talloc_asprintf(smb_fname, "%s%s", parent_fname,
+       new_base_name = talloc_asprintf(talloc_tos(), "%s%s", parent_fname,
                                        smb_fname->base_name);
        if (new_base_name == NULL) {
                status = NT_STATUS_NO_MEMORY;
                goto out;
        }
 
-       TALLOC_FREE(smb_fname->base_name);
-       smb_fname->base_name = new_base_name;
-       status = NT_STATUS_OK;
+       status = filename_convert(req,
+                               conn,
+                               req->flags2 & FLAGS2_DFS_PATHNAMES,
+                               new_base_name,
+                               0,
+                               NULL,
+                               smb_fname_out);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto out;
+       }
 
  out:
        TALLOC_FREE(parent_fname);
+       TALLOC_FREE(new_base_name);
        return status;
 }
 
@@ -3424,6 +3588,7 @@ NTSTATUS create_file_default(connection_struct *conn,
                             uint32_t file_attributes,
                             uint32_t oplock_request,
                             uint64_t allocation_size,
+                            uint32_t private_flags,
                             struct security_descriptor *sd,
                             struct ea_list *ea_list,
                             files_struct **result,
@@ -3432,11 +3597,13 @@ NTSTATUS create_file_default(connection_struct *conn,
        int info = FILE_WAS_OPENED;
        files_struct *fsp = NULL;
        NTSTATUS status;
+       bool stream_name = false;
 
        DEBUG(10,("create_file: access_mask = 0x%x "
                  "file_attributes = 0x%x, share_access = 0x%x, "
                  "create_disposition = 0x%x create_options = 0x%x "
                  "oplock_request = 0x%x "
+                 "private_flags = 0x%x "
                  "root_dir_fid = 0x%x, ea_list = 0x%p, sd = 0x%p, "
                  "fname = %s\n",
                  (unsigned int)access_mask,
@@ -3445,6 +3612,7 @@ NTSTATUS create_file_default(connection_struct *conn,
                  (unsigned int)create_disposition,
                  (unsigned int)create_options,
                  (unsigned int)oplock_request,
+                 (unsigned int)private_flags,
                  (unsigned int)root_dir_fid,
                  ea_list, sd, smb_fname_str_dbg(smb_fname)));
 
@@ -3453,18 +3621,21 @@ NTSTATUS create_file_default(connection_struct *conn,
         */
 
        if (root_dir_fid != 0) {
+               struct smb_filename *smb_fname_out = NULL;
                status = get_relative_fid_filename(conn, req, root_dir_fid,
-                                                  smb_fname);
+                                                  smb_fname, &smb_fname_out);
                if (!NT_STATUS_IS_OK(status)) {
                        goto fail;
                }
+               smb_fname = smb_fname_out;
        }
 
        /*
         * Check to see if this is a mac fork of some kind.
         */
 
-       if (is_ntfs_stream_smb_fname(smb_fname)) {
+       stream_name = is_ntfs_stream_smb_fname(smb_fname);
+       if (stream_name) {
                enum FAKE_FILE_TYPE fake_file_type;
 
                fake_file_type = is_fake_file(smb_fname);
@@ -3506,10 +3677,31 @@ NTSTATUS create_file_default(connection_struct *conn,
                goto fail;
        }
 
+       if (stream_name && is_ntfs_default_stream_smb_fname(smb_fname)) {
+               int ret;
+               smb_fname->stream_name = NULL;
+               /* We have to handle this error here. */
+               if (create_options & FILE_DIRECTORY_FILE) {
+                       status = NT_STATUS_NOT_A_DIRECTORY;
+                       goto fail;
+               }
+               if (lp_posix_pathnames()) {
+                       ret = SMB_VFS_LSTAT(conn, smb_fname);
+               } else {
+                       ret = SMB_VFS_STAT(conn, smb_fname);
+               }
+
+               if (ret == 0 && VALID_STAT_OF_DIR(smb_fname->st)) {
+                       status = NT_STATUS_FILE_IS_A_DIRECTORY;
+                       goto fail;
+               }
+       }
+
        status = create_file_unixpath(
                conn, req, smb_fname, access_mask, share_access,
                create_disposition, create_options, file_attributes,
-               oplock_request, allocation_size, sd, ea_list,
+               oplock_request, allocation_size, private_flags,
+               sd, ea_list,
                &fsp, &info);
 
        if (!NT_STATUS_IS_OK(status)) {