Check for WRITE_ACCESS on the file before overriding an EACCESS.
[samba.git] / source3 / smbd / dosmode.c
index e9e92ada20e5d6964c2f804be61d7f56b6c0b2d7..3152631f65b607568b90048f09e98f44b8364a3b 100644 (file)
 */
 
 #include "includes.h"
+#include "system/filesys.h"
+#include "librpc/gen_ndr/ndr_xattr.h"
+#include "../libcli/security/security.h"
+#include "smbd/smbd.h"
+#include "lib/param/loadparm.h"
 
-static int set_sparse_flag(const SMB_STRUCT_STAT * const sbuf)
+static uint32_t filter_mode_by_protocol(uint32_t mode)
 {
-#if defined (HAVE_STAT_ST_BLOCKS) && defined(STAT_ST_BLOCKSIZE)
-       if (sbuf->st_ex_size > sbuf->st_ex_blocks * (SMB_OFF_T)STAT_ST_BLOCKSIZE) {
-               return FILE_ATTRIBUTE_SPARSE;
+       if (get_Protocol() <= PROTOCOL_LANMAN2) {
+               DEBUG(10,("filter_mode_by_protocol: "
+                       "filtering result 0x%x to 0x%x\n",
+                       (unsigned int)mode,
+                       (unsigned int)(mode & 0x3f) ));
+               mode &= 0x3f;
        }
-#endif
-       return 0;
+       return mode;
 }
 
 static int set_link_read_only_flag(const SMB_STRUCT_STAT *const sbuf)
@@ -35,7 +42,7 @@ static int set_link_read_only_flag(const SMB_STRUCT_STAT *const sbuf)
 #ifdef S_ISLNK
 #if LINKS_READ_ONLY
        if (S_ISLNK(sbuf->st_mode) && S_ISDIR(sbuf->st_mode))
-               return aRONLY;
+               return FILE_ATTRIBUTE_READONLY;
 #endif
 #endif
        return 0;
@@ -164,40 +171,45 @@ static uint32 dos_mode_from_sbuf(connection_struct *conn,
        int result = 0;
        enum mapreadonly_options ro_opts = (enum mapreadonly_options)lp_map_readonly(SNUM(conn));
 
+#if defined(UF_IMMUTABLE) && defined(SF_IMMUTABLE)
+       /* if we can find out if a file is immutable we should report it r/o */
+       if (smb_fname->st.st_ex_flags & (UF_IMMUTABLE | SF_IMMUTABLE)) {
+               result |= FILE_ATTRIBUTE_READONLY;
+       }
+#endif
        if (ro_opts == MAP_READONLY_YES) {
                /* Original Samba method - map inverse of user "w" bit. */
                if ((smb_fname->st.st_ex_mode & S_IWUSR) == 0) {
-                       result |= aRONLY;
+                       result |= FILE_ATTRIBUTE_READONLY;
                }
        } else if (ro_opts == MAP_READONLY_PERMISSIONS) {
                /* Check actual permissions for read-only. */
                if (!can_write_to_file(conn, smb_fname)) {
-                       result |= aRONLY;
+                       result |= FILE_ATTRIBUTE_READONLY;
                }
        } /* Else never set the readonly bit. */
 
        if (MAP_ARCHIVE(conn) && ((smb_fname->st.st_ex_mode & S_IXUSR) != 0))
-               result |= aARCH;
+               result |= FILE_ATTRIBUTE_ARCHIVE;
 
        if (MAP_SYSTEM(conn) && ((smb_fname->st.st_ex_mode & S_IXGRP) != 0))
-               result |= aSYSTEM;
+               result |= FILE_ATTRIBUTE_SYSTEM;
 
        if (MAP_HIDDEN(conn) && ((smb_fname->st.st_ex_mode & S_IXOTH) != 0))
-               result |= aHIDDEN;   
+               result |= FILE_ATTRIBUTE_HIDDEN;
 
        if (S_ISDIR(smb_fname->st.st_ex_mode))
-               result = aDIR | (result & aRONLY);
+               result = FILE_ATTRIBUTE_DIRECTORY | (result & FILE_ATTRIBUTE_READONLY);
 
-       result |= set_sparse_flag(&smb_fname->st);
        result |= set_link_read_only_flag(&smb_fname->st);
 
        DEBUG(8,("dos_mode_from_sbuf returning "));
 
-       if (result & aHIDDEN) DEBUG(8, ("h"));
-       if (result & aRONLY ) DEBUG(8, ("r"));
-       if (result & aSYSTEM) DEBUG(8, ("s"));
-       if (result & aDIR   ) DEBUG(8, ("d"));
-       if (result & aARCH  ) DEBUG(8, ("a"));
+       if (result & FILE_ATTRIBUTE_HIDDEN) DEBUG(8, ("h"));
+       if (result & FILE_ATTRIBUTE_READONLY ) DEBUG(8, ("r"));
+       if (result & FILE_ATTRIBUTE_SYSTEM) DEBUG(8, ("s"));
+       if (result & FILE_ATTRIBUTE_DIRECTORY   ) DEBUG(8, ("d"));
+       if (result & FILE_ATTRIBUTE_ARCHIVE  ) DEBUG(8, ("a"));
 
        DEBUG(8,("\n"));
        return result;
@@ -205,15 +217,19 @@ static uint32 dos_mode_from_sbuf(connection_struct *conn,
 
 /****************************************************************************
  Get DOS attributes from an EA.
+ This can also pull the create time into the stat struct inside smb_fname.
 ****************************************************************************/
 
 static bool get_ea_dos_attribute(connection_struct *conn,
-                                const struct smb_filename *smb_fname,
+                                struct smb_filename *smb_fname,
                                 uint32 *pattr)
 {
+       struct xattr_DOSATTRIB dosattrib;
+       enum ndr_err_code ndr_err;
+       DATA_BLOB blob;
        ssize_t sizeret;
        fstring attrstr;
-       unsigned int dosattr;
+       uint32_t dosattr;
 
        if (!lp_store_dos_attributes(SNUM(conn))) {
                return False;
@@ -232,7 +248,7 @@ static bool get_ea_dos_attribute(connection_struct *conn,
 #else
                                ) {
 #endif
-                       DEBUG(1,("get_ea_dos_attributes: Cannot get attribute "
+                       DEBUG(1,("get_ea_dos_attribute: Cannot get attribute "
                                 "from EA on file %s: Error = %s\n",
                                 smb_fname_str_dbg(smb_fname),
                                 strerror(errno)));
@@ -240,31 +256,87 @@ static bool get_ea_dos_attribute(connection_struct *conn,
                }
                return False;
        }
-       /* Null terminate string. */
-       attrstr[sizeret] = 0;
-       DEBUG(10,("get_ea_dos_attribute: %s attrstr = %s\n",
-                 smb_fname_str_dbg(smb_fname), attrstr));
 
-       if (sizeret < 2 || attrstr[0] != '0' || attrstr[1] != 'x' ||
-                       sscanf(attrstr, "%x", &dosattr) != 1) {
-               DEBUG(1,("get_ea_dos_attributes: Badly formed DOSATTRIB on "
-                        "file %s - %s\n", smb_fname_str_dbg(smb_fname),
-                        attrstr));
-                return False;
-        }
+       blob.data = (uint8_t *)attrstr;
+       blob.length = sizeret;
+
+       ndr_err = ndr_pull_struct_blob(&blob, talloc_tos(), &dosattrib,
+                       (ndr_pull_flags_fn_t)ndr_pull_xattr_DOSATTRIB);
+
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               DEBUG(1,("get_ea_dos_attribute: bad ndr decode "
+                        "from EA on file %s: Error = %s\n",
+                        smb_fname_str_dbg(smb_fname),
+                        ndr_errstr(ndr_err)));
+               return false;
+       }
+
+       DEBUG(10,("get_ea_dos_attribute: %s attr = %s\n",
+                 smb_fname_str_dbg(smb_fname), dosattrib.attrib_hex));
+
+       switch (dosattrib.version) {
+               case 0xFFFF:
+                       dosattr = dosattrib.info.compatinfoFFFF.attrib;
+                       break;
+               case 1:
+                       dosattr = dosattrib.info.info1.attrib;
+                       if (!null_nttime(dosattrib.info.info1.create_time)) {
+                               struct timespec create_time =
+                                       nt_time_to_unix_timespec(
+                                               &dosattrib.info.info1.create_time);
+
+                               update_stat_ex_create_time(&smb_fname->st,
+                                                       create_time);
+
+                               DEBUG(10,("get_ea_dos_attribute: file %s case 1 "
+                                       "set btime %s\n",
+                                       smb_fname_str_dbg(smb_fname),
+                                       time_to_asc(convert_timespec_to_time_t(
+                                               create_time)) ));
+                       }
+                       break;
+               case 2:
+                       dosattr = dosattrib.info.oldinfo2.attrib;
+                       /* Don't know what flags to check for this case. */
+                       break;
+               case 3:
+                       dosattr = dosattrib.info.info3.attrib;
+                       if ((dosattrib.info.info3.valid_flags & XATTR_DOSINFO_CREATE_TIME) &&
+                                       !null_nttime(dosattrib.info.info3.create_time)) {
+                               struct timespec create_time =
+                                       nt_time_to_unix_timespec(
+                                               &dosattrib.info.info3.create_time);
+
+                               update_stat_ex_create_time(&smb_fname->st,
+                                                       create_time);
+
+                               DEBUG(10,("get_ea_dos_attribute: file %s case 3 "
+                                       "set btime %s\n",
+                                       smb_fname_str_dbg(smb_fname),
+                                       time_to_asc(convert_timespec_to_time_t(
+                                               create_time)) ));
+                       }
+                       break;
+               default:
+                       DEBUG(1,("get_ea_dos_attribute: Badly formed DOSATTRIB on "
+                                "file %s - %s\n", smb_fname_str_dbg(smb_fname),
+                                attrstr));
+                       return false;
+       }
 
        if (S_ISDIR(smb_fname->st.st_ex_mode)) {
-               dosattr |= aDIR;
+               dosattr |= FILE_ATTRIBUTE_DIRECTORY;
        }
-       *pattr = (uint32)(dosattr & SAMBA_ATTRIBUTES_MASK);
+       /* FILE_ATTRIBUTE_SPARSE is valid on get but not on set. */
+       *pattr = (uint32)(dosattr & (SAMBA_ATTRIBUTES_MASK|FILE_ATTRIBUTE_SPARSE));
 
        DEBUG(8,("get_ea_dos_attribute returning (0x%x)", dosattr));
 
-       if (dosattr & aHIDDEN) DEBUG(8, ("h"));
-       if (dosattr & aRONLY ) DEBUG(8, ("r"));
-       if (dosattr & aSYSTEM) DEBUG(8, ("s"));
-       if (dosattr & aDIR   ) DEBUG(8, ("d"));
-       if (dosattr & aARCH  ) DEBUG(8, ("a"));
+       if (dosattr & FILE_ATTRIBUTE_HIDDEN) DEBUG(8, ("h"));
+       if (dosattr & FILE_ATTRIBUTE_READONLY ) DEBUG(8, ("r"));
+       if (dosattr & FILE_ATTRIBUTE_SYSTEM) DEBUG(8, ("s"));
+       if (dosattr & FILE_ATTRIBUTE_DIRECTORY   ) DEBUG(8, ("d"));
+       if (dosattr & FILE_ATTRIBUTE_ARCHIVE  ) DEBUG(8, ("a"));
 
        DEBUG(8,("\n"));
 
@@ -273,24 +345,56 @@ static bool get_ea_dos_attribute(connection_struct *conn,
 
 /****************************************************************************
  Set DOS attributes in an EA.
+ Also sets the create time.
 ****************************************************************************/
 
 static bool set_ea_dos_attribute(connection_struct *conn,
                                 struct smb_filename *smb_fname,
                                 uint32 dosmode)
 {
-       fstring attrstr;
-       files_struct *fsp = NULL;
-       bool ret = False;
+       struct xattr_DOSATTRIB dosattrib;
+       enum ndr_err_code ndr_err;
+       DATA_BLOB blob;
 
        if (!lp_store_dos_attributes(SNUM(conn))) {
                return False;
        }
 
-       snprintf(attrstr, sizeof(attrstr)-1, "0x%x", dosmode & SAMBA_ATTRIBUTES_MASK);
+       ZERO_STRUCT(dosattrib);
+       ZERO_STRUCT(blob);
+
+       dosattrib.version = 3;
+       dosattrib.info.info3.valid_flags = XATTR_DOSINFO_ATTRIB|
+                                       XATTR_DOSINFO_CREATE_TIME;
+       dosattrib.info.info3.attrib = dosmode;
+       unix_timespec_to_nt_time(&dosattrib.info.info3.create_time,
+                               smb_fname->st.st_ex_btime);
+
+       DEBUG(10,("set_ea_dos_attributes: set attribute 0x%x, btime = %s on file %s\n",
+               (unsigned int)dosmode,
+               time_to_asc(convert_timespec_to_time_t(smb_fname->st.st_ex_btime)),
+               smb_fname_str_dbg(smb_fname) ));
+
+       ndr_err = ndr_push_struct_blob(
+                       &blob, talloc_tos(), &dosattrib,
+                       (ndr_push_flags_fn_t)ndr_push_xattr_DOSATTRIB);
+
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               DEBUG(5, ("create_acl_blob: ndr_push_xattr_DOSATTRIB failed: %s\n",
+                       ndr_errstr(ndr_err)));
+               return false;
+       }
+
+       if (blob.data == NULL || blob.length == 0) {
+               return false;
+       }
+
        if (SMB_VFS_SETXATTR(conn, smb_fname->base_name,
-                            SAMBA_XATTR_DOS_ATTRIB, attrstr, strlen(attrstr),
+                            SAMBA_XATTR_DOS_ATTRIB, blob.data, blob.length,
                             0) == -1) {
+               bool ret = false;
+               files_struct *fsp = NULL;
+
                if((errno != EPERM) && (errno != EACCES)) {
                        if (errno == ENOSYS
 #if defined(ENOTSUP)
@@ -304,7 +408,7 @@ static bool set_ea_dos_attribute(connection_struct *conn,
                                         strerror(errno) ));
                                set_store_dos_attributes(SNUM(conn), False);
                        }
-                       return False;
+                       return false;
                }
 
                /* We want DOS semantics, ie allow non owner with write permission to change the
@@ -313,7 +417,11 @@ static bool set_ea_dos_attribute(connection_struct *conn,
 
                /* Check if we have write access. */
                if(!CAN_WRITE(conn) || !lp_dos_filemode(SNUM(conn)))
-                       return False;
+                       return false;
+
+               if (!can_write_to_file(conn, smb_fname)) {
+                       return false;
+               }
 
                /*
                 * We need to open the file with write access whilst
@@ -321,22 +429,23 @@ static bool set_ea_dos_attribute(connection_struct *conn,
                 * are not violating security in doing the setxattr.
                 */
 
-               if (!NT_STATUS_IS_OK(open_file_fchmod(NULL, conn, smb_fname,
+               if (!NT_STATUS_IS_OK(open_file_fchmod(conn, smb_fname,
                                                      &fsp)))
-                       return ret;
+                       return false;
                become_root();
-               if (SMB_VFS_SETXATTR(conn, smb_fname->base_name,
-                                    SAMBA_XATTR_DOS_ATTRIB, attrstr,
-                                    strlen(attrstr), 0) == 0) {
-                       ret = True;
+               if (SMB_VFS_FSETXATTR(fsp,
+                                    SAMBA_XATTR_DOS_ATTRIB, blob.data,
+                                    blob.length, 0) == 0) {
+                       ret = true;
                }
                unbecome_root();
-               close_file_fchmod(NULL, fsp);
+               close_file(NULL, fsp, NORMAL_CLOSE);
                return ret;
        }
-       DEBUG(10,("set_ea_dos_attribute: set EA %s on file %s\n", attrstr,
-                 smb_fname_str_dbg(smb_fname)));
-       return True;
+       DEBUG(10,("set_ea_dos_attribute: set EA 0x%x on file %s\n",
+               (unsigned int)dosmode,
+               smb_fname_str_dbg(smb_fname)));
+       return true;
 }
 
 /****************************************************************************
@@ -367,7 +476,7 @@ uint32 dos_mode_msdfs(connection_struct *conn,
                /* Only . and .. are not hidden. */
                if (p[0] == '.' && !((p[1] == '\0') ||
                                (p[1] == '.' && p[2] == '\0'))) {
-                       result |= aHIDDEN;
+                       result |= FILE_ATTRIBUTE_HIDDEN;
                }
        }
 
@@ -375,18 +484,24 @@ uint32 dos_mode_msdfs(connection_struct *conn,
 
        /* Optimization : Only call is_hidden_path if it's not already
           hidden. */
-       if (!(result & aHIDDEN) &&
+       if (!(result & FILE_ATTRIBUTE_HIDDEN) &&
            IS_HIDDEN_PATH(conn, smb_fname->base_name)) {
-               result |= aHIDDEN;
+               result |= FILE_ATTRIBUTE_HIDDEN;
        }
 
+       if (result == 0) {
+               result = FILE_ATTRIBUTE_NORMAL;
+       }
+
+       result = filter_mode_by_protocol(result);
+
        DEBUG(8,("dos_mode_msdfs returning "));
 
-       if (result & aHIDDEN) DEBUG(8, ("h"));
-       if (result & aRONLY ) DEBUG(8, ("r"));
-       if (result & aSYSTEM) DEBUG(8, ("s"));
-       if (result & aDIR   ) DEBUG(8, ("d"));
-       if (result & aARCH  ) DEBUG(8, ("a"));
+       if (result & FILE_ATTRIBUTE_HIDDEN) DEBUG(8, ("h"));
+       if (result & FILE_ATTRIBUTE_READONLY ) DEBUG(8, ("r"));
+       if (result & FILE_ATTRIBUTE_SYSTEM) DEBUG(8, ("s"));
+       if (result & FILE_ATTRIBUTE_DIRECTORY   ) DEBUG(8, ("d"));
+       if (result & FILE_ATTRIBUTE_ARCHIVE  ) DEBUG(8, ("a"));
        if (result & FILE_ATTRIBUTE_SPARSE ) DEBUG(8, ("[sparse]"));
 
        DEBUG(8,("\n"));
@@ -403,13 +518,13 @@ int dos_attributes_to_stat_dos_flags(uint32_t dosmode)
 {
        uint32_t dos_stat_flags = 0;
 
-       if (dosmode & aARCH)
+       if (dosmode & FILE_ATTRIBUTE_ARCHIVE)
                dos_stat_flags |= UF_DOS_ARCHIVE;
-       if (dosmode & aHIDDEN)
+       if (dosmode & FILE_ATTRIBUTE_HIDDEN)
                dos_stat_flags |= UF_DOS_HIDDEN;
-       if (dosmode & aRONLY)
+       if (dosmode & FILE_ATTRIBUTE_READONLY)
                dos_stat_flags |= UF_DOS_RO;
-       if (dosmode & aSYSTEM)
+       if (dosmode & FILE_ATTRIBUTE_SYSTEM)
                dos_stat_flags |= UF_DOS_SYSTEM;
        if (dosmode & FILE_ATTRIBUTE_NONINDEXED)
                dos_stat_flags |= UF_DOS_NOINDEX;
@@ -436,19 +551,20 @@ static bool get_stat_dos_flags(connection_struct *conn,
                  smb_fname_str_dbg(smb_fname)));
 
        if (smb_fname->st.st_ex_flags & UF_DOS_ARCHIVE)
-               *dosmode |= aARCH;
+               *dosmode |= FILE_ATTRIBUTE_ARCHIVE;
        if (smb_fname->st.st_ex_flags & UF_DOS_HIDDEN)
-               *dosmode |= aHIDDEN;
+               *dosmode |= FILE_ATTRIBUTE_HIDDEN;
        if (smb_fname->st.st_ex_flags & UF_DOS_RO)
-               *dosmode |= aRONLY;
+               *dosmode |= FILE_ATTRIBUTE_READONLY;
        if (smb_fname->st.st_ex_flags & UF_DOS_SYSTEM)
-               *dosmode |= aSYSTEM;
+               *dosmode |= FILE_ATTRIBUTE_SYSTEM;
        if (smb_fname->st.st_ex_flags & UF_DOS_NOINDEX)
                *dosmode |= FILE_ATTRIBUTE_NONINDEXED;
+       if (smb_fname->st.st_ex_flags & FILE_ATTRIBUTE_SPARSE)
+               *dosmode |= FILE_ATTRIBUTE_SPARSE;
        if (S_ISDIR(smb_fname->st.st_ex_mode))
-               *dosmode |= aDIR;
+               *dosmode |= FILE_ATTRIBUTE_DIRECTORY;
 
-       *dosmode |= set_sparse_flag(&smb_fname->st);
        *dosmode |= set_link_read_only_flag(&smb_fname->st);
 
        return true;
@@ -504,11 +620,12 @@ static bool set_stat_dos_flags(connection_struct *conn,
 
 /****************************************************************************
  Change a unix mode to a dos mode.
+ May also read the create timespec into the stat struct in smb_fname
+ if "store dos attributes" is true.
 ****************************************************************************/
 
-uint32 dos_mode(connection_struct *conn, const struct smb_filename *smb_fname)
+uint32 dos_mode(connection_struct *conn, struct smb_filename *smb_fname)
 {
-       SMB_STRUCT_STAT sbuf;
        uint32 result = 0;
        bool offline, used_stat_dos_flags = false;
 
@@ -531,7 +648,7 @@ uint32 dos_mode(connection_struct *conn, const struct smb_filename *smb_fname)
                /* Only . and .. are not hidden. */
                if (p[0] == '.' && !((p[1] == '\0') ||
                                (p[1] == '.' && p[2] == '\0'))) {
-                       result |= aHIDDEN;
+                       result |= FILE_ATTRIBUTE_HIDDEN;
                }
        }
 
@@ -540,33 +657,36 @@ uint32 dos_mode(connection_struct *conn, const struct smb_filename *smb_fname)
 #endif
        if (!used_stat_dos_flags) {
                /* Get the DOS attributes from an EA by preference. */
-               if (get_ea_dos_attribute(conn, smb_fname, &result)) {
-                       result |= set_sparse_flag(&smb_fname->st);
-               } else {
+               if (!get_ea_dos_attribute(conn, smb_fname, &result)) {
                        result |= dos_mode_from_sbuf(conn, smb_fname);
                }
        }
 
-       sbuf = smb_fname->st;
-       offline = SMB_VFS_IS_OFFLINE(conn, smb_fname->base_name, &sbuf);
-       if (S_ISREG(sbuf.st_ex_mode) && offline) {
+       offline = SMB_VFS_IS_OFFLINE(conn, smb_fname, &smb_fname->st);
+       if (S_ISREG(smb_fname->st.st_ex_mode) && offline) {
                result |= FILE_ATTRIBUTE_OFFLINE;
        }
 
        /* Optimization : Only call is_hidden_path if it's not already
           hidden. */
-       if (!(result & aHIDDEN) &&
+       if (!(result & FILE_ATTRIBUTE_HIDDEN) &&
            IS_HIDDEN_PATH(conn, smb_fname->base_name)) {
-               result |= aHIDDEN;
+               result |= FILE_ATTRIBUTE_HIDDEN;
        }
 
+       if (result == 0) {
+               result = FILE_ATTRIBUTE_NORMAL;
+       }
+
+       result = filter_mode_by_protocol(result);
+
        DEBUG(8,("dos_mode returning "));
 
-       if (result & aHIDDEN) DEBUG(8, ("h"));
-       if (result & aRONLY ) DEBUG(8, ("r"));
-       if (result & aSYSTEM) DEBUG(8, ("s"));
-       if (result & aDIR   ) DEBUG(8, ("d"));
-       if (result & aARCH  ) DEBUG(8, ("a"));
+       if (result & FILE_ATTRIBUTE_HIDDEN) DEBUG(8, ("h"));
+       if (result & FILE_ATTRIBUTE_READONLY ) DEBUG(8, ("r"));
+       if (result & FILE_ATTRIBUTE_SYSTEM) DEBUG(8, ("s"));
+       if (result & FILE_ATTRIBUTE_DIRECTORY   ) DEBUG(8, ("d"));
+       if (result & FILE_ATTRIBUTE_ARCHIVE  ) DEBUG(8, ("a"));
        if (result & FILE_ATTRIBUTE_SPARSE ) DEBUG(8, ("[sparse]"));
 
        DEBUG(8,("\n"));
@@ -576,6 +696,9 @@ uint32 dos_mode(connection_struct *conn, const struct smb_filename *smb_fname)
 
 /*******************************************************************
  chmod a file - but preserve some bits.
+ If "store dos attributes" is also set it will store the create time
+ from the stat struct in smb_fname (in NTTIME format) in the EA
+ attribute also.
 ********************************************************************/
 
 int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
@@ -586,6 +709,13 @@ int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
        mode_t unixmode;
        int ret = -1, lret = -1;
        uint32_t old_mode;
+       struct timespec new_create_timespec;
+       files_struct *fsp = NULL;
+
+       if (!CAN_WRITE(conn)) {
+               errno = EROFS;
+               return -1;
+       }
 
        /* We only allow READONLY|HIDDEN|SYSTEM|DIRECTORY|ARCHIVE here. */
        dosmode &= (SAMBA_ATTRIBUTES_MASK | FILE_ATTRIBUTE_OFFLINE);
@@ -593,26 +723,23 @@ int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
        DEBUG(10,("file_set_dosmode: setting dos mode 0x%x on file %s\n",
                  dosmode, smb_fname_str_dbg(smb_fname)));
 
-       if (!VALID_STAT(smb_fname->st)) {
-               if (SMB_VFS_STAT(conn, smb_fname))
-                       return(-1);
-       }
-
        unixmode = smb_fname->st.st_ex_mode;
 
        get_acl_group_bits(conn, smb_fname->base_name,
                           &smb_fname->st.st_ex_mode);
 
        if (S_ISDIR(smb_fname->st.st_ex_mode))
-               dosmode |= aDIR;
+               dosmode |= FILE_ATTRIBUTE_DIRECTORY;
        else
-               dosmode &= ~aDIR;
+               dosmode &= ~FILE_ATTRIBUTE_DIRECTORY;
+
+       new_create_timespec = smb_fname->st.st_ex_btime;
 
        old_mode = dos_mode(conn, smb_fname);
 
        if (dosmode & FILE_ATTRIBUTE_OFFLINE) {
                if (!(old_mode & FILE_ATTRIBUTE_OFFLINE)) {
-                       lret = SMB_VFS_SET_OFFLINE(conn, smb_fname->base_name);
+                       lret = SMB_VFS_SET_OFFLINE(conn, smb_fname);
                        if (lret == -1) {
                                DEBUG(0, ("set_dos_mode: client has asked to "
                                          "set FILE_ATTRIBUTE_OFFLINE to "
@@ -627,10 +754,7 @@ int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
        dosmode  &= ~FILE_ATTRIBUTE_OFFLINE;
        old_mode &= ~FILE_ATTRIBUTE_OFFLINE;
 
-       if (old_mode == dosmode) {
-               smb_fname->st.st_ex_mode = unixmode;
-               return(0);
-       }
+       smb_fname->st.st_ex_btime = new_create_timespec;
 
 #ifdef HAVE_STAT_DOS_FLAGS
        {
@@ -692,6 +816,27 @@ int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
                unixmode |= (smb_fname->st.st_ex_mode & (S_IWUSR|S_IWGRP|S_IWOTH));
        }
 
+       /*
+        * From the chmod 2 man page:
+        *
+        * "If the calling process is not privileged, and the group of the file
+        * does not match the effective group ID of the process or one of its
+        * supplementary group IDs, the S_ISGID bit will be turned off, but
+        * this will not cause an error to be returned."
+        *
+        * Simply refuse to do the chmod in this case.
+        */
+
+       if (S_ISDIR(smb_fname->st.st_ex_mode) && (unixmode & S_ISGID) &&
+                       geteuid() != sec_initial_uid() &&
+                       !current_user_in_group(conn, smb_fname->st.st_ex_gid)) {
+               DEBUG(3,("file_set_dosmode: setgid bit cannot be "
+                       "set for directory %s\n",
+                       smb_fname_str_dbg(smb_fname)));
+               errno = EPERM;
+               return -1;
+       }
+
        ret = SMB_VFS_CHMOD(conn, smb_fname->base_name, unixmode);
        if (ret == 0) {
                if(!newfile || (lret != -1)) {
@@ -713,37 +858,103 @@ int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
                bits on a file. Just like file_ntimes below.
        */
 
-       /* Check if we have write access. */
-       if (CAN_WRITE(conn)) {
-               /*
-                * We need to open the file with write access whilst
-                * still in our current user context. This ensures we
-                * are not violating security in doing the fchmod.
-                * This file open does *not* break any oplocks we are
-                * holding. We need to review this.... may need to
-                * break batch oplocks open by others. JRA.
-                */
-               files_struct *fsp;
-               if (!NT_STATUS_IS_OK(open_file_fchmod(NULL, conn, smb_fname,
-                                    &fsp)))
-                       return -1;
-               become_root();
-               ret = SMB_VFS_FCHMOD(fsp, unixmode);
-               unbecome_root();
-               close_file_fchmod(NULL, fsp);
-               if (!newfile) {
-                       notify_fname(conn, NOTIFY_ACTION_MODIFIED,
-                                    FILE_NOTIFY_CHANGE_ATTRIBUTES,
-                                    smb_fname->base_name);
-               }
-               if (ret == 0) {
-                       smb_fname->st.st_ex_mode = unixmode;
-               }
+       if (!can_write_to_file(conn, smb_fname)) {
+               errno = EACCES;
+               return -1;
+       }
+
+       /*
+        * We need to open the file with write access whilst
+        * still in our current user context. This ensures we
+        * are not violating security in doing the fchmod.
+        */
+       if (!NT_STATUS_IS_OK(open_file_fchmod(conn, smb_fname,
+                            &fsp)))
+               return -1;
+       become_root();
+       ret = SMB_VFS_FCHMOD(fsp, unixmode);
+       unbecome_root();
+       close_file(NULL, fsp, NORMAL_CLOSE);
+       if (!newfile) {
+               notify_fname(conn, NOTIFY_ACTION_MODIFIED,
+                            FILE_NOTIFY_CHANGE_ATTRIBUTES,
+                            smb_fname->base_name);
+       }
+       if (ret == 0) {
+               smb_fname->st.st_ex_mode = unixmode;
        }
 
        return( ret );
 }
 
+
+NTSTATUS file_set_sparse(connection_struct *conn,
+                        files_struct *fsp,
+                        bool sparse)
+{
+       uint32_t old_dosmode;
+       uint32_t new_dosmode;
+       NTSTATUS status;
+
+       if (!CAN_WRITE(conn)) {
+               DEBUG(9,("file_set_sparse: fname[%s] set[%u] "
+                       "on readonly share[%s]\n",
+                       smb_fname_str_dbg(fsp->fsp_name),
+                       sparse,
+                       lp_servicename(talloc_tos(), SNUM(conn))));
+               return NT_STATUS_MEDIA_WRITE_PROTECTED;
+       }
+
+       if (!(fsp->access_mask & FILE_WRITE_DATA) &&
+                       !(fsp->access_mask & FILE_WRITE_ATTRIBUTES)) {
+               DEBUG(9,("file_set_sparse: fname[%s] set[%u] "
+                       "access_mask[0x%08X] - access denied\n",
+                       smb_fname_str_dbg(fsp->fsp_name),
+                       sparse,
+                       fsp->access_mask));
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       DEBUG(10,("file_set_sparse: setting sparse bit %u on file %s\n",
+                 sparse, smb_fname_str_dbg(fsp->fsp_name)));
+
+       if (!lp_store_dos_attributes(SNUM(conn))) {
+               return NT_STATUS_INVALID_DEVICE_REQUEST;
+       }
+
+       status = vfs_stat_fsp(fsp);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       old_dosmode = dos_mode(conn, fsp->fsp_name);
+
+       if (sparse && !(old_dosmode & FILE_ATTRIBUTE_SPARSE)) {
+               new_dosmode = old_dosmode | FILE_ATTRIBUTE_SPARSE;
+       } else if (!sparse && (old_dosmode & FILE_ATTRIBUTE_SPARSE)) {
+               new_dosmode = old_dosmode & ~FILE_ATTRIBUTE_SPARSE;
+       } else {
+               return NT_STATUS_OK;
+       }
+
+       /* Store the DOS attributes in an EA. */
+       if (!set_ea_dos_attribute(conn, fsp->fsp_name,
+                                 new_dosmode)) {
+               if (errno == 0) {
+                       errno = EIO;
+               }
+               return map_nt_error_from_unix(errno);
+       }
+
+       notify_fname(conn, NOTIFY_ACTION_MODIFIED,
+                    FILE_NOTIFY_CHANGE_ATTRIBUTES,
+                    fsp->fsp_name->base_name);
+
+       fsp->is_sparse = sparse;
+
+       return NT_STATUS_OK;
+}
+
 /*******************************************************************
  Wrapper around the VFS ntimes that possibly allows DOS semantics rather
  than POSIX.
@@ -830,118 +1041,66 @@ bool set_sticky_write_time_path(struct file_id fileid, struct timespec mtime)
 
 bool set_sticky_write_time_fsp(struct files_struct *fsp, struct timespec mtime)
 {
+       if (null_timespec(mtime)) {
+               return true;
+       }
+
        fsp->write_time_forced = true;
        TALLOC_FREE(fsp->update_write_time_event);
 
        return set_sticky_write_time_path(fsp->file_id, mtime);
 }
 
-/******************************************************************
- Update a write time immediately, without the 2 second delay.
-******************************************************************/
-
-bool update_write_time(struct files_struct *fsp)
-{
-       if (!set_write_time(fsp->file_id, timespec_current())) {
-               return false;
-       }
-
-       notify_fname(fsp->conn, NOTIFY_ACTION_MODIFIED,
-                    FILE_NOTIFY_CHANGE_LAST_WRITE, fsp->fsp_name->base_name);
-
-       return true;
-}
-
 /******************************************************************
  Set a create time EA.
 ******************************************************************/
 
 NTSTATUS set_create_timespec_ea(connection_struct *conn,
-                               struct files_struct *fsp,
-                                const struct smb_filename *smb_fname,
+                               const struct smb_filename *psmb_fname,
                                struct timespec create_time)
 {
+       NTSTATUS status;
+       struct smb_filename *smb_fname = NULL;
+       uint32_t dosmode;
        int ret;
-       char buf[8];
 
-       if (!lp_store_create_time(SNUM(conn))) {
+       if (!lp_store_dos_attributes(SNUM(conn))) {
                return NT_STATUS_OK;
        }
 
-       put_long_date_timespec(buf, create_time);
-       if (fsp && fsp->fh->fd != -1) {
-               ret = SMB_VFS_FSETXATTR(fsp,
-                               SAMBA_XATTR_DOSTIMESTAMPS,
-                               buf,
-                               sizeof(buf),
-                               0);
-       } else {
-               ret = SMB_VFS_SETXATTR(conn,
-                               smb_fname->base_name,
-                               SAMBA_XATTR_DOSTIMESTAMPS,
-                               buf,
-                               sizeof(buf),
-                               0);
-       }
+       status = create_synthetic_smb_fname(talloc_tos(),
+                               psmb_fname->base_name,
+                               NULL, &psmb_fname->st,
+                               &smb_fname);
 
-       if (ret == -1) {
-               map_nt_error_from_unix(errno);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
-       return NT_STATUS_OK;
-}
 
-/******************************************************************
- Returns an EA create timespec, or a zero timespec if fail.
-******************************************************************/
+       dosmode = dos_mode(conn, smb_fname);
 
-static struct timespec get_create_timespec_ea(connection_struct *conn,
-                                struct files_struct *fsp,
-                                const struct smb_filename *smb_fname)
-{
-       ssize_t ret;
-       char buf[8];
-       struct timespec ts;
-
-       ZERO_STRUCT(ts);
+       smb_fname->st.st_ex_btime = create_time;
 
-       if (!lp_store_create_time(SNUM(conn))) {
-               return ts;
+       ret = file_set_dosmode(conn, smb_fname, dosmode, NULL, false);
+       if (ret == -1) {
+               map_nt_error_from_unix(errno);
        }
 
-       if (fsp && fsp->fh->fd != -1) {
-               ret = SMB_VFS_FGETXATTR(fsp,
-                               SAMBA_XATTR_DOSTIMESTAMPS,
-                               buf,
-                               sizeof(buf));
-       } else {
-               ret = SMB_VFS_GETXATTR(conn,
-                               smb_fname->base_name,
-                               SAMBA_XATTR_DOSTIMESTAMPS,
-                               buf,
-                               sizeof(buf));
-       }
-       if (ret == sizeof(buf)) {
-               return interpret_long_date(buf);
-       } else {
-               return ts;
-       }
+       DEBUG(10,("set_create_timespec_ea: wrote create time EA for file %s\n",
+               smb_fname_str_dbg(smb_fname)));
+
+       return NT_STATUS_OK;
 }
 
 /******************************************************************
- Return a create time - looks at EA.
+ Return a create time.
 ******************************************************************/
 
 struct timespec get_create_timespec(connection_struct *conn,
                                struct files_struct *fsp,
                                const struct smb_filename *smb_fname)
 {
-       struct timespec ts = get_create_timespec_ea(conn, fsp, smb_fname);
-
-       if (!null_timespec(ts)) {
-               return ts;
-       } else {
-               return smb_fname->st.st_ex_btime;
-       }
+       return smb_fname->st.st_ex_btime;
 }
 
 /******************************************************************