r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
[samba.git] / source3 / smbd / blocking.c
index 5c6ddbc6b7ef2cfb7f35341b1b9c4aedeaad8566..04ab01eb664fef7e2fec9ed2b2388d82223b80ac 100644 (file)
 
 #include "includes.h"
 
-extern char *OutBuffer;
-
 /****************************************************************************
  This is the structure to queue to implement blocking locks.
  notify. It consists of the requesting SMB and the expiry time.
 *****************************************************************************/
 
-typedef struct {
-       ubi_slNode msg_next;
+typedef struct _blocking_lock_record {
+       struct _blocking_lock_record *next;
+       struct _blocking_lock_record *prev;
        int com_type;
        files_struct *fsp;
        time_t expire_time;
        int lock_num;
        SMB_BIG_UINT offset;
        SMB_BIG_UINT count;
-       uint16 lock_pid;
+       uint32 lock_pid;
+       enum brl_flavour lock_flav;
+       enum brl_type lock_type;
        char *inbuf;
        int length;
 } blocking_lock_record;
 
-static ubi_slList blocking_lock_queue = { NULL, (ubi_slNodePtr)&blocking_lock_queue, 0};
+static blocking_lock_record *blocking_lock_queue;
 
 /****************************************************************************
  Destructor for the above structure.
@@ -48,29 +49,11 @@ static ubi_slList blocking_lock_queue = { NULL, (ubi_slNodePtr)&blocking_lock_qu
 
 static void free_blocking_lock_record(blocking_lock_record *blr)
 {
+       DLIST_REMOVE(blocking_lock_queue, blr);
        SAFE_FREE(blr->inbuf);
        SAFE_FREE(blr);
 }
 
-/****************************************************************************
- Get the files_struct given a particular queued SMB.
-*****************************************************************************/
-
-static files_struct *get_fsp_from_pkt(char *inbuf)
-{
-       switch(CVAL(inbuf,smb_com)) {
-               case SMBlock:
-               case SMBlockread:
-                       return file_fsp(inbuf,smb_vwv0);
-               case SMBlockingX:
-                       return file_fsp(inbuf,smb_vwv2);
-               default:
-                       DEBUG(0,("get_fsp_from_pkt: PANIC - unknown type on blocking lock queue - exiting.!\n"));
-                       exit_server("PANIC - unknown type on blocking lock queue");
-       }
-       return NULL; /* Keep compiler happy. */
-}
-
 /****************************************************************************
  Determine if this is a secondary element of a chained SMB.
   **************************************************************************/
@@ -80,18 +63,26 @@ static BOOL in_chained_smb(void)
        return (chain_size != 0);
 }
 
-static void received_unlock_msg(int msg_type, pid_t src, void *buf, size_t len);
+static void received_unlock_msg(int msg_type, struct process_id src,
+                               void *buf, size_t len);
 
 /****************************************************************************
  Function to push a blocking lock request onto the lock queue.
 ****************************************************************************/
 
-BOOL push_blocking_lock_request( char *inbuf, int length, int lock_timeout,
-               int lock_num, uint16 lock_pid, SMB_BIG_UINT offset, SMB_BIG_UINT count)
+BOOL push_blocking_lock_request( char *inbuf, int length,
+               files_struct *fsp,
+               int lock_timeout,
+               int lock_num,
+               uint32 lock_pid,
+               enum brl_type lock_type,
+               enum brl_flavour lock_flav,
+               SMB_BIG_UINT offset, SMB_BIG_UINT count)
 {
        static BOOL set_lock_msg;
-       blocking_lock_record *blr;
+       blocking_lock_record *blr, *tmp;
        BOOL my_lock_ctx = False;
+       struct byte_range_lock *br_lck = NULL;
        NTSTATUS status;
 
        if(in_chained_smb() ) {
@@ -104,31 +95,48 @@ BOOL push_blocking_lock_request( char *inbuf, int length, int lock_timeout,
         * the expiration time here.
         */
 
-       if((blr = (blocking_lock_record *)malloc(sizeof(blocking_lock_record))) == NULL) {
+       if((blr = SMB_MALLOC_P(blocking_lock_record)) == NULL) {
                DEBUG(0,("push_blocking_lock_request: Malloc fail !\n" ));
                return False;
        }
 
-       if((blr->inbuf = (char *)malloc(length)) == NULL) {
+       blr->next = NULL;
+       blr->prev = NULL;
+
+       if((blr->inbuf = (char *)SMB_MALLOC(length)) == NULL) {
                DEBUG(0,("push_blocking_lock_request: Malloc fail (2)!\n" ));
                SAFE_FREE(blr);
                return False;
        }
 
        blr->com_type = CVAL(inbuf,smb_com);
-       blr->fsp = get_fsp_from_pkt(inbuf);
+       blr->fsp = fsp;
        blr->expire_time = (lock_timeout == -1) ? (time_t)-1 : time(NULL) + (time_t)lock_timeout;
        blr->lock_num = lock_num;
        blr->lock_pid = lock_pid;
+       blr->lock_flav = lock_flav;
+       blr->lock_type = lock_type;
        blr->offset = offset;
        blr->count = count;
        memcpy(blr->inbuf, inbuf, length);
        blr->length = length;
 
+       br_lck = brl_get_locks(NULL, blr->fsp);
+       if (!br_lck) {
+               free_blocking_lock_record(blr);
+               return False;
+       }
+
        /* Add a pending lock record for this. */
-       status = brl_lock(blr->fsp->dev, blr->fsp->inode, blr->fsp->fnum,
-                       lock_pid, sys_getpid(), blr->fsp->conn->cnum,
-                       offset, count, PENDING_LOCK, &my_lock_ctx);
+       status = brl_lock(br_lck,
+                       lock_pid,
+                       procid_self(),
+                       offset,
+                       count,
+                       PENDING_LOCK,
+                       blr->lock_flav,
+                       &my_lock_ctx);
+       TALLOC_FREE(br_lck);
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("push_blocking_lock_request: failed to add PENDING_LOCK record.\n"));
@@ -136,7 +144,7 @@ BOOL push_blocking_lock_request( char *inbuf, int length, int lock_timeout,
                return False;
        }
 
-       ubi_slAddTail(&blocking_lock_queue, blr);
+       DLIST_ADD_END(blocking_lock_queue, blr, tmp);
 
        /* Ensure we'll receive messages when this is unlocked. */
        if (!set_lock_msg) {
@@ -149,7 +157,7 @@ for fnum = %d, name = %s\n", length, (int)blr->expire_time, lock_timeout,
                blr->fsp->fnum, blr->fsp->fsp_name ));
 
        /* Push the MID of this packet on the signing queue. */
-       srv_defer_sign_response(SVAL(inbuf,smb_mid), True);
+       srv_defer_sign_response(SVAL(inbuf,smb_mid));
 
        return True;
 }
@@ -173,7 +181,7 @@ static void send_blocking_reply(char *outbuf, int outsize)
 
 static void reply_lockingX_success(blocking_lock_record *blr)
 {
-       char *outbuf = OutBuffer;
+       char *outbuf = get_OutBuffer();
        int bufsize = BUFFER_SIZE;
        char *inbuf = blr->inbuf;
        int outsize = 0;
@@ -202,7 +210,7 @@ static void reply_lockingX_success(blocking_lock_record *blr)
 
 static void generic_blocking_lock_error(blocking_lock_record *blr, NTSTATUS status)
 {
-       char *outbuf = OutBuffer;
+       char *outbuf = get_OutBuffer();
        char *inbuf = blr->inbuf;
        construct_reply_common(inbuf, outbuf);
 
@@ -226,10 +234,9 @@ static void reply_lockingX_error(blocking_lock_record *blr, NTSTATUS status)
 {
        char *inbuf = blr->inbuf;
        files_struct *fsp = blr->fsp;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
        uint16 num_ulocks = SVAL(inbuf,smb_vwv6);
        SMB_BIG_UINT count = (SMB_BIG_UINT)0, offset = (SMB_BIG_UINT) 0;
-       uint16 lock_pid;
+       uint32 lock_pid;
        unsigned char locktype = CVAL(inbuf,smb_vwv3);
        BOOL large_file_format = (locktype & LOCKING_ANDX_LARGE_FILES);
        char *data;
@@ -260,7 +267,11 @@ static void reply_lockingX_error(blocking_lock_record *blr, NTSTATUS status)
                 * request would never have been queued. JRA.
                 */
                
-               do_unlock(fsp,conn,lock_pid,count,offset);
+               do_unlock(fsp,
+                       lock_pid,
+                       count,
+                       offset,
+                       WINDOWS_LOCK);
        }
        
        generic_blocking_lock_error(blr, status);
@@ -273,19 +284,41 @@ static void reply_lockingX_error(blocking_lock_record *blr, NTSTATUS status)
 static void blocking_lock_reply_error(blocking_lock_record *blr, NTSTATUS status)
 {
        switch(blr->com_type) {
+#if 0
+       /* We no longer push blocking lock requests for anything but lockingX and trans2. */
        case SMBlock:
        case SMBlockread:
                generic_blocking_lock_error(blr, status);
                break;
+#endif
        case SMBlockingX:
                reply_lockingX_error(blr, status);
                break;
+       case SMBtrans2:
+       case SMBtranss2:
+               {
+                       char *outbuf = get_OutBuffer();
+                       char *inbuf = blr->inbuf;
+                       construct_reply_common(inbuf, outbuf);
+                       /* construct_reply_common has done us the favor to pre-fill the
+                        * command field with SMBtranss2 which is wrong :-)
+                        */
+                       SCVAL(outbuf,smb_com,SMBtrans2);
+                       ERROR_NT(status);
+                       if (!send_smb(smbd_server_fd(),outbuf)) {
+                               exit_server("blocking_lock_reply_error: send_smb failed.");
+                       }
+                       break;
+               }
        default:
                DEBUG(0,("blocking_lock_reply_error: PANIC - unknown type on blocking lock queue - exiting.!\n"));
                exit_server("PANIC - unknown type on blocking lock queue");
        }
 }
 
+#if 0
+/* We no longer push blocking lock requests for anything but lockingX and trans2. */
+
 /****************************************************************************
  Attempt to finish off getting all pending blocking locks for a lockread call.
  Returns True if we want to be removed from the list.
@@ -293,7 +326,7 @@ static void blocking_lock_reply_error(blocking_lock_record *blr, NTSTATUS status
 
 static BOOL process_lockread(blocking_lock_record *blr)
 {
-       char *outbuf = OutBuffer;
+       char *outbuf = get_OutBuffer();
        char *inbuf = blr->inbuf;
        ssize_t nread = -1;
        char *data, *p;
@@ -301,7 +334,6 @@ static BOOL process_lockread(blocking_lock_record *blr)
        SMB_BIG_UINT startpos;
        size_t numtoread;
        NTSTATUS status;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
        files_struct *fsp = blr->fsp;
        BOOL my_lock_ctx = False;
 
@@ -311,7 +343,14 @@ static BOOL process_lockread(blocking_lock_record *blr)
        numtoread = MIN(BUFFER_SIZE-outsize,numtoread);
        data = smb_buf(outbuf) + 3;
  
-       status = do_lock_spin( fsp, conn, SVAL(inbuf,smb_pid), (SMB_BIG_UINT)numtoread, startpos, READ_LOCK, &my_lock_ctx);
+       status = do_lock_spin(fsp,
+                               (uint32)SVAL(inbuf,smb_pid),
+                               (SMB_BIG_UINT)numtoread,
+                               startpos,
+                               READ_LOCK,
+                               WINDOWS_LOCK,
+                               &my_lock_ctx);
+
        if (NT_STATUS_V(status)) {
                if (!NT_STATUS_EQUAL(status,NT_STATUS_LOCK_NOT_GRANTED) &&
                        !NT_STATUS_EQUAL(status,NT_STATUS_FILE_LOCK_CONFLICT)) {
@@ -351,8 +390,8 @@ static BOOL process_lockread(blocking_lock_record *blr)
        SSVAL(p,0,nread); p += 2;
        set_message_end(outbuf, p+nread);
        
-       DEBUG(3, ( "process_lockread file = %s, fnum=%d num=%d nread=%d\n",
-                  fsp->fsp_name, fsp->fnum, (int)numtoread, (int)nread ) );
+       DEBUG(3, ( "process_lockread file = %s, fnum=%d num=%lu nread=%ld\n",
+                  fsp->fsp_name, fsp->fnum, (unsigned long)numtoread, (long)nread ) );
        
        send_blocking_reply(outbuf,outsize);
        return True;
@@ -365,12 +404,11 @@ static BOOL process_lockread(blocking_lock_record *blr)
 
 static BOOL process_lock(blocking_lock_record *blr)
 {
-       char *outbuf = OutBuffer;
+       char *outbuf = get_OutBuffer();
        char *inbuf = blr->inbuf;
        int outsize;
        SMB_BIG_UINT count = (SMB_BIG_UINT)0, offset = (SMB_BIG_UINT)0;
        NTSTATUS status;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
        files_struct *fsp = blr->fsp;
        BOOL my_lock_ctx = False;
 
@@ -378,7 +416,14 @@ static BOOL process_lock(blocking_lock_record *blr)
        offset = IVAL_TO_SMB_OFF_T(inbuf,smb_vwv3);
 
        errno = 0;
-       status = do_lock_spin(fsp, conn, SVAL(inbuf,smb_pid), count, offset, WRITE_LOCK, &my_lock_ctx);
+       status = do_lock_spin(fsp,
+                               (uint32)SVAL(inbuf,smb_pid),
+                               count,
+                               offset,
+                               WRITE_LOCK,
+                               WINDOWS_LOCK,
+                               &my_lock_ctx);
+
        if (NT_STATUS_IS_ERR(status)) {
                if (!NT_STATUS_EQUAL(status,NT_STATUS_LOCK_NOT_GRANTED) &&
                        !NT_STATUS_EQUAL(status,NT_STATUS_FILE_LOCK_CONFLICT)) {
@@ -411,6 +456,7 @@ static BOOL process_lock(blocking_lock_record *blr)
        send_blocking_reply(outbuf,outsize);
        return True;
 }
+#endif
 
 /****************************************************************************
  Attempt to finish off getting all pending blocking locks for a lockingX call.
@@ -422,11 +468,10 @@ static BOOL process_lockingX(blocking_lock_record *blr)
        char *inbuf = blr->inbuf;
        unsigned char locktype = CVAL(inbuf,smb_vwv3);
        files_struct *fsp = blr->fsp;
-       connection_struct *conn = conn_find(SVAL(inbuf,smb_tid));
        uint16 num_ulocks = SVAL(inbuf,smb_vwv6);
        uint16 num_locks = SVAL(inbuf,smb_vwv7);
        SMB_BIG_UINT count = (SMB_BIG_UINT)0, offset = (SMB_BIG_UINT)0;
-       uint16 lock_pid;
+       uint32 lock_pid;
        BOOL large_file_format = (locktype & LOCKING_ANDX_LARGE_FILES);
        char *data;
        BOOL my_lock_ctx = False;
@@ -451,9 +496,17 @@ static BOOL process_lockingX(blocking_lock_record *blr)
                 * request would never have been queued. JRA.
                 */
                errno = 0;
-               status = do_lock_spin(fsp,conn,lock_pid,count,offset, 
-                                ((locktype & 1) ? READ_LOCK : WRITE_LOCK), &my_lock_ctx);
-               if (NT_STATUS_IS_ERR(status)) break;
+               status = do_lock_spin(fsp,
+                               lock_pid,
+                               count,
+                               offset, 
+                               ((locktype & 1) ? READ_LOCK : WRITE_LOCK),
+                               WINDOWS_LOCK,
+                               &my_lock_ctx);
+
+               if (NT_STATUS_IS_ERR(status)) {
+                       break;
+               }
        }
 
        if(blr->lock_num == num_locks) {
@@ -489,6 +542,51 @@ Waiting....\n",
        return False;
 }
 
+/****************************************************************************
+ Attempt to get the posix lock request from a SMBtrans2 call.
+ Returns True if we want to be removed from the list.
+*****************************************************************************/
+
+static BOOL process_trans2(blocking_lock_record *blr)
+{
+       extern int max_send;
+       char *inbuf = blr->inbuf;
+       char *outbuf;
+       BOOL my_lock_ctx = False;
+       char params[2];
+       NTSTATUS status;
+
+       status = do_lock(blr->fsp,
+                       blr->lock_pid,
+                       blr->count,
+                       blr->offset,
+                       blr->lock_type,
+                       blr->lock_flav,
+                       &my_lock_ctx);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               if (ERROR_WAS_LOCK_DENIED(status)) {
+                       /* Still can't get the lock, just keep waiting. */
+                       return False;
+               }       
+               /*
+                * We have other than a "can't get lock"
+                * error. Send an error and return True so we get dequeued.
+                */
+               blocking_lock_reply_error(blr, status);
+               return True;
+       }
+
+       /* We finally got the lock, return success. */
+       outbuf = get_OutBuffer();
+       construct_reply_common(inbuf, outbuf);
+       SCVAL(outbuf,smb_com,SMBtrans2);
+       SSVAL(params,0,0);
+       send_trans2_replies(outbuf, max_send, params, 2, NULL, 0);
+       return True;
+}
+
+
 /****************************************************************************
  Process a blocking lock SMB.
  Returns True if we want to be removed from the list.
@@ -497,12 +595,18 @@ Waiting....\n",
 static BOOL blocking_lock_record_process(blocking_lock_record *blr)
 {
        switch(blr->com_type) {
+#if 0
+               /* We no longer push blocking lock requests for anything but lockingX and trans2. */
                case SMBlock:
                        return process_lock(blr);
                case SMBlockread:
                        return process_lockread(blr);
+#endif
                case SMBlockingX:
                        return process_lockingX(blr);
+               case SMBtrans2:
+               case SMBtranss2:
+                       return process_trans2(blr);
                default:
                        DEBUG(0,("blocking_lock_record_process: PANIC - unknown type on blocking lock queue - exiting.!\n"));
                        exit_server("PANIC - unknown type on blocking lock queue");
@@ -516,26 +620,29 @@ static BOOL blocking_lock_record_process(blocking_lock_record *blr)
 
 void remove_pending_lock_requests_by_fid(files_struct *fsp)
 {
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst( &blocking_lock_queue );
-       blocking_lock_record *prev = NULL;
+       blocking_lock_record *blr, *next = NULL;
 
-       while(blr != NULL) {
+       for(blr = blocking_lock_queue; blr; blr = next) {
+               next = blr->next;
                if(blr->fsp->fnum == fsp->fnum) {
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
 
-                       DEBUG(10,("remove_pending_lock_requests_by_fid - removing request type %d for \
+                       if (br_lck) {
+                               DEBUG(10,("remove_pending_lock_requests_by_fid - removing request type %d for \
 file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
 
-                       brl_unlock(blr->fsp->dev, blr->fsp->inode, blr->fsp->fnum,
-                               blr->lock_pid, sys_getpid(), blr->fsp->conn->cnum,
-                               blr->offset, blr->count, True, NULL, NULL);
+                               brl_remove_pending_lock(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
 
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
-                       continue;
-               }
+                       }
 
-               prev = blr;
-               blr = (blocking_lock_record *)ubi_slNext(blr);
+                       free_blocking_lock_record(blr);
+               }
        }
 }
 
@@ -545,27 +652,30 @@ file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
 
 void remove_pending_lock_requests_by_mid(int mid)
 {
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst( &blocking_lock_queue );
-       blocking_lock_record *prev = NULL;
+       blocking_lock_record *blr, *next = NULL;
 
-       while(blr != NULL) {
+       for(blr = blocking_lock_queue; blr; blr = next) {
+               next = blr->next;
                if(SVAL(blr->inbuf,smb_mid) == mid) {
                        files_struct *fsp = blr->fsp;
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
 
-                       DEBUG(10,("remove_pending_lock_requests_by_mid - removing request type %d for \
+                       if (br_lck) {
+                               DEBUG(10,("remove_pending_lock_requests_by_mid - removing request type %d for \
 file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
 
-                       blocking_lock_reply_error(blr,NT_STATUS_CANCELLED);
-                       brl_unlock(blr->fsp->dev, blr->fsp->inode, blr->fsp->fnum,
-                               blr->lock_pid, sys_getpid(), blr->fsp->conn->cnum,
-                               blr->offset, blr->count, True, NULL, NULL);
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
-                       continue;
-               }
+                               brl_remove_pending_lock(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
 
-               prev = blr;
-               blr = (blocking_lock_record *)ubi_slNext(blr);
+                       blocking_lock_reply_error(blr,NT_STATUS_FILE_LOCK_CONFLICT);
+                       free_blocking_lock_record(blr);
+               }
        }
 }
 
@@ -573,7 +683,8 @@ file %s fnum = %d\n", blr->com_type, fsp->fsp_name, fsp->fnum ));
   Set a flag as an unlock request affects one of our pending locks.
 *****************************************************************************/
 
-static void received_unlock_msg(int msg_type, pid_t src, void *buf, size_t len)
+static void received_unlock_msg(int msg_type, struct process_id src,
+                               void *buf, size_t len)
 {
        DEBUG(10,("received_unlock_msg\n"));
        process_blocking_lock_queue(time(NULL));
@@ -587,7 +698,7 @@ unsigned blocking_locks_timeout(unsigned default_timeout)
 {
        unsigned timeout = default_timeout;
        time_t t;
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst(&blocking_lock_queue);
+       blocking_lock_record *blr = blocking_lock_queue;
 
        /* note that we avoid the time() syscall if there are no blocking locks */
        if (!blr)
@@ -595,12 +706,11 @@ unsigned blocking_locks_timeout(unsigned default_timeout)
 
        t = time(NULL);
 
-       while (blr) {
+       for (; blr; blr = blr->next) {
                if ((blr->expire_time != (time_t)-1) &&
                                        (timeout > (blr->expire_time - t))) {
                        timeout = blr->expire_time - t;
                }
-               blr = (blocking_lock_record *)ubi_slNext(blr);
        }
 
        if (timeout < 1)
@@ -615,21 +725,19 @@ unsigned blocking_locks_timeout(unsigned default_timeout)
 
 void process_blocking_lock_queue(time_t t)
 {
-       blocking_lock_record *blr = (blocking_lock_record *)ubi_slFirst( &blocking_lock_queue );
-       blocking_lock_record *prev = NULL;
-
-       if(blr == NULL)
-               return;
+       blocking_lock_record *blr, *next = NULL;
 
        /*
         * Go through the queue and see if we can get any of the locks.
         */
 
-       while(blr != NULL) {
+       for (blr = blocking_lock_queue; blr; blr = next) {
                connection_struct *conn = NULL;
                uint16 vuid;
                files_struct *fsp = NULL;
 
+               next = blr->next;
+
                /*
                 * Ensure we don't have any old chain_fsp values
                 * sitting around....
@@ -646,53 +754,75 @@ void process_blocking_lock_queue(time_t t)
                        fsp->fnum, fsp->fsp_name ));
 
                if((blr->expire_time != -1) && (blr->expire_time <= t)) {
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
                        /*
                         * Lock expired - throw away all previously
                         * obtained locks and return lock error.
                         */
-                       DEBUG(5,("process_blocking_lock_queue: pending lock fnum = %d for file %s timed out.\n",
-                               fsp->fnum, fsp->fsp_name ));
 
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                               blr->lock_pid, sys_getpid(), conn->cnum,
-                               blr->offset, blr->count, True, NULL, NULL);
+                       if (br_lck) {
+                               DEBUG(5,("process_blocking_lock_queue: pending lock fnum = %d for file %s timed out.\n",
+                                       fsp->fnum, fsp->fsp_name ));
+
+                               brl_remove_pending_lock(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
 
                        blocking_lock_reply_error(blr,NT_STATUS_FILE_LOCK_CONFLICT);
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
+                       free_blocking_lock_record(blr);
                        continue;
                }
 
                if(!change_to_user(conn,vuid)) {
-                       DEBUG(0,("process_blocking_lock_queue: Unable to become user vuid=%d.\n",
-                               vuid ));
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
                        /*
                         * Remove the entry and return an error to the client.
                         */
-                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
 
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                                       blr->lock_pid, sys_getpid(), conn->cnum,
-                                       blr->offset, blr->count, True, NULL, NULL);
+                       if (br_lck) {
+                               brl_remove_pending_lock(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
 
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
+                       DEBUG(0,("process_blocking_lock_queue: Unable to become user vuid=%d.\n",
+                               vuid ));
+                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
+                       free_blocking_lock_record(blr);
                        continue;
                }
 
-               if(!set_current_service(conn,True)) {
-                       DEBUG(0,("process_blocking_lock_queue: Unable to become service Error was %s.\n", strerror(errno) ));
+               if(!set_current_service(conn,SVAL(blr->inbuf,smb_flg),True)) {
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
                        /*
                         * Remove the entry and return an error to the client.
                         */
-                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
 
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                                       blr->lock_pid, sys_getpid(), conn->cnum,
-                                       blr->offset, blr->count, True, NULL, NULL);
+                       if (br_lck) {
+                               brl_remove_pending_lock(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
 
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
+                       DEBUG(0,("process_blocking_lock_queue: Unable to become service Error was %s.\n", strerror(errno) ));
+                       blocking_lock_reply_error(blr,NT_STATUS_ACCESS_DENIED);
+                       free_blocking_lock_record(blr);
                        change_to_root_user();
                        continue;
                }
@@ -704,23 +834,20 @@ void process_blocking_lock_queue(time_t t)
                 */
 
                if(blocking_lock_record_process(blr)) {
-
-                       brl_unlock(fsp->dev, fsp->inode, fsp->fnum,
-                                       blr->lock_pid, sys_getpid(), conn->cnum,
-                                       blr->offset, blr->count, True, NULL, NULL);
-
-                       free_blocking_lock_record((blocking_lock_record *)ubi_slRemNext( &blocking_lock_queue, prev));
-                       blr = (blocking_lock_record *)(prev ? ubi_slNext(prev) : ubi_slFirst(&blocking_lock_queue));
-                       change_to_root_user();
-                       continue;
+                       struct byte_range_lock *br_lck = brl_get_locks(NULL, fsp);
+
+                       if (br_lck) {
+                               brl_remove_pending_lock(br_lck,
+                                       blr->lock_pid,
+                                       procid_self(),
+                                       blr->offset,
+                                       blr->count,
+                                       blr->lock_flav);
+                               TALLOC_FREE(br_lck);
+                       }
+
+                       free_blocking_lock_record(blr);
                }
-
                change_to_root_user();
-
-               /*
-                * Move to the next in the list.
-                */
-               prev = blr;
-               blr = (blocking_lock_record *)ubi_slNext(blr);
        }
 }