s3: VFS: Remove fsync_fn() from the VFS and all modules. VFS ABI change.
[samba.git] / source3 / modules / vfs_commit.c
index c22e8161d70d561987c51b2505e31fe62342a26f..aa9c87db74d1928541349d837d7b278346e3055f 100644 (file)
@@ -17,6 +17,9 @@
  */
 
 #include "includes.h"
+#include "system/filesys.h"
+#include "smbd/smbd.h"
+#include "lib/util/tevent_unix.h"
 
 /* Commit data module.
  *
@@ -66,11 +69,11 @@ enum eof_mode
 struct commit_info
 {
         /* For chunk-based commits */
-        SMB_OFF_T dbytes;      /* Dirty (uncommitted) bytes */
-        SMB_OFF_T dthresh;     /* Dirty data threshold */
+        off_t dbytes;  /* Dirty (uncommitted) bytes */
+        off_t dthresh; /* Dirty data threshold */
         /* For commits on EOF */
         enum eof_mode on_eof;
-        SMB_OFF_T eof;         /* Expected file size */
+        off_t eof;             /* Expected file size */
 };
 
 static int commit_do(
@@ -88,6 +91,8 @@ static int commit_do(
 #elif HAVE_FSYNC
         result = fsync(fd);
 #else
+       DEBUG(0, ("%s: WARNING: no commit support on this platform\n",
+               MODULE));
        result = 0
 #endif
         if (result == 0) {
@@ -102,7 +107,7 @@ static int commit_all(
 {
         struct commit_info *c;
 
-        if ((c = VFS_FETCH_FSP_EXTENSION(handle, fsp))) {
+        if ((c = (struct commit_info *)VFS_FETCH_FSP_EXTENSION(handle, fsp))) {
                 if (c->dbytes) {
                         DEBUG(module_debug,
                                 ("%s: flushing %lu dirty bytes\n",
@@ -117,12 +122,13 @@ static int commit_all(
 static int commit(
         struct vfs_handle_struct *     handle,
         files_struct *                 fsp,
-       SMB_OFF_T                       offset,
+       off_t                   offset,
         ssize_t                                last_write)
 {
         struct commit_info *c;
 
-        if ((c = VFS_FETCH_FSP_EXTENSION(handle, fsp)) == NULL) {
+        if ((c = (struct commit_info *)VFS_FETCH_FSP_EXTENSION(handle, fsp))
+           == NULL) {
                return 0;
        }
 
@@ -161,25 +167,31 @@ static int commit_connect(
         const char *                service,
         const char *                user)
 {
+       int ret = SMB_VFS_NEXT_CONNECT(handle, service, user);
+
+       if (ret < 0) {
+               return ret;
+       }
+
         module_debug = lp_parm_int(SNUM(handle->conn), MODULE, "debug", 100);
-        return SMB_VFS_NEXT_CONNECT(handle, service, user);
+        return 0;
 }
 
 static int commit_open(
        vfs_handle_struct * handle,
-       const char *        fname,
+       struct smb_filename *smb_fname,
        files_struct *      fsp,
        int                 flags,
        mode_t              mode)
 {
-        SMB_OFF_T dthresh;
+        off_t dthresh;
        const char *eof_mode;
         struct commit_info *c = NULL;
         int fd;
 
         /* Don't bother with read-only files. */
         if ((flags & O_ACCMODE) == O_RDONLY) {
-                return SMB_VFS_NEXT_OPEN(handle, fname, fsp, flags, mode);
+                return SMB_VFS_NEXT_OPEN(handle, smb_fname, fsp, flags, mode);
         }
 
         /* Read and check module configuration */
@@ -190,7 +202,8 @@ static int commit_open(
                                         MODULE, "eof mode", "none");
 
         if (dthresh > 0 || !strequal(eof_mode, "none")) {
-                c = VFS_ADD_FSP_EXTENSION(handle, fsp, struct commit_info, NULL);
+                c = VFS_ADD_FSP_EXTENSION(
+                       handle, fsp, struct commit_info, NULL);
                 /* Process main tunables */
                 if (c) {
                         c->dthresh = dthresh;
@@ -208,7 +221,7 @@ static int commit_open(
                 }
         }
 
-        fd = SMB_VFS_NEXT_OPEN(handle, fname, fsp, flags, mode);
+        fd = SMB_VFS_NEXT_OPEN(handle, smb_fname, fsp, flags, mode);
        if (fd == -1) {
                VFS_REMOVE_FSP_EXTENSION(handle, fsp);
                return fd;
@@ -217,19 +230,28 @@ static int commit_open(
         /* EOF commit modes require us to know the initial file size. */
         if (c && (c->on_eof != EOF_NONE)) {
                 SMB_STRUCT_STAT st;
-                if (SMB_VFS_FSTAT(fsp, &st) == -1) {
+               /*
+                * Setting the fd of the FSP is a hack
+                * but also practiced elsewhere -
+                * needed for calling the VFS.
+                */
+               fsp->fh->fd = fd;
+               if (SMB_VFS_FSTAT(fsp, &st) == -1) {
+                       int saved_errno = errno;
+                       SMB_VFS_CLOSE(fsp);
+                       errno = saved_errno;
                         return -1;
                 }
                c->eof = st.st_ex_size;
         }
 
-        return 0;
+        return fd;
 }
 
 static ssize_t commit_write(
         vfs_handle_struct * handle,
         files_struct *      fsp,
-        void *              data,
+        const void *        data,
         size_t              count)
 {
         ssize_t ret;
@@ -247,9 +269,9 @@ static ssize_t commit_write(
 static ssize_t commit_pwrite(
         vfs_handle_struct * handle,
         files_struct *      fsp,
-        void *              data,
+        const void *        data,
         size_t              count,
-       SMB_OFF_T           offset)
+       off_t       offset)
 {
         ssize_t ret;
 
@@ -263,6 +285,84 @@ static ssize_t commit_pwrite(
         return ret;
 }
 
+struct commit_pwrite_state {
+       struct vfs_handle_struct *handle;
+       struct files_struct *fsp;
+       ssize_t ret;
+       struct vfs_aio_state vfs_aio_state;
+};
+
+static void commit_pwrite_written(struct tevent_req *subreq);
+
+static struct tevent_req *commit_pwrite_send(struct vfs_handle_struct *handle,
+                                            TALLOC_CTX *mem_ctx,
+                                            struct tevent_context *ev,
+                                            struct files_struct *fsp,
+                                            const void *data,
+                                            size_t n, off_t offset)
+{
+       struct tevent_req *req, *subreq;
+       struct commit_pwrite_state *state;
+
+       req = tevent_req_create(mem_ctx, &state, struct commit_pwrite_state);
+       if (req == NULL) {
+               return NULL;
+       }
+       state->handle = handle;
+       state->fsp = fsp;
+
+       subreq = SMB_VFS_NEXT_PWRITE_SEND(state, ev, handle, fsp, data,
+                                         n, offset);
+       if (tevent_req_nomem(subreq, req)) {
+               return tevent_req_post(req, ev);
+       }
+       tevent_req_set_callback(subreq, commit_pwrite_written, req);
+       return req;
+}
+
+static void commit_pwrite_written(struct tevent_req *subreq)
+{
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct commit_pwrite_state *state = tevent_req_data(
+               req, struct commit_pwrite_state);
+       int commit_ret;
+
+       state->ret = SMB_VFS_PWRITE_RECV(subreq, &state->vfs_aio_state);
+       TALLOC_FREE(subreq);
+
+       if (state->ret <= 0) {
+               tevent_req_done(req);
+               return;
+       }
+
+       /*
+        * Ok, this is a sync fake. We should make the sync async as well, but
+        * I'm too lazy for that right now -- vl
+        */
+       commit_ret = commit(state->handle, state->fsp, state->fsp->fh->pos,
+                           state->ret);
+
+       if (commit_ret == -1) {
+               state->ret = -1;
+       }
+
+       tevent_req_done(req);
+}
+
+static ssize_t commit_pwrite_recv(struct tevent_req *req,
+                                 struct vfs_aio_state *vfs_aio_state)
+{
+       struct commit_pwrite_state *state =
+               tevent_req_data(req, struct commit_pwrite_state);
+
+       if (tevent_req_is_unix_error(req, &vfs_aio_state->error)) {
+               return -1;
+       }
+       *vfs_aio_state = state->vfs_aio_state;
+       return state->ret;
+}
+
 static int commit_close(
         vfs_handle_struct * handle,
         files_struct *      fsp)
@@ -275,14 +375,15 @@ static int commit_close(
 static int commit_ftruncate(
         vfs_handle_struct * handle,
         files_struct *      fsp,
-        SMB_OFF_T           len)
+        off_t           len)
 {
         int result;
 
         result = SMB_VFS_NEXT_FTRUNCATE(handle, fsp, len);
         if (result == 0) {
                struct commit_info *c;
-               if ((c = VFS_FETCH_FSP_EXTENSION(handle, fsp))) {
+               if ((c = (struct commit_info *)VFS_FETCH_FSP_EXTENSION(
+                            handle, fsp))) {
                        commit(handle, fsp, len, 0);
                        c->eof = len;
                }
@@ -291,28 +392,22 @@ static int commit_ftruncate(
         return result;
 }
 
-static vfs_op_tuple commit_ops [] =
-{
-        {SMB_VFS_OP(commit_open),
-                SMB_VFS_OP_OPEN, SMB_VFS_LAYER_TRANSPARENT},
-        {SMB_VFS_OP(commit_close),
-                SMB_VFS_OP_CLOSE, SMB_VFS_LAYER_TRANSPARENT},
-        {SMB_VFS_OP(commit_write),
-                SMB_VFS_OP_WRITE, SMB_VFS_LAYER_TRANSPARENT},
-        {SMB_VFS_OP(commit_pwrite),
-                SMB_VFS_OP_PWRITE, SMB_VFS_LAYER_TRANSPARENT},
-        {SMB_VFS_OP(commit_connect),
-                SMB_VFS_OP_CONNECT,  SMB_VFS_LAYER_TRANSPARENT},
-        {SMB_VFS_OP(commit_ftruncate),
-                SMB_VFS_OP_FTRUNCATE,  SMB_VFS_LAYER_TRANSPARENT},
-
-        {SMB_VFS_OP(NULL), SMB_VFS_OP_NOOP, SMB_VFS_LAYER_NOOP}
+static struct vfs_fn_pointers vfs_commit_fns = {
+        .open_fn = commit_open,
+        .close_fn = commit_close,
+        .write_fn = commit_write,
+        .pwrite_fn = commit_pwrite,
+        .pwrite_send_fn = commit_pwrite_send,
+        .pwrite_recv_fn = commit_pwrite_recv,
+        .connect_fn = commit_connect,
+        .ftruncate_fn = commit_ftruncate
 };
 
-NTSTATUS vfs_commit_init(void);
-NTSTATUS vfs_commit_init(void)
+static_decl_vfs;
+NTSTATUS vfs_commit_init(TALLOC_CTX *ctx)
 {
-       return smb_register_vfs(SMB_VFS_INTERFACE_VERSION, MODULE, commit_ops);
+       return smb_register_vfs(SMB_VFS_INTERFACE_VERSION, MODULE,
+                               &vfs_commit_fns);
 }