Fix bug 8636 - When returning an ACL without SECINFO_DACL requested, we still set...
[kai/samba.git] / source3 / modules / vfs_acl_common.c
index 06bcfb856b1a0ec7ea9eacadf9b6a0f1e0ea26ab..00ac2a193206537136bc349239289f56547023db 100644 (file)
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+#include "smbd/smbd.h"
+#include "system/filesys.h"
+#include "../libcli/security/security.h"
+#include "../librpc/gen_ndr/ndr_security.h"
+#include "../lib/util/bitmap.h"
+
 static NTSTATUS create_acl_blob(const struct security_descriptor *psd,
                        DATA_BLOB *pblob,
                        uint16_t hash_type,
@@ -34,10 +40,10 @@ static NTSTATUS store_acl_blob_fsp(vfs_handle_struct *handle,
                        files_struct *fsp,
                        DATA_BLOB *pblob);
 
-#define HASH_SECURITY_INFO (OWNER_SECURITY_INFORMATION | \
-                               GROUP_SECURITY_INFORMATION | \
-                               DACL_SECURITY_INFORMATION | \
-                               SACL_SECURITY_INFORMATION)
+#define HASH_SECURITY_INFO (SECINFO_OWNER | \
+                               SECINFO_GROUP | \
+                               SECINFO_DACL | \
+                               SECINFO_SACL)
 
 /*******************************************************************
  Hash a security descriptor.
@@ -56,9 +62,9 @@ static NTSTATUS hash_sd_sha256(struct security_descriptor *psd,
                return status;
        }
 
-       SHA256_Init(&tctx);
-       SHA256_Update(&tctx, blob.data, blob.length);
-       SHA256_Final(hash, &tctx);
+       samba_SHA256_Init(&tctx);
+       samba_SHA256_Update(&tctx, blob.data, blob.length);
+       samba_SHA256_Final(hash, &tctx);
 
        return NT_STATUS_OK;
 }
@@ -77,18 +83,30 @@ static NTSTATUS parse_acl_blob(const DATA_BLOB *pblob,
        enum ndr_err_code ndr_err;
        size_t sd_size;
 
-       ndr_err = ndr_pull_struct_blob(pblob, ctx, NULL, &xacl,
+       ndr_err = ndr_pull_struct_blob(pblob, ctx, &xacl,
                        (ndr_pull_flags_fn_t)ndr_pull_xattr_NTACL);
 
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                DEBUG(5, ("parse_acl_blob: ndr_pull_xattr_NTACL failed: %s\n",
                        ndr_errstr(ndr_err)));
-               return ndr_map_error2ntstatus(ndr_err);;
+               return ndr_map_error2ntstatus(ndr_err);
        }
 
        switch (xacl.version) {
+               case 1:
+                       *ppdesc = make_sec_desc(ctx, SD_REVISION,
+                                       xacl.info.sd->type | SEC_DESC_SELF_RELATIVE,
+                                       xacl.info.sd->owner_sid,
+                                       xacl.info.sd->group_sid,
+                                       xacl.info.sd->sacl,
+                                       xacl.info.sd->dacl,
+                                       &sd_size);
+                       /* No hash - null out. */
+                       *p_hash_type = XATTR_SD_HASH_TYPE_NONE;
+                       memset(hash, '\0', XATTR_SD_HASH_SIZE);
+                       break;
                case 2:
-                       *ppdesc = make_sec_desc(ctx, SEC_DESC_REVISION,
+                       *ppdesc = make_sec_desc(ctx, SD_REVISION,
                                        xacl.info.sd_hs2->sd->type | SEC_DESC_SELF_RELATIVE,
                                        xacl.info.sd_hs2->sd->owner_sid,
                                        xacl.info.sd_hs2->sd->group_sid,
@@ -100,7 +118,7 @@ static NTSTATUS parse_acl_blob(const DATA_BLOB *pblob,
                        memset(hash, '\0', XATTR_SD_HASH_SIZE);
                        break;
                case 3:
-                       *ppdesc = make_sec_desc(ctx, SEC_DESC_REVISION,
+                       *ppdesc = make_sec_desc(ctx, SD_REVISION,
                                        xacl.info.sd_hs3->sd->type | SEC_DESC_SELF_RELATIVE,
                                        xacl.info.sd_hs3->sd->owner_sid,
                                        xacl.info.sd_hs3->sd->group_sid,
@@ -139,23 +157,102 @@ static NTSTATUS create_acl_blob(const struct security_descriptor *psd,
 
        xacl.version = 3;
        xacl.info.sd_hs3 = &sd_hs3;
-       xacl.info.sd_hs3->sd = CONST_DISCARD(struct security_descriptor *, psd);
+       xacl.info.sd_hs3->sd = discard_const_p(struct security_descriptor, psd);
        xacl.info.sd_hs3->hash_type = hash_type;
        memcpy(&xacl.info.sd_hs3->hash[0], hash, XATTR_SD_HASH_SIZE);
 
        ndr_err = ndr_push_struct_blob(
-                       pblob, ctx, NULL, &xacl,
+                       pblob, ctx, &xacl,
                        (ndr_push_flags_fn_t)ndr_push_xattr_NTACL);
 
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                DEBUG(5, ("create_acl_blob: ndr_push_xattr_NTACL failed: %s\n",
                        ndr_errstr(ndr_err)));
-               return ndr_map_error2ntstatus(ndr_err);;
+               return ndr_map_error2ntstatus(ndr_err);
        }
 
        return NT_STATUS_OK;
 }
 
+/*******************************************************************
+ Add in 3 inheritable components for a non-inheritable directory ACL.
+ CREATOR_OWNER/CREATOR_GROUP/WORLD.
+*******************************************************************/
+
+static void add_directory_inheritable_components(vfs_handle_struct *handle,
+                                const char *name,
+                               SMB_STRUCT_STAT *psbuf,
+                               struct security_descriptor *psd)
+{
+       struct connection_struct *conn = handle->conn;
+       int num_aces = (psd->dacl ? psd->dacl->num_aces : 0);
+       struct smb_filename smb_fname;
+       enum security_ace_type acltype;
+       uint32_t access_mask;
+       mode_t dir_mode;
+       mode_t file_mode;
+       mode_t mode;
+       struct security_ace *new_ace_list = talloc_zero_array(talloc_tos(),
+                                               struct security_ace,
+                                               num_aces + 3);
+
+       if (new_ace_list == NULL) {
+               return;
+       }
+
+       /* Fake a quick smb_filename. */
+       ZERO_STRUCT(smb_fname);
+       smb_fname.st = *psbuf;
+       smb_fname.base_name = discard_const_p(char, name);
+
+       dir_mode = unix_mode(conn,
+                       FILE_ATTRIBUTE_DIRECTORY, &smb_fname, NULL);
+       file_mode = unix_mode(conn,
+                       FILE_ATTRIBUTE_ARCHIVE, &smb_fname, NULL);
+
+       mode = dir_mode | file_mode;
+
+       DEBUG(10, ("add_directory_inheritable_components: directory %s, "
+               "mode = 0%o\n",
+               name,
+               (unsigned int)mode ));
+
+       if (num_aces) {
+               memcpy(new_ace_list, psd->dacl->aces,
+                       num_aces * sizeof(struct security_ace));
+       }
+       access_mask = map_canon_ace_perms(SNUM(conn), &acltype,
+                               mode & 0700, false);
+
+       init_sec_ace(&new_ace_list[num_aces],
+                       &global_sid_Creator_Owner,
+                       acltype,
+                       access_mask,
+                       SEC_ACE_FLAG_CONTAINER_INHERIT|
+                               SEC_ACE_FLAG_OBJECT_INHERIT|
+                               SEC_ACE_FLAG_INHERIT_ONLY);
+       access_mask = map_canon_ace_perms(SNUM(conn), &acltype,
+                               (mode << 3) & 0700, false);
+       init_sec_ace(&new_ace_list[num_aces+1],
+                       &global_sid_Creator_Group,
+                       acltype,
+                       access_mask,
+                       SEC_ACE_FLAG_CONTAINER_INHERIT|
+                               SEC_ACE_FLAG_OBJECT_INHERIT|
+                               SEC_ACE_FLAG_INHERIT_ONLY);
+       access_mask = map_canon_ace_perms(SNUM(conn), &acltype,
+                               (mode << 6) & 0700, false);
+       init_sec_ace(&new_ace_list[num_aces+2],
+                       &global_sid_World,
+                       acltype,
+                       access_mask,
+                       SEC_ACE_FLAG_CONTAINER_INHERIT|
+                               SEC_ACE_FLAG_OBJECT_INHERIT|
+                               SEC_ACE_FLAG_INHERIT_ONLY);
+       psd->dacl->aces = new_ace_list;
+       psd->dacl->num_aces += 3;
+}
+
 /*******************************************************************
  Pull a DATA_BLOB from an xattr given a pathname.
  If the hash doesn't match, or doesn't exist - return the underlying
@@ -168,13 +265,17 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
                                uint32_t security_info,
                                struct security_descriptor **ppdesc)
 {
-       DATA_BLOB blob;
+       DATA_BLOB blob = data_blob_null;
        NTSTATUS status;
-       uint16_t hash_type;
+       uint16_t hash_type = XATTR_SD_HASH_TYPE_NONE;
        uint8_t hash[XATTR_SD_HASH_SIZE];
        uint8_t hash_tmp[XATTR_SD_HASH_SIZE];
        struct security_descriptor *psd = NULL;
        struct security_descriptor *pdesc_next = NULL;
+       bool ignore_file_system_acl = lp_parm_bool(SNUM(handle->conn),
+                                               ACL_MODULE_NAME,
+                                               "ignore system acls",
+                                               false);
 
        if (fsp && name == NULL) {
                name = fsp->fsp_name->base_name;
@@ -238,6 +339,9 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
                        goto out;
        }
 
+       if (ignore_file_system_acl) {
+               goto out;
+       }
 
        status = hash_sd_sha256(pdesc_next, hash_tmp);
        if (!NT_STATUS_IS_OK(status)) {
@@ -248,6 +352,9 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
 
        if (memcmp(&hash[0], &hash_tmp[0], XATTR_SD_HASH_SIZE) == 0) {
                /* Hash matches, return blob sd. */
+               DEBUG(10, ("get_nt_acl_internal: blob hash "
+                       "matches for file %s\n",
+                       name ));
                goto out;
        }
 
@@ -261,270 +368,84 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
                /* We're returning the blob, throw
                 * away the filesystem SD. */
                TALLOC_FREE(pdesc_next);
+       } else {
+               SMB_STRUCT_STAT sbuf;
+               SMB_STRUCT_STAT *psbuf = &sbuf;
+               bool is_directory = false;
+               /*
+                * We're returning the underlying ACL from the
+                * filesystem. If it's a directory, and has no
+                * inheritable ACE entries we have to fake them.
+                */
+               if (fsp) {
+                       status = vfs_stat_fsp(fsp);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               return status;
+                       }
+                       psbuf = &fsp->fsp_name->st;
+               } else {
+                       int ret = vfs_stat_smb_fname(handle->conn,
+                                               name,
+                                               &sbuf);
+                       if (ret == -1) {
+                               return map_nt_error_from_unix(errno);
+                       }
+               }
+               is_directory = S_ISDIR(sbuf.st_ex_mode);
+
+               if (ignore_file_system_acl) {
+                       TALLOC_FREE(pdesc_next);
+                       status = make_default_filesystem_acl(talloc_tos(),
+                                               name,
+                                               psbuf,
+                                               &psd);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               return status;
+                       }
+               } else {
+                       if (is_directory &&
+                               !sd_has_inheritable_components(psd,
+                                                       true)) {
+                               add_directory_inheritable_components(handle,
+                                                       name,
+                                                       psbuf,
+                                                       psd);
+                       }
+                       /* The underlying POSIX module always sets
+                          the ~SEC_DESC_DACL_PROTECTED bit, as ACLs
+                          can't be inherited in this way under POSIX.
+                          Remove it for Windows-style ACLs. */
+                       psd->type &= ~SEC_DESC_DACL_PROTECTED;
+               }
        }
 
-       if (!(security_info & OWNER_SECURITY_INFORMATION)) {
+       if (!(security_info & SECINFO_OWNER)) {
                psd->owner_sid = NULL;
        }
-       if (!(security_info & GROUP_SECURITY_INFORMATION)) {
+       if (!(security_info & SECINFO_GROUP)) {
                psd->group_sid = NULL;
        }
-       if (!(security_info & DACL_SECURITY_INFORMATION)) {
+       if (!(security_info & SECINFO_DACL)) {
+               psd->type &= ~SEC_DESC_DACL_PRESENT;
                psd->dacl = NULL;
        }
-       if (!(security_info & SACL_SECURITY_INFORMATION)) {
+       if (!(security_info & SECINFO_SACL)) {
+               psd->type &= ~SEC_DESC_SACL_PRESENT;
                psd->sacl = NULL;
        }
 
        TALLOC_FREE(blob.data);
        *ppdesc = psd;
-       return NT_STATUS_OK;
-}
-
-/*********************************************************************
- Create a default ACL by inheriting from the parent. If no inheritance
- from the parent available, don't set anything. This will leave the actual
- permissions the new file or directory already got from the filesystem
- as the NT ACL when read.
-*********************************************************************/
-
-static NTSTATUS inherit_new_acl(vfs_handle_struct *handle,
-                                       files_struct *fsp,
-                                       struct security_descriptor *parent_desc,
-                                       bool is_directory)
-{
-       TALLOC_CTX *ctx = talloc_tos();
-       NTSTATUS status = NT_STATUS_OK;
-       struct security_descriptor *psd = NULL;
-       size_t size;
-
-       if (!sd_has_inheritable_components(parent_desc, is_directory)) {
-               return NT_STATUS_OK;
-       }
-
-       /* Create an inherited descriptor from the parent. */
-
-       if (DEBUGLEVEL >= 10) {
-               DEBUG(10,("inherit_new_acl: parent acl for %s is:\n",
-                       fsp_str_dbg(fsp) ));
-               NDR_PRINT_DEBUG(security_descriptor, parent_desc);
-       }
-
-       status = se_create_child_secdesc(ctx,
-                       &psd,
-                       &size,
-                       parent_desc,
-                       &handle->conn->server_info->ptok->user_sids[PRIMARY_USER_SID_INDEX],
-                       &handle->conn->server_info->ptok->user_sids[PRIMARY_GROUP_SID_INDEX],
-                       is_directory);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
 
        if (DEBUGLEVEL >= 10) {
-               DEBUG(10,("inherit_new_acl: child acl for %s is:\n",
-                       fsp_str_dbg(fsp) ));
-               NDR_PRINT_DEBUG(security_descriptor, parent_desc);
-       }
-
-       return SMB_VFS_FSET_NT_ACL(fsp,
-                               (OWNER_SECURITY_INFORMATION |
-                                GROUP_SECURITY_INFORMATION |
-                                DACL_SECURITY_INFORMATION),
-                               psd);
-}
-
-static NTSTATUS check_parent_acl_common(vfs_handle_struct *handle,
-                               const char *path,
-                               uint32_t access_mask,
-                               struct security_descriptor **pp_parent_desc)
-{
-       char *parent_name = NULL;
-       struct security_descriptor *parent_desc = NULL;
-       uint32_t access_granted = 0;
-       NTSTATUS status;
-
-       if (!parent_dirname(talloc_tos(), path, &parent_name, NULL)) {
-               return NT_STATUS_NO_MEMORY;
+               DEBUG(10,("get_nt_acl_internal: returning acl for %s is:\n",
+                       name ));
+               NDR_PRINT_DEBUG(security_descriptor, psd);
        }
 
-       status = get_nt_acl_internal(handle,
-                                       NULL,
-                                       parent_name,
-                                       (OWNER_SECURITY_INFORMATION |
-                                        GROUP_SECURITY_INFORMATION |
-                                        DACL_SECURITY_INFORMATION),
-                                       &parent_desc);
-
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(10,("check_parent_acl_common: get_nt_acl_internal "
-                       "on directory %s for "
-                       "path %s returned %s\n",
-                       parent_name,
-                       path,
-                       nt_errstr(status) ));
-               return status;
-       }
-       status = smb1_file_se_access_check(parent_desc,
-                                       handle->conn->server_info->ptok,
-                                       access_mask,
-                                       &access_granted);
-       if(!NT_STATUS_IS_OK(status)) {
-               DEBUG(10,("check_parent_acl_common: access check "
-                       "on directory %s for "
-                       "path %s for mask 0x%x returned %s\n",
-                       parent_name,
-                       path,
-                       access_mask,
-                       nt_errstr(status) ));
-               return status;
-       }
-       if (pp_parent_desc) {
-               *pp_parent_desc = parent_desc;
-       }
        return NT_STATUS_OK;
 }
 
-static void free_sd_common(void **ptr)
-{
-       TALLOC_FREE(*ptr);
-}
-
-/*********************************************************************
- Check ACL on open. For new files inherit from parent directory.
-*********************************************************************/
-
-static int open_acl_common(vfs_handle_struct *handle,
-                       struct smb_filename *smb_fname,
-                       files_struct *fsp,
-                       int flags,
-                       mode_t mode)
-{
-       uint32_t access_granted = 0;
-       struct security_descriptor *pdesc = NULL;
-       struct security_descriptor *parent_desc = NULL;
-       bool file_existed = true;
-       char *fname = NULL;
-       NTSTATUS status;
-
-       if (fsp->base_fsp) {
-               /* Stream open. Base filename open already did the ACL check. */
-               DEBUG(10,("open_acl_common: stream open on %s\n",
-                       fsp_str_dbg(fsp) ));
-               return SMB_VFS_NEXT_OPEN(handle, smb_fname, fsp, flags, mode);
-       }
-
-       status = get_full_smb_filename(talloc_tos(), smb_fname,
-                                      &fname);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto err;
-       }
-
-       status = get_nt_acl_internal(handle,
-                               NULL,
-                               fname,
-                               (OWNER_SECURITY_INFORMATION |
-                                GROUP_SECURITY_INFORMATION |
-                                DACL_SECURITY_INFORMATION),
-                               &pdesc);
-        if (NT_STATUS_IS_OK(status)) {
-               /* See if we can access it. */
-               status = smb1_file_se_access_check(pdesc,
-                                       handle->conn->server_info->ptok,
-                                       fsp->access_mask,
-                                       &access_granted);
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(10,("open_acl_xattr: %s open "
-                               "refused with error %s\n",
-                               fsp_str_dbg(fsp),
-                               nt_errstr(status) ));
-                       goto err;
-               }
-        } else if (NT_STATUS_EQUAL(status,NT_STATUS_OBJECT_NAME_NOT_FOUND)) {
-               file_existed = false;
-               /*
-                * If O_CREAT is true then we're trying to create a file.
-                * Check the parent directory ACL will allow this.
-                */
-               if (flags & O_CREAT) {
-                       struct security_descriptor *psd = NULL;
-
-                       status = check_parent_acl_common(handle, fname,
-                                       SEC_DIR_ADD_FILE, &parent_desc);
-                       if (!NT_STATUS_IS_OK(status)) {
-                               goto err;
-                       }
-                       /* Cache the parent security descriptor for
-                        * later use. We do have an fsp here, but to
-                        * keep the code consistent with the directory
-                        * case which doesn't, use the handle. */
-
-                       /* Attach this to the conn, move from talloc_tos(). */
-                       psd = (struct security_descriptor *)talloc_move(handle->conn,
-                               &parent_desc);
-
-                       if (!psd) {
-                               status = NT_STATUS_NO_MEMORY;
-                               goto err;
-                       }
-                       status = NT_STATUS_NO_MEMORY;
-                       SMB_VFS_HANDLE_SET_DATA(handle, psd, free_sd_common,
-                               struct security_descriptor *, goto err);
-                       status = NT_STATUS_OK;
-               }
-       }
-
-       DEBUG(10,("open_acl_xattr: get_nt_acl_attr_internal for "
-               "%s returned %s\n",
-               fsp_str_dbg(fsp),
-               nt_errstr(status) ));
-
-       fsp->fh->fd = SMB_VFS_NEXT_OPEN(handle, smb_fname, fsp, flags, mode);
-       return fsp->fh->fd;
-
-  err:
-
-       errno = map_errno_from_nt_status(status);
-       return -1;
-}
-
-static int mkdir_acl_common(vfs_handle_struct *handle, const char *path, mode_t mode)
-{
-       int ret;
-       NTSTATUS status;
-       SMB_STRUCT_STAT sbuf;
-
-       ret = vfs_stat_smb_fname(handle->conn, path, &sbuf);
-       if (ret == -1 && errno == ENOENT) {
-               struct security_descriptor *parent_desc = NULL;
-               struct security_descriptor *psd = NULL;
-
-               /* We're creating a new directory. */
-               status = check_parent_acl_common(handle, path,
-                               SEC_DIR_ADD_SUBDIR, &parent_desc);
-               if (!NT_STATUS_IS_OK(status)) {
-                       errno = map_errno_from_nt_status(status);
-                       return -1;
-               }
-
-               /* Cache the parent security descriptor for
-                * later use. We don't have an fsp here so
-                * use the handle. */
-
-               /* Attach this to the conn, move from talloc_tos(). */
-               psd = (struct security_descriptor *)talloc_move(handle->conn,
-                               &parent_desc);
-
-               if (!psd) {
-                       return -1;
-               }
-               SMB_VFS_HANDLE_SET_DATA(handle, psd, free_sd_common,
-                       struct security_descriptor *, return -1);
-       }
-
-       return SMB_VFS_NEXT_MKDIR(handle, path, mode);
-}
-
 /*********************************************************************
  Fetch a security descriptor given an fsp.
 *********************************************************************/
@@ -552,61 +473,47 @@ static NTSTATUS get_nt_acl_common(vfs_handle_struct *handle,
 *********************************************************************/
 
 static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
-        uint32_t security_info_sent, const struct security_descriptor *psd)
+        uint32_t security_info_sent, const struct security_descriptor *orig_psd)
 {
        NTSTATUS status;
        DATA_BLOB blob;
        struct security_descriptor *pdesc_next = NULL;
+       struct security_descriptor *psd = NULL;
        uint8_t hash[XATTR_SD_HASH_SIZE];
 
        if (DEBUGLEVEL >= 10) {
                DEBUG(10,("fset_nt_acl_xattr: incoming sd for file %s\n",
                          fsp_str_dbg(fsp)));
                NDR_PRINT_DEBUG(security_descriptor,
-                       CONST_DISCARD(struct security_descriptor *,psd));
+                       discard_const_p(struct security_descriptor, orig_psd));
        }
 
-        /* Ensure we have OWNER/GROUP/DACL set. */
-
-       if ((security_info_sent & (OWNER_SECURITY_INFORMATION|
-                               GROUP_SECURITY_INFORMATION|
-                               DACL_SECURITY_INFORMATION)) !=
-                               (OWNER_SECURITY_INFORMATION|
-                                GROUP_SECURITY_INFORMATION|
-                                DACL_SECURITY_INFORMATION)) {
-               /* No we don't - read from the existing SD. */
-               struct security_descriptor *nc_psd = NULL;
-
-               status = get_nt_acl_internal(handle, fsp,
-                               NULL,
-                               (OWNER_SECURITY_INFORMATION|
-                                GROUP_SECURITY_INFORMATION|
-                                DACL_SECURITY_INFORMATION),
-                               &nc_psd);
+       status = get_nt_acl_internal(handle, fsp,
+                       NULL,
+                       SECINFO_OWNER|SECINFO_GROUP|SECINFO_DACL|SECINFO_SACL,
+                       &psd);
 
-               if (!NT_STATUS_IS_OK(status)) {
-                       return status;
-               }
-
-               /* This is safe as nc_psd is discarded at fn exit. */
-               if (security_info_sent & OWNER_SECURITY_INFORMATION) {
-                       nc_psd->owner_sid = psd->owner_sid;
-               }
-               security_info_sent |= OWNER_SECURITY_INFORMATION;
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
-               if (security_info_sent & GROUP_SECURITY_INFORMATION) {
-                       nc_psd->group_sid = psd->group_sid;
-               }
-               security_info_sent |= GROUP_SECURITY_INFORMATION;
+       psd->revision = orig_psd->revision;
+       /* All our SD's are self relative. */
+       psd->type = orig_psd->type | SEC_DESC_SELF_RELATIVE;
 
-               if (security_info_sent & DACL_SECURITY_INFORMATION) {
-                       nc_psd->dacl = dup_sec_acl(talloc_tos(), psd->dacl);
-                       if (nc_psd->dacl == NULL) {
-                               return NT_STATUS_NO_MEMORY;
-                       }
-               }
-               security_info_sent |= DACL_SECURITY_INFORMATION;
-               psd = nc_psd;
+       if ((security_info_sent & SECINFO_OWNER) && (orig_psd->owner_sid != NULL)) {
+               psd->owner_sid = orig_psd->owner_sid;
+       }
+       if ((security_info_sent & SECINFO_GROUP) && (orig_psd->group_sid != NULL)) {
+               psd->group_sid = orig_psd->group_sid;
+       }
+       if (security_info_sent & SECINFO_DACL) {
+               psd->dacl = orig_psd->dacl;
+               psd->type |= SEC_DESC_DACL_PRESENT;
+       }
+       if (security_info_sent & SECINFO_SACL) {
+               psd->sacl = orig_psd->sacl;
+               psd->type |= SEC_DESC_SACL_PRESENT;
        }
 
        status = SMB_VFS_NEXT_FSET_NT_ACL(handle, fsp, security_info_sent, psd);
@@ -633,7 +540,7 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
                DEBUG(10,("fset_nt_acl_xattr: storing xattr sd for file %s\n",
                          fsp_str_dbg(fsp)));
                NDR_PRINT_DEBUG(security_descriptor,
-                       CONST_DISCARD(struct security_descriptor *,psd));
+                       discard_const_p(struct security_descriptor, psd));
        }
        create_acl_blob(psd, &blob, XATTR_SD_HASH_TYPE_SHA256, hash);
        store_acl_blob_fsp(handle, fsp, &blob);
@@ -641,113 +548,176 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
        return NT_STATUS_OK;
 }
 
-static SMB_STRUCT_DIR *opendir_acl_common(vfs_handle_struct *handle,
-                       const char *fname, const char *mask, uint32 attr)
+static int acl_common_remove_object(vfs_handle_struct *handle,
+                                       const char *path,
+                                       bool is_directory)
 {
-       NTSTATUS status = check_parent_acl_common(handle, fname,
-                                       SEC_DIR_LIST, NULL);
-
-       if (!NT_STATUS_IS_OK(status)) {
-               errno = map_errno_from_nt_status(status);
-               return NULL;
+       connection_struct *conn = handle->conn;
+       struct file_id id;
+       files_struct *fsp = NULL;
+       int ret = 0;
+       char *parent_dir = NULL;
+       const char *final_component = NULL;
+       struct smb_filename local_fname;
+       int saved_errno = 0;
+       char *saved_dir = NULL;
+
+       saved_dir = vfs_GetWd(talloc_tos(),conn);
+       if (!saved_dir) {
+               saved_errno = errno;
+               goto out;
        }
-       return SMB_VFS_NEXT_OPENDIR(handle, fname, mask, attr);
-}
 
-static NTSTATUS create_file_acl_common(struct vfs_handle_struct *handle,
-                               struct smb_request *req,
-                               uint16_t root_dir_fid,
-                               struct smb_filename *smb_fname,
-                               uint32_t access_mask,
-                               uint32_t share_access,
-                               uint32_t create_disposition,
-                               uint32_t create_options,
-                               uint32_t file_attributes,
-                               uint32_t oplock_request,
-                               uint64_t allocation_size,
-                               struct security_descriptor *sd,
-                               struct ea_list *ea_list,
-                               files_struct **result,
-                               int *pinfo)
-{
-       NTSTATUS status, status1;
-       files_struct *fsp = NULL;
-       int info;
-       struct security_descriptor *parent_sd = NULL;
-
-       status = SMB_VFS_NEXT_CREATE_FILE(handle,
-                                       req,
-                                       root_dir_fid,
-                                       smb_fname,
-                                       access_mask,
-                                       share_access,
-                                       create_disposition,
-                                       create_options,
-                                       file_attributes,
-                                       oplock_request,
-                                       allocation_size,
-                                       sd,
-                                       ea_list,
-                                       result,
-                                       &info);
-
-       if (info != FILE_WAS_CREATED) {
-               /* File/directory was opened, not created. */
+       if (!parent_dirname(talloc_tos(), path,
+                       &parent_dir, &final_component)) {
+               saved_errno = ENOMEM;
                goto out;
        }
 
-       fsp = *result;
+       DEBUG(10,("acl_common_remove_object: removing %s %s/%s\n",
+               is_directory ? "directory" : "file",
+               parent_dir, final_component ));
 
-       if (!NT_STATUS_IS_OK(status) || fsp == NULL) {
-               /* Only handle success. */
+       /* cd into the parent dir to pin it. */
+       ret = vfs_ChDir(conn, parent_dir);
+       if (ret == -1) {
+               saved_errno = errno;
                goto out;
        }
 
-       if (sd) {
-               /* Security descriptor already set. */
+       ZERO_STRUCT(local_fname);
+       local_fname.base_name = discard_const_p(char, final_component);
+
+       /* Must use lstat here. */
+       ret = SMB_VFS_LSTAT(conn, &local_fname);
+       if (ret == -1) {
+               saved_errno = errno;
                goto out;
        }
 
-       if (fsp->base_fsp) {
-               /* Stream open. */
+       /* Ensure we have this file open with DELETE access. */
+       id = vfs_file_id_from_sbuf(conn, &local_fname.st);
+       for (fsp = file_find_di_first(conn->sconn, id); fsp;
+                    fsp = file_find_di_next(fsp)) {
+               if (fsp->access_mask & DELETE_ACCESS &&
+                               fsp->delete_on_close) {
+                       /* We did open this for delete,
+                        * allow the delete as root.
+                        */
+                       break;
+               }
+       }
+
+       if (!fsp) {
+               DEBUG(10,("acl_common_remove_object: %s %s/%s "
+                       "not an open file\n",
+                       is_directory ? "directory" : "file",
+                       parent_dir, final_component ));
+               saved_errno = EACCES;
                goto out;
        }
 
+       become_root();
+       if (is_directory) {
+               ret = SMB_VFS_NEXT_RMDIR(handle, final_component);
+       } else {
+               ret = SMB_VFS_NEXT_UNLINK(handle, &local_fname);
+       }
+       unbecome_root();
+
+       if (ret == -1) {
+               saved_errno = errno;
+       }
+
+  out:
+
+       TALLOC_FREE(parent_dir);
 
-       /* We must have a cached parent sd in this case.
-        * attached to the handle. */
+       if (saved_dir) {
+               vfs_ChDir(conn, saved_dir);
+       }
+       if (saved_errno) {
+               errno = saved_errno;
+       }
+       return ret;
+}
 
-       SMB_VFS_HANDLE_GET_DATA(handle, parent_sd,
-               struct security_descriptor,
-               goto err);
+static int rmdir_acl_common(struct vfs_handle_struct *handle,
+                               const char *path)
+{
+       int ret;
 
-       if (!parent_sd) {
-               goto err;
+       ret = SMB_VFS_NEXT_RMDIR(handle, path);
+       if (!(ret == -1 && (errno == EACCES || errno == EPERM))) {
+               DEBUG(10,("rmdir_acl_common: unlink of %s failed %s\n",
+                       path,
+                       strerror(errno) ));
+               return ret;
        }
 
-       /* New directory - inherit from parent. */
-       status1 = inherit_new_acl(handle, fsp, parent_sd, fsp->is_directory);
+       return acl_common_remove_object(handle,
+                                       path,
+                                       true);
+}
+
+static int unlink_acl_common(struct vfs_handle_struct *handle,
+                       const struct smb_filename *smb_fname)
+{
+       int ret;
 
-       if (!NT_STATUS_IS_OK(status1)) {
-               DEBUG(1,("create_file_acl_common: error setting "
-                       "sd for %s (%s)\n",
-                       fsp_str_dbg(fsp),
-                       nt_errstr(status1) ));
+       ret = SMB_VFS_NEXT_UNLINK(handle, smb_fname);
+       if (!(ret == -1 && (errno == EACCES || errno == EPERM))) {
+               DEBUG(10,("unlink_acl_common: unlink of %s failed %s\n",
+                       smb_fname->base_name,
+                       strerror(errno) ));
+               return ret;
+       }
+       /* Don't do anything fancy for streams. */
+       if (smb_fname->stream_name) {
+               return ret;
        }
 
-  out:
+       return acl_common_remove_object(handle,
+                                       smb_fname->base_name,
+                                       false);
+}
 
-       /* Ensure we never leave attached data around. */
-       SMB_VFS_HANDLE_FREE_DATA(handle);
+static int chmod_acl_module_common(struct vfs_handle_struct *handle,
+                       const char *path, mode_t mode)
+{
+       if (lp_posix_pathnames()) {
+               /* Only allow this on POSIX pathnames. */
+               return SMB_VFS_NEXT_CHMOD(handle, path, mode);
+       }
+       return 0;
+}
 
-       if (NT_STATUS_IS_OK(status) && pinfo) {
-               *pinfo = info;
+static int fchmod_acl_module_common(struct vfs_handle_struct *handle,
+                       struct files_struct *fsp, mode_t mode)
+{
+       if (fsp->posix_open) {
+               /* Only allow this on POSIX opens. */
+               return SMB_VFS_NEXT_FCHMOD(handle, fsp, mode);
        }
-       return status;
+       return 0;
+}
 
-  err:
+static int chmod_acl_acl_module_common(struct vfs_handle_struct *handle,
+                       const char *name, mode_t mode)
+{
+       if (lp_posix_pathnames()) {
+               /* Only allow this on POSIX pathnames. */
+               return SMB_VFS_NEXT_CHMOD_ACL(handle, name, mode);
+       }
+       return 0;
+}
 
-       smb_panic("create_file_acl_common: logic error.\n");
-       /* NOTREACHED */
-       return status;
+static int fchmod_acl_acl_module_common(struct vfs_handle_struct *handle,
+                       struct files_struct *fsp, mode_t mode)
+{
+       if (fsp->posix_open) {
+               /* Only allow this on POSIX opens. */
+               return SMB_VFS_NEXT_FCHMOD_ACL(handle, fsp, mode);
+       }
+       return 0;
 }