r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
[samba.git] / source3 / libads / ldap_printer.c
index 4a983b20e30ed65d0ecbe865eae12c97a47cb5ce..68e6735891038a1de49a390e0cc6e8abb8189605 100644 (file)
@@ -1,7 +1,7 @@
 /* 
    Unix SMB/CIFS implementation.
    ads (active directory) printer utility library
-   Copyright (C) Jim McDonough 2002
+   Copyright (C) Jim McDonough <jmcd@us.ibm.com> 2002
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -31,12 +31,12 @@ ADS_STATUS ads_find_printer_on_server(ADS_STRUCT *ads, void **res,
                                      const char *printer, const char *servername)
 {
        ADS_STATUS status;
-       char *srv_dn, **srv_cn, *exp;
+       char *srv_dn, **srv_cn, *s;
        const char *attrs[] = {"*", "nTSecurityDescriptor", NULL};
 
        status = ads_find_machine_acct(ads, res, servername);
        if (!ADS_ERR_OK(status)) {
-               DEBUG(1, ("ads_add_printer: cannot find host %s in ads\n",
+               DEBUG(1, ("ads_find_printer_on_server: cannot find host %s in ads\n",
                          servername));
                return status;
        }
@@ -44,15 +44,29 @@ ADS_STATUS ads_find_printer_on_server(ADS_STRUCT *ads, void **res,
        srv_cn = ldap_explode_dn(srv_dn, 1);
        ads_msgfree(ads, *res);
 
-       asprintf(&exp, "(cn=%s-%s)", srv_cn[0], printer);
-       status = ads_search(ads, res, exp, attrs);
+       asprintf(&s, "(cn=%s-%s)", srv_cn[0], printer);
+       status = ads_search(ads, res, s, attrs);
 
        ldap_memfree(srv_dn);
        ldap_value_free(srv_cn);
-       free(exp);
+       free(s);
        return status;  
 }
 
+ADS_STATUS ads_find_printers(ADS_STRUCT *ads, void **res)
+{
+       char *ldap_expr;
+       const char *attrs[] = { "objectClass", "printerName", "location", "driverName",
+                               "serverName", "description", NULL };
+
+       /* For the moment only display all printers */
+
+       ldap_expr = "(&(!(showInAdvancedViewOnly=TRUE))(uncName=*)"
+               "(objectCategory=printQueue))";
+
+       return ads_search(ads, res, ldap_expr, attrs);
+}
+
 /*
   modify a printer entry in the directory
 */
@@ -79,15 +93,15 @@ static BOOL map_sz(TALLOC_CTX *ctx, ADS_MODLIST *mods,
                            const REGISTRY_VALUE *value)
 {
        char *str_value = NULL;
+       ADS_STATUS status;
 
        if (value->type != REG_SZ)
                return False;
 
        if (value->size && *((smb_ucs2_t *) value->data_p)) {
-               pull_ucs2_talloc(ctx, (void **) &str_value, 
-                                (const smb_ucs2_t *) value->data_p);
-               return ADS_ERR_OK(ads_mod_str(ctx, mods, value->valuename, 
-                                             str_value));
+               pull_ucs2_talloc(ctx, &str_value, (const smb_ucs2_t *) value->data_p);
+               status = ads_mod_str(ctx, mods, value->valuename, str_value);
+               return ADS_ERR_OK(status);
        }
        return True;
                
@@ -100,11 +114,13 @@ static BOOL map_dword(TALLOC_CTX *ctx, ADS_MODLIST *mods,
                      const REGISTRY_VALUE *value)
 {
        char *str_value = NULL;
+       ADS_STATUS status;
 
        if (value->type != REG_DWORD)
                return False;
        str_value = talloc_asprintf(ctx, "%d", *((uint32 *) value->data_p));
-       return ADS_ERR_OK(ads_mod_str(ctx, mods, value->valuename, str_value));
+       status = ads_mod_str(ctx, mods, value->valuename, str_value);
+       return ADS_ERR_OK(status);
 }
 
 /*
@@ -114,12 +130,14 @@ static BOOL map_bool(TALLOC_CTX *ctx, ADS_MODLIST *mods,
                     const REGISTRY_VALUE *value)
 {
        char *str_value;
+       ADS_STATUS status;
 
        if ((value->type != REG_BINARY) || (value->size != 1))
                return False;
        str_value =  talloc_asprintf(ctx, "%s", 
                                     *(value->data_p) ? "TRUE" : "FALSE");
-       return ADS_ERR_OK(ads_mod_str(ctx, mods, value->valuename, str_value));
+       status = ads_mod_str(ctx, mods, value->valuename, str_value);
+       return ADS_ERR_OK(status);
 }
 
 /*
@@ -131,6 +149,7 @@ static BOOL map_multi_sz(TALLOC_CTX *ctx, ADS_MODLIST *mods,
        char **str_values = NULL;
        smb_ucs2_t *cur_str = (smb_ucs2_t *) value->data_p;
         uint32 size = 0, num_vals = 0, i=0;
+       ADS_STATUS status;
 
        if (value->type != REG_MULTI_SZ)
                return False;
@@ -142,25 +161,24 @@ static BOOL map_multi_sz(TALLOC_CTX *ctx, ADS_MODLIST *mods,
        };
 
        if (num_vals) {
-               str_values = talloc(ctx, 
-                                   (num_vals + 1) * sizeof(smb_ucs2_t *));
+               str_values = TALLOC_ARRAY(ctx, char *, num_vals + 1);
                memset(str_values, '\0', 
-                      (num_vals + 1) * sizeof(smb_ucs2_t *));
+                      (num_vals + 1) * sizeof(char *));
 
                cur_str = (smb_ucs2_t *) value->data_p;
                for (i=0; i < num_vals; i++)
-                       cur_str += pull_ucs2_talloc(ctx, 
-                                                   (void **) &str_values[i], 
-                                                   cur_str);
+                       cur_str += pull_ucs2_talloc(ctx, &str_values[i],
+                                                   cur_str);
 
-               return ADS_ERR_OK(ads_mod_strlist(ctx, mods, value->valuename, 
-                                                 (const char **) str_values));
+               status = ads_mod_strlist(ctx, mods, value->valuename, 
+                                        (const char **) str_values);
+               return ADS_ERR_OK(status);
        } 
        return True;
 }
 
 struct valmap_to_ads {
-       char *valname;
+       const char *valname;
        BOOL (*fn)(TALLOC_CTX *, ADS_MODLIST *, const REGISTRY_VALUE *);
 };
 
@@ -170,58 +188,59 @@ struct valmap_to_ads {
 static void map_regval_to_ads(TALLOC_CTX *ctx, ADS_MODLIST *mods, 
                              REGISTRY_VALUE *value)
 {
-       struct valmap_to_ads map[] = {
-               {"assetNumber", map_sz},
-               {"bytesPerMinute", map_dword},
-               {"defaultPriority", map_dword},
-               {"driverName", map_sz},
-               {"driverVersion", map_dword},
-               {"flags", map_dword},
-               {"location", map_sz},
-               {"operatingSystem", map_sz},
-               {"operatingSystemHotfix", map_sz},
-               {"operatingSystemServicePack", map_sz},
-               {"operatingSystemVersion", map_sz},
-               {"portName", map_multi_sz},
-               {"printAttributes", map_dword},
-               {"printBinNames", map_multi_sz},
-               {"printCollate", map_bool},
-               {"printColor", map_bool},
-               {"printDuplexSupported", map_bool},
-               {"printEndTime", map_dword},
-               {"printFormName", map_sz},
-               {"printKeepPrintedJobs", map_bool},
-               {"printLanguage", map_multi_sz},
-               {"printMACAddress", map_sz},
-               {"printMaxCopies", map_sz},
-               {"printMaxResolutionSupported", map_dword},
-               {"printMaxXExtent", map_dword},
-               {"printMaxYExtent", map_dword},
-               {"printMediaReady", map_multi_sz},
-               {"printMediaSupported", map_multi_sz},
-               {"printMemory", map_dword},
-               {"printMinXExtent", map_dword},
-               {"printMinYExtent", map_dword},
-               {"printNetworkAddress", map_sz},
-               {"printNotify", map_sz},
-               {"printNumberUp", map_dword},
-               {"printOrientationsSupported", map_multi_sz},
-               {"printOwner", map_sz},
-               {"printPagesPerMinute", map_dword},
-               {"printRate", map_dword},
-               {"printRateUnit", map_sz},
-               {"printSeparatorFile", map_sz},
-               {"printShareName", map_sz},
-               {"printSpooling", map_sz},
-               {"printStaplingSupported", map_bool},
-               {"printStartTime", map_dword},
-               {"printStatus", map_sz},
-               {"priority", map_dword},
-               {"serverName", map_sz},
-               {"shortServerName", map_sz},
-               {"uNCName", map_sz},
-               {"url", map_sz},
-               {"versionNumber", map_dword},
+       const struct valmap_to_ads map[] = {
+               {SPOOL_REG_ASSETNUMBER, map_sz},
+               {SPOOL_REG_BYTESPERMINUTE, map_dword},
+               {SPOOL_REG_DEFAULTPRIORITY, map_dword},
+               {SPOOL_REG_DESCRIPTION, map_sz},
+               {SPOOL_REG_DRIVERNAME, map_sz},
+               {SPOOL_REG_DRIVERVERSION, map_dword},
+               {SPOOL_REG_FLAGS, map_dword},
+               {SPOOL_REG_LOCATION, map_sz},
+               {SPOOL_REG_OPERATINGSYSTEM, map_sz},
+               {SPOOL_REG_OPERATINGSYSTEMHOTFIX, map_sz},
+               {SPOOL_REG_OPERATINGSYSTEMSERVICEPACK, map_sz},
+               {SPOOL_REG_OPERATINGSYSTEMVERSION, map_sz},
+               {SPOOL_REG_PORTNAME, map_multi_sz},
+               {SPOOL_REG_PRINTATTRIBUTES, map_dword},
+               {SPOOL_REG_PRINTBINNAMES, map_multi_sz},
+               {SPOOL_REG_PRINTCOLLATE, map_bool},
+               {SPOOL_REG_PRINTCOLOR, map_bool},
+               {SPOOL_REG_PRINTDUPLEXSUPPORTED, map_bool},
+               {SPOOL_REG_PRINTENDTIME, map_dword},
+               {SPOOL_REG_PRINTFORMNAME, map_sz},
+               {SPOOL_REG_PRINTKEEPPRINTEDJOBS, map_bool},
+               {SPOOL_REG_PRINTLANGUAGE, map_multi_sz},
+               {SPOOL_REG_PRINTMACADDRESS, map_sz},
+               {SPOOL_REG_PRINTMAXCOPIES, map_sz},
+               {SPOOL_REG_PRINTMAXRESOLUTIONSUPPORTED, map_dword},
+               {SPOOL_REG_PRINTMAXXEXTENT, map_dword},
+               {SPOOL_REG_PRINTMAXYEXTENT, map_dword},
+               {SPOOL_REG_PRINTMEDIAREADY, map_multi_sz},
+               {SPOOL_REG_PRINTMEDIASUPPORTED, map_multi_sz},
+               {SPOOL_REG_PRINTMEMORY, map_dword},
+               {SPOOL_REG_PRINTMINXEXTENT, map_dword},
+               {SPOOL_REG_PRINTMINYEXTENT, map_dword},
+               {SPOOL_REG_PRINTNETWORKADDRESS, map_sz},
+               {SPOOL_REG_PRINTNOTIFY, map_sz},
+               {SPOOL_REG_PRINTNUMBERUP, map_dword},
+               {SPOOL_REG_PRINTORIENTATIONSSUPPORTED, map_multi_sz},
+               {SPOOL_REG_PRINTOWNER, map_sz},
+               {SPOOL_REG_PRINTPAGESPERMINUTE, map_dword},
+               {SPOOL_REG_PRINTRATE, map_dword},
+               {SPOOL_REG_PRINTRATEUNIT, map_sz},
+               {SPOOL_REG_PRINTSEPARATORFILE, map_sz},
+               {SPOOL_REG_PRINTSHARENAME, map_sz},
+               {SPOOL_REG_PRINTSPOOLING, map_sz},
+               {SPOOL_REG_PRINTSTAPLINGSUPPORTED, map_bool},
+               {SPOOL_REG_PRINTSTARTTIME, map_dword},
+               {SPOOL_REG_PRINTSTATUS, map_sz},
+               {SPOOL_REG_PRIORITY, map_dword},
+               {SPOOL_REG_SERVERNAME, map_sz},
+               {SPOOL_REG_SHORTSERVERNAME, map_sz},
+               {SPOOL_REG_UNCNAME, map_sz},
+               {SPOOL_REG_URL, map_sz},
+               {SPOOL_REG_VERSIONNUMBER, map_dword},
                {NULL, NULL}
        };
        int i;
@@ -242,11 +261,12 @@ static void map_regval_to_ads(TALLOC_CTX *ctx, ADS_MODLIST *mods,
 WERROR get_remote_printer_publishing_data(struct cli_state *cli, 
                                          TALLOC_CTX *mem_ctx,
                                          ADS_MODLIST *mods,
-                                         char *printer)
+                                         const char *printer)
 {
        WERROR result;
        char *printername, *servername;
        REGVAL_CTR dsdriver_ctr, dsspooler_ctr;
+       BOOL got_dsdriver = False, got_dsspooler = False;
        uint32 needed, i;
        POLICY_HND pol;
 
@@ -267,47 +287,50 @@ WERROR get_remote_printer_publishing_data(struct cli_state *cli,
        }
        
        result = cli_spoolss_enumprinterdataex(cli, mem_ctx, 0, &needed, 
-                                              &pol, "DsDriver", NULL);
+                                              &pol, SPOOL_DSDRIVER_KEY, NULL);
 
        if (W_ERROR_V(result) == ERRmoredata)
                result = cli_spoolss_enumprinterdataex(cli, mem_ctx, needed, 
-                                                      NULL, &pol, "DsDriver",
+                                                      NULL, &pol, 
+                                                      SPOOL_DSDRIVER_KEY,
                                                       &dsdriver_ctr);
 
        if (!W_ERROR_IS_OK(result)) {
                DEBUG(3, ("Unable to do enumdataex on %s, error is %s.\n",
                          printername, dos_errstr(result)));
-               cli_spoolss_close_printer(cli, mem_ctx, &pol);
-               return result;
-       }
+       } else {
 
-       /* Have the data we need now, so start building */
-
-       for (i=0; i < dsdriver_ctr.num_values; i++)
-               map_regval_to_ads(mem_ctx, mods, dsdriver_ctr.values[i]);
+               /* Have the data we need now, so start building */
+               got_dsdriver = True;
+               for (i=0; i < dsdriver_ctr.num_values; i++)
+                       map_regval_to_ads(mem_ctx, mods, 
+                                         dsdriver_ctr.values[i]);
+       }
        
        result = cli_spoolss_enumprinterdataex(cli, mem_ctx, 0, &needed, 
-                                              &pol, "DsSpooler", NULL);
+                                              &pol, SPOOL_DSSPOOLER_KEY, 
+                                              NULL);
 
        if (W_ERROR_V(result) == ERRmoredata)
                result = cli_spoolss_enumprinterdataex(cli, mem_ctx, needed, 
-                                                      NULL, &pol, "DsSpooler",
+                                                      NULL, &pol, 
+                                                      SPOOL_DSSPOOLER_KEY,
                                                       &dsspooler_ctr);
 
        if (!W_ERROR_IS_OK(result)) {
                DEBUG(3, ("Unable to do enumdataex on %s, error is %s.\n",
                          printername, dos_errstr(result)));
-               regval_ctr_destroy(&dsdriver_ctr);
-               cli_spoolss_close_printer(cli, mem_ctx, &pol);
-               return result;
+       } else {
+               got_dsspooler = True;
+               for (i=0; i < dsspooler_ctr.num_values; i++)
+                       map_regval_to_ads(mem_ctx, mods, 
+                                         dsspooler_ctr.values[i]);
        }
-       for (i=0; i < dsspooler_ctr.num_values; i++)
-               map_regval_to_ads(mem_ctx, mods, dsspooler_ctr.values[i]);
        
-       ads_mod_str(mem_ctx, mods, "printerName", printername);
+       ads_mod_str(mem_ctx, mods, SPOOL_REG_PRINTERNAME, printer);
 
-       regval_ctr_destroy(&dsdriver_ctr);
-       regval_ctr_destroy(&dsspooler_ctr);
+       if (got_dsdriver) regval_ctr_destroy(&dsdriver_ctr);
+       if (got_dsspooler) regval_ctr_destroy(&dsspooler_ctr);
        cli_spoolss_close_printer(cli, mem_ctx, &pol);
 
        return result;
@@ -328,4 +351,3 @@ BOOL get_local_printer_publishing_data(TALLOC_CTX *mem_ctx,
 }
 
 #endif
-