RIP BOOL. Convert BOOL -> bool. I found a few interesting
[samba.git] / source3 / client / smbmount.c
index 18af824c1fd5c9c65bc4c4fe12cefc7a7462c6e3..95adc9a8f233c4b77413621ebbb5e1757a565cca 100644 (file)
@@ -1,12 +1,11 @@
 /* 
-   Unix SMB/Netbios implementation.
-   Version 2.0.
+   Unix SMB/CIFS implementation.
    SMBFS mount program
    Copyright (C) Andrew Tridgell 1999
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-#define NO_SYSLOG
-
 #include "includes.h"
 
 #include <mntent.h>
 #include <asm/types.h>
 #include <linux/smb_fs.h>
 
-/* Uncomment this to allow debug the mount.smb daemon */
-/* WARNING!  This option is incompatible with autofs/automount because
-       it does not close the stdout pipe back to the automount
-       process, which automount depends on.  This will cause automount
-       to hang!  Use with caution! */
-/* #define SMBFS_DEBUG 1 */
-
-extern struct in_addr ipzero;
-extern int DEBUGLEVEL;
-
-extern BOOL in_client;
+extern bool in_client;
 extern pstring user_socket_options;
+extern char *optarg;
+extern int optind;
 
+static pstring credentials;
 static pstring my_netbios_name;
 static pstring password;
 static pstring username;
 static pstring workgroup;
 static pstring mpoint;
 static pstring service;
+static pstring options;
 
 static struct in_addr dest_ip;
-static BOOL have_ip;
-static int smb_port = 139;
-static BOOL got_pass;
+static bool have_ip;
+static int smb_port = 0;
+static bool got_user;
+static bool got_pass;
 static uid_t mount_uid;
 static gid_t mount_gid;
 static int mount_ro;
 static unsigned mount_fmask;
 static unsigned mount_dmask;
+static bool use_kerberos;
+/* TODO: Add code to detect smbfs version in kernel */
+static bool status32_smbfs = False;
+static bool smbfs_has_unicode = False;
+static bool smbfs_has_lfs = False;
 
 static void usage(void);
 
@@ -72,8 +68,8 @@ static void daemonize(void)
 
        signal( SIGTERM, exit_parent );
 
-       if ((child_pid = fork()) < 0) {
-               fprintf(stderr,"could not fork\n");
+       if ((child_pid = sys_fork()) < 0) {
+               DEBUG(0,("could not fork\n"));
        }
 
        if (child_pid > 0) {
@@ -87,8 +83,12 @@ static void daemonize(void)
                        }
                        break;
                }
+
                /* If we get here - the child exited with some error status */
-               exit(status);
+               if (WIFSIGNALED(status))
+                       exit(128 + WTERMSIG(status));
+               else
+                       exit(WEXITSTATUS(status));
        }
 
        signal( SIGTERM, SIG_DFL );
@@ -98,8 +98,12 @@ static void daemonize(void)
 static void close_our_files(int client_fd)
 {
        int i;
-       for (i = 0; i < 256; i++) {
-               if (i == client_fd) continue;
+       struct rlimit limits;
+
+       getrlimit(RLIMIT_NOFILE,&limits);
+       for (i = 0; i< limits.rlim_max; i++) {
+               if (i == client_fd)
+                       continue;
                close(i);
        }
 }
@@ -113,23 +117,22 @@ static void usr1_handler(int x)
 /***************************************************** 
 return a connection to a server
 *******************************************************/
-static struct cli_state *do_connection(char *service)
+static struct cli_state *do_connection(char *the_service)
 {
        struct cli_state *c;
        struct nmb_name called, calling;
        char *server_n;
        struct in_addr ip;
-       extern struct in_addr ipzero;
        pstring server;
        char *share;
 
-       if (service[0] != '\\' || service[1] != '\\') {
+       if (the_service[0] != '\\' || the_service[1] != '\\') {
                usage();
                exit(1);
        }
 
-       pstrcpy(server, service+2);
-       share = strchr(server,'\\');
+       pstrcpy(server, the_service+2);
+       share = strchr_m(server,'\\');
        if (!share) {
                usage();
                exit(1);
@@ -138,26 +141,43 @@ static struct cli_state *do_connection(char *service)
        share++;
 
        server_n = server;
-       
-       ip = ipzero;
 
        make_nmb_name(&calling, my_netbios_name, 0x0);
        make_nmb_name(&called , server, 0x20);
 
  again:
-       ip = ipzero;
+        zero_ip_v4(&ip);
        if (have_ip) ip = dest_ip;
 
        /* have to open a new connection */
-       if (!(c=cli_initialise(NULL)) || (cli_set_port(c, smb_port) == 0) ||
-           !cli_connect(c, server_n, &ip)) {
-               fprintf(stderr,"Connection to %s failed\n", server_n);
+       if (!(c=cli_initialise()) || (cli_set_port(c, smb_port) != smb_port) ||
+           !NT_STATUS_IS_OK(cli_connect(c, server_n, &ip))) {
+               DEBUG(0,("%d: Connection to %s failed\n", sys_getpid(), server_n));
+               if (c) {
+                       cli_shutdown(c);
+               }
                return NULL;
        }
 
+       /* SPNEGO doesn't work till we get NTSTATUS error support */
+       /* But it is REQUIRED for kerberos authentication */
+       if(!use_kerberos) c->use_spnego = False;
+
+       /* The kernel doesn't yet know how to sign it's packets */
+       c->sign_info.allow_smb_signing = False;
+
+       /* Use kerberos authentication if specified */
+       c->use_kerberos = use_kerberos;
+
        if (!cli_session_request(c, &calling, &called)) {
-               fprintf(stderr, "session request to %s failed\n", called.name);
+               char *p;
+               DEBUG(0,("%d: session request to %s failed (%s)\n", 
+                        sys_getpid(), called.name, cli_errstr(c)));
                cli_shutdown(c);
+               if ((p=strchr_m(called.name, '.'))) {
+                       *p = 0;
+                       goto again;
+               }
                if (strcmp(called.name, "*SMBSERVER")) {
                        make_nmb_name(&called , "*SMBSERVER", 0x20);
                        goto again;
@@ -165,10 +185,10 @@ static struct cli_state *do_connection(char *service)
                return NULL;
        }
 
-       DEBUG(4,(" session request ok\n"));
+       DEBUG(4,("%d: session request ok\n", sys_getpid()));
 
        if (!cli_negprot(c)) {
-               fprintf(stderr, "protocol negotiation failed\n");
+               DEBUG(0,("%d: protocol negotiation failed\n", sys_getpid()));
                cli_shutdown(c);
                return NULL;
        }
@@ -180,24 +200,45 @@ static struct cli_state *do_connection(char *service)
                }
        }
 
-       if (!cli_session_setup(c, username, 
-                              password, strlen(password),
-                              password, strlen(password),
-                              workgroup)) {
-               fprintf(stderr, "session setup failed: %s\n", cli_errstr(c));
-               return NULL;
+       /* This should be right for current smbfs. Future versions will support
+         large files as well as unicode and oplocks. */
+       c->capabilities &= ~(CAP_NT_SMBS | CAP_NT_FIND | CAP_LEVEL_II_OPLOCKS);
+       if (!smbfs_has_lfs)
+               c->capabilities &= ~CAP_LARGE_FILES;
+       if (!smbfs_has_unicode)
+               c->capabilities &= ~CAP_UNICODE;
+       if (!status32_smbfs) {
+               c->capabilities &= ~CAP_STATUS32;
+               c->force_dos_errors = True;
+       }
+
+       if (!NT_STATUS_IS_OK(cli_session_setup(c, username, 
+                                              password, strlen(password),
+                                              password, strlen(password),
+                                              workgroup))) {
+               /* if a password was not supplied then try again with a
+                       null username */
+               if (password[0] || !username[0] ||
+                   !NT_STATUS_IS_OK(cli_session_setup(c, "", "", 0, "", 0, workgroup))) {
+                       DEBUG(0,("%d: session setup failed: %s\n",
+                               sys_getpid(), cli_errstr(c)));
+                       cli_shutdown(c);
+                       return NULL;
+               }
+               DEBUG(0,("Anonymous login successful\n"));
        }
 
-       DEBUG(4,(" session setup ok\n"));
+       DEBUG(4,("%d: session setup ok\n", sys_getpid()));
 
        if (!cli_send_tconX(c, share, "?????",
                            password, strlen(password)+1)) {
-               fprintf(stderr,"tree connect failed: %s\n", cli_errstr(c));
+               DEBUG(0,("%d: tree connect failed: %s\n",
+                        sys_getpid(), cli_errstr(c)));
                cli_shutdown(c);
                return NULL;
        }
 
-       DEBUG(4,(" tconx ok\n"));
+       DEBUG(4,("%d: tconx ok\n", sys_getpid()));
 
        got_pass = True;
 
@@ -226,29 +267,29 @@ static void smb_umount(char *mount_point)
                the lights to exit anyways...
        */
         if (umount(mount_point) != 0) {
-                fprintf(stderr, "Could not umount %s: %s\n",
-                        mount_point, strerror(errno));
+                DEBUG(0,("%d: Could not umount %s: %s\n",
+                        sys_getpid(), mount_point, strerror(errno)));
                 return;
         }
 
         if ((fd = open(MOUNTED"~", O_RDWR|O_CREAT|O_EXCL, 0600)) == -1) {
-                fprintf(stderr, "Can't get "MOUNTED"~ lock file");
+                DEBUG(0,("%d: Can't get "MOUNTED"~ lock file", sys_getpid()));
                 return;
         }
 
         close(fd);
        
         if ((mtab = setmntent(MOUNTED, "r")) == NULL) {
-                fprintf(stderr, "Can't open " MOUNTED ": %s\n",
-                        strerror(errno));
+                DEBUG(0,("%d: Can't open " MOUNTED ": %s\n",
+                        sys_getpid(), strerror(errno)));
                 return;
         }
 
 #define MOUNTED_TMP MOUNTED".tmp"
 
         if ((new_mtab = setmntent(MOUNTED_TMP, "w")) == NULL) {
-                fprintf(stderr, "Can't open " MOUNTED_TMP ": %s\n",
-                        strerror(errno));
+                DEBUG(0,("%d: Can't open " MOUNTED_TMP ": %s\n",
+                        sys_getpid(), strerror(errno)));
                 endmntent(mtab);
                 return;
         }
@@ -262,21 +303,21 @@ static void smb_umount(char *mount_point)
         endmntent(mtab);
 
         if (fchmod (fileno (new_mtab), S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
-                fprintf(stderr, "Error changing mode of %s: %s\n",
-                        MOUNTED_TMP, strerror(errno));
+                DEBUG(0,("%d: Error changing mode of %s: %s\n",
+                        sys_getpid(), MOUNTED_TMP, strerror(errno)));
                 return;
         }
 
         endmntent(new_mtab);
 
         if (rename(MOUNTED_TMP, MOUNTED) < 0) {
-                fprintf(stderr, "Cannot rename %s to %s: %s\n",
-                        MOUNTED, MOUNTED_TMP, strerror(errno));
+                DEBUG(0,("%d: Cannot rename %s to %s: %s\n",
+                        sys_getpid(), MOUNTED, MOUNTED_TMP, strerror(errno)));
                 return;
         }
 
         if (unlink(MOUNTED"~") == -1) {
-                fprintf(stderr, "Can't remove "MOUNTED"~");
+                DEBUG(0,("%d: Can't remove "MOUNTED"~", sys_getpid()));
                 return;
         }
 }
@@ -288,7 +329,7 @@ static void smb_umount(char *mount_point)
  * not exit after open_sockets() or send_login() errors,
  * as the smbfs mount would then have no way to recover.
  */
-static void send_fs_socket(char *service, char *mount_point, struct cli_state *c)
+static void send_fs_socket(char *the_service, char *mount_point, struct cli_state *c)
 {
        int fd, closed = 0, res = 1;
        pid_t parentpid = getppid();
@@ -298,9 +339,10 @@ static void send_fs_socket(char *service, char *mount_point, struct cli_state *c
 
        while (1) {
                if ((fd = open(mount_point, O_RDONLY)) < 0) {
-                       fprintf(stderr, "mount.smbfs: can't open %s\n", mount_point);
+                       DEBUG(0,("mount.smbfs[%d]: can't open %s\n",
+                                sys_getpid(), mount_point));
                        break;
-               }               
+               }
 
                conn_options.fd = c->fd;
                conn_options.protocol = c->protocol;
@@ -317,7 +359,9 @@ static void send_fs_socket(char *service, char *mount_point, struct cli_state *c
 
                res = ioctl(fd, SMB_IOC_NEWCONN, &conn_options);
                if (res != 0) {
-                       fprintf(stderr, "mount.smbfs: ioctl failed, res=%d\n", res);
+                       DEBUG(0,("mount.smbfs[%d]: ioctl failed, res=%d\n",
+                                sys_getpid(), res));
+                       close(fd);
                        break;
                }
 
@@ -332,54 +376,66 @@ static void send_fs_socket(char *service, char *mount_point, struct cli_state *c
 
                close(fd);
 
-#ifndef SMBFS_DEBUG
-               /* Close all open files if we haven't done so yet. */
+               /* This looks wierd but we are only closing the userspace
+                  side, the connection has already been passed to smbfs and 
+                  it has increased the usage count on the socket.
+
+                  If we don't do this we will "leak" sockets and memory on
+                  each reconnection we have to make. */
+               c->smb_rw_error = DO_NOT_DO_TDIS;
+               cli_shutdown(c);
+               c = NULL;
+
                if (!closed) {
-                       extern FILE *dbf;
+                       /* close the name cache so that close_our_files() doesn't steal its FD */
+                       namecache_shutdown();
+
+                       /* redirect stdout & stderr since we can't know that
+                          the library functions we use are using DEBUG. */
+                       if ( (fd = open("/dev/null", O_WRONLY)) < 0)
+                               DEBUG(2,("mount.smbfs: can't open /dev/null\n"));
+                       close_our_files(fd);
+                       if (fd >= 0) {
+                               dup2(fd, STDOUT_FILENO);
+                               dup2(fd, STDERR_FILENO);
+                               close(fd);
+                       }
+
+                       /* here we are no longer interactive */
+                       set_remote_machine_name("smbmount", False);     /* sneaky ... */
+                       setup_logging("mount.smbfs", False);
+                       reopen_logs();
+                       DEBUG(0, ("mount.smbfs: entering daemon mode for service %s, pid=%d\n", the_service, sys_getpid()));
+
                        closed = 1;
-                       dbf = NULL;
-                       close_our_files(c?c->fd:-1);
                }
-#endif
 
-               /* Wait for a signal from smbfs ... */
-               CatchSignal(SIGUSR1, &usr1_handler);
-               pause();
-#ifdef SMBFS_DEBUG
-               DEBUG(2,("mount.smbfs: got signal, getting new socket\n"));
-#endif
-               c = do_connection(service);
+               /* Wait for a signal from smbfs ... but don't continue
+                   until we actually get a new connection. */
+               while (!c) {
+                       CatchSignal(SIGUSR1, &usr1_handler);
+                       pause();
+                       DEBUG(2,("mount.smbfs[%d]: got signal, getting new socket\n", sys_getpid()));
+                       c = do_connection(the_service);
+               }
        }
 
        smb_umount(mount_point);
-       DEBUG(2,("mount.smbfs: exit\n"));
+       DEBUG(2,("mount.smbfs[%d]: exit\n", sys_getpid()));
        exit(1);
 }
 
-/*********************************************************
-a strdup with exit
-**********************************************************/
-static char *xstrdup(char *s)
-{
-       s = strdup(s);
-       if (!s) {
-               fprintf(stderr,"out of memory\n");
-               exit(1);
-       }
-       return s;
-}
-
 
-/****************************************************************************
-mount smbfs
-****************************************************************************/
+/**
+ * Mount a smbfs
+ **/
 static void init_mount(void)
 {
-       char mount_point[MAXPATHLEN+1];
+       char mount_point[PATH_MAX+1];
        pstring tmp;
        pstring svc2;
        struct cli_state *c;
-       char *args[20];
+       const char *args[20];
        int i, status;
 
        if (realpath(mpoint, mount_point) == NULL) {
@@ -417,34 +473,47 @@ static void init_mount(void)
                args[i++] = "-r";
        }
        if (mount_uid) {
-               slprintf(tmp, sizeof(tmp), "%d", mount_uid);
+               slprintf(tmp, sizeof(tmp)-1, "%d", mount_uid);
                args[i++] = "-u";
-               args[i++] = xstrdup(tmp);
+               args[i++] = smb_xstrdup(tmp);
        }
        if (mount_gid) {
-               slprintf(tmp, sizeof(tmp), "%d", mount_gid);
+               slprintf(tmp, sizeof(tmp)-1, "%d", mount_gid);
                args[i++] = "-g";
-               args[i++] = xstrdup(tmp);
+               args[i++] = smb_xstrdup(tmp);
        }
        if (mount_fmask) {
-               slprintf(tmp, sizeof(tmp), "0%o", mount_fmask);
+               slprintf(tmp, sizeof(tmp)-1, "0%o", mount_fmask);
                args[i++] = "-f";
-               args[i++] = xstrdup(tmp);
+               args[i++] = smb_xstrdup(tmp);
        }
        if (mount_dmask) {
-               slprintf(tmp, sizeof(tmp), "0%o", mount_dmask);
+               slprintf(tmp, sizeof(tmp)-1, "0%o", mount_dmask);
                args[i++] = "-d";
-               args[i++] = xstrdup(tmp);
+               args[i++] = smb_xstrdup(tmp);
+       }
+       if (options) {
+               args[i++] = "-o";
+               args[i++] = options;
        }
 
-       if (fork() == 0) {
-               if (file_exist(BINDIR "/smbmnt", NULL)) {
-                       execv(BINDIR "/smbmnt", args);
-                       fprintf(stderr,"execv of %s failed. Error was %s.", BINDIR "/smbmnt", strerror(errno));
+       if (sys_fork() == 0) {
+               char *smbmnt_path;
+
+               asprintf(&smbmnt_path, "%s/smbmnt", dyn_BINDIR);
+               
+               if (file_exist(smbmnt_path, NULL)) {
+                       execv(smbmnt_path, (char * const *)args);
+                       fprintf(stderr,
+                               "smbfs/init_mount: execv of %s failed. Error was %s.",
+                               smbmnt_path, strerror(errno));
                } else {
-                       execvp("smbmnt", args);
-                       fprintf(stderr,"execvp of smbmnt failed. Error was %s.", strerror(errno) );
+                       execvp("smbmnt", (char * const *)args);
+                       fprintf(stderr,
+                               "smbfs/init_mount: execv of %s failed. Error was %s.",
+                               "smbmnt", strerror(errno));
                }
+               free(smbmnt_path);
                exit(1);
        }
 
@@ -452,10 +521,15 @@ static void init_mount(void)
                fprintf(stderr,"waitpid failed: Error was %s", strerror(errno) );
                /* FIXME: do some proper error handling */
                exit(1);
-       }       
+       }
 
        if (WIFEXITED(status) && WEXITSTATUS(status) != 0) {
                fprintf(stderr,"smbmnt failed: %d\n", WEXITSTATUS(status));
+               /* FIXME: do some proper error handling */
+               exit(1);
+       } else if (WIFSIGNALED(status)) {
+               fprintf(stderr, "smbmnt killed by signal %d\n", WTERMSIG(status));
+               exit(1);
        }
 
        /* Ok...  This is the rubicon for that mount point...  At any point
@@ -467,6 +541,124 @@ static void init_mount(void)
 }
 
 
+/****************************************************************************
+get a password from a a file or file descriptor
+exit on failure (from smbclient, move to libsmb or shared .c file?)
+****************************************************************************/
+static void get_password_file(void)
+{
+       int fd = -1;
+       char *p;
+       bool close_it = False;
+       pstring spec;
+       char pass[128];
+
+       if ((p = getenv("PASSWD_FD")) != NULL) {
+               pstrcpy(spec, "descriptor ");
+               pstrcat(spec, p);
+               sscanf(p, "%d", &fd);
+               close_it = False;
+       } else if ((p = getenv("PASSWD_FILE")) != NULL) {
+               fd = sys_open(p, O_RDONLY, 0);
+               pstrcpy(spec, p);
+               if (fd < 0) {
+                       fprintf(stderr, "Error opening PASSWD_FILE %s: %s\n",
+                               spec, strerror(errno));
+                       exit(1);
+               }
+               close_it = True;
+       }
+
+       for(p = pass, *p = '\0'; /* ensure that pass is null-terminated */
+           p && p - pass < sizeof(pass);) {
+               switch (read(fd, p, 1)) {
+               case 1:
+                       if (*p != '\n' && *p != '\0') {
+                               *++p = '\0'; /* advance p, and null-terminate pass */
+                               break;
+                       }
+               case 0:
+                       if (p - pass) {
+                               *p = '\0'; /* null-terminate it, just in case... */
+                               p = NULL; /* then force the loop condition to become false */
+                               break;
+                       } else {
+                               fprintf(stderr, "Error reading password from file %s: %s\n",
+                                       spec, "empty password\n");
+                               exit(1);
+                       }
+
+               default:
+                       fprintf(stderr, "Error reading password from file %s: %s\n",
+                               spec, strerror(errno));
+                       exit(1);
+               }
+       }
+       pstrcpy(password, pass);
+       if (close_it)
+               close(fd);
+}
+
+/****************************************************************************
+get username and password from a credentials file
+exit on failure (from smbclient, move to libsmb or shared .c file?)
+****************************************************************************/
+static void read_credentials_file(char *filename)
+{
+       FILE *auth;
+       fstring buf;
+       uint16 len = 0;
+       char *ptr, *val, *param;
+
+       if ((auth=sys_fopen(filename, "r")) == NULL)
+       {
+               /* fail if we can't open the credentials file */
+               DEBUG(0,("ERROR: Unable to open credentials file!\n"));
+               exit (-1);
+       }
+
+       while (!feof(auth))
+       {
+               /* get a line from the file */
+               if (!fgets (buf, sizeof(buf), auth))
+                       continue;
+               len = strlen(buf);
+
+               if ((len) && (buf[len-1]=='\n'))
+               {
+                       buf[len-1] = '\0';
+                       len--;
+               }
+               if (len == 0)
+                       continue;
+
+               /* break up the line into parameter & value.
+                  will need to eat a little whitespace possibly */
+               param = buf;
+               if (!(ptr = strchr (buf, '=')))
+                       continue;
+               val = ptr+1;
+               *ptr = '\0';
+
+               /* eat leading white space */
+               while ((*val!='\0') && ((*val==' ') || (*val=='\t')))
+                       val++;
+
+               if (strwicmp("password", param) == 0)
+               {
+                       pstrcpy(password, val);
+                       got_pass = True;
+               }
+               else if (strwicmp("username", param) == 0) {
+                       pstrcpy(username, val);
+               }
+
+               memset(buf, 0, sizeof(buf));
+       }
+       fclose(auth);
+}
+
+
 /****************************************************************************
 usage on the program
 ****************************************************************************/
@@ -474,30 +666,40 @@ static void usage(void)
 {
        printf("Usage: mount.smbfs service mountpoint [-o options,...]\n");
 
-       printf("Version %s\n\n",VERSION);
+       printf("Version %s\n\n",SAMBA_VERSION_STRING);
+
+       printf("Please be aware that smbfs is deprecated in favor of "
+              "cifs\n\n");
 
        printf(
-"Options:
-      username=<arg>                  SMB username
-      password=<arg>                  SMB password
-      netbiosname=<arg>               source NetBIOS name
-      uid=<arg>                       mount uid or username
-      gid=<arg>                       mount gid or groupname
-      port=<arg>                      remote SMB port number
-      fmask=<arg>                     file umask
-      dmask=<arg>                     directory umask
-      debug=<arg>                     debug level
-      ip=<arg>                        destination host or IP address
-      workgroup=<arg>                 workgroup on destination
-      sockopt=<arg>                   TCP socket options
-      scope=<arg>                     NetBIOS scope
-      guest                           don't prompt for a password
-      ro                              mount read-only
-      rw                              mount read-write
-
-This command is designed to be run from within /bin/mount by giving
-the option '-t smbfs'. For example:
-  mount -t smbfs -o username=tridge,password=foobar //fjall/test /data/test
+"Options:\n\
+      username=<arg>                  SMB username\n\
+      password=<arg>                  SMB password\n\
+      credentials=<filename>          file with username/password\n\
+      krb                             use kerberos (active directory)\n\
+      netbiosname=<arg>               source NetBIOS name\n\
+      uid=<arg>                       mount uid or username\n\
+      gid=<arg>                       mount gid or groupname\n\
+      port=<arg>                      remote SMB port number\n\
+      fmask=<arg>                     file umask\n\
+      dmask=<arg>                     directory umask\n\
+      debug=<arg>                     debug level\n\
+      ip=<arg>                        destination host or IP address\n\
+      workgroup=<arg>                 workgroup on destination\n\
+      sockopt=<arg>                   TCP socket options\n\
+      scope=<arg>                     NetBIOS scope\n\
+      iocharset=<arg>                 Linux charset (iso8859-1, utf8)\n\
+      codepage=<arg>                  server codepage (cp850)\n\
+      unicode                         use unicode when communicating with server\n\
+      lfs                             large file system support\n\
+      ttl=<arg>                       dircache time to live\n\
+      guest                           don't prompt for a password\n\
+      ro                              mount read-only\n\
+      rw                              mount read-write\n\
+\n\
+This command is designed to be run from within /bin/mount by giving\n\
+the option '-t smbfs'. For example:\n\
+  mount -t smbfs -o username=tridge,password=foobar //fjall/test /data/test\n\
 ");
 }
 
@@ -514,9 +716,19 @@ static void parse_mount_smb(int argc, char **argv)
        int opt;
        char *opts;
        char *opteq;
-       extern char *optarg;
        int val;
-       extern pstring global_scope;
+       char *p;
+
+       /* FIXME: This function can silently fail if the arguments are
+        * not in the expected order.
+
+       > The arguments syntax of smbmount 2.2.3a (smbfs of Debian stable)
+       > requires that one gives "-o" before further options like username=...
+       > . Without -o, the username=.. setting is *silently* ignored. I've
+       > spent about an hour trying to find out why I couldn't log in now..
+
+       */
+
 
        if (argc < 2 || argv[1][0] == '-') {
                usage();
@@ -537,26 +749,30 @@ static void parse_mount_smb(int argc, char **argv)
                return;
        }
 
+       options[0] = 0;
+       p = options;
+
        /*
         * option parsing from nfsmount.c (util-linux-2.9u)
         */
         for (opts = strtok(optarg, ","); opts; opts = strtok(NULL, ",")) {
                DEBUG(3, ("opts: %s\n", opts));
-                if ((opteq = strchr(opts, '='))) {
+                if ((opteq = strchr_m(opts, '='))) {
                         val = atoi(opteq + 1);
                         *opteq = '\0';
 
                         if (!strcmp(opts, "username") || 
                            !strcmp(opts, "logon")) {
                                char *lp;
+                               got_user = True;
                                pstrcpy(username,opteq+1);
-                               if ((lp=strchr(username,'%'))) {
+                               if ((lp=strchr_m(username,'%'))) {
                                        *lp = 0;
                                        pstrcpy(password,lp+1);
                                        got_pass = True;
-                                       memset(strchr(opteq+1,'%')+1,'X',strlen(password));
+                                       memset(strchr_m(opteq+1,'%')+1,'X',strlen(password));
                                }
-                               if ((lp=strchr(username,'/'))) {
+                               if ((lp=strchr_m(username,'/'))) {
                                        *lp = 0;
                                        pstrcpy(workgroup,lp+1);
                                }
@@ -565,6 +781,8 @@ static void parse_mount_smb(int argc, char **argv)
                                pstrcpy(password,opteq+1);
                                got_pass = True;
                                memset(opteq+1,'X',strlen(password));
+                       } else if(!strcmp(opts, "credentials")) {
+                               pstrcpy(credentials,opteq+1);
                        } else if(!strcmp(opts, "netbiosname")) {
                                pstrcpy(my_netbios_name,opteq+1);
                        } else if(!strcmp(opts, "uid")) {
@@ -581,7 +799,7 @@ static void parse_mount_smb(int argc, char **argv)
                                DEBUGLEVEL = val;
                        } else if(!strcmp(opts, "ip")) {
                                dest_ip = *interpret_addr2(opteq+1);
-                               if (zero_ip(dest_ip)) {
+                               if (is_zero_ip_v4(dest_ip)) {
                                        fprintf(stderr,"Can't resolve address %s\n", opteq+1);
                                        exit(1);
                                }
@@ -591,10 +809,10 @@ static void parse_mount_smb(int argc, char **argv)
                        } else if(!strcmp(opts, "sockopt")) {
                                pstrcpy(user_socket_options,opteq+1);
                        } else if(!strcmp(opts, "scope")) {
-                               pstrcpy(global_scope,opteq+1);
+                               set_global_scope(opteq+1);
                        } else {
-                               usage();
-                               exit(1);
+                               slprintf(p, sizeof(pstring) - (p - options) - 1, "%s=%s,", opts, opteq+1);
+                               p += strlen(p);
                        }
                } else {
                        val = 1;
@@ -602,11 +820,31 @@ static void parse_mount_smb(int argc, char **argv)
                                fprintf(stderr, "Unhandled option: %s\n", opteq+1);
                                exit(1);
                        } else if(!strcmp(opts, "guest")) {
+                               *password = '\0';
                                got_pass = True;
+                       } else if(!strcmp(opts, "krb")) {
+#ifdef HAVE_KRB5
+
+                               use_kerberos = True;
+                               if(!status32_smbfs)
+                                       fprintf(stderr, "Warning: kerberos support will only work for samba servers\n");
+#else
+                               fprintf(stderr,"No kerberos support compiled in\n");
+                               exit(1);
+#endif
                        } else if(!strcmp(opts, "rw")) {
                                mount_ro = 0;
                        } else if(!strcmp(opts, "ro")) {
                                mount_ro = 1;
+                       } else if(!strcmp(opts, "unicode")) {
+                               smbfs_has_unicode = True;
+                       } else if(!strcmp(opts, "lfs")) {
+                               smbfs_has_lfs = True;
+                       } else {
+                               strncpy(p, opts, sizeof(pstring) - (p - options) - 1);
+                               p += strlen(opts);
+                               *p++ = ',';
+                               *p = 0;
                        }
                }
        }
@@ -615,6 +853,11 @@ static void parse_mount_smb(int argc, char **argv)
                usage();
                exit(1);
        }
+
+       if (p != options) {
+               *(p-1) = 0;     /* remove trailing , */
+               DEBUG(3,("passthrough options '%s'\n", options));
+       }
 }
 
 /****************************************************************************
@@ -622,48 +865,70 @@ static void parse_mount_smb(int argc, char **argv)
 ****************************************************************************/
  int main(int argc,char *argv[])
 {
-       extern char *optarg;
-       extern int optind;
-       static pstring servicesf = CONFIGFILE;
        char *p;
 
        DEBUGLEVEL = 1;
-       
+
+       load_case_tables();
+
+       /* here we are interactive, even if run from autofs */
        setup_logging("mount.smbfs",True);
 
-       TimeInit();
-       charset_initialise();
-       
+#if 0 /* JRA - Urban says not needed ? */
+       /* CLI_FORCE_ASCII=false makes smbmount negotiate unicode. The default
+          is to not announce any unicode capabilities as current smbfs does
+          not support it. */
+       p = getenv("CLI_FORCE_ASCII");
+       if (p && !strcmp(p, "false"))
+               unsetenv("CLI_FORCE_ASCII");
+       else
+               setenv("CLI_FORCE_ASCII", "true", 1);
+#endif
+
        in_client = True;   /* Make sure that we tell lp_load we are */
 
        if (getenv("USER")) {
                pstrcpy(username,getenv("USER"));
 
-               if ((p=strchr(username,'%'))) {
+               if ((p=strchr_m(username,'%'))) {
                        *p = 0;
                        pstrcpy(password,p+1);
                        got_pass = True;
+                       memset(strchr_m(getenv("USER"),'%')+1,'X',strlen(password));
                }
+               strupper_m(username);
        }
 
        if (getenv("PASSWD")) {
                pstrcpy(password,getenv("PASSWD"));
+               got_pass = True;
+       }
+
+       if (getenv("PASSWD_FD") || getenv("PASSWD_FILE")) {
+               get_password_file();
+               got_pass = True;
        }
 
        if (*username == 0 && getenv("LOGNAME")) {
                pstrcpy(username,getenv("LOGNAME"));
        }
 
+       if (!lp_load(dyn_CONFIGFILE,True,False,False,True)) {
+               fprintf(stderr, "Can't load %s - run testparm to debug it\n", 
+                       dyn_CONFIGFILE);
+       }
+
        parse_mount_smb(argc, argv);
 
-       DEBUG(3,("mount.smbfs started (version %s)\n", VERSION));
+       if (use_kerberos && !got_user) {
+               got_pass = True;
+       }
 
-       if (!lp_load(servicesf,True,False,False)) {
-               fprintf(stderr, "Can't load %s - run testparm to debug it\n", 
-                       servicesf);
+       if (*credentials != 0) {
+               read_credentials_file(credentials);
        }
 
-       codepage_initialise(lp_client_code_page());
+       DEBUG(3,("mount.smbfs started (version %s)\n", SAMBA_VERSION_STRING));
 
        if (*workgroup == 0) {
                pstrcpy(workgroup,lp_workgroup());
@@ -673,7 +938,7 @@ static void parse_mount_smb(int argc, char **argv)
        if (!*my_netbios_name) {
                pstrcpy(my_netbios_name, myhostname());
        }
-       strupper(my_netbios_name);
+       strupper_m(my_netbios_name);
 
        init_mount();
        return 0;