s3/smbclient: fix incorrect command tab completions
[mat/samba.git] / source3 / client / client.c
index 4a5a31ac09c51c4919b2e9d5f5d6447266aeefec..d03d1a40aed264dc3c80980c203a326a7bbdf328 100644 (file)
@@ -37,6 +37,7 @@
 #include "trans2.h"
 #include "libsmb/nmblib.h"
 #include "include/ntioctl.h"
+#include "../libcli/smb/smbXcli_base.h"
 
 #ifndef REGISTER
 #define REGISTER 0
@@ -64,10 +65,6 @@ static int cmd_help(void);
 
 #define CREATE_ACCESS_READ READ_CONTROL_ACCESS
 
-/* 30 second timeout on most commands */
-#define CLIENT_TIMEOUT (30*1000)
-#define SHORT_TIMEOUT (5*1000)
-
 /* value for unused fid field in trans2 secondary request */
 #define FID_UNUSED (0xFFFF)
 
@@ -88,6 +85,7 @@ static bool prompt = true;
 static bool recurse = false;
 static bool showacls = false;
 bool lowercase = false;
+static bool backup_intent = false;
 
 static struct sockaddr_storage dest_ss;
 static char dest_ss_str[INET6_ADDRSTRLEN];
@@ -250,7 +248,7 @@ static int readfile(uint8_t *b, int n, XFILE *f)
 
 struct push_state {
        XFILE *f;
-       SMB_OFF_T nread;
+       off_t nread;
 };
 
 static size_t push_source(uint8_t *buf, size_t n, void *priv)
@@ -426,7 +424,7 @@ static int do_cd(const char *new_dir)
        /* Use a trans2_qpathinfo to test directories for modern servers.
           Except Win9x doesn't support the qpathinfo_basic() call..... */
 
-       if (targetcli->protocol > PROTOCOL_LANMAN2 && !targetcli->win95) {
+       if (smbXcli_conn_protocol(targetcli->conn) > PROTOCOL_LANMAN2 && !targetcli->win95) {
 
                status = cli_qpathinfo_basic(targetcli, targetpath, &sbuf,
                                             &attributes);
@@ -586,12 +584,12 @@ static NTSTATUS display_finfo(struct cli_state *cli_state, struct file_info *fin
                                   afname, nt_errstr(status)));
                } else {
                        struct security_descriptor *sd = NULL;
-                       sd = cli_query_secdesc(cli_state, fnum, ctx);
-                       if (!sd) {
-                               status = cli_nt_error(cli_state);
+                       status = cli_query_secdesc(cli_state, fnum,
+                                                  ctx, &sd);
+                       if (!NT_STATUS_IS_OK(status)) {
                                DEBUG( 0, ("display_finfo() failed to "
-                                       "get security descriptor: %s",
-                                       nt_errstr(status)));
+                                          "get security descriptor: %s",
+                                          nt_errstr(status)));
                        } else {
                                display_sec_desc(sd);
                        }
@@ -1069,9 +1067,9 @@ static int do_get(const char *rname, const char *lname_in, bool reget)
        bool newhandle = false;
        struct timespec tp_start;
        uint16 attr;
-       SMB_OFF_T size;
+       off_t size;
        off_t start = 0;
-       SMB_OFF_T nread = 0;
+       off_t nread = 0;
        int rc = 0;
        struct cli_state *targetcli = NULL;
        char *targetname = NULL;
@@ -1084,7 +1082,10 @@ static int do_get(const char *rname, const char *lname_in, bool reget)
        }
 
        if (lowercase) {
-               strlower_m(lname);
+               if (!strlower_m(lname)) {
+                       d_printf("strlower_m %s failed\n", lname);
+                       return 1;
+               }
        }
 
        status = cli_resolve_path(ctx, "", auth_info, cli, rname, &targetcli,
@@ -1107,16 +1108,16 @@ static int do_get(const char *rname, const char *lname_in, bool reget)
                handle = fileno(stdout);
        } else {
                if (reget) {
-                       handle = sys_open(lname, O_WRONLY|O_CREAT, 0644);
+                       handle = open(lname, O_WRONLY|O_CREAT, 0644);
                        if (handle >= 0) {
-                               start = sys_lseek(handle, 0, SEEK_END);
+                               start = lseek(handle, 0, SEEK_END);
                                if (start == -1) {
                                        d_printf("Error seeking local file\n");
                                        return 1;
                                }
                        }
                } else {
-                       handle = sys_open(lname, O_WRONLY|O_CREAT|O_TRUNC, 0644);
+                       handle = open(lname, O_WRONLY|O_CREAT|O_TRUNC, 0644);
                }
                newhandle = true;
        }
@@ -1294,7 +1295,9 @@ static NTSTATUS do_mget(struct cli_state *cli_state, struct file_info *finfo,
 
        string_replace(finfo->name,'\\','/');
        if (lowercase) {
-               strlower_m(finfo->name);
+               if (!strlower_m(finfo->name)) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
        }
 
        if (!directory_exist(finfo->name) &&
@@ -1318,8 +1321,17 @@ static NTSTATUS do_mget(struct cli_state *cli_state, struct file_info *finfo,
                return NT_STATUS_NO_MEMORY;
        }
 
-       status = do_list(mget_mask, FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_DIRECTORY,do_mget,false, true);
-       if (!NT_STATUS_IS_OK(status)) {
+       status = do_list(mget_mask,
+                        (FILE_ATTRIBUTE_SYSTEM
+                         | FILE_ATTRIBUTE_HIDDEN
+                         | FILE_ATTRIBUTE_DIRECTORY),
+                        do_mget, false, true);
+       if (!NT_STATUS_IS_OK(status)
+        && !NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED)) {
+               /*
+                * Ignore access denied errors to ensure all permitted files are
+                * pulled down.
+                */
                return status;
        }
 
@@ -1349,6 +1361,7 @@ static int cmd_more(void)
        const char *pager;
        int fd;
        int rc = 0;
+       mode_t mask;
 
        rname = talloc_strdup(ctx, client_get_cur_dir());
        if (!rname) {
@@ -1359,7 +1372,9 @@ static int cmd_more(void)
        if (!lname) {
                return 1;
        }
+       mask = umask(S_IRWXO | S_IRWXG);
        fd = mkstemp(lname);
+       umask(mask);
        if (fd == -1) {
                d_printf("failed to create temporary file for more\n");
                return 1;
@@ -1677,7 +1692,7 @@ static int do_allinfo(const char *name)
 {
        fstring altname;
        struct timespec b_time, a_time, m_time, c_time;
-       SMB_OFF_T size;
+       off_t size;
        uint16_t mode;
        SMB_INO_T ino;
        NTTIME tmp;
@@ -1750,7 +1765,8 @@ static int do_allinfo(const char *name)
        }
 
        status = cli_ntcreate(cli, name, 0,
-                             CREATE_ACCESS_READ, 0,
+                             SEC_FILE_READ_DATA | SEC_FILE_READ_ATTRIBUTE |
+                             SEC_STD_SYNCHRONIZE, 0,
                              FILE_SHARE_READ|FILE_SHARE_WRITE
                              |FILE_SHARE_DELETE,
                              FILE_OPEN, 0x0, 0x0, &fnum);
@@ -1837,7 +1853,7 @@ static int do_put(const char *rname, const char *lname, bool reput)
        TALLOC_CTX *ctx = talloc_tos();
        uint16_t fnum;
        XFILE *f;
-       SMB_OFF_T start = 0;
+       off_t start = 0;
        int rc = 0;
        struct timespec tp_start;
        struct cli_state *targetcli;
@@ -1948,7 +1964,7 @@ static int do_put(const char *rname, const char *lname, bool reput)
 
        if (f == x_stdin) {
                cli_shutdown(cli);
-               exit(0);
+               exit(rc);
        }
 
        return rc;
@@ -2073,7 +2089,7 @@ static int cmd_select(void)
 static int file_find(struct file_list **list, const char *directory,
                      const char *expression, bool match)
 {
-       SMB_STRUCT_DIR *dir;
+       DIR *dir;
        struct file_list *entry;
         struct stat statbuf;
         int ret;
@@ -2081,7 +2097,7 @@ static int file_find(struct file_list **list, const char *directory,
        bool isdir;
        const char *dname;
 
-        dir = sys_opendir(directory);
+        dir = opendir(directory);
        if (!dir)
                return -1;
 
@@ -2110,14 +2126,14 @@ static int file_find(struct file_list **list, const char *directory,
 
                                if (ret == -1) {
                                        SAFE_FREE(path);
-                                       sys_closedir(dir);
+                                       closedir(dir);
                                        return -1;
                                }
                        }
                        entry = SMB_MALLOC_P(struct file_list);
                        if (!entry) {
                                d_printf("Out of memory in file_find\n");
-                               sys_closedir(dir);
+                               closedir(dir);
                                return -1;
                        }
                        entry->file_path = path;
@@ -2128,7 +2144,7 @@ static int file_find(struct file_list **list, const char *directory,
                }
         }
 
-       sys_closedir(dir);
+       closedir(dir);
        return 0;
 }
 
@@ -2291,12 +2307,12 @@ static int cmd_print(void)
                rname = talloc_asprintf(ctx,
                                        "%s-%d",
                                        p+1,
-                                       (int)sys_getpid());
+                                       (int)getpid());
        }
        if (strequal(lname,"-")) {
                rname = talloc_asprintf(ctx,
                                "stdin-%d",
-                               (int)sys_getpid());
+                               (int)getpid());
        }
        if (!rname) {
                return 1;
@@ -3462,11 +3478,6 @@ static int cmd_getfacl(void)
        return 0;
 }
 
-static void printf_cb(const char *buf, void *private_data)
-{
-       printf("%s", buf);
-}
-
 /****************************************************************************
  Get the EA list of a file
 ****************************************************************************/
@@ -3510,8 +3521,8 @@ static int cmd_geteas(void)
 
        for (i=0; i<num_eas; i++) {
                d_printf("%s (%d) =\n", eas[i].name, (int)eas[i].flags);
-               dump_data_cb(eas[i].value.data, eas[i].value.length, false,
-                            printf_cb, NULL);
+               dump_data_file(eas[i].value.data, eas[i].value.length, false,
+                              stdout);
                d_printf("\n");
        }
 
@@ -3904,6 +3915,62 @@ static int cmd_newer(void)
        return 0;
 }
 
+/****************************************************************************
+ Watch directory changes
+****************************************************************************/
+
+static int cmd_notify(void)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       char *name, *buf;
+       NTSTATUS status;
+       uint16_t fnum;
+
+       name = talloc_strdup(talloc_tos(), client_get_cur_dir());
+       if (name == NULL) {
+               goto fail;
+       }
+       if (!next_token_talloc(talloc_tos(), &cmd_ptr, &buf, NULL)) {
+               goto usage;
+       }
+       name = talloc_asprintf_append(name, "%s", buf);
+       if (name == NULL) {
+               goto fail;
+       }
+       status = cli_ntcreate(
+               cli, name, 0, FILE_READ_DATA, 0,
+               FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE,
+               FILE_OPEN, 0, 0, &fnum);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("Could not open file: %s\n", nt_errstr(status));
+               goto fail;
+       }
+
+       while (1) {
+               uint32_t i, num_changes;
+               struct notify_change *changes;
+
+               status = cli_notify(cli, fnum, 1000, FILE_NOTIFY_CHANGE_ALL,
+                                   true,
+                                   talloc_tos(), &num_changes, &changes);
+               if (!NT_STATUS_IS_OK(status)) {
+                       d_printf("notify returned %s\n",
+                                nt_errstr(status));
+                       goto fail;
+               }
+               for (i=0; i<num_changes; i++) {
+                       printf("%4.4x %s\n", changes[i].action,
+                              changes[i].name);
+               }
+               TALLOC_FREE(changes);
+       }
+usage:
+       d_printf("notify <file>\n");
+fail:
+       TALLOC_FREE(frame);
+       return 1;
+}
+
 /****************************************************************************
  Set the archive level.
 ****************************************************************************/
@@ -3922,6 +3989,18 @@ static int cmd_archive(void)
        return 0;
 }
 
+/****************************************************************************
+ Toggle the backup_intent state.
+****************************************************************************/
+
+static int cmd_backup(void)
+{
+       backup_intent = !backup_intent;
+       cli_set_backup_intent(cli, backup_intent);
+       DEBUG(2,("backup intent is now %s\n",backup_intent?"on":"off"));
+       return 1;
+}
+
 /****************************************************************************
  Toggle the lowercaseflag.
 ****************************************************************************/
@@ -4261,11 +4340,12 @@ static int cmd_vuid(void)
        char *buf;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
-               d_printf("Current VUID is %d\n", cli->vuid);
+               d_printf("Current VUID is %d\n",
+                        cli_state_get_uid(cli));
                return 0;
        }
 
-       cli->vuid = atoi(buf);
+       cli_state_set_uid(cli, atoi(buf));
        return 0;
 }
 
@@ -4285,9 +4365,12 @@ static int cmd_logon(void)
        }
 
        if (!next_token_talloc(ctx, &cmd_ptr,&l_password,NULL)) {
-               char *pass = getpass("Password: ");
-               if (pass) {
-                       l_password = talloc_strdup(ctx,pass);
+               char pwd[256] = {0};
+               int rc;
+
+               rc = samba_getpass("Password: ", pwd, sizeof(pwd), false, false);
+               if (rc == 0) {
+                       l_password = talloc_strdup(ctx, pwd);
                }
        }
        if (!l_password) {
@@ -4303,7 +4386,100 @@ static int cmd_logon(void)
                return -1;
        }
 
-       d_printf("Current VUID is %d\n", cli->vuid);
+       d_printf("Current VUID is %d\n", cli_state_get_uid(cli));
+       return 0;
+}
+
+/**
+ * close the session
+ */
+
+static int cmd_logoff(void)
+{
+       NTSTATUS status;
+
+       status = cli_ulogoff(cli);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("logoff failed: %s\n", nt_errstr(status));
+               return -1;
+       }
+
+       d_printf("logoff successful\n");
+       return 0;
+}
+
+
+/**
+ * tree connect (connect to a share)
+ */
+
+static int cmd_tcon(void)
+{
+       TALLOC_CTX *ctx = talloc_tos();
+       char *sharename;
+       NTSTATUS status;
+
+       if (!next_token_talloc(ctx, &cmd_ptr, &sharename, NULL)) {
+               d_printf("tcon <sharename>\n");
+               return 0;
+       }
+
+       if (!sharename) {
+               return 1;
+       }
+
+       status = cli_tree_connect(cli, sharename, "?????", "", 0);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("tcon failed: %s\n", nt_errstr(status));
+               return -1;
+       }
+
+       talloc_free(sharename);
+
+       d_printf("tcon to %s successful, tid: %u\n", sharename,
+                cli_state_get_tid(cli));
+       return 0;
+}
+
+/**
+ * tree disconnect (disconnect from a share)
+ */
+
+static int cmd_tdis(void)
+{
+       NTSTATUS status;
+
+       status = cli_tdis(cli);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("tdis failed: %s\n", nt_errstr(status));
+               return -1;
+       }
+
+       d_printf("tdis successful\n");
+       return 0;
+}
+
+
+/**
+ * get or set tid
+ */
+
+static int cmd_tid(void)
+{
+       TALLOC_CTX *ctx = talloc_tos();
+       char *tid_str;
+
+       if (!next_token_talloc(ctx, &cmd_ptr, &tid_str, NULL)) {
+               if (cli_state_has_tcon(cli)) {
+                       d_printf("current tid is %d\n", cli_state_get_tid(cli));
+               } else {
+                       d_printf("no tcon currently\n");
+               }
+       } else {
+               uint16_t tid = atoi(tid_str);
+               cli_state_set_tid(cli, tid);
+       }
+
        return 0;
 }
 
@@ -4337,7 +4513,7 @@ static int cmd_show_connect( void )
                return 1;
        }
 
-       d_printf("//%s/%s\n", targetcli->desthost, targetcli->share);
+       d_printf("//%s/%s\n", smbXcli_conn_remote_name(targetcli->conn), targetcli->share);
        return 0;
 }
 
@@ -4425,22 +4601,23 @@ static struct {
    {COMPL_NONE,COMPL_NONE}},
   {"altname",cmd_altname,"<file> show alt name",{COMPL_NONE,COMPL_NONE}},
   {"archive",cmd_archive,"<level>\n0=ignore archive bit\n1=only get archive files\n2=only get archive files and reset archive bit\n3=get all files and reset archive bit",{COMPL_NONE,COMPL_NONE}},
+  {"backup",cmd_backup,"toggle backup intent state",{COMPL_NONE,COMPL_NONE}},  
   {"blocksize",cmd_block,"blocksize <number> (default 20)",{COMPL_NONE,COMPL_NONE}},
   {"cancel",cmd_cancel,"<jobid> cancel a print queue entry",{COMPL_NONE,COMPL_NONE}},
   {"case_sensitive",cmd_setcase,"toggle the case sensitive flag to server",{COMPL_NONE,COMPL_NONE}},
   {"cd",cmd_cd,"[directory] change/report the remote directory",{COMPL_REMOTE,COMPL_NONE}},
-  {"chmod",cmd_chmod,"<src> <mode> chmod a file using UNIX permission",{COMPL_REMOTE,COMPL_REMOTE}},
-  {"chown",cmd_chown,"<src> <uid> <gid> chown a file using UNIX uids and gids",{COMPL_REMOTE,COMPL_REMOTE}},
-  {"close",cmd_close,"<fid> close a file given a fid",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"chmod",cmd_chmod,"<src> <mode> chmod a file using UNIX permission",{COMPL_REMOTE,COMPL_NONE}},
+  {"chown",cmd_chown,"<src> <uid> <gid> chown a file using UNIX uids and gids",{COMPL_REMOTE,COMPL_NONE}},
+  {"close",cmd_close,"<fid> close a file given a fid",{COMPL_REMOTE,COMPL_NONE}},
   {"del",cmd_del,"<mask> delete all matching files",{COMPL_REMOTE,COMPL_NONE}},
   {"dir",cmd_dir,"<mask> list the contents of the current directory",{COMPL_REMOTE,COMPL_NONE}},
   {"du",cmd_du,"<mask> computes the total size of the current directory",{COMPL_REMOTE,COMPL_NONE}},
   {"echo",cmd_echo,"ping the server",{COMPL_NONE,COMPL_NONE}},
   {"exit",cmd_quit,"logoff the server",{COMPL_NONE,COMPL_NONE}},
   {"get",cmd_get,"<remote name> [local name] get a file",{COMPL_REMOTE,COMPL_LOCAL}},
-  {"getfacl",cmd_getfacl,"<file name> get the POSIX ACL on a file (UNIX extensions only)",{COMPL_REMOTE,COMPL_LOCAL}},
+  {"getfacl",cmd_getfacl,"<file name> get the POSIX ACL on a file (UNIX extensions only)",{COMPL_REMOTE,COMPL_NONE}},
   {"geteas", cmd_geteas, "<file name> get the EA list of a file",
-   {COMPL_REMOTE, COMPL_LOCAL}},
+   {COMPL_REMOTE, COMPL_NONE}},
   {"hardlink",cmd_hardlink,"<src> <dest> create a Windows hard link",{COMPL_REMOTE,COMPL_REMOTE}},
   {"help",cmd_help,"[command] give help on a command",{COMPL_NONE,COMPL_NONE}},
   {"history",cmd_history,"displays the command history",{COMPL_NONE,COMPL_NONE}},
@@ -4458,6 +4635,7 @@ static struct {
   {"more",cmd_more,"<remote name> view a remote file with your pager",{COMPL_REMOTE,COMPL_NONE}},  
   {"mput",cmd_mput,"<mask> put all matching files",{COMPL_REMOTE,COMPL_NONE}},
   {"newer",cmd_newer,"<file> only mget files newer than the specified local file",{COMPL_LOCAL,COMPL_NONE}},
+  {"notify",cmd_notify,"<file>Get notified of dir changes",{COMPL_REMOTE,COMPL_NONE}},
   {"open",cmd_open,"<mask> open a file",{COMPL_REMOTE,COMPL_NONE}},
   {"posix", cmd_posix, "turn on all POSIX capabilities", {COMPL_REMOTE,COMPL_NONE}},
   {"posix_encrypt",cmd_posix_encrypt,"<domain> <user> <password> start up transport encryption",{COMPL_REMOTE,COMPL_NONE}},
@@ -4479,12 +4657,12 @@ static struct {
   {"rename",cmd_rename,"<src> <dest> rename some files",{COMPL_REMOTE,COMPL_REMOTE}},
   {"reput",cmd_reput,"<local name> [remote name] put a file restarting at end of remote file",{COMPL_LOCAL,COMPL_REMOTE}},
   {"rm",cmd_del,"<mask> delete all matching files",{COMPL_REMOTE,COMPL_NONE}},
-  {"rmdir",cmd_rmdir,"<directory> remove a directory",{COMPL_NONE,COMPL_NONE}},
+  {"rmdir",cmd_rmdir,"<directory> remove a directory",{COMPL_REMOTE,COMPL_NONE}},
   {"showacls",cmd_showacls,"toggle if ACLs are shown or not",{COMPL_NONE,COMPL_NONE}},  
   {"setea", cmd_setea, "<file name> <eaname> <eaval> Set an EA of a file",
    {COMPL_REMOTE, COMPL_LOCAL}},
-  {"setmode",cmd_setmode,"filename <setmode string> change modes of file",{COMPL_REMOTE,COMPL_NONE}},
-  {"stat",cmd_stat,"filename Do a UNIX extensions stat call on a file",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"setmode",cmd_setmode,"<file name> <setmode string> change modes of file",{COMPL_REMOTE,COMPL_NONE}},
+  {"stat",cmd_stat,"<file name> Do a UNIX extensions stat call on a file",{COMPL_REMOTE,COMPL_NONE}},
   {"symlink",cmd_symlink,"<oldname> <newname> create a UNIX symlink",{COMPL_REMOTE,COMPL_REMOTE}},
   {"tar",cmd_tar,"tar <c|x>[IXFqbgNan] current directory to/from <file name>",{COMPL_NONE,COMPL_NONE}},
   {"tarmode",cmd_tarmode,"<full|inc|reset|noreset> tar's behaviour towards archive bits",{COMPL_NONE,COMPL_NONE}},
@@ -4496,6 +4674,10 @@ static struct {
   {"logon",cmd_logon,"establish new logon",{COMPL_NONE,COMPL_NONE}},
   {"listconnect",cmd_list_connect,"list open connections",{COMPL_NONE,COMPL_NONE}},
   {"showconnect",cmd_show_connect,"display the current active connection",{COMPL_NONE,COMPL_NONE}},
+  {"tcon",cmd_tcon,"connect to a share" ,{COMPL_NONE,COMPL_NONE}},
+  {"tdis",cmd_tdis,"disconnect from a share",{COMPL_NONE,COMPL_NONE}},
+  {"tid",cmd_tid,"show or set the current tid (tree-id)",{COMPL_NONE,COMPL_NONE}},
+  {"logoff",cmd_logoff,"log off (close the session)",{COMPL_NONE,COMPL_NONE}},
   {"..",cmd_cd_oneup,"change the remote directory (up one level)",{COMPL_REMOTE,COMPL_NONE}},
 
   /* Yes, this must be here, see crh's comment above. */
@@ -4799,6 +4981,7 @@ static char **remote_completion(const char *text, int len)
 
        info.matches[0] = SMB_STRNDUP(info.matches[1], info.samelen);
        info.matches[info.count] = NULL;
+       TALLOC_FREE(ctx);
        return info.matches;
 
 cleanup:
@@ -4911,7 +5094,8 @@ static void readline_callback(void)
        static time_t last_t;
        struct timespec now;
        time_t t;
-       int ret, revents;
+       NTSTATUS status;
+       unsigned char garbage[16];
 
        clock_gettime_mono(&now);
        t = now.tv_sec;
@@ -4921,60 +5105,18 @@ static void readline_callback(void)
 
        last_t = t;
 
- again:
-
-       if (cli->fd == -1)
+       /* Ping the server to keep the connection alive using SMBecho. */
+       memset(garbage, 0xf0, sizeof(garbage));
+       status = cli_echo(cli, 1, data_blob_const(garbage, sizeof(garbage)));
+       if (NT_STATUS_IS_OK(status)) {
                return;
-
-       /* We deliberately use receive_smb_raw instead of
-          client_receive_smb as we want to receive
-          session keepalives and then drop them here.
-       */
-
-       ret = poll_intr_one_fd(cli->fd, POLLIN|POLLHUP, 0, &revents);
-
-       if ((ret > 0) && (revents & (POLLIN|POLLHUP|POLLERR))) {
-               char inbuf[CLI_SAMBA_MAX_LARGE_READX_SIZE + LARGE_WRITEX_HDR_SIZE];
-               NTSTATUS status;
-               size_t len;
-
-               status = receive_smb_raw(cli->fd, inbuf, sizeof(inbuf), 0, 0, &len);
-
-               if (!NT_STATUS_IS_OK(status)) {
-                       if (cli->fd != -1) {
-                               close(cli->fd);
-                               cli->fd = -1;
-                       }
-
-                       DEBUG(0, ("Read from server failed, maybe it closed "
-                                 "the connection: %s\n", nt_errstr(status)));
-
-                       finished = true;
-                       smb_readline_done();
-                       return;
-               }
-               if(CVAL(inbuf,0) != SMBkeepalive) {
-                       DEBUG(0, ("Read from server "
-                               "returned unexpected packet!\n"));
-                       return;
-               }
-
-               goto again;
        }
 
-       /* Ping the server to keep the connection alive using SMBecho. */
-       {
-               NTSTATUS status;
-               unsigned char garbage[16];
-               memset(garbage, 0xf0, sizeof(garbage));
-               status = cli_echo(cli, 1, data_blob_const(garbage, sizeof(garbage)));
-
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0, ("SMBecho failed. Maybe server has closed "
-                               "the connection\n"));
-                       finished = true;
-                       smb_readline_done();
-               }
+       if (!cli_state_is_connected(cli)) {
+               DEBUG(0,("SMBecho failed (%s). The connection is "
+                        "disconnected now\n", nt_errstr(status)));
+               finished = true;
+               smb_readline_done();
        }
 }
 
@@ -5102,7 +5244,7 @@ static int do_host_query(const char *query_host)
                }
        }
 
-       if (port != 139) {
+       if (port != NBT_SMB_PORT) {
 
                /* Workgroups simply don't make sense over anything
                   else but port 139... */
@@ -5111,7 +5253,8 @@ static int do_host_query(const char *query_host)
                status = cli_cm_open(talloc_tos(), NULL,
                                     have_ip ? dest_ss_str : query_host,
                                     "IPC$", auth_info, true, smb_encrypt,
-                                    max_protocol, 139, name_type, &cli);
+                                    max_protocol, NBT_SMB_PORT, name_type,
+                                    &cli);
                if (!NT_STATUS_IS_OK(status)) {
                        cli = NULL;
                }
@@ -5176,8 +5319,8 @@ static int do_message_op(struct user_auth_info *a_info)
        NTSTATUS status;
 
        status = cli_connect_nb(desthost, have_ip ? &dest_ss : NULL,
-                               port ? port : 139, name_type,
-                               lp_netbios_name(), Undefined, &cli);
+                               port ? port : NBT_SMB_PORT, name_type,
+                               lp_netbios_name(), SMB_SIGNING_DEFAULT, 0, &cli);
        if (!NT_STATUS_IS_OK(status)) {
                d_printf("Connection to %s failed. Error %s\n", desthost, nt_errstr(status));
                return 1;
@@ -5248,8 +5391,6 @@ static int do_message_op(struct user_auth_info *a_info)
        pc = poptGetContext("smbclient", argc, (const char **) argv, long_options, 0);
        poptSetOtherOptionHelp(pc, "service <password>");
 
-        lp_set_in_client(true); /* Make sure that we tell lp_load we are */
-
        while ((opt = poptGetNextOpt(pc)) != -1) {
 
                /* if the tar option has been called previouslt, now we need to eat out the leftovers */
@@ -5278,6 +5419,7 @@ static int do_message_op(struct user_auth_info *a_info)
                                                       poptGetArg(pc));
                }
 
+
                switch (opt) {
                case 'M':
                        /* Messages are sent to NetBIOS name type 0x3
@@ -5290,7 +5432,7 @@ static int do_message_op(struct user_auth_info *a_info)
                                exit(ENOMEM);
                        }
                        if( !port )
-                               port = 139;
+                               port = NBT_SMB_PORT;
                        message = true;
                        break;
                case 'I':
@@ -5378,9 +5520,9 @@ static int do_message_op(struct user_auth_info *a_info)
        }
 
        if ( override_logfile )
-               setup_logging( lp_logfile(), DEBUG_FILE );
+               setup_logging( lp_logfile(talloc_tos()), DEBUG_FILE );
 
-       if (!lp_load(get_dyn_CONFIGFILE(),true,false,false,true)) {
+       if (!lp_load_client(get_dyn_CONFIGFILE())) {
                fprintf(stderr, "%s: Can't load %s - run testparm to debug it\n",
                        argv[0], get_dyn_CONFIGFILE());
        }
@@ -5417,7 +5559,7 @@ static int do_message_op(struct user_auth_info *a_info)
        }
 
        if(new_name_resolve_order)
-               lp_set_name_resolve_order(new_name_resolve_order);
+               lp_set_cmdline("name resolve order", new_name_resolve_order);
 
        if (!tar_type && !query_host && !service && !message) {
                poptPrintUsage(pc, stderr, 0);
@@ -5425,6 +5567,7 @@ static int do_message_op(struct user_auth_info *a_info)
        }
 
        poptFreeContext(pc);
+       popt_burn_cmdline_password(argc, argv);
 
        DEBUG(3,("Client started (version %s).\n", samba_version_string()));
 
@@ -5434,10 +5577,8 @@ static int do_message_op(struct user_auth_info *a_info)
        if (tar_type) {
                if (cmdstr)
                        process_command_string(cmdstr);
-               return do_tar_op(base_directory);
-       }
-
-       if (query_host && *query_host) {
+               rc = do_tar_op(base_directory);
+       } else if (query_host && *query_host) {
                char *qhost = query_host;
                char *slash;
 
@@ -5455,15 +5596,11 @@ static int do_message_op(struct user_auth_info *a_info)
                        sscanf(p, "%x", &name_type);
                }
 
-               return do_host_query(qhost);
-       }
-
-       if (message) {
-               return do_message_op(auth_info);
-       }
-
-       if (process(base_directory)) {
-               return 1;
+               rc = do_host_query(qhost);
+       } else if (message) {
+               rc = do_message_op(auth_info);
+       } else if (process(base_directory)) {
+               rc = 1;
        }
 
        TALLOC_FREE(frame);