s3:fix a comment typo
[abartlet/samba.git/.git] / source3 / auth / auth_util.c
index cf6588ad828cfd51747280a59107d8ba5a59a557..8167a80a4fac9f65fd5815df2631224012409766 100644 (file)
@@ -22,6 +22,8 @@
 */
 
 #include "includes.h"
+#include "smbd/globals.h"
+#include "../libcli/auth/libcli_auth.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_AUTH
@@ -197,34 +199,29 @@ NTSTATUS make_user_info_map(auth_usersupplied_info **user_info,
                            DATA_BLOB *plaintext,
                            bool encrypted)
 {
+       struct smbd_server_connection *sconn = smbd_server_conn;
        const char *domain;
        NTSTATUS result;
        bool was_mapped;
        fstring internal_username;
        fstrcpy(internal_username, smb_name);
-       was_mapped = map_username(internal_username);
+       was_mapped = map_username(sconn, internal_username);
 
        DEBUG(5, ("Mapping user [%s]\\[%s] from workstation [%s]\n",
                 client_domain, smb_name, wksta_name));
 
-       /* don't allow "" as a domain, fixes a Win9X bug
-          where it doens't supply a domain for logon script
-          'net use' commands.                                 */
-
-       if ( *client_domain )
-               domain = client_domain;
-       else
-               domain = lp_workgroup();
+       domain = client_domain;
 
        /* If you connect to a Windows domain member using a bogus domain name,
         * the Windows box will map the BOGUS\user to SAMNAME\user.  Thus, if
         * the Windows box is a DC the name will become DOMAIN\user and be
         * authenticated against AD, if the Windows box is a member server but
         * not a DC the name will become WORKSTATION\user.  A standalone
-        * non-domain member box will also map to WORKSTATION\user. */
+        * non-domain member box will also map to WORKSTATION\user.
+        * This also deals with the client passing in a "" domain */
 
        if (!is_trusted_domain(domain) &&
-           !strequal(domain, get_global_sam_name()) )
+           !strequal(domain, my_sam_name()))
        {
                if (lp_map_untrusted_to_domain())
                        domain = my_sam_name();
@@ -309,8 +306,7 @@ bool make_user_info_netlogon_interactive(auth_usersupplied_info **user_info,
        unsigned char local_nt_response[24];
        unsigned char key[16];
        
-       ZERO_STRUCT(key);
-       memcpy(key, dc_sess_key, 8);
+       memcpy(key, dc_sess_key, 16);
        
        if (lm_interactive_pwd)
                memcpy(lm_pwd, lm_interactive_pwd, sizeof(lm_pwd));
@@ -330,10 +326,10 @@ bool make_user_info_netlogon_interactive(auth_usersupplied_info **user_info,
 #endif
        
        if (lm_interactive_pwd)
-               SamOEMhash(lm_pwd, key, sizeof(lm_pwd));
+               arcfour_crypt(lm_pwd, key, sizeof(lm_pwd));
        
        if (nt_interactive_pwd)
-               SamOEMhash(nt_pwd, key, sizeof(nt_pwd));
+               arcfour_crypt(nt_pwd, key, sizeof(nt_pwd));
        
 #ifdef DEBUG_PASSWORD
        DEBUG(100,("decrypt of lm owf password:"));
@@ -777,7 +773,7 @@ NTSTATUS create_local_token(auth_serversupplied_info *server_info)
 
        if (!uid_to_unix_users_sid(server_info->utok.uid, &tmp_sid)) {
                DEBUG(1,("create_local_token: Failed to create SID "
-                       "for uid %d!\n", server_info->utok.uid));
+                       "for uid %u!\n", (unsigned int)server_info->utok.uid));
        }
        add_sid_to_array_unique(server_info->ptok, &tmp_sid,
                                &server_info->ptok->user_sids,
@@ -786,7 +782,7 @@ NTSTATUS create_local_token(auth_serversupplied_info *server_info)
        for ( i=0; i<server_info->utok.ngroups; i++ ) {
                if (!gid_to_unix_groups_sid( server_info->utok.groups[i], &tmp_sid ) ) {
                        DEBUG(1,("create_local_token: Failed to create SID "
-                               "for gid %d!\n", server_info->utok.groups[i]));
+                               "for gid %u!\n", (unsigned int)server_info->utok.groups[i]));
                        continue;
                }
                add_sid_to_array_unique(server_info->ptok, &tmp_sid,
@@ -886,8 +882,9 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
                                                    &group_sids, &gids,
                                                    &num_group_sids);
                if (!NT_STATUS_IS_OK(result)) {
-                       DEBUG(10, ("enum_group_memberships failed for %s\n",
-                                  username));
+                       DEBUG(1, ("enum_group_memberships failed for %s (%s): "
+                                 "%s\n", username, sid_string_dbg(&user_sid),
+                                 nt_errstr(result)));
                        DEBUGADD(1, ("Fall back to unix user %s\n", username));
                        goto unix_user;
                }
@@ -901,6 +898,33 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
                *found_username = talloc_strdup(mem_ctx,
                                                pdb_get_username(sam_acct));
 
+               /*
+                * If the SID from lookup_name() was the guest sid, passdb knows
+                * about the mapping of guest sid to lp_guestaccount()
+                * username and will return the unix_pw info for a guest
+                * user. Use it if it's there, else lookup the *uid details
+                * using getpwnam_alloc(). See bug #6291 for details. JRA.
+                */
+
+               /* We must always assign the *uid. */
+               if (sam_acct->unix_pw == NULL) {
+                       struct passwd *pwd = getpwnam_alloc(sam_acct, *found_username );
+                       if (!pwd) {
+                               DEBUG(10, ("getpwnam_alloc failed for %s\n",
+                                       *found_username));
+                               result = NT_STATUS_NO_SUCH_USER;
+                               goto done;
+                       }
+                       result = samu_set_unix(sam_acct, pwd );
+                       if (!NT_STATUS_IS_OK(result)) {
+                               DEBUG(10, ("samu_set_unix failed for %s\n",
+                                       *found_username));
+                               result = NT_STATUS_NO_SUCH_USER;
+                               goto done;
+                       }
+               }
+               *uid = sam_acct->unix_pw->pw_uid;
+
        } else  if (sid_check_is_in_unix_users(&user_sid)) {
 
                /* This is a unix user not in passdb. We need to ask nss
@@ -917,8 +941,9 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
        unix_user:
 
                if (!sid_to_uid(&user_sid, uid)) {
-                       DEBUG(1, ("sid_to_uid for %s (%s) failed\n",
+                       DEBUG(1, ("unix_user case, sid_to_uid for %s (%s) failed\n",
                                  username, sid_string_dbg(&user_sid)));
+                       result = NT_STATUS_NO_SUCH_USER;
                        goto done;
                }
 
@@ -926,8 +951,8 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
 
                pass = getpwuid_alloc(tmp_ctx, *uid);
                if (pass == NULL) {
-                       DEBUG(1, ("getpwuid(%d) for user %s failed\n",
-                                 *uid, username));
+                       DEBUG(1, ("getpwuid(%u) for user %s failed\n",
+                                 (unsigned int)*uid, username));
                        goto done;
                }
 
@@ -971,6 +996,14 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
 
                uint32 dummy;
 
+               /* We must always assign the *uid. */
+               if (!sid_to_uid(&user_sid, uid)) {
+                       DEBUG(1, ("winbindd case, sid_to_uid for %s (%s) failed\n",
+                                 username, sid_string_dbg(&user_sid)));
+                       result = NT_STATUS_NO_SUCH_USER;
+                       goto done;
+               }
+
                num_group_sids = 1;
                group_sids = TALLOC_ARRAY(tmp_ctx, DOM_SID, num_group_sids);
                if (group_sids == NULL) {
@@ -1013,7 +1046,7 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username,
 
                if ( !gid_to_unix_groups_sid( gids[i], &unix_group_sid ) ) {
                        DEBUG(1,("create_token_from_username: Failed to create SID "
-                               "for gid %d!\n", gids[i]));
+                               "for gid %u!\n", (unsigned int)gids[i]));
                        continue;
                }
                result = add_sid_to_array_unique(tmp_ctx, &unix_group_sid,
@@ -1456,6 +1489,7 @@ static NTSTATUS fill_sam_account(TALLOC_CTX *mem_ctx,
                                 struct samu *account,
                                 bool *username_was_mapped)
 {
+       struct smbd_server_connection *sconn = smbd_server_conn;
        NTSTATUS nt_status;
        fstring dom_user, lower_username;
        fstring real_username;
@@ -1469,7 +1503,7 @@ static NTSTATUS fill_sam_account(TALLOC_CTX *mem_ctx,
 
        /* Get the passwd struct.  Try to create the account is necessary. */
 
-       *username_was_mapped = map_username( dom_user );
+       *username_was_mapped = map_username(sconn, dom_user);
 
        if ( !(passwd = smb_getpwnam( NULL, dom_user, real_username, True )) )
                return NT_STATUS_NO_SUCH_USER;
@@ -2133,7 +2167,7 @@ bool make_auth_methods(struct auth_context *auth_context, auth_methods **auth_me
  * Verify whether or not given domain is trusted.
  *
  * @param domain_name name of the domain to be verified
- * @return true if domain is one of the trusted once or
+ * @return true if domain is one of the trusted ones or
  *         false if otherwise
  **/
 
@@ -2147,6 +2181,14 @@ bool is_trusted_domain(const char* dom_name)
        if ( lp_server_role() == ROLE_STANDALONE )
                return False;
 
+       if (dom_name == NULL || dom_name[0] == '\0') {
+               return false;
+       }
+
+       if (strequal(dom_name, get_global_sam_name())) {
+               return false;
+       }
+
        /* if we are a DC, then check for a direct trust relationships */
 
        if ( IS_DC ) {