r10656: BIG merge from trunk. Features not copied over
[samba.git] / source / rpc_parse / parse_net.c
index b584673f386f65c9299c2ea6190aa01e2e82a98f..35533e360a1ed5fe3defd36cec672b59f246a289 100644 (file)
@@ -1,11 +1,11 @@
 /* 
- *  Unix SMB/Netbios implementation.
- *  Version 1.9.
+ *  Unix SMB/CIFS implementation.
  *  RPC Pipe client / server routines
  *  Copyright (C) Andrew Tridgell              1992-1997,
  *  Copyright (C) Luke Kenneth Casson Leighton 1996-1997,
  *  Copyright (C) Paul Ashton                       1997.
- *  
+ *  Copyright (C) Jean François Micouleau           2002.
+ *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
  *  the Free Software Foundation; either version 2 of the License, or
 
 #include "includes.h"
 
+#undef DBGC_CLASS
+#define DBGC_CLASS DBGC_RPC_PARSE
+
 /*******************************************************************
  Reads or writes a structure.
 ********************************************************************/
 
-static BOOL net_io_neg_flags(char *desc, NEG_FLAGS *neg, prs_struct *ps, int depth)
+static BOOL net_io_neg_flags(const char *desc, NEG_FLAGS *neg, prs_struct *ps, int depth)
 {
        if (neg == NULL)
                return False;
@@ -63,7 +66,7 @@ static void init_netinfo_3(NETLOGON_INFO_3 *info, uint32 flags, uint32 logon_att
  Reads or writes a NETLOGON_INFO_3 structure.
 ********************************************************************/
 
-static BOOL net_io_netinfo_3(char *desc,  NETLOGON_INFO_3 *info, prs_struct *ps, int depth)
+static BOOL net_io_netinfo_3(const char *desc,  NETLOGON_INFO_3 *info, prs_struct *ps, int depth)
 {
        if (info == NULL)
                return False;
@@ -107,7 +110,7 @@ static void init_netinfo_1(NETLOGON_INFO_1 *info, uint32 flags, uint32 pdc_statu
  Reads or writes a NETLOGON_INFO_1 structure.
 ********************************************************************/
 
-static BOOL net_io_netinfo_1(char *desc, NETLOGON_INFO_1 *info, prs_struct *ps, int depth)
+static BOOL net_io_netinfo_1(const char *desc, NETLOGON_INFO_1 *info, prs_struct *ps, int depth)
 {
        if (info == NULL)
                return False;
@@ -131,25 +134,24 @@ static BOOL net_io_netinfo_1(char *desc, NETLOGON_INFO_1 *info, prs_struct *ps,
 ********************************************************************/
 
 static void init_netinfo_2(NETLOGON_INFO_2 *info, uint32 flags, uint32 pdc_status,
-                               uint32 tc_status, char *trusted_dc_name)
+                               uint32 tc_status, const char *trusted_dc_name)
 {
-       int len_dc_name = strlen(trusted_dc_name);
        info->flags      = flags;
        info->pdc_status = pdc_status;
        info->ptr_trusted_dc_name = 1;
        info->tc_status  = tc_status;
 
        if (trusted_dc_name != NULL)
-               init_unistr2(&info->uni_trusted_dc_name, trusted_dc_name, len_dc_name+1);
+               init_unistr2(&info->uni_trusted_dc_name, trusted_dc_name, UNI_STR_TERMINATE);
        else
-               init_unistr2(&info->uni_trusted_dc_name, "", 1);
+               init_unistr2(&info->uni_trusted_dc_name, "", UNI_STR_TERMINATE);
 }
 
 /*******************************************************************
  Reads or writes a NETLOGON_INFO_2 structure.
 ********************************************************************/
 
-static BOOL net_io_netinfo_2(char *desc, NETLOGON_INFO_2 *info, prs_struct *ps, int depth)
+static BOOL net_io_netinfo_2(const char *desc, NETLOGON_INFO_2 *info, prs_struct *ps, int depth)
 {
        if (info == NULL)
                return False;
@@ -180,11 +182,55 @@ static BOOL net_io_netinfo_2(char *desc, NETLOGON_INFO_2 *info, prs_struct *ps,
        return True;
 }
 
+static BOOL net_io_ctrl_data_info_5(const char *desc, CTRL_DATA_INFO_5 *info, prs_struct *ps, int depth)
+{
+       if (info == NULL)
+               return False;
+               
+       prs_debug(ps, depth, desc, "net_io_ctrl_data_info_5");
+       depth++;
+       
+       if ( !prs_uint32( "function_code", ps, depth, &info->function_code ) )
+               return False;
+       
+       if(!prs_uint32("ptr_domain", ps, depth, &info->ptr_domain))
+               return False;
+               
+       if ( info->ptr_domain ) {
+               if(!smb_io_unistr2("domain", &info->domain, info->ptr_domain, ps, depth))
+                       return False;
+       }
+               
+       return True;
+}
+
+static BOOL net_io_ctrl_data_info_6(const char *desc, CTRL_DATA_INFO_6 *info, prs_struct *ps, int depth)
+{
+       if (info == NULL)
+               return False;
+               
+       prs_debug(ps, depth, desc, "net_io_ctrl_data_info_6");
+       depth++;
+       
+       if ( !prs_uint32( "function_code", ps, depth, &info->function_code ) )
+               return False;
+       
+       if(!prs_uint32("ptr_domain", ps, depth, &info->ptr_domain))
+               return False;
+               
+       if ( info->ptr_domain ) {
+               if(!smb_io_unistr2("domain", &info->domain, info->ptr_domain, ps, depth))
+                       return False;
+       }
+               
+       return True;
+}
+
 /*******************************************************************
  Reads or writes an NET_Q_LOGON_CTRL2 structure.
 ********************************************************************/
 
-BOOL net_io_q_logon_ctrl2(char *desc, NET_Q_LOGON_CTRL2 *q_l, prs_struct *ps, int depth)
+BOOL net_io_q_logon_ctrl2(const char *desc, NET_Q_LOGON_CTRL2 *q_l, prs_struct *ps, int depth)
 {
        if (q_l == NULL)
                return False;
@@ -208,9 +254,23 @@ BOOL net_io_q_logon_ctrl2(char *desc, NET_Q_LOGON_CTRL2 *q_l, prs_struct *ps, in
                return False;
        if(!prs_uint32("query_level  ", ps, depth, &q_l->query_level))
                return False;
-       if(!prs_uint32("switch_value ", ps, depth, &q_l->switch_value))
-               return False;
+       switch ( q_l->function_code ) {
+               case NETLOGON_CONTROL_REDISCOVER:
+                       if ( !net_io_ctrl_data_info_5( "ctrl_data_info5", &q_l->info.info5, ps, depth) ) 
+                               return False;
+                       break;
+                       
+               case NETLOGON_CONTROL_TC_QUERY:
+                       if ( !net_io_ctrl_data_info_6( "ctrl_data_info6", &q_l->info.info6, ps, depth) ) 
+                               return False;
+                       break;
 
+               default:
+                       DEBUG(0,("net_io_q_logon_ctrl2: unknown function_code [%d]\n",
+                               q_l->function_code));
+                       return False;
+       }
+       
        return True;
 }
 
@@ -218,16 +278,15 @@ BOOL net_io_q_logon_ctrl2(char *desc, NET_Q_LOGON_CTRL2 *q_l, prs_struct *ps, in
  Inits an NET_Q_LOGON_CTRL2 structure.
 ********************************************************************/
 
-void init_net_q_logon_ctrl2(NET_Q_LOGON_CTRL2 *q_l, char *srv_name,
+void init_net_q_logon_ctrl2(NET_Q_LOGON_CTRL2 *q_l, const char *srv_name,
                            uint32 query_level)
 {
        DEBUG(5,("init_q_logon_ctrl2\n"));
 
        q_l->function_code = 0x01;
        q_l->query_level = query_level;
-       q_l->switch_value  = 0x01;
 
-       init_unistr2(&q_l->uni_server_name, srv_name, strlen(srv_name) + 1);
+       init_unistr2(&q_l->uni_server_name, srv_name, UNI_STR_TERMINATE);
 }
 
 /*******************************************************************
@@ -237,11 +296,9 @@ void init_net_q_logon_ctrl2(NET_Q_LOGON_CTRL2 *q_l, char *srv_name,
 void init_net_r_logon_ctrl2(NET_R_LOGON_CTRL2 *r_l, uint32 query_level,
                            uint32 flags, uint32 pdc_status, 
                            uint32 logon_attempts, uint32 tc_status, 
-                           char *trusted_domain_name)
+                           const char *trusted_domain_name)
 {
-       DEBUG(5,("init_r_logon_ctrl2\n"));
-
-       r_l->switch_value  = query_level; /* should only be 0x1 */
+       r_l->switch_value  = query_level; 
 
        switch (query_level) {
        case 1:
@@ -275,7 +332,7 @@ void init_net_r_logon_ctrl2(NET_R_LOGON_CTRL2 *r_l, uint32 query_level,
  Reads or writes an NET_R_LOGON_CTRL2 structure.
 ********************************************************************/
 
-BOOL net_io_r_logon_ctrl2(char *desc, NET_R_LOGON_CTRL2 *r_l, prs_struct *ps, int depth)
+BOOL net_io_r_logon_ctrl2(const char *desc, NET_R_LOGON_CTRL2 *r_l, prs_struct *ps, int depth)
 {
        if (r_l == NULL)
                return False;
@@ -319,7 +376,7 @@ BOOL net_io_r_logon_ctrl2(char *desc, NET_R_LOGON_CTRL2 *r_l, prs_struct *ps, in
  Reads or writes an NET_Q_LOGON_CTRL structure.
 ********************************************************************/
 
-BOOL net_io_q_logon_ctrl(char *desc, NET_Q_LOGON_CTRL *q_l, prs_struct *ps, 
+BOOL net_io_q_logon_ctrl(const char *desc, NET_Q_LOGON_CTRL *q_l, prs_struct *ps, 
                         int depth)
 {
        prs_debug(ps, depth, desc, "net_io_q_logon_ctrl");
@@ -349,7 +406,7 @@ BOOL net_io_q_logon_ctrl(char *desc, NET_Q_LOGON_CTRL *q_l, prs_struct *ps,
  Inits an NET_Q_LOGON_CTRL structure.
 ********************************************************************/
 
-void init_net_q_logon_ctrl(NET_Q_LOGON_CTRL *q_l, char *srv_name,
+void init_net_q_logon_ctrl(NET_Q_LOGON_CTRL *q_l, const char *srv_name,
                           uint32 query_level)
 {
        DEBUG(5,("init_q_logon_ctrl\n"));
@@ -357,7 +414,7 @@ void init_net_q_logon_ctrl(NET_Q_LOGON_CTRL *q_l, char *srv_name,
        q_l->function_code = 0x01; /* ??? */
        q_l->query_level = query_level;
 
-       init_unistr2(&q_l->uni_server_name, srv_name, strlen(srv_name) + 1);
+       init_unistr2(&q_l->uni_server_name, srv_name, UNI_STR_TERMINATE);
 }
 
 /*******************************************************************
@@ -392,7 +449,7 @@ void init_net_r_logon_ctrl(NET_R_LOGON_CTRL *r_l, uint32 query_level,
  Reads or writes an NET_R_LOGON_CTRL structure.
 ********************************************************************/
 
-BOOL net_io_r_logon_ctrl(char *desc, NET_R_LOGON_CTRL *r_l, prs_struct *ps, 
+BOOL net_io_r_logon_ctrl(const char *desc, NET_R_LOGON_CTRL *r_l, prs_struct *ps, 
                         int depth)
 {
        prs_debug(ps, depth, desc, "net_io_r_logon_ctrl");
@@ -422,14 +479,98 @@ BOOL net_io_r_logon_ctrl(char *desc, NET_R_LOGON_CTRL *r_l, prs_struct *ps,
        return True;
 }
 
+/*******************************************************************
+ Inits an NET_R_GETDCNAME structure.
+********************************************************************/
+void init_net_q_getdcname(NET_Q_GETDCNAME *r_t, const char *logon_server,
+                         const char *domainname)
+{
+       DEBUG(5,("init_r_getdcname\n"));
+
+       r_t->ptr_logon_server = (logon_server != NULL);
+       init_unistr2(&r_t->uni_logon_server, logon_server, UNI_STR_TERMINATE);
+       r_t->ptr_domainname = (domainname != NULL);
+       init_unistr2(&r_t->uni_domainname, domainname, UNI_STR_TERMINATE);
+}
+
+/*******************************************************************
+ Reads or writes an NET_Q_GETDCNAME structure.
+********************************************************************/
+
+BOOL net_io_q_getdcname(const char *desc, NET_Q_GETDCNAME *r_t, prs_struct *ps,
+                       int depth)
+{
+       if (r_t == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "net_io_q_getdcname");
+       depth++;
+
+       if (!prs_uint32("ptr_logon_server", ps, depth, &r_t->ptr_logon_server))
+               return False;
+
+       if (!smb_io_unistr2("logon_server", &r_t->uni_logon_server,
+                           r_t->ptr_logon_server, ps, depth))
+               return False;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("ptr_domainname", ps, depth, &r_t->ptr_domainname))
+               return False;
+
+       if (!smb_io_unistr2("domainname", &r_t->uni_domainname,
+                           r_t->ptr_domainname, ps, depth))
+               return False;
+
+       return True;
+}
+
+
+/*******************************************************************
+ Inits an NET_R_GETDCNAME structure.
+********************************************************************/
+void init_net_r_getdcname(NET_R_GETDCNAME *r_t, const char *dcname)
+{
+       DEBUG(5,("init_r_getdcname\n"));
+
+       init_unistr2(&r_t->uni_dcname, dcname, UNI_STR_TERMINATE);
+}
+
+/*******************************************************************
+ Reads or writes an NET_R_GETDCNAME structure.
+********************************************************************/
+
+BOOL net_io_r_getdcname(const char *desc, NET_R_GETDCNAME *r_t, prs_struct *ps,
+                       int depth)
+{
+       if (r_t == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "net_io_r_getdcname");
+       depth++;
+
+       if (!prs_uint32("ptr_dcname", ps, depth, &r_t->ptr_dcname))
+               return False;
+
+       if (!smb_io_unistr2("dcname", &r_t->uni_dcname,
+                           r_t->ptr_dcname, ps, depth))
+               return False;
+
+       if (!prs_ntstatus("status", ps, depth, &r_t->status))
+               return False;
+
+       return True;
+}
+
 /*******************************************************************
  Inits an NET_R_TRUST_DOM_LIST structure.
 ********************************************************************/
 
 void init_r_trust_dom(NET_R_TRUST_DOM_LIST *r_t,
-                       uint32 num_doms, char *dom_name)
+                       uint32 num_doms, const char *dom_name)
 {
-       int i = 0;
+       unsigned int i = 0;
 
        DEBUG(5,("init_r_trust_dom\n"));
 
@@ -443,10 +584,10 @@ void init_r_trust_dom(NET_R_TRUST_DOM_LIST *r_t,
        for (i = 0; i < num_doms; i++) {
                fstring domain_name;
                fstrcpy(domain_name, dom_name);
-               strupper(domain_name);
-               init_unistr2(&r_t->uni_trust_dom_name[i], domain_name, strlen(domain_name)+1);
+               strupper_m(domain_name);
+               init_unistr2(&r_t->uni_trust_dom_name[i], domain_name, UNI_STR_TERMINATE);
                /* the use of UNISTR2 here is non-standard. */
-               r_t->uni_trust_dom_name[i].undoc = 0x1;
+               r_t->uni_trust_dom_name[i].offset = 0x1;
        }
        
        r_t->status = NT_STATUS_OK;
@@ -456,7 +597,7 @@ void init_r_trust_dom(NET_R_TRUST_DOM_LIST *r_t,
  Reads or writes an NET_R_TRUST_DOM_LIST structure.
 ********************************************************************/
 
-BOOL net_io_r_trust_dom(char *desc, NET_R_TRUST_DOM_LIST *r_t, prs_struct *ps, int depth)
+BOOL net_io_r_trust_dom(const char *desc, NET_R_TRUST_DOM_LIST *r_t, prs_struct *ps, int depth)
 {
        uint32 value;
 
@@ -508,7 +649,7 @@ BOOL net_io_r_trust_dom(char *desc, NET_R_TRUST_DOM_LIST *r_t, prs_struct *ps, i
  Reads or writes an NET_Q_TRUST_DOM_LIST structure.
 ********************************************************************/
 
-BOOL net_io_q_trust_dom(char *desc, NET_Q_TRUST_DOM_LIST *q_l, prs_struct *ps, int depth)
+BOOL net_io_q_trust_dom(const char *desc, NET_Q_TRUST_DOM_LIST *q_l, prs_struct *ps, int depth)
 {
        if (q_l == NULL)
                 return False;
@@ -529,15 +670,15 @@ BOOL net_io_q_trust_dom(char *desc, NET_Q_TRUST_DOM_LIST *q_l, prs_struct *ps, i
 ********************************************************************/
 
 void init_q_req_chal(NET_Q_REQ_CHAL *q_c,
-                               char *logon_srv, char *logon_clnt,
-                               DOM_CHAL *clnt_chal)
+                    const char *logon_srv, const char *logon_clnt,
+                    const DOM_CHAL *clnt_chal)
 {
        DEBUG(5,("init_q_req_chal: %d\n", __LINE__));
 
        q_c->undoc_buffer = 1; /* don't know what this buffer is */
 
-       init_unistr2(&q_c->uni_logon_srv, logon_srv , strlen(logon_srv )+1);
-       init_unistr2(&q_c->uni_logon_clnt, logon_clnt, strlen(logon_clnt)+1);
+       init_unistr2(&q_c->uni_logon_srv, logon_srv , UNI_STR_TERMINATE);
+       init_unistr2(&q_c->uni_logon_clnt, logon_clnt, UNI_STR_TERMINATE);
 
        memcpy(q_c->clnt_chal.data, clnt_chal->data, sizeof(clnt_chal->data));
 
@@ -548,10 +689,8 @@ void init_q_req_chal(NET_Q_REQ_CHAL *q_c,
  Reads or writes an NET_Q_REQ_CHAL structure.
 ********************************************************************/
 
-BOOL net_io_q_req_chal(char *desc,  NET_Q_REQ_CHAL *q_c, prs_struct *ps, int depth)
+BOOL net_io_q_req_chal(const char *desc,  NET_Q_REQ_CHAL *q_c, prs_struct *ps, int depth)
 {
-       int old_align;
-
        if (q_c == NULL)
                return False;
 
@@ -569,15 +708,8 @@ BOOL net_io_q_req_chal(char *desc,  NET_Q_REQ_CHAL *q_c, prs_struct *ps, int dep
        if(!smb_io_unistr2("", &q_c->uni_logon_clnt, True, ps, depth)) /* logon client unicode string */
                return False;
 
-       old_align = ps->align;
-       ps->align = 0;
-       /* client challenge is _not_ aligned after the unicode strings */
-       if(!smb_io_chal("", &q_c->clnt_chal, ps, depth)) {
-               /* client challenge */
-               ps->align = old_align;
+       if(!smb_io_chal("", &q_c->clnt_chal, ps, depth))
                return False;
-       }
-       ps->align = old_align;
 
        return True;
 }
@@ -586,7 +718,7 @@ BOOL net_io_q_req_chal(char *desc,  NET_Q_REQ_CHAL *q_c, prs_struct *ps, int dep
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_r_req_chal(char *desc, NET_R_REQ_CHAL *r_c, prs_struct *ps, int depth)
+BOOL net_io_r_req_chal(const char *desc, NET_R_REQ_CHAL *r_c, prs_struct *ps, int depth)
 {
        if (r_c == NULL)
                return False;
@@ -611,9 +743,8 @@ BOOL net_io_r_req_chal(char *desc, NET_R_REQ_CHAL *r_c, prs_struct *ps, int dept
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_q_auth(char *desc, NET_Q_AUTH *q_a, prs_struct *ps, int depth)
+BOOL net_io_q_auth(const char *desc, NET_Q_AUTH *q_a, prs_struct *ps, int depth)
 {
-       int old_align;
        if (q_a == NULL)
                return False;
 
@@ -625,15 +756,8 @@ BOOL net_io_q_auth(char *desc, NET_Q_AUTH *q_a, prs_struct *ps, int depth)
     
        if(!smb_io_log_info ("", &q_a->clnt_id, ps, depth)) /* client identification info */
                return False;
-       /* client challenge is _not_ aligned */
-       old_align = ps->align;
-       ps->align = 0;
-       if(!smb_io_chal("", &q_a->clnt_chal, ps, depth)) {
-               /* client-calculated credentials */
-               ps->align = old_align;
+       if(!smb_io_chal("", &q_a->clnt_chal, ps, depth))
                return False;
-       }
-       ps->align = old_align;
 
        return True;
 }
@@ -642,7 +766,7 @@ BOOL net_io_q_auth(char *desc, NET_Q_AUTH *q_a, prs_struct *ps, int depth)
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_r_auth(char *desc, NET_R_AUTH *r_a, prs_struct *ps, int depth)
+BOOL net_io_r_auth(const char *desc, NET_R_AUTH *r_a, prs_struct *ps, int depth)
 {
        if (r_a == NULL)
                return False;
@@ -667,8 +791,8 @@ BOOL net_io_r_auth(char *desc, NET_R_AUTH *r_a, prs_struct *ps, int depth)
 ********************************************************************/
 
 void init_q_auth_2(NET_Q_AUTH_2 *q_a,
-               char *logon_srv, char *acct_name, uint16 sec_chan, char *comp_name,
-               DOM_CHAL *clnt_chal, uint32 clnt_flgs)
+               const char *logon_srv, const char *acct_name, uint16 sec_chan, const char *comp_name,
+               const DOM_CHAL *clnt_chal, uint32 clnt_flgs)
 {
        DEBUG(5,("init_q_auth_2: %d\n", __LINE__));
 
@@ -683,9 +807,8 @@ void init_q_auth_2(NET_Q_AUTH_2 *q_a,
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_q_auth_2(char *desc, NET_Q_AUTH_2 *q_a, prs_struct *ps, int depth)
+BOOL net_io_q_auth_2(const char *desc, NET_Q_AUTH_2 *q_a, prs_struct *ps, int depth)
 {
-       int old_align;
        if (q_a == NULL)
                return False;
 
@@ -697,15 +820,8 @@ BOOL net_io_q_auth_2(char *desc, NET_Q_AUTH_2 *q_a, prs_struct *ps, int depth)
     
        if(!smb_io_log_info ("", &q_a->clnt_id, ps, depth)) /* client identification info */
                return False;
-       /* client challenge is _not_ aligned */
-       old_align = ps->align;
-       ps->align = 0;
-       if(!smb_io_chal("", &q_a->clnt_chal, ps, depth)) {
-               /* client-calculated credentials */
-               ps->align = old_align;
+       if(!smb_io_chal("", &q_a->clnt_chal, ps, depth))
                return False;
-       }
-       ps->align = old_align;
        if(!net_io_neg_flags("", &q_a->clnt_flgs, ps, depth))
                return False;
 
@@ -716,7 +832,7 @@ BOOL net_io_q_auth_2(char *desc, NET_Q_AUTH_2 *q_a, prs_struct *ps, int depth)
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_r_auth_2(char *desc, NET_R_AUTH_2 *r_a, prs_struct *ps, int depth)
+BOOL net_io_r_auth_2(const char *desc, NET_R_AUTH_2 *r_a, prs_struct *ps, int depth)
 {
        if (r_a == NULL)
                return False;
@@ -738,20 +854,92 @@ BOOL net_io_r_auth_2(char *desc, NET_R_AUTH_2 *r_a, prs_struct *ps, int depth)
        return True;
 }
 
+/*******************************************************************
+ Inits a NET_Q_AUTH_3 struct.
+********************************************************************/
+
+void init_q_auth_3(NET_Q_AUTH_3 *q_a,
+               const char *logon_srv, const char *acct_name, uint16 sec_chan, const char *comp_name,
+               const DOM_CHAL *clnt_chal, uint32 clnt_flgs)
+{
+       DEBUG(5,("init_q_auth_3: %d\n", __LINE__));
+
+       init_log_info(&q_a->clnt_id, logon_srv, acct_name, sec_chan, comp_name);
+       memcpy(q_a->clnt_chal.data, clnt_chal->data, sizeof(clnt_chal->data));
+       q_a->clnt_flgs.neg_flags = clnt_flgs;
+
+       DEBUG(5,("init_q_auth_3: %d\n", __LINE__));
+}
+
+/*******************************************************************
+ Reads or writes a structure.
+********************************************************************/
+
+BOOL net_io_q_auth_3(const char *desc, NET_Q_AUTH_3 *q_a, prs_struct *ps, int depth)
+{
+       if (q_a == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "net_io_q_auth_3");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+    
+       if(!smb_io_log_info ("", &q_a->clnt_id, ps, depth)) /* client identification info */
+               return False;
+       if(!smb_io_chal("", &q_a->clnt_chal, ps, depth))
+               return False;
+       if(!net_io_neg_flags("", &q_a->clnt_flgs, ps, depth))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ Reads or writes a structure.
+********************************************************************/
+
+BOOL net_io_r_auth_3(const char *desc, NET_R_AUTH_3 *r_a, prs_struct *ps, int depth)
+{
+       if (r_a == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "net_io_r_auth_3");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+    
+       if(!smb_io_chal("srv_chal", &r_a->srv_chal, ps, depth)) /* server challenge */
+               return False;
+       if(!net_io_neg_flags("srv_flgs", &r_a->srv_flgs, ps, depth))
+               return False;
+       if (!prs_uint32("unknown", ps, depth, &r_a->unknown))
+               return False;
+
+       if(!prs_ntstatus("status", ps, depth, &r_a->status))
+               return False;
+
+       return True;
+}
+
 
 /*******************************************************************
  Inits a NET_Q_SRV_PWSET.
 ********************************************************************/
 
-void init_q_srv_pwset(NET_Q_SRV_PWSET *q_s, char *logon_srv, char *sess_key, char *acct_name, 
-                uint16 sec_chan, char *comp_name, DOM_CRED *cred, char hashed_mach_pwd[16])
+void init_q_srv_pwset(NET_Q_SRV_PWSET *q_s,
+               const char *logon_srv, const char *sess_key, const char *acct_name, 
+                uint16 sec_chan, const char *comp_name,
+               DOM_CRED *cred, uchar hashed_mach_pwd[16])
 {
        unsigned char nt_cypher[16];
        
        DEBUG(5,("init_q_srv_pwset\n"));
        
        /* Process the new password. */
-       cred_hash3( nt_cypher, hashed_mach_pwd, sess_key, 1);
+       cred_hash3( nt_cypher, hashed_mach_pwd, (const unsigned char *)sess_key, 1);
 
        init_clnt_info(&q_s->clnt_id, logon_srv, acct_name, sec_chan, comp_name, cred);
 
@@ -762,7 +950,7 @@ void init_q_srv_pwset(NET_Q_SRV_PWSET *q_s, char *logon_srv, char *sess_key, cha
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_q_srv_pwset(char *desc, NET_Q_SRV_PWSET *q_s, prs_struct *ps, int depth)
+BOOL net_io_q_srv_pwset(const char *desc, NET_Q_SRV_PWSET *q_s, prs_struct *ps, int depth)
 {
        if (q_s == NULL)
                return False;
@@ -785,7 +973,7 @@ BOOL net_io_q_srv_pwset(char *desc, NET_Q_SRV_PWSET *q_s, prs_struct *ps, int de
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_r_srv_pwset(char *desc, NET_R_SRV_PWSET *r_s, prs_struct *ps, int depth)
+BOOL net_io_r_srv_pwset(const char *desc, NET_R_SRV_PWSET *r_s, prs_struct *ps, int depth)
 {
        if (r_s == NULL)
                return False;
@@ -809,9 +997,9 @@ BOOL net_io_r_srv_pwset(char *desc, NET_R_SRV_PWSET *r_s, prs_struct *ps, int de
  Init DOM_SID2 array from a string containing multiple sids
  *************************************************************************/
 
-static int init_dom_sid2s(TALLOC_CTX *ctx, char *sids_str, DOM_SID2 **ppsids)
+static int init_dom_sid2s(TALLOC_CTX *ctx, const char *sids_str, DOM_SID2 **ppsids)
 {
-       char *ptr;
+       const char *ptr;
        pstring s2;
        int count = 0;
 
@@ -823,23 +1011,27 @@ static int init_dom_sid2s(TALLOC_CTX *ctx, char *sids_str, DOM_SID2 **ppsids)
                int number;
                DOM_SID2 *sids;
 
-               /* Count the number of SIDs. */
-               for (count = 0, ptr = sids_str; 
-                 next_token(&ptr, s2, NULL, sizeof(s2)); count++)
-                       ;
+               /* Count the number of valid SIDs. */
+               for (count = 0, ptr = sids_str; next_token(&ptr, s2, NULL, sizeof(s2)); ) {
+                       DOM_SID tmpsid;
+                       if (string_to_sid(&tmpsid, s2))
+                               count++;
+               }
 
                /* Now allocate space for them. */
-               *ppsids = (DOM_SID2 *)talloc_zero(ctx, count * sizeof(DOM_SID2));
+               *ppsids = TALLOC_ZERO_ARRAY(ctx, DOM_SID2, count);
                if (*ppsids == NULL)
                        return 0;
 
                sids = *ppsids;
 
-               for (number = 0, ptr = sids_str; 
-                 next_token(&ptr, s2, NULL, sizeof(s2)); number++) {
+               for (number = 0, ptr = sids_str; next_token(&ptr, s2, NULL, sizeof(s2)); ) {
                        DOM_SID tmpsid;
-                       string_to_sid(&tmpsid, s2);
-                       init_dom_sid2(&sids[number], &tmpsid);
+                       if (string_to_sid(&tmpsid, s2)) {
+                               /* count only valid sids */
+                               init_dom_sid2(&sids[number], &tmpsid);
+                               number++;
+                       }
                }
        }
 
@@ -850,16 +1042,12 @@ static int init_dom_sid2s(TALLOC_CTX *ctx, char *sids_str, DOM_SID2 **ppsids)
  Inits a NET_ID_INFO_1 structure.
 ********************************************************************/
 
-void init_id_info1(NET_ID_INFO_1 *id, char *domain_name,
+void init_id_info1(NET_ID_INFO_1 *id, const char *domain_name,
                                uint32 param_ctrl, uint32 log_id_low, uint32 log_id_high,
-                               char *user_name, char *wksta_name,
-                               char *sess_key,
+                               const char *user_name, const char *wksta_name,
+                               const char *sess_key,
                                unsigned char lm_cypher[16], unsigned char nt_cypher[16])
 {
-       int len_domain_name = strlen(domain_name);
-       int len_user_name   = strlen(user_name  );
-       int len_wksta_name  = strlen(wksta_name );
-
        unsigned char lm_owf[16];
        unsigned char nt_owf[16];
 
@@ -867,13 +1055,9 @@ void init_id_info1(NET_ID_INFO_1 *id, char *domain_name,
 
        id->ptr_id_info1 = 1;
 
-       init_uni_hdr(&id->hdr_domain_name, len_domain_name);
-
        id->param_ctrl = param_ctrl;
        init_logon_id(&id->logon_id, log_id_low, log_id_high);
 
-       init_uni_hdr(&id->hdr_user_name, len_user_name);
-       init_uni_hdr(&id->hdr_wksta_name, len_wksta_name);
 
        if (lm_cypher && nt_cypher) {
                unsigned char key[16];
@@ -908,16 +1092,19 @@ void init_id_info1(NET_ID_INFO_1 *id, char *domain_name,
        init_owf_info(&id->lm_owf, lm_cypher);
        init_owf_info(&id->nt_owf, nt_cypher);
 
-       init_unistr2(&id->uni_domain_name, domain_name, len_domain_name);
-       init_unistr2(&id->uni_user_name, user_name, len_user_name);
-       init_unistr2(&id->uni_wksta_name, wksta_name, len_wksta_name);
+       init_unistr2(&id->uni_domain_name, domain_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&id->hdr_domain_name, &id->uni_domain_name);
+       init_unistr2(&id->uni_user_name, user_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&id->hdr_user_name, &id->uni_user_name);
+       init_unistr2(&id->uni_wksta_name, wksta_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&id->hdr_wksta_name, &id->uni_wksta_name);
 }
 
 /*******************************************************************
  Reads or writes an NET_ID_INFO_1 structure.
 ********************************************************************/
 
-static BOOL net_io_id_info1(char *desc,  NET_ID_INFO_1 *id, prs_struct *ps, int depth)
+static BOOL net_io_id_info1(const char *desc,  NET_ID_INFO_1 *id, prs_struct *ps, int depth)
 {
        if (id == NULL)
                return False;
@@ -984,45 +1171,27 @@ void init_id_info2(NET_ID_INFO_2 * id, const char *domain_name,
                   uint32 log_id_low, uint32 log_id_high,
                   const char *user_name, const char *wksta_name,
                   const uchar lm_challenge[8],
-                  const uchar * lm_chal_resp, int lm_chal_resp_len,
-                  const uchar * nt_chal_resp, int nt_chal_resp_len)
+                  const uchar * lm_chal_resp, size_t lm_chal_resp_len,
+                  const uchar * nt_chal_resp, size_t nt_chal_resp_len)
 {
-       int len_domain_name = strlen(domain_name);
-       int len_user_name   = strlen(user_name  );
-       int len_wksta_name  = strlen(wksta_name );
-       unsigned char lm_owf[24];
-       unsigned char nt_owf[128];
 
        DEBUG(5,("init_id_info2: %d\n", __LINE__));
 
        id->ptr_id_info2 = 1;
 
-       init_uni_hdr(&id->hdr_domain_name, len_domain_name);
-
        id->param_ctrl = param_ctrl;
        init_logon_id(&id->logon_id, log_id_low, log_id_high);
 
-       init_uni_hdr(&id->hdr_user_name, len_user_name);
-       init_uni_hdr(&id->hdr_wksta_name, len_wksta_name);
-
-       if (nt_chal_resp) {
-               /* oops.  can only send what-ever-it-is direct */
-               memcpy(nt_owf, nt_chal_resp, MIN(sizeof(nt_owf), nt_chal_resp_len));
-               nt_chal_resp = nt_owf;
-       }
-       if (lm_chal_resp) {
-               /* oops.  can only send what-ever-it-is direct */
-               memcpy(lm_owf, lm_chal_resp, MIN(sizeof(lm_owf), lm_chal_resp_len));
-               lm_chal_resp = lm_owf;
-       }
-
        memcpy(id->lm_chal, lm_challenge, sizeof(id->lm_chal));
        init_str_hdr(&id->hdr_nt_chal_resp, nt_chal_resp_len, nt_chal_resp_len, (nt_chal_resp != NULL) ? 1 : 0);
        init_str_hdr(&id->hdr_lm_chal_resp, lm_chal_resp_len, lm_chal_resp_len, (lm_chal_resp != NULL) ? 1 : 0);
 
-       init_unistr2(&id->uni_domain_name, domain_name, len_domain_name);
-       init_unistr2(&id->uni_user_name, user_name, len_user_name);
-       init_unistr2(&id->uni_wksta_name, wksta_name, len_wksta_name);
+       init_unistr2(&id->uni_domain_name, domain_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&id->hdr_domain_name, &id->uni_domain_name);
+       init_unistr2(&id->uni_user_name, user_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&id->hdr_user_name, &id->uni_user_name);
+       init_unistr2(&id->uni_wksta_name, wksta_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&id->hdr_wksta_name, &id->uni_wksta_name);
 
        init_string2(&id->nt_chal_resp, (const char *)nt_chal_resp, nt_chal_resp_len, nt_chal_resp_len);
        init_string2(&id->lm_chal_resp, (const char *)lm_chal_resp, lm_chal_resp_len, lm_chal_resp_len);
@@ -1033,7 +1202,7 @@ void init_id_info2(NET_ID_INFO_2 * id, const char *domain_name,
  Reads or writes an NET_ID_INFO_2 structure.
 ********************************************************************/
 
-static BOOL net_io_id_info2(char *desc,  NET_ID_INFO_2 *id, prs_struct *ps, int depth)
+static BOOL net_io_id_info2(const char *desc,  NET_ID_INFO_2 *id, prs_struct *ps, int depth)
 {
        if (id == NULL)
                return False;
@@ -1095,7 +1264,8 @@ static BOOL net_io_id_info2(char *desc,  NET_ID_INFO_2 *id, prs_struct *ps, int
 ********************************************************************/
 
 void init_sam_info(DOM_SAM_INFO *sam,
-                               char *logon_srv, char *comp_name, DOM_CRED *clnt_cred,
+                               const char *logon_srv, const char *comp_name,
+                               DOM_CRED *clnt_cred,
                                DOM_CRED *rtn_cred, uint16 logon_level,
                                NET_ID_INFO_CTR *ctr)
 {
@@ -1118,7 +1288,7 @@ void init_sam_info(DOM_SAM_INFO *sam,
  Reads or writes a DOM_SAM_INFO structure.
 ********************************************************************/
 
-static BOOL net_io_id_info_ctr(char *desc, NET_ID_INFO_CTR **pp_ctr, prs_struct *ps, int depth)
+static BOOL net_io_id_info_ctr(const char *desc, NET_ID_INFO_CTR **pp_ctr, prs_struct *ps, int depth)
 {
        NET_ID_INFO_CTR *ctr = *pp_ctr;
 
@@ -1126,7 +1296,7 @@ static BOOL net_io_id_info_ctr(char *desc, NET_ID_INFO_CTR **pp_ctr, prs_struct
        depth++;
 
        if (UNMARSHALLING(ps)) {
-               ctr = *pp_ctr = (NET_ID_INFO_CTR *)prs_alloc_mem(ps, sizeof(NET_ID_INFO_CTR));
+               ctr = *pp_ctr = PRS_ALLOC_MEM(ps, NET_ID_INFO_CTR, 1);
                if (ctr == NULL)
                        return False;
        }
@@ -1161,7 +1331,7 @@ static BOOL net_io_id_info_ctr(char *desc, NET_ID_INFO_CTR **pp_ctr, prs_struct
  Reads or writes a DOM_SAM_INFO structure.
  ********************************************************************/
 
-static BOOL smb_io_sam_info(char *desc, DOM_SAM_INFO *sam, prs_struct *ps, int depth)
+static BOOL smb_io_sam_info(const char *desc, DOM_SAM_INFO *sam, prs_struct *ps, int depth)
 {
        if (sam == NULL)
                return False;
@@ -1192,58 +1362,59 @@ static BOOL smb_io_sam_info(char *desc, DOM_SAM_INFO *sam, prs_struct *ps, int d
 }
 
 /*************************************************************************
- Init
+ Inits a NET_USER_INFO_3 structure.
+
+ This is a network logon reply packet, and contains much information about
+ the user.  This information is passed as a (very long) paramater list
+ to avoid having to link in the PASSDB code to every program that deals 
+ with this file.
  *************************************************************************/
 
-void init_net_user_info3(TALLOC_CTX *ctx, NET_USER_INFO_3 *usr, SAM_ACCOUNT *sampw,
+void init_net_user_info3(TALLOC_CTX *ctx, NET_USER_INFO_3 *usr, 
+                        uint32                user_rid,
+                        uint32                group_rid,
+
+                        const char*            user_name,
+                        const char*            full_name,
+                        const char*            home_dir,
+                        const char*            dir_drive,
+                        const char*            logon_script,
+                        const char*            profile_path,
+
+                        time_t unix_logon_time,
+                        time_t unix_logoff_time,
+                        time_t unix_kickoff_time,
+                        time_t unix_pass_last_set_time,
+                        time_t unix_pass_can_change_time,
+                        time_t unix_pass_must_change_time,
+                        
                         uint16 logon_count, uint16 bad_pw_count,
-                        uint32 num_groups, DOM_GID *gids,
-                        uint32 user_flgs, uchar *sess_key,
-                        char *logon_srv, char *logon_dom,
-                        DOM_SID *dom_sid, char *other_sids)
+                        uint32 num_groups, const DOM_GID *gids,
+                        uint32 user_flgs, uchar user_session_key[16],
+                        uchar lm_session_key[16],
+                        const char *logon_srv, const char *logon_dom,
+                        const DOM_SID *dom_sid, const char *other_sids)
 {
        /* only cope with one "other" sid, right now. */
        /* need to count the number of space-delimited sids */
-       int i;
+       unsigned int i;
        int num_other_sids = 0;
        
        NTTIME          logon_time, logoff_time, kickoff_time,
                        pass_last_set_time, pass_can_change_time,
                        pass_must_change_time;
 
-       int             len_user_name, len_full_name, len_home_dir,
-                       len_dir_drive, len_logon_script, len_profile_path;
-                       
-       const char*             user_name = pdb_get_username(sampw);
-       const char*             full_name = pdb_get_fullname(sampw);
-       const char*             home_dir  = pdb_get_homedir(sampw);
-       const char*             dir_drive = pdb_get_dirdrive(sampw);
-       const char*             logon_script = pdb_get_logon_script(sampw);
-       const char*             profile_path = pdb_get_profile_path(sampw);
-
-       int len_logon_srv    = strlen(logon_srv);
-       int len_logon_dom    = strlen(logon_dom);
-
-       len_user_name    = strlen(user_name   );
-       len_full_name    = strlen(full_name   );
-       len_home_dir     = strlen(home_dir    );
-       len_dir_drive    = strlen(dir_drive   );
-       len_logon_script = strlen(logon_script);
-       len_profile_path = strlen(profile_path);
-
-
        ZERO_STRUCTP(usr);
 
        usr->ptr_user_info = 1; /* yes, we're bothering to put USER_INFO data here */
 
-
        /* Create NTTIME structs */
-       unix_to_nt_time (&logon_time,           pdb_get_logon_time(sampw));
-       unix_to_nt_time (&logoff_time,          pdb_get_logoff_time(sampw));
-       unix_to_nt_time (&kickoff_time,         pdb_get_kickoff_time(sampw));
-       unix_to_nt_time (&pass_last_set_time,   pdb_get_pass_last_set_time(sampw));
-       unix_to_nt_time (&pass_can_change_time, pdb_get_pass_can_change_time(sampw));
-       unix_to_nt_time (&pass_must_change_time,pdb_get_pass_must_change_time(sampw));
+       unix_to_nt_time (&logon_time,            unix_logon_time);
+       unix_to_nt_time (&logoff_time,           unix_logoff_time);
+       unix_to_nt_time (&kickoff_time,          unix_kickoff_time);
+       unix_to_nt_time (&pass_last_set_time,    unix_pass_last_set_time);
+       unix_to_nt_time (&pass_can_change_time,  unix_pass_can_change_time);
+       unix_to_nt_time (&pass_must_change_time, unix_pass_must_change_time);
 
        usr->logon_time            = logon_time;
        usr->logoff_time           = logoff_time;
@@ -1252,58 +1423,65 @@ void init_net_user_info3(TALLOC_CTX *ctx, NET_USER_INFO_3 *usr, SAM_ACCOUNT *sam
        usr->pass_can_change_time  = pass_can_change_time;
        usr->pass_must_change_time = pass_must_change_time;
 
-       init_uni_hdr(&usr->hdr_user_name, len_user_name);
-       init_uni_hdr(&usr->hdr_full_name, len_full_name);
-       init_uni_hdr(&usr->hdr_logon_script, len_logon_script);
-       init_uni_hdr(&usr->hdr_profile_path, len_profile_path);
-       init_uni_hdr(&usr->hdr_home_dir, len_home_dir);
-       init_uni_hdr(&usr->hdr_dir_drive, len_dir_drive);
-
        usr->logon_count = logon_count;
        usr->bad_pw_count = bad_pw_count;
 
-       usr->user_rid = pdb_get_user_rid(sampw);
-       usr->group_rid = pdb_get_group_rid(sampw);
+       usr->user_rid = user_rid;
+       usr->group_rid = group_rid;
        usr->num_groups = num_groups;
 
        usr->buffer_groups = 1; /* indicates fill in groups, below, even if there are none */
        usr->user_flgs = user_flgs;
 
-       if (sess_key != NULL)
-               memcpy(usr->user_sess_key, sess_key, sizeof(usr->user_sess_key));
+       if (user_session_key != NULL)
+               memcpy(usr->user_sess_key, user_session_key, sizeof(usr->user_sess_key));
        else
                memset((char *)usr->user_sess_key, '\0', sizeof(usr->user_sess_key));
 
-       init_uni_hdr(&usr->hdr_logon_srv, len_logon_srv);
-       init_uni_hdr(&usr->hdr_logon_dom, len_logon_dom);
-
        usr->buffer_dom_id = dom_sid ? 1 : 0; /* yes, we're bothering to put a domain SID in */
 
-       memset((char *)usr->padding, '\0', sizeof(usr->padding));
+       memset((char *)usr->lm_sess_key, '\0', sizeof(usr->lm_sess_key));
+       memset(&usr->acct_flags, '\0', sizeof(usr->acct_flags));
+
+       for (i=0; i<7; i++) {
+               memset(&usr->unknown[i], '\0', sizeof(usr->unknown));
+       }
+
+       if (lm_session_key != NULL) {
+               memcpy(usr->lm_sess_key, lm_session_key, sizeof(usr->lm_sess_key));
+       }
 
        num_other_sids = init_dom_sid2s(ctx, other_sids, &usr->other_sids);
 
        usr->num_other_sids = num_other_sids;
        usr->buffer_other_sids = (num_other_sids != 0) ? 1 : 0; 
        
-       init_unistr2(&usr->uni_user_name, user_name, len_user_name);
-       init_unistr2(&usr->uni_full_name, full_name, len_full_name);
-       init_unistr2(&usr->uni_logon_script, logon_script, len_logon_script);
-       init_unistr2(&usr->uni_profile_path, profile_path, len_profile_path);
-       init_unistr2(&usr->uni_home_dir, home_dir, len_home_dir);
-       init_unistr2(&usr->uni_dir_drive, dir_drive, len_dir_drive);
+       init_unistr2(&usr->uni_user_name, user_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_user_name, &usr->uni_user_name);
+       init_unistr2(&usr->uni_full_name, full_name, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_full_name, &usr->uni_full_name);
+       init_unistr2(&usr->uni_logon_script, logon_script, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_logon_script, &usr->uni_logon_script);
+       init_unistr2(&usr->uni_profile_path, profile_path, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_profile_path, &usr->uni_profile_path);
+       init_unistr2(&usr->uni_home_dir, home_dir, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_home_dir, &usr->uni_home_dir);
+       init_unistr2(&usr->uni_dir_drive, dir_drive, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_dir_drive, &usr->uni_dir_drive);
 
        usr->num_groups2 = num_groups;
 
-       usr->gids = (DOM_GID *)talloc_zero(ctx,sizeof(DOM_GID) * (num_groups));
+       usr->gids = TALLOC_ZERO_ARRAY(ctx,DOM_GID,num_groups);
        if (usr->gids == NULL && num_groups>0)
                return;
 
        for (i = 0; i < num_groups; i++) 
                usr->gids[i] = gids[i]; 
                
-       init_unistr2(&usr->uni_logon_srv, logon_srv, len_logon_srv);
-       init_unistr2(&usr->uni_logon_dom, logon_dom, len_logon_dom);
+       init_unistr2(&usr->uni_logon_srv, logon_srv, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_logon_srv, &usr->uni_logon_srv);
+       init_unistr2(&usr->uni_logon_dom, logon_dom, UNI_FLAGS_NONE);
+       init_uni_hdr(&usr->hdr_logon_dom, &usr->uni_logon_dom);
 
        init_dom_sid2(&usr->dom_sid, dom_sid);
        /* "other" sids are set up above */
@@ -1317,14 +1495,15 @@ void init_net_user_info3(TALLOC_CTX *ctx, NET_USER_INFO_3 *usr, SAM_ACCOUNT *sam
  Jacobsen at HP. JRA.
 ********************************************************************/
 
-static BOOL net_io_user_info3(char *desc, NET_USER_INFO_3 *usr, prs_struct *ps, int depth, uint16 validation_level)
+BOOL net_io_user_info3(const char *desc, NET_USER_INFO_3 *usr, prs_struct *ps, 
+                      int depth, uint16 validation_level, BOOL kerb_validation_level)
 {
-       int i;
+       unsigned int i;
 
        if (usr == NULL)
                return False;
 
-       prs_debug(ps, depth, desc, "lsa_io_lsa_user_info");
+       prs_debug(ps, depth, desc, "net_io_user_info3");
        depth++;
 
        if (UNMARSHALLING(ps))
@@ -1381,7 +1560,7 @@ static BOOL net_io_user_info3(char *desc, NET_USER_INFO_3 *usr, prs_struct *ps,
        if(!prs_uint32("user_flgs     ", ps, depth, &usr->user_flgs))     /* user flags */
                return False;
 
-       if(!prs_uint8s(False, "user_sess_key", ps, depth, usr->user_sess_key, 16)) /* unused user session key */
+       if(!prs_uint8s(False, "user_sess_key", ps, depth, usr->user_sess_key, 16)) /* user session key */
                return False;
 
        if(!smb_io_unihdr("hdr_logon_srv", &usr->hdr_logon_srv, ps, depth)) /* logon server unicode string header */
@@ -1391,9 +1570,19 @@ static BOOL net_io_user_info3(char *desc, NET_USER_INFO_3 *usr, prs_struct *ps,
 
        if(!prs_uint32("buffer_dom_id ", ps, depth, &usr->buffer_dom_id)) /* undocumented logon domain id pointer */
                return False;
-       if(!prs_uint8s (False, "padding       ", ps, depth, usr->padding, 40)) /* unused padding bytes? */
+
+       if(!prs_uint8s(False, "lm_sess_key", ps, depth, usr->lm_sess_key, 8)) /* lm session key */
+               return False;
+
+       if(!prs_uint32("acct_flags ", ps, depth, &usr->acct_flags)) /* Account flags  */
                return False;
 
+       for (i = 0; i < 7; i++)
+       {
+               if (!prs_uint32("unkown", ps, depth, &usr->unknown[i])) /* unknown */
+                        return False;
+       }
+
        if (validation_level == 3) {
                if(!prs_uint32("num_other_sids", ps, depth, &usr->num_other_sids)) /* 0 - num_sids */
                        return False;
@@ -1406,6 +1595,18 @@ static BOOL net_io_user_info3(char *desc, NET_USER_INFO_3 *usr, prs_struct *ps,
                }
        }
                
+       /* get kerb validation info (not really part of user_info_3) - Guenther */
+
+       if (kerb_validation_level) {
+
+               if(!prs_uint32("ptr_res_group_dom_sid", ps, depth, &usr->ptr_res_group_dom_sid))
+                       return False;
+               if(!prs_uint32("res_group_count", ps, depth, &usr->res_group_count))
+                       return False;
+               if(!prs_uint32("ptr_res_groups", ps, depth, &usr->ptr_res_groups))
+                       return False;
+       }
+
        if(!smb_io_unistr2("uni_user_name", &usr->uni_user_name, usr->hdr_user_name.buffer, ps, depth)) /* username unicode string */
                return False;
        if(!smb_io_unistr2("uni_full_name", &usr->uni_full_name, usr->hdr_full_name.buffer, ps, depth)) /* user's full name unicode string */
@@ -1425,7 +1626,7 @@ static BOOL net_io_user_info3(char *desc, NET_USER_INFO_3 *usr, prs_struct *ps,
                return False;
 
        if (UNMARSHALLING(ps) && usr->num_groups2 > 0) {
-               usr->gids = (DOM_GID *)prs_alloc_mem(ps, sizeof(DOM_GID)*usr->num_groups2);
+               usr->gids = PRS_ALLOC_MEM(ps, DOM_GID, usr->num_groups2);
                if (usr->gids == NULL)
                        return False;
        }
@@ -1437,37 +1638,63 @@ static BOOL net_io_user_info3(char *desc, NET_USER_INFO_3 *usr, prs_struct *ps,
 
        if(!smb_io_unistr2("uni_logon_srv", &usr->uni_logon_srv, usr->hdr_logon_srv.buffer, ps, depth)) /* logon server unicode string */
                return False;
-       if(!smb_io_unistr2("uni_logon_dom", &usr->uni_logon_dom, usr->hdr_logon_srv.buffer, ps, depth)) /* logon domain unicode string */
+       if(!smb_io_unistr2("uni_logon_dom", &usr->uni_logon_dom, usr->hdr_logon_dom.buffer, ps, depth)) /* logon domain unicode string */
                return False;
 
        if(!smb_io_dom_sid2("", &usr->dom_sid, ps, depth))           /* domain SID */
                return False;
 
-       if (usr->num_other_sids) {
+       if (usr->buffer_other_sids) {
 
-               if (UNMARSHALLING(ps)) {
-                       usr->other_sids = (DOM_SID2 *)prs_alloc_mem(ps, sizeof(DOM_SID2)*usr->num_other_sids);
-                       if (usr->other_sids == NULL)
-                               return False;
+               uint32 num_other_sids = usr->num_other_sids;
+
+               if (!(usr->user_flgs & LOGON_EXTRA_SIDS)) {
+                       DEBUG(10,("net_io_user_info3: user_flgs attribute does not have LOGON_EXTRA_SIDS\n"));
+                       /* return False; */
                }
-       
-               if(!prs_uint32("num_other_groups", ps, depth, &usr->num_other_groups))
+
+               if (!prs_uint32("num_other_sids", ps, depth,
+                               &num_other_sids))
                        return False;
 
-               if (UNMARSHALLING(ps) && usr->num_other_groups > 0) {
-                       usr->other_gids = (DOM_GID *)prs_alloc_mem(ps, sizeof(DOM_GID)*usr->num_other_groups);
-                       if (usr->other_gids == NULL)
+               if (num_other_sids != usr->num_other_sids)
+                       return False;
+
+               if (UNMARSHALLING(ps)) {
+                       usr->other_sids = PRS_ALLOC_MEM(ps, DOM_SID2, usr->num_other_sids);
+                       usr->other_sids_attrib =
+                               PRS_ALLOC_MEM(ps, uint32, usr->num_other_sids);
+                                                              
+                       if ((num_other_sids != 0) &&
+                           ((usr->other_sids == NULL) ||
+                            (usr->other_sids_attrib == NULL)))
                                return False;
                }
-       
-               for (i = 0; i < usr->num_other_groups; i++) {
-                       if(!smb_io_gid("", &usr->other_gids[i], ps, depth)) /* other GIDs */
+
+               /* First the pointers to the SIDS and attributes */
+
+               depth++;
+
+               for (i=0; i<usr->num_other_sids; i++) {
+                       uint32 ptr = 1;
+
+                       if (!prs_uint32("sid_ptr", ps, depth, &ptr))
+                               return False;
+
+                       if (UNMARSHALLING(ps) && (ptr == 0))
+                               return False;
+
+                       if (!prs_uint32("attribute", ps, depth,
+                                       &usr->other_sids_attrib[i]))
                                return False;
                }
+       
                for (i = 0; i < usr->num_other_sids; i++) {
                        if(!smb_io_dom_sid2("", &usr->other_sids[i], ps, depth)) /* other domain SIDs */
                                return False;
                }
+
+               depth--;
        }
 
        return True;
@@ -1477,7 +1704,7 @@ static BOOL net_io_user_info3(char *desc, NET_USER_INFO_3 *usr, prs_struct *ps,
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_q_sam_logon(char *desc, NET_Q_SAM_LOGON *q_l, prs_struct *ps, int depth)
+BOOL net_io_q_sam_logon(const char *desc, NET_Q_SAM_LOGON *q_l, prs_struct *ps, int depth)
 {
        if (q_l == NULL)
                return False;
@@ -1491,6 +1718,9 @@ BOOL net_io_q_sam_logon(char *desc, NET_Q_SAM_LOGON *q_l, prs_struct *ps, int de
        if(!smb_io_sam_info("", &q_l->sam_id, ps, depth))
                return False;
 
+       if(!prs_align_uint16(ps))
+               return False;
+       
        if(!prs_uint16("validation_level", ps, depth, &q_l->validation_level))
                return False;
 
@@ -1501,7 +1731,7 @@ BOOL net_io_q_sam_logon(char *desc, NET_Q_SAM_LOGON *q_l, prs_struct *ps, int de
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_r_sam_logon(char *desc, NET_R_SAM_LOGON *r_l, prs_struct *ps, int depth)
+BOOL net_io_r_sam_logon(const char *desc, NET_R_SAM_LOGON *r_l, prs_struct *ps, int depth)
 {
        if (r_l == NULL)
                return False;
@@ -1511,8 +1741,10 @@ BOOL net_io_r_sam_logon(char *desc, NET_R_SAM_LOGON *r_l, prs_struct *ps, int de
 
        if(!prs_uint32("buffer_creds", ps, depth, &r_l->buffer_creds)) /* undocumented buffer pointer */
                return False;
-       if(!smb_io_cred("", &r_l->srv_creds, ps, depth)) /* server credentials.  server time stamp appears to be ignored. */
-               return False;
+       if (&r_l->buffer_creds) {
+               if(!smb_io_cred("", &r_l->srv_creds, ps, depth)) /* server credentials.  server time stamp appears to be ignored. */
+                       return False;
+       }
 
        if(!prs_uint16("switch_value", ps, depth, &r_l->switch_value))
                return False;
@@ -1520,11 +1752,11 @@ BOOL net_io_r_sam_logon(char *desc, NET_R_SAM_LOGON *r_l, prs_struct *ps, int de
                return False;
 
 #if 1 /* W2k always needs this - even for bad passwd. JRA */
-       if(!net_io_user_info3("", r_l->user, ps, depth, r_l->switch_value))
+       if(!net_io_user_info3("", r_l->user, ps, depth, r_l->switch_value, False))
                return False;
 #else
        if (r_l->switch_value != 0) {
-               if(!net_io_user_info3("", r_l->user, ps, depth, r_l->switch_value))
+               if(!net_io_user_info3("", r_l->user, ps, depth, r_l->switch_value, False))
                        return False;
        }
 #endif
@@ -1545,7 +1777,7 @@ BOOL net_io_r_sam_logon(char *desc, NET_R_SAM_LOGON *r_l, prs_struct *ps, int de
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_q_sam_logoff(char *desc,  NET_Q_SAM_LOGOFF *q_l, prs_struct *ps, int depth)
+BOOL net_io_q_sam_logoff(const char *desc,  NET_Q_SAM_LOGOFF *q_l, prs_struct *ps, int depth)
 {
        if (q_l == NULL)
                return False;
@@ -1566,7 +1798,7 @@ BOOL net_io_q_sam_logoff(char *desc,  NET_Q_SAM_LOGOFF *q_l, prs_struct *ps, int
  Reads or writes a structure.
 ********************************************************************/
 
-BOOL net_io_r_sam_logoff(char *desc, NET_R_SAM_LOGOFF *r_l, prs_struct *ps, int depth)
+BOOL net_io_r_sam_logoff(const char *desc, NET_R_SAM_LOGOFF *r_l, prs_struct *ps, int depth)
 {
        if (r_l == NULL)
                return False;
@@ -1593,12 +1825,13 @@ makes a NET_Q_SAM_SYNC structure.
 ********************************************************************/
 BOOL init_net_q_sam_sync(NET_Q_SAM_SYNC * q_s, const char *srv_name,
                          const char *cli_name, DOM_CRED *cli_creds, 
-                         DOM_CRED *ret_creds, uint32 database_id)
+                         DOM_CRED *ret_creds, uint32 database_id, 
+                        uint32 next_rid)
 {
        DEBUG(5, ("init_q_sam_sync\n"));
 
-       init_unistr2(&q_s->uni_srv_name, srv_name, strlen(srv_name) + 1);
-       init_unistr2(&q_s->uni_cli_name, cli_name, strlen(cli_name) + 1);
+       init_unistr2(&q_s->uni_srv_name, srv_name, UNI_STR_TERMINATE);
+       init_unistr2(&q_s->uni_cli_name, cli_name, UNI_STR_TERMINATE);
 
         if (cli_creds)
                 memcpy(&q_s->cli_creds, cli_creds, sizeof(q_s->cli_creds));
@@ -1610,7 +1843,7 @@ BOOL init_net_q_sam_sync(NET_Q_SAM_SYNC * q_s, const char *srv_name,
 
        q_s->database_id = database_id;
        q_s->restart_state = 0;
-       q_s->sync_context = 0;
+       q_s->sync_context = next_rid;
        q_s->max_size = 0xffff;
 
        return True;
@@ -1619,7 +1852,7 @@ BOOL init_net_q_sam_sync(NET_Q_SAM_SYNC * q_s, const char *srv_name,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-BOOL net_io_q_sam_sync(char *desc, NET_Q_SAM_SYNC * q_s, prs_struct *ps,
+BOOL net_io_q_sam_sync(const char *desc, NET_Q_SAM_SYNC * q_s, prs_struct *ps,
                       int depth)
 {
        prs_debug(ps, depth, desc, "net_io_q_sam_sync");
@@ -1651,7 +1884,7 @@ BOOL net_io_q_sam_sync(char *desc, NET_Q_SAM_SYNC * q_s, prs_struct *ps,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_delta_hdr(char *desc, SAM_DELTA_HDR * delta,
+static BOOL net_io_sam_delta_hdr(const char *desc, SAM_DELTA_HDR * delta,
                                 prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "net_io_sam_delta_hdr");
@@ -1681,7 +1914,7 @@ static BOOL net_io_sam_delta_hdr(char *desc, SAM_DELTA_HDR * delta,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_delta_stamp(char *desc, SAM_DELTA_STAMP *info,
+static BOOL net_io_sam_delta_mod_count(const char *desc, SAM_DELTA_MOD_COUNT *info,
                                    prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "net_io_sam_delta_stamp");
@@ -1705,7 +1938,7 @@ static BOOL net_io_sam_delta_stamp(char *desc, SAM_DELTA_STAMP *info,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_domain_info(char *desc, SAM_DOMAIN_INFO * info,
+static BOOL net_io_sam_domain_info(const char *desc, SAM_DOMAIN_INFO * info,
                                   prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "net_io_sam_domain_info");
@@ -1730,15 +1963,26 @@ static BOOL net_io_sam_domain_info(char *desc, SAM_DOMAIN_INFO * info,
                 return False;
        if (!smb_io_time("creation_time", &info->creation_time, ps, depth))
                 return False;
-
-       if (!smb_io_bufhdr2("hdr_sec_desc", &info->hdr_sec_desc, ps, depth))
-                return False;
-       if (!smb_io_unihdr("hdr_unknown", &info->hdr_unknown, ps, depth))
-                return False;
-
-       if (ps->data_offset + 40 > ps->buffer_size)
-                return False;
-        ps->data_offset += 40;
+       if (!prs_uint32("security_information", ps, depth, &info->security_information))
+               return False;
+       if (!smb_io_bufhdr4("hdr_sec_desc", &info->hdr_sec_desc, ps, depth))
+               return False;
+       if (!smb_io_lockout_string_hdr("hdr_account_lockout_string", &info->hdr_account_lockout, ps, depth))
+               return False;
+       if (!smb_io_unihdr("hdr_unknown2", &info->hdr_unknown2, ps, depth))
+               return False;
+       if (!smb_io_unihdr("hdr_unknown3", &info->hdr_unknown3, ps, depth))
+               return False;
+       if (!smb_io_unihdr("hdr_unknown4", &info->hdr_unknown4, ps, depth))
+               return False;
+       if (!prs_uint32("logon_chgpass", ps, depth, &info->logon_chgpass))
+               return False;
+       if (!prs_uint32("unknown6", ps, depth, &info->unknown6))
+               return False;
+       if (!prs_uint32("unknown7", ps, depth, &info->unknown7))
+               return False;
+       if (!prs_uint32("unknown8", ps, depth, &info->unknown8))
+               return False;
 
        if (!smb_io_unistr2("uni_dom_name", &info->uni_dom_name,
                             info->hdr_dom_name.buffer, ps, depth))
@@ -1747,20 +1991,30 @@ static BOOL net_io_sam_domain_info(char *desc, SAM_DOMAIN_INFO * info,
                             info->hdr_oem_info.buffer, ps, depth))
                 return False;
 
-       if (!smb_io_buffer4("buf_sec_desc", &info->buf_sec_desc,
-                            info->hdr_sec_desc.buffer, ps, depth))
-                return False;
-       if (!smb_io_unistr2("buf_unknown", &info->buf_unknown,
-                            info->hdr_unknown.buffer, ps, depth))
+       if (!smb_io_rpc_blob("buf_sec_desc", &info->buf_sec_desc, ps, depth))
                 return False;
 
+       if (!smb_io_account_lockout_str("account_lockout", &info->account_lockout, 
+                                       info->hdr_account_lockout.buffer, ps, depth))
+               return False;
+
+       if (!smb_io_unistr2("buf_unknown2", &info->buf_unknown2, 
+                           info->hdr_unknown2.buffer, ps, depth))
+               return False;
+       if (!smb_io_unistr2("buf_unknown3", &info->buf_unknown3, 
+                           info->hdr_unknown3.buffer, ps, depth))
+               return False;
+       if (!smb_io_unistr2("buf_unknown4", &info->buf_unknown4, 
+                           info->hdr_unknown4.buffer, ps, depth))
+               return False;
+
        return True;
 }
 
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_group_info(char *desc, SAM_GROUP_INFO * info,
+static BOOL net_io_sam_group_info(const char *desc, SAM_GROUP_INFO * info,
                                  prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "net_io_sam_group_info");
@@ -1785,8 +2039,7 @@ static BOOL net_io_sam_group_info(char *desc, SAM_GROUP_INFO * info,
        if (!smb_io_unistr2("uni_grp_desc", &info->uni_grp_desc,
                             info->hdr_grp_desc.buffer, ps, depth))
                 return False;
-       if (!smb_io_buffer4("buf_sec_desc", &info->buf_sec_desc,
-                            info->hdr_sec_desc.buffer, ps, depth))
+       if (!smb_io_rpc_blob("buf_sec_desc", &info->buf_sec_desc, ps, depth))
                 return False;
 
        return True;
@@ -1795,7 +2048,7 @@ static BOOL net_io_sam_group_info(char *desc, SAM_GROUP_INFO * info,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_passwd_info(char *desc, SAM_PWD * pwd,
+static BOOL net_io_sam_passwd_info(const char *desc, SAM_PWD * pwd,
                                   prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "net_io_sam_passwd_info");
@@ -1905,9 +2158,8 @@ BOOL make_sam_account_info(SAM_ACCOUNT_INFO * info,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_account_info(char *desc, uint8 sess_key[16],
-                                   SAM_ACCOUNT_INFO * info, prs_struct *ps,
-                                   int depth)
+static BOOL net_io_sam_account_info(const char *desc, SAM_ACCOUNT_INFO *info,
+                               prs_struct *ps, int depth)
 {
        BUFHDR2 hdr_priv_data;
        uint32 i;
@@ -2038,8 +2290,7 @@ static BOOL net_io_sam_account_info(char *desc, uint8 sess_key[16],
        if (!prs_uint32("unknown2", ps, depth, &info->unknown2))
                 return False;
 
-       if (!smb_io_buffer4("buf_logon_hrs", &info->buf_logon_hrs,
-                            info->ptr_logon_hrs, ps, depth))
+       if (!smb_io_rpc_blob("buf_logon_hrs", &info->buf_logon_hrs, ps, depth))
                 return False;
        prs_align(ps);
        if (!smb_io_unistr2("uni_comment", &info->uni_comment,
@@ -2057,12 +2308,12 @@ static BOOL net_io_sam_account_info(char *desc, uint8 sess_key[16],
                if (!prs_uint32("pwd_len", ps, depth, &len))
                         return False;
                old_offset = ps->data_offset;
-               if (len == 0x44)
+               if (len > 0)
                {
                        if (ps->io)
                        {
                                /* reading */
-                                if (!prs_hash1(ps, ps->data_offset, sess_key))
+                                if (!prs_hash1(ps, ps->data_offset, len))
                                         return False;
                        }
                        if (!net_io_sam_passwd_info("pass", &info->pass, 
@@ -2072,7 +2323,7 @@ static BOOL net_io_sam_account_info(char *desc, uint8 sess_key[16],
                        if (!ps->io)
                        {
                                /* writing */
-                                if (!prs_hash1(ps, old_offset, sess_key))
+                                if (!prs_hash1(ps, old_offset, len))
                                         return False;
                        }
                }
@@ -2080,8 +2331,7 @@ static BOOL net_io_sam_account_info(char *desc, uint8 sess_key[16],
                         return False;
                ps->data_offset = old_offset + len;
        }
-       if (!smb_io_buffer4("buf_sec_desc", &info->buf_sec_desc,
-                            info->hdr_sec_desc.buffer, ps, depth))
+       if (!smb_io_rpc_blob("buf_sec_desc", &info->buf_sec_desc, ps, depth))
                 return False;
        prs_align(ps);
        if (!smb_io_unistr2("uni_profile", &info->uni_profile,
@@ -2096,7 +2346,7 @@ static BOOL net_io_sam_account_info(char *desc, uint8 sess_key[16],
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_group_mem_info(char *desc, SAM_GROUP_MEM_INFO * info,
+static BOOL net_io_sam_group_mem_info(const char *desc, SAM_GROUP_MEM_INFO * info,
                                      prs_struct *ps, int depth)
 {
        uint32 i;
@@ -2129,8 +2379,7 @@ static BOOL net_io_sam_group_mem_info(char *desc, SAM_GROUP_MEM_INFO * info,
                        return False;
                }
 
-                info->rids = talloc(ps->mem_ctx, sizeof(uint32) *
-                                    info->num_members2);
+                info->rids = TALLOC_ARRAY(ps->mem_ctx, uint32, info->num_members2);
 
                 if (info->rids == NULL) {
                         DEBUG(0, ("out of memory allocating %d rids\n",
@@ -2157,8 +2406,7 @@ static BOOL net_io_sam_group_mem_info(char *desc, SAM_GROUP_MEM_INFO * info,
                        return False;
                }
 
-                info->attribs = talloc(ps->mem_ctx, sizeof(uint32) *
-                                       info->num_members3);
+                info->attribs = TALLOC_ARRAY(ps->mem_ctx, uint32, info->num_members3);
 
                 if (info->attribs == NULL) {
                         DEBUG(0, ("out of memory allocating %d attribs\n",
@@ -2180,7 +2428,7 @@ static BOOL net_io_sam_group_mem_info(char *desc, SAM_GROUP_MEM_INFO * info,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_alias_info(char *desc, SAM_ALIAS_INFO * info,
+static BOOL net_io_sam_alias_info(const char *desc, SAM_ALIAS_INFO * info,
                                  prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "net_io_sam_alias_info");
@@ -2202,12 +2450,12 @@ static BOOL net_io_sam_alias_info(char *desc, SAM_ALIAS_INFO * info,
        if (!smb_io_unistr2("uni_als_name", &info->uni_als_name,
                             info->hdr_als_name.buffer, ps, depth))
                 return False;
-       if (!smb_io_buffer4("buf_sec_desc", &info->buf_sec_desc,
-                            info->hdr_sec_desc.buffer, ps, depth))
+       if (!smb_io_rpc_blob("buf_sec_desc", &info->buf_sec_desc, ps, depth))
                 return False;
+
        if (!smb_io_unistr2("uni_als_desc", &info->uni_als_desc,
-                            info->hdr_als_name.buffer, ps, depth))
-                return False;
+                           info->hdr_als_desc.buffer, ps, depth))
+               return False;
 
        return True;
 }
@@ -2215,7 +2463,7 @@ static BOOL net_io_sam_alias_info(char *desc, SAM_ALIAS_INFO * info,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_alias_mem_info(char *desc, SAM_ALIAS_MEM_INFO * info,
+static BOOL net_io_sam_alias_mem_info(const char *desc, SAM_ALIAS_MEM_INFO * info,
                                      prs_struct *ps, int depth)
 {
        uint32 i;
@@ -2230,12 +2478,12 @@ static BOOL net_io_sam_alias_mem_info(char *desc, SAM_ALIAS_MEM_INFO * info,
        if (!prs_uint32("ptr_members", ps, depth, &info->ptr_members))
                 return False;
 
+       if (ps->data_offset + 16 > ps->buffer_size)
+               return False;
+       ps->data_offset += 16;
+
        if (info->ptr_members != 0)
        {
-                if (ps->data_offset + 16 > ps->buffer_size)
-                        return False;
-                ps->data_offset += 16;
-
                if (!prs_uint32("num_sids", ps, depth, &info->num_sids))
                         return False;
                if (info->num_sids != info->num_members)
@@ -2244,8 +2492,7 @@ static BOOL net_io_sam_alias_mem_info(char *desc, SAM_ALIAS_MEM_INFO * info,
                        return False;
                }
 
-                info->ptr_sids = talloc(ps->mem_ctx, sizeof(uint32) *
-                                        info->num_sids);
+                info->ptr_sids = TALLOC_ARRAY(ps->mem_ctx, uint32, info->num_sids);
                 
                 if (info->ptr_sids == NULL) {
                         DEBUG(0, ("out of memory allocating %d ptr_sids\n",
@@ -2260,8 +2507,7 @@ static BOOL net_io_sam_alias_mem_info(char *desc, SAM_ALIAS_MEM_INFO * info,
                                 return False;
                }
 
-                info->sids = talloc(ps->mem_ctx, sizeof(DOM_SID2) *
-                                    info->num_sids);
+                info->sids = TALLOC_ARRAY(ps->mem_ctx, DOM_SID2, info->num_sids);
 
                 if (info->sids == NULL) {
                         DEBUG(0, ("error allocating %d sids\n",
@@ -2288,83 +2534,74 @@ static BOOL net_io_sam_alias_mem_info(char *desc, SAM_ALIAS_MEM_INFO * info,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_dom_info(char *desc, SAM_DELTA_DOM *info,
+static BOOL net_io_sam_policy_info(const char *desc, SAM_DELTA_POLICY *info,
                                      prs_struct *ps, int depth)
 {
-       int i;
-
-       prs_debug(ps, depth, desc, "net_io_sam_dom_info");
+       unsigned int i;
+       prs_debug(ps, depth, desc, "net_io_sam_policy_info");
        depth++;
 
        if(!prs_align(ps))
                return False;
 
-       if (!prs_uint32("unknown1", ps, depth, &info->unknown1))
-                return False;
-       if (!prs_uint32("unknown2", ps, depth, &info->unknown2))
+       if (!prs_uint32("max_log_size", ps, depth, &info->max_log_size))
                 return False;
-       if (!prs_uint32("unknown3", ps, depth, &info->unknown3))
+       if (!prs_uint64("audit_retention_period", ps, depth,
+                       &info->audit_retention_period))
                 return False;
-       if (!prs_uint32("unknown4", ps, depth, &info->unknown4))
+       if (!prs_uint32("auditing_mode", ps, depth, &info->auditing_mode))
                 return False;
-       if (!prs_uint32("count1", ps, depth, &info->count1))
+       if (!prs_uint32("num_events", ps, depth, &info->num_events))
                 return False;
-       if (!prs_uint32("ptr1", ps, depth, &info->ptr1))
+       if (!prs_uint32("ptr_events", ps, depth, &info->ptr_events))
                 return False;
 
-       if (!prs_uint16("count2", ps, depth, &info->count2))
-                return False;
-       if (!prs_uint16("count3", ps, depth, &info->count3))
-                return False;
+       if (!smb_io_unihdr("hdr_dom_name", &info->hdr_dom_name, ps, depth))
+               return False;
 
-       if (!prs_uint32("ptr2", ps, depth, &info->ptr2))
-                return False;
-       if (!prs_uint32("ptr3", ps, depth, &info->ptr3))
+       if (!prs_uint32("sid_ptr", ps, depth, &info->sid_ptr))
                 return False;
 
-       if (!prs_uint32("unknown4b", ps, depth, &info->unknown4b))
+       if (!prs_uint32("paged_pool_limit", ps, depth, &info->paged_pool_limit))
                 return False;
-       if (!prs_uint32("unknown5", ps, depth, &info->unknown5))
+       if (!prs_uint32("non_paged_pool_limit", ps, depth,
+                       &info->non_paged_pool_limit))
                 return False;
-       if (!prs_uint32("unknown6", ps, depth, &info->unknown6))
+       if (!prs_uint32("min_workset_size", ps, depth, &info->min_workset_size))
                 return False;
-       if (!prs_uint32("unknown7", ps, depth, &info->unknown7))
+       if (!prs_uint32("max_workset_size", ps, depth, &info->max_workset_size))
                 return False;
-       if (!prs_uint32("unknown8", ps, depth, &info->unknown8))
+       if (!prs_uint32("page_file_limit", ps, depth, &info->page_file_limit))
                 return False;
-       if (!prs_uint32("unknown9", ps, depth, &info->unknown9))
+       if (!prs_uint64("time_limit", ps, depth, &info->time_limit))
                 return False;
-       if (!prs_uint32("unknown10", ps, depth, &info->unknown10))
+       if (!smb_io_time("modify_time", &info->modify_time, ps, depth))
                 return False;
-       if (!prs_uint32("unknown11", ps, depth, &info->unknown11))
+       if (!smb_io_time("create_time", &info->create_time, ps, depth))
                 return False;
-       if (!prs_uint32("unknown12", ps, depth, &info->unknown12))
+       if (!smb_io_bufhdr2("hdr_sec_desc", &info->hdr_sec_desc, ps, depth))
                 return False;
 
-       if (!prs_uint32("unknown13", ps, depth, &info->unknown13))
-                return False;
-       if (!prs_uint32("unknown14", ps, depth, &info->unknown14))
-                return False;
-       if (!prs_uint32("unknown15", ps, depth, &info->unknown15))
-                return False;
-       if (!prs_uint32("unknown16", ps, depth, &info->unknown16))
-                return False;
-       if (!prs_uint32("unknown17", ps, depth, &info->unknown17))
-                return False;
+       for (i=0; i<4; i++) {
+               UNIHDR dummy;
+               if (!smb_io_unihdr("dummy", &dummy, ps, depth))
+                       return False;
+       }
 
-       for (i=0; i<info->count2; i++)
-               if (!prs_uint32("unknown18", ps, depth, &info->unknown18))
-                       return False;
+       for (i=0; i<4; i++) {
+               uint32 reserved;
+               if (!prs_uint32("reserved", ps, depth, &reserved))
+                       return False;
+       }
 
-       if (!prs_uint32("unknown19", ps, depth, &info->unknown19))
+       if (!prs_uint32("num_event_audit_options", ps, depth,
+                       &info->num_event_audit_options))
                 return False;
 
-       for (i=0; i<info->count1; i++)
-               if (!prs_uint32("unknown20", ps, depth, &info->unknown20))
-                       return False;
-
-       if (!prs_uint32("ptr4", ps, depth, &info->ptr4))
-                return False;
+       for (i=0; i<info->num_event_audit_options; i++)
+               if (!prs_uint32("event_audit_option", ps, depth,
+                               &info->event_audit_option))
+                       return False;
 
        if (!smb_io_unistr2("domain_name", &info->domain_name, True, ps, depth))
                 return False;
@@ -2372,18 +2609,26 @@ static BOOL net_io_sam_dom_info(char *desc, SAM_DELTA_DOM *info,
        if(!smb_io_dom_sid2("domain_sid", &info->domain_sid, ps, depth))
                return False;
 
+       if (!smb_io_rpc_blob("buf_sec_desc", &info->buf_sec_desc, ps, depth))
+
+               return False;
+
        return True;
 }
 
+#if 0
+
+/* This function is pretty broken - see bug #334 */
+
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_unk0e_info(char *desc, SAM_DELTA_UNK0E *info,
+static BOOL net_io_sam_trustdoms_info(const char *desc, SAM_DELTA_TRUSTDOMS *info,
                                      prs_struct *ps, int depth)
 {
        int i;
 
-       prs_debug(ps, depth, desc, "net_io_sam_unk0e_info");
+       prs_debug(ps, depth, desc, "net_io_sam_trustdoms_info");
        depth++;
 
        if(!prs_align(ps))
@@ -2423,15 +2668,21 @@ static BOOL net_io_sam_unk0e_info(char *desc, SAM_DELTA_UNK0E *info,
        return True;
 }
 
+#endif
+
+#if 0
+
+/* This function doesn't work - see bug #334 */
+
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_unk12_info(char *desc, SAM_DELTA_UNK12 *info,
-                                     prs_struct *ps, int depth)
+static BOOL net_io_sam_secret_info(const char *desc, SAM_DELTA_SECRET *info,
+                                  prs_struct *ps, int depth)
 {
        int i;
 
-       prs_debug(ps, depth, desc, "net_io_sam_unk12_info");
+       prs_debug(ps, depth, desc, "net_io_sam_secret_info");
        depth++;
 
        if(!prs_align(ps))
@@ -2510,13 +2761,15 @@ static BOOL net_io_sam_unk12_info(char *desc, SAM_DELTA_UNK12 *info,
        return True;
 }
 
+#endif
+
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_privs_info(char *desc, SAM_DELTA_PRIVS *info,
+static BOOL net_io_sam_privs_info(const char *desc, SAM_DELTA_PRIVS *info,
                                      prs_struct *ps, int depth)
 {
-       int i;
+       unsigned int i;
 
        prs_debug(ps, depth, desc, "net_io_sam_privs_info");
        depth++;
@@ -2524,57 +2777,53 @@ static BOOL net_io_sam_privs_info(char *desc, SAM_DELTA_PRIVS *info,
        if(!prs_align(ps))
                return False;
 
-       if(!prs_uint32("buf_size", ps, depth, &info->buf_size))
-                return False;
-
-       if(!sec_io_desc("sec_desc", &info->sec_desc, ps, depth))
-               return False;
-
        if(!smb_io_dom_sid2("sid", &info->sid, ps, depth))
                return False;
 
        if(!prs_uint32("priv_count", ps, depth, &info->priv_count))
                 return False;
-       if(!prs_uint32("reserved1", ps, depth, &info->reserved1))
+       if(!prs_uint32("priv_control", ps, depth, &info->priv_control))
                 return False;
 
-       if(!prs_uint32("ptr1", ps, depth, &info->ptr1))
+       if(!prs_uint32("priv_attr_ptr", ps, depth, &info->priv_attr_ptr))
                 return False;
-       if(!prs_uint32("ptr2", ps, depth, &info->ptr2))
+       if(!prs_uint32("priv_name_ptr", ps, depth, &info->priv_name_ptr))
                 return False;
 
-       if(!prs_uint32("unknown1", ps, depth, &info->unknown1))
+       if (!prs_uint32("paged_pool_limit", ps, depth, &info->paged_pool_limit))
                 return False;
-       if(!prs_uint32("unknown2", ps, depth, &info->unknown2))
+       if (!prs_uint32("non_paged_pool_limit", ps, depth,
+                       &info->non_paged_pool_limit))
                 return False;
-       if(!prs_uint32("unknown3", ps, depth, &info->unknown3))
+       if (!prs_uint32("min_workset_size", ps, depth, &info->min_workset_size))
                 return False;
-       if(!prs_uint32("unknown4", ps, depth, &info->unknown4))
+       if (!prs_uint32("max_workset_size", ps, depth, &info->max_workset_size))
                 return False;
-       if(!prs_uint32("unknown5", ps, depth, &info->unknown5))
+       if (!prs_uint32("page_file_limit", ps, depth, &info->page_file_limit))
                 return False;
-       if(!prs_uint32("unknown6", ps, depth, &info->unknown6))
+       if (!prs_uint64("time_limit", ps, depth, &info->time_limit))
                 return False;
-       if(!prs_uint32("unknown7", ps, depth, &info->unknown7))
+       if (!prs_uint32("system_flags", ps, depth, &info->system_flags))
                 return False;
-       if(!prs_uint32("unknown8", ps, depth, &info->unknown8))
-                return False;
-       if(!prs_uint32("unknown9", ps, depth, &info->unknown9))
+       if (!smb_io_bufhdr2("hdr_sec_desc", &info->hdr_sec_desc, ps, depth))
                 return False;
 
-       if(!prs_uint32("buf_size2", ps, depth, &info->buf_size2))
-                return False;
-       if(!prs_uint32("ptr3", ps, depth, &info->ptr3))
-                return False;
+       for (i=0; i<4; i++) {
+               UNIHDR dummy;
+               if (!smb_io_unihdr("dummy", &dummy, ps, depth))
+                       return False;
+       }
 
-       for (i=0; i<12; i++)
-               if(!prs_uint32("unknown10", ps, depth, &info->unknown10))
-                       return False;
+       for (i=0; i<4; i++) {
+               uint32 reserved;
+               if (!prs_uint32("reserved", ps, depth, &reserved))
+                       return False;
+       }
 
        if(!prs_uint32("attribute_count", ps, depth, &info->attribute_count))
                 return False;
 
-       info->attributes = talloc(ps->mem_ctx, sizeof(uint32) * info->attribute_count);
+       info->attributes = TALLOC_ARRAY(ps->mem_ctx, uint32, info->attribute_count);
 
        for (i=0; i<info->attribute_count; i++)
                if(!prs_uint32("attributes", ps, depth, &info->attributes[i]))
@@ -2583,8 +2832,8 @@ static BOOL net_io_sam_privs_info(char *desc, SAM_DELTA_PRIVS *info,
        if(!prs_uint32("privlist_count", ps, depth, &info->privlist_count))
                 return False;
 
-       info->hdr_privslist = talloc(ps->mem_ctx, sizeof(UNIHDR) * info->privlist_count);
-       info->uni_privslist = talloc(ps->mem_ctx, sizeof(UNISTR2) * info->privlist_count);
+       info->hdr_privslist = TALLOC_ARRAY(ps->mem_ctx, UNIHDR, info->privlist_count);
+       info->uni_privslist = TALLOC_ARRAY(ps->mem_ctx, UNISTR2, info->privlist_count);
 
        for (i=0; i<info->privlist_count; i++)
                if(!smb_io_unihdr("hdr_privslist", &info->hdr_privslist[i], ps, depth))
@@ -2594,13 +2843,16 @@ static BOOL net_io_sam_privs_info(char *desc, SAM_DELTA_PRIVS *info,
                if (!smb_io_unistr2("uni_privslist", &info->uni_privslist[i], True, ps, depth))
                        return False;
 
+       if (!smb_io_rpc_blob("buf_sec_desc", &info->buf_sec_desc, ps, depth))
+                return False;
+
        return True;
 }
 
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-static BOOL net_io_sam_delta_ctr(char *desc, uint8 sess_key[16],
+static BOOL net_io_sam_delta_ctr(const char *desc,
                                 SAM_DELTA_CTR * delta, uint16 type,
                                 prs_struct *ps, int depth)
 {
@@ -2609,8 +2861,8 @@ static BOOL net_io_sam_delta_ctr(char *desc, uint8 sess_key[16],
 
        switch (type) {
                 /* Seen in sam deltas */
-                case SAM_DELTA_SAM_STAMP:
-                        if (!net_io_sam_delta_stamp("", &delta->stamp, ps, depth))
+                case SAM_DELTA_MODIFIED_COUNT:
+                        if (!net_io_sam_delta_mod_count("", &delta->mod_count, ps, depth))
                                 return False;
                         break;
 
@@ -2625,7 +2877,7 @@ static BOOL net_io_sam_delta_ctr(char *desc, uint8 sess_key[16],
                        break;
 
                case SAM_DELTA_ACCOUNT_INFO:
-                       if (!net_io_sam_account_info("", sess_key, &delta->account_info, ps, depth))
+                       if (!net_io_sam_account_info("", &delta->account_info, ps, depth))
                                 return False;
                        break;
 
@@ -2639,8 +2891,8 @@ static BOOL net_io_sam_delta_ctr(char *desc, uint8 sess_key[16],
                                 return False;
                        break;
 
-               case SAM_DELTA_DOM_INFO:
-                        if (!net_io_sam_dom_info("", &delta->dom_info, ps, depth))
+               case SAM_DELTA_POLICY_INFO:
+                        if (!net_io_sam_policy_info("", &delta->policy_info, ps, depth))
                                 return False;
                        break;
 
@@ -2654,16 +2906,19 @@ static BOOL net_io_sam_delta_ctr(char *desc, uint8 sess_key[16],
                                 return False;
                        break;
 
-               case SAM_DELTA_UNK0E_INFO:
-                       if (!net_io_sam_unk0e_info("", &delta->unk0e_info, ps, depth))
-                                return False;
-                       break;
+                       /* These guys are implemented but broken */
 
-               case SAM_DELTA_UNK12_INFO:
-                       if (!net_io_sam_unk12_info("", &delta->unk12_info, ps, depth))
-                                return False;
+               case SAM_DELTA_TRUST_DOMS:
+               case SAM_DELTA_SECRET_INFO:
                        break;
 
+                       /* These guys are not implemented yet */
+
+               case SAM_DELTA_RENAME_GROUP:
+               case SAM_DELTA_RENAME_USER:
+               case SAM_DELTA_RENAME_ALIAS:
+               case SAM_DELTA_DELETE_GROUP:
+               case SAM_DELTA_DELETE_USER:
                default:
                        DEBUG(0, ("Replication error: Unknown delta type 0x%x\n", type));
                        break;
@@ -2675,7 +2930,7 @@ static BOOL net_io_sam_delta_ctr(char *desc, uint8 sess_key[16],
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-BOOL net_io_r_sam_sync(char *desc, uint8 sess_key[16],
+BOOL net_io_r_sam_sync(const char *desc,
                       NET_R_SAM_SYNC * r_s, prs_struct *ps, int depth)
 {
        uint32 i;
@@ -2709,10 +2964,7 @@ BOOL net_io_r_sam_sync(char *desc, uint8 sess_key[16],
                        }
 
                         if (r_s->num_deltas2 > 0) {
-                                r_s->hdr_deltas = (SAM_DELTA_HDR *)
-                                        talloc(ps->mem_ctx, r_s->num_deltas2 *
-                                               sizeof(SAM_DELTA_HDR));
-                          
+                                r_s->hdr_deltas = TALLOC_ARRAY(ps->mem_ctx, SAM_DELTA_HDR, r_s->num_deltas2);
                                 if (r_s->hdr_deltas == NULL) {
                                         DEBUG(0, ("error tallocating memory "
                                                   "for %d delta headers\n", 
@@ -2730,10 +2982,7 @@ BOOL net_io_r_sam_sync(char *desc, uint8 sess_key[16],
                        }
 
                         if (r_s->num_deltas2 > 0) {
-                                r_s->deltas = (SAM_DELTA_CTR *)
-                                        talloc(ps->mem_ctx, r_s->num_deltas2 *
-                                               sizeof(SAM_DELTA_CTR));
-
+                                r_s->deltas = TALLOC_ARRAY(ps->mem_ctx, SAM_DELTA_CTR, r_s->num_deltas2);
                                 if (r_s->deltas == NULL) {
                                         DEBUG(0, ("error tallocating memory "
                                                   "for %d deltas\n", 
@@ -2745,7 +2994,7 @@ BOOL net_io_r_sam_sync(char *desc, uint8 sess_key[16],
                        for (i = 0; i < r_s->num_deltas2; i++)
                        {
                                if (!net_io_sam_delta_ctr(
-                                        "", sess_key, &r_s->deltas[i],
+                                        "", &r_s->deltas[i],
                                         r_s->hdr_deltas[i].type3,
                                         ps, depth)) {
                                         DEBUG(0, ("hmm, failed on i=%d\n", i));
@@ -2771,8 +3020,8 @@ BOOL init_net_q_sam_deltas(NET_Q_SAM_DELTAS *q_s, const char *srv_name,
 {
        DEBUG(5, ("init_net_q_sam_deltas\n"));
 
-       init_unistr2(&q_s->uni_srv_name, srv_name, strlen(srv_name) + 1);
-       init_unistr2(&q_s->uni_cli_name, cli_name, strlen(cli_name) + 1);
+       init_unistr2(&q_s->uni_srv_name, srv_name, UNI_STR_TERMINATE);
+       init_unistr2(&q_s->uni_cli_name, cli_name, UNI_STR_TERMINATE);
 
        memcpy(&q_s->cli_creds, cli_creds, sizeof(q_s->cli_creds));
        memset(&q_s->ret_creds, 0, sizeof(q_s->ret_creds));
@@ -2788,7 +3037,7 @@ BOOL init_net_q_sam_deltas(NET_Q_SAM_DELTAS *q_s, const char *srv_name,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-BOOL net_io_q_sam_deltas(char *desc, NET_Q_SAM_DELTAS *q_s, prs_struct *ps,
+BOOL net_io_q_sam_deltas(const char *desc, NET_Q_SAM_DELTAS *q_s, prs_struct *ps,
                          int depth)
 {
        prs_debug(ps, depth, desc, "net_io_q_sam_deltas");
@@ -2817,10 +3066,10 @@ BOOL net_io_q_sam_deltas(char *desc, NET_Q_SAM_DELTAS *q_s, prs_struct *ps,
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-BOOL net_io_r_sam_deltas(char *desc, uint8 sess_key[16],
+BOOL net_io_r_sam_deltas(const char *desc,
                          NET_R_SAM_DELTAS *r_s, prs_struct *ps, int depth)
 {
-        int i;
+        unsigned int i;
 
        prs_debug(ps, depth, desc, "net_io_r_sam_deltas");
        depth++;
@@ -2845,9 +3094,7 @@ BOOL net_io_r_sam_deltas(char *desc, uint8 sess_key[16],
                if (r_s->ptr_deltas != 0)
                {
                         if (r_s->num_deltas > 0) {
-                                r_s->hdr_deltas = (SAM_DELTA_HDR *)
-                                        talloc(ps->mem_ctx, r_s->num_deltas *
-                                               sizeof(SAM_DELTA_HDR));
+                                r_s->hdr_deltas = TALLOC_ARRAY(ps->mem_ctx, SAM_DELTA_HDR, r_s->num_deltas);
                                 if (r_s->hdr_deltas == NULL) {
                                         DEBUG(0, ("error tallocating memory "
                                                   "for %d delta headers\n", 
@@ -2863,10 +3110,7 @@ BOOL net_io_r_sam_deltas(char *desc, uint8 sess_key[16],
                        }
                         
                         if (r_s->num_deltas > 0) {
-                                r_s->deltas = (SAM_DELTA_CTR *)
-                                        talloc(ps->mem_ctx, r_s->num_deltas *
-                                               sizeof(SAM_DELTA_CTR));
-
+                                r_s->deltas = TALLOC_ARRAY(ps->mem_ctx, SAM_DELTA_CTR, r_s->num_deltas);
                                 if (r_s->deltas == NULL) {
                                         DEBUG(0, ("error tallocating memory "
                                                   "for %d deltas\n", 
@@ -2878,7 +3122,7 @@ BOOL net_io_r_sam_deltas(char *desc, uint8 sess_key[16],
                        for (i = 0; i < r_s->num_deltas; i++)
                        {
                                if (!net_io_sam_delta_ctr(
-                                        "", sess_key,
+                                        "",
                                         &r_s->deltas[i],
                                         r_s->hdr_deltas[i].type2,
                                         ps, depth))