Add a much better workaround for bug #8382 and some expert info.
[metze/wireshark/wip.git] / capture_opts.c
index cbfe1b9aa56b59f57c023d85d00b57c9c321b3fe..c297b1396f072e545fd76db2331bf70280325b8e 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#ifdef HAVE_CONFIG_H
-# include "config.h"
-#endif
+#include "config.h"
+
+#include <stdio.h>
 
 #ifdef HAVE_LIBPCAP
 
@@ -39,7 +39,7 @@
 
 #include <epan/packet.h>
 #include <epan/prefs.h>
-#include "simple_dialog.h"
+#include "ui/simple_dialog.h"
 #include "capture_ui_utils.h"
 
 #include "capture_opts.h"
@@ -70,7 +70,7 @@ capture_opts_init(capture_options *capture_opts, void *cf)
   capture_opts->default_options.linktype        = -1;
   capture_opts->default_options.promisc_mode    = TRUE;
 #if defined(_WIN32) || defined(HAVE_PCAP_CREATE)
-  capture_opts->default_options.buffer_size     = 1;                /* 1 MB */
+  capture_opts->default_options.buffer_size     = DEFAULT_CAPTURE_BUFFER_SIZE;
 #endif
   capture_opts->default_options.monitor_mode    = FALSE;
 #ifdef HAVE_PCAP_REMOTE
@@ -142,9 +142,10 @@ capture_opts_log(const char *log_domain, GLogLevelFlags log_level, capture_optio
         interface_options interface_opts;
 
         interface_opts = g_array_index(capture_opts->ifaces, interface_options, i);
-        g_log(log_domain, log_level, "Interface name[%02d]  : %s", i, interface_opts.name);
-        g_log(log_domain, log_level, "Interface Descr[%02d] : %s", i, interface_opts.descr);
-        g_log(log_domain, log_level, "Capture filter[%02d]  : %s", i, interface_opts.cfilter);
+        g_log(log_domain, log_level, "Interface name[%02d]  : %s", i, interface_opts.name ? interface_opts.name : "(unspecified)");
+        g_log(log_domain, log_level, "Interface description[%02d] : %s", i, interface_opts.descr ? interface_opts.descr : "(unspecified)");
+        g_log(log_domain, log_level, "Console display name[%02d]: %s", i, interface_opts.console_display_name ? interface_opts.console_display_name : "(unspecified)");
+        g_log(log_domain, log_level, "Capture filter[%02d]  : %s", i, interface_opts.cfilter ? interface_opts.cfilter : "(unspecified)");
         g_log(log_domain, log_level, "Snap length[%02d] (%u) : %d", i, interface_opts.has_snaplen, interface_opts.snaplen);
         g_log(log_domain, log_level, "Link Type[%02d]       : %d", i, interface_opts.linktype);
         g_log(log_domain, log_level, "Promiscuous Mode[%02d]: %s", i, interface_opts.promisc_mode?"TRUE":"FALSE");
@@ -158,15 +159,15 @@ capture_opts_log(const char *log_domain, GLogLevelFlags log_level, capture_optio
             interface_opts.src_type == CAPTURE_IFREMOTE ? "Remote interface" :
             "Unknown");
         if (interface_opts.src_type == CAPTURE_IFREMOTE) {
-            g_log(log_domain, log_level, "Remote host[%02d]     : %s", i, interface_opts.remote_host);
-            g_log(log_domain, log_level, "Remote port[%02d]     : %s", i, interface_opts.remote_port);
+            g_log(log_domain, log_level, "Remote host[%02d]     : %s", i, interface_opts.remote_host ? interface_opts.remote_host : "(unspecified)");
+            g_log(log_domain, log_level, "Remote port[%02d]     : %s", i, interface_opts.remote_port ? interface_opts.remote_port : "(unspecified)");
         }
         g_log(log_domain, log_level, "Authentication[%02d]  : %s", i,
             interface_opts.auth_type == CAPTURE_AUTH_NULL ? "Null" :
             interface_opts.auth_type == CAPTURE_AUTH_PWD ? "By username/password" :
             "Unknown");
         if (interface_opts.auth_type == CAPTURE_AUTH_PWD) {
-            g_log(log_domain, log_level, "Auth username[%02d]   : %s", i, interface_opts.auth_username);
+            g_log(log_domain, log_level, "Auth username[%02d]   : %s", i, interface_opts.auth_username ? interface_opts.auth_username : "(unspecified)");
             g_log(log_domain, log_level, "Auth password[%02d]   : <hidden>", i);
         }
         g_log(log_domain, log_level, "UDP data tfer[%02d]   : %u", i, interface_opts.datatx_udp);
@@ -178,9 +179,9 @@ capture_opts_log(const char *log_domain, GLogLevelFlags log_level, capture_optio
         g_log(log_domain, log_level, "Sampling param.[%02d] : %d", i, interface_opts.sampling_param);
 #endif
     }
-    g_log(log_domain, log_level, "Interface name[df]  : %s", capture_opts->default_options.name);
-    g_log(log_domain, log_level, "Interface Descr[df] : %s", capture_opts->default_options.descr);
-    g_log(log_domain, log_level, "Capture filter[df]  : %s", capture_opts->default_options.cfilter);
+    g_log(log_domain, log_level, "Interface name[df]  : %s", capture_opts->default_options.name ? capture_opts->default_options.name : "(unspecified)");
+    g_log(log_domain, log_level, "Interface Descr[df] : %s", capture_opts->default_options.descr ? capture_opts->default_options.descr : "(unspecified)");
+    g_log(log_domain, log_level, "Capture filter[df]  : %s", capture_opts->default_options.cfilter ? capture_opts->default_options.cfilter : "(unspecified)");
     g_log(log_domain, log_level, "Snap length[df] (%u) : %d", capture_opts->default_options.has_snaplen, capture_opts->default_options.snaplen);
     g_log(log_domain, log_level, "Link Type[df]       : %d", capture_opts->default_options.linktype);
     g_log(log_domain, log_level, "Promiscuous Mode[df]: %s", capture_opts->default_options.promisc_mode?"TRUE":"FALSE");
@@ -194,15 +195,15 @@ capture_opts_log(const char *log_domain, GLogLevelFlags log_level, capture_optio
         capture_opts->default_options.src_type == CAPTURE_IFREMOTE ? "Remote interface" :
         "Unknown");
     if (capture_opts->default_options.src_type == CAPTURE_IFREMOTE) {
-        g_log(log_domain, log_level, "Remote host[df]     : %s", capture_opts->default_options.remote_host);
-        g_log(log_domain, log_level, "Remote port[df]     : %s", capture_opts->default_options.remote_port);
+        g_log(log_domain, log_level, "Remote host[df]     : %s", capture_opts->default_options.remote_host ? capture_opts->default_options.remote_host : "(unspecified)");
+        g_log(log_domain, log_level, "Remote port[df]     : %s", capture_opts->default_options.remote_port ? capture_opts->default_options.remote_port : "(unspecified)");
     }
     g_log(log_domain, log_level, "Authentication[df]  : %s",
         capture_opts->default_options.auth_type == CAPTURE_AUTH_NULL ? "Null" :
         capture_opts->default_options.auth_type == CAPTURE_AUTH_PWD ? "By username/password" :
         "Unknown");
     if (capture_opts->default_options.auth_type == CAPTURE_AUTH_PWD) {
-        g_log(log_domain, log_level, "Auth username[df]   : %s", capture_opts->default_options.auth_username);
+        g_log(log_domain, log_level, "Auth username[df]   : %s", capture_opts->default_options.auth_username ? capture_opts->default_options.auth_username : "(unspecified)");
         g_log(log_domain, log_level, "Auth password[df]   : <hidden>");
     }
     g_log(log_domain, log_level, "UDP data tfer[df]   : %u", capture_opts->default_options.datatx_udp);
@@ -447,7 +448,6 @@ capture_opts_add_iface_opt(capture_options *capture_opts, const char *optarg_str
     gchar       *err_str;
     interface_options interface_opts;
 
-
     /*
      * If the argument is a number, treat it as an index into the list
      * of adapters, as printed by "tshark -D".
@@ -476,6 +476,7 @@ capture_opts_add_iface_opt(capture_options *capture_opts, const char *optarg_str
             switch (err) {
 
             case CANT_GET_INTERFACE_LIST:
+            case DONT_HAVE_PCAP:
                 cmdarg_err("%s", err_str);
                 g_free(err_str);
                 break;
@@ -486,20 +487,120 @@ capture_opts_add_iface_opt(capture_options *capture_opts, const char *optarg_str
             }
             return 2;
         }
-        if_info = (if_info_t *)g_list_nth_data(if_list, adapter_index - 1);
+        if_info = (if_info_t *)g_list_nth_data(if_list, (int)(adapter_index - 1));
         if (if_info == NULL) {
             cmdarg_err("There is no interface with that adapter index");
             return 1;
         }
         interface_opts.name = g_strdup(if_info->name);
-        /*  We don't set iface_descr here because doing so requires
-         *  capture_ui_utils.c which requires epan/prefs.c which is
-         *  probably a bit too much dependency for here...
-         */
+        if (if_info->friendly_name != NULL) {
+            /*
+             * We have a friendly name for the interface, so display that
+             * instead of the interface name/guid.
+             *
+             * XXX - on UN*X, the interface name is not quite so ugly,
+             * and might be more familiar to users; display them both?
+             */
+            interface_opts.console_display_name = g_strdup(if_info->friendly_name);
+        } else {
+            /* fallback to the interface name */
+            interface_opts.console_display_name = g_strdup(if_info->name);
+        }
         free_interface_list(if_list);
     } else {
-        interface_opts.name = g_strdup(optarg_str_p);
+        /*
+         * Retrieve the interface list so that we can search for the
+         * specified option amongst both the interface names and the
+         * friendly names and so that we find the friendly name even
+         * if an interface name was specified.
+         *
+         * If we can't get the list, just use the specified option as
+         * the interface name, so that the user can try specifying an
+         * interface explicitly for testing purposes.
+         */
+        if_list = capture_interface_list(&err, &err_str);
+        if (if_list != NULL) {
+            /* try and do an exact match (case insensitive) */
+            GList   *if_entry;
+            gboolean matched;
+
+            matched = FALSE;
+            for (if_entry = g_list_first(if_list); if_entry != NULL;
+                 if_entry = g_list_next(if_entry))
+            {
+                if_info = (if_info_t *)if_entry->data;
+                /* exact name check */
+                if (g_ascii_strcasecmp(if_info->name, optarg_str_p) == 0) {
+                    /* exact match on the interface name, use that for displaying etc */
+                    interface_opts.name = g_strdup(if_info->name);
+
+                    if (if_info->friendly_name != NULL) {
+                        /*
+                         * If we have a friendly name, use that for the
+                         * console display name, as it is the basis for
+                         * the auto generated temp filename.
+                         */
+                        interface_opts.console_display_name = g_strdup(if_info->friendly_name);
+                    } else {
+                        interface_opts.console_display_name = g_strdup(if_info->name);
+                    }
+                    matched = TRUE;
+                    break;
+                }
+
+                /* exact friendly name check */
+                if (if_info->friendly_name != NULL &&
+                    g_ascii_strcasecmp(if_info->friendly_name, optarg_str_p) == 0) {
+                    /* exact match - use the friendly name for display */
+                    interface_opts.name = g_strdup(if_info->name);
+                    interface_opts.console_display_name = g_strdup(if_info->friendly_name);
+                    matched = TRUE;
+                    break;
+                }
+            }
+
+            /* didn't find, attempt a case insensitive prefix match of the friendly name*/
+            if (!matched) {
+                size_t prefix_length;
+
+                prefix_length = strlen(optarg_str_p);
+                for (if_entry = g_list_first(if_list); if_entry != NULL;
+                     if_entry = g_list_next(if_entry))
+                {
+                    if_info = (if_info_t *)if_entry->data;
+
+                    if (if_info->friendly_name != NULL &&
+                        g_ascii_strncasecmp(if_info->friendly_name, optarg_str_p, prefix_length) == 0) {
+                        /* prefix match - use the friendly name for display */
+                        interface_opts.name = g_strdup(if_info->name);
+                        interface_opts.console_display_name = g_strdup(if_info->friendly_name);
+                        matched = TRUE;
+                        break;
+                    }
+                }
+            }
+            if (!matched) {
+                /*
+                 * We didn't find the interface in the list; just use
+                 * the specified name, so that, for example, if an
+                 * interface doesn't show up in the list for some
+                 * reason, the user can try specifying it explicitly
+                 * for testing purposes.
+                 */
+                interface_opts.name = g_strdup(optarg_str_p);
+                interface_opts.console_display_name = g_strdup(optarg_str_p);
+            }
+            free_interface_list(if_list);
+        } else {
+            interface_opts.name = g_strdup(optarg_str_p);
+            interface_opts.console_display_name = g_strdup(optarg_str_p);
+        }
     }
+
+    /*  We don't set iface_descr here because doing so requires
+     *  capture_ui_utils.c which requires epan/prefs.c which is
+     *  probably a bit too much dependency for here...
+     */
     interface_opts.descr = g_strdup(capture_opts->default_options.descr);
     interface_opts.cfilter = g_strdup(capture_opts->default_options.cfilter);
     interface_opts.snaplen = capture_opts->default_options.snaplen;
@@ -527,86 +628,11 @@ capture_opts_add_iface_opt(capture_options *capture_opts, const char *optarg_str
 #endif
 
     g_array_append_val(capture_opts->ifaces, interface_opts);
-    return 0;
-}
-
-int
-capture_opts_select_iface(capture_options *capture_opts, const char *optarg_str_p)
-{
-    long        adapter_index;
-    char        *p;
-    GList       *if_list;
-    if_info_t   *if_info;
-    int         err;
-    guint       i;
-    gchar       *err_str, *name = NULL;
-    interface_t device;
 
-    /*
-     * If the argument is a number, treat it as an index into the list
-     * of adapters, as printed by "tshark -D".
-     *
-     * This should be OK on UNIX systems, as interfaces shouldn't have
-     * names that begin with digits.  It can be useful on Windows, where
-     * more than one interface can have the same name.
-     */
-    adapter_index = strtol(optarg_str_p, &p, 10);
-    if (p != NULL && *p == '\0') {
-        if (adapter_index < 0) {
-            cmdarg_err("The specified adapter index is a negative number");
-            return 1;
-        }
-        if (adapter_index > INT_MAX) {
-            cmdarg_err("The specified adapter index is too large (greater than %d)",
-                       INT_MAX);
-            return 1;
-        }
-        if (adapter_index == 0) {
-            cmdarg_err("There is no interface with that adapter index");
-            return 1;
-        }
-        if_list = capture_interface_list(&err, &err_str);
-        if (if_list == NULL) {
-            switch (err) {
-
-            case CANT_GET_INTERFACE_LIST:
-                cmdarg_err("%s", err_str);
-                g_free(err_str);
-                break;
-
-            case NO_INTERFACES_FOUND:
-                cmdarg_err("There are no interfaces on which a capture can be done");
-                break;
-            }
-            return 2;
-        }
-        if_info = (if_info_t *)g_list_nth_data(if_list, adapter_index - 1);
-        if (if_info == NULL) {
-            cmdarg_err("There is no interface with that adapter index");
-            return 1;
-        }
-        name = g_strdup(if_info->name);
-        /*  We don't set iface_descr here because doing so requires
-         *  capture_ui_utils.c which requires epan/prefs.c which is
-         *  probably a bit too much dependency for here...
-         */
-        free_interface_list(if_list);
-    } else {
-        name = g_strdup(optarg_str_p);
-    }
-    for(i = 0; i < capture_opts->all_ifaces->len; i++) {
-        device = g_array_index(capture_opts->all_ifaces, interface_t, i);
-        if (strcmp(device.name, name) == 0) {
-            device.selected = TRUE;
-            capture_opts->num_selected++;
-            capture_opts->all_ifaces = g_array_remove_index(capture_opts->all_ifaces, i);
-            g_array_insert_val(capture_opts->all_ifaces, i, device);
-            break;
-        }
-    } 
     return 0;
 }
 
+
 int
 capture_opts_add_opt(capture_options *capture_opts, int opt, const char *optarg_str_p, gboolean *start_capture)
 {
@@ -666,6 +692,9 @@ capture_opts_add_opt(capture_options *capture_opts, int opt, const char *optarg_
             capture_opts->default_options.cfilter = g_strdup(optarg_str_p);
         }
         break;
+    case 'g':        /* enable group read access on the capture file(s) */
+        capture_opts->group_read_access = TRUE;
+        break;
     case 'H':        /* Hide capture info dialog box */
         capture_opts->show_info = FALSE;
         break;
@@ -777,9 +806,6 @@ capture_opts_add_opt(capture_options *capture_opts, int opt, const char *optarg_
         capture_opts->save_file = g_strdup(optarg_str_p);
         status = capture_opts_output_to_pipe(capture_opts->save_file, &capture_opts->output_to_pipe);
         return status;
-    case 'g':        /* enable group read access on the capture file(s) */
-        capture_opts->group_read_access = TRUE;
-        break;
     case 'y':        /* Set the pcap data link type */
         if (capture_opts->ifaces->len > 0) {
             interface_options interface_opts;
@@ -848,15 +874,21 @@ capture_opts_print_interfaces(GList *if_list)
         if_info = (if_info_t *)if_entry->data;
         fprintf_stderr("%d. %s", i++, if_info->name);
 
-        /* Print the description if it exists */
-        if (if_info->description != NULL)
-            fprintf_stderr(" (%s)", if_info->description);
+        /* Print the interface friendly name, if it exists;
+          if not fall back to vendor description, if it exists. */
+        if (if_info->friendly_name != NULL){
+            fprintf_stderr(" (%s)", if_info->friendly_name);
+        } else {
+            if (if_info->vendor_description != NULL)
+                fprintf_stderr(" (%s)", if_info->vendor_description);
+        }
         fprintf_stderr("\n");
     }
 }
 
 
-void capture_opts_trim_snaplen(capture_options *capture_opts, int snaplen_min)
+void
+capture_opts_trim_snaplen(capture_options *capture_opts, int snaplen_min)
 {
     guint i;
     interface_options interface_opts;
@@ -880,7 +912,8 @@ void capture_opts_trim_snaplen(capture_options *capture_opts, int snaplen_min)
 }
 
 
-void capture_opts_trim_ring_num_files(capture_options *capture_opts)
+void
+capture_opts_trim_ring_num_files(capture_options *capture_opts)
 {
     /* Check the value range of the ring_num_files parameter */
     if (capture_opts->ring_num_files > RINGBUFFER_MAX_NUM_FILES) {
@@ -897,96 +930,37 @@ void capture_opts_trim_ring_num_files(capture_options *capture_opts)
 }
 
 
-gboolean capture_opts_trim_iface(capture_options *capture_opts, const char *capture_device)
+int
+capture_opts_trim_iface(capture_options *capture_opts, const char *capture_device)
 {
-    GList       *if_list;
-    if_info_t   *if_info;
-    int         err;
-    gchar       *err_str;
-    interface_options interface_opts;
-
+    int status;
 
     /* Did the user specify an interface to use? */
-    if (capture_opts->num_selected == 0 && capture_opts->ifaces->len == 0) {
-        /* No - is a default specified in the preferences file? */
-        if (capture_device != NULL) {
-            /* Yes - use it. */
-            interface_opts.name = g_strdup(capture_device);
-            /*  We don't set iface_descr here because doing so requires
-             *  capture_ui_utils.c which requires epan/prefs.c which is
-             *  probably a bit too much dependency for here...
-             */
-        } else {
-            /* No - pick the first one from the list of interfaces. */
-            if_list = capture_interface_list(&err, &err_str);
-            if (if_list == NULL) {
-                switch (err) {
-
-                case CANT_GET_INTERFACE_LIST:
-                    cmdarg_err("%s", err_str);
-                    g_free(err_str);
-                    break;
-
-                case NO_INTERFACES_FOUND:
-                    cmdarg_err("There are no interfaces on which a capture can be done");
-                    break;
-                }
-                return FALSE;
-            }
-            if_info = (if_info_t *)if_list->data;      /* first interface */
-            interface_opts.name = g_strdup(if_info->name);
-            /*  We don't set iface_descr here because doing so requires
-             *  capture_ui_utils.c which requires epan/prefs.c which is
-             *  probably a bit too much dependency for here...
-             */
-            free_interface_list(if_list);
-        }
-        if (capture_opts->default_options.descr) {
-            interface_opts.descr = g_strdup(capture_opts->default_options.descr);
-        } else {
-            interface_opts.descr = NULL;
-        }
-        interface_opts.cfilter = g_strdup(capture_opts->default_options.cfilter);
-        interface_opts.snaplen = capture_opts->default_options.snaplen;
-        interface_opts.has_snaplen = capture_opts->default_options.has_snaplen;
-        interface_opts.linktype = capture_opts->default_options.linktype;
-        interface_opts.promisc_mode = capture_opts->default_options.promisc_mode;
-#if defined(_WIN32) || defined(HAVE_PCAP_CREATE)
-        interface_opts.buffer_size = capture_opts->default_options.buffer_size;
-#endif
-        interface_opts.monitor_mode = capture_opts->default_options.monitor_mode;
-#ifdef HAVE_PCAP_REMOTE
-        interface_opts.src_type = capture_opts->default_options.src_type;
-        interface_opts.remote_host = g_strdup(capture_opts->default_options.remote_host);
-        interface_opts.remote_port = g_strdup(capture_opts->default_options.remote_port);
-        interface_opts.auth_type = capture_opts->default_options.auth_type;
-        interface_opts.auth_username = g_strdup(capture_opts->default_options.auth_username);
-        interface_opts.auth_password = g_strdup(capture_opts->default_options.auth_password);
-        interface_opts.datatx_udp = capture_opts->default_options.datatx_udp;
-        interface_opts.nocap_rpcap = capture_opts->default_options.nocap_rpcap;
-        interface_opts.nocap_local = capture_opts->default_options.nocap_local;
-#endif
-#ifdef HAVE_PCAP_SETSAMPLING
-        interface_opts.sampling_method = capture_opts->default_options.sampling_method;
-        interface_opts.sampling_param  = capture_opts->default_options.sampling_param;
-#endif
-        g_array_append_val(capture_opts->ifaces, interface_opts);
+    if (capture_opts->num_selected != 0 || capture_opts->ifaces->len != 0) {
+        /* yes they did, return immediately - nothing further to do here */
+        return 0;
     }
 
-    return TRUE;
+    /* No - is a default specified in the preferences file? */
+    if (capture_device != NULL) {
+        /* Yes - use it. */
+        status = capture_opts_add_iface_opt(capture_opts, capture_device);
+        return status;
+    }
+    /* No default in preferences file, just pick the first interface from the list of interfaces. */
+    return capture_opts_add_iface_opt(capture_opts, "1");
 }
 
-
-
 #ifndef S_IFIFO
-#define S_IFIFO        _S_IFIFO
+#define S_IFIFO _S_IFIFO
 #endif
 #ifndef S_ISFIFO
 #define S_ISFIFO(mode)  (((mode) & S_IFMT) == S_IFIFO)
 #endif
 
 /* copied from filesystem.c */
-static int capture_opts_test_for_fifo(const char *path)
+static int
+capture_opts_test_for_fifo(const char *path)
 {
   ws_statb64 statb;
 
@@ -999,7 +973,8 @@ static int capture_opts_test_for_fifo(const char *path)
     return 0;
 }
 
-static gboolean capture_opts_output_to_pipe(const char *save_file, gboolean *is_pipe)
+static gboolean
+capture_opts_output_to_pipe(const char *save_file, gboolean *is_pipe)
 {
   int err;
 
@@ -1038,18 +1013,43 @@ static gboolean capture_opts_output_to_pipe(const char *save_file, gboolean *is_
   return 0;
 }
 
+/*
+ * Add all non-hidden selected interfaces in the "all interfaces" list
+ * to the list of interfaces for the capture.
+ */
 void
 collect_ifaces(capture_options *capture_opts)
 {
   guint i;
   interface_t device;
   interface_options interface_opts;
+
+  /* Empty out the existing list of interfaces. */
+  for (i = capture_opts->ifaces->len; i != 0; i--) {
+    interface_opts = g_array_index(capture_opts->ifaces, interface_options, i - 1);
+    g_free(interface_opts.name);
+    g_free(interface_opts.descr);
+    if (interface_opts.console_display_name != NULL)
+        g_free(interface_opts.console_display_name);
+    g_free(interface_opts.cfilter);
+#ifdef HAVE_PCAP_REMOTE
+    if (interface_opts.src_type == CAPTURE_IFREMOTE) {
+      g_free(interface_opts.remote_host);
+      g_free(interface_opts.remote_port);
+      g_free(interface_opts.auth_username);
+      g_free(interface_opts.auth_password);
+    }
+#endif
+    capture_opts->ifaces = g_array_remove_index(capture_opts->ifaces, i - 1);
+  }
+
+  /* Now fill the list up again. */
   for (i = 0; i < capture_opts->all_ifaces->len; i++) {
     device = g_array_index(capture_opts->all_ifaces, interface_t, i);
-    if (device.selected) {
+    if (!device.hidden && device.selected) {
       interface_opts.name = g_strdup(device.name);
       interface_opts.descr = g_strdup(device.display_name);
-      interface_opts.monitor_mode = device.monitor_mode_enabled;
+      interface_opts.console_display_name = g_strdup(device.name);
       interface_opts.linktype = device.active_dlt;
       interface_opts.cfilter = g_strdup(device.cfilter);
       interface_opts.snaplen = device.snaplen;
@@ -1058,23 +1058,24 @@ collect_ifaces(capture_options *capture_opts)
 #if defined(_WIN32) || defined(HAVE_PCAP_CREATE)
       interface_opts.buffer_size =  device.buffer;
 #endif
-      if (device.type == IF_REMOTE) {
-#ifdef HAVE_PCAP_REMOTE 
-        interface_opts.src_type = device.type;
-        interface_opts.remote_host = g_strdup(device.remote_opts.remote_host_opts.remote_host);
-        interface_opts.remote_port = g_strdup(device.remote_opts.remote_host_opts.remote_port);
-        interface_opts.auth_type = device.remote_opts.remote_host_opts.auth_type;
-        interface_opts.auth_username = g_strdup(device.remote_opts.remote_host_opts.auth_username);
-        interface_opts.auth_password = g_strdup(device.remote_opts.remote_host_opts.auth_password);
-        interface_opts.datatx_udp = device.remote_opts.remote_host_opts.datatx_udp;
-        interface_opts.nocap_rpcap = device.remote_opts.remote_host_opts.nocap_rpcap;
-        interface_opts.nocap_local = device.remote_opts.remote_host_opts.nocap_local;
+#ifdef HAVE_PCAP_CREATE
+      interface_opts.monitor_mode = device.monitor_mode_enabled;
+#endif
+#ifdef HAVE_PCAP_REMOTE
+      interface_opts.src_type = CAPTURE_IFREMOTE;
+      interface_opts.remote_host = g_strdup(device.remote_opts.remote_host_opts.remote_host);
+      interface_opts.remote_port = g_strdup(device.remote_opts.remote_host_opts.remote_port);
+      interface_opts.auth_type = device.remote_opts.remote_host_opts.auth_type;
+      interface_opts.auth_username = g_strdup(device.remote_opts.remote_host_opts.auth_username);
+      interface_opts.auth_password = g_strdup(device.remote_opts.remote_host_opts.auth_password);
+      interface_opts.datatx_udp = device.remote_opts.remote_host_opts.datatx_udp;
+      interface_opts.nocap_rpcap = device.remote_opts.remote_host_opts.nocap_rpcap;
+      interface_opts.nocap_local = device.remote_opts.remote_host_opts.nocap_local;
 #endif
 #ifdef HAVE_PCAP_SETSAMPLING
-        interface_opts.sampling_method = device.remote_opts.sampling_method;
-        interface_opts.sampling_param  = device.remote_opts.sampling_param;
+      interface_opts.sampling_method = device.remote_opts.sampling_method;
+      interface_opts.sampling_param  = device.remote_opts.sampling_param;
 #endif
-      }
       g_array_append_val(capture_opts->ifaces, interface_opts);
     } else {
       continue;