reformatting patches and making things easier for developers to work together.
You don't have to like them or even agree with them, but once put in place
we all have to abide by them (or vote to change them). However, coding
reformatting patches and making things easier for developers to work together.
You don't have to like them or even agree with them, but once put in place
we all have to abide by them (or vote to change them). However, coding
described here are hopefully easy enough to follow as they are very
common and supported by tools and editors.
described here are hopefully easy enough to follow as they are very
common and supported by tools and editors.
-The basic style, also mentioned in the SAMBA_4_0/prog_guide.txt is the
-Linux kernel coding style (See Documentation/CodingStyle in the kernel
-source tree). The closely matches what most Samba developers use already
-anyways.
+The basic style, also mentioned in prog_guide4.txt, is the Linux kernel coding
+style (See Documentation/CodingStyle in the kernel source tree). This closely
+matches what most Samba developers use already anyways.
* Maximum Line Width is 80 Characters
The reason is not for people with low-res screens but rather sticking
to 80 columns prevents you from easily nesting more than one level of
* Maximum Line Width is 80 Characters
The reason is not for people with low-res screens but rather sticking
to 80 columns prevents you from easily nesting more than one level of
* Follow the K&R guidelines. We won't go throw them all here. You have
a copy of "The C Programming Language" anyways right? You can also use
* Follow the K&R guidelines. We won't go throw them all here. You have
a copy of "The C Programming Language" anyways right? You can also use
following to $HOME/.exrc:
set tabstop=8
set shiftwidth=8
For Vim, the following settings in $HOME/.vimrc will also deal with
following to $HOME/.exrc:
set tabstop=8
set shiftwidth=8
For Vim, the following settings in $HOME/.vimrc will also deal with
To avoid confusion, indentations are to be 8 character with tab (not
8 ' ' characters. When wrapping parameters for function calls,
To avoid confusion, indentations are to be 8 character with tab (not
8 ' ' characters. When wrapping parameters for function calls,
Use tabs to get as close as possible and then fill in the final 7
characters or less with whitespace. For example,
Use tabs to get as close as possible and then fill in the final 7
characters or less with whitespace. For example,
-Braces for code blocks used by for, if, switch, while, do..while, etc...
+Braces for code blocks used by for, if, switch, while, do..while, etc.
should begin on the same line as the statement keyword and end on a line
of their own. NOTE: Functions are different and the beginning left brace
should begin on a line of its own.
should begin on the same line as the statement keyword and end on a line
of their own. NOTE: Functions are different and the beginning left brace
should begin on a line of its own.
as the single exit point from a function. But in no Samba world what so ever
is a goto outside of a function or block of code a good idea.
as the single exit point from a function. But in no Samba world what so ever
is a goto outside of a function or block of code a good idea.
When invoking functions that return pointer values, either of the following
are acceptable. Use you best judgement and choose the more readable option.
When invoking functions that return pointer values, either of the following
are acceptable. Use you best judgement and choose the more readable option.
if ((x = malloc(sizeof(short)*10)) == NULL ) {
fprintf(stderr, "Unable to alloc memory!\n");
}
if ((x = malloc(sizeof(short)*10)) == NULL ) {
fprintf(stderr, "Unable to alloc memory!\n");
}