r3379: More merging of kerberos keytab and salting fixes from Nalin Dahyabhai <nalin...
[samba.git] / source3 / libads / kerberos_keytab.c
1 /*
2    Unix SMB/CIFS implementation.
3    kerberos keytab utility library
4    Copyright (C) Andrew Tridgell 2001
5    Copyright (C) Remus Koos 2001
6    Copyright (C) Luke Howard 2003
7    Copyright (C) Jim McDonough (jmcd@us.ibm.com) 2003
8    Copyright (C) Guenther Deschner 2003
9    Copyright (C) Rakesh Patel 2004
10    Copyright (C) Dan Perry 2004
11    Copyright (C) Jeremy Allison 2004
12
13    This program is free software; you can redistribute it and/or modify
14    it under the terms of the GNU General Public License as published by
15    the Free Software Foundation; either version 2 of the License, or
16    (at your option) any later version.
17
18    This program is distributed in the hope that it will be useful,
19    but WITHOUT ANY WARRANTY; without even the implied warranty of
20    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
21    GNU General Public License for more details.
22
23    You should have received a copy of the GNU General Public License
24    along with this program; if not, write to the Free Software
25    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
26 */
27
28 #include "includes.h"
29
30 #ifdef HAVE_KRB5
31
32 /**********************************************************************
33  Adds a single service principal, i.e. 'host' to the system keytab
34 ***********************************************************************/
35
36 int ads_keytab_add_entry(ADS_STRUCT *ads, const char *srvPrinc)
37 {
38         krb5_error_code ret = 0;
39         krb5_context context = NULL;
40         krb5_keytab keytab = NULL;
41         krb5_kt_cursor cursor;
42         krb5_keytab_entry kt_entry;
43         krb5_principal princ = NULL;
44         krb5_data password;
45         krb5_enctype *enctypes = NULL;
46         krb5_kvno kvno;
47
48         char *principal = NULL;
49         char *princ_s = NULL;
50         char *password_s = NULL;
51 #ifndef MAX_KEYTAB_NAME_LEN
52 #define MAX_KEYTAB_NAME_LEN 1100
53 #endif
54         char keytab_name[MAX_KEYTAB_NAME_LEN];          /* This MAX_NAME_LEN is a constant defined in krb5.h */
55         fstring my_fqdn;
56         int i;
57         char *ktprinc = NULL;
58
59         ZERO_STRUCT(kt_entry);
60         ZERO_STRUCT(cursor);
61
62         initialize_krb5_error_table();
63         ret = krb5_init_context(&context);
64         if (ret) {
65                 DEBUG(1,("ads_keytab_add_entry: could not krb5_init_context: %s\n",error_message(ret)));
66                 return -1;
67         }
68 #ifdef HAVE_WRFILE_KEYTAB       /* MIT */
69         keytab_name[0] = 'W';
70         keytab_name[1] = 'R';
71         ret = krb5_kt_default_name(context, (char *) &keytab_name[2], MAX_KEYTAB_NAME_LEN - 4);
72 #else                           /* Heimdal */
73         ret = krb5_kt_default_name(context, (char *) &keytab_name[0], MAX_KEYTAB_NAME_LEN - 2);
74 #endif
75         if (ret) {
76                 DEBUG(1,("ads_keytab_add_entry: krb5_kt_default_name failed (%s)\n", error_message(ret)));
77                 goto out;
78         }
79         DEBUG(2,("ads_keytab_add_entry: Using default system keytab: %s\n", (char *) &keytab_name));
80         ret = krb5_kt_resolve(context, (char *) &keytab_name, &keytab);
81         if (ret) {
82                 DEBUG(1,("ads_keytab_add_entry: krb5_kt_resolve failed (%s)\n", error_message(ret)));
83                 goto out;
84         }
85
86         /* retrieve the password */
87         if (!secrets_init()) {
88                 DEBUG(1,("ads_keytab_add_entry: secrets_init failed\n"));
89                 ret = -1;
90                 goto out;
91         }
92         password_s = secrets_fetch_machine_password(lp_workgroup(), NULL, NULL);
93         if (!password_s) {
94                 DEBUG(1,("ads_keytab_add_entry: failed to fetch machine password\n"));
95                 ret = -1;
96                 goto out;
97         }
98         password.data = password_s;
99         password.length = strlen(password_s);
100
101         /* Construct our principal */
102         name_to_fqdn(my_fqdn, global_myname());
103         strlower_m(my_fqdn);
104
105         if (strchr_m(srvPrinc, '@')) {
106                 /* It's a fully-named principal. */
107                 asprintf(&princ_s, "%s", srvPrinc);
108         } else if (srvPrinc[strlen(srvPrinc)-1] == '$') {
109                 /* It's the machine account, as used by smbclient clients. */
110                 asprintf(&princ_s, "%s@%s", srvPrinc, lp_realm());
111         } else {
112                 /* It's a normal service principal.  Add the SPN now so that we
113                  * can obtain credentials for it and double-check the salt value
114                  * used to generate the service's keys. */
115                 asprintf(&princ_s, "%s/%s@%s", srvPrinc, my_fqdn, lp_realm());
116                 /* Update the directory with the SPN */
117                 DEBUG(3,("ads_keytab_add_entry: Attempting to add/update '%s'\n", princ_s));
118                 if (!ADS_ERR_OK(ads_add_service_principal_name(ads, global_myname(), srvPrinc))) {
119                         DEBUG(1,("ads_keytab_add_entry: ads_add_service_principal_name failed.\n"));
120                         goto out;
121                 }
122         }
123
124         ret = get_kerberos_allowed_etypes(context,&enctypes);
125         if (ret) {
126                 DEBUG(1,("ads_keytab_add_entry: get_kerberos_allowed_etypes failed (%s)\n",error_message(ret)));
127                 goto out;
128         }
129
130         /* Guess at how the KDC is salting keys for this principal. */
131         kerberos_derive_salting_principal(context, NULL, enctypes, princ_s);
132
133         ret = krb5_parse_name(context, princ_s, &princ);
134         if (ret) {
135                 DEBUG(1,("ads_keytab_add_entry: krb5_parse_name(%s) failed (%s)\n", princ_s, error_message(ret)));
136                 goto out;
137         }
138
139         kvno = (krb5_kvno) ads_get_kvno(ads, global_myname());
140         if (kvno == -1) {       /* -1 indicates failure, everything else is OK */
141                 DEBUG(1,("ads_keytab_add_entry: ads_get_kvno failed to determine the system's kvno.\n"));
142                 ret = -1;
143                 goto out;
144         }
145
146         /* Seek and delete old keytab entries */
147         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
148         if (ret != KRB5_KT_END && ret != ENOENT ) {
149                 DEBUG(3,("ads_keytab_add_entry: Will try to delete old keytab entries\n"));
150                 while(!krb5_kt_next_entry(context, keytab, &kt_entry, &cursor)) {
151                         BOOL compare_ok = False;
152
153                         ret = krb5_unparse_name(context, kt_entry.principal, &ktprinc);
154                         if (ret) {
155                                 DEBUG(1,("ads_keytab_add_entry: krb5_unparse_name failed (%s)\n", error_message(ret)));
156                                 goto out;
157                         }
158
159                         /*---------------------------------------------------------------------------
160                          * Save the entries with kvno - 1.   This is what microsoft does
161                          * to allow people with existing sessions that have kvno - 1 to still
162                          * work.   Otherwise, when the password for the machine changes, all
163                          * kerberizied sessions will 'break' until either the client reboots or
164                          * the client's session key expires and they get a new session ticket
165                          * with the new kvno.
166                          */
167
168 #ifdef HAVE_KRB5_KT_COMPARE
169                         compare_ok = ((krb5_kt_compare(context, &kt_entry, princ, 0, 0) == True) && (kt_entry.vno != kvno - 1));
170 #else
171                         compare_ok = ((strcmp(ktprinc, princ_s) == 0) && (kt_entry.vno != kvno - 1));
172 #endif
173                         krb5_free_unparsed_name(context, ktprinc);
174                         ktprinc = NULL;
175
176                         if (compare_ok) {
177                                 DEBUG(3,("ads_keytab_add_entry: Found old entry for principal: %s (kvno %d) - trying to remove it.\n",
178                                         princ_s, kt_entry.vno));
179                                 ret = krb5_kt_end_seq_get(context, keytab, &cursor);
180                                 ZERO_STRUCT(cursor);
181                                 if (ret) {
182                                         DEBUG(1,("ads_keytab_add_entry: krb5_kt_end_seq_get() failed (%s)\n",
183                                                 error_message(ret)));
184                                         goto out;
185                                 }
186                                 ret = krb5_kt_remove_entry(context, keytab, &kt_entry);
187                                 if (ret) {
188                                         DEBUG(1,("ads_keytab_add_entry: krb5_kt_remove_entry failed (%s)\n",
189                                                 error_message(ret)));
190                                         goto out;
191                                 }
192                                 ret = krb5_kt_start_seq_get(context, keytab, &cursor);
193                                 if (ret) {
194                                         DEBUG(1,("ads_keytab_add_entry: krb5_kt_start_seq failed (%s)\n",
195                                                 error_message(ret)));
196                                         goto out;
197                                 }
198                                 ret = smb_krb5_kt_free_entry(context, &kt_entry);
199                                 ZERO_STRUCT(kt_entry);
200                                 if (ret) {
201                                         DEBUG(1,("ads_keytab_add_entry: krb5_kt_remove_entry failed (%s)\n",
202                                                 error_message(ret)));
203                                         goto out;
204                                 }
205                                 continue;
206                         }
207
208                         /* Not a match, just free this entry and continue. */
209                         ret = smb_krb5_kt_free_entry(context, &kt_entry);
210                         ZERO_STRUCT(kt_entry);
211                         if (ret) {
212                                 DEBUG(1,("ads_keytab_add_entry: smb_krb5_kt_free_entry failed (%s)\n", error_message(ret)));
213                                 goto out;
214                         }
215                 }
216
217                 ret = krb5_kt_end_seq_get(context, keytab, &cursor);
218                 ZERO_STRUCT(cursor);
219                 if (ret) {
220                         DEBUG(1,("ads_keytab_add_entry: krb5_kt_end_seq_get failed (%s)\n",error_message(ret)));
221                         goto out;
222                 }
223         }
224
225         /* Ensure we don't double free. */
226         ZERO_STRUCT(kt_entry);
227         ZERO_STRUCT(cursor);
228
229         /* If we get here, we have deleted all the old entries with kvno's not equal to the current kvno-1. */
230
231         /* Now add keytab entries for all encryption types */
232         for (i = 0; enctypes[i]; i++) {
233                 krb5_keyblock *keyp;
234
235 #if !defined(HAVE_KRB5_KEYTAB_ENTRY_KEY) && !defined(HAVE_KRB5_KEYTAB_ENTRY_KEYBLOCK)
236 #error krb5_keytab_entry has no key or keyblock member
237 #endif
238 #ifdef HAVE_KRB5_KEYTAB_ENTRY_KEY               /* MIT */
239                 keyp = &kt_entry.key;
240 #endif
241 #ifdef HAVE_KRB5_KEYTAB_ENTRY_KEYBLOCK          /* Heimdal */
242                 keyp = &kt_entry.keyblock;
243 #endif
244                 if (create_kerberos_key_from_string(context, princ, &password, keyp, enctypes[i])) {
245                         continue;
246                 }
247
248                 kt_entry.principal = princ;
249                 kt_entry.vno       = kvno;
250
251                 DEBUG(3,("ads_keytab_add_entry: adding keytab entry for (%s) with encryption type (%d) and version (%d)\n",
252                         princ_s, enctypes[i], kt_entry.vno));
253                 ret = krb5_kt_add_entry(context, keytab, &kt_entry);
254                 krb5_free_keyblock_contents(context, keyp);
255                 ZERO_STRUCT(kt_entry);
256                 if (ret) {
257                         DEBUG(1,("ads_keytab_add_entry: adding entry to keytab failed (%s)\n", error_message(ret)));
258                         goto out;
259                 }
260         }
261
262         krb5_kt_close(context, keytab);
263         keytab = NULL; /* Done with keytab now. No double free. */
264
265 out:
266
267         SAFE_FREE(principal);
268         SAFE_FREE(password_s);
269         SAFE_FREE(princ_s);
270
271         {
272                 krb5_keytab_entry zero_kt_entry;
273                 ZERO_STRUCT(zero_kt_entry);
274                 if (memcmp(&zero_kt_entry, &kt_entry, sizeof(krb5_keytab_entry))) {
275                         smb_krb5_kt_free_entry(context, &kt_entry);
276                 }
277         }
278         if (princ) {
279                 krb5_free_principal(context, princ);
280         }
281         if (enctypes) {
282                 free_kerberos_etypes(context, enctypes);
283         }
284
285         {
286                 krb5_kt_cursor zero_csr;
287                 ZERO_STRUCT(zero_csr);
288                 if ((memcmp(&cursor, &zero_csr, sizeof(krb5_kt_cursor)) != 0) && keytab) {
289                         krb5_kt_end_seq_get(context, keytab, &cursor);  
290                 }
291         }
292         if (keytab) {
293                 krb5_kt_close(context, keytab);
294         }
295         if (context) {
296                 krb5_free_context(context);
297         }
298         return (int)ret;
299 }
300
301 /**********************************************************************
302  Flushes all entries from the system keytab.
303 ***********************************************************************/
304
305 int ads_keytab_flush(ADS_STRUCT *ads)
306 {
307         krb5_error_code ret = 0;
308         krb5_context context = NULL;
309         krb5_keytab keytab = NULL;
310         krb5_kt_cursor cursor;
311         krb5_keytab_entry kt_entry;
312         krb5_kvno kvno;
313         char keytab_name[MAX_KEYTAB_NAME_LEN];
314
315         ZERO_STRUCT(kt_entry);
316         ZERO_STRUCT(cursor);
317
318         initialize_krb5_error_table();
319         ret = krb5_init_context(&context);
320         if (ret) {
321                 DEBUG(1,("ads_keytab_flush: could not krb5_init_context: %s\n",error_message(ret)));
322                 return ret;
323         }
324 #ifdef HAVE_WRFILE_KEYTAB
325         keytab_name[0] = 'W';
326         keytab_name[1] = 'R';
327         ret = krb5_kt_default_name(context, (char *) &keytab_name[2], MAX_KEYTAB_NAME_LEN - 4);
328 #else
329         ret = krb5_kt_default_name(context, (char *) &keytab_name[0], MAX_KEYTAB_NAME_LEN - 2);
330 #endif
331         if (ret) {
332                 DEBUG(1,("ads_keytab_flush: krb5_kt_default failed (%s)\n", error_message(ret)));
333                 goto out;
334         }
335         DEBUG(3,("ads_keytab_flush: Using default keytab: %s\n", (char *) &keytab_name));
336         ret = krb5_kt_resolve(context, (char *) &keytab_name, &keytab);
337         if (ret) {
338                 DEBUG(1,("ads_keytab_flush: krb5_kt_default failed (%s)\n", error_message(ret)));
339                 goto out;
340         }
341         ret = krb5_kt_resolve(context, (char *) &keytab_name, &keytab);
342         if (ret) {
343                 DEBUG(1,("ads_keytab_flush: krb5_kt_default failed (%s)\n", error_message(ret)));
344                 goto out;
345         }
346
347         kvno = (krb5_kvno) ads_get_kvno(ads, global_myname());
348         if (kvno == -1) {       /* -1 indicates a failure */
349                 DEBUG(1,("ads_keytab_flush: Error determining the system's kvno.\n"));
350                 goto out;
351         }
352
353         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
354         if (ret != KRB5_KT_END && ret != ENOENT) {
355                 while (!krb5_kt_next_entry(context, keytab, &kt_entry, &cursor)) {
356                         ret = krb5_kt_end_seq_get(context, keytab, &cursor);
357                         ZERO_STRUCT(cursor);
358                         if (ret) {
359                                 DEBUG(1,("ads_keytab_flush: krb5_kt_end_seq_get() failed (%s)\n",error_message(ret)));
360                                 goto out;
361                         }
362                         ret = krb5_kt_remove_entry(context, keytab, &kt_entry);
363                         if (ret) {
364                                 DEBUG(1,("ads_keytab_flush: krb5_kt_remove_entry failed (%s)\n",error_message(ret)));
365                                 goto out;
366                         }
367                         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
368                         if (ret) {
369                                 DEBUG(1,("ads_keytab_flush: krb5_kt_start_seq failed (%s)\n",error_message(ret)));
370                                 goto out;
371                         }
372                         ret = smb_krb5_kt_free_entry(context, &kt_entry);
373                         ZERO_STRUCT(kt_entry);
374                         if (ret) {
375                                 DEBUG(1,("ads_keytab_flush: krb5_kt_remove_entry failed (%s)\n",error_message(ret)));
376                                 goto out;
377                         }
378                 }
379         }
380
381         /* Ensure we don't double free. */
382         ZERO_STRUCT(kt_entry);
383         ZERO_STRUCT(cursor);
384
385         if (!ADS_ERR_OK(ads_clear_service_principal_names(ads, global_myname()))) {
386                 DEBUG(1,("ads_keytab_flush: Error while clearing service principal listings in LDAP.\n"));
387                 goto out;
388         }
389
390 out:
391
392         {
393                 krb5_keytab_entry zero_kt_entry;
394                 ZERO_STRUCT(zero_kt_entry);
395                 if (memcmp(&zero_kt_entry, &kt_entry, sizeof(krb5_keytab_entry))) {
396                         smb_krb5_kt_free_entry(context, &kt_entry);
397                 }
398         }
399         {
400                 krb5_kt_cursor zero_csr;
401                 ZERO_STRUCT(zero_csr);
402                 if ((memcmp(&cursor, &zero_csr, sizeof(krb5_kt_cursor)) != 0) && keytab) {
403                         krb5_kt_end_seq_get(context, keytab, &cursor);  
404                 }
405         }
406         if (keytab) {
407                 krb5_kt_close(context, keytab);
408         }
409         if (context) {
410                 krb5_free_context(context);
411         }
412         return ret;
413 }
414
415 /**********************************************************************
416  Adds all the required service principals to the system keytab.
417 ***********************************************************************/
418
419 int ads_keytab_create_default(ADS_STRUCT *ads)
420 {
421         krb5_error_code ret = 0;
422         krb5_context context = NULL;
423         krb5_keytab keytab = NULL;
424         krb5_kt_cursor cursor;
425         krb5_keytab_entry kt_entry;
426         krb5_kvno kvno;
427         fstring my_fqdn, my_Fqdn, my_name, my_NAME;
428         int i, found = 0;
429         char **oldEntries = NULL, *princ_s[18];;
430
431         ret = ads_keytab_add_entry(ads, "host");
432         if (ret) {
433                 DEBUG(1,("ads_keytab_create_default: ads_keytab_add_entry failed while adding 'host'.\n"));
434                 return ret;
435         }
436         ret = ads_keytab_add_entry(ads, "cifs");
437         if (ret) {
438                 DEBUG(1,("ads_keytab_create_default: ads_keytab_add_entry failed while adding 'cifs'.\n"));
439                 return ret;
440         }
441
442         fstrcpy(my_name, global_myname());
443         strlower_m(my_name);
444         fstrcpy(my_NAME, global_myname());
445         strupper_m(my_NAME);
446         name_to_fqdn(my_Fqdn, global_myname());
447         strlower_m(my_Fqdn);
448         memcpy(my_Fqdn, my_NAME, strlen(my_NAME));
449         name_to_fqdn(my_fqdn, global_myname());
450         strlower_m(my_fqdn);
451
452         asprintf(&princ_s[0], "%s$@%s", my_name, lp_realm());
453         asprintf(&princ_s[1], "%s$@%s", my_NAME, lp_realm());
454         asprintf(&princ_s[2], "host/%s@%s", my_name, lp_realm());
455         asprintf(&princ_s[3], "host/%s@%s", my_NAME, lp_realm());
456         asprintf(&princ_s[4], "host/%s@%s", my_fqdn, lp_realm());
457         asprintf(&princ_s[5], "host/%s@%s", my_Fqdn, lp_realm());
458         asprintf(&princ_s[6], "HOST/%s@%s", my_name, lp_realm());
459         asprintf(&princ_s[7], "HOST/%s@%s", my_NAME, lp_realm());
460         asprintf(&princ_s[8], "HOST/%s@%s", my_fqdn, lp_realm());
461         asprintf(&princ_s[9], "HOST/%s@%s", my_Fqdn, lp_realm());
462         asprintf(&princ_s[10], "cifs/%s@%s", my_name, lp_realm());
463         asprintf(&princ_s[11], "cifs/%s@%s", my_NAME, lp_realm());
464         asprintf(&princ_s[12], "cifs/%s@%s", my_fqdn, lp_realm());
465         asprintf(&princ_s[13], "cifs/%s@%s", my_Fqdn, lp_realm());
466         asprintf(&princ_s[14], "CIFS/%s@%s", my_name, lp_realm());
467         asprintf(&princ_s[15], "CIFS/%s@%s", my_NAME, lp_realm());
468         asprintf(&princ_s[16], "CIFS/%s@%s", my_fqdn, lp_realm());
469         asprintf(&princ_s[17], "CIFS/%s@%s", my_Fqdn, lp_realm());
470
471         for (i = 0; i < sizeof(princ_s) / sizeof(princ_s[0]); i++) {
472                 if (princ_s[i] != NULL) {
473                         ret = ads_keytab_add_entry(ads, princ_s[i]);
474                         if (ret != 0) {
475                                 DEBUG(1,("ads_keytab_create_default: ads_keytab_add_entry failed while adding '%s'.\n", princ_s[i]));
476                         }
477                         SAFE_FREE(princ_s[i]);
478                 }
479         }
480
481         kvno = (krb5_kvno) ads_get_kvno(ads, global_myname());
482         if (kvno == -1) {
483                 DEBUG(1,("ads_keytab_create_default: ads_get_kvno failed to determine the system's kvno.\n"));
484                 return -1;
485         }
486
487         DEBUG(3,("ads_keytab_create_default: Searching for keytab entries to preserve and update.\n"));
488         /* Now loop through the keytab and update any other existing entries... */
489
490         ZERO_STRUCT(kt_entry);
491         ZERO_STRUCT(cursor);
492
493         initialize_krb5_error_table();
494         ret = krb5_init_context(&context);
495         if (ret) {
496                 DEBUG(1,("ads_keytab_create_default: could not krb5_init_context: %s\n",error_message(ret)));
497                 return ret;
498         }
499         ret = krb5_kt_default(context, &keytab);
500         if (ret) {
501                 DEBUG(1,("ads_keytab_create_default: krb5_kt_default failed (%s)\n",error_message(ret)));
502                 goto done;
503         }
504
505         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
506         if (ret != KRB5_KT_END && ret != ENOENT ) {
507                 while ((ret = krb5_kt_next_entry(context, keytab, &kt_entry, &cursor)) == 0) {
508                         smb_krb5_kt_free_entry(context, &kt_entry);
509                         ZERO_STRUCT(kt_entry);
510                         found++;
511                 }
512         }
513         krb5_kt_end_seq_get(context, keytab, &cursor);
514         ZERO_STRUCT(cursor);
515
516         /*
517          * Hmmm. There is no "rewind" function for the keytab. This means we have a race condition
518          * where someone else could add entries after we've counted them. Re-open asap to minimise
519          * the race. JRA.
520          */
521         
522         DEBUG(3, ("ads_keytab_create_default: Found %d entries in the keytab.\n", found));
523         if (!found) {
524                 goto done;
525         }
526         oldEntries = (char **) malloc(found * sizeof(char *));
527         if (!oldEntries) {
528                 DEBUG(1,("ads_keytab_create_default: Failed to allocate space to store the old keytab entries (malloc failed?).\n"));
529                 ret = -1;
530                 goto done;
531         }
532         memset(oldEntries, '\0', found * sizeof(char *));
533
534         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
535         if (ret != KRB5_KT_END && ret != ENOENT ) {
536                 while (krb5_kt_next_entry(context, keytab, &kt_entry, &cursor) == 0) {
537                         if (kt_entry.vno != kvno) {
538                                 char *ktprinc = NULL;
539                                 char *p;
540
541                                 /* This returns a malloc'ed string in ktprinc. */
542                                 ret = krb5_unparse_name(context, kt_entry.principal, &ktprinc);
543                                 if (ret) {
544                                         DEBUG(1,("krb5_unparse_name failed (%s)\n", error_message(ret)));
545                                         goto done;
546                                 }
547                                 /*
548                                  * From looking at the krb5 source they don't seem to take locale
549                                  * or mb strings into account. Maybe this is because they assume utf8 ?
550                                  * In this case we may need to convert from utf8 to mb charset here ? JRA.
551                                  */
552                                 p = strchr_m(ktprinc, '@');
553                                 if (p) {
554                                         *p = '\0';
555                                 }
556
557                                 p = strchr_m(ktprinc, '/');
558                                 if (p) {
559                                         *p = '\0';
560                                 }
561                                 for (i = 0; i < found; i++) {
562                                         if (!oldEntries[i]) {
563                                                 oldEntries[i] = ktprinc;
564                                                 break;
565                                         }
566                                         if (!strcmp(oldEntries[i], ktprinc)) {
567                                                 krb5_free_unparsed_name(context, ktprinc);
568                                                 break;
569                                         }
570                                 }
571                                 if (i == found) {
572                                         krb5_free_unparsed_name(context, ktprinc);
573                                 }
574                         }
575                         smb_krb5_kt_free_entry(context, &kt_entry);
576                         ZERO_STRUCT(kt_entry);
577                 }
578                 ret = 0;
579                 for (i = 0; oldEntries[i]; i++) {
580                         ret |= ads_keytab_add_entry(ads, oldEntries[i]);
581                         krb5_free_unparsed_name(context, oldEntries[i]);
582                 }
583                 krb5_kt_end_seq_get(context, keytab, &cursor);
584         }
585         ZERO_STRUCT(cursor);
586
587 done:
588
589         SAFE_FREE(oldEntries);
590
591         {
592                 krb5_keytab_entry zero_kt_entry;
593                 ZERO_STRUCT(zero_kt_entry);
594                 if (memcmp(&zero_kt_entry, &kt_entry, sizeof(krb5_keytab_entry))) {
595                         smb_krb5_kt_free_entry(context, &kt_entry);
596                 }
597         }
598         {
599                 krb5_kt_cursor zero_csr;
600                 ZERO_STRUCT(zero_csr);
601                 if ((memcmp(&cursor, &zero_csr, sizeof(krb5_kt_cursor)) != 0) && keytab) {
602                         krb5_kt_end_seq_get(context, keytab, &cursor);  
603                 }
604         }
605         if (keytab) {
606                 krb5_kt_close(context, keytab);
607         }
608         if (context) {
609                 krb5_free_context(context);
610         }
611         return ret;
612 }
613 #endif /* HAVE_KRB5 */