2 Author: Gerald Combs <gerald@wireshark.org>
3 Date: Thu Jul 14 11:05:17 2016 -0700
7 Change-Id: I2895d29415bb191bf2d7fc0a4468f085085bd4d9
10 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
11 Date: Thu Jul 14 18:12:16 2016 +0100
13 IPv6: Fix jumbo payload length offset
15 Change-Id: I52fb082782674cc851b246d3b6afa7b4f14bbe34
16 Reviewed-on: https://code.wireshark.org/review/16434
17 Reviewed-by: João Valverde <j@v6e.pt>
20 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
21 Date: Thu Jul 14 17:55:31 2016 +0100
23 IPv6: Fix Jumbogram hop-by-hop expert info
25 Change-Id: I751acad2fad501b700c01a37bafa96d2add8fb36
26 Reviewed-on: https://code.wireshark.org/review/16433
27 Reviewed-by: João Valverde <j@v6e.pt>
30 Author: Guy Harris <guy@alum.mit.edu>
31 Date: Thu Jul 14 10:08:26 2016 -0700
35 (Gotta ensure that there's always at least one commit here that's less
38 Change-Id: I297920f1b68dd49550ce07544797a9f2cb854cf5
39 Reviewed-on: https://code.wireshark.org/review/16432
40 Reviewed-by: Guy Harris <guy@alum.mit.edu>
43 Author: Pascal Quantin <pascal.quantin@gmail.com>
44 Date: Thu Jul 14 15:07:59 2016 +0200
46 MBIM: add dissection of AT&T proprietary UUID
48 Based on AT&T Windows 8 Extended API Requirements version 1.8.0
50 Change-Id: Iaf54173812a02023581c530f2340ea21e9e220d9
51 Reviewed-on: https://code.wireshark.org/review/16431
52 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
53 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
54 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
57 Author: Daniele Lacamera <daniele.lacamera@technicolor.com>
58 Date: Thu Jul 14 14:08:56 2016 +0200
60 DHCP: correctly parse PXE options (209-210)
62 option 209 was marked as opaque, now it's as PXELINUX config file (text)
63 --> Fix: decorate as non-null terminated string
64 --> CfR: IETF RFC5071 section 4.2. "Packet Format"
66 option 210 was marked as special, and erroneously decorated as Authentication
68 --> Fix: decorate as non-null terminated string
69 --> CfR: IETF RFC5071 section 5.2. "Packet Format"
72 Change-Id: I4220c137ef4b8b7f0827496c165b0ca35b70f675
73 Reviewed-on: https://code.wireshark.org/review/16430
74 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
75 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
76 Reviewed-by: Michael Mann <mmann78@netscape.net>
79 Author: Pascal Quantin <pascal.quantin@gmail.com>
80 Date: Thu Jul 14 14:33:01 2016 +0200
82 ETAG: add explicit casts to please OSX buildbot
84 Change-Id: I057ffc6eb5e6c16e05b0ddc1c069159980678b85
85 Reviewed-on: https://code.wireshark.org/review/16429
86 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
89 Author: Michael Mann <mmann78@netscape.net>
90 Date: Thu Jul 14 07:46:13 2016 -0400
92 packet-beep.c: Pacify OS X buildbot with cast
94 Change-Id: I0149546cdd2aac8335dcb1046d31ed857ed674f3
95 Reviewed-on: https://code.wireshark.org/review/16428
96 Reviewed-by: Michael Mann <mmann78@netscape.net>
99 Author: Michael Mann <mmann78@netscape.net>
100 Date: Wed Jul 13 19:48:22 2016 -0400
102 proto.c: Unsigned fields should use %u within printf.
104 Found by VS Code Analysis
106 Change-Id: I76ea860cd86b41ef33c47dcc8f6b1c122f8bb668
107 Reviewed-on: https://code.wireshark.org/review/16424
108 Petri-Dish: Anders Broman <a.broman58@gmail.com>
109 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
110 Reviewed-by: Anders Broman <a.broman58@gmail.com>
113 Author: Pascal Quantin <pascal.quantin@gmail.com>
114 Date: Thu Jul 14 10:59:48 2016 +0200
116 MBIM: add a missing break
118 Change-Id: I3a4483861b1d97ff5e43041b3ecca64c3077b284
119 Reviewed-on: https://code.wireshark.org/review/16427
120 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
123 Author: William Tu <u9012063@gmail.com>
124 Date: Tue Jul 12 11:09:31 2016 -0700
126 Add ERSPAN II support for field EN and Index.
128 Current ERSPAN II dissector does not support parsing EN field and Index.
129 The patch follows the field description in draft:
130 https://tools.ietf.org/html/draft-foschiano-erspan-01
132 Change-Id: I92ce56264be0fb2560c4d1a5da35738cf45a8c96
133 Reviewed-on: https://code.wireshark.org/review/16400
134 Reviewed-by: Michael Mann <mmann78@netscape.net>
135 Petri-Dish: Michael Mann <mmann78@netscape.net>
136 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
137 Reviewed-by: Anders Broman <a.broman58@gmail.com>
140 Author: Michael Mann <mmann78@netscape.net>
141 Date: Tue Jul 12 13:18:05 2016 -0400
143 packet-beep.c: Use strtol over scanf to prevent analysis warnings.
145 Change-Id: I9244edc537d2eb49d73e097a4cb34bf2cde868e4
146 Reviewed-on: https://code.wireshark.org/review/16395
147 Reviewed-by: Michael Mann <mmann78@netscape.net>
148 Petri-Dish: Michael Mann <mmann78@netscape.net>
149 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
150 Reviewed-by: Anders Broman <a.broman58@gmail.com>
153 Author: Pascal Quantin <pascal.quantin@gmail.com>
154 Date: Wed Jul 13 23:50:31 2016 +0200
156 LTE RRC: add dissection of schedulingInfoSIB1-r13 field
158 Change-Id: I226ae82a2d75a9b658a0e9122b4ef1925b003279
159 Reviewed-on: https://code.wireshark.org/review/16417
160 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
161 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
162 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
163 Reviewed-by: Anders Broman <a.broman58@gmail.com>
166 Author: Gerald Combs <gerald@wireshark.org>
167 Date: Wed Jul 13 14:51:56 2016 -0700
169 Qt: Allocate packet list records using wmem.
171 Add PacketListRecord::operator new, which uses wmem_alloc. Roughly
172 matches the GTK+ UI behavior. Add ColumnTextList which also uses
175 Lazily allocate our column text.
177 Change-Id: I86a63cd8ace7764eaab1561bf71b4358af72fe03
178 Reviewed-on: https://code.wireshark.org/review/16418
179 Reviewed-by: Gerald Combs <gerald@wireshark.org>
180 Petri-Dish: Gerald Combs <gerald@wireshark.org>
181 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
182 Reviewed-by: Anders Broman <a.broman58@gmail.com>
185 Author: Michael Mann <mmann78@netscape.net>
186 Date: Wed Jul 13 18:18:03 2016 -0400
188 androiddump.c: Use preprocessor directive to distinguish E_AGAIN and E_WOULDBLOCK.
190 VS Code analysis considers them hardcoded values so the if statement is either
191 always true or always false.
193 Change-Id: Iad04add9391c515873e2e00d2c6cbd682fbf5b3f
194 Reviewed-on: https://code.wireshark.org/review/16419
195 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
196 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
197 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
198 Reviewed-by: Anders Broman <a.broman58@gmail.com>
201 Author: Guy Harris <guy@alum.mit.edu>
202 Date: Wed Jul 13 20:13:22 2016 -0700
204 Fix VHT valid checks.
206 The valid array in a struct mcs_vht_valid is indexed by the bandwidth
207 and the NSS-1; use the NSS-1, not the NSS, as the index.
209 The maximum possible value of the NSS is MAX_VHT_NSS, so allow a value
212 Change-Id: I49585f217f3e70356c1dd1ba32b6c714ce202236
213 Reviewed-on: https://code.wireshark.org/review/16426
214 Reviewed-by: Guy Harris <guy@alum.mit.edu>
217 Author: Michael Mann <mmann78@netscape.net>
218 Date: Wed Jul 13 19:42:15 2016 -0400
220 vwr.c Dynamically allocate large buffers
222 VS Code Analysis claims the arrays are too large and should be moved to help
224 Change-Id: I741ebe8cc73a108cb6e6d9ecbda37e2a4b6e1b4b
225 Reviewed-on: https://code.wireshark.org/review/16423
226 Petri-Dish: Michael Mann <mmann78@netscape.net>
227 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
228 Reviewed-by: Michael Mann <mmann78@netscape.net>
231 Author: Michael Mann <mmann78@netscape.net>
232 Date: Wed Jul 13 19:26:16 2016 -0400
234 pcapng.c: Use preprocessor directive to compare G_BYTE_ORDER with G_LITTLE_ENDIAN.
236 VS Code analysis considers them hardcoded values so the if statement is either
237 always true or always false.
239 Change-Id: Iabb8462b66f728195bf378ae26c79a783feddb03
240 Reviewed-on: https://code.wireshark.org/review/16422
241 Reviewed-by: Michael Mann <mmann78@netscape.net>
244 Author: Michael Mann <mmann78@netscape.net>
245 Date: Wed Jul 13 18:42:14 2016 -0400
247 packet-ieee80211-radio.c: Prevent array overflow.
249 Found by VS Code Analysis.
251 Change-Id: Idab6cb5496749ebff47466b20a9a665b1574565d
252 Reviewed-on: https://code.wireshark.org/review/16421
253 Reviewed-by: Michael Mann <mmann78@netscape.net>
256 Author: Michael Mann <mmann78@netscape.net>
257 Date: Wed Jul 13 18:23:03 2016 -0400
259 packet-gsm_a_common.c: Create typedef declaration for elem_func signature.
261 This should keep VS Code Analysis happy.
263 Change-Id: I99ebdc644ba353d5986d6509da784eeaa37dcc8f
264 Reviewed-on: https://code.wireshark.org/review/16420
265 Reviewed-by: Michael Mann <mmann78@netscape.net>
268 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
269 Date: Tue Dec 29 19:30:58 2015 +0000
271 IPv6: Add support for more option types
273 Change-Id: I1027e6e2481774953216ade6da4785e1a3c5ca63
274 Reviewed-on: https://code.wireshark.org/review/16357
275 Petri-Dish: João Valverde <j@v6e.pt>
276 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
277 Reviewed-by: João Valverde <j@v6e.pt>
280 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
281 Date: Tue Dec 29 12:15:44 2015 +0000
283 IPv6: Refactor dissect_opts() into type-specific dissectors
285 Change-Id: Ife8a7da3bd9bfea347321413bf05ea454186bc6d
286 Reviewed-on: https://code.wireshark.org/review/16356
287 Petri-Dish: João Valverde <j@v6e.pt>
288 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
289 Reviewed-by: João Valverde <j@v6e.pt>
292 Author: dsrsupport <eugene.exarevsky@dsr-company.com>
293 Date: Wed Jul 13 14:33:55 2016 +0300
295 ZigBee: fix column description for APS ACK to T2 packet
297 If this is APS ACK, do not overwrite its column description by Test Profile command description.
299 Change-Id: Ibd4ae978776ad9e9924e6933ede90bc2ad8855de
300 Reviewed-on: https://code.wireshark.org/review/16414
301 Petri-Dish: Michael Mann <mmann78@netscape.net>
302 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
303 Reviewed-by: Michael Mann <mmann78@netscape.net>
306 Author: Gerald Combs <gerald@wireshark.org>
307 Date: Wed Jul 13 11:06:52 2016 -0700
309 Speed up col_append_ports on Windows.
311 Fill in our port information using StringCchPrintf on Windows instead
312 of g_snprintf. Loading a large-ish test capture here under the VS 2013
313 profiler showed that we spent 620 samples in col_append_ports. Switching
314 from g_snprintf to StringCchPrintf reduced that to six samples.
316 Inline col_snprint_port while we're here.
318 Change-Id: I955e5baa66ebb9cc950fc0eb1682d3c015c7a55a
319 Reviewed-on: https://code.wireshark.org/review/16416
320 Petri-Dish: Gerald Combs <gerald@wireshark.org>
321 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
322 Reviewed-by: Gerald Combs <gerald@wireshark.org>
325 Author: Kim Kempf <kim.kempf@apcon.com>
326 Date: Tue Jul 12 10:28:38 2016 -0700
328 Adding 802.1BR E-Tag dissector
330 Based on IEEE Std 802.1BR-2012
333 Change-Id: Ic5198471f67a1af728df40a09443a1cab2621169
334 Reviewed-on: https://code.wireshark.org/review/16402
335 Reviewed-by: Michael Mann <mmann78@netscape.net>
338 Author: Michael Mann <mmann78@netscape.net>
339 Date: Tue Jul 12 22:53:39 2016 -0400
341 Support Juniper VN over UDP.
343 Change-Id: I40dab9d392ddea1f895b88f8f19c1194e56563a2
344 Reviewed-on: https://code.wireshark.org/review/16408
345 Reviewed-by: Amitoj Setia <amitoj_setia@yahoo.com>
346 Petri-Dish: Michael Mann <mmann78@netscape.net>
347 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
348 Reviewed-by: Michael Mann <mmann78@netscape.net>
351 Author: dsrsupport <eugene.exarevsky@dsr-company.com>
352 Date: Wed Jul 13 12:40:54 2016 +0300
354 ZigBee MAC parse: fix Association request parse in case of FCS absence.
356 If it is ok to parse packets with bas FSC, FCS may be even absent. Parse MAC command even if remaining buffer length is less that FCS size in such case.
358 Change-Id: Ibbc9fed7ab87d0511f8c97db8e0e3bdf562cd15c
359 Reviewed-on: https://code.wireshark.org/review/16412
360 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
361 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
362 Reviewed-by: Michael Mann <mmann78@netscape.net>
365 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
366 Date: Wed Jul 13 10:07:16 2016 -0400
368 Restore setting data.edt in write_specified_fields().
370 This prevents tshark from crashing when run with "-T fields -e data".
372 I5778b08c52119b5be1ec482be9417b3c4ba8ed62 mistakenly removed this line (this
373 'data' is a write_field_data_t rather than the print_data structure that
374 change was cleaning up).
377 Change-Id: I773e47f12f852e19a20ec29a43eb3a0953923173
378 Reviewed-on: https://code.wireshark.org/review/16415
379 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
380 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
383 Author: Pascal Quantin <pascal.quantin@gmail.com>
384 Date: Wed Jul 13 12:22:37 2016 +0200
386 MBIM: add dissection of Intel proprietary UUIDs
388 Based on http://www.telit.com/fileadmin/user_upload/products/Downloads/4G/Telit_xN930_MBIM_Command_Functional_Specification_r2.pdf
390 While we are at it, add placeholder for AT&T proprietary UUID (no dissection of the buffers).
392 Change-Id: I4f9825d1f9fde474853f9b86a4302742c078d8cd
393 Reviewed-on: https://code.wireshark.org/review/16413
394 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
395 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
396 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
399 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
400 Date: Wed Jul 13 09:28:15 2016 +0200
402 TCP: fix indent (use 4 spaces)
404 Change-Id: Id08427246f5b481c004e861719b9b213796438c1
405 Reviewed-on: https://code.wireshark.org/review/16409
406 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
409 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
410 Date: Mon Jun 13 04:56:57 2016 +0100
412 IPv6: Simplify RPL routing header dissector
414 Use a wmem_array to perform strict checking.
416 Fold cmprI/cmprE dissection into a single loop.
418 Change-Id: I67443a604b47cd9cbca32c7f7276a7e2229580f1
419 Reviewed-on: https://code.wireshark.org/review/16348
420 Petri-Dish: João Valverde <j@v6e.pt>
421 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
422 Reviewed-by: João Valverde <j@v6e.pt>
425 Author: Pascal Quantin <pascal.quantin@gmail.com>
426 Date: Tue Jul 12 19:04:12 2016 +0200
428 LTE RRC: upgrade dissector to v13.2.0
430 Change-Id: If2e15f429e3e35b3deef8afc23e57c8ef3974a22
431 Reviewed-on: https://code.wireshark.org/review/16410
432 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
433 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
434 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
437 Author: Pascal Quantin <pascal.quantin@gmail.com>
438 Date: Wed Jul 13 10:19:43 2016 +0200
442 Change-Id: I6d429da6e36e9609c1b7a539cf75e0c2c484bf00
443 Reviewed-on: https://code.wireshark.org/review/16411
444 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
447 Author: Michael Mann <mmann78@netscape.net>
448 Date: Tue Jul 12 13:28:10 2016 -0400
450 packet-cql.c: Bugfix bitwise operation with parenthesis.
452 Change-Id: I93e1c64597f309db5341c6ccadfdb3b23c056182
453 Reviewed-on: https://code.wireshark.org/review/16397
454 Petri-Dish: Michael Mann <mmann78@netscape.net>
455 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
456 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
459 Author: Michael Mann <mmann78@netscape.net>
460 Date: Tue Jul 12 12:31:33 2016 -0400
462 file-pcapng.c: Apply parenthesis to fix build warnings
464 Change-Id: I35d180e7aa040c94ca80a49e7d2132dd76e46aaf
465 Reviewed-on: https://code.wireshark.org/review/16393
466 Reviewed-by: Michael Mann <mmann78@netscape.net>
469 Author: Michael Mann <mmann78@netscape.net>
470 Date: Tue Jul 12 12:32:06 2016 -0400
472 packet-6lowpan.c: fix uninitialized variable (ipv6_ext) warning
474 Change-Id: I8182bc9452cbd1201c81407041b6b522434f5ec0
475 Reviewed-on: https://code.wireshark.org/review/16394
476 Reviewed-by: Michael Mann <mmann78@netscape.net>
479 Author: Michael Mann <mmann78@netscape.net>
480 Date: Tue Jul 12 13:23:29 2016 -0400
482 packet-btrfcomm.c: Add NULL check to pacify VS Code Analysis
484 Some if checks are confusing the analysis, but it does add some
487 Change-Id: Ic4fe16a87646a7055f7639af050d53ff004eda5f
488 Reviewed-on: https://code.wireshark.org/review/16396
489 Reviewed-by: Michael Mann <mmann78@netscape.net>
492 Author: Michael Mann <mmann78@netscape.net>
493 Date: Tue Jul 12 08:21:35 2016 -0400
495 Remove T.30 FCF mask.
497 Found by VS Code Analysis, verified with spec that mask isn't needed.
498 Also included link to current spec.
501 Change-Id: Ic3e8ee599501c7c12717649579ffd70581622178
502 Reviewed-on: https://code.wireshark.org/review/16392
503 Reviewed-by: Michael Mann <mmann78@netscape.net>
506 Author: Guy Harris <guy@alum.mit.edu>
507 Date: Tue Jul 12 11:25:49 2016 -0700
509 Handle dissectors that don't have names.
511 Dissector handles created with create_dissector_handle() don't have a
512 name; report them as "(anonymous)" (there's no guarantee that the printf
513 family of routines don't crash when a null pointer is provided to %s -
514 the printf routines in at least some versions of Solaris *do* crash in
517 Change-Id: I561ff855a46eeb442299011d567f20751c5c6869
518 Reviewed-on: https://code.wireshark.org/review/16399
519 Reviewed-by: Guy Harris <guy@alum.mit.edu>
522 Author: Thomas PORTASSAU <thomas.portassau@hotmail.fr>
523 Date: Tue Jul 12 08:36:25 2016 +0200
525 USB CCID added Interrupt IN and PC2RDR_params
527 Change-Id: I77a88b910fa51e09f9d5bdb541170de76ffb3708
528 Reviewed-on: https://code.wireshark.org/review/16386
529 Petri-Dish: Michael Mann <mmann78@netscape.net>
530 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
531 Reviewed-by: Michael Mann <mmann78@netscape.net>
534 Author: dsrsupport <eugene.exarevsky@dsr-company.com>
535 Date: Tue Jul 12 12:21:23 2016 +0300
537 ZigBee Test Profile #2 enchancement.
539 If profile id is ZigBee Test Profile #2, do not try to parse packet contents as other protocol above APS: ZCL or whatever else.
541 Change-Id: I0f1446aea9b270c226c7c472fe794e29240defc9
542 Reviewed-on: https://code.wireshark.org/review/16387
543 Petri-Dish: Michael Mann <mmann78@netscape.net>
544 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
545 Reviewed-by: Michael Mann <mmann78@netscape.net>
548 Author: Gerald Combs <gerald@wireshark.org>
549 Date: Mon Jul 11 15:40:03 2016 -0700
551 Add resource usage logging.
553 Add log_resource_usage, which prints the current and elapsed user and
554 system times. Add a usage example in packet_list_model.cpp.
556 Change-Id: I747161c754a3731e540821715cc9bb10b3dc821d
557 Reviewed-on: https://code.wireshark.org/review/16383
558 Petri-Dish: Gerald Combs <gerald@wireshark.org>
559 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
560 Reviewed-by: Gerald Combs <gerald@wireshark.org>
563 Author: Michael Mann <mmann78@netscape.net>
564 Date: Tue Jul 12 09:09:57 2016 -0400
566 Create stub VXLAN (GPE) protocol for Decode As.
568 Also remove dissector_add_for_decode_as calls as dissector_add_uint
569 already handles that.
571 Change-Id: I87202d49765ffb1a2e6c922cb02b692fb16c0693
572 Reviewed-on: https://code.wireshark.org/review/16388
573 Petri-Dish: Michael Mann <mmann78@netscape.net>
574 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
575 Reviewed-by: Michael Mann <mmann78@netscape.net>
578 Author: D. Ulis <daulis0@gmail.com>
579 Date: Mon Jul 11 21:14:36 2016 -0400
581 HTTP: Add request/response arrows
583 HTTP has multiple related packets, so seeing which are the actual request/response (related to the current selected packet) is helpful.
585 Change-Id: I833f4f620cfe8bfe9b1d7518c4e28fbd41b64e29
586 Reviewed-on: https://code.wireshark.org/review/16385
587 Petri-Dish: Michael Mann <mmann78@netscape.net>
588 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
589 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
590 Reviewed-by: Michael Mann <mmann78@netscape.net>
593 Author: Jeff Layton <jlayton@redhat.com>
594 Date: Mon Jun 20 15:10:32 2016 -0400
596 ceph: distingush between client and server by checking for a second entity_addr_t
598 The current ceph dissector assumes that the server will always send its
599 initial connection negotiation first, but that's not necessarily the
600 case, especially with the kernel client which sends its banner as soon
601 as the socket is created.
603 So, we need a better mechanism to determine which end is client and
604 which is the server. The server sends its own address and then the
605 address of the client, but the client only sends its own address. We
606 can determine whether the initial negotiation message is from the client
607 or server by looking at the data after the first entity addr and seeing
608 whether it also looks like an entity addr.
610 This patch takes that approach. It just grabs the address family from
611 the second address and sees whether it's IPv4 or IPv6. If it's not one
612 of those, then it assumes that it's not an entity_addr_t at all and is
613 therefore a request from the client.
615 We could go farther and try to verify the port and address as well, but
616 that's probably overkill. The address family is at the same offset as
617 the host_type field in the client's Connect request, but it's big endian
618 and the host_type is little endian. As long as we don't end up with
619 host_types that are 0x200 or 0xA00, this scheme should be OK.
621 Change-Id: I161d02da86d978272eff95497c6df66766b02ebc
622 Signed-off-by: Jeff Layton <jlayton@redhat.com>
623 Reviewed-on: https://code.wireshark.org/review/16043
624 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
625 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
626 Reviewed-by: Michael Mann <mmann78@netscape.net>
627 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
630 Author: sjha3 <sjha3@ncsu.edu>
631 Date: Sat Jul 2 15:34:37 2016 -0400
633 Generic Protocol Extension support for VxLAN
636 Change-Id: I53bfedf50ad09cda52320b0e6eb81e92ed73efc8
637 Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
638 Reviewed-on: https://code.wireshark.org/review/16250
641 Author: Jesse Gross <jesse@kernel.org>
642 Date: Fri Jun 24 15:28:55 2016 -0700
644 Geneve: Update list of option classes.
646 Newer versions of the Geneve protocol draft have defined additional
647 option classes. This updates the list so we can show the class name
650 Change-Id: I19f2024704abe2bc0692c73be783858d74323c0e
651 Reviewed-on: https://code.wireshark.org/review/16382
652 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
655 Author: Dario Lombardo <lomato@gmail.com>
656 Date: Mon Jul 11 15:35:29 2016 +0200
658 osx-app: small improvement in packaging script.
660 Change-Id: I484ab1b001f7fd578e734b4e006137f590a750a9
661 Reviewed-on: https://code.wireshark.org/review/16379
662 Reviewed-by: Guy Harris <guy@alum.mit.edu>
665 Author: Joerg Mayer <jmayer@loplof.de>
666 Date: Mon Jul 11 18:59:13 2016 +0200
668 Fix up *some* of the coding style inconsistencies
670 - return type of a function definition is always on a seperate line
671 - reformat single line expert items into multiline format
672 - no space between functionname and (
673 - reformat some hf_ elements that looked different from most others
674 - space after , where appropriate
675 - Fix the following warnings and errors from checkhf.pl
676 Unused href entry: epan/dissectors/packet-ieee80211.c: hf_ieee80211_ff_rcsi
677 Unused href entry: epan/dissectors/packet-ieee80211.c: hf_ieee80211_ff_rcsi_aid
678 Error: hf_ieee80211_ff_dsss_ofdm: FT_BOOLEAN with non-null 'convert' field missing TFS in epan/dissectors/packet-ieee80211.c
679 Error: non-null hf_ieee80211_ff_dsss_ofdm 'convert' field missing 'VALS|VALS64|RVALS|TFS|CF_FUNC|FRAMENUM_TYPE|&' in epan/dissectors/packet-ieee80211.c ?
680 Error: hf_ieee80211_operat_mode_field_channel_width is passing the address of a pointer to VALS in epan/dissectors/packet-ieee80211.c
681 Error: hf_ieee80211_operat_mode_field_rxnss is passing the address of a pointer to VALS in epan/dissectors/packet-ieee80211.c
683 Change-Id: Ide51d1871755199721e65c0f62b3f6a62ef1159e
684 Reviewed-on: https://code.wireshark.org/review/16381
685 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
688 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
689 Date: Sat Jul 9 02:22:03 2016 +0100
691 IPv6: refactor dissect_routing6() into type-specific dissectors
693 Change-Id: I153c39bb76dc30cecede9dbf5fe4abf234fcd719
694 Reviewed-on: https://code.wireshark.org/review/16347
695 Petri-Dish: João Valverde <j@v6e.pt>
696 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
697 Reviewed-by: João Valverde <j@v6e.pt>
700 Author: Martin Kaiser <wireshark@kaiser.cx>
701 Date: Mon Jul 11 10:49:53 2016 +0200
703 hdcp2: don't throw an exception during heuristic check
705 Change-Id: I24895950464e1845c468f9fa9b6e5aa3ab8c75de
706 Reviewed-on: https://code.wireshark.org/review/16378
707 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
708 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
709 Reviewed-by: Anders Broman <a.broman58@gmail.com>
712 Author: Martin Kaiser <wireshark@kaiser.cx>
713 Date: Mon Jul 11 10:29:26 2016 +0200
715 iso7816: check for minimum atr len
717 and reject the packet if it is shorter
719 make sure that we don't throw an exception when we read the first byte
720 and haven't yet decided if the packet contains an iso7816 atr
722 Change-Id: I7b4c93cc7c55489467b46241f07a1bb5ddfd927a
723 Reviewed-on: https://code.wireshark.org/review/16377
724 Reviewed-by: Anders Broman <a.broman58@gmail.com>
727 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
728 Date: Sun Jul 10 19:27:47 2016 +0200
730 BGP: Add support of Vendor Capability 131 (Multisession Cisco)
732 Issue reported by Garri Djavadyan
734 Change-Id: I6dd4bd20d82a3f2cb8aa45f740f72d33e33053da
736 Reviewed-on: https://code.wireshark.org/review/16374
737 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
738 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
739 Reviewed-by: Michael Mann <mmann78@netscape.net>
742 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
743 Date: Sun Jul 10 12:17:04 2016 +0200
745 BGP: Add (Cisco) for "Vendor" Cisco capability
747 * Route Refresh Cisco capability (128)
748 * ORF Cisco capability (130)
750 Issue reported by Garri Djavadyan
753 Change-Id: Icb19cd6a75315e5af4772dd7833a5b762bdd7ff4
754 Reviewed-on: https://code.wireshark.org/review/16373
755 Reviewed-by: Michael Mann <mmann78@netscape.net>
758 Author: Binh Trinh <beango@gmail.com>
759 Date: Sun Jul 10 01:57:15 2016 -0400
761 NAS-EPS: Add preference to bypass a heuristic decode of a ciphered NAS.
763 Change-Id: Ifedb82bbcb29ab978ffb9ce2f485ac9ff0712fc2
764 Reviewed-on: https://code.wireshark.org/review/16363
765 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
766 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
767 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
770 Author: Guy Harris <guy@alum.mit.edu>
771 Date: Sun Jul 10 10:23:40 2016 -0700
773 Remove a compiler warning some platforms give.
775 Some UN*Xes declare an index() function, that being the name strchr()
776 originally had in V7 UNIX. This causes warnings from compilers if you
777 have a variable named "index", so rename the variable.
779 Change-Id: Ibb046005d1ef911ce0739ce70a0a55c13310cdf0
780 Reviewed-on: https://code.wireshark.org/review/16372
781 Reviewed-by: Guy Harris <guy@alum.mit.edu>
784 Author: Martin Kaiser <wireshark@kaiser.cx>
785 Date: Sun Jul 10 18:41:23 2016 +0200
787 pvfs2: clean up dissect_pvfs_distribution()
789 remove unnecessary variable initializers
790 remove an unnecessary if (tree) check
792 Change-Id: I4c5326c11efe4fe38fb606a45ca7674484e9421c
793 Reviewed-on: https://code.wireshark.org/review/16371
794 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
797 Author: Martin Kaiser <wireshark@kaiser.cx>
798 Date: Sun Jul 10 13:32:33 2016 +0200
800 mp2t: use tvb_new_subset_remaining() instead of tvb_new_proxy()
802 the latter is internal to the tvb code and not meant to
803 be called from a dissector
805 Change-Id: Iee5af3d59329aeef8156f0bbbd5c765cac4e314d
806 Reviewed-on: https://code.wireshark.org/review/16364
807 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
808 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
809 Reviewed-by: Anders Broman <a.broman58@gmail.com>
812 Author: Gerald Combs <gerald@wireshark.org>
813 Date: Sun Jul 10 08:07:47 2016 -0700
815 [Automatic update for 2016-07-10]
817 Update manuf, services enterprise-numbers, translations, and other items.
819 Change-Id: I9d1c7b06a449a3b0dc02dd99f33c4e7634e2d1c0
820 Reviewed-on: https://code.wireshark.org/review/16368
821 Reviewed-by: Gerald Combs <gerald@wireshark.org>
824 Author: Bruno Verstuyft <bruno.verstuyft@excentis.com>
825 Date: Wed Jun 29 14:25:34 2016 +0200
827 DOCSIS: Added dissector for Downstream Profile Descriptor (DPD)
829 Change-Id: I97e6e07be45a5c4de6c8c467e0c782b35036bd98
830 Reviewed-on: https://code.wireshark.org/review/16202
831 Petri-Dish: João Valverde <j@v6e.pt>
832 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
833 Reviewed-by: Adrian Simionov <daniel.simionov@gmail.com>
834 Reviewed-by: Anders Broman <a.broman58@gmail.com>
837 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
838 Date: Tue Jul 5 20:15:09 2016 -0400
840 Cleanup and extend the regex for matching expert info entries.
842 Match each entity in the structure explicitly rather than skipping a bunch at
843 the end. This makes it possible to easily (and clearly) specify where we
846 Don't capture the event group and severity: we don't use them anyway.
848 Don't put single character matches in []: that makes it hard to read (for
851 There's no need for both the "m"(ultiline) and "s"(ingle line) options. Nor
852 the "o"optimize (make buggy) option.
854 These same changes should/will be applied to the hf regex later.
856 Change-Id: I3bf307dcd6432eb1a0c2b9aceea201f8403e08c0
857 Reviewed-on: https://code.wireshark.org/review/16313
858 Reviewed-by: Michael Mann <mmann78@netscape.net>
859 Reviewed-by: Anders Broman <a.broman58@gmail.com>
862 Author: David Morsberger <dave@morsberger.com>
863 Date: Sun Jul 3 19:36:12 2016 -0400
865 Remember query after closing Follow Stream
867 Update main filter after follow stream dialog is closed - Use:
868 previous_filter if new 'Back' button (passed in follow() method)
869 filter_out_filter_ if 'Filter Out This Stream' button (built by appending !current_stream to previous_filter)
870 leave filter alone if window closed using Close button or window close. (current stream)
872 Change-Id: Ic02edeaffdc65ff0f33cac4cb9afb8cde28963c7
873 Reviewed-on: https://code.wireshark.org/review/16277
874 Reviewed-by: Jim Young <jim.young.ws@gmail.com>
875 Petri-Dish: Jim Young <jim.young.ws@gmail.com>
876 Tested-by: Jim Young <jim.young.ws@gmail.com>
877 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
878 Reviewed-by: Anders Broman <a.broman58@gmail.com>
881 Author: Michal Privoznik <mprivozn@redhat.com>
882 Date: Mon Jul 4 10:36:20 2016 +0200
884 Makefile: Install wireshark.pc too
886 In my previous patches (8454f2a20e2 and ea16a84ef51) I've tried
887 to make the pkg-config file more robust. But what I had
888 completely forgot about is that the file was never installed by
889 our Makefile rather than we relied on distribution maintainers to
890 be smart and make the package install the file instead. I've
891 realized this as soon as I've tried to update wireshark in my
894 Change-Id: Idb60157a51ea1dd0afd6cfac695bfa5760485241
895 Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
896 Reviewed-on: https://code.wireshark.org/review/16279
897 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
898 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
899 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
900 Reviewed-by: Anders Broman <a.broman58@gmail.com>
903 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
904 Date: Sun Jul 10 15:12:05 2016 +0100
906 randpkt_core: Use g_random_* for randpkt_parse_type().
908 randpkt_parse_type() can (and most likely will) be called before
909 randpkt_example_init(), therefore g_rand_int_range is called with a NULL
910 GRand argument. This produces non-random output.
912 Change-Id: Id420edc15a5f9dec427c5f1a1dd9a1f18a225319
913 Reviewed-on: https://code.wireshark.org/review/16367
914 Reviewed-by: João Valverde <j@v6e.pt>
917 Author: Martin Kaiser <wireshark@kaiser.cx>
918 Date: Sun Jul 10 13:51:14 2016 +0200
920 iso14443: the uid size is a generated item
922 Change-Id: I77952e0099ed8103c8316becafc700866b4c46d8
923 Reviewed-on: https://code.wireshark.org/review/16366
924 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
927 Author: Martin Kaiser <wireshark@kaiser.cx>
928 Date: Sun Jul 10 13:48:27 2016 +0200
930 iso14443: expert info for invalid uid size
932 Change-Id: I3181375c3a2c8a905e1fd8bb722ac27902735ff0
933 Reviewed-on: https://code.wireshark.org/review/16365
934 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
937 Author: Dario Lombardo <lomato@gmail.com>
938 Date: Sun Jul 10 00:17:03 2016 +0200
940 Qt: add assert (CID 1311486).
942 Change-Id: I62290f1f1c7856ee431705a64fae2022b850234a
943 Reviewed-on: https://code.wireshark.org/review/16361
944 Petri-Dish: Dario Lombardo <lomato@gmail.com>
945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
946 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
949 Author: Dario Lombardo <lomato@gmail.com>
950 Date: Thu Jul 7 23:01:06 2016 +0200
952 randpkt_core: change rand() to g_rand_int (CID 1355360).
954 Change-Id: I48560cbb6007eb16aa545a3e8e6a0e8e3b206930
955 Reviewed-on: https://code.wireshark.org/review/16326
956 Petri-Dish: João Valverde <j@v6e.pt>
957 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
958 Petri-Dish: Dario Lombardo <lomato@gmail.com>
959 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
962 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
963 Date: Sat Jul 9 15:37:27 2016 +0100
965 IPv6: Remove obsolete comment
967 WS_INET6_ADDRSTRLEN should be used instead of INET6_ADDRSTRLEN.
969 Change-Id: Id937ca72361f4f1b3cad2c18b1067c3fddc527a9
970 Reviewed-on: https://code.wireshark.org/review/16359
971 Reviewed-by: João Valverde <j@v6e.pt>
974 Author: Michael Mann <mmann78@netscape.net>
975 Date: Sat Jul 9 09:05:12 2016 -0400
977 packet-wsp.c: Fix infinite loop in add_headers
980 Change-Id: Id86d1e5f2db12871bc1b345721e79e57192f01e1
981 Reviewed-on: https://code.wireshark.org/review/16355
982 Petri-Dish: Michael Mann <mmann78@netscape.net>
983 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
984 Reviewed-by: Michael Mann <mmann78@netscape.net>
987 Author: Pascal Quantin <pascal.quantin@gmail.com>
988 Date: Fri Jul 8 23:25:14 2016 +0200
990 Fix detection of NSIS/WiX install path when running a win64 CMake
994 ProgramFiles=C:\Program Files
998 ProgramFiles=C:\Program Files
999 ProgramFiles(x86)=C:\Program Files (x86)
1000 ProgramW6432=C:\Program Files
1002 ProgramFiles=C:\Program Files (x86)
1003 ProgramFiles(x86)=C:\Program Files (x86)
1004 ProgramW6432=C:\Program Files
1006 Change-Id: I32d52219366b299f1e8099dc6d7737970dc398dd
1007 Reviewed-on: https://code.wireshark.org/review/16346
1008 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1009 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1010 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1013 Author: Guy Harris <guy@alum.mit.edu>
1014 Date: Sat Jul 9 00:07:52 2016 -0700
1016 Check for pcapng files when reading from a pipe.
1018 That way, people don't get confused by an "Unrecognized libpcap format"
1019 error - it's *not* libpcap format!
1021 Also, improve *that* message to say "...or not libpcap data", and put a
1022 period at the end of the error messages.
1024 Change-Id: I175f9399fe99ce424f1d83596b7330e1fa5c0625
1025 Reviewed-on: https://code.wireshark.org/review/16349
1026 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1029 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1030 Date: Thu Jun 30 11:09:07 2016 +0100
1032 Fix value_string_ext_free() constness
1034 Don't declare destructor as taking a const argument.
1036 Change-Id: I9badfe400718bef41a0e0a00d4b3d1b0bb2879d1
1037 Reviewed-on: https://code.wireshark.org/review/16342
1038 Reviewed-by: João Valverde <j@v6e.pt>
1039 Petri-Dish: João Valverde <j@v6e.pt>
1040 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1041 Reviewed-by: Michael Mann <mmann78@netscape.net>
1044 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1045 Date: Thu Jun 2 17:17:43 2016 +0100
1047 IPv6: Remove a memcpy()
1049 Replace CamelCase and remove unnecessary casts too.
1051 Change-Id: Iacf56912448c0e0dc0fe21477d6b71ba9caba69a
1052 Reviewed-on: https://code.wireshark.org/review/16344
1053 Reviewed-by: Michael Mann <mmann78@netscape.net>
1054 Petri-Dish: Michael Mann <mmann78@netscape.net>
1055 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1056 Reviewed-by: João Valverde <j@v6e.pt>
1059 Author: Amitoj Setia <asetia@juniper.net>
1060 Date: Fri Jul 8 09:42:50 2016 -0700
1062 fixed some juniper vn dissector bugs
1064 Change-Id: I67ea5df962266c1476d1d1b6234e831018138422
1065 Reviewed-on: https://code.wireshark.org/review/16341
1066 Petri-Dish: Michael Mann <mmann78@netscape.net>
1067 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1068 Reviewed-by: Michael Mann <mmann78@netscape.net>
1071 Author: Pascal Quantin <pascal.quantin@gmail.com>
1072 Date: Fri Jul 8 15:58:55 2016 +0200
1074 GSM RLC/MAC: register dissectors for EC-GSM-IoT control messages
1076 Change-Id: I8fe84cc98b8967c529c07ff17014648610ad8660
1077 Reviewed-on: https://code.wireshark.org/review/16340
1078 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1079 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1080 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1083 Author: Pascal Quantin <pascal.quantin@gmail.com>
1084 Date: Fri Jul 8 12:24:13 2016 +0200
1086 MAC LTE: upgrade dissector to v13.2.0
1088 Change-Id: Ic859d69583ca3c342d4775511b68fc276f3290a4
1089 Reviewed-on: https://code.wireshark.org/review/16339
1090 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1091 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1092 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1095 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
1096 Date: Thu Jul 7 09:46:12 2016 +0000
1098 When generating the LUA reference in AsciiDoc then say so.
1100 Generating LUA documentation source for the developer guide says that
1101 it's generating XML, which it did before the switch to AsciiDoc. Fix
1104 Change-Id: Ib8625af84c74b5f6dc31c1e9e5ded80d9d7940ff
1105 Reviewed-on: https://code.wireshark.org/review/16320
1106 Reviewed-by: Michael Mann <mmann78@netscape.net>
1109 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1110 Date: Fri Jul 8 08:06:30 2016 +0200
1112 couchbase: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
1114 Change-Id: Ie1e3b071388b3527bba1088af69d76dcb8d6981a
1115 Reviewed-on: https://code.wireshark.org/review/16333
1116 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1117 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1118 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1119 Reviewed-by: Michael Mann <mmann78@netscape.net>
1122 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1123 Date: Thu Jul 7 21:49:41 2016 -0400
1127 There's no need to create global structures with pointers to the (global) hf's
1128 to pass into the dissection functions. Just reference the global variables
1131 Remove other global variables passed as arguments while we're at it.
1133 Remove boilerplate comments.
1135 Change-Id: I7ce6b356172aa25983f4cc6a007a0158cb7f26c9
1136 Reviewed-on: https://code.wireshark.org/review/16331
1137 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1138 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1139 Reviewed-by: Michael Mann <mmann78@netscape.net>
1142 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1143 Date: Thu Jul 7 21:23:57 2016 -0400
1145 APRS: clean up some header fields.
1147 Try to make the names self-explanatory (without relying on blurbs).
1149 Change-Id: Icfb4797282987b42ac68709b431d8b7248a0a633
1150 Reviewed-on: https://code.wireshark.org/review/16330
1151 Reviewed-by: Michael Mann <mmann78@netscape.net>
1154 Author: Stig Bjørlykke <stig@bjorlykke.org>
1155 Date: Fri Jul 8 10:52:29 2016 +0200
1157 Qt: Update scrollbars when change byte view format
1159 Update scrollbars when changing display format between hex and
1160 bits view because the height of the phane will change.
1162 Change-Id: I81556c8dbdfb0a34f6c97e76834646a40aed62bb
1163 Reviewed-on: https://code.wireshark.org/review/16336
1164 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1167 Author: dsrsupport <eugene.exarevsky@dsr-company.com>
1168 Date: Fri Jul 8 11:37:31 2016 +0300
1170 ZigBee GreenPower: Fix GP Pairing command dissection.
1172 Fix length of Sink GroupID in GP Pairing command.
1174 Change-Id: I5905812456faa0181ee1cc13824a12ce2583d4e0
1175 Reviewed-on: https://code.wireshark.org/review/16335
1176 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1179 Author: Stig Bjørlykke <stig@bjorlykke.org>
1180 Date: Fri Jul 8 09:45:26 2016 +0200
1182 p1: Add BuiltInEncodedInformationTypes.telex
1184 This is for completeness.
1186 Change-Id: Id89f649aa836dd011f0967cdbdc905916b4d2182
1187 Reviewed-on: https://code.wireshark.org/review/16334
1188 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1191 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1192 Date: Wed Jul 6 08:46:29 2016 +0200
1194 nbifom: fix no previous prototype for 'proto_register_nbifom' [-Wmissing-prototypes]
1196 Change-Id: I4456cfd6600986b2e0c1cecf7d3054f3e829a210
1197 Reviewed-on: https://code.wireshark.org/review/16332
1198 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1199 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1202 Author: Dario Lombardo <lomato@gmail.com>
1203 Date: Thu Jul 7 22:43:49 2016 +0200
1205 Qt: add initializers (CID 1261463).
1207 Change-Id: I5c2d5c73e188586a91dde342d6347d25495e0263
1208 Reviewed-on: https://code.wireshark.org/review/16325
1209 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1210 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1211 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1214 Author: Dario Lombardo <lomato@gmail.com>
1215 Date: Thu Jul 7 22:38:40 2016 +0200
1217 Qt: add initializer (CID 1269610).
1219 Change-Id: I483e5d3f239f4708f9fc6b11c98869bb1381fb44
1220 Reviewed-on: https://code.wireshark.org/review/16324
1221 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1222 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1223 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1226 Author: Dario Lombardo <lomato@gmail.com>
1227 Date: Thu Jul 7 22:35:30 2016 +0200
1229 Qt: add initializers (CID 1317257).
1231 Change-Id: I61a63c187990b119b62e99871832913a0e3f75e4
1232 Reviewed-on: https://code.wireshark.org/review/16323
1233 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1234 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1235 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1238 Author: Guy Harris <guy@alum.mit.edu>
1239 Date: Thu Jul 7 17:21:48 2016 -0700
1241 Handle extcap binaries and the libssh upon which some depend.
1243 Search the extcap binaries for shared libraries they require.
1245 Treat libssh specially - for some reason, when built by macosx-setup.sh
1246 (which just does a standard cmake build of libssh), libssh's shared
1247 library has just libssh.4.dylib, not {installation
1248 directory}/libssh.4.dylib, as its shared library ID, so we don't find
1249 its binary using otool -L.
1252 Change-Id: I3e5632d7520f1bbeca1a8faae3a012938ef9dee7
1253 Reviewed-on: https://code.wireshark.org/review/16329
1254 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1257 Author: Dario Lombardo <lomato@gmail.com>
1258 Date: Thu Jul 7 22:13:41 2016 +0200
1260 osx-app.sh: add ciscodump.
1263 Change-Id: I7326e43ce8b294c8065e09120d85b4743f1659a9
1264 Reviewed-on: https://code.wireshark.org/review/16321
1265 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1268 Author: Joerg Mayer <jmayer@loplof.de>
1269 Date: Fri Jul 8 00:24:14 2016 +0200
1271 Clean up fixed field handling
1273 - Get rid of FF_FIELD macro. Use resoved strings instead.
1274 - Reorder add_ff_ functions so we don't need forward declarations
1275 - Replace add_fixed_field call by call to resolved function
1276 - Remove add_fixed_field and all structs and enums exclusive to it.
1277 - #if 0 out unused function add_ff_relay_capable_sta_info
1279 Change-Id: I9955febb317f3e7c1b9ae28a5ee9c6a6472f7e9c
1280 Reviewed-on: https://code.wireshark.org/review/16328
1281 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
1284 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1285 Date: Thu Jul 7 21:33:09 2016 +0100
1287 CMakeLists.txt: Fix gcee3e82
1290 Change-Id: I7f9be4027214cb7ae4f7b235cba73c088596a80d
1291 Reviewed-on: https://code.wireshark.org/review/16322
1292 Reviewed-by: João Valverde <j@v6e.pt>
1295 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1296 Date: Tue Jul 5 22:01:52 2016 -0400
1298 APRS: register the storm fields.
1300 There's been a comment here since 2012 about them being unregistered. Put in
1301 some registrations based on a feeble understanding of the specification (these
1302 are all strings, add them as such); that should be close enough and is much
1303 better than the (dissector) assertion we'd get otherwise.
1305 Don't bother putting those hf's in a global structure and passing around the
1306 structure: the hf's are global anyway--just reference them directly.
1308 Add a link to the specification while we're here.
1310 Change-Id: Ia7b17e92a996a1a8eb4a4489eff9fca042190a32
1311 Reviewed-on: https://code.wireshark.org/review/16318
1312 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
1313 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1314 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
1315 Reviewed-by: Michael Mann <mmann78@netscape.net>
1318 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1319 Date: Wed May 25 08:06:46 2016 +0200
1321 PAPI: Update Header field
1323 Change-Id: I0c2a522ea70e62b6962c99729068e962beb21085
1324 Reviewed-on: https://code.wireshark.org/review/15572
1325 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1326 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1327 Reviewed-by: Michael Mann <mmann78@netscape.net>
1330 Author: Roland Knall <roland.knall@br-automation.com>
1331 Date: Wed Jul 6 13:39:54 2016 +0200
1333 openSAFETY: Simplify handling of SN Fail/Ack
1335 Also add information about error group/code acknowledged,
1336 and additional parameter set missing, if applicable
1338 Change-Id: I911d9941a33ff4064649090908e0fcc2bf6e00f8
1339 Reviewed-on: https://code.wireshark.org/review/16319
1340 Petri-Dish: Roland Knall <rknall@gmail.com>
1341 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1342 Reviewed-by: Roland Knall <rknall@gmail.com>
1345 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1346 Date: Tue Jul 5 20:14:34 2016 +0100
1348 configure: Check for working lrelease
1350 The qtchooser package in many (all?) distros installs executable symlinks to
1351 qtchooser that can mislead AC_PROG_PATH if the corresponding Qt linguist
1352 tools package is missing.
1355 Change-Id: I98795a3a7b8a05214c56a0c7b50829ea3b2976fa
1356 Reviewed-on: https://code.wireshark.org/review/16316
1357 Petri-Dish: João Valverde <j@v6e.pt>
1358 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1359 Reviewed-by: Adrian Simionov <daniel.simionov@gmail.com>
1360 Reviewed-by: João Valverde <j@v6e.pt>
1363 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1364 Date: Tue Jul 5 21:22:36 2016 -0400
1366 ATM PW: don't use macros to generate hf entries.
1368 The macros weren't saving much code, were confusing checkhf.pl, and were hiding
1369 useability problems with the fields (such as names equal to the abbreviation
1370 and having several fields with the same abbreviation--things checkAPIs.pl can
1371 check now that the macros are out of the way).
1373 Change-Id: Id2ba67d09ce7dd424aee9d7f2e25eb54fa432d98
1374 Reviewed-on: https://code.wireshark.org/review/16315
1375 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
1376 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1377 Reviewed-by: João Valverde <j@v6e.pt>
1378 Reviewed-by: Michael Mann <mmann78@netscape.net>
1381 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1382 Date: Tue Jul 5 21:40:26 2016 -0400
1384 LAT: use ENC_ASCII when adding strings.
1386 Change-Id: If3970fbc25d4085037fb975498de02449e2c25c1
1387 Reviewed-on: https://code.wireshark.org/review/16317
1388 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1389 Reviewed-by: Michael Mann <mmann78@netscape.net>
1392 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1393 Date: Tue Jul 5 20:46:08 2016 -0400
1395 LAT: register several hf's.
1399 Change-Id: If985d04f24a188ac402bc11cf61d29aa418ad242
1400 Reviewed-on: https://code.wireshark.org/review/16314
1401 Reviewed-by: Michael Mann <mmann78@netscape.net>
1404 Author: Hendrik Uhlmann <Hendrik.Uhlmann@rheinmetall.com>
1405 Date: Tue Jul 5 14:16:48 2016 +0200
1407 DIS: Introduced support of Collision PDU
1409 Parse all Attributes of Collision PDU and display them in wireshark HMI.
1411 Change-Id: I3003c6dd709498cc6c1adf784800047d0984bafa
1412 Reviewed-on: https://code.wireshark.org/review/16299
1413 Reviewed-by: Michael Mann <mmann78@netscape.net>
1414 Petri-Dish: Michael Mann <mmann78@netscape.net>
1415 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1416 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
1419 Author: Dario Lombardo <lomato@gmail.com>
1420 Date: Tue Jul 5 16:45:52 2016 +0200
1422 Qt: add initializers (CID 1268205).
1424 Change-Id: I7eb71876731df29c076a3a756b6748f165d1c327
1425 Reviewed-on: https://code.wireshark.org/review/16306
1426 Petri-Dish: Michael Mann <mmann78@netscape.net>
1427 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1428 Reviewed-by: Dario Lombardo <lomato@gmail.com>
1429 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1432 Author: Dario Lombardo <lomato@gmail.com>
1433 Date: Tue Jul 5 23:08:30 2016 +0200
1435 Qt: add initializers (CID 1162824).
1437 Change-Id: Ib570d3531bfdd35404b75d49dbd7dd43db4c30d9
1438 Reviewed-on: https://code.wireshark.org/review/16310
1439 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1440 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1441 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1444 Author: Sergey Avseyev <sergey.avseyev@gmail.com>
1445 Date: Wed Jul 6 01:22:11 2016 +0300
1447 packet-couchbase.c: describe observe-seqno (0x91)
1449 Change-Id: I6018a57a8ae947ee68aa35901398d504d35b99c7
1450 Reviewed-on: https://code.wireshark.org/review/16312
1451 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
1454 Author: Dario Lombardo <lomato@gmail.com>
1455 Date: Tue Jul 5 23:35:11 2016 +0200
1457 Qt: remove unneeded constructors.
1459 There is no need to have an empty private constructor if an explicit
1460 one is already present. The former private constructor didn't initialize
1461 the private members causing many CIDs from coverity.
1463 Change-Id: I8ba98d2b9fc32a867fdcf3421df7946b90bd7b09
1464 Reviewed-on: https://code.wireshark.org/review/16311
1465 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1466 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1467 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1470 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1471 Date: Tue Jul 5 15:30:38 2016 +0100
1473 Rename PIDL Makefile
1475 Otherwise it will get overwritten by the in-tree cmake build.
1477 Issue reported by Rémy Léone.
1479 Change-Id: I0d908973386bcb70585f5e32c36456230967bb7f
1480 Reviewed-on: https://code.wireshark.org/review/16305
1481 Petri-Dish: Michael Mann <mmann78@netscape.net>
1482 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1483 Reviewed-by: Michael Mann <mmann78@netscape.net>
1486 Author: Dario Lombardo <lomato@gmail.com>
1487 Date: Tue Jul 5 22:27:55 2016 +0200
1489 Qt: remove unused variable.
1491 This fixes also CID 1159350.
1493 Change-Id: I21b55686f96131e3e1cff0feac5f16df1c7c7ca2
1494 Reviewed-on: https://code.wireshark.org/review/16309
1495 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1496 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1497 Reviewed-by: Michael Mann <mmann78@netscape.net>
1500 Author: Dario Lombardo <lomato@gmail.com>
1501 Date: Tue Jul 5 16:30:28 2016 +0200
1503 bgp: add return check (CID 1354417).
1505 Change-Id: Id8be1d5f6346686087d747167ec44df2b88dd35e
1506 Reviewed-on: https://code.wireshark.org/review/16304
1507 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1508 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1509 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1510 Reviewed-by: Dario Lombardo <lomato@gmail.com>
1513 Author: Dario Lombardo <lomato@gmail.com>
1514 Date: Tue Jul 5 16:19:33 2016 +0200
1516 tap: check return value (CID 1355643).
1518 Change-Id: I03b141c7aeaa1bc06dc126c5cc8f0d001a57c116
1519 Reviewed-on: https://code.wireshark.org/review/16302
1520 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1521 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1522 Reviewed-by: Michael Mann <mmann78@netscape.net>
1525 Author: Dario Lombardo <lomato@gmail.com>
1526 Date: Mon Jul 4 22:49:32 2016 +0200
1528 Qt: remove unused variable.
1530 This fixes CID 1232347.
1532 Change-Id: I42b5ac997dbde8fcb05665b24444a60b009871be
1533 Reviewed-on: https://code.wireshark.org/review/16290
1534 Petri-Dish: Michael Mann <mmann78@netscape.net>
1535 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1536 Reviewed-by: Michael Mann <mmann78@netscape.net>
1539 Author: Graham Bloice <graham.bloice@trihedral.com>
1540 Date: Tue Jul 5 16:06:16 2016 +0100
1542 Developers Guide updates
1544 Added info about debugging under Visual Studio.
1545 Updated buildbot info.
1547 Change-Id: I9a6a0a2b14e3616a35f652c99b04ee23ea642ba5
1548 Reviewed-on: https://code.wireshark.org/review/16307
1549 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
1550 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1551 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
1554 Author: Pascal Quantin <pascal.quantin@gmail.com>
1555 Date: Tue Jul 5 16:21:01 2016 +0200
1557 Remove remnants of g_spawn_helper support
1559 Change-Id: I88121a280ff01a889daeda438b308380b6ea0703
1560 Reviewed-on: https://code.wireshark.org/review/16303
1561 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1562 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1563 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1566 Author: Roland Knall <roland.knall@br-automation.com>
1567 Date: Tue Jul 5 16:01:10 2016 +0200
1569 openSAFETY: Add byte offset of frame
1571 Add the absolute byte offset of each openSAFETY frame to
1572 dissection, so a change in the offset can be easily detected
1574 Change-Id: Ib935eff7ba1e2e1169cb9071a5c9703cc58fc123
1575 Reviewed-on: https://code.wireshark.org/review/16301
1576 Petri-Dish: Roland Knall <rknall@gmail.com>
1577 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1578 Reviewed-by: Roland Knall <rknall@gmail.com>
1581 Author: Dario Lombardo <lomato@gmail.com>
1582 Date: Mon Jul 4 22:53:21 2016 +0200
1584 Qt: add initializers (CID 1233100).
1586 Change-Id: I99e0d6bd10cc0faddb8a503ec877b3d03b927f4e
1587 Reviewed-on: https://code.wireshark.org/review/16293
1588 Reviewed-by: Michael Mann <mmann78@netscape.net>
1591 Author: Dario Lombardo <lomato@gmail.com>
1592 Date: Mon Jul 4 22:58:41 2016 +0200
1594 Qt: add initializers (CID 1249475).
1596 Change-Id: Ic001c0dfab1e82c66473d6ca15633aaa57520659
1597 Reviewed-on: https://code.wireshark.org/review/16294
1598 Reviewed-by: Michael Mann <mmann78@netscape.net>
1601 Author: Dario Lombardo <lomato@gmail.com>
1602 Date: Mon Jul 4 22:41:01 2016 +0200
1604 dis: cast to guint64 to avoid potential overflow (CID 1214480).
1606 Change-Id: I24ae4a7a5ef8b4ed363ec849ac9c8aeeefe836dd
1607 Reviewed-on: https://code.wireshark.org/review/16288
1608 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1609 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1610 Reviewed-by: Michael Mann <mmann78@netscape.net>
1613 Author: Roland Knall <rknall@gmail.com>
1614 Date: Tue Jun 28 21:34:46 2016 +0200
1616 extcap: Remove g_spawn_helper support
1618 Move g_spawn to separate file and implement functions to
1619 use Windows based method of spawning, instead of the glib
1622 Change-Id: Ibae03d834ec86531eba37dc8768fbf17ddadf57f
1623 Reviewed-on: https://code.wireshark.org/review/16049
1624 Petri-Dish: Roland Knall <rknall@gmail.com>
1625 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1626 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
1627 Reviewed-by: Roland Knall <rknall@gmail.com>
1630 Author: Pascal Quantin <pascal.quantin@gmail.com>
1631 Date: Mon Jul 4 22:41:29 2016 +0200
1633 Network-Based IP Flow Mobility (NBIFOM) dissector
1635 Based on 3GPP 24.161 V13.1.0
1637 Change-Id: I7bf635c862bf7e0b73fd05bc8a55c900d1f4dd87
1638 Reviewed-on: https://code.wireshark.org/review/16291
1639 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1640 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1641 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1642 Reviewed-by: Michael Mann <mmann78@netscape.net>
1645 Author: Guy Harris <guy@alum.mit.edu>
1646 Date: Mon Jul 4 16:24:57 2016 -0700
1648 Style fix and trailing whitespace fix.
1650 Change-Id: I03a438fa58f84939f6245426cbe725e6196c2560
1651 Reviewed-on: https://code.wireshark.org/review/16297
1652 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1655 Author: Guy Harris <guy@alum.mit.edu>
1656 Date: Mon Jul 4 16:22:11 2016 -0700
1660 Make sure the LBMR TNWG Interest record's length is at least the size of
1661 a minimum-length LBMR TNWG Interest record.
1663 Hopefully this will fix the real problem about which CID 1363025 is
1666 Change-Id: I60d94a054ec1ba4fb32b0cdd361995a584fe74a6
1667 Reviewed-on: https://code.wireshark.org/review/16296
1668 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1671 Author: Dario Lombardo <lomato@gmail.com>
1672 Date: Mon Jul 4 22:47:27 2016 +0200
1674 Qt: add initializer (CID 1230901).
1676 Change-Id: Ie7874ef90ce14978adb2c62f208dbcc2a636d3cf
1677 Reviewed-on: https://code.wireshark.org/review/16289
1678 Reviewed-by: Michael Mann <mmann78@netscape.net>
1681 Author: Guy Harris <guy@alum.mit.edu>
1682 Date: Mon Jul 4 14:14:58 2016 -0700
1686 Make sure the authentication trailer length is large enough for a
1687 minimum-length authentication trailer.
1689 Hopefully this fixes the real problem reported by CID 1363027.
1691 Use proto_tree_add_item_ret_uint() while we're at it.
1693 Change-Id: I3377f2a52a26f00eeb24ee5776853ffc6e4f7cce
1694 Reviewed-on: https://code.wireshark.org/review/16295
1695 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1698 Author: Guy Harris <guy@alum.mit.edu>
1699 Date: Mon Jul 4 13:52:20 2016 -0700
1701 Check to make sure the name length <= DLM3_RESNAME_MAXLEN.
1703 If it's not, we'd misdissect it.
1705 Hopefully this fixes the *real* problem that CID 1363031 was complaining
1708 Change-Id: If1fc7c30f72d75b9dc047d7e475f78c9d5869943
1709 Reviewed-on: https://code.wireshark.org/review/16292
1710 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1713 Author: Michael Mann <mmann78@netscape.net>
1714 Date: Sun Jul 3 11:34:37 2016 -0400
1716 packet-packetbb.c cleanup
1718 Change-Id: I2f6ab0bffca5aa4b021b46b930b55455e76b8a9f
1719 Reviewed-on: https://code.wireshark.org/review/16284
1720 Petri-Dish: Michael Mann <mmann78@netscape.net>
1721 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1722 Reviewed-by: Michael Mann <mmann78@netscape.net>
1725 Author: Michael Mann <mmann78@netscape.net>
1726 Date: Sat Jul 2 21:21:54 2016 -0400
1728 packet-tcap.c: Remove MEM_TCAPSRT
1730 No need to duplicate memory allocation of hash tables to have a "debug copy".
1731 Maybe a separate wmem allocator can be used within the dissector, but that
1732 type of debugging shouldn't be in trunk source. Keep it on private branch
1735 Change-Id: I4bdd0f3d1b613f7ae79aa57ebb8e5c3293023253
1736 Reviewed-on: https://code.wireshark.org/review/16282
1737 Reviewed-by: Michael Mann <mmann78@netscape.net>
1740 Author: Guy Harris <guy@alum.mit.edu>
1741 Date: Mon Jul 4 13:40:07 2016 -0700
1745 While scanning through the Prefix64 option, check to make sure we
1746 haven't run past the end of the option.
1748 The Prefix64 option requires that the prefix length be <= 12, and, if
1749 it's not, we end up with part of the prefix having a negative length.
1750 Check to make sure that it is <= 12.
1752 While we're at it, use proto_tree_add_item_ret_uint(), update IETF
1753 document references to use RFCs rather tha earlier I-Ds, and add
1754 references for RFC 7220 and RFC 7225.
1756 Hopefully this fixes the *real* problem that CID 1363032 was complaining
1759 Change-Id: I1592de31f1d4f4ed6e6cdc141516fb764f21d2fb
1760 Reviewed-on: https://code.wireshark.org/review/16287
1761 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1764 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1765 Date: Sun Jul 3 22:01:23 2016 +0200
1767 .mailmap: Update some name...
1769 Change-Id: I755010e59d33bc771a3be06bd1f6da1bcd81d836
1770 Reviewed-on: https://code.wireshark.org/review/16267
1771 Reviewed-by: Eugene Exarevsky <eugene.exarevsky@dsr-company.com>
1772 Reviewed-by: Anil Kumar K K <anilkumar911@gmail.com>
1773 Reviewed-by: Jose Rubio <joserubiovidales@gmail.com>
1774 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1777 Author: Michael Mann <mmann78@netscape.net>
1778 Date: Sun Jul 3 11:16:45 2016 -0400
1780 LTE PDCP: Replace a few g_malloc0 calls with wmem
1782 Change-Id: I8bce527fcd2cf9feb77326a5e9fa6857218dda19
1783 Reviewed-on: https://code.wireshark.org/review/16283
1784 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1787 Author: Guy Harris <guy@alum.mit.edu>
1788 Date: Mon Jul 4 12:42:11 2016 -0700
1792 Addresses CID 1363024.
1794 Change-Id: Ie365f77ca215293aa880a9063521d2c2d7de73c8
1795 Reviewed-on: https://code.wireshark.org/review/16286
1796 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1799 Author: Michael Mann <mmann78@netscape.net>
1800 Date: Sat Jul 2 17:40:17 2016 -0400
1802 General cleanup of packet-ipsec.c
1804 Noticed some things working on bug 12567 that weren't related to bug.
1806 Change-Id: Ie9acbf85cad0899af18202415a40f392a3088ffa
1807 Reviewed-on: https://code.wireshark.org/review/16249
1808 Petri-Dish: Michael Mann <mmann78@netscape.net>
1809 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1810 Reviewed-by: Michael Mann <mmann78@netscape.net>
1813 Author: Michael Mann <mmann78@netscape.net>
1814 Date: Sat Jul 2 16:08:58 2016 -0400
1816 Treat SPI field in ESP/SA configuration as string only if wildcards are used.
1818 Otherwise convert the SPI field to a number, which allows more user
1819 flexibility in SPI format.
1822 Change-Id: I646f0aeeeec4ca4302eb7d5172af9218e88b289f
1823 Reviewed-on: https://code.wireshark.org/review/16248
1824 Petri-Dish: Michael Mann <mmann78@netscape.net>
1825 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1826 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1827 Reviewed-by: Michael Mann <mmann78@netscape.net>
1830 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
1831 Date: Thu Jun 30 23:32:27 2016 +0200
1833 NHRP: Add option for source address in authentication extension.
1835 It seems that not all Cisco IOS implementations adhere to RFC2332
1836 with respect to having the source address after the SPI in the
1837 authentication extension. This change adds a preference to suppress
1838 the interpretation of the bytes following the SPI as the source
1839 address. The default is to adhere to the RFC.
1842 Change-Id: I00d3c1b90ace54f16f0fe4704e6127a5c4881c82
1843 Reviewed-on: https://code.wireshark.org/review/16231
1844 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1845 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
1846 Reviewed-by: Michael Mann <mmann78@netscape.net>
1849 Author: Peter Wu <peter@lekensteyn.nl>
1850 Date: Tue Jun 28 00:15:33 2016 +0200
1852 wslua: fail on tree:add(nil)
1854 It is unlikely that tree:add(nil) or tree:add(nil, tvb) represents a
1855 valid invocation. Most likely the developer made a mistake and tried
1858 local pf_thing = ProtoField.string("some.thing", "Description")
1859 some_proto.fields = { pf_thing }
1861 tree:add(some_proto.fields.thing, tvb())
1863 which should have been:
1865 some_proto.fields = { thing = pf_thing }
1869 tree:add(pf_thing, tvb())
1871 Save the developer some pain and bail out early.
1873 Change-Id: I59fc04153f02bb186b47b763676a68bb0271df76
1874 Reviewed-on: https://code.wireshark.org/review/16177
1875 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
1876 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1877 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1878 Reviewed-by: Michael Mann <mmann78@netscape.net>
1881 Author: Dario Lombardo <lomato@gmail.com>
1882 Date: Sun Jul 3 22:04:38 2016 +0200
1884 androiddump: fix leak (CID 1293387).
1886 Change-Id: I27e167368575dfddf78c237723d20c8b790e5f15
1887 Reviewed-on: https://code.wireshark.org/review/16268
1888 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1889 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1890 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
1893 Author: Dario Lombardo <lomato@gmail.com>
1894 Date: Sun Jul 3 22:56:28 2016 +0200
1896 Qt: add initializers (CID 1159363).
1898 Change-Id: I5d8c2c847c842ddc172d26a3c8aee5d877201a4d
1899 Reviewed-on: https://code.wireshark.org/review/16276
1900 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1901 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1902 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1905 Author: Dario Lombardo <lomato@gmail.com>
1906 Date: Sun Jul 3 22:50:47 2016 +0200
1908 Qt: add initializer (CID 1159361).
1910 Change-Id: Ib7b66b4e1d600048b8a66b47d035c27ef126da29
1911 Reviewed-on: https://code.wireshark.org/review/16275
1912 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1913 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1914 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1917 Author: Dario Lombardo <lomato@gmail.com>
1918 Date: Sun Jul 3 22:46:33 2016 +0200
1920 Qt: add initializer (CID 1159360).
1922 Change-Id: I0ade3925497022d5ac16e66c02727be7fd9f4aa5
1923 Reviewed-on: https://code.wireshark.org/review/16274
1924 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1925 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1926 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1929 Author: Dario Lombardo <lomato@gmail.com>
1930 Date: Sun Jul 3 22:43:05 2016 +0200
1932 Qt: add initializers (CID 1159359).
1934 Change-Id: I21de7d1b5f69bdcfa91da560abc262906d412777
1935 Reviewed-on: https://code.wireshark.org/review/16273
1936 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1937 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1938 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1941 Author: Dario Lombardo <lomato@gmail.com>
1942 Date: Sun Jul 3 22:40:11 2016 +0200
1944 Qt: add initializer (CID 1159358).
1946 Change-Id: I3002015d793e48c87017571f8997dd5a78438f75
1947 Reviewed-on: https://code.wireshark.org/review/16272
1948 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1949 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1950 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1953 Author: Dario Lombardo <lomato@gmail.com>
1954 Date: Sun Jul 3 22:37:42 2016 +0200
1956 Qt: add initializers (CID 1159357).
1958 Change-Id: I27d561d8d63e0d15f7811dd7a033c38df17dfb36
1959 Reviewed-on: https://code.wireshark.org/review/16271
1960 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1961 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1962 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1965 Author: Dario Lombardo <lomato@gmail.com>
1966 Date: Sun Jul 3 22:34:50 2016 +0200
1968 Qt: add initializer (CID 1159355).
1970 Change-Id: If2504ea4a9d806005a6d7631ec4645df1af0206a
1971 Reviewed-on: https://code.wireshark.org/review/16270
1972 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1973 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1974 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1977 Author: Dario Lombardo <lomato@gmail.com>
1978 Date: Sun Jul 3 22:31:32 2016 +0200
1980 Qt: add initializer (CID 1159354).
1982 Change-Id: I0aa4b9db902d084fe33eff5b69ac5cdc85c3fec8
1983 Reviewed-on: https://code.wireshark.org/review/16269
1984 Petri-Dish: Dario Lombardo <lomato@gmail.com>
1985 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1986 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1989 Author: Martin Kaiser <wireshark@kaiser.cx>
1990 Date: Sun Jul 3 16:04:19 2016 +0200
1992 ssh: wmem_strdup() never returns NULL
1994 Change-Id: I2f7b01e5a71f043e49305d0e2a3e78eaa5eae0a8
1995 Reviewed-on: https://code.wireshark.org/review/16262
1996 Petri-Dish: Michael Mann <mmann78@netscape.net>
1997 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1998 Reviewed-by: Michael Mann <mmann78@netscape.net>
2001 Author: Gerald Combs <gerald@wireshark.org>
2002 Date: Sun Jul 3 08:07:30 2016 -0700
2004 [Automatic update for 2016-07-03]
2006 Update manuf, services enterprise-numbers, translations, and other items.
2008 Change-Id: Ie8e9bf51a9c25c6693597ba1109c221a111e3b58
2009 Reviewed-on: https://code.wireshark.org/review/16264
2010 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2013 Author: Martin Kaiser <wireshark@kaiser.cx>
2014 Date: Sun Jul 3 16:39:20 2016 +0200
2016 iso14443: expert info if the crc is wrong
2018 Change-Id: I1b59a7d7bf0f9f304f816558f38ce5d52deb504e
2019 Reviewed-on: https://code.wireshark.org/review/16263
2020 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2023 Author: Martin Kaiser <wireshark@kaiser.cx>
2024 Date: Sun Jul 3 13:37:51 2016 +0200
2026 profinet, CID 1362120: check the return value of ftell()
2028 change filePosRecord's data type to long, this is what ftell() and
2031 limit filePosRecord's scope to the block where it's actually used
2033 if ftell() returns < 0, don't move the file pointer and don't call
2034 fseek() with the negative offset
2036 Change-Id: If5a43099c32e476a691f4d6cd26ed7fb73490fcf
2037 Reviewed-on: https://code.wireshark.org/review/16258
2038 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
2039 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2040 Reviewed-by: Michael Mann <mmann78@netscape.net>
2043 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2044 Date: Sun Jul 3 13:17:41 2016 +0100
2046 checkhf: Use colon as field separator for better readability
2048 Comma looks like a list when skimming quickly.
2050 Change-Id: Ic0ac1bc8746c70724d2279e3d725c5c9449b79d8
2051 Reviewed-on: https://code.wireshark.org/review/16260
2052 Reviewed-by: João Valverde <j@v6e.pt>
2053 Reviewed-by: Michael Mann <mmann78@netscape.net>
2056 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2057 Date: Sun Jul 3 12:58:24 2016 +0100
2059 ICMPv6-RPL: Fix DRO-ACK reserved field.
2061 Unused href entry: epan/dissectors/packet-icmpv6.c, hf_icmpv6_rpl_p2p_droack_flag_reserved
2063 Change-Id: I2fb74946aeb7cf1df708449c185126ee7b6b0253
2064 Reviewed-on: https://code.wireshark.org/review/16259
2065 Reviewed-by: João Valverde <j@v6e.pt>
2068 Author: Martin Kaiser <wireshark@kaiser.cx>
2069 Date: Sun Jul 3 13:42:40 2016 +0200
2071 profinet: add a space to make checkhf happy
2073 without the space, checkhf complains about an ei entry
2075 martin@reykholt:~/src/wireshark.git$ ./tools/checkhf.pl plugins/profinet/packet-dcerpc-pn-io.c
2076 ERROR: NO ARRAY: plugins/profinet/packet-dcerpc-pn-io.c, ei_pn_io_unsupported
2078 Change-Id: Ie72efcec644225bc4f554117ae10672694823cad
2079 Reviewed-on: https://code.wireshark.org/review/16257
2080 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2083 Author: Martin Kaiser <wireshark@kaiser.cx>
2084 Date: Sat Jun 18 16:35:26 2016 -0700
2086 dns: remove a bunch of unnecessary NULL checks
2088 Change-Id: Ia4066ae3fc31fb43d4cc63cfb739f22738581831
2089 Reviewed-on: https://code.wireshark.org/review/16256
2090 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2093 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2094 Date: Sun Jul 3 09:47:22 2016 +0000
2096 Revert "Support for NSH with VXLAN-GPE encapsulation"
2098 This reverts commit 76a8bca9bc87823e9182fa6ebb35f0b93bcc451b.
2100 Change-Id: I85b9778329373872e4f9fd1b90280dfef5e33a06
2101 Reviewed-on: https://code.wireshark.org/review/16255
2102 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2105 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2106 Date: Sun Jul 3 01:29:04 2016 +0100
2110 Change-Id: I41b9cf4b7e3efbee48174fe0151ca94cb0bbc425
2111 Reviewed-on: https://code.wireshark.org/review/16254
2112 Reviewed-by: Michael Mann <mmann78@netscape.net>
2113 Petri-Dish: Michael Mann <mmann78@netscape.net>
2114 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2115 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2118 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2119 Date: Sun Jul 3 01:26:32 2016 +0100
2121 ICMPv6: Avoid "no response found" for multicast ping
2123 Change-Id: Ia6bfdd28fc6d85b3899d542db5aa4ed54be054ea
2124 Reviewed-on: https://code.wireshark.org/review/16253
2125 Reviewed-by: Michael Mann <mmann78@netscape.net>
2126 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2129 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2130 Date: Sun Jul 3 00:31:38 2016 +0100
2132 ICMP: Avoid "no response found" for multicast ping
2135 Change-Id: I6943d275de988e9de66bc01e2b421901947a5b95
2136 Reviewed-on: https://code.wireshark.org/review/16252
2137 Reviewed-by: Michael Mann <mmann78@netscape.net>
2138 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2141 Author: Adrian Simionov <daniel.simionov@gmail.com>
2142 Date: Sat Jul 2 22:49:44 2016 +1000
2144 DOCSIS: Update to Type 35 UCD
2146 Change-Id: Ie0dda94894cfaec9bccbd69d52367034e1c629da
2147 Reviewed-on: https://code.wireshark.org/review/16242
2148 Reviewed-by: Michael Mann <mmann78@netscape.net>
2151 Author: sjha3 <sjha3@ncsu.edu>
2152 Date: Sat Jul 2 19:09:50 2016 -0400
2154 Support for NSH with VXLAN-GPE encapsulation
2157 Change-Id: I8481c4ab69c4432985acc79bff7818e6857fa1cb
2158 Reviewed-on: https://code.wireshark.org/review/16251
2159 Petri-Dish: Michael Mann <mmann78@netscape.net>
2160 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2161 Reviewed-by: Michael Mann <mmann78@netscape.net>
2164 Author: Dario Lombardo <lomato@gmail.com>
2165 Date: Sat Jul 2 23:16:11 2016 +0200
2167 Qt: add initializer (CID 1159352).
2169 Change-Id: Ie355a31284685ca0c160a46a4daa6c28b39e3093
2170 Reviewed-on: https://code.wireshark.org/review/16247
2171 Petri-Dish: Dario Lombardo <lomato@gmail.com>
2172 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2173 Reviewed-by: Michael Mann <mmann78@netscape.net>
2176 Author: Dario Lombardo <lomato@gmail.com>
2177 Date: Sat Jul 2 23:05:24 2016 +0200
2179 Qt: remove unneeded check (CID 1159309).
2181 fi has already been checked in line 51.
2183 Change-Id: Idd4d09a35ef1d4897479538979debd708e2cfe5b
2184 Reviewed-on: https://code.wireshark.org/review/16246
2185 Petri-Dish: Dario Lombardo <lomato@gmail.com>
2186 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2187 Reviewed-by: Michael Mann <mmann78@netscape.net>
2190 Author: Gerald Combs <gerald@wireshark.org>
2191 Date: Fri Jul 1 10:35:22 2016 -0700
2193 Qt: Fixup byte view context menus
2195 Shorten text similar to other context menus.
2197 Change-Id: I8806ed4dddb6fc3c51ddbd4150d9090f5b2ca787
2198 Reviewed-on: https://code.wireshark.org/review/16238
2199 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2200 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2201 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2202 Reviewed-by: Michael Mann <mmann78@netscape.net>
2205 Author: Matt Texier <matthieu@texier.tv>
2206 Date: Wed Jun 29 17:33:21 2016 +0200
2208 BGP: Fixed an side effect of length coding on offset
2211 Change-Id: Ibf063293041d749664f6e6ecd2455024ea3fd4ed
2212 Reviewed-on: https://code.wireshark.org/review/16237
2213 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2214 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2215 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2216 Reviewed-by: Michael Mann <mmann78@netscape.net>
2219 Author: Michael Mann <mmann78@netscape.net>
2220 Date: Sat Jul 2 08:23:34 2016 -0400
2222 packetbb: Prevent divide by 0.
2225 Change-Id: Ibfa605597b786d8dbf1e256ef2ca6dc691498974
2226 Reviewed-on: https://code.wireshark.org/review/16241
2227 Petri-Dish: Michael Mann <mmann78@netscape.net>
2228 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2229 Reviewed-by: Michael Mann <mmann78@netscape.net>
2232 Author: Pascal Quantin <pascal.quantin@gmail.com>
2233 Date: Mon Jun 27 14:45:03 2016 +0200
2235 proto.c: allow calling get_hfi_length() with a 0 byte tvb and length=-1
2237 As indicated in the comment, we allow FT_PROTOCOL, FT_NONE, FT_BYTES, FT_STRING
2238 and FT_STRINGZPAD to be zero-length.
2239 But in that case do not call tvb_ensure_captured_length_remaining() that ensures
2240 that at least 1 byte is present.
2243 Change-Id: I881754368c24d334b88f0dda1d59a68e08219227
2244 Reviewed-on: https://code.wireshark.org/review/16167
2245 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2246 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2247 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2248 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2251 Author: dsrsupport <eugene.exarevsky@dsr-company.com>
2252 Date: Fri Jul 1 13:22:09 2016 +0300
2254 ZigBee Green Power: implement GP Pairing Configuration command dissection.
2256 Change-Id: I539e98935699e5be8f91daaebade00f22b500dbc
2257 Reviewed-on: https://code.wireshark.org/review/16235
2258 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2259 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2260 Reviewed-by: Michael Mann <mmann78@netscape.net>
2263 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
2264 Date: Fri Jul 1 11:27:52 2016 -0400
2266 Don't leak a file descriptor when changing the SSL debug file name.
2268 I guess people don't change the SSL debug file name that often--this bug has
2269 been here since 2006...
2271 Change-Id: I3db053dd7e0cb9a9e4ae49a310e956b3c77c99f6
2272 Reviewed-on: https://code.wireshark.org/review/16236
2273 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
2274 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2275 Reviewed-by: Michael Mann <mmann78@netscape.net>
2278 Author: Hessam Jalali <hessam.jalali@gmail.com>
2279 Date: Thu Jun 30 21:41:15 2016 +0430
2281 fix missing fields for json, ek and pdml when used with -e fields
2286 when -T json,ed or pdml used in conjunction with -e fields they would
2287 always miss the last field.
2289 in case of json and ek, if some fields in the middle are empty,
2290 the generated json would be invalid.
2294 { "_index": "packets-2016-06-30", "_type": "pcap_file",
2295 "_score": null, "_source":
2296 { "layers": { "e212.mcc": ["255","262"] "frame.time_epoch":
2297 ["1426550400.004751510"], "e212.mnc": ["1","1"] } } }
2301 tshark -T ek -r C:\a.pcap -e e212.mcc -e frame.comment
2302 -e frame.time_epoch -e e212.mnc > C:\test.json
2306 the comma is missing between e212.mcc and frame.time_epoch
2308 Change-Id: I2efae0c48036cf6313e2a064453c8dbc49f38b09
2309 Reviewed-on: https://code.wireshark.org/review/16226
2310 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2311 Reviewed-by: Martin Kacer <kacer.martin@gmail.com>
2312 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2313 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2316 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
2317 Date: Wed Jun 29 23:18:57 2016 +0200
2319 Cleanup LAPD preferences and registration handoff routine
2321 The preferences and the registration handoff routine used to handle
2322 preference changes are setup inconsistent and less efficient. This
2323 change cleans it up.
2325 Change-Id: I9a1d51d8924c30d9e86d8af394ab1f0f31da4d2d
2326 Reviewed-on: https://code.wireshark.org/review/16208
2327 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
2328 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2329 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2332 Author: Michael Mann <mmann78@netscape.net>
2333 Date: Thu Jun 30 20:41:45 2016 -0400
2335 ASN.1 dissectors - don't try to find yourself.
2337 If an ASN.1 dissector is calling register_dissector for itself in its proto_register_xxx
2338 function and then calling find_dissector for itself in its proto_reg_handoff_xxx
2339 function then just create a static handle for that dissector and use the return
2340 value of register_dissector, so the find isn't necessary.
2342 Change-Id: I911bdadc2fb4259601c141b955e741a2369cc447
2343 Reviewed-on: https://code.wireshark.org/review/16233
2344 Reviewed-by: Michael Mann <mmann78@netscape.net>
2345 Petri-Dish: Michael Mann <mmann78@netscape.net>
2346 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2347 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2350 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2351 Date: Thu Jun 30 22:37:10 2016 +0200
2353 s7comm: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
2355 Change-Id: I296d11ec43b3817d30920432239632f86b9f773f
2356 Reviewed-on: https://code.wireshark.org/review/16227
2357 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2358 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2359 Reviewed-by: Thomas Wiens <th.wiens@gmx.de>
2360 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2363 Author: Gerald Combs <gerald@wireshark.org>
2364 Date: Thu Jun 30 09:24:57 2016 -0700
2366 Qt: Add ASCII+EBCDIC actions to the byte view context menu.
2368 Add actions to switch between ASCII and EBCDIC, similar to the hex and
2372 Change-Id: Ib601ac6e89411e6482f3e4172726e16a08fdbd2b
2373 Reviewed-on: https://code.wireshark.org/review/16225
2374 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2375 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2376 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2377 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2380 Author: Gerald Combs <gerald@wireshark.org>
2381 Date: Thu Jun 30 14:55:19 2016 -0700
2383 Qt+Gtk: Fix the -t command line flag.
2385 Add the time format to commandline_param_info_t and apply it when we've
2386 finished application initialization.
2389 Change-Id: Ice626198a610567e945a8e53c0c1093797e8208e
2390 Reviewed-on: https://code.wireshark.org/review/16232
2391 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2392 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2393 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2394 Reviewed-by: Michael Mann <mmann78@netscape.net>
2397 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2398 Date: Thu Jun 30 23:04:37 2016 +0200
2400 exported_pdu(.h): Fix warning: parameter 'tag_type.' not found in the function declaration [-Wdocumentation]
2402 Change-Id: Ic93914a7f526b645bc21a5c9c5f2fa0bf988c27e
2403 Reviewed-on: https://code.wireshark.org/review/16230
2404 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2405 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2406 Reviewed-by: Michael Mann <mmann78@netscape.net>
2409 Author: Pascal Quantin <pascal.quantin@gmail.com>
2410 Date: Thu Jun 30 22:42:26 2016 +0200
2412 802.11 radio: fix an out of bounds access
2415 Change-Id: I4dafdd9bdec5acddf346fd2db6a06d9dfabcbb2e
2416 Reviewed-on: https://code.wireshark.org/review/16228
2417 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2418 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2421 Author: Gerald Combs <gerald@wireshark.org>
2422 Date: Wed Jun 29 16:51:37 2016 -0700
2424 Speed up print_line_text.
2426 isatty adds a small delay, at least on OS X. Call it only when we
2427 allocate a stream. Do the same for our codeset check.
2429 Change-Id: Id3a20059dbc9cf7d5db16d8d238d038b9de0ebf2
2430 Reviewed-on: https://code.wireshark.org/review/16222
2431 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2432 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2433 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2436 Author: Pascal Quantin <pascal.quantin@gmail.com>
2437 Date: Thu Jun 30 17:40:44 2016 +0200
2439 NAS EPS: upgrade dissector to v13.6.0
2441 Change-Id: Ie27ce7481b9730ad8da0d465ed1c2bc373d4b602
2442 Reviewed-on: https://code.wireshark.org/review/16224
2443 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2444 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2445 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2448 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
2449 Date: Thu Jun 30 09:16:58 2016 -0400
2451 Reinstate the wmem test-programs target.
2453 It's used when building the test programs (today wmem has only one but it
2454 might someday have more).
2456 Change-Id: I627513e1297b8348bf034e852eaf212ddbef96ff
2457 Reviewed-on: https://code.wireshark.org/review/16221
2458 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
2459 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2460 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2463 Author: Gerald Combs <gerald@wireshark.org>
2464 Date: Thu Jun 30 08:25:44 2016 -0700
2468 Add a couple of missing breaks. Fixes CIDs 1362970 and 1362971.
2470 Change-Id: If37bcfed9b48ba30ce8ed85df6e232a6bc5d36f4
2471 Reviewed-on: https://code.wireshark.org/review/16223
2472 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2473 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2474 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2477 Author: Gerald Combs <gerald@wireshark.org>
2478 Date: Wed Jun 29 13:28:57 2016 -0700
2482 Recompress PNGs using the current versions of various compressors:
2489 Parallelize PNG compression. Note why we're not using a couple of other
2490 compression utilities.
2492 Change-Id: I52757d0bc2d424013e7f00b693a0f5378427cc31
2493 Reviewed-on: https://code.wireshark.org/review/16209
2494 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2495 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2496 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2499 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2500 Date: Tue Jun 21 05:06:23 2016 +0100
2502 Remove Makefile.common files
2504 Now that nmake build system has been removed they are not needed anymore.
2506 Change-Id: I88075f955bb4349185859c1af4be22e53de5850f
2507 Reviewed-on: https://code.wireshark.org/review/16050
2508 Petri-Dish: João Valverde <j@v6e.pt>
2509 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2510 Reviewed-by: João Valverde <j@v6e.pt>
2513 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2514 Date: Thu Jun 30 00:29:31 2016 +0100
2516 SDP: Fix warnings [-Wcast-qual]
2518 Change-Id: I471c3d060ff69982e94c9046ca121bb0c15f0d74
2519 Reviewed-on: https://code.wireshark.org/review/16212
2520 Petri-Dish: João Valverde <j@v6e.pt>
2521 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2522 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2525 Author: Gerald Combs <gerald@wireshark.org>
2526 Date: Wed Jun 29 16:12:12 2016 -0700
2528 Qt: Show the correct data in the packet dialog.
2530 Set our pointers and copy our data *after* we read our packet.
2533 Change-Id: I5b373f94ad5b2fa2e6563142200a80912e717a96
2534 Reviewed-on: https://code.wireshark.org/review/16211
2535 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2536 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2537 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2538 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2539 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2542 Author: Matt Texier <matthieu@texier.tv>
2543 Date: Wed Jun 29 17:33:21 2016 +0200
2545 BGP dissector: Fixing NLRI length for flow spec NLRI
2548 Change-Id: Id2b89c2d133865771e21acf3ee224f57ac9d262b
2549 Reviewed-on: https://code.wireshark.org/review/16203
2550 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2553 Author: Martin Kaiser <wireshark@kaiser.cx>
2554 Date: Sun Jun 26 20:13:30 2016 +0200
2556 remove Wireshark.pro, modify update-tx accordingly
2558 Wireshark.pro is the qt project file used by qmake
2559 which in turn was used by nmake
2561 now that nmake is gone, the only reason to keep Wireshark.pro
2562 was the update-tx script that syncs our translation files with Transifex
2564 update-tx calls lupdate to create a list of texts to translate and
2565 lrelease to convert such a list into a binary file
2566 lupdate and lrelase can read file names from a project file or
2567 get them on the command line
2569 modify update-tx to pass the required file names on the command line
2570 we can use wildcards so there's no need to change update-tx when a new
2571 source file is added
2573 remove Wireshark.pro from the release tarball as well
2575 Change-Id: I7ff4ebc96f13b4ffc6fb1b2f4e045999fbfbed5e
2576 Reviewed-on: https://code.wireshark.org/review/16151
2577 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2578 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2579 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2580 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2581 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2584 Author: Guy Harris <guy@alum.mit.edu>
2585 Date: Wed Jun 29 18:45:41 2016 -0700
2587 Pass the format as an argument to write_specified_fields().
2589 That makes failing to specify a format a compile-time error.
2591 Change-Id: Iff0bda8be35b1e3acc97e4314657ceaff2b3d0be
2592 Reviewed-on: https://code.wireshark.org/review/16218
2593 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2596 Author: Guy Harris <guy@alum.mit.edu>
2597 Date: Wed Jun 29 18:39:45 2016 -0700
2599 Mention autotools, give some information for other UN*Xes.
2601 For OS X, mention the use of CMake or autotools for building.
2603 For Linux, mention autotools as well as CMake, and speak of Debian
2604 derivatives other than Ubuntu.
2606 Add a section for UN*Xes other than OS X and Linux.
2608 Change-Id: I73bb7afe2d427333b10016aeb497ab32eee16d43
2609 Reviewed-on: https://code.wireshark.org/review/16217
2610 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2613 Author: Guy Harris <guy@alum.mit.edu>
2614 Date: Wed Jun 29 17:21:53 2016 -0700
2616 ui/qt/i18n.qrc is a generated file; ignore it.
2618 Change-Id: Ifc8b45d42d9dbf9560ec825e3ce1784534df7b3b
2619 Reviewed-on: https://code.wireshark.org/review/16216
2620 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2623 Author: Guy Harris <guy@alum.mit.edu>
2624 Date: Wed Jun 29 17:07:44 2016 -0700
2626 Remove unused edt field from print_data structure.
2628 Change-Id: I5778b08c52119b5be1ec482be9417b3c4ba8ed62
2629 Reviewed-on: https://code.wireshark.org/review/16215
2630 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2633 Author: Guy Harris <guy@alum.mit.edu>
2634 Date: Wed Jun 29 16:53:06 2016 -0700
2636 Get rid of unused edt member in write_pdml_data structure.
2638 Change-Id: I2a41d378187c1685afb701372cf3a8ec9c0aeb70
2639 Reviewed-on: https://code.wireshark.org/review/16214
2640 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2643 Author: Guy Harris <guy@alum.mit.edu>
2644 Date: Wed Jun 29 16:49:04 2016 -0700
2646 Remove unused edt member from write_json_data structure.
2648 Change-Id: Id8b45715c753dc6006f7833e5f49bd8aabc15271
2649 Reviewed-on: https://code.wireshark.org/review/16213
2650 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2653 Author: Guy Harris <guy@alum.mit.edu>
2654 Date: Wed Jun 29 16:13:38 2016 -0700
2656 Fix -T fields, broken by ceae9e4d1fff4500b285dba021c3f239ff87779e.
2658 Rename write_fields_proto_tree() to write_specified_fields(), and make
2659 it static. Make write_fields_proto_tree() a wrapper around
2660 write_specified_fields() that sets the format to FORMAT_CSV. Have
2661 write_specified_fields() fail with an assertion if fields->format isn't
2662 one of the known formats, to catch problems such as this in the future.
2664 Don't fill in the "data" structure if we're not going to use it.
2666 Change-Id: I11dbf448d72ca389f0e5fb8558a41b7eecf7c9a4
2667 Reviewed-on: https://code.wireshark.org/review/16210
2668 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2671 Author: Benjamin Coddington <bcodding@redhat.com>
2672 Date: Fri Jun 24 09:24:20 2016 -0400
2674 packet-nfs: fixup whitespace in pNFS SCSI work
2676 A recent patch introduced whitespace errors.. clean them out.
2678 Change-Id: Id67bed40646d60dc6775e1e1f958a5a07a5f5f6d
2679 Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
2680 Reviewed-on: https://code.wireshark.org/review/16205
2681 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2682 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2683 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2684 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2687 Author: Gerald Combs <gerald@wireshark.org>
2688 Date: Wed Jun 29 13:14:23 2016 -0700
2690 Remove an unused image.
2692 Remove ui/qt/progress_overlay.png.
2694 Change-Id: I2016c6aa5f77314add9870ba95d1c297d72a05c3
2695 Reviewed-on: https://code.wireshark.org/review/16207
2696 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2699 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2700 Date: Wed Jun 29 20:05:27 2016 +0100
2704 Change-Id: Icf7774098986da29efdf76af1dcf217bced428e4
2705 Reviewed-on: https://code.wireshark.org/review/16206
2706 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2707 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2708 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2711 Author: clairvoyant <joserubiovidales@gmail.com>
2712 Date: Thu Jun 23 16:33:50 2016 +0200
2714 LAPD. SCTP can carry LAPD information.
2716 * LAPD can be configured in "Decode As" using port and protocol identifier.
2717 * Add default sctp ppi (the number is not assigned by IANA).
2719 Change-Id: Iaa4797e844f6480881605ad4e6b408d7d5f60cad
2720 Reviewed-on: https://code.wireshark.org/review/16107
2721 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2722 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2725 Author: Michael Mann <mmann78@netscape.net>
2726 Date: Thu Jun 23 23:10:08 2016 -0400
2728 Provide new interface for Export PDU.
2730 Rather than have a bitmask for each desired field, have a dissector
2731 provide a list of structures that represent data that goes into
2734 Change-Id: I125190cbaee489ebffb7d9f5d8bc6f3be2d06353
2735 Reviewed-on: https://code.wireshark.org/review/16122
2736 Petri-Dish: Michael Mann <mmann78@netscape.net>
2737 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2738 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2741 Author: Gerald Combs <gerald@wireshark.org>
2742 Date: Tue Jun 28 10:35:27 2016 -0700
2744 CMake: Update the macOS wrapper script behavior.
2746 CMake on macOS creates a convenience wrapper (run/wireshark) that runs
2747 run/Wireshark.app/Contents/MacOS/Wireshark. Have it run the executable
2748 using "exec" instead of opening the bundle using "open" so that
2749 Wireshark runs in the foreground.
2751 Change-Id: I295ce0681da75678e5e01781e9c8fb58e2236fc9
2752 Reviewed-on: https://code.wireshark.org/review/16196
2753 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2754 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2755 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2758 Author: Martin Kacer <kacer.martin@gmail.com>
2759 Date: Tue Jun 28 13:01:25 2016 +0200
2761 tshark fields filter added for other outputs
2763 -e fields filter addded to ek|json|pdml output.
2766 Change-Id: I1f0f8772eefceb5b71927925ce0c34af483571b9
2767 Reviewed-on: https://code.wireshark.org/review/16193
2768 Petri-Dish: Guy Harris <guy@alum.mit.edu>
2769 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2770 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2773 Author: Guy Harris <guy@alum.mit.edu>
2774 Date: Tue Jun 28 19:31:32 2016 -0700
2776 Distribute i18n.qrc.in in the release tarball.
2778 Change-Id: I4f974351ab1f4781e140873f460d028f49640ca1
2779 Reviewed-on: https://code.wireshark.org/review/16200
2780 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2783 Author: Guy Harris <guy@alum.mit.edu>
2784 Date: Tue Jun 28 17:24:19 2016 -0700
2786 Don't assume GNU sed.
2788 Not all versions of sed support "\n" as meaning "newline" in the
2789 replacement string of an s command. POSIX requires tr to support "\n"
2790 in the replacement string, however, so use % as meaning "newline" in the
2791 sed script, and translate it to a newline using tr.
2793 Change-Id: Icdbc0b55787340953dfc90ea82e0421b4e77a896
2794 Reviewed-on: https://code.wireshark.org/review/16199
2795 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2798 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2799 Date: Tue Mar 15 03:06:21 2016 +0000
2801 Qt: Generate .qm files during build
2803 Change-Id: Ia2ee723227e1b331eeec0f0463654f35a4c9f37b
2804 Reviewed-on: https://code.wireshark.org/review/14508
2805 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
2806 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2807 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2810 Author: Bruno Verstuyft <bruno.verstuyft@excentis.com>
2811 Date: Mon Jun 20 14:29:10 2016 +0200
2813 DOCSIS: Added dissector for OFDM Channel Descriptor
2815 Change-Id: Idbbc1ad126e0b01952957a914bd9c16a990a9b9e
2816 Reviewed-on: https://code.wireshark.org/review/16036
2817 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2818 Reviewed-by: Michael Mann <mmann78@netscape.net>
2821 Author: Pascal Quantin <pascal.quantin@gmail.com>
2822 Date: Tue Jun 28 21:47:46 2016 +0200
2824 3GPP NAS: add a missing separator for optional string
2826 Change-Id: Idddbae0e969b525ddbe31f3b1ddbccaed232891a
2827 Reviewed-on: https://code.wireshark.org/review/16197
2828 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2831 Author: Gerald Combs <gerald@zing.org>
2832 Date: Mon Jun 27 20:13:35 2016 -0700
2834 Qt: Make the packet map work with Qt 5.7.
2836 It's not safe to assume that the overlay scroll bar range is equal(ish)
2837 to the number of packets. Adjust our arithmetic accordingly.
2839 Change-Id: Ic8cc8a746bdd2bdc6771794303e95a810bc3d1d2
2840 Reviewed-on: https://code.wireshark.org/review/16186
2841 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2842 Tested-by: Gerald Combs <gerald@wireshark.org>
2843 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2844 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2847 Author: Gerald Combs <gerald@wireshark.org>
2848 Date: Tue Jun 28 08:54:53 2016 -0700
2850 Qt: Make recent preferences changes work with Qt4.
2852 Cast a pointer to a QWidget * so that compilation and pref selection
2853 works for Qt4. Add an assert and some comments.
2855 Change-Id: Ide89b698220a9af7b7252488f0770ff35081432e
2856 Reviewed-on: https://code.wireshark.org/review/16195
2857 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2858 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2859 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2860 Reviewed-by: Michael Mann <mmann78@netscape.net>
2863 Author: Jens Kilian <jens.kilian@advantest.com>
2864 Date: Tue Jun 28 10:32:26 2016 +0200
2866 Qt: Add a missing Q_DECLARE_METATYPE to fix a compile error on RHEL 7.
2868 Change-Id: I6cf0a95525334d5a7561a477093b892a3f821b98
2869 Reviewed-on: https://code.wireshark.org/review/16189
2870 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2871 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2872 Reviewed-by: Michael Mann <mmann78@netscape.net>
2875 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2876 Date: Mon Jun 27 08:08:28 2016 +0200
2880 * Replace tab by 4-spaces
2881 * Add modelines (for packet-dtn.c)
2883 Change-Id: I668f20b4a021ef94a1bb0b26ac815495eb9920d9
2884 Reviewed-on: https://code.wireshark.org/review/16165
2885 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2888 Author: David Zoller <zollerd@gmail.com>
2889 Date: Sat Jun 25 09:13:00 2016 -0500
2891 DTN follow up to Change ID: I49769271a41b6a7b23c6bc1d4beaadbe8819198d
2893 Change-Id: Ia90644c22896586e4a260a3bf11d1f3e50bd4c4b
2894 Reviewed-on: https://code.wireshark.org/review/16134
2895 Petri-Dish: Anders Broman <a.broman58@gmail.com>
2896 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2897 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2900 Author: Pascal Quantin <pascal.quantin@gmail.com>
2901 Date: Tue Jun 28 16:47:20 2016 +0200
2903 3GPP NAS: upgrade dissector to v13.6.0
2905 Change-Id: Ieffc5d6544f3bd121ff317ff598faaadb5f117ab
2906 Reviewed-on: https://code.wireshark.org/review/16194
2907 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2908 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2909 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2912 Author: Dario Lombardo <lomato@gmail.com>
2913 Date: Tue Jun 28 10:43:12 2016 +0200
2915 print.c NULL pointer check in print_escaped
2917 Added NULL pointer check in print_escaped functions.
2918 Requested by comment in change 16034.
2920 Change-Id: Id172d772d9b5cb4bcd31fe8b42286f885ec5b968
2921 Reviewed-on: https://code.wireshark.org/review/16188
2922 Petri-Dish: Dario Lombardo <lomato@gmail.com>
2923 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2924 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2927 Author: Dario Lombardo <lomato@gmail.com>
2928 Date: Tue Jun 28 10:43:12 2016 +0200
2930 print: change function call.
2932 Change-Id: I8cae4a8d2b57f961d16cb388befed2348a88badc
2933 Reviewed-on: https://code.wireshark.org/review/16191
2934 Petri-Dish: Dario Lombardo <lomato@gmail.com>
2935 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2936 Reviewed-by: Martin Kacer <kacer.martin@gmail.com>
2937 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2938 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2941 Author: Dario Lombardo <lomato@gmail.com>
2942 Date: Tue Jun 28 10:42:55 2016 +0200
2944 print: merge json and ek functions.
2946 Change-Id: Ia5d75bab03bfc065651ea83c936aedffb1f69e9f
2947 Reviewed-on: https://code.wireshark.org/review/16190
2948 Petri-Dish: Dario Lombardo <lomato@gmail.com>
2949 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2950 Reviewed-by: Martin Kacer <kacer.martin@gmail.com>
2951 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2952 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2955 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2956 Date: Tue Jun 28 07:29:50 2016 +0200
2958 print(.c): fix no previous prototype for 'check_protocolfilter' [-Wmissing-prototypes]
2960 Change-Id: Ib10e919dd3f0bec92004c68bf73a3c7d37961f03
2961 Reviewed-on: https://code.wireshark.org/review/16187
2962 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2963 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2964 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2967 Author: Gerald Combs <gerald@wireshark.org>
2968 Date: Mon Jun 27 14:34:29 2016 -0700
2970 Qt: Preferences dialog performance improvements.
2972 Fill in advanced and module tree item text when requested.
2974 Create ModulePreferencesScrollAreas only when we need to show them.
2976 Change-Id: I5aa7d5dba8f5d20de088de3a9d1ee9d58e779269
2977 Reviewed-on: https://code.wireshark.org/review/16181
2978 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2979 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2980 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2981 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2984 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
2985 Date: Mon Jun 27 23:17:27 2016 +0200
2987 OSPF: Differentiate meaning of N/P bit in NSSA LSA type 7
2989 In OSPF v2 the N/P bit in NSSA LSA type 7 messages has to be
2990 interpreted as P-bit (RFC 3101) instead of N-bit. This change
2994 Change-Id: I1d4a8978ca42d0472d5967528e72cbfada87b799
2995 Reviewed-on: https://code.wireshark.org/review/16174
2996 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2999 Author: Guy Harris <guy@alum.mit.edu>
3000 Date: Mon Jun 27 19:58:21 2016 -0700
3004 Change-Id: I185a1786365f185f18f3ec492a8ef165d61595ed
3005 Reviewed-on: https://code.wireshark.org/review/16185
3006 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3009 Author: Guy Harris <guy@alum.mit.edu>
3010 Date: Mon Jun 27 19:54:42 2016 -0700
3012 Have commandline_other_options() directly fill in the global structure.
3014 Other code looks at the global structure, so there won't be other
3015 structures; just fill in the global structure directly.
3017 Change-Id: I4dc87b79168c5a7c9ab1f085aa2d78cc6d2c9019
3018 Reviewed-on: https://code.wireshark.org/review/16184
3019 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3022 Author: Guy Harris <guy@alum.mit.edu>
3023 Date: Mon Jun 27 18:56:29 2016 -0700
3025 Don't set quit_after_cap if no pcap, as it's not present.
3027 Change-Id: I871f75394ba66967d7d7be203bd9e235575458e1
3028 Reviewed-on: https://code.wireshark.org/review/16183
3029 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3032 Author: Guy Harris <guy@alum.mit.edu>
3033 Date: Mon Jun 27 18:40:09 2016 -0700
3035 Make quit_after_cap an item in commandline_param_info_t.
3037 And make the commandline_info structure global, so all the places that
3038 look at quit_after_cap can get at it.
3040 Change-Id: I006329cf8842c655cca36f024570855d1b16e107
3041 Reviewed-on: https://code.wireshark.org/review/16182
3042 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3045 Author: Guy Harris <guy@alum.mit.edu>
3046 Date: Mon Jun 27 17:21:24 2016 -0700
3048 Pull quit_after_cap out of the global capture options.
3050 Really, all the GUI-related options should be pulled out, so they're not
3051 cluttering up dumpcap and tshark.
3053 Change-Id: I0276dee2be48bae3498a819d8c0c2747fe1352e7
3054 Reviewed-on: https://code.wireshark.org/review/16180
3055 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3058 Author: Guy Harris <guy@alum.mit.edu>
3059 Date: Mon Jun 27 16:49:08 2016 -0700
3061 We need global_capture_opts if we have extcap, even without pcap.
3063 Change-Id: I16b778064c1cd2bbf281fb5192bf35da252e99dd
3064 Reviewed-on: https://code.wireshark.org/review/16179
3065 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3068 Author: Peter Wu <peter@lekensteyn.nl>
3069 Date: Tue Jun 28 00:34:07 2016 +0200
3071 test: ensure temporary directory outside source tree
3073 The whole point of using mktemp is to get a temporary directory outside
3074 the source tree. Commit v2.1.0rc0-1027-ge01f8fb tried to fix the
3075 invocation for *BSD (including OS X), but by adding a template it
3076 dropped the implicit --tmpdir option for GNU mktemp on Linux..
3078 Use the GNU mktemp invocation and if it fails (for example, because a
3079 template is expected for BSD/OS X), provide a template.
3081 Change-Id: I77bbc7dc2045e4fa756e102afa080860b0857713
3082 Reviewed-on: https://code.wireshark.org/review/16178
3083 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
3086 Author: Peter Wu <peter@lekensteyn.nl>
3087 Date: Mon Jun 27 23:23:31 2016 +0200
3089 qt: fix linking error with global_capture_opts
3091 global_capture_opts is already defined by ui/commandline.c which is also
3092 linked with wireshark-qt.cpp. Remove the duplicate definition to avoid a
3093 build failure with the gold linker.
3095 Fixes regression from v2.1.1rc0-192-g9b5b444.
3097 Change-Id: I4484e2769bf270dee1ec0378fd9c925e01eaf390
3098 Reviewed-on: https://code.wireshark.org/review/16175
3099 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
3100 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3101 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
3104 Author: Peter Wu <peter@lekensteyn.nl>
3105 Date: Thu Jun 16 15:27:25 2016 -0700
3107 cmake: add idl2wrs-dissectors target for DCERPC
3109 Add a callable target such that dissectors can be generated without the
3110 AUTOGEN_dcerpc option.
3112 Modelled after the pidl CMakeLists.txt file and target. This approach
3113 has the advantage over the previous implementation such that the clean
3114 target does not remove the packet-dcerpc-X.c files.
3116 Change-Id: I3226937eaa76dffa253df9d4f989421d5faa3f3f
3117 Reviewed-on: https://code.wireshark.org/review/15989
3118 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
3119 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3120 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
3123 Author: Gerald Combs <gerald@wireshark.org>
3124 Date: Mon Jun 27 09:02:51 2016 -0700
3126 Qt: Clean up capture file callbacks.
3128 Mark some callbacks GTK+ only as appropriate. Change a debug message to
3129 an assert since we handle all callbacks.
3131 Change-Id: I4266f0d7134d19a9c0432354ea36de67501275b4
3132 Reviewed-on: https://code.wireshark.org/review/16171
3133 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3134 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3135 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3138 Author: Martin Kacer <kacer.martin@gmail.com>
3139 Date: Mon Jun 27 06:41:56 2016 +0200
3141 Fixed tshark pdml output.
3143 Corrected if no protocol filter (-j) specified.
3145 Change-Id: Id20dd255642951633efa935dbb1363e7b9aa9be0
3146 Reviewed-on: https://code.wireshark.org/review/16164
3147 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
3148 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3149 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
3152 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
3153 Date: Mon Jun 27 09:48:35 2016 -0400
3155 There's no need to check the return from g_array_index().
3157 g_array_index() returns an index into an array: we're sure to find
3158 something at that index (whether that something is in bounds is
3159 a-whole-nother question).
3161 This fixes CIDs 1362829 and 1362890/1362830. There were other CIDs like
3162 this but they've already been fixed.
3164 Change-Id: I94af0931b9adf3abd3bedc969e399cda98bbdd07
3165 Reviewed-on: https://code.wireshark.org/review/16168
3166 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
3169 Author: Michael Mann <mmann78@netscape.net>
3170 Date: Sun Jun 26 10:52:37 2016 -0400
3172 tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_string
3174 Also some other tricks to remove unnecessary tvb_get_string_enc calls.
3176 Change-Id: I2f40d9175b6c0bb0b1364b4089bfaa287edf0914
3177 Reviewed-on: https://code.wireshark.org/review/16158
3178 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
3179 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3180 Reviewed-by: Michael Mann <mmann78@netscape.net>
3181 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3184 Author: D. Ulis <daulis0@gmail.com>
3185 Date: Sun Jun 26 22:34:03 2016 -0400
3187 CIP: Cleanup info column for MSP packets
3189 1. Skip printing class name in info column when it was an MSP, since it's implied.
3190 2. Don't print response status for embedded messages in info column for MSP. It makes the line too long.
3191 3. Print the response status for embedded messages in the Service Packet tree. This makes it easier to find the packet that may have failed.
3193 Change-Id: I2c60fb9baf113a215ada7301f493cbd51e340dcd
3194 Reviewed-on: https://code.wireshark.org/review/16162
3195 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3196 Petri-Dish: Anders Broman <a.broman58@gmail.com>
3197 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3198 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
3201 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
3202 Date: Sun Jun 26 21:38:19 2016 -0400
3204 endpoint dialog: fix compilation when we don't HAVE_GEOIP.
3206 Also fix some indentation and white space.
3207 Remove a break-after-return.
3210 Change-Id: I912ccdac62aceaabcffec8f7739da56cc6036abf
3211 Reviewed-on: https://code.wireshark.org/review/16159
3212 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3215 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3216 Date: Mon Jun 27 08:10:33 2016 +0200
3220 replace space by tab
3222 Change-Id: I52d5fefbf795fe6ee2dbdeda087c49280ba47503
3223 Reviewed-on: https://code.wireshark.org/review/16166
3224 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
3225 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3228 Author: Bruno Verstuyft <bruno.verstuyft@excentis.com>
3229 Date: Thu Jun 16 10:24:21 2016 +0200
3231 DOCSIS: Fix unknown TLVs in UCD type29 caused parsing errors + bugfixes
3233 Change-Id: I9ab56ded7ebf9f087afceed979e451e369eaf1d6
3234 Reviewed-on: https://code.wireshark.org/review/15967
3235 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3236 Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3237 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3240 Author: Joerg Mayer <jmayer@loplof.de>
3241 Date: Sun Jun 26 23:42:20 2016 +0200
3243 Remove author comments and some accompanying useless code comments
3245 This only removes author's names that appear in the AUTHORS* files.
3246 In those cases where a group of people get mentioned, this patch does
3247 not remove any in case at least one name is not found in AUTHORS*
3249 Change-Id: I2259dbda3d4a1250bdc103f3fc5be93df5482489
3250 Reviewed-on: https://code.wireshark.org/review/16154
3251 Reviewed-by: Michael Mann <mmann78@netscape.net>
3252 Petri-Dish: Michael Mann <mmann78@netscape.net>
3253 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3254 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3257 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3258 Date: Sat Jun 25 19:23:58 2016 +0100
3260 autotools: Qt 5.7 requires C++11
3262 Change-Id: Icad622a052a84862ace98a7000f10ccf677f54a5
3263 Reviewed-on: https://code.wireshark.org/review/16138
3264 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
3265 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3266 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3269 Author: Thomas Wiens <th.wiens@gmx.de>
3270 Date: Fri Jun 24 23:53:36 2016 +0200
3272 s7comm: Sinumerik NC file transfer
3274 Added decoding of up-/downloading files from/to a Sinumerik NC CNC control
3277 Change-Id: If7939e56e972fc2b8feb12150c4184a880b0cdae
3278 Reviewed-on: https://code.wireshark.org/review/16129
3279 Reviewed-by: Michael Mann <mmann78@netscape.net>
3280 Petri-Dish: Michael Mann <mmann78@netscape.net>
3281 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3282 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3285 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3286 Date: Sun Jun 26 18:54:54 2016 +0200
3288 AUTHORS: fix duplicate / wrong name entry
3290 Change-Id: I1e2bb98d1e78af193f449c75109eabc92f934c11
3291 Reviewed-on: https://code.wireshark.org/review/16149
3292 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
3293 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3294 Reviewed-by: David Zoller <zollerd@gmail.com>
3295 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3298 Author: Martin Kacer <kacer.martin@gmail.com>
3299 Date: Sun Jun 26 21:13:06 2016 +0200
3301 json: corrected json output format.
3303 Some pcaps caused invalid json and ek files.
3306 Change-Id: Id4c4d744b4d07fe4e8b6423688be1bb10a803844
3307 Reviewed-on: https://code.wireshark.org/review/16152
3308 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3311 Author: Gerald Combs <gerald@zing.org>
3312 Date: Sat Jun 25 09:44:28 2016 -0700
3314 CMake: Qt 5.7 requires C++ 11.
3316 Add -std=c++11 to CMAKE_CXX_FLAGS if we have Qt >= 5.7.0 and we're
3317 compiling with g++ or clang++.
3319 Change-Id: Id4ce5921ce5c475e9eb9cc67f94c3b3a895924a1
3320 Reviewed-on: https://code.wireshark.org/review/16135
3321 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3322 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3323 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3324 Reviewed-by: João Valverde <j@v6e.pt>
3327 Author: Ashish Shukla <shukla.a@gmail.com>
3328 Date: Fri Jun 24 15:59:39 2016 -0700
3330 radiotap: Fix for the VHT 20MHz MCS 9 data rate not displayed
3332 MCS 9 at 20 MHz is valid for 3 and 6 spatial streams.
3333 Changed the rate table to include rate (mbps) for VHT 20MHz MCS 9.
3335 Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3338 Change-Id: Ia16ae545a5ac1779131e24e1f54a5659390cd321
3339 Reviewed-on: https://code.wireshark.org/review/16146
3340 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3343 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3344 Date: Sun Jun 26 17:19:56 2016 +0200
3346 circuit(.h): fix indent (and add modelines)
3348 Change-Id: I71bb0a8eaf9f5bd34395a4182e4158abaca4ace2
3349 Reviewed-on: https://code.wireshark.org/review/16144
3350 Reviewed-by: Dario Lombardo <lomato@gmail.com>
3351 Petri-Dish: Dario Lombardo <lomato@gmail.com>
3352 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3353 Reviewed-by: Michael Mann <mmann78@netscape.net>
3356 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3357 Date: Sun Jun 26 18:48:30 2016 +0200
3359 Fix typo on AUTHORS.src (about @)
3361 Change-Id: Ie4ba5b6ca9cdcf0a90c4b7604b0b4ff89690f3d9
3362 Reviewed-on: https://code.wireshark.org/review/16148
3363 Reviewed-by: Michael Mann <mmann78@netscape.net>
3366 Author: Guy Harris <guy@alum.mit.edu>
3367 Date: Sun Jun 26 17:37:49 2016 -0700
3369 The "coding" subfield of the VHT field is a bitmask.
3371 Treat it as such. Fetch it once, regardless of whether we have any
3372 non-zero NSS values or not, and use the per-user NSS value to decide
3373 whether a particular bit in the bitmask is valid and worth displaying.
3375 Make the four coding fields bitfields, with the appropriate bit.
3377 Change-Id: I506b35afa9d07da8d800da5c304d5d0aadd87c54
3378 Reviewed-on: https://code.wireshark.org/review/16155
3379 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3382 Author: Guy Harris <guy@alum.mit.edu>
3383 Date: Sun Jun 26 13:44:17 2016 -0700
3385 Check for an invalid 11ac MCS/bandwidth/NSS combination.
3387 A few of the combinations are marked as "Not valid" in 802.11ac-2013.
3390 Change-Id: I18b78ebb84ab32a6fc53c6d634ef07ae87fb4866
3391 Reviewed-on: https://code.wireshark.org/review/16153
3392 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3395 Author: Joerg Mayer <jmayer@loplof.de>
3396 Date: Sun Jun 26 19:07:57 2016 +0200
3398 Decode partial virtual bitmap in TIM IE
3400 - Add yet another filter name for an association id element
3401 - Minor (consistency) cleanups in the vicinity of the new hf element.
3404 Change-Id: Ic8e7580e7de7572e1b449ae03494b25567d86ea3
3405 Reviewed-on: https://code.wireshark.org/review/16150
3406 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
3409 Author: Gerald Combs <gerald@wireshark.org>
3410 Date: Sun Jun 26 08:09:49 2016 -0700
3412 [Automatic update for 2016-06-26]
3414 Update manuf, services enterprise-numbers, translations, and other items.
3416 Change-Id: Id5cc1bbd3d7f899e48ae9c2de48613ef0366cc29
3417 Reviewed-on: https://code.wireshark.org/review/16142
3418 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3421 Author: Gerald Combs <gerald@zing.org>
3422 Date: Sat Jun 25 10:12:21 2016 -0700
3424 Qt: Don't use QStyleOptionViewItemV4.
3426 It was deprecated in Qt 5.7. Just use QStyleOptionViewItem.
3428 Change-Id: I890305a11393940e21bdc68d90ca6602ade16769
3429 Reviewed-on: https://code.wireshark.org/review/16137
3430 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3431 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3432 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3433 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3436 Author: Gerald Combs <gerald@wireshark.org>
3437 Date: Fri Jun 24 16:48:23 2016 -0700
3439 Add an RA_INTERFACES register action.
3441 Add RA_INTERFACES between RA_PREFERENCES and RA_CONFIGURATION. Wireshark
3442 was spending a suspiciously long time loading module preferences here.
3443 (Now we just need to find out why that section of the code is slow.)
3445 Change-Id: Iecbe55e8e10c8844bcb151a13e383cb13a3f6eb1
3446 Reviewed-on: https://code.wireshark.org/review/16133
3447 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3450 Author: Gerald Combs <gerald@wireshark.org>
3451 Date: Fri Jun 24 15:17:25 2016 -0700
3453 Qt: Handle unhandled filter actions.
3455 Handle FilterAction::ActionColorize and ::ActionFind. Remove
3456 ::ActionConversation since it was unused. Assert when we encounter a
3457 missing FilterAction, similar to what we do in other parts of the code.
3460 Change-Id: I5c1ecd488e5bdb9700a80fc70ec7c047311054b6
3461 Reviewed-on: https://code.wireshark.org/review/16131
3462 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3463 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3464 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3465 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3468 Author: Gerald Combs <gerald@wireshark.org>
3469 Date: Fri Jun 24 10:52:44 2016 -0700
3471 Qt: Try to fix un-maximize behavior on OS X.
3473 On OS X, create dialogs with valid parents so that we don't trigger
3474 QTBUG-46701. Document QDialog's "on top", maximize, and minimize
3478 Change-Id: I32c0ef01dba3f7132e5fd0cd61f9feb654b92009
3479 Reviewed-on: https://code.wireshark.org/review/16127
3480 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3481 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3482 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3483 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3486 Author: Gerald Combs <gerald@wireshark.org>
3487 Date: Thu Jun 23 13:10:52 2016 -0700
3489 Qt: Conversation and Endpoint dialog performance tweaks.
3491 Generate column text dynamically. This keeps us from having to iterate
3492 over our tree items each time we receive updates.
3494 Set the uniformRowHeights property.
3496 Stop automatically resizing columns after 200 items.
3498 Fixup name resolution behavior. Disable the checkbox if host name
3499 resolution is disabled.
3501 Change-Id: Ib2fef604d6ee9e39a8b1edd72d58d0cb02d3bb64
3502 Reviewed-on: https://code.wireshark.org/review/16110
3503 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3504 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3505 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3506 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3509 Author: Dario Lombardo <lomato@gmail.com>
3510 Date: Thu Jun 23 17:52:51 2016 +0200
3512 circuit: rename shadow variable
3514 Change-Id: I67e2c80e89af9526ba4b482933d64cab93b9490a
3515 Reviewed-on: https://code.wireshark.org/review/16105
3516 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3519 Author: Dario Lombardo <lomato@gmail.com>
3520 Date: Thu Jun 23 17:53:45 2016 +0200
3522 app_mem_usage: rename shadow variable
3524 Change-Id: I0db888633118beeabfe4bb8fa6da419d0827c7c1
3525 Reviewed-on: https://code.wireshark.org/review/16106
3526 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
3527 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3528 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3531 Author: Dario Lombardo <lomato@gmail.com>
3532 Date: Thu Jun 23 17:51:41 2016 +0200
3534 conversation: rename shadow variable
3536 Change-Id: I8f738b2e01d7f448b21cdc1b488b16b7dd581911
3537 Reviewed-on: https://code.wireshark.org/review/16104
3538 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3541 Author: Dario Lombardo <lomato@gmail.com>
3542 Date: Thu Jun 23 17:40:40 2016 +0200
3544 ex-opt: rename shadow variable
3546 Change-Id: Iba19920e58ffb7f1a88c2a75964c518f0479c66f
3547 Reviewed-on: https://code.wireshark.org/review/16103
3548 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3551 Author: Dario Lombardo <lomato@gmail.com>
3552 Date: Thu Jun 23 17:39:43 2016 +0200
3554 filter: rename shadow var
3556 Change-Id: Idc18f2988754fc21b1f8f2dcadfe5e3dd31d5545
3557 Reviewed-on: https://code.wireshark.org/review/16102
3558 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3561 Author: Dario Lombardo <lomato@gmail.com>
3562 Date: Thu Jun 23 17:35:17 2016 +0200
3564 srt: rename shadow variable
3566 Change-Id: I69bda25f79b6b46bdb288e32133847a853b614e0
3567 Reviewed-on: https://code.wireshark.org/review/16101
3568 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3571 Author: Dario Lombardo <lomato@gmail.com>
3572 Date: Thu Jun 23 17:31:49 2016 +0200
3574 stats_tree: rename shadow variable
3576 Change-Id: I5b3272cc4df728c70d6b0370b0d8a6d3482a0c6c
3577 Reviewed-on: https://code.wireshark.org/review/16100
3578 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3581 Author: Dario Lombardo <lomato@gmail.com>
3582 Date: Thu Jun 23 17:15:34 2016 +0200
3584 h248: rename shadow variable.
3586 Change-Id: I98545776127a0cc3b5d9c44bb625a217672b4443
3587 Reviewed-on: https://code.wireshark.org/review/16099
3588 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3591 Author: Gerald Combs <gerald@wireshark.org>
3592 Date: Fri Jun 24 16:01:51 2016 -0700
3594 Minor UI locale updates.
3596 Qt: Call setlocale before commandline_early_options so that we get
3597 proper "-v" output, similar to the GTK+ UI.
3599 GTK+: Call setlocale once at startup.
3602 Change-Id: I3c3a196b9d94fc768e1085200891bc8d67e21a08
3603 Reviewed-on: https://code.wireshark.org/review/16132
3604 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3605 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3606 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3607 Reviewed-by: João Valverde <j@v6e.pt>
3610 Author: Roland Knall <roland.knall@br-automation.com>
3611 Date: Thu Jun 23 10:43:30 2016 +0200
3613 wsutil: Move Win32 helper routines from capchild
3615 Move error handling and argument quoting routines from
3616 capchild to wsutil, as those methods will be used by
3617 extcap_spawn as well.
3619 Change-Id: I2c4515fefd5aecad317fcdaefa721734288f792c
3620 Reviewed-on: https://code.wireshark.org/review/16123
3621 Petri-Dish: Roland Knall <rknall@gmail.com>
3622 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3623 Reviewed-by: João Valverde <j@v6e.pt>
3624 Reviewed-by: Roland Knall <rknall@gmail.com>
3627 Author: Gerald Combs <gerald@wireshark.org>
3628 Date: Fri Jun 24 12:59:07 2016 -0700
3630 Qt: Fix "-l" behavior.
3632 gbcae998 didn't completely fix the missing "-l" behavior.
3635 Change-Id: Iee3c844013ac137e94848aaafca7aeb3de43e080
3636 Reviewed-on: https://code.wireshark.org/review/16128
3637 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3638 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3639 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3642 Author: Gerald Combs <gerald@wireshark.org>
3643 Date: Fri Jun 24 08:59:48 2016 -0700
3645 Qt: Keep the syntax line edit cursor active.
3647 Ignore focusOutEvents when the syntax line edit completer is active.
3648 This keeps it from hiding its cursor.
3651 Change-Id: I8e25b92c097e039e26e2381c5209be1e27a6a7cd
3652 Reviewed-on: https://code.wireshark.org/review/16126
3653 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3654 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3655 Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
3656 Tested-by: Jim Young <jim.young.ws@gmail.com>
3657 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3660 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3661 Date: Fri Jun 24 14:13:06 2016 +0200
3663 print(.c): fix indent
3665 Change-Id: Ie7c55fb432b29abe689eed1968cfa30bd8e88e33
3666 Reviewed-on: https://code.wireshark.org/review/16124
3667 Petri-Dish: Michael Mann <mmann78@netscape.net>
3668 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3669 Reviewed-by: Michael Mann <mmann78@netscape.net>
3672 Author: Dario Lombardo <lomato@gmail.com>
3673 Date: Thu Jun 23 18:21:13 2016 +0200
3675 tfshark: remove unused variable
3677 Change-Id: I30ab3e4e044de12b18b7b7213a605df7096d1c54
3678 Reviewed-on: https://code.wireshark.org/review/16108
3679 Reviewed-by: Michael Mann <mmann78@netscape.net>
3682 Author: Guy Harris <guy@alum.mit.edu>
3683 Date: Thu Jun 23 18:51:25 2016 -0700
3685 Indicate how this should be done.
3687 Assuming that it could, if registered as an "eth.trailer" heuristic
3688 dissector, get the length of the entire frame, that is.
3690 Change-Id: I1ac26feeb10bb8ba357089a80f4b768f580bb51d
3691 Reviewed-on: https://code.wireshark.org/review/16121
3692 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3695 Author: Guy Harris <guy@alum.mit.edu>
3696 Date: Thu Jun 23 12:45:32 2016 -0700
3698 Fix "disable this protocol by default".
3700 Allow a dissector to mark its protocol as "disabled by default", which
3701 means that the "enable all protocols" routine won't enable it. This is
3702 necessary in order to allow the disabling of protocols not to be
3703 unintentionally changed due to profile changes; see bug 9826.
3705 Change-Id: I3947f794c21350b70a8de06899cfc7715b77f90f
3707 Reviewed-on: https://code.wireshark.org/review/16109
3708 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3711 Author: Pascal Quantin <pascal.quantin@gmail.com>
3712 Date: Thu Jun 23 16:10:09 2016 +0200
3714 LTE RRC: fix display of info column when receiving a BR SIB
3716 Change-Id: Ic288cb10fad3bd34fe088479e7a79f77985808e0
3717 Reviewed-on: https://code.wireshark.org/review/16098
3718 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
3719 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3720 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3723 Author: Benjamin Coddington <bcodding@redhat.com>
3724 Date: Thu Jun 23 05:57:03 2016 -0400
3726 packet-nfs: add extent decoding for SCSI layouts
3728 Decode extents sent within the response to a LAYOUTGET operation on
3731 Change-Id: I1fc0a5e3d4782f078f96866dc63f2ec43b6d62b1
3732 Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
3733 Reviewed-on: https://code.wireshark.org/review/16097
3734 Petri-Dish: Anders Broman <a.broman58@gmail.com>
3735 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3736 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3739 Author: dz-msfc <zollerd@gmail.com>
3740 Date: Wed Mar 2 20:39:12 2016 -0600
3742 NASA provided LTP and DTN updates
3744 Change-Id: I49769271a41b6a7b23c6bc1d4beaadbe8819198d
3745 Reviewed-on: https://code.wireshark.org/review/14310
3746 Petri-Dish: Anders Broman <a.broman58@gmail.com>
3747 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3748 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3751 Author: Jens Kilian <jens.kilian@advantest.com>
3752 Date: Thu Jun 23 10:31:42 2016 +0200
3754 Increase MAX_DISSECTOR_ADDR_TYPE.
3756 With the recent changes causing some address types to be registered
3757 by their proper dissectors, I ran into the MAX_DISSECTOR_ADDR_TYPE
3758 limit in a new dissector I'm currently writing.
3760 Change-Id: I72f521266af9190e8ad198ace4d6608b6b4d2dee
3761 Reviewed-on: https://code.wireshark.org/review/16091
3762 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3765 Author: Dario Lombardo <lomato@gmail.com>
3766 Date: Thu Jun 23 10:13:15 2016 +0200
3768 bthci: add missing break (CID 1362832)
3770 Change-Id: I705cb17d7c6d615361d29f00ba840a94dc835ff0
3771 Reviewed-on: https://code.wireshark.org/review/16090
3772 Petri-Dish: Dario Lombardo <lomato@gmail.com>
3773 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3776 Author: Guy Harris <guy@alum.mit.edu>
3777 Date: Thu Jun 23 02:33:46 2016 -0700
3779 Fix some of the brokenness in the PRP redundancy control trailer dissector.
3781 IF YOU ARE DOING A HEURISTIC CHECK TO DETERMINE WHETHER THE PACKET
3782 YOU'RE LOOKING AT IS ONE YOU SHOULD DISSECT, EVEN IN A DISSECTOR
3783 THAT'S NOT REGISTERED AS A HEURISTIC DISSECTOR, DO NOT LOOK AT PACKET
3784 BYTES UNLESS YOU HAVE ALREADY DETERMINED THAT THEY ARE AVAILABLE IN THE
3787 THERE ARE NO EXCEPTIONS TO THIS RULE.
3790 Change-Id: I2327a92ee760003bc10489263c0c53acdf2094e9
3791 Reviewed-on: https://code.wireshark.org/review/16092
3792 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3795 Author: Guy Harris <guy@alum.mit.edu>
3796 Date: Thu Jun 23 01:00:26 2016 -0700
3798 No pcap, no live capture, so no auto_scroll_live.
3800 Change-Id: Ic1993916cdb78c946bb291fa59f7cdc25e9cef2d
3801 Reviewed-on: https://code.wireshark.org/review/16088
3802 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3805 Author: Dario Lombardo <lomato@gmail.com>
3806 Date: Mon Jun 13 20:02:46 2016 +0200
3808 Qt: quit the UI if WIRESHARK_QUIT_AFTER_CAPTURE is set (offline mode too).
3810 This change is useful to use the offline mode in tests (like fuzzing)
3811 that require the software to quit after the processing of a sample.
3813 Change-Id: I311c642edecf4012dc518c2bf8bca66c97aa1b02
3814 Reviewed-on: https://code.wireshark.org/review/16038
3815 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
3816 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3817 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3820 Author: Michael Mann <mmann78@netscape.net>
3821 Date: Thu Jun 23 00:30:51 2016 -0400
3823 Add LACP "flag strings"
3825 Merged the functionality of a Lua script from Sharkfest '16
3826 presentation into the dissector.
3827 Also cleaned up some of the tfs values used by the dissector.
3830 Change-Id: I6b4c2f4d8a07cfb836265518d713a499df3e971c
3831 Reviewed-on: https://code.wireshark.org/review/16086
3832 Petri-Dish: Michael Mann <mmann78@netscape.net>
3833 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3834 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3837 Author: Chris Brandson <chris.brandson@gmail.com>
3838 Date: Fri Jun 17 15:12:12 2016 -0700
3840 ZigBee updated ZDO support to comply with R22
3842 Update ZDO support for R22 (and IEEE 802.15.4-2015)
3843 - Add support for the new IEEE Joining List request / response
3844 - Changed Network Update to support channel pages
3845 - Added Network Update Enhanced request
3846 - Added decoding of EU Sub-GHz Frequency Band
3848 Change-Id: I3a513a486f6d3784897fc8b783411c678e3f905e
3849 Reviewed-on: https://code.wireshark.org/review/16040
3850 Petri-Dish: Anders Broman <a.broman58@gmail.com>
3851 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3852 Reviewed-by: Michael Mann <mmann78@netscape.net>
3853 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3856 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3857 Date: Wed Jun 22 21:10:50 2016 +0100
3859 IPv6: Don't check payload length for ICMPv6 encapsulation
3861 Change-Id: I783df2ddc98da1c78020837a32005ea143321990
3862 Reviewed-on: https://code.wireshark.org/review/16081
3863 Petri-Dish: João Valverde <j@v6e.pt>
3864 Tested-by: João Valverde <j@v6e.pt>
3865 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3866 Reviewed-by: João Valverde <j@v6e.pt>
3869 Author: Guy Harris <guy@alum.mit.edu>
3870 Date: Wed Jun 22 21:29:20 2016 -0700
3872 Squelch some 64-bit-to-32-bit-shortening warnings.
3874 Change-Id: I64f833abd11d3b2511c235bb353cb5fb7b813b7f
3875 Reviewed-on: https://code.wireshark.org/review/16085
3876 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3879 Author: Gerald Combs <gerald@wireshark.org>
3880 Date: Wed Jun 22 12:44:02 2016 -0700
3882 Qt: Use queued signals+slots for filter actions
3884 Many of our dialogs can send an "apply this display filter" signal to
3885 the main window. Applying a display filter in turn creates a nested
3886 event loop via cf_read+update_progress_dlg. If the "apply" signal+slot
3887 is directly connected (which is the default, and which means we're
3888 calling into a function table) we can close the dialog while the signal
3889 is firing, which means we return into a deleted object.
3891 Make all of the filterAction signals+slots queued instead of direct.
3894 Change-Id: Ica331054c0aa52a7f33bd8df1fa65ecd09fdc292
3895 Reviewed-on: https://code.wireshark.org/review/16080
3896 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3897 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3898 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3899 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3902 Author: Uli Heilmeier <uh@heilmeier.eu>
3903 Date: Thu Jun 16 14:03:04 2016 +0200
3905 HTTP: Split URI into path and query. Tokenize parameters.
3907 Split a HTTP URI into path and query.
3908 Tokenize the parameters of a query.
3911 Change-Id: I9892914eba9737c9751936ce62e63497aba61c61
3912 Reviewed-on: https://code.wireshark.org/review/15971
3913 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
3914 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3915 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3918 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
3919 Date: Fri Jun 17 20:41:31 2016 -0400
3921 RTP player: increase the maximum number of silence frames to 30 minutes worth.
3923 The BadAlloc X11 crash I reported in bug 4119 (which is why the limit was as
3924 low as it was) has long since been fixed thanks to
3925 bug 2630/I71e1bd2f9a62792db06ce887e2bbe7a96d110e0a so we can now deal with
3926 more silence frames.
3928 Change-Id: I0127381e71e497560e0f23af04f9d96af1ed6335
3932 Reviewed-on: https://code.wireshark.org/review/16003
3933 Petri-Dish: Michael Mann <mmann78@netscape.net>
3934 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3935 Reviewed-by: Michael Mann <mmann78@netscape.net>
3938 Author: Gerald Combs <gerald@wireshark.org>
3939 Date: Wed Jun 22 14:41:16 2016 -0700
3941 Qt: Support the -j, -J, and -l command line flags
3943 Add support for -j, -J, and -l. Mark the -m flag deprecated.
3946 Change-Id: Ic44b3997840018e5d571aa1813a1646bce11d4a6
3947 Reviewed-on: https://code.wireshark.org/review/16083
3948 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3949 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3950 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3951 Reviewed-by: Michael Mann <mmann78@netscape.net>
3954 Author: John A. Thacker <johnthacker@gmail.com>
3955 Date: Mon Jun 20 16:29:49 2016 -0400
3957 Editcap: Fix setting of max_packet_number
3959 editcap -r only sets max_packet_number to the earliest, instead of latest,
3960 packet or end of range selection. This changes it to the proper test.
3963 Change-Id: I81772962b00fc6566ccead4fb44c6626a47fff31
3964 Reviewed-on: https://code.wireshark.org/review/16045
3965 Petri-Dish: Michael Mann <mmann78@netscape.net>
3966 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3967 Reviewed-by: Michael Mann <mmann78@netscape.net>
3970 Author: Pascal Quantin <pascal.quantin@gmail.com>
3971 Date: Tue Jun 21 15:31:39 2016 +0200
3973 Windows: rename wiretap-${PROJECT_VERSION}.dll to libwiretap.dll
3975 This aligns the name with what is done for other Wireshark shared libraries.
3976 Moreover it allows to compile a wiretap plugin once per major release, without
3977 the need to recompile it each time ${PROJECT_VERSION} changes (each nightly
3978 build / official release).
3980 Change-Id: I53c82277223a4f323079cf695168ac85c2fba523
3981 Reviewed-on: https://code.wireshark.org/review/16058
3982 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3983 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
3984 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3985 Reviewed-by: Michael Mann <mmann78@netscape.net>
3988 Author: Michael Mann <mmann78@netscape.net>
3989 Date: Wed Jun 22 01:28:48 2016 -0400
3991 Don't close Wireshark (GTK) if user cancels Save on Close.
3994 Change-Id: I4a6e3ca676f1c1096521c0a8147a1459777c92fa
3995 Reviewed-on: https://code.wireshark.org/review/16075
3996 Petri-Dish: Dario Lombardo <lomato@gmail.com>
3997 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3998 Reviewed-by: Michael Mann <mmann78@netscape.net>
4001 Author: Michael Mann <mmann78@netscape.net>
4002 Date: Wed Jun 22 10:56:07 2016 -0400
4004 Don't close Wireshark (Qt) if user cancels Save on Close.
4007 Change-Id: I8c73c839419cd4bcb850824ffb42bf72eed50b19
4008 Reviewed-on: https://code.wireshark.org/review/16076
4009 Petri-Dish: Michael Mann <mmann78@netscape.net>
4010 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4011 Reviewed-by: Michael Mann <mmann78@netscape.net>
4014 Author: Gerald Combs <gerald@wireshark.org>
4015 Date: Mon Jun 20 09:41:10 2016 -0700
4017 Handle ENAMETOOLONG.
4019 g_strerror doesn't appear to handle ENAMETOOLONG. Check for it ourselves.
4021 Change-Id: Icd113a81e8d95bb3c84c91bb420a1a6a19bf5d40
4022 Reviewed-on: https://code.wireshark.org/review/16041
4023 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4024 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4025 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4026 Reviewed-by: Michael Mann <mmann78@netscape.net>
4029 Author: Guy Harris <guy@alum.mit.edu>
4030 Date: Wed Jun 22 16:26:56 2016 -0700
4032 No GeoIP, no need for geoip_none_.
4034 Change-Id: I6fb328d07718d2ff7a7d6008c936b7478ea6db3f
4035 Reviewed-on: https://code.wireshark.org/review/16084
4036 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4039 Author: Gerald Combs <gerald@wireshark.org>
4040 Date: Wed Jun 22 10:56:30 2016 -0700
4042 Qt: Fix crash in Conversations and Endpoints dialogs
4044 Don't assume that conv_item_t or hostlist_talker_t pointers never
4045 change. GArrays can reallocate their data, and in our case this can
4046 happen when we have more than 10,000 items (which is the size that the
4047 conversation table code passes to_array_sized_new).
4050 Change-Id: I88e58be830e35dde272f81fe9250b054fb87facf
4051 Reviewed-on: https://code.wireshark.org/review/16078
4052 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4053 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4054 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4055 Reviewed-by: Michael Mann <mmann78@netscape.net>
4058 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4059 Date: Wed Jun 22 21:08:57 2016 +0200
4061 SSH: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
4063 Change-Id: If084278acfeb82ae7c91aefff9035f156e8f4f15
4064 Reviewed-on: https://code.wireshark.org/review/16079
4065 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4066 Reviewed-by: Kenny Root <kenny@the-b.org>
4067 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4068 Reviewed-by: Michael Mann <mmann78@netscape.net>
4071 Author: Gerald Combs <gerald@wireshark.org>
4072 Date: Tue Jun 21 16:23:04 2016 -0700
4074 Qt: Make the syntax line edit less greedy.
4076 In SyntaxLineEdit::event, only grab ShortcutOverride events that have
4077 Ctrl+Alt modifiers. When the main window display filter edit has focus
4078 this should let us use text editing shortcuts and most main window
4079 shorcuts as appropriate. "Most" means everything except for time display
4080 formats. We might want to use something other than Ctrl+Alt for their
4085 Change-Id: I61eb86b80b4237e6907d5e50262b8f5c291b27a7
4086 Reviewed-on: https://code.wireshark.org/review/16065
4087 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4088 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4089 Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
4090 Reviewed-by: Michael Mann <mmann78@netscape.net>
4093 Author: Balint Reczey <balint@balintreczey.hu>
4094 Date: Thu Jun 16 15:09:56 2016 -0700
4096 GTK: Keep display filter applied when switching profiles
4099 Change-Id: I3bcd6aaad33482474e3429e0dcc074973a338fca
4100 Reviewed-on: https://code.wireshark.org/review/15992
4101 Petri-Dish: Balint Reczey <balint@balintreczey.hu>
4102 Tested-by: Balint Reczey <balint@balintreczey.hu>
4103 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4104 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4105 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4108 Author: Michael Mann <mmann78@netscape.net>
4109 Date: Tue Jun 21 22:23:05 2016 -0400
4111 Add address_to_bytes API.
4113 This will copy an address's "byte format" into a buffer. The original
4114 intended design is for export_pdu functionality, which tries to do
4115 this "manually" for many address types (and creates undesired dependencies)
4117 The default functionality if a "byte format function" isn't provided
4118 (currently the case for all address types) is a memcpy of the address
4119 data. Providing "address to byte" functions to aid export PDU
4120 functionality will be provided later.
4122 Change-Id: I3703f9e617a8cef09165ad53a0f98c6372676b9b
4123 Reviewed-on: https://code.wireshark.org/review/16070
4124 Petri-Dish: Michael Mann <mmann78@netscape.net>
4125 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4126 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4129 Author: Gerald Combs <gerald@wireshark.org>
4130 Date: Tue Jun 21 15:13:30 2016 -0700
4132 Qt: Clear the packet list selection before freezing it.
4134 Call selectionModel()->clear() before removing our model. This will
4135 hopefully make sure we don't end up with an invalid selection in
4138 Clear the selection model before clearing the model while we're here.
4140 Change-Id: I1007eeaa480afa0fb31dafc15a49ca6c247b30c8
4141 Reviewed-on: https://code.wireshark.org/review/16062
4142 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4143 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4144 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4145 Reviewed-by: Kenny Root <kenny@the-b.org>
4146 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4149 Author: Michael Mann <mmann78@netscape.net>
4150 Date: Tue Jun 21 20:30:35 2016 -0400
4152 Move AT_VINES address type to VINES dissector.
4154 proto.c still has to deal with FT_VINES, but maybe that
4155 can be refactored to the dissector too.
4157 Change-Id: Iee04eed3b75f91cb62bb7b625dd44baeeb9aebb3
4158 Reviewed-on: https://code.wireshark.org/review/16069
4159 Petri-Dish: Michael Mann <mmann78@netscape.net>
4160 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4163 Author: Michael Mann <mmann78@netscape.net>
4164 Date: Tue Jun 21 20:06:01 2016 -0400
4166 Move AT_USB to inside USB dissector.
4168 This required some hacking in the conversation table handling, but
4169 still seemed worth it as USB address is not widely used.
4170 Maybe a "is_stringlike" property for address types...
4172 Change-Id: I628a15c17cb1f595bb292130867adbc5bea0f41a
4173 Reviewed-on: https://code.wireshark.org/review/16068
4174 Petri-Dish: Michael Mann <mmann78@netscape.net>
4175 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4176 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4179 Author: Guy Harris <guy@alum.mit.edu>
4180 Date: Tue Jun 21 16:34:36 2016 -0700
4182 The C standard requires <stdlib.h> for getenv() and abort().
4184 You might be able to get away with not including it on some or all
4185 UN*Xes, but you can't do so on Windows with MSVC.
4187 Change-Id: Id2de70745e2a6e8dedc005a55030f3d3fcb54a69
4188 Reviewed-on: https://code.wireshark.org/review/16064
4189 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4192 Author: Joerg Mayer <jmayer@loplof.de>
4193 Date: Wed Jun 22 00:23:38 2016 +0200
4195 More helpful failure when registration fails.
4197 Change-Id: I3c574c504cc9166d04b5b725a6a393767a58a280
4198 Reviewed-on: https://code.wireshark.org/review/16063
4199 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
4202 Author: Guy Harris <guy@alum.mit.edu>
4203 Date: Tue Jun 21 11:21:33 2016 -0700
4205 As with dissector_add_uint(), so with dissector_add_{string,guid}.
4207 Improve the error message for a null disssector handle.
4209 Fix indentation while we're at it.
4211 Change-Id: I1cb2f8ac52e56fc98f6b3ad981018f571e5a7bf0
4212 Reviewed-on: https://code.wireshark.org/review/16060
4213 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4216 Author: Joerg Mayer <jmayer@loplof.de>
4217 Date: Tue Jun 21 19:56:00 2016 +0200
4219 Slightly improve error message in case of initialization errors.
4221 Change-Id: Icb5d4f0f3bc60970737abbf62044f4550e8d3ca3
4222 Reviewed-on: https://code.wireshark.org/review/16059
4223 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
4226 Author: Martin Kacer <kacer.martin@gmail.com>
4227 Date: Mon Jun 20 11:03:40 2016 +0200
4229 tshark JSON and Elasticsearch output fix
4231 Fixed json and ek escape function
4232 Fixed -j protocol filter to do exact match
4233 Fixed -T json to correctly close json
4234 Added -j protocol filter also to pdml output
4237 Change-Id: I02f274e4a5a02346922b37bbe946c10340c242ea
4238 Reviewed-on: https://code.wireshark.org/review/16034
4239 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4240 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4241 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4242 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4245 Author: Pascal Quantin <pascal.quantin@gmail.com>
4246 Date: Tue Jun 21 15:30:33 2016 +0200
4248 libcodecs and libwsutil are DLLs, not static libraries
4250 Change-Id: I4486f35e07c72d4ca35d5649de25d0c9abd2a964
4251 Reviewed-on: https://code.wireshark.org/review/16057
4252 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4255 Author: AndersBroman <anders.broman@ericsson.com>
4256 Date: Tue Jun 21 15:20:16 2016 +0200
4258 Add a couple of vendor defines.
4260 Change-Id: I252b4f892a539c7fa585615ef636fc26de356bf7
4261 Reviewed-on: https://code.wireshark.org/review/16055
4262 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4265 Author: AndersBroman <anders.broman@ericsson.com>
4266 Date: Tue Jun 21 15:14:48 2016 +0200
4268 [H248-Q1950] Correct signal ids.
4270 Change-Id: Iafb030313ed3b715a09146d131dfb4ffdcb7961a
4271 Reviewed-on: https://code.wireshark.org/review/16054
4272 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4275 Author: Anthony Coddington <anthony.coddington@endace.com>
4276 Date: Tue Apr 5 14:21:36 2016 +1200
4278 pcap: ERF per-Host ID/Source ID interface support
4280 Add encap_priv pointer to libpcap_t.
4281 Initialize erf_priv when ENCAP_ERF.
4282 Use erf_populate_interface_from_header() to dynamically create interfaces.
4283 Free encap_priv on pcap_close.
4286 Change-Id: Ieda425ef3e50a124d9c38ee4538aa3644128ce60
4287 Reviewed-on: https://code.wireshark.org/review/15362
4288 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4289 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4290 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4293 Author: Yang Luo <hsluoyz@gmail.com>
4294 Date: Thu Jun 16 11:39:32 2016 +0800
4296 pcap: Add support to "new" Npcap native mode without setting PATH
4298 Npcap decided not to add "C:\Windows\System32\Npcap" to
4299 system PATH in the installation any more (starting from
4300 Npcap 0.07 r14). So this patch needs to be applied, otherwise
4301 Wireshark will not find Packet.dll (the error message will
4302 only say wpcap.dll is missing, but actually is Packet.dll
4305 Change-Id: Ifd8b6e6d8ecf9866cd37c3368b604de210ff8c7b
4306 Reviewed-on: https://code.wireshark.org/review/15959
4307 Reviewed-by: Yang Luo <hsluoyz@gmail.com>
4308 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4309 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4310 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4313 Author: Stig Bjørlykke <stig@bjorlykke.org>
4314 Date: Tue Jun 21 08:55:14 2016 +0200
4316 bthci: Show unknown ocf as undecoded
4318 Don't show unknown ocf values as unexpected parameters.
4320 Change-Id: I08a6c8c20d6382a847f0a2969e4c523a2873dd6f
4321 Reviewed-on: https://code.wireshark.org/review/16048
4322 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
4323 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4324 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
4325 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4326 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4329 Author: Stig Bjørlykke <stig@bjorlykke.org>
4330 Date: Tue Jun 21 08:52:51 2016 +0200
4332 packetlogger: Add some info types
4334 Add Kernel, Kernel Debug and Error info types.
4336 Change-Id: I04547a426b69adde5186e8315a08f4648c1e7837
4337 Reviewed-on: https://code.wireshark.org/review/16047
4338 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
4339 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4340 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4343 Author: Dario Lombardo <lomato@gmail.com>
4344 Date: Fri Jun 17 19:30:57 2016 +0200
4346 debian-setup: add additional params to apt-get.
4348 Can be used to pass params like -qq and -y for automated installations,
4351 Change-Id: Iddf18829f09ce6b16c1c71264adab38d0a893fe6
4352 Reviewed-on: https://code.wireshark.org/review/15999
4353 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
4354 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4355 Reviewed-by: Dario Lombardo <lomato@gmail.com>
4358 Author: Michael Mann <mmann78@netscape.net>
4359 Date: Tue Jun 21 01:19:47 2016 -0400
4361 Check for negative nanoseconds in io,stat tap.
4363 Seconds were already being checked for negative values, but if there is
4364 only a fraction of a second, the negative check wasn't being done,
4365 which led to bad results.
4368 Change-Id: I820e0a4b1384330acebf4a632a04f7840db2288b
4369 Reviewed-on: https://code.wireshark.org/review/16046
4370 Reviewed-by: Michael Mann <mmann78@netscape.net>
4371 Petri-Dish: Michael Mann <mmann78@netscape.net>
4372 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4373 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4376 Author: Jeff Layton <jlayton@redhat.com>
4377 Date: Mon Jun 20 15:10:32 2016 -0400
4379 ceph: c_dissect_sockaddr doesn't need the "data" pointer
4381 Change-Id: I8d4ca2e46a556e32e594610fd26c72840783601e
4382 Signed-off-by: Jeff Layton <jlayton@redhat.com>
4383 Reviewed-on: https://code.wireshark.org/review/16042
4384 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4385 Petri-Dish: Anders Broman <a.broman58@gmail.com>
4386 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4387 Reviewed-by: Michael Mann <mmann78@netscape.net>
4390 Author: Rudra Rugge <rrugge@juniper.net>
4391 Date: Wed Jun 15 11:32:57 2016 -0700
4393 Add support for Opencontrail virtual network
4395 Change-Id: Ia6012e0f6425be069e222538eafb1191b398ec83
4396 Reviewed-on: https://code.wireshark.org/review/15930
4397 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4398 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4399 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4400 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4403 Author: AndersBroman <anders.broman@ericsson.com>
4404 Date: Wed Jan 13 17:49:43 2016 +0100
4406 [RNSAP]Update to V13.1.0 (2015-12)
4408 Change-Id: I6cb7099ac691d68ddae7be59bf37130c8affad42
4409 Reviewed-on: https://code.wireshark.org/review/13263
4410 Petri-Dish: Anders Broman <a.broman58@gmail.com>
4411 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4414 Author: AndersBroman <anders.broman@ericsson.com>
4415 Date: Mon Jun 20 13:57:11 2016 +0200
4417 [pre-commit-ignore] Dont check the asn1 files they are imported verbatime
4418 from standards documents in most cases.
4420 Change-Id: Ie9db1a1431a201dc374f800b5118a199dcb51b9c
4421 Reviewed-on: https://code.wireshark.org/review/16035
4422 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4425 Author: Guy Harris <guy@alum.mit.edu>
4426 Date: Sun Jun 19 23:54:33 2016 -0700
4428 Pull the options structure initialization into commandline_other_options().
4430 Change-Id: I931cde27a81566dfa0ce6e5c9307bfc1a4d5fe54
4431 Reviewed-on: https://code.wireshark.org/review/16033
4432 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4435 Author: Michael Mann <mmann78@netscape.net>
4436 Date: Sun Jun 19 17:53:59 2016 -0400
4438 Add display filter completion suggestions to color filters.
4440 Change-Id: I84d890b55c72e4427ceb2d64e4a7888c07c030f5
4441 Reviewed-on: https://code.wireshark.org/review/16024
4442 Petri-Dish: Michael Mann <mmann78@netscape.net>
4443 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4444 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4447 Author: Michael Mann <mmann78@netscape.net>
4448 Date: Sun Jun 19 17:47:27 2016 -0400
4450 Add field completion suggestions when adding a Display filter or Y Field to the IO Graph
4453 Change-Id: I7cee36581dc773daa691dad10500124ab66520bc
4454 Reviewed-on: https://code.wireshark.org/review/16023
4455 Petri-Dish: Michael Mann <mmann78@netscape.net>
4456 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4457 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4460 Author: Gerald Combs <gerald@zing.org>
4461 Date: Sat Jun 18 12:13:15 2016 -0700
4463 GTK+: Truncate simple_message_box messages.
4465 In do_simple_message_box, build our primary message using
4466 g_string_vprintf instead of g_strdup_vprintf. Truncate both the primary
4467 and secondary messages so that we end up with merely annoyingly wide
4468 dialogs instead of insanely wide ones.
4471 Change-Id: I93ff76344c0da7d97cce5180ed9ecf9349190f6f
4472 Reviewed-on: https://code.wireshark.org/review/16005
4473 Reviewed-by: Michael Mann <mmann78@netscape.net>
4474 Petri-Dish: Michael Mann <mmann78@netscape.net>
4475 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4476 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4479 Author: Martin Kaiser <wireshark@kaiser.cx>
4480 Date: Fri Jun 17 13:43:20 2016 -0700
4482 qt: reset the column sorting when a new file is loaded
4485 Change-Id: I75656d4027dd39e1f97c4bcd38e0dea6fe2de297
4486 Reviewed-on: https://code.wireshark.org/review/16002
4487 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
4488 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4489 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4492 Author: Pascal Quantin <pascal.quantin@gmail.com>
4493 Date: Sun Jun 19 16:52:50 2016 +0200
4495 Add JSON export to Qt/GTK UI
4497 Change-Id: I5ff46a40cdb1f8f41565d2aa54c6f9e61d397e3a
4498 Reviewed-on: https://code.wireshark.org/review/16013
4499 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4500 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4501 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4502 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4503 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4506 Author: Guy Harris <guy@alum.mit.edu>
4507 Date: Sun Jun 19 17:42:14 2016 -0700
4509 Protect some code that's only for Wireshark-with-pcap.
4511 Put that code inside #ifdef HAVE_LIBPCAP/#endif.
4513 Change-Id: I85768fd49a008341a95ac3c8656e96afa6741fbe
4514 Reviewed-on: https://code.wireshark.org/review/16030
4515 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4518 Author: Guy Harris <guy@alum.mit.edu>
4519 Date: Sun Jun 19 16:36:57 2016 -0700
4521 Move some option checking to common code.
4523 Change-Id: Icff9dacd73ea933c59ed664db05098dd8cb3dbf5
4524 Reviewed-on: https://code.wireshark.org/review/16029
4525 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4528 Author: Guy Harris <guy@alum.mit.edu>
4529 Date: Sun Jun 19 15:28:39 2016 -0700
4531 Don't assume we successfully read the configuration files.
4533 read_configuration_files() can fail and return NULL, so check that
4534 commandline_info.prefs_p is non-null before dereferencing it.
4538 Change-Id: I3066769c474d394fbfe548b50d6be704964e59d3
4539 Reviewed-on: https://code.wireshark.org/review/16028
4540 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4543 Author: Guy Harris <guy@alum.mit.edu>
4544 Date: Sun Jun 19 15:18:00 2016 -0700
4546 Don't assume we have an array of GeoIP databases.
4548 The attempt to open them might fail; if geoip_dat_arr is null, just
4549 return 0 as the number of databases, don't crash.
4551 Change-Id: I967d863d328a42d7dce79f58d4fa67d922d0cb2c
4552 Reviewed-on: https://code.wireshark.org/review/16025
4553 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4556 Author: Guy Harris <guy@alum.mit.edu>
4557 Date: Sun Jun 19 14:12:30 2016 -0700
4559 Pass the info strings directly to commandline_early_options().
4561 Just pass them directly as arguments, don't stuff them into a structure.
4563 Change-Id: Iac84226f54898bc953011bca64795e9049762905
4564 Reviewed-on: https://code.wireshark.org/review/16022
4565 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4568 Author: Guy Harris <guy@alum.mit.edu>
4569 Date: Sun Jun 19 13:21:17 2016 -0700
4571 Handle capture options in pcap-less Wireshark in the commandline_ routines.
4573 Get rid of the capture_option_specified and arg_error members of the
4574 commandline_capture_param_info_t and commandline_param_info_t
4575 structures, and have them be local variables in
4576 commandline_early_options() and commandline_other_options(). Have
4577 commandline_early_options() print the "sorry, Wireshark wasn't built
4578 with pcap" and exit if -D was specified but Wireshark wasn't built with
4581 Change-Id: I0efcdea89d9585af8f3c0a28aee060f33d3ec5fd
4582 Reviewed-on: https://code.wireshark.org/review/16021
4583 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4586 Author: Guy Harris <guy@alum.mit.edu>
4587 Date: Sun Jun 19 13:00:13 2016 -0700
4591 Change-Id: I71332dc35047e7d8d32b428fb99b8b9368c41de6
4592 Reviewed-on: https://code.wireshark.org/review/16020
4593 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4596 Author: Guy Harris <guy@alum.mit.edu>
4597 Date: Sun Jun 19 12:55:48 2016 -0700
4599 Those aren't capture options, they're the options we must process early.
4601 The only one of those options that has anything to do with packet
4602 capture is -i, and all we do there is check for an argument of "-"; the
4605 1) options that affect your preference settings (-C to select
4606 the profile, -P to set the personal file directory path);
4608 2) options that just print something to the standard output or
4609 error and exit, before firing up the GUI;
4611 3) extension command line options (-X).
4613 Change-Id: Iba9b8b14fe468e2ca9d4c67e1a9b8103603678d9
4614 Reviewed-on: https://code.wireshark.org/review/16019
4615 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4618 Author: Michael Mann <mmann78@netscape.net>
4619 Date: Sun Jun 19 02:33:13 2016 -0400
4621 Ability to invoke "Decode As..." as command-line argument for GUIshark.
4623 TShark has had the functionality for awhile. While the GUI version
4624 still has ways to change and persist Decode As functionality, adding
4625 command line functionality gives the Decode As from initial launch
4627 Was also an excuse to refactor a bunch of code out of tshark.c
4630 Change-Id: Ie67007d75e897bc06cc9afd9b84372a96b93778c
4631 Reviewed-on: https://code.wireshark.org/review/16008
4632 Reviewed-by: Michael Mann <mmann78@netscape.net>
4635 Author: Guy Harris <guy@alum.mit.edu>
4636 Date: Sun Jun 19 09:52:55 2016 -0700
4638 Get rid of an unused variable.
4640 There's no need for the capture_option_specified variable; it's now in a
4643 Change-Id: Ic2f1faee4666eea7ae91fd6899cecaa76d0ceb9f
4644 Reviewed-on: https://code.wireshark.org/review/16018
4645 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4648 Author: Guy Harris <guy@alum.mit.edu>
4649 Date: Sun Jun 19 09:29:21 2016 -0700
4651 Get rid of an unused variable; set a structure member.
4653 There's no need for the capture_option_specified variable, but we *do*
4654 need to initialize the capture_option_specified member of *param_info
4655 before parsing the flags.
4657 Change-Id: I89d0b8c338c2784742b21ba4e854f702ce491849
4658 Reviewed-on: https://code.wireshark.org/review/16017
4659 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4662 Author: Gerald Combs <gerald@wireshark.org>
4663 Date: Sun Jun 19 08:10:58 2016 -0700
4665 [Automatic update for 2016-06-19]
4667 Update manuf, services enterprise-numbers, translations, and other items.
4669 Change-Id: Idd2d53a32188f2e607351da874b1a68a4811ed57
4670 Reviewed-on: https://code.wireshark.org/review/16014
4671 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4674 Author: Pascal Quantin <pascal.quantin@gmail.com>
4675 Date: Sun Jun 19 11:01:56 2016 +0200
4677 Revert "tap: change glib functions to wmem."
4679 This reverts commit 2e9f3c5d366eaa7139fc877b5301392166b3f985.
4681 It breaks the registration of codec, dissector and libwiretap plugins.
4683 Change-Id: I4ef91dd192f765adf87ea9fe9f3693e25dbd24de
4684 Reviewed-on: https://code.wireshark.org/review/16012
4685 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4686 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4689 Author: Joerg Mayer <jmayer@loplof.de>
4690 Date: Sun Jun 19 10:33:59 2016 +0200
4694 Change-Id: I3d5ed2e671ec761f3628fb8de6f393fdc915165e
4695 Reviewed-on: https://code.wireshark.org/review/16011
4696 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
4699 Author: Joerg Mayer <jmayer@loplof.de>
4700 Date: Fri Jun 17 20:28:58 2016 +0200
4702 Calculate and print CWmin and CWmax in addition to ECWmin and ECWmax
4704 This also changes the summary presentation to make it more compact
4706 Change-Id: I27ef8b2da280e36cff84dcb97d6d40dc0015a74b
4707 Reviewed-on: https://code.wireshark.org/review/16000
4708 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
4711 Author: Guy Harris <guy@alum.mit.edu>
4712 Date: Sun Jun 19 00:49:42 2016 -0700
4714 Fix problems when compiling without pcap.
4716 Change-Id: Id682a76ac561f92f65638bbdfcd4236eb92e46b7
4717 Reviewed-on: https://code.wireshark.org/review/16010
4718 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4721 Author: Guy Harris <guy@alum.mit.edu>
4722 Date: Sun Jun 19 00:38:41 2016 -0700
4724 Put #ifdef/#endif around a variable used only on Windows.
4726 Change-Id: Ia6fed6db03cb88433469e758693fcc72c4bd9071
4727 Reviewed-on: https://code.wireshark.org/review/16009
4728 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4731 Author: Michael Mann <mmann78@netscape.net>
4732 Date: Sat Jun 18 16:49:23 2016 -0400
4734 Refactor command-line handling of GUI options.
4736 Both GTK and Qt both use the same command-line options, so refactor
4737 the parsing and (possibly) applying of those arguments to a single
4741 Change-Id: Ib31e576c509c5d3d21c33d3247640d9f9c68661b
4742 Reviewed-on: https://code.wireshark.org/review/16006
4743 Reviewed-by: Michael Mann <mmann78@netscape.net>
4744 Petri-Dish: Michael Mann <mmann78@netscape.net>
4745 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4746 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4749 Author: Peter Wu <peter@lekensteyn.nl>
4750 Date: Thu Jun 16 14:58:19 2016 -0700
4752 cmake: add PIDL dissector generation support
4754 The dissectors list is generated based on regex magic on pidl/Makefile.
4755 A dssetup.cnf file is added because all other protocols already have
4756 this file. The srvsvc and wkssvc protocols cannot be built for some
4757 reason, so just disable it (this mirrors the original Makefile).
4759 Add frsrpc and samr to PIDL_DISSECTOR_SRC list which was missing
4760 compared to autotools.
4762 Tested with an out-of-tree and in-tree build with cmake (make and ninja):
4764 cmake -GNinja && ninja -v pidl-dissectors
4765 touch epan/dissectors/pidl/dfs/dfs.idl && ninja generate_dissector-dcerpc-dfs
4766 cmake . && make -C epan/dissectors/pidl generate_dissector-dcerpc-dfs
4768 Change-Id: Id8bf34e76c20053a8a393024560d90a048473e03
4769 Reviewed-on: https://code.wireshark.org/review/15962
4770 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
4771 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4772 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4775 Author: Binh Trinh <beango@gmail.com>
4776 Date: Fri Jun 17 21:46:11 2016 -0400
4778 DCE/RPC: fix array of pointers with NULL
4780 Change-Id: Ie89f8fd4ec744d427d41866206d5a6784c5b224f
4781 Reviewed-on: https://code.wireshark.org/review/16004
4782 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
4783 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4784 Reviewed-by: Michael Mann <mmann78@netscape.net>
4787 Author: Chris Brandson <chris.brandson@gmail.com>
4788 Date: Fri Jun 17 11:38:15 2016 -0700
4790 ZigBee dissector added support for the Power Negotiation bit
4792 An update to R22 adds the Power Negotiation bit to the Parent
4793 Information of the End Device Timeout Response
4795 Change-Id: I3d423e1088821ccaba98183e2be7f2152bd659d1
4796 Reviewed-on: https://code.wireshark.org/review/16001
4797 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4798 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4799 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4800 Reviewed-by: Michael Mann <mmann78@netscape.net>
4803 Author: Michael Mann <mmann78@netscape.net>
4804 Date: Fri Jun 17 10:58:32 2016 -0400
4806 GTPv2: Use proto_tree_add_bitmask
4808 Change-Id: I236a3513237a7a977389438adaf381542281943d
4809 Reviewed-on: https://code.wireshark.org/review/15997
4810 Reviewed-by: Michael Mann <mmann78@netscape.net>
4813 Author: Samiran Saha <ssahasamiran@gmail.com>
4814 Date: Fri Jun 17 18:20:04 2016 +0530
4816 MKA: tvbrange for all subtrees corrected
4818 * Incorrect tvbrabge was affecting highlight on selection.
4820 * AN & Confidentiality Offset dissection fixed.
4822 Change-Id: Ibc4422322b765b0073471345f6e0bc3b1aeba2f9
4823 Reviewed-on: https://code.wireshark.org/review/15996
4824 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4827 Author: Kenny Root <kenny@the-b.org>
4828 Date: Thu Jun 16 00:12:53 2016 -0700
4830 ssh: add RSA host key printing
4832 Adds a dissector for the ssh-rsa type of public key where the modulus
4833 and public exponent are extracted out.
4835 Change-Id: I10b1f2d6f41878d9f7ffe5d399b9b7d4f69ad96e
4836 Reviewed-on: https://code.wireshark.org/review/15975
4837 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4840 Author: Kenny Root <kenny@the-b.org>
4841 Date: Wed Jun 15 17:05:54 2016 -0700
4843 ssh: add hostkey information
4845 Adds a framework for hostkey to be printed out separately from the rest
4846 of the key exchange. This will allow for individual key information to
4847 be presented separately in subsequent changes.
4849 Change-Id: I27433772ef1a9e1c45f388809017ed07cf6e41fa
4850 Reviewed-on: https://code.wireshark.org/review/15974
4851 Petri-Dish: Anders Broman <a.broman58@gmail.com>
4852 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4853 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4856 Author: Binh Trinh <beango@gmail.com>
4857 Date: Thu Jun 16 23:51:14 2016 -0400
4859 Diameter-3GPP: add AVP 21 RAT-Type decoding
4861 Change-Id: Ibede796a52bb382525bc1f430d5fdecd555c233f
4862 Reviewed-on: https://code.wireshark.org/review/15993
4863 Reviewed-by: Michael Mann <mmann78@netscape.net>
4864 Petri-Dish: Michael Mann <mmann78@netscape.net>
4865 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4868 Author: Joerg Mayer <jmayer@loplof.de>
4869 Date: Fri Jun 17 17:45:28 2016 +0200
4871 Add an expert item to asure that aifsn is at least 2
4873 Change-Id: If7105ba2e476acca8a02ce740decc4966b0af1bb
4874 Reviewed-on: https://code.wireshark.org/review/15998
4875 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
4878 Author: Dario Lombardo <lomato@gmail.com>
4879 Date: Tue May 3 18:40:17 2016 +0200
4881 tap: change glib functions to wmem.
4883 Change-Id: I878ae6b121a669f9b7f4e1e57bc079f0cb44c0bf
4884 Reviewed-on: https://code.wireshark.org/review/15270
4885 Petri-Dish: Dario Lombardo <lomato@gmail.com>
4886 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4887 Reviewed-by: Evan Huus <eapache@gmail.com>
4888 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4891 Author: Binh Trinh <beango@gmail.com>
4892 Date: Fri Jun 17 01:21:19 2016 -0400
4894 GTPV2: add decoding of ECI into enodebid and cellid
4896 Change-Id: If46cc354e202ff9a126580bf742d747e42678f83
4897 Reviewed-on: https://code.wireshark.org/review/15994
4898 Petri-Dish: Anders Broman <a.broman58@gmail.com>
4899 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4900 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4903 Author: Jens Kilian <jens.kilian@advantest.com>
4904 Date: Fri Jun 17 12:39:09 2016 +0200
4906 Qt: Fix a compile error occurring on RedHat Enterprise Linux.
4908 Another missing Qt #include; probably caused by commit 157721c.
4910 Change-Id: I8ab4be9f18dffde7159debd842201e2a67230ec8
4911 Reviewed-on: https://code.wireshark.org/review/15995
4912 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4913 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4914 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
4917 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4918 Date: Wed Jun 15 00:04:21 2016 +0200
4920 autotool: Add -Wc99-extensions CFLAGS
4922 See with CMake (ga9070e1a90)
4924 Change-Id: If768b663f9ed032503fc121785b078c0107cdadc
4925 Reviewed-on: https://code.wireshark.org/review/15909
4926 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4927 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4928 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4931 Author: Martin Kacer <kacer.martin@gmail.com>
4932 Date: Mon Jun 13 15:47:44 2016 +0200
4934 tshark JSON and Elasticsearch output
4936 Added ouput -T for json|ek
4937 Added -j switch fo filter EK json|ek fields.
4938 Added -x switch to work with json|ek to insert raw fields.
4942 Change-Id: Iad5a9092b843c074b0b774d1745fa14fca09f6b7
4943 Reviewed-on: https://code.wireshark.org/review/15869
4944 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
4945 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
4946 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4947 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4950 Author: Peter Wu <peter@lekensteyn.nl>
4951 Date: Thu Jun 16 15:23:59 2016 -0700
4953 idl2wrs: fix more bad strndups
4955 Fixed another g_strndup case that truncated the name and replaced more
4956 by strdups when possible.
4958 Change-Id: Id7ce4d82da9fb1d0071bc7a6b4e7c2062bf77f55
4959 Reviewed-on: https://code.wireshark.org/review/15988
4960 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4963 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
4964 Date: Thu Jun 16 23:26:58 2016 +0100
4966 mswsp: Remove null check (CID1355407)
4968 value->type is already asserted as not null (and probably shouldn't be).
4970 Change-Id: I574d3e7e0d5c636e6b731c1c817f2e457447afc1
4971 Reviewed-on: https://code.wireshark.org/review/15990
4972 Petri-Dish: João Valverde <j@v6e.pt>
4973 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4974 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4977 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
4978 Date: Wed Jun 15 02:20:11 2016 +0100
4980 Align AUTHORS.src column
4982 Change-Id: I17ed5e0be356666e9b29490ce43deb357fe177ff
4983 Reviewed-on: https://code.wireshark.org/review/15991
4984 Reviewed-by: João Valverde <j@v6e.pt>
4987 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
4988 Date: Thu Jun 16 10:38:33 2016 +0100
4990 LDSS: Add an assertion (CID280539,CID280540)
4992 Change-Id: I18082a4d45f0c320b8ee0e11139295eb1aee2c89
4993 Reviewed-on: https://code.wireshark.org/review/15968
4994 Petri-Dish: João Valverde <j@v6e.pt>
4995 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4996 Reviewed-by: João Valverde <j@v6e.pt>
4999 Author: Gerald Combs <gerald@wireshark.org>
5000 Date: Thu Jun 16 14:09:28 2016 -0700
5002 Qt: Add "Copy As…" to VoIP Calls.
5005 Change-Id: I88dba82bd63e8c3be2b6fac3eca88f810c62d8bd
5006 Reviewed-on: https://code.wireshark.org/review/15985
5007 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5008 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5009 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5010 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5013 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
5014 Date: Thu Jun 16 10:18:07 2016 +0100
5016 CANopen: Check array bounds for untrusted index (CID 1356262)
5018 Change-Id: If5ca51e5703fa4137ab9f388a99d613752d3b0d0
5019 Reviewed-on: https://code.wireshark.org/review/15983
5020 Reviewed-by: Michael Mann <mmann78@netscape.net>
5021 Petri-Dish: Michael Mann <mmann78@netscape.net>
5022 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5023 Reviewed-by: João Valverde <j@v6e.pt>
5026 Author: Gerald Combs <gerald@wireshark.org>
5027 Date: Thu Jun 16 13:31:47 2016 -0700
5029 Add a sequence analysis wishlist item.
5031 Change-Id: Idea0bab80c7c05e3ad9f8591904e882df69a17ff
5032 Reviewed-on: https://code.wireshark.org/review/15984
5033 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5036 Author: Martin Kaiser <wireshark@kaiser.cx>
5037 Date: Thu Jun 16 10:20:40 2016 -0700
5039 lemon: use a define for fseek()'s whence parameter
5041 for people who don't immediately understand what fseek(fp, 0, 2) does
5043 Change-Id: I297ba6fd718ef0f09c4d0b29bf433262c3c38435
5044 Reviewed-on: https://code.wireshark.org/review/15976
5045 Petri-Dish: Michael Mann <mmann78@netscape.net>
5046 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5047 Reviewed-by: Michael Mann <mmann78@netscape.net>
5050 Author: Victor Barratault <victor.barratault@gmail.com>
5051 Date: Thu Jun 16 14:06:32 2016 -0400
5053 ldap: added modify-increment operation identification in packet dissection and generate the modified dissector dissector
5055 Change-Id: Iad745b9e0e8ab0bc055da7f26ec0822433897db7
5056 Reviewed-on: https://code.wireshark.org/review/15977
5057 Reviewed-by: Michael Mann <mmann78@netscape.net>
5058 Petri-Dish: Michael Mann <mmann78@netscape.net>
5059 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5060 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5063 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5064 Date: Thu Jun 16 20:51:24 2016 +0200
5066 DEC DNART: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
5068 Change-Id: Ic2d333b418928351f32673890c9c432c7bfa0f16
5069 Reviewed-on: https://code.wireshark.org/review/15982
5070 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5073 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5074 Date: Thu Jun 16 20:48:58 2016 +0200
5076 SITA: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
5078 Change-Id: I2565b0bee66f934561df506e87a35fdd14590f92
5079 Reviewed-on: https://code.wireshark.org/review/15981
5080 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5083 Author: Michael Mann <mmann78@netscape.net>
5084 Date: Wed Jun 15 18:54:07 2016 -0400
5086 DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_value
5088 Change-Id: I88398aa1923e86bb83b97cc3904529a5810f6c40
5089 Reviewed-on: https://code.wireshark.org/review/15978
5090 Petri-Dish: Michael Mann <mmann78@netscape.net>
5091 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5092 Reviewed-by: Michael Mann <mmann78@netscape.net>
5095 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
5096 Date: Tue Jun 14 23:59:12 2016 +0200
5098 Add Cisco ttag dissector
5100 Add dissector for Cisco ttag protocol.
5103 Change-Id: Id17293a80b2b6827fd2d5c7ead098784c35a28ef
5104 Reviewed-on: https://code.wireshark.org/review/15964
5105 Petri-Dish: Michael Mann <mmann78@netscape.net>
5106 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5107 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
5110 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5111 Date: Thu Jun 16 12:43:24 2016 -0400
5113 Finish getting making the Diameter XML valid XML.
5115 ... Except for the fact that many AVP names start with "3GPP".
5117 Make the AVP names XML IDs again.
5119 Fix all the grouped AVPs that reference AVPs (by name) or vice-versa. This
5121 * Fixing a bunch of typos (including type mismatches).
5122 * Commenting out a number of references to vendor AVPs for which we don't have
5124 * Adding a few missing AVPs.
5126 Change-Id: Ic2ddb50cc947877de9086be51f7813e8f9be02b4
5127 Reviewed-on: https://code.wireshark.org/review/15973
5128 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5131 Author: Kenny Root <kenny@the-b.org>
5132 Date: Wed Jun 15 23:53:49 2016 -0700
5134 ssh: set packet lengths correctly
5136 Each SSH packet was being set to be the remaining length of the frame.
5137 This change sets the packet lengths correctly for each SSH packet.
5139 Change-Id: Id9c2331d875465cd5e6bb788d420e0025f5d496e
5140 Reviewed-on: https://code.wireshark.org/review/15966
5141 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5142 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5143 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5146 Author: Kenny Root <kenny@the-b.org>
5147 Date: Wed Jun 15 23:54:43 2016 -0700
5149 ssh: packets after SSH_MSG_NEWKEYS are encrypted
5151 According to RFC 4253 section 7.3, once the SSH_MSG_NEWKEYS is received
5152 all packets after that will be encrypted using the negotiated keys. This
5153 can happen in the middle of a frame, so account for the offset in the
5154 frame where this happens.
5156 Change-Id: Ibc3b06a4bdfe38ae15b0e65afac6f5d3646cb58d
5157 Reviewed-on: https://code.wireshark.org/review/15965
5158 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5159 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5160 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5163 Author: Michael Mann <mmann78@netscape.net>
5164 Date: Wed Jun 15 15:35:51 2016 -0400
5166 DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_with_flags
5168 Change-Id: I8891ec90244ffd9609d8443df631a7c8e6453b7e
5169 Reviewed-on: https://code.wireshark.org/review/15942
5170 Petri-Dish: Michael Mann <mmann78@netscape.net>
5171 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5172 Reviewed-by: Michael Mann <mmann78@netscape.net>
5175 Author: Samiran Saha <ssahasamiran@gmail.com>
5176 Date: Thu Jun 16 17:15:06 2016 +0530
5178 MKA: Fix for GCM-AES-256 dissection & Added Enumeration for macsec-cipher-suite
5180 Change-Id: Ief38f949d3e30754a65fbfeaa64cbbd2f5646a9b
5181 Reviewed-on: https://code.wireshark.org/review/15969
5182 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5183 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5184 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5187 Author: Thomas Shen <thomashen@gmail.com>
5188 Date: Wed Jun 15 14:26:02 2016 -0700
5190 NSH: Correct the display of the NSH header fields
5192 Change-Id: I3be75d20a3f00091aa3077e475f9ddb00eeca06c
5193 Reviewed-on: https://code.wireshark.org/review/15963
5194 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5195 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5196 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5197 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5200 Author: Stig Bjørlykke <stig@bjorlykke.org>
5201 Date: Thu Jun 16 14:32:58 2016 +0200
5203 gtk: Check chunk before g_string_chunk_clear
5205 Avoid this warning from wireshark-gtk:
5206 (wireshark-gtk:39505): GLib-CRITICAL **: g_string_chunk_clear: assertion
5207 'chunk != NULL' failed
5209 Change-Id: I413b3435a1ac595236dd1c4e619e3af1543b6a91
5210 Reviewed-on: https://code.wireshark.org/review/15970
5211 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
5212 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5213 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5216 Author: Victor Barratault <victor.barratault@gmail.com>
5217 Date: Tue Jun 14 12:17:54 2016 -0400
5219 Typing error line 4928 of packet-dns.c
5221 Change-Id: I1a6409262614a87c159236375223707c85114650
5222 Reviewed-on: https://code.wireshark.org/review/15972
5223 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5226 Author: Peter Wu <peter@lekensteyn.nl>
5227 Date: Wed Jun 15 22:23:46 2016 -0700
5229 gitignore: updated cmake paths
5231 * files.txt: v2.1.0rc0-2918-g2e23b50 ("Add checkAPI calls to CMake.")
5232 * epan: v2.1.0rc0-2202-g6b54fbf ("CMake: Add more structure to
5233 libwireshark build")
5234 * asn1: v2.1.0rc0-2330-g54a520d ("Move /asn1 to /epan/dissectors")
5236 Change-Id: I0ef590de7d262d96c011be360b958fbda72a61fa
5237 Reviewed-on: https://code.wireshark.org/review/15961
5238 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
5241 Author: Peter Wu <peter@lekensteyn.nl>
5242 Date: Sat Feb 28 17:44:27 2015 +0100
5244 filesystem: Fix build dir detection when using cmake
5246 Fixes loading of plugins by detecting the build output directory of
5247 cmake. This requires a "CMakeCache.txt" file to be present in the parent
5248 directory (above run/).
5250 Change-Id: I297432cdcd0981646058410f3eadf5f73b5248c8
5251 Reviewed-on: https://code.wireshark.org/review/7453
5252 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
5253 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5254 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5257 Author: Gerald Combs <gerald@wireshark.org>
5258 Date: Wed Jun 15 13:17:41 2016 -0700
5260 Add a note about the new intelligent scroll bar.
5262 Should we call it the intelligenter scroll bar?
5264 Change-Id: I67e76c1aabeb4b2e87e38815fe4ab120f0869b25
5265 Reviewed-on: https://code.wireshark.org/review/15936
5266 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5269 Author: Martin Kaiser <wireshark@kaiser.cx>
5270 Date: Wed Jun 15 19:53:45 2016 -0700
5272 CID 1250642: check the return value of dup()
5276 Change-Id: Ie14c18679ff74529731558d6742f63ebfb9fe97b
5277 Reviewed-on: https://code.wireshark.org/review/15958
5278 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5279 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5280 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5283 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5284 Date: Thu Jun 16 00:04:36 2016 -0400
5286 Make the rest of the Diameter AVP names unique.
5288 In most cases this means prepending the application- or vendor-name to force
5289 uniqueness. A few vendors have duplicates within their namespace--append the
5292 Also fix a few other invalid names (with spaces or parentheses in the names).
5294 Change-Id: I5bb78d31526122dd5782055638af410cc497e49d
5295 Reviewed-on: https://code.wireshark.org/review/15960
5296 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5299 Author: Balint Reczey <balint@balintreczey.hu>
5300 Date: Tue Jun 14 22:29:34 2016 -0700
5302 cmake: Detect proper large file defines even with -Wno-error
5304 Without this change large file support was detected as available
5305 even when it was not without additional flags on 32 architectures.
5307 As a result mergecap and other programs are built without large
5308 file support causing mergecap not being able to write files
5309 bigger than 2GB on i386 systems. This used to work properly
5310 with autotools builds, but not with CMake ones.
5312 Change-Id: Ibfd043342b2a48310d2ac9d760e6404a701c5808
5313 Reviewed-on: https://code.wireshark.org/review/15937
5314 Petri-Dish: Balint Reczey <balint@balintreczey.hu>
5315 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5316 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
5319 Author: Dario Lombardo <lomato@gmail.com>
5320 Date: Wed Jun 15 00:47:44 2016 +0200
5322 qt: move free_stat_tables from SimpleStatisticsDialog::fillTree to ~SimpleStatisticsDialog.
5324 Add a reference count to stat_tap_table_ui to prevent bad deallocations.
5327 Change-Id: Ib9b1f929d08a574c306dc755ec416ab94a3fd6d3
5328 Reviewed-on: https://code.wireshark.org/review/15920
5329 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
5330 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
5331 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5332 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5335 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5336 Date: Wed Jun 15 13:25:44 2016 -0400
5338 Update the X11 dissector to use the latest mesa and xcbproto.
5340 Change-Id: Ia1395cffaebbcf6585b9167861d8c3b4d86cf821
5341 Reviewed-on: https://code.wireshark.org/review/15923
5342 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5343 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5344 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5347 Author: Balint Reczey <balint@balintreczey.hu>
5348 Date: Wed Jun 15 19:16:42 2016 -0700
5350 Qt: Clarify follow stream dialog's format button
5352 The stream is not just shown, but also saved in ASCII, EBDIC, Raw, etc.
5354 Change-Id: Ic29e3273ebb9a3eca0fe791bdd48606c4be3b828
5355 Reviewed-on: https://code.wireshark.org/review/15957
5356 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5359 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5360 Date: Wed Jun 15 23:35:58 2016 +0200
5362 X11: Fix last indent issue on X11 generator
5364 and regenerate X11 dissector
5366 Change-Id: If2c781d346713f5a2a2e97de84c0fedcfd1958af
5367 Reviewed-on: https://code.wireshark.org/review/15944
5368 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5371 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5372 Date: Wed Jun 15 22:52:18 2016 +0200
5374 x11: Regenerate dissector after indent change on g2b8caf31cca
5376 Change-Id: Iac1522998c5983b417a0083b9c607a60e7f66e8c
5377 Reviewed-on: https://code.wireshark.org/review/15943
5378 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5381 Author: Dario Lombardo <lomato@gmail.com>
5382 Date: Thu Jun 16 01:25:03 2016 +0200
5384 randpktdump: fix a crash.
5386 Randpktdump requires the init the wtap opttypes.
5387 Fixed making the init function public and calling it.
5390 Change-Id: I02585c41012deacff1526b51ed09ab555cbfc8ce
5391 Reviewed-on: https://code.wireshark.org/review/15951
5392 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5393 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5394 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5395 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5398 Author: AndersBroman <anders.broman@ericsson.com>
5399 Date: Wed Jun 15 23:57:39 2016 +0200
5401 Don't call g_ascii_strcasecmp() with an NULL string.
5403 Change-Id: I6efbdcb51efe5f2db233827e32e2105db6322d6c
5404 Reviewed-on: https://code.wireshark.org/review/15946
5405 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5408 Author: Dario Lombardo <lomato@gmail.com>
5409 Date: Thu Jun 16 02:34:27 2016 +0200
5411 gtk: add initializer (CID 1362745).
5413 Change-Id: Ib1bc11e905b0a4e84302e3f9ac43f3a87afd6edf
5414 Reviewed-on: https://code.wireshark.org/review/15954
5415 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5418 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5419 Date: Wed Jun 15 22:01:31 2016 -0400
5421 Remove a bunch of unassigned ETSI AVPs.
5423 These were presumably there to allow indexed search of the AVP list but it
5424 wasn't working anyway (binary search was used). And the expert info for
5425 "unknown" (to Wireshark) AVPs is a good thing.
5427 Change-Id: Id6b9e5c90b8a2a6e3cf4415cd1b6114308c74440
5428 Reviewed-on: https://code.wireshark.org/review/15956
5429 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5432 Author: Rudra Rugge <rudrarugge@gmail.com>
5433 Date: Wed Jun 15 15:22:25 2016 -0700
5435 ip-over-ib description entry was missing
5437 Description entry was missing in the list.
5439 Change-Id: Ia8f8bd4608ee6800a352f4979752b5c45c4a5086
5440 Reviewed-on: https://code.wireshark.org/review/15947
5441 Reviewed-by: Michael Mann <mmann78@netscape.net>
5442 Petri-Dish: Michael Mann <mmann78@netscape.net>
5443 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5444 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5447 Author: Pascal Quantin <pascal.quantin@gmail.com>
5448 Date: Wed Jun 15 18:06:04 2016 -0700
5450 Export wtap_optionblock_copy_options() symbol
5452 It can be useful for wiretap plugins
5454 Change-Id: Ic56e4357ba3bfcef30d13615efc1361399c3133e
5455 Reviewed-on: https://code.wireshark.org/review/15955
5456 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5459 Author: Pascal Quantin <pascal.quantin@gmail.com>
5460 Date: Wed Jun 15 13:42:56 2016 -0700
5462 file_util.c: do not search in Npcap installation folder when calling ws_load_library()
5464 ws_load_library() is not used to load packet.dll or wpcap.dll (we use ws_module_open() for this).
5465 Let's not lose time checking the folder content.
5467 Change-Id: Ibd4a71b8b0c5ffc0c4c146eca51ad9f20964515b
5468 Reviewed-on: https://code.wireshark.org/review/15938
5469 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5472 Author: Martin Kaiser <wireshark@kaiser.cx>
5473 Date: Wed Jun 15 13:02:39 2016 -0700
5475 mongo: return the number of bytes we actually consumed
5477 even if the document length is 0, we consumed at least 4 bytes for the
5481 Change-Id: I2f1612bf575b558c1bcc0afe8202b202747846e3
5482 Reviewed-on: https://code.wireshark.org/review/15934
5483 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5486 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5487 Date: Wed Jun 15 18:40:53 2016 -0400
5489 Make some more Diameter AVP names unique.
5491 In some cases this means using the correct (updated?) name from the
5492 specification. In others it means prepending the application- or vendor-name
5493 to force uniqueness.
5495 Remove a few more "Unassigned" AVPs from the XML files.
5497 Change-Id: I61d55ef97ff8efc3317c91bf79e73031735f740a
5498 Reviewed-on: https://code.wireshark.org/review/15949
5499 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5502 Author: Peter Wu <peter@lekensteyn.nl>
5503 Date: Wed Jun 15 14:06:23 2016 -0700
5505 idl2wrs: fix code generation
5507 Fixes a regression from v1.99.9rc0-470-g87f2bd4 which truncated function
5508 names to 26 characters.
5512 cd epan/dissectors/dcerpc/budb
5513 make IDL2WRS=/tmp/wsbuild/run/idl2wrs
5514 diff packet-dcerpc-budb.c ../../packet-dcerpc-budb.c
5516 While at it, replace all g_strndup(X, strlen(X)) occurrences with
5517 g_strdup(X) since that is the same thing and less redundant.
5519 Change-Id: Id8da45792c830e2287cf8f14ff6245149751afd2
5520 Reviewed-on: https://code.wireshark.org/review/15939
5521 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
5522 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5523 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5524 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5527 Author: Balint Reczey <balint@balintreczey.hu>
5528 Date: Wed Jun 15 15:40:15 2016 -0700
5530 gtk: Fix null dereference in stats
5532 This fixes the bug reported to Debian:
5533 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786704
5535 Change-Id: Iabe19c11067318d78664a17fa00d6a4d1998250c
5536 Reviewed-on: https://code.wireshark.org/review/15948
5537 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
5540 Author: Pascal Quantin <pascal.quantin@gmail.com>
5541 Date: Wed Jun 15 14:50:03 2016 -0700
5543 proto.c: allow calling proto_item_add_bitmask_tree() with a length set to 0
5545 This is required for the flags from packet-frame.c
5548 Change-Id: I60bfe671687bcd3a9b5c997ba62bed563e890548
5549 Reviewed-on: https://code.wireshark.org/review/15945
5550 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5551 Reviewed-by: Michael Mann <mmann78@netscape.net>
5554 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5555 Date: Wed Jun 15 20:35:47 2016 +0200
5557 capture info (wslua): Dereference of null pointer
5559 Change-Id: Iced579d5acaefa9d1c8e3775a53916773bf87659
5560 Reviewed-on: https://code.wireshark.org/review/15929
5561 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5562 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5563 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
5566 Author: Balint Reczey <balint@balintreczey.hu>
5567 Date: Wed Jun 15 14:14:23 2016 -0700
5569 documentation: Suggest using prefixed public symbols
5571 Change-Id: I9153756b0e921fd74d7df9d119337f5484856ba0
5572 Reviewed-on: https://code.wireshark.org/review/15940
5573 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5576 Author: Gerald Combs <gerald@wireshark.org>
5577 Date: Wed Jun 15 11:27:53 2016 -0700
5579 Qt: Adjust the search frame layout.
5581 Add padding on the left side of the search frame in order to reduce the
5582 amount of mousing required on large screens.
5584 Change-Id: I1dcd8c4a103f4a462f4ab60a22a93b8c0f28b055
5585 Reviewed-on: https://code.wireshark.org/review/15928
5586 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5587 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5588 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5591 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5592 Date: Wed Jun 15 16:01:05 2016 -0400
5594 Make some Diameter AVP names unique.
5596 In some cases this means using the correct (updated?) name from the
5597 specification. In others it means prepending the application name to force
5600 Change-Id: I8301c769af2b2279c0be7c1bc65e99fe25c1cc80
5601 Reviewed-on: https://code.wireshark.org/review/15935
5602 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5605 Author: dsrsupport <eugene.exarevsky@dsr-company.com>
5606 Date: Wed Jun 15 19:45:50 2016 +0300
5608 ZigBee: decode ZBOSS traffic dump and Interpan frames as ZigBee.
5610 If decoded ZBOSS traffic dump, sure this is ZigBee, so bypass heuristic.
5611 If decoding air sniffer dump, try to go thru heuristic by checking for ext address src mode required for interpan.
5613 Change-Id: Iddf799400a4cf0fd73714f06b99e3d11c8cb2e60
5614 Reviewed-on: https://code.wireshark.org/review/15921
5615 Reviewed-by: Michael Mann <mmann78@netscape.net>
5616 Petri-Dish: Michael Mann <mmann78@netscape.net>
5617 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5618 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5621 Author: Gerald Combs <gerald@wireshark.org>
5622 Date: Fri Jun 10 15:26:57 2016 -0700
5624 Pass "/utf-8" to Visual C++ 2015.
5626 Many projects (Qt[1] and GNOME[2] in particular) either recommend, use,
5627 or at least allow for UTF-8 in source and header files. Pass /utf-8 to
5628 Visual C++ 2015 so that it will behave itself around UTF-8 and be more
5629 like that nice compiler down the street.
5631 [1] https://wiki.qt.io/Strings_and_encodings_in_Qt
5632 [2] https://bugzilla.gnome.org/show_bug.cgi?id=767218
5634 Change-Id: Ibc90d235742134cb42dd796ba529699bcbbe3ad0
5635 Reviewed-on: https://code.wireshark.org/review/15821
5636 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5637 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5638 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5641 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5642 Date: Wed Jun 15 20:14:18 2016 +0200
5644 diameter (3GPP): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
5646 Change-Id: Iaa74265df66455528c86658a26812876574a904a
5647 Reviewed-on: https://code.wireshark.org/review/15927
5648 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5649 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5650 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5653 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5654 Date: Wed Jun 15 13:31:41 2016 -0400
5656 Update to the latest config.guess and config.sub
5658 Change-Id: Id493fb3b79326b522a3a11c3258531683f159187
5659 Reviewed-on: https://code.wireshark.org/review/15924
5660 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
5661 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5662 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5665 Author: dsrsupport <eugene.exarevsky@dsr-company.com>
5666 Date: Wed Jun 15 18:48:01 2016 +0300
5668 ZigBee: add support for inter-pan transmissions.
5670 Added dissection of inter-pan nwk and aps stub to be used to decode ZLL commissioning cluster.
5672 Change-Id: I871016a93854f1caf2f14f2f84e5397de5f1e2ff
5673 Reviewed-on: https://code.wireshark.org/review/15918
5674 Reviewed-by: Michael Mann <mmann78@netscape.net>
5675 Petri-Dish: Michael Mann <mmann78@netscape.net>
5676 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5677 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5680 Author: Pascal Quantin <pascal.quantin@gmail.com>
5681 Date: Wed Jun 8 15:57:00 2016 +0200
5683 Remove Nmake build system
5685 Change-Id: I3bd474f3cda9667dec66426b5729449953df3e61
5686 Reviewed-on: https://code.wireshark.org/review/15777
5687 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5688 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5689 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
5690 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
5693 Author: Guy Harris <guy@alum.mit.edu>
5694 Date: Wed Jun 15 12:15:54 2016 -0700
5696 Don't map the interface ID for records that don't pertain to an interface.
5698 And revert to the previous behavior of map_phdr_interface_id(); that
5699 change broke the mergecap tests when it was merging pcap files into a
5702 Change-Id: I2e079b0e87dce06e98faa9ab7615f9b9b2701b77
5703 Reviewed-on: https://code.wireshark.org/review/15932
5704 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5707 Author: Pascal Quantin <pascal.quantin@gmail.com>
5708 Date: Wed Jun 15 11:46:53 2016 -0700
5710 Win: convert atkversion.h to UTF-8
5712 Change-Id: I7bfa9be11596cc9a3e1b0226c6865edf47e96782
5713 Reviewed-on: https://code.wireshark.org/review/15931
5714 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5717 Author: Dario Lombardo <lomato@gmail.com>
5718 Date: Wed Jun 15 20:05:32 2016 +0200
5720 qt: add initializer to ExpertPacketTreeWidgetItem (CID 1362746).
5722 Change-Id: I8ca154907e01fb40affb9e5f5a0aaf55921c95db
5723 Reviewed-on: https://code.wireshark.org/review/15926
5724 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5727 Author: Martin Kaiser <wireshark@kaiser.cx>
5728 Date: Wed Jun 15 10:53:43 2016 -0700
5730 zbee-nwk: don't THROW() an exception from a dissector
5732 we already have an expert info, so we can just return the number of
5735 Change-Id: I6199760316d7ef141877bc8f65012d36e4dd357b
5736 Reviewed-on: https://code.wireshark.org/review/15925
5737 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5740 Author: Stig Bjørlykke <stig@bjorlykke.org>
5741 Date: Fri Mar 11 18:42:49 2016 +0100
5743 wtap: Make default_filter static
5745 Address of stack memory associated with local variable 'default_filter'
5746 is still referred to by the global variable 'filter_option' upon returning
5747 to the caller. This will be a dangling reference.
5749 Change-Id: I6160a37f05b8aea245b723ec50803e4062886738
5750 Reviewed-on: https://code.wireshark.org/review/14427
5751 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
5752 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5753 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5756 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
5757 Date: Wed Sep 30 14:34:39 2015 +0100
5759 Display "IP DSCP" column as short text
5762 Change-Id: I618b2017e161d89f0efa25ce2fb82a1808e8d315
5763 Reviewed-on: https://code.wireshark.org/review/10701
5764 Reviewed-by: João Valverde <j@v6e.pt>
5767 Author: Peter Wu <peter@lekensteyn.nl>
5768 Date: Wed Jun 15 08:45:54 2016 -0700
5770 androiddump: fix leak on --extcap-interfaces
5772 extcap_base_register_interface duplicates the memory, so there is no
5773 need to keep it around.
5775 Change-Id: I2bac8be519b659504c512d4eb29be8f7ef6dbd59
5776 Reviewed-on: https://code.wireshark.org/review/15919
5777 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5780 Author: Pascal Quantin <pascal.quantin@gmail.com>
5781 Date: Wed Jun 15 08:24:48 2016 -0700
5783 win-setup.ps1: stop downloading user-guide; with CMake it is generated from source code
5785 Change-Id: I3b015594bd6a6b0c41938ba17d5690c08e04f490
5786 Reviewed-on: https://code.wireshark.org/review/15917
5787 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5788 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5789 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5792 Author: Michael Mann <mmann78@netscape.net>
5793 Date: Tue Jun 14 23:17:25 2016 -0400
5795 proto_tree_add_boolean -> proto_tree_add_bitmask_list_value
5797 Change-Id: Ic644042d238b5f2abcd874bca92c6dea55804ba9
5798 Reviewed-on: https://code.wireshark.org/review/15913
5799 Petri-Dish: Michael Mann <mmann78@netscape.net>
5800 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5801 Reviewed-by: Michael Mann <mmann78@netscape.net>
5804 Author: Gerald Combs <gerald@zing.org>
5805 Date: Sun Apr 24 11:21:50 2016 -0700
5807 More Sysdig / system event support.
5809 Add REC_TYPE_SYSCALL to wiretap and use it for Sysdig events. Call the
5810 Sysdig event dissector from the frame dissector. Create a "syscall"
5811 protocol for system calls, but add "frame" items to it for now.
5813 Add the ability to write Sysdig events. This lets us merge packet
5814 capture and syscall capture files.
5816 Change-Id: I12774ec69c89d8e329b6130c67f29aade4e3d778
5817 Reviewed-on: https://code.wireshark.org/review/15078
5818 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5819 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5822 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
5823 Date: Wed Jun 15 08:53:14 2016 +0200
5825 Let the calculated window scale be 16 bit wide.
5827 Even though TCP window scale shift is only 8 bits, the scale
5828 calculated from it is max 16384. therefor a 16 bit value.
5829 Let the tree item map to the single byte in the TVB, while
5830 allowing the value to be 16 bit.
5833 Change-Id: I41cebc62f6b8b09e13efa5f3b7432001e8d994e1
5834 Reviewed-on: https://code.wireshark.org/review/15914
5835 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
5836 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5837 Reviewed-by: Michael Mann <mmann78@netscape.net>
5840 Author: Michael Mann <mmann78@netscape.net>
5841 Date: Tue Jun 14 11:55:08 2016 -0400
5843 Allow control of individual columns to be (un)writable.
5845 Most protocols just want to limit COL_INFO or COL_PROTOCOL
5846 so give that level of granularity.
5851 Change-Id: I8de9b7d2c69e90d3fbfc0a52c2bd78c3de58e2f8
5852 Reviewed-on: https://code.wireshark.org/review/15894
5853 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
5854 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5855 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5856 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5859 Author: Peter Wu <peter@lekensteyn.nl>
5860 Date: Tue Jun 14 14:52:01 2016 -0700
5862 cmake: fix ENABLE_ASAN detection
5864 Do not add -fsanitize=undefined when ASAN is requested, UBSAN is a
5865 different feature (which could be added later as desired). This makes
5866 the -DENABLE_ASAN=1 option match the autotools --enable-asan option.
5868 Fail hard if ASAN support is requested but not supported, this avoids
5869 surprises when something is wrong. Fix ASAN detection by setting the
5872 Note: if you have previously set ENABLE_ASAN=1 with the broken ASAN
5873 detection, you have to clear your CMakeCache.txt file to redo the
5876 Change-Id: Iba6ca0da0336eccedd0cf31a251baad9d1aff5b4
5877 Reviewed-on: https://code.wireshark.org/review/15908
5878 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
5879 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5880 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5881 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5884 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
5885 Date: Mon Jun 13 15:28:16 2016 -0400
5887 Change how dissectors do late-field-registration to avoid a double-registration
5890 If a dissector forces registration of fields during dissection it needs to do
5891 so in a way that clears the prefix registration. Otherwise epan will call the
5892 registration routine a 2nd time (which will cause us to assert out) if a user
5893 types a display filter (with the dissector's prefix) that doesn't exist.
5895 Update the proto_register_prefix() comments to reflect this.
5897 Change-Id: I3ce29243395fb55192bb5dfd950baa88410ac136
5898 Reviewed-on: https://code.wireshark.org/review/15881
5899 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
5900 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5901 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
5904 Author: Martin Kaiser <wireshark@kaiser.cx>
5905 Date: Mon Jun 13 18:05:11 2016 -0700
5907 mount: fix a memory leak
5909 don't copy the wmem-buffer from address_to_str() into a g_malloc()ed one
5912 instead, realloc the wmem-buffer and add the nfs path to it
5914 (nfs_name_snoop_add_name() will make a copy internally)
5916 Change-Id: I4274a4a413c09f3f1d78beba65d94748ce185413
5917 Reviewed-on: https://code.wireshark.org/review/15902
5918 Petri-Dish: Michael Mann <mmann78@netscape.net>
5919 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5920 Reviewed-by: Michael Mann <mmann78@netscape.net>
5923 Author: Guy Harris <guy@alum.mit.edu>
5924 Date: Tue Jun 14 17:35:51 2016 -0700
5926 Clean up some messages.
5928 We're checking for more than just a 64-bit off_t; we're checking for the
5929 ability to do 64-bit seeks in files, even if, as on Windows, the APIs
5932 Remove trailing white space and clean up some comments while we're at
5935 Change-Id: I6122b6d6b44ff5dd3a4d8268f9793193e65817ce
5936 Reviewed-on: https://code.wireshark.org/review/15912
5937 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5940 Author: Pascal Quantin <pascal.quantin@gmail.com>
5941 Date: Tue Jun 14 16:11:18 2016 -0700
5945 Dirty CORBA IDL dissectors must be compiled without -Werror option
5947 Change-Id: I46431c635274399cd6d365a608cdc0aecbc59c95
5948 Reviewed-on: https://code.wireshark.org/review/15911
5949 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5952 Author: Dario Lombardo <lomato@gmail.com>
5953 Date: Tue Jun 14 19:35:32 2016 +0200
5955 dns_stats: generate stats just for pure dns (not mDNS, not LLMR).
5957 The stats for mDNS and llmnr are pending. The change just resolves a bug
5958 in the stats that are wrongly generated when the traffic is mDNS or LLMR.
5961 Change-Id: Ie772e204d0ddea997dd8cbf609725605c8a507c8
5962 Reviewed-on: https://code.wireshark.org/review/15897
5963 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5966 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5967 Date: Tue Jun 14 23:43:15 2016 +0200
5969 proto(.h): fix '@return' command used in a comment that is attached to a function returning void [-Wdocumentation]
5971 Change-Id: Ie0e502adcc8eb00f65ffa6c018d5b9d79655ddb7
5972 Reviewed-on: https://code.wireshark.org/review/15907
5973 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5974 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5975 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5976 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5979 Author: Michael Mann <mmann78@netscape.net>
5980 Date: Tue Jun 14 17:23:58 2016 -0400
5982 FIX dissector - Improve Message info
5985 Change-Id: I4b2d60549f9680bbc008a2abba5d7ec108f6bf22
5986 Reviewed-on: https://code.wireshark.org/review/15905
5987 Petri-Dish: Michael Mann <mmann78@netscape.net>
5988 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5989 Reviewed-by: Michael Mann <mmann78@netscape.net>
5992 Author: Pascal Quantin <pascal.quantin@gmail.com>
5993 Date: Mon Jun 13 15:11:55 2016 -0700
5995 CORBA IDL: compile dissectors with /Ox when using MSVC2013 x64
5997 By default Windows files are compiled with /O2 optimization flag (that brings the best performance).
5998 But MSVC2013 x64 compiler generates buggy code for CORBA IDL dissectors.
5999 Let's downgrade the optimization to /Ox for those files specifically.
6002 Change-Id: Ibbb532653808d915c82bd20b55dd9e68d86b1207
6003 Reviewed-on: https://code.wireshark.org/review/15884
6004 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
6007 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6008 Date: Tue Jun 14 17:38:17 2016 -0400
6010 Don't list "AVP" as a possible member of a grouped AVP.
6012 There's no AVP named "AVP". And there's no need to tell Wireshark that any AVP
6013 may put in the group (the RFC lists "AVP" for that purpose).
6015 Change-Id: I3591af725ebe089e13eae7b712ef4404cb7924a2
6016 Reviewed-on: https://code.wireshark.org/review/15906
6017 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6020 Author: Dario Lombardo <lomato@gmail.com>
6021 Date: Tue Apr 5 18:24:25 2016 +0200
6023 packet.c: remove const compiler warning.
6025 Change-Id: Ida9384dccb0e8bacbc9aad39515c3dae9c5ce563
6026 Reviewed-on: https://code.wireshark.org/review/14768
6027 Reviewed-by: João Valverde <j@v6e.pt>
6028 Petri-Dish: João Valverde <j@v6e.pt>
6029 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6030 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6033 Author: Pascal Quantin <pascal.quantin@gmail.com>
6034 Date: Tue Jun 14 11:31:10 2016 -0700
6036 Qt: fix crash when opening Expert Info dialog
6038 g6ff19ff tried to access cinfo by following a chain of pointers from
6039 expert_info. Access cinfo from cap_file_, which is more reliable. While
6040 we are at it, let's explicitly check the pointer validity.
6042 Change-Id: I0da72c5b1d2230a49c125a1b57c81c3115c4f2fb
6043 Reviewed-on: https://code.wireshark.org/review/15901
6044 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6045 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6046 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6047 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6050 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6051 Date: Tue Jun 14 10:52:28 2016 -0400
6053 Give unique names to a bunch of reserved, experimental, etc., AVPs.
6055 Also remove a bunch of AVPs that are unassigned/unallocated--there's no
6056 real benefit to telling users that...
6058 Change-Id: I1b18a11a1b65189d21520c74aae3dde77688e592
6059 Reviewed-on: https://code.wireshark.org/review/15895
6060 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6063 Author: Joerg Mayer <jmayer@loplof.de>
6064 Date: Tue Jun 14 21:45:53 2016 +0200
6066 Replace wlan_ignore_wep_ by wlan_ignore_prot_ and WLAN_IGNORE_WEP_ by WLAN_IGNORE_PROT_
6068 Change-Id: I870cc1e5293dd6e1a1b71157987e27399e080a73
6069 Reviewed-on: https://code.wireshark.org/review/15904
6070 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
6073 Author: Dario Lombardo <lomato@gmail.com>
6074 Date: Mon May 2 17:21:57 2016 +0200
6076 tvbparse: change g_hash_table to wmem_map.
6078 Change-Id: I245595051617f6d6333314240825a526adf19339
6079 Reviewed-on: https://code.wireshark.org/review/15244
6080 Reviewed-by: Michael Mann <mmann78@netscape.net>
6083 Author: Dario Lombardo <lomato@gmail.com>
6084 Date: Thu Apr 21 18:04:16 2016 +0200
6086 addr_resolv: change g_hash to wmem_map.
6088 Change-Id: Ice7533fbeac700dae0a46766838818a32b0d5736
6089 Reviewed-on: https://code.wireshark.org/review/15051
6090 Reviewed-by: Michael Mann <mmann78@netscape.net>
6093 Author: Dario Lombardo <lomato@gmail.com>
6094 Date: Tue Apr 12 18:14:14 2016 +0200
6096 dcm: remove g_malloc
6098 Change-Id: I3d00b710c6fc6e5798ecc5eca9af11ccac920e5a
6099 Reviewed-on: https://code.wireshark.org/review/14913
6100 Reviewed-by: Michael Mann <mmann78@netscape.net>
6103 Author: Dario Lombardo <lomato@gmail.com>
6104 Date: Mon May 2 17:50:38 2016 +0200
6106 tvbparse: change g_malloc to wmem_alloc.
6108 Change-Id: I6a6363400d9fd1d76b9de0c5deea83dfc7cea1e2
6109 Reviewed-on: https://code.wireshark.org/review/15245
6110 Petri-Dish: Michael Mann <mmann78@netscape.net>
6111 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6112 Reviewed-by: Michael Mann <mmann78@netscape.net>
6115 Author: Joerg Mayer <jmayer@loplof.de>
6116 Date: Tue Jun 14 21:12:16 2016 +0200
6118 Add Aerohive gre tunnel between APs.
6120 Change-Id: I24d0320cd164ead2802af37d07016c9c46d18e9e
6121 Reviewed-on: https://code.wireshark.org/review/15903
6122 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
6125 Author: Peter Wu <peter@lekensteyn.nl>
6126 Date: Sun Apr 3 11:10:02 2016 +0200
6128 wslua: remove FAIL_ON_NULL_MEMBER_OR_EXPIRED
6130 Ensure that the member cannot be NULL at initialization, simplifies
6131 checkCaptureInfo and checkCaptureInfoConst logic.
6133 Change-Id: I2d9caa4a235310569ebbf0b30199dd3df7a4c093
6134 Reviewed-on: https://code.wireshark.org/review/14791
6135 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6138 Author: Peter Wu <peter@lekensteyn.nl>
6139 Date: Sun Apr 3 10:58:44 2016 +0200
6141 wslua: Drop unused "push_code" macro parameter
6143 Reduce noise, no caller has used this parameter since its introduction.
6144 Msotly automated regex search and replace.
6146 Change-Id: I4b1180bfee8544b38d19c9c440ff5b9b0dc080b2
6147 Reviewed-on: https://code.wireshark.org/review/14790
6148 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
6149 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6150 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6153 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6154 Date: Fri Jun 3 17:56:54 2016 +0200
6156 Add dissector for Real Time Location System (RTLS)
6158 Change-Id: I494cbb8c3c6da18dfd7901d098dde6448226f67e
6159 Reviewed-on: https://code.wireshark.org/review/15711
6160 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6161 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6162 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6165 Author: Irene Ruengeler <ruengeler@wireshark.org>
6166 Date: Mon Jun 13 17:39:42 2016 +0200
6168 Fix SCTP analysis broken
6171 Change-Id: I3fdf79106ed007aadf528f0b373fb7a487f3d9a9
6172 Reviewed-on: https://code.wireshark.org/review/15870
6173 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6174 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6175 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6178 Author: Balint Reczey <balint@balintreczey.hu>
6179 Date: Tue Jun 23 13:51:32 2015 -0700
6181 gtk: Allow restoring maximized windows as maximized
6183 without losing window decorations on GNOME on the secondary monitor.
6186 Change-Id: Ie8f541dba9d49f9fe5d4892a8dc1cd42091afe1d
6187 Reviewed-on: https://code.wireshark.org/review/9077
6188 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
6189 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
6190 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
6191 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6194 Author: Binh Trinh <beango@gmail.com>
6195 Date: Tue Jun 14 00:37:53 2016 -0400
6197 Added XML proper decoding for XML CDATASection
6200 Change-Id: Iecf7ce4bfad45d0c49f3af205e8489e53077198b
6201 Reviewed-on: https://code.wireshark.org/review/15889
6202 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6203 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6204 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6205 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6208 Author: Anders Broman <a.broman58@gmail.com>
6209 Date: Tue Jun 14 15:37:33 2016 +0000
6211 Revert "Move inclusion of CmakeListsCustom to the end of the file in order to have all defines in place."
6213 This reverts commit bcbcad1e597f89e64389b6cc25b2fdbe9f89d960.
6215 This change breaks building of custom plugins.
6217 Change-Id: I63e88ceb922ca23ead9784705ad8ba088a504fd1
6218 Reviewed-on: https://code.wireshark.org/review/15893
6219 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6222 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6223 Date: Tue Jun 14 15:40:57 2016 +0200
6225 browser (dcerpc): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
6227 Change-Id: I158a5fd8a645cd4d58565a6a4ee64371d271eb8e
6228 Reviewed-on: https://code.wireshark.org/review/15892
6229 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6230 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
6233 Author: Balint Reczey <balint@balintreczey.hu>
6234 Date: Mon Jun 13 20:01:08 2016 -0700
6236 GTK: Disable liboverlay-scrollbar that crashed wireshark on Ubuntu
6239 Change-Id: I40d901ab3ef43a61ef984014dabc0547605ef77c
6240 Reviewed-on: https://code.wireshark.org/review/15888
6241 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6244 Author: Martin Kaiser <wireshark@kaiser.cx>
6245 Date: Mon Jun 13 15:50:33 2016 -0700
6247 mount: don't THROW() an exception from a dissector
6249 if the length is too large, we can simply skip nfs_name_snoop_add_name()
6250 and the code to prepare its input
6252 Change-Id: I30c9a89edf7b48c45b52e7dad099ac4151f7f4a7
6253 Reviewed-on: https://code.wireshark.org/review/15883
6254 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6257 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6258 Date: Mon Jun 13 19:51:29 2016 -0400
6260 Don't register Wireshark for .pfx (IPFIX) files.
6262 (As pointed out by Gerald) .pfx files are (more commonly) PKCS#12 files.
6263 People may be upset if we start grabbing them.
6265 Change-Id: Iecf857d082b7f2a0ad4fdd1a932332fc3c9d9498
6266 Reviewed-on: https://code.wireshark.org/review/15886
6267 Reviewed-by: Michael Mann <mmann78@netscape.net>
6268 Petri-Dish: Michael Mann <mmann78@netscape.net>
6269 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6270 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6273 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6274 Date: Mon Jun 13 20:14:41 2016 -0400
6276 Adjust the Diameter DTD to accept applications and vendors in any order.
6278 Change-Id: I301a138b7f6db2d1a9ce1a20ebecf94e100bf831
6279 Reviewed-on: https://code.wireshark.org/review/15887
6280 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
6283 Author: John A. Thacker <johnthacker@gmail.com>
6284 Date: Mon Jun 13 16:36:07 2016 -0400
6286 extcap: Check libssh >= 0.6.0 for sshdump, ciscodump
6288 sshdump and ciscodump require libssh >= 0.6.0. Check for this version and
6289 only build them if a sufficient version is present. (The other checks
6290 stay; in particular, ssh_userauth_agent doesn't exist on Windows and
6291 must be checked separately.)
6294 Change-Id: Ibe42b0cbb597cd9c4aab51f44d48185940ad954b
6295 Reviewed-on: https://code.wireshark.org/review/15882
6296 Petri-Dish: Michael Mann <mmann78@netscape.net>
6297 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6298 Reviewed-by: Dario Lombardo <lomato@gmail.com>
6299 Tested-by: Dario Lombardo <lomato@gmail.com>
6300 Reviewed-by: Michael Mann <mmann78@netscape.net>
6303 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6304 Date: Mon Jun 13 19:28:04 2016 -0400
6306 Fix Custom.xml so it can be (correctly) included into the main dictionary.
6308 This file is included into dictionary.xml so it doesn't need all the DOCTYPE
6311 Change-Id: I8397b3babe45c28706867be3169ce6ed566930e6
6312 Reviewed-on: https://code.wireshark.org/review/15885
6313 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
6316 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
6317 Date: Mon Jun 13 05:35:14 2016 +0100
6319 Add missing const to inet_ipv6.h
6321 Make it simpler too.
6323 Change-Id: I97dc79d7ac536089c1fa6ec2c20f19754d47a9d4
6324 Reviewed-on: https://code.wireshark.org/review/15866
6325 Petri-Dish: João Valverde <j@v6e.pt>
6326 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6327 Reviewed-by: João Valverde <j@v6e.pt>
6330 Author: Martin Kaiser <wireshark@kaiser.cx>
6331 Date: Sat Jun 11 13:56:33 2016 +0200
6333 dcerpc: don't THROW() an exception from a dissector
6335 remove the checks in dissect_ndr_ucarray_core() where a block or bytes
6336 dissection function is called and an exception is thrown if the offset
6337 wraps around, i.e. the final offset is lower than the initial one
6339 the block functions eventually call proto_tree_add_item(), which throws
6340 an exception if necessary
6342 the bytes functions end up calling functions to dissect basic types.
6343 insert calls to tvb_ensure_bytes_exist() if those functions increase our
6344 offset without reading data. thus, an exception is thrown if there's an
6347 remove some unnecessary if (tree) checks while at it
6349 Change-Id: I8006399ae20934daeec231246debe247f8dedbf0
6350 Reviewed-on: https://code.wireshark.org/review/15832
6351 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6354 Author: Michael Mann <mmann78@netscape.net>
6355 Date: Mon Jun 13 15:34:16 2016 -0400
6357 Add proto_tree_add_bitmask_list_value.
6359 Ran across enough situations that proto_tree_add_bitmask_list couldn't
6360 solve that it seemed necessary.
6362 Change-Id: I6a540ac6efca76cae7c4571a84bb400538652784
6363 Reviewed-on: https://code.wireshark.org/review/15880
6364 Reviewed-by: Michael Mann <mmann78@netscape.net>
6365 Petri-Dish: Michael Mann <mmann78@netscape.net>
6366 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6367 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6370 Author: Andreas Leibold <andreas.leibold@harman.com>
6371 Date: Fri Jun 10 10:41:19 2016 +0200
6373 Updates on AVB IEEE 1722 protocol to support more 1722 subtypes.
6375 packet-ieee1722.c now contains the entire protocol.
6376 packet-ieee1722a.c file was removed, because the term 1722a is outdated
6377 and now part of 1722 protocol.
6379 Change-Id: Ic2f44a2752f9254cde62d878dc971f09cddc5adc
6380 Reviewed-on: https://code.wireshark.org/review/15810
6381 Petri-Dish: Anders Broman <a.broman58@gmail.com>
6382 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6383 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6384 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6387 Author: Martin Kaiser <wireshark@kaiser.cx>
6388 Date: Sun Jun 12 16:31:57 2016 -0700
6390 use #include <file.h> for generated include files
6392 the same mechanism as described in
6393 7c40de5c38ac71323455c51dcc14a5eb385ce718
6394 could trick us into using the wrong config.h
6396 fix this for some occassions where config.h is included before we
6399 I saw compile errors on windows where we picked up config.h from a linux
6400 build and zlib failed because of a mission unistd.h
6402 Change-Id: I91cf73b96c9e1b6f009fb2376fabfe973d1ac941
6403 Reviewed-on: https://code.wireshark.org/review/15874
6404 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6405 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6406 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6409 Author: Martin Kaiser <wireshark@kaiser.cx>
6410 Date: Sun Jun 12 14:00:21 2016 -0700
6412 qt: use #include <file.h> for generated include files
6414 make sure that generated include files are picked up only from the
6415 directories set by -I (or /I), not from the current directory
6417 if we use #include "file.h", Visual Studio searches for file.h in the
6418 same diretory as the source file that includes file.h
6420 if we do an out-of-tree build with cmake and the source directory
6421 contains files from an in-tree build (done with autotools), we might end
6422 up including the wrong file
6424 Change-Id: Iaaed2626258b6ff0c12485fe3f436bd03bbb5adf
6425 Reviewed-on: https://code.wireshark.org/review/15873
6426 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6429 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
6430 Date: Sat Jun 11 23:15:01 2016 +0100
6432 IPv6: Add text marker for SRH next segment
6434 Change-Id: If13ffe4ddb9ae08e738ccf0c715dc12ce7a076e8
6435 Reviewed-on: https://code.wireshark.org/review/15834
6436 Petri-Dish: Anders Broman <a.broman58@gmail.com>
6437 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6438 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6441 Author: Martin Kaiser <wireshark@kaiser.cx>
6442 Date: Mon Jun 13 11:36:10 2016 -0700
6444 sip: remove some unnecessary if (tree) checks
6446 which shouldn't have any impact on performance
6448 we should not remove the chcks around blocks where
6449 vb_format_text() is called
6451 Change-Id: Idc191cc70e7458225bbc5dfececb3c88c83ab5f1
6452 Reviewed-on: https://code.wireshark.org/review/15879
6453 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6456 Author: AndersBroman <anders.broman@ericsson.com>
6457 Date: Mon Jun 13 20:51:48 2016 +0200
6459 Move inclusion of CmakeListsCustom to the end of the file in order to have
6460 all defines in place.
6462 Change-Id: I190257e9b833c409921bbca74c8ab531b632c60d
6463 Reviewed-on: https://code.wireshark.org/review/15878
6464 Petri-Dish: Anders Broman <a.broman58@gmail.com>
6465 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6466 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6469 Author: Martin Kaiser <wireshark@kaiser.cx>
6470 Date: Mon Jun 13 09:30:30 2016 -0700
6474 do the special handling for len==0 and tag==ISNS_ATTR_TAG_PORTAL_GROUP_TAG
6475 before going into the different attributes
6478 Change-Id: I4dd6dcea25aba2e4963811a7a85f1eed1b906bcd
6479 Reviewed-on: https://code.wireshark.org/review/15875
6480 Reviewed-by: Michael Mann <mmann78@netscape.net>
6481 Petri-Dish: Michael Mann <mmann78@netscape.net>
6482 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6483 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6486 Author: Dario Lombardo <lomato@gmail.com>
6487 Date: Tue May 3 16:51:45 2016 +0200
6489 tvbparse: change g_strdup_printf to wmem_strdup_printf.
6491 Change-Id: I57ff604d23967eb1f6481c7019e3eab0389dc3a5
6492 Reviewed-on: https://code.wireshark.org/review/15257
6493 Petri-Dish: Dario Lombardo <lomato@gmail.com>
6494 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6495 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6496 Reviewed-by: Dario Lombardo <lomato@gmail.com>
6499 Author: Gerald Combs <gerald@wireshark.org>
6500 Date: Mon Jun 13 11:17:48 2016 -0700
6502 Qt: Fix a Windows version check.
6504 Fetch the version using QSysInfo::windowsVersion.
6507 Change-Id: If63c576ec4f56f34b76f320cdd927bee427c8cb7
6508 Reviewed-on: https://code.wireshark.org/review/15876
6509 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6510 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6511 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6514 Author: Gerald Combs <gerald@wireshark.org>
6515 Date: Sun Jun 12 16:07:30 2016 -0700
6517 Qt: Main window tab behavior.
6519 Make the main window tab order more closely match the GTK+ UI. Draw a
6520 focus rect in the byte view text while we're here.
6522 Change-Id: I04212c14ea7f0d6865b709533246760adc02f45a
6523 Reviewed-on: https://code.wireshark.org/review/15862
6524 Petri-Dish: Anders Broman <a.broman58@gmail.com>
6525 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6526 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6527 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6530 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6531 Date: Mon Jun 13 14:29:22 2016 -0400
6533 Cisco Diameter: move the XML declaration to the top of the file.
6535 ... That's where it's supposed to be.
6537 Change-Id: I0ec68dc8757776bf757b52e75bc156acc7264ee5
6538 Reviewed-on: https://code.wireshark.org/review/15877
6539 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
6542 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6543 Date: Mon Jun 13 13:52:19 2016 -0400
6545 Diameter (NSN): the attribute name is 'mandatory' not 'mandatory-flag'.
6547 Change-Id: Ifa19b59e23278abf332d8ab06dd5ad2059f3e679
6548 Reviewed-on: https://code.wireshark.org/review/15872
6549 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
6552 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6553 Date: Mon Jun 13 13:37:08 2016 -0400
6555 Diameter: close command elements.
6557 ... in order to make the XML (more) valid.
6559 Change-Id: Iefffff3208c98d6ea55d509ed35b57abd268baf3
6560 Reviewed-on: https://code.wireshark.org/review/15871
6561 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
6564 Author: Michael Mann <mmann78@netscape.net>
6565 Date: Sun Jun 12 12:28:02 2016 -0400
6567 Convert AT_SS7PC to a "dissector address type"
6569 The formatting of the address type is determined by a preference in
6570 packet-mtp3.c, so just make MTP3 register the address type.
6571 Use address_type_get_by_name in other dissectors (and export_pdu)
6572 to use the address type.
6574 Change-Id: Ifb32d7de27aeaa23cee8e803e25ffb3c905547b5
6575 Reviewed-on: https://code.wireshark.org/review/15856
6576 Petri-Dish: Michael Mann <mmann78@netscape.net>
6577 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6578 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6581 Author: Gerald Combs <gerald@wireshark.org>
6582 Date: Fri Mar 18 13:13:44 2016 -0700
6584 Use getc_unlocked in a few places.
6586 Use getc_unlocked or _fgetc_nolock instead of getc in a few places. This
6587 reduces startup time by about 100ms here.
6589 Change-Id: I59ceb09678457c871cce79fcc3ce71998fe4f5af
6590 Reviewed-on: https://code.wireshark.org/review/14518
6591 Reviewed-by: Michael Mann <mmann78@netscape.net>
6592 Petri-Dish: Michael Mann <mmann78@netscape.net>
6593 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6594 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6597 Author: Anton Thomasson <anton.thomasson@ericsson.com>
6598 Date: Fri Jun 10 16:12:24 2016 +0200
6600 GSM RLC/MAC: add dissection of EC-GSM-IoT control messages
6602 Change-Id: Ib7096039aa9761fda96ed8552899833597ba70a6
6603 Reviewed-on: https://code.wireshark.org/review/15812
6604 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6607 Author: Anton Thomasson <anton.thomasson@ericsson.com>
6608 Date: Fri Jun 10 16:13:44 2016 +0200
6610 GSM RR: add dissection of EC-GSM-IoT ccch control messages
6612 Change-Id: Ib40f78a0d1822bf216af0911f9672c750a78b265
6613 Reviewed-on: https://code.wireshark.org/review/15813
6614 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6617 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6618 Date: Sun Jun 12 19:00:37 2016 -0400
6620 Diameter: free the diameter directory variable.
6622 It's only needed for a few milliseconds--there's no need for it to stick around
6623 until the epan scope ends.
6625 As discussed on I51813815babb4c40722c38459139ab9e3e3ccb42.
6627 Change-Id: I81fef351ef2d700cc5ec5866340605704173fbdb
6628 Reviewed-on: https://code.wireshark.org/review/15861
6629 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
6630 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6631 Reviewed-by: Michael Mann <mmann78@netscape.net>
6634 Author: Gerald Combs <gerald@wireshark.org>
6635 Date: Sun Jun 12 15:10:02 2016 -0700
6637 Qt: Make the capture filter read-only only in main welcome.
6639 As noted in gb7897dd, CaptureFilterCombo needs to be read-only until the
6640 app is initialized. Move the code to do so to MainWelcome, otherwise the
6641 capture filter entry in CaptureInterfacesDialog starts out read-only and
6642 stays that way. Disable / enable the entire CaptureFilterCombo instead
6643 of setting its lineEdit read-only status, which provides a stronger
6646 Change-Id: Ic7bf5b5631b861ecf4dc8cca67beb5bf4ed27510
6647 Reviewed-on: https://code.wireshark.org/review/15859
6648 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6649 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6650 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6651 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6652 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6655 Author: Gerald Combs <gerald@wireshark.org>
6656 Date: Fri Jun 10 09:57:17 2016 -0700
6658 Qt: Add the Info column contents to Expert Info.
6660 When "group by summary" is enabled, packet items contain a packet number
6661 followed by a lot of empty space. Fill it with the contents of the Info
6664 Set the first column title to "Severity" or "Packet" depending on the
6667 Change-Id: Iff96ab2ec631300ec8f08e55019e191e88cff84a
6668 Reviewed-on: https://code.wireshark.org/review/15814
6669 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6670 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6671 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6672 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6675 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
6676 Date: Wed Apr 27 15:07:03 2016 +0100
6678 Indent register.c and other cosmetic changes
6680 Change-Id: I06e863e0b87118047f4c3b7618df02b9c7384a34
6681 Reviewed-on: https://code.wireshark.org/review/15836
6682 Petri-Dish: Anders Broman <a.broman58@gmail.com>
6683 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6684 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6687 Author: Binh Trinh <beango@gmail.com>
6688 Date: Sun Jun 12 14:21:12 2016 -0400
6690 Added Diameter 3GPP decoding of AVP 1404 - QoS-Subscribed
6692 (removed C++ style comments)
6694 Change-Id: I0f6c7586486b48eab8659a048be451ce3fe1c72b
6695 Reviewed-on: https://code.wireshark.org/review/15850
6696 Petri-Dish: Anders Broman <a.broman58@gmail.com>
6697 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6698 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6701 Author: Stig Bjørlykke <stig@bjorlykke.org>
6702 Date: Mon Jun 13 10:00:28 2016 +0200
6704 Qt: Multi line import from hex dump without offsets
6706 Fix importing hex dump without offsets with multiple lines.
6708 Change-Id: I7a7339e375b3125688f5b5d29f493704c7b9944a
6709 Reviewed-on: https://code.wireshark.org/review/15868
6710 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
6713 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6714 Date: Sat Jun 11 06:14:35 2016 +0200
6716 RADIUS: Add Sangoma dictionary
6718 From FreeRADIUS master
6720 commit ba4b4402588ae87497a0b7c87e26eb5cb433c8a7
6721 Author: Alan T. DeKok <aland@freeradius.org>
6722 Date: Fri Jun 10 14:38:55 2016 -0400
6724 Added dictionary.sangoma
6726 from http://wiki.sangoma.com/files/NSC-Radius-Support/dictionary.sangoma.txt
6728 Change-Id: Ie51ea6343a2a8a5b286d70451abce81ca920261f
6729 Reviewed-on: https://code.wireshark.org/review/15823
6730 Petri-Dish: Michael Mann <mmann78@netscape.net>
6731 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6732 Reviewed-by: Michael Mann <mmann78@netscape.net>
6735 Author: Michael Mann <mmann78@netscape.net>
6736 Date: Sun Jun 12 11:12:15 2016 -0400
6738 Add address_type_get_by_name
6740 This allows the decoupling of a dissector registering an address type
6741 so it doesn't need to export the returned registered type.
6743 Change-Id: I49c913d042e70bd4b7ea1e964ba9511bb27304f5
6744 Reviewed-on: https://code.wireshark.org/review/15855
6745 Petri-Dish: Michael Mann <mmann78@netscape.net>
6746 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6747 Reviewed-by: Michael Mann <mmann78@netscape.net>
6750 Author: Michael Mann <mmann78@netscape.net>
6751 Date: Sun Jun 12 09:38:55 2016 -0400
6753 Completely remove dissector_add_handle.
6755 It has been deprecated and replaced with dissector_add_for_decode_as.
6757 Change-Id: I5a4976f83951f749e70b5267570fca188daa7a07
6758 Reviewed-on: https://code.wireshark.org/review/15854
6759 Petri-Dish: Michael Mann <mmann78@netscape.net>
6760 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6761 Reviewed-by: Michael Mann <mmann78@netscape.net>
6764 Author: Pascal Quantin <pascal.quantin@gmail.com>
6765 Date: Sun Jun 12 14:50:04 2016 -0700
6767 USB: fix dissection of URB setup when the payload was claimed by a sub dissector
6770 Change-Id: Ic9af8358e2a8110f53c587201cafc337630c302a
6771 Reviewed-on: https://code.wireshark.org/review/15858
6772 Reviewed-by: Michael Mann <mmann78@netscape.net>
6773 Petri-Dish: Michael Mann <mmann78@netscape.net>
6774 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
6775 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6776 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6779 Author: Pascal Quantin <pascal.quantin@gmail.com>
6780 Date: Sun Jun 12 14:49:04 2016 -0700
6782 USB HID: add dissector to USB Device 'Decode As' list
6785 Change-Id: I6193e3bb084adf9925bb6800a756804164030630
6786 Reviewed-on: https://code.wireshark.org/review/15857
6787 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6790 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
6791 Date: Mon Jun 13 03:49:37 2016 +0100
6795 Change-Id: Ie5d859e166fbc8073be88cbbd96bffa877e6b654
6796 Reviewed-on: https://code.wireshark.org/review/15865
6797 Reviewed-by: João Valverde <j@v6e.pt>
6800 Author: Guy Harris <guy@alum.mit.edu>
6801 Date: Sun Jun 12 19:15:40 2016 -0700
6803 Finish moving the parenthesis.
6805 Change-Id: I02f099ef198e360663b03857bdf9538bb63a7de8
6806 Reviewed-on: https://code.wireshark.org/review/15864
6807 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6810 Author: Guy Harris <guy@alum.mit.edu>
6811 Date: Sun Jun 12 18:45:45 2016 -0700
6813 Fix a compile error.
6815 (Perhaps the Petri dish buildbots should, if a build fails, immediately
6816 mark the change as failing the Petri dish build, without waiting for the
6817 other build(s), so that you don't have to, for example, wait for the
6818 Ubuntu buildbot to finish doing a test build for a change that doesn't
6819 affect code built on UN*X.)
6821 Change-Id: I89ee1616d35c186fcabc0ec989936fa94116df70
6822 Reviewed-on: https://code.wireshark.org/review/15863
6823 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6826 Author: Guy Harris <guy@alum.mit.edu>
6827 Date: Sun Jun 12 15:30:35 2016 -0700
6829 Don't assume we can get a module handle for kernel32.dll.
6831 A failure "shouldn't happen", but check anyway; if nothing else, that
6832 squelches some complaining from the VS Code Analysis tool.
6834 Change-Id: I9b06db399741176d0e9f859eb650bed8a2f96d9c
6835 Reviewed-on: https://code.wireshark.org/review/15860
6836 Petri-Dish: Guy Harris <guy@alum.mit.edu>
6837 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6840 Author: Stig Bjørlykke <stig@bjorlykke.org>
6841 Date: Sun Jun 5 21:06:51 2016 +0200
6843 Qt: Add import from hex dump without offsets
6845 Added support for importing from hex dump without offsets.
6846 This will create one packet with all hex values found in the file.
6848 Change-Id: I0414441721078befeb59aa6a87b9412646cfcf5c
6849 Reviewed-on: https://code.wireshark.org/review/15743
6850 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
6851 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6852 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6855 Author: Léo Gaspard <leo@gaspard.io>
6856 Date: Sun Jun 12 22:35:16 2016 +0200
6858 Fix typo in dissector doc
6860 Change-Id: I5ca20080f99905ab23d484d0be054a89c406c583
6861 Reviewed-on: https://code.wireshark.org/review/15852
6862 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6865 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6866 Date: Sun Jun 12 18:46:46 2016 +0200
6868 expert_info_dialog (Qt): fix Uninitialized members (UNINIT_CTOR) reported by Coverity (CID 1362692)
6870 Change-Id: I1bc71ac7b9c08a9a5749aa9bc88863fa10eb27c7
6871 Reviewed-on: https://code.wireshark.org/review/15848
6872 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6873 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6874 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
6877 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
6878 Date: Sat Jun 11 18:09:05 2016 +0100
6880 IPv6: Add dissection for SRH flags
6882 Change-Id: I535aba36cc906e8d78cb594900e9a7fdcbd26c83
6883 Reviewed-on: https://code.wireshark.org/review/15828
6884 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6885 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6886 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6887 Reviewed-by: João Valverde <j@v6e.pt>
6890 Author: Thibault Gerondal <github@tycale.be>
6891 Date: Sat May 28 02:55:04 2016 +0200
6893 IPv6: Add support for Segment Routing (Type 4) Extension Header
6896 Change-Id: I5672ff3b8c4e8afcc82e957933330e0bf9454b08
6897 Reviewed-on: https://code.wireshark.org/review/15593
6898 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6899 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6900 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6901 Reviewed-by: João Valverde <j@v6e.pt>
6904 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
6905 Date: Sat Jun 11 06:10:17 2016 +0100
6907 CMake: Make PROJECT_VERSION_EXTENSION code simpler
6909 The intent was to allow all sorts of overrides but, ugly.
6911 I don't think we need $cmake_package_string either, at least with
6914 Follow-up to 7c6e859ccf210a45e1cc0f6da17692845e6b5a23.
6916 (And bdec712166ba924a2cdeaaca8ae580c343eaf02c).
6918 Change-Id: I808b6bd3a3c64d2a67165344e8fe23e8314c27db
6919 Reviewed-on: https://code.wireshark.org/review/15835
6920 Reviewed-by: João Valverde <j@v6e.pt>
6923 Author: Guy Harris <guy@alum.mit.edu>
6924 Date: Sun Jun 12 12:18:14 2016 -0700
6926 Have MemoryCheck() directly incorporate the error message and exit.
6928 Manually inline memory_error() in MemoryCheck(), so that static
6929 analyzers know that, if MemoryCheck() sees a null pointer, it exists,
6930 and the null pointer isn't subsequently used.
6932 Use MemoryCheck() instead of the one place where we manually checked for
6933 a null pointer and called memory_error().
6935 Change-Id: Id6b0328cfd17cb14ec9d1e461420896a31573c71
6936 Reviewed-on: https://code.wireshark.org/review/15851
6937 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6940 Author: Guy Harris <guy@alum.mit.edu>
6941 Date: Sun Jun 12 10:34:16 2016 -0700
6943 Add more memory checks, and use MemoryCheck() for some existing checks.
6945 Always check for malloc() and realloc() failing. Use MemoryCheck() for
6946 most of the checks - it's a bit cleaner and makes the error message the
6947 same for those checks.
6949 Change-Id: I533153c697b37b85adfa0259c1352efece0b0486
6950 Reviewed-on: https://code.wireshark.org/review/15849
6951 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6954 Author: Gerald Combs <gerald@wireshark.org>
6955 Date: Fri Jun 10 11:16:10 2016 -0700
6957 Qt: Draw a border around inactive+selected packet list items.
6959 Try to make inactive+selected packet list items more visible by drawing
6960 a border around them. Make an exception for Windows 7 and Vista if a
6964 Change-Id: I974069dda92588b80772f577f319569751ff3347
6965 Reviewed-on: https://code.wireshark.org/review/15816
6966 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6967 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6968 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6971 Author: Gerald Combs <gerald@wireshark.org>
6972 Date: Sun Jun 12 08:11:17 2016 -0700
6974 [Automatic update for 2016-06-12]
6976 Update manuf, services enterprise-numbers, translations, and other items.
6978 Change-Id: I14deff6b9a13a51d66ebdea361686822583b07c0
6979 Reviewed-on: https://code.wireshark.org/review/15843
6980 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6983 Author: Martin Kaiser <wireshark@kaiser.cx>
6984 Date: Sat Jun 11 14:23:59 2016 +0200
6986 mongo: don't THROW() an exception from a dissector
6988 just return the overall length even if the value is not in line with the
6989 protocol specification
6991 Change-Id: Ieeb5d1d265acb6de807a1175f07c7981db4b6c2b
6992 Reviewed-on: https://code.wireshark.org/review/15833
6993 Reviewed-by: Michael Mann <mmann78@netscape.net>
6994 Petri-Dish: Michael Mann <mmann78@netscape.net>
6995 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6996 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6999 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
7000 Date: Sat Jun 11 14:21:17 2016 +0200
7002 Actually progress through the command data (CID-281394)
7004 The loop reading through the command data doesn't progress through
7005 it, it just reads until the available data (represented by max_length)
7006 runs out. It therefore:
7007 - doesn't present the commands
7008 - doesn't detect a missing final marker bit (CID-281394)
7009 This change does make the code progress through the command data,
7010 fixing both issues in the process.
7012 Change-Id: I61ba8b56b4a153affe9b4f9a574267f981ef0594
7013 Reviewed-on: https://code.wireshark.org/review/15825
7014 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
7015 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7016 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7019 Author: Balint Reczey <balint@balintreczey.hu>
7020 Date: Fri Apr 29 10:21:44 2016 +0200
7022 debian: Regenerate ASN.1 dissector code during package build
7024 Change-Id: I3f7378ae5c048d3f954238bd04c707f039401ea1
7025 Reviewed-on: https://code.wireshark.org/review/15161
7026 Petri-Dish: Balint Reczey <balint@balintreczey.hu>
7027 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7028 Reviewed-by: Michael Mann <mmann78@netscape.net>
7031 Author: Michael Mann <mmann78@netscape.net>
7032 Date: Fri Jun 10 00:00:39 2016 -0400
7034 Move Gateway Control Protocol (Context Tracking) into packet-h248.h
7036 The Gateway Control Protocol (Context Tracking) is used by both H248
7037 and MEGACO, so the functionality was refactored to epan, but should
7038 really be kept in the dissector directory to minimize (and eventually
7039 completely remove) the epan directory's dependence on it.
7041 Change-Id: I387b46aecde97234086bfdb7d8c546854fa301cd
7042 Reviewed-on: https://code.wireshark.org/review/15798
7043 Petri-Dish: Michael Mann <mmann78@netscape.net>
7044 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7045 Reviewed-by: Michael Mann <mmann78@netscape.net>
7048 Author: Michael Vigovsky <upliner@gmail.com>
7049 Date: Fri Jun 10 15:17:49 2016 +0300
7051 Add missing scale in TDS type info
7053 Change-Id: I6734fe448e4ee6f20a0d57b1aaae5e7e61f0cb5c
7054 Reviewed-on: https://code.wireshark.org/review/15811
7055 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
7056 Reviewed-by: Michael Mann <mmann78@netscape.net>
7059 Author: Guy Harris <guy@alum.mit.edu>
7060 Date: Sat Jun 11 19:13:14 2016 -0700
7062 Handle zero-length addresses in cmp_address().
7064 Don't compare the data if there's none to compare.
7066 Change-Id: Ib0e3541e448127869d19afddfc71bb441dba5874
7067 Reviewed-on: https://code.wireshark.org/review/15840
7068 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7071 Author: Guy Harris <guy@alum.mit.edu>
7072 Date: Sat Jun 11 18:59:25 2016 -0700
7074 Add checks to address setting routines.
7078 1) you have an AT_NONE address with data;
7080 2) you have a non-AT_NONE address with a zero length and a
7081 non-null data pointer, or with a non-zero length and a null
7084 When comparing addresses for equality, just make sure the types are the
7085 same, the lengths are the same and, if the lengths are non-zero, the
7086 data is the same; don't treat AT_NONE specially - the "lengths are
7087 non-zero" check will make sure we do the right thing.
7089 Make sure when we create an AT_NONE address it has a zero length and
7092 Change-Id: I5c452ef0d140c2d9aef3004f1cfd124a95b78fb2
7093 Reviewed-on: https://code.wireshark.org/review/15839
7094 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7097 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
7098 Date: Sat Jun 11 14:49:59 2016 +0200
7100 Store the tree item to add to later (CID-1159152)
7102 The tree item needed to test and append to isn't being stored,
7103 so the items are never amended with notes, resulting in dead code.
7105 Change-Id: Ib1a9b7994ad12a9a9013d1bc1e1e4c165f34f20f
7106 Reviewed-on: https://code.wireshark.org/review/15826
7107 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
7108 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7109 Reviewed-by: Michael Mann <mmann78@netscape.net>
7112 Author: Michael Mann <mmann78@netscape.net>
7113 Date: Thu Jun 9 11:02:33 2016 -0400
7115 H225: Replace globals that track packet data with p_add_proto_data/p_get_proto_data.
7117 Change-Id: I0380151fb0f45063b81bc55dd5b8dc4add99ad30
7118 Reviewed-on: https://code.wireshark.org/review/15794
7119 Petri-Dish: Michael Mann <mmann78@netscape.net>
7120 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7121 Reviewed-by: Michael Mann <mmann78@netscape.net>
7124 Author: Guy Harris <guy@alum.mit.edu>
7125 Date: Sat Jun 11 13:28:29 2016 -0700
7129 Change-Id: Ifda0499e00dfa38c936f7e054ab4d5b3a0fd627f
7130 Reviewed-on: https://code.wireshark.org/review/15830
7131 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7134 Author: Vincent Helfre <vincenthelfre@googlemail.com>
7135 Date: Thu Jun 9 17:47:20 2016 +0200
7137 GSM RLC/MAC: improve dissection of Packet Resource Request message
7139 Change-Id: I8513ef550e81a97e1a8ac1c1f365355118d5ebae
7140 Reviewed-on: https://code.wireshark.org/review/15827
7141 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
7142 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7143 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
7146 Author: Martin Kaiser <wireshark@kaiser.cx>
7147 Date: Sun May 29 16:35:22 2016 +0200
7149 dcerpc-browser: don't THROW() an exception from a dissector
7151 the condition for THROW() will never be true
7153 there's no way to decrement offset below its initial value
7154 the dissect_browser_TYPE_x_data() functions read a uint32 and increment
7155 offset by 4 + the uint32 value that was read
7157 Change-Id: Ia5a63e714ffa0add601960d858452152e4d9b10b
7158 Reviewed-on: https://code.wireshark.org/review/15627
7159 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
7160 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7161 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
7162 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7165 Author: Martin Kaiser <wireshark@kaiser.cx>
7166 Date: Fri Jun 3 20:11:56 2016 +0200
7168 iso14443: dissect attrib's p3 byte
7170 Change-Id: Iec3595a9ee0f7037af1f949804f1022f315d1edc
7171 Reviewed-on: https://code.wireshark.org/review/15824
7172 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
7175 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
7176 Date: Fri Jun 10 19:30:36 2016 +0100
7178 ftype-protocol: Fix [-Wcast-qual] warnings
7180 Change-Id: Ia8a02d8dc66aead486c8ae3f0bdf4cd82717ed20
7181 Reviewed-on: https://code.wireshark.org/review/15817
7182 Petri-Dish: João Valverde <j@v6e.pt>
7183 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7184 Reviewed-by: Michael Mann <mmann78@netscape.net>
7187 Author: Guy Harris <guy@alum.mit.edu>
7188 Date: Fri Jun 10 15:05:23 2016 -0700
7190 More comment clarification.
7192 That's not "the biggest record we're willing to write", it's "the
7193 biggest record the pcapng format supports, as the record length is a
7196 Change-Id: Icbd5e0cc4ed8e2a3a0d474245a9b9ed2c999d520
7197 Reviewed-on: https://code.wireshark.org/review/15818
7198 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7199 (cherry picked from commit 09de28933f9a17d4472206e1ac4b7c92001e44f5)
7200 Reviewed-on: https://code.wireshark.org/review/15820
7203 Author: Guy Harris <guy@alum.mit.edu>
7204 Date: Fri Jun 10 11:02:07 2016 -0700
7206 Make the IPv4 NRB code's comments match the IPv6 NRB code's comments.
7208 The IPv6 comments gave more details.
7210 Change-Id: I4e4d865feadbabfd625cdf2b2b162b99c4f23efa
7211 Reviewed-on: https://code.wireshark.org/review/15815
7212 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7215 Author: Gerald Combs <gerald@wireshark.org>
7216 Date: Thu Jan 14 11:15:46 2016 -0800
7218 Qt: Expert info grouping.
7220 Add the ability to group expert info items by summary and enable it by
7221 default. This more closely matches the GTK+ UI behavior.
7223 Show matching item counts while we're here.
7226 Change-Id: Ic02267da8435fb70015de8dd15e0ac46faabbee9
7227 Reviewed-on: https://code.wireshark.org/review/15796
7228 Petri-Dish: Gerald Combs <gerald@wireshark.org>
7229 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7230 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7233 Author: Michal Labedzki <michal.labedzki@tieto.com>
7234 Date: Tue May 19 11:55:01 2015 +0200
7236 Qt/Bluetooth: Add Device dialog
7238 Device dialog appears when user double clicks on device in
7239 Devices dialog (Bluetooth->Devices). It provides
7240 summary of device, like BD_ADDR, name, timeouts, etc.
7241 Base on information from HCI layer, so this feature is more interesting
7242 for local devices (capturing on its side). Each field has changes counter,
7243 what mean that value at specified field changes in time, for example:
7244 user change device name 3 times. Please note that initial change
7245 is not counted. It means that you can see fielkd without any value
7246 then change occur and counter is not increased. It will be increased
7247 next time. Reason for that is in most cases field value is unknown
7250 Change-Id: Ife0a6bd454eac00a28f8eb2906e1b395695b0307
7251 Reviewed-on: https://code.wireshark.org/review/15793
7252 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
7253 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7254 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
7255 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
7258 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7259 Date: Fri Jun 10 08:42:41 2016 +0200
7261 Bluetooth HCI (Qt): Remove Q_UNUSED
7263 See g21754f43e for detail
7265 There is always some other Q_UNUSED but include on #if/#endif...
7267 Change-Id: Ib2283660c91787acbf6392841faa3db6aed39438
7268 Reviewed-on: https://code.wireshark.org/review/15803
7269 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
7270 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7271 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
7274 Author: Guy Harris <guy@alum.mit.edu>
7275 Date: Fri Jun 10 00:40:18 2016 -0700
7277 Always count packets per encapsulation.
7279 Currently, for pcapng files, if all of the IDBs we've seen *so far* are
7280 the same, we report it as the file's encapsulation type; however, we may
7281 see IDBs of a different type in the future, so don't check for
7282 per-packet encapsulation before counting packets of the encapsulation
7285 Change-Id: I617ddcf2963aa16e7ba58855b3e5bf326ab7dc32
7286 Reviewed-on: https://code.wireshark.org/review/15808
7287 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7290 Author: Guy Harris <guy@alum.mit.edu>
7291 Date: Fri Jun 10 00:31:36 2016 -0700
7293 Set the size of the packet counts array when we create it.
7295 g_array_sized_new() sets the amount of *space allocated for* the array,
7296 but doesn't actually set its *length*.
7298 Change-Id: Ia7deab34c758c88910dfb0e246a6903301e68029
7299 Reviewed-on: https://code.wireshark.org/review/15806
7300 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7303 Author: Guy Harris <guy@alum.mit.edu>
7304 Date: Thu Jun 9 23:59:34 2016 -0700
7306 Set cf_info.num_interfaces before using it.
7308 Change-Id: I6ba5932f339ea6296dd91a6800721b11bcd4956a
7309 Reviewed-on: https://code.wireshark.org/review/15804
7310 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7313 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7314 Date: Fri Jun 10 07:04:44 2016 +0200
7316 LANforge: fix wrong offset for magic detection
7318 Issue reported by Brent Lovelace https://www.wireshark.org/lists/wireshark-dev/201606/msg00034.html
7320 Change-Id: If296f01747316ddbe28e88d4d11d9df90d68bc5d
7321 Reviewed-on: https://code.wireshark.org/review/15800
7322 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
7323 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
7324 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7325 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7328 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
7329 Date: Thu Jun 9 23:51:04 2016 +0200
7331 Remove superfluous length check (CID-1158783)
7333 When entering a loop with check for minimum length, don't stick
7334 to the pattern of checking length first thing.
7336 Change-Id: I28c414108efa5499dbacd8527b2c3e654e49e808
7337 Reviewed-on: https://code.wireshark.org/review/15795
7338 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7341 Author: Guy Harris <guy@alum.mit.edu>
7342 Date: Thu Jun 9 20:32:35 2016 -0700
7344 Don't assume all IDBs are available aftre we open the file.
7346 IDBs can occur anywhere in the file, so if we see an interface ID bigger
7347 than the number of IDBs we've see, re-fetch the interface information,
7348 update the IDB count, and grow the packet count array as necessary.
7350 Get the information strings for interfaces after reading the entire
7351 file; we don't need them until then.
7353 Change-Id: Ib6096e481e321de485710d14eadf7b5232bf0be7
7354 Reviewed-on: https://code.wireshark.org/review/15797
7355 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7358 Author: Jaap Keuter <jaap.keuter@xs4all.nl>
7359 Date: Thu Jun 9 08:04:04 2016 +0200
7361 Make the determination if file is relative. (CID-1348040)
7363 The code tries to show a file handle when the file is relative
7364 to it, but doesn't actually make that determination. Extract the
7365 relevant bit and use that to flag the relative file.
7367 Change-Id: I7259c8843dc388b9dda96a73399a6da5575d3f5e
7368 Reviewed-on: https://code.wireshark.org/review/15789
7369 Petri-Dish: Anders Broman <a.broman58@gmail.com>
7370 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7371 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7374 Author: Michael Mann <mmann78@netscape.net>
7375 Date: Wed Jun 8 23:28:07 2016 -0400
7377 MGCP: Replace globals that track packet data with passing data to functions.
7379 Change-Id: I9595abf882adb821fd3c08532afba1b7e20412fe
7380 Reviewed-on: https://code.wireshark.org/review/15788
7381 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7382 Petri-Dish: Anders Broman <a.broman58@gmail.com>
7383 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7384 Reviewed-by: Michael Mann <mmann78@netscape.net>
7387 Author: Michal Labedzki <michal.labedzki@tieto.com>
7388 Date: Tue May 3 22:50:26 2016 +0200
7390 Qt/Bluetooth: Set missing HCI Summary Occurence fields
7392 Set they to zeros at startup like other fields.
7394 Change-Id: I820e7a0ce8fad5726448cb83f85235ecf578d77d
7395 Reviewed-on: https://code.wireshark.org/review/15792
7396 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
7397 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7398 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
7399 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
7402 Author: Michal Labedzki <michal.labedzki@tieto.com>
7403 Date: Wed Jun 8 17:18:45 2016 +0200
7405 Bluetooth: ATT: Fix Object List Control Point response
7411 Change-Id: Ia6c95c8f31a19b5e8fc21182658147ed4208d635
7412 Reviewed-on: https://code.wireshark.org/review/15790
7413 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
7414 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7415 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
7418 Author: Michal Labedzki <michal.labedzki@tieto.com>
7419 Date: Sun May 29 11:10:24 2016 +0200
7421 Logcat: Unicodize texts
7423 Text over Logcat is in real in Unicode.
7424 ASCII does not display it correctly.
7426 Change-Id: I998dad1ee50c4b00b874a1f197f6e465fadd3e38
7427 Reviewed-on: https://code.wireshark.org/review/15791
7428 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
7429 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7430 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
7433 Author: Pascal Quantin <pascal.quantin@gmail.com>
7434 Date: Wed Jun 8 22:26:02 2016 +0200
7436 Update Developer's Guide to reflect dissector_t signature change
7438 Change-Id: Ia793d94c7e79e49d1f27ad8adbdbafdb30131abe
7439 Reviewed-on: https://code.wireshark.org/review/15783
7440 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
7443 Author: Guy Harris <guy@alum.mit.edu>
7444 Date: Wed Jun 8 18:12:48 2016 -0700
7446 Use the locale's decimal separator for times as seconds and fraction.
7448 We use it when printing *other* seconds-and-fraction values, as we're
7449 just using %f, so we should use it consistently. If you don't want
7450 commas as decimal separators, you presumably don't want them anywhere;
7451 if you want to standardize the way numbers are shown, set the locale to
7454 This addresses one of the two problems mentioned in bug 12500; there may
7455 be other places in the Wireshark suite where we should use the locale's
7456 decimal separator in times.
7458 Change-Id: I41f1c44d12ebf0f46ff678c977a955d09831b0cf
7460 Reviewed-on: https://code.wireshark.org/review/15787
7461 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7464 Author: Guy Harris <guy@alum.mit.edu>
7465 Date: Wed Jun 8 16:26:18 2016 -0700
7467 ieee80211_htrate() isn't exported.
7469 Change-Id: I8a7a4727b473820d46ee543875f9fb57c5d79928
7470 Reviewed-on: https://code.wireshark.org/review/15786
7471 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7474 Author: Gerald Combs <gerald@wireshark.org>
7475 Date: Wed Jun 8 14:55:06 2016 -0700
7479 Change-Id: Ib8aab341be406d3c6e9139ae670489bd9e3edcc5
7480 Reviewed-on: https://code.wireshark.org/review/15785
7481 Reviewed-by: Gerald Combs <gerald@wireshark.org>