null_blk: initialize the tag_set timeout in null_init_tag_set
authorChristoph Hellwig <hch@lst.de>
Tue, 20 Feb 2024 09:32:45 +0000 (10:32 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 20 Feb 2024 13:21:27 +0000 (06:21 -0700)
Otherwise it will be reset to the always same value when initializing a
device using the shared tag_set.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Tested-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20240220093248.3290292-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/null_blk/main.c

index d6836327eefb426b6346fb536b4324767180a2b0..89e63d1c61036274565dd4883145100fba983973 100644 (file)
@@ -1797,6 +1797,7 @@ static int null_init_tag_set(struct nullb *nullb, struct blk_mq_tag_set *set)
        set->nr_hw_queues = hw_queues;
        set->queue_depth = queue_depth;
        set->numa_node = numa_node;
+       set->timeout = 5 * HZ;
        if (poll_queues) {
                set->nr_hw_queues += poll_queues;
                set->nr_maps = 3;
@@ -1921,7 +1922,6 @@ static int null_add_dev(struct nullb_device *dev)
        if (rv)
                goto out_cleanup_queues;
 
-       nullb->tag_set->timeout = 5 * HZ;
        nullb->disk = blk_mq_alloc_disk(nullb->tag_set, NULL, nullb);
        if (IS_ERR(nullb->disk)) {
                rv = PTR_ERR(nullb->disk);