drm/msm: Remove dangling submitqueue references
authorRob Clark <robdclark@chromium.org>
Mon, 17 Aug 2020 22:01:26 +0000 (15:01 -0700)
committerRob Clark <robdclark@chromium.org>
Sat, 12 Sep 2020 17:45:55 +0000 (10:45 -0700)
Currently it doesn't matter, since we free the ctx immediately.  But
when we start refcnt'ing the ctx, we don't want old dangling list
entries to hang around.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/gpu/drm/msm/msm_submitqueue.c

index a1d94be7883a061c26dc1773ecea30a548554431..90c9d84e6155ab39f3b45f45d54025a6039bf4d5 100644 (file)
@@ -49,8 +49,10 @@ void msm_submitqueue_close(struct msm_file_private *ctx)
         * No lock needed in close and there won't
         * be any more user ioctls coming our way
         */
-       list_for_each_entry_safe(entry, tmp, &ctx->submitqueues, node)
+       list_for_each_entry_safe(entry, tmp, &ctx->submitqueues, node) {
+               list_del(&entry->node);
                msm_submitqueue_put(entry);
+       }
 }
 
 int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,