r8169: add missing conditional compiling for call to r8169_remove_leds
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 10 Apr 2024 13:11:28 +0000 (15:11 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 11 Apr 2024 01:59:31 +0000 (18:59 -0700)
Add missing dependency on CONFIG_R8169_LEDS. As-is a link error occurs
if config option CONFIG_R8169_LEDS isn't enabled.

Fixes: 19fa4f2a85d7 ("r8169: fix LED-related deadlock on module removal")
Reported-by: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Tested-By: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>
Link: https://lore.kernel.org/r/d080038c-eb6b-45ac-9237-b8c1cdd7870f@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index 8a27328eae34b7ef10b134d354e7ac0ccc032b28..0fc5fe564ae50be28bc6568f90d339d840a4b8d1 100644 (file)
@@ -5046,7 +5046,8 @@ static void rtl_remove_one(struct pci_dev *pdev)
 
        cancel_work_sync(&tp->wk.work);
 
-       r8169_remove_leds(tp->leds);
+       if (IS_ENABLED(CONFIG_R8169_LEDS))
+               r8169_remove_leds(tp->leds);
 
        unregister_netdev(tp->dev);