CVE-2020-10745: ndr/dns-utils: prepare for NBT compatibility
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 14 May 2020 22:52:45 +0000 (10:52 +1200)
committerKarolin Seeger <kseeger@samba.org>
Thu, 2 Jul 2020 09:01:41 +0000 (09:01 +0000)
commitcc3a67760cf9faaad3af73b1eed9e2ef85276633
treed90b5a7325ec352f8d1458b4a0245edaf1753865
parentc3fa8ada43e5383f8dec6cd93cbc21139df704f7
CVE-2020-10745: ndr/dns-utils: prepare for NBT compatibility

NBT has a funny thing where it sometimes needs to send a trailing dot as
part of the last component, because the string representation is a user
name. In DNS, "example.com", and "example.com." are the same, both
having three components ("example", "com", ""); in NBT, we want to treat
them differently, with the second form having the three components
("example", "com.", "").

This retains the logic of e6e2ec0001fe3c010445e26cc0efddbc1f73416b.

Also DNS compression cannot be turned off for NBT.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
librpc/ndr/ndr_dns.c
librpc/ndr/ndr_dns_utils.c
librpc/ndr/ndr_dns_utils.h
librpc/ndr/ndr_nbt.c
librpc/wscript_build
selftest/knownfail.d/dns_packet
selftest/knownfail.d/ndr_dns_nbt [deleted file]