BIG patch...
authorAndrew Bartlett <abartlet@samba.org>
Thu, 2 Jan 2003 09:07:17 +0000 (09:07 +0000)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 2 Jan 2003 09:07:17 +0000 (09:07 +0000)
commit6d66fb308ab85bd9691d541764e683e6040cf724
tree10b705921665cb7bafdd332ca53b8a943e13f0e5
parentc105c12d122e599fe57dde8b2b73c52231f0c1d2
BIG patch...

This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
138 files changed:
source3/auth/auth.c
source3/auth/pampass.c
source3/client/client.c
source3/client/clitar.c
source3/client/smbspool.c
source3/groupdb/mapping.c
source3/include/auth.h
source3/include/charset.h
source3/include/includes.h
source3/include/mapping.h
source3/include/ntdomain.h
source3/include/passdb.h
source3/include/rpc_dce.h
source3/include/rpc_reg.h
source3/include/smb.h
source3/intl/lang_tdb.c
source3/lib/account_pol.c
source3/lib/adt_tree.c
source3/lib/charcnv.c
source3/lib/genrand.c
source3/lib/iconv.c
source3/lib/messages.c
source3/lib/pam_errors.c
source3/lib/pidfile.c
source3/lib/smbpasswd.c
source3/lib/system.c
source3/lib/util.c
source3/lib/util_sid.c
source3/lib/util_sock.c
source3/lib/util_str.c
source3/libads/disp_sec.c
source3/libads/ldap.c
source3/libads/ldap_printer.c
source3/libsmb/asn1.c
source3/libsmb/clidgram.c
source3/libsmb/clientgen.c
source3/libsmb/clierror.c
source3/libsmb/clikrb5.c
source3/libsmb/cliprint.c
source3/libsmb/clirap.c
source3/libsmb/clirap2.c
source3/libsmb/clireadwrite.c
source3/libsmb/doserr.c
source3/libsmb/errormap.c
source3/libsmb/nmblib.c
source3/libsmb/nterr.c
source3/libsmb/smberr.c
source3/libsmb/unexpected.c
source3/nmbd/nmbd_namelistdb.c
source3/nmbd/nmbd_packets.c
source3/nmbd/nmbd_processlogon.c
source3/nmbd/nmbd_sendannounce.c
source3/nmbd/nmbd_subnetdb.c
source3/nmbd/nmbd_winsserver.c
source3/nsswitch/wbinfo.c
source3/nsswitch/winbindd.c
source3/param/loadparm.c
source3/param/params.c
source3/passdb/passdb.c
source3/passdb/pdb_interface.c
source3/passdb/pdb_ldap.c
source3/passdb/pdb_tdb.c
source3/passdb/secrets.c
source3/passdb/util_sam_sid.c
source3/printing/lpq_parse.c
source3/printing/nt_printing.c
source3/printing/printing.c
source3/registry/reg_objects.c
source3/registry/reg_printing.c
source3/rpc_client/cli_pipe.c
source3/rpc_client/cli_spoolss.c
source3/rpc_parse/parse_dfs.c
source3/rpc_parse/parse_ds.c
source3/rpc_parse/parse_lsa.c
source3/rpc_parse/parse_misc.c
source3/rpc_parse/parse_net.c
source3/rpc_parse/parse_prs.c
source3/rpc_parse/parse_reg.c
source3/rpc_parse/parse_rpc.c
source3/rpc_parse/parse_samr.c
source3/rpc_parse/parse_sec.c
source3/rpc_parse/parse_spoolss.c
source3/rpc_parse/parse_srv.c
source3/rpc_parse/parse_wks.c
source3/rpc_server/srv_lsa.c
source3/rpc_server/srv_netlog_nt.c
source3/rpc_server/srv_pipe.c
source3/rpc_server/srv_reg_nt.c
source3/rpc_server/srv_spoolss_nt.c
source3/rpc_server/srv_srvsvc_nt.c
source3/rpc_server/srv_util.c
source3/rpcclient/cmd_samr.c
source3/rpcclient/cmd_spoolss.c
source3/rpcclient/rpcclient.h
source3/smbd/build_options.c
source3/smbd/connection.c
source3/smbd/dir.c
source3/smbd/filename.c
source3/smbd/lanman.c
source3/smbd/mangle.c
source3/smbd/mangle_hash.c
source3/smbd/negprot.c
source3/smbd/nttrans.c
source3/smbd/process.c
source3/smbd/reply.c
source3/smbd/server.c
source3/smbd/utmp.c
source3/smbd/vfs.c
source3/tdb/tdbutil.c
source3/torture/denytest.c
source3/torture/locktest2.c
source3/torture/masktest.c
source3/torture/nsstest.c
source3/torture/scanner.c
source3/torture/torture.c
source3/torture/vfstest.c
source3/torture/vfstest.h
source3/ubiqx/debugparse.c
source3/ubiqx/debugparse.h
source3/utils/editreg.c
source3/utils/net.c
source3/utils/net.h
source3/utils/net_ads.c
source3/utils/net_rap.c
source3/utils/net_rpc.c
source3/utils/net_time.c
source3/utils/nmblookup.c
source3/utils/ntlm_auth.c
source3/utils/pdbedit.c
source3/utils/profiles.c
source3/utils/smbcacls.c
source3/utils/smbcontrol.c
source3/utils/smbpasswd.c
source3/utils/testprns.c
source3/web/cgi.c
source3/web/statuspage.c
source3/web/swat.c
source3/wrepld/server.c