ctdb-tests: Make integration.bash pass shellcheck
authorMartin Schwenke <martin@meltin.net>
Thu, 5 Mar 2020 18:58:26 +0000 (05:58 +1100)
committerAmitay Isaacs <amitay@samba.org>
Wed, 22 Jul 2020 02:42:37 +0000 (02:42 +0000)
commit0f04b8a70be3b8e157a4a88e9e54e87fa380022e
tree0bf03dd7150f2c9626b0de87b48c2a03f40aeeea
parent9a7cabd342d0aed450ed3305931702a7351f814a
ctdb-tests: Make integration.bash pass shellcheck

Apart from the non-constant sourcing of include files.

Mostly avoidance of quoting warnings.

One subtle change is to simply pass "120" to wait_until_ready() to
stop warnings that it expects arguments but none are passed (both
SC2119 and SC2120).  There seems no way to indicate to structure
function argument handling so that shellcheck realises arguments are
optional.  In later shellcheck versions, disabling SC2120 for a
function also silences complaints about its callers... but not all of
our testing uses "later" shellcheck versions.

Signed-off-by: Martin Schwenke <martin@meltin.net>
ctdb/tests/UNIT/shellcheck/tests.sh
ctdb/tests/scripts/integration.bash