s3/smbd: Fix error code for unsupported SET_INFO requests
[sfrench/samba-autobuild/.git] / source3 / smbd / smb2_flush.c
index c3f5a301290d24348d1cb2f390a7b3f32a03e7a2..d077c62c40345da38cee41dfedda24aa43709f96 100644 (file)
 static struct tevent_req *smbd_smb2_flush_send(TALLOC_CTX *mem_ctx,
                                               struct tevent_context *ev,
                                               struct smbd_smb2_request *smb2req,
-                                              uint64_t in_file_id_volatile);
+                                              struct files_struct *fsp);
 static NTSTATUS smbd_smb2_flush_recv(struct tevent_req *req);
 
 static void smbd_smb2_request_flush_done(struct tevent_req *subreq);
 NTSTATUS smbd_smb2_request_process_flush(struct smbd_smb2_request *req)
 {
-       const uint8_t *inhdr;
+       NTSTATUS status;
        const uint8_t *inbody;
-       int i = req->current_idx;
-       size_t expected_body_size = 0x18;
-       size_t body_size;
        uint64_t in_file_id_persistent;
        uint64_t in_file_id_volatile;
+       struct files_struct *in_fsp;
        struct tevent_req *subreq;
 
-       inhdr = (const uint8_t *)req->in.vector[i+0].iov_base;
-       if (req->in.vector[i+1].iov_len != (expected_body_size & 0xFFFFFFFE)) {
-               return smbd_smb2_request_error(req, NT_STATUS_INVALID_PARAMETER);
-       }
-
-       inbody = (const uint8_t *)req->in.vector[i+1].iov_base;
-
-       body_size = SVAL(inbody, 0x00);
-       if (body_size != expected_body_size) {
-               return smbd_smb2_request_error(req, NT_STATUS_INVALID_PARAMETER);
+       status = smbd_smb2_request_verify_sizes(req, 0x18);
+       if (!NT_STATUS_IS_OK(status)) {
+               return smbd_smb2_request_error(req, status);
        }
+       inbody = SMBD_SMB2_IN_BODY_PTR(req);
 
        in_file_id_persistent   = BVAL(inbody, 0x08);
        in_file_id_volatile     = BVAL(inbody, 0x10);
 
-       if (req->compat_chain_fsp) {
-               /* skip check */
-       } else if (in_file_id_persistent != in_file_id_volatile) {
+       in_fsp = file_fsp_smb2(req, in_file_id_persistent, in_file_id_volatile);
+       if (in_fsp == NULL) {
                return smbd_smb2_request_error(req, NT_STATUS_FILE_CLOSED);
        }
 
-       subreq = smbd_smb2_flush_send(req,
-                                     req->sconn->smb2.event_ctx,
-                                     req,
-                                     in_file_id_volatile);
+       subreq = smbd_smb2_flush_send(req, req->sconn->ev_ctx,
+                                     req, in_fsp);
        if (subreq == NULL) {
                return smbd_smb2_request_error(req, NT_STATUS_NO_MEMORY);
        }
        tevent_req_set_callback(subreq, smbd_smb2_request_flush_done, req);
 
-       return smbd_smb2_request_pending_queue(req, subreq);
+       return smbd_smb2_request_pending_queue(req, subreq, 500);
 }
 
 static void smbd_smb2_request_flush_done(struct tevent_req *subreq)
@@ -88,18 +77,18 @@ static void smbd_smb2_request_flush_done(struct tevent_req *subreq)
        if (!NT_STATUS_IS_OK(status)) {
                error = smbd_smb2_request_error(req, status);
                if (!NT_STATUS_IS_OK(error)) {
-                       smbd_server_connection_terminate(req->sconn,
+                       smbd_server_connection_terminate(req->xconn,
                                                         nt_errstr(error));
                        return;
                }
                return;
        }
 
-       outbody = data_blob_talloc(req->out.vector, NULL, 0x10);
+       outbody = smbd_smb2_generate_outbody(req, 0x04);
        if (outbody.data == NULL) {
                error = smbd_smb2_request_error(req, NT_STATUS_NO_MEMORY);
                if (!NT_STATUS_IS_OK(error)) {
-                       smbd_server_connection_terminate(req->sconn,
+                       smbd_server_connection_terminate(req->xconn,
                                                         nt_errstr(error));
                        return;
                }
@@ -111,7 +100,7 @@ static void smbd_smb2_request_flush_done(struct tevent_req *subreq)
 
        error = smbd_smb2_request_done(req, outbody, NULL);
        if (!NT_STATUS_IS_OK(error)) {
-               smbd_server_connection_terminate(req->sconn,
+               smbd_server_connection_terminate(req->xconn,
                                                 nt_errstr(error));
                return;
        }
@@ -121,16 +110,18 @@ struct smbd_smb2_flush_state {
        struct smbd_smb2_request *smb2req;
 };
 
+static void smbd_smb2_flush_done(struct tevent_req *subreq);
+
 static struct tevent_req *smbd_smb2_flush_send(TALLOC_CTX *mem_ctx,
                                               struct tevent_context *ev,
                                               struct smbd_smb2_request *smb2req,
-                                              uint64_t in_file_id_volatile)
+                                              struct files_struct *fsp)
 {
        struct tevent_req *req;
+       struct tevent_req *subreq;
        struct smbd_smb2_flush_state *state;
-       NTSTATUS status;
        struct smb_request *smbreq;
-       files_struct *fsp;
+       int ret;
 
        req = tevent_req_create(mem_ctx, &state,
                                struct smbd_smb2_flush_state);
@@ -139,8 +130,8 @@ static struct tevent_req *smbd_smb2_flush_send(TALLOC_CTX *mem_ctx,
        }
        state->smb2req = smb2req;
 
-       DEBUG(10,("smbd_smb2_flush: file_id[0x%016llX]\n",
-                 (unsigned long long)in_file_id_volatile));
+       DEBUG(10,("smbd_smb2_flush: %s - %s\n",
+                 fsp_str_dbg(fsp), fsp_fnum_dbg(fsp)));
 
        smbreq = smbd_smb2_fake_smb_request(smb2req);
        if (tevent_req_nomem(smbreq, req)) {
@@ -152,35 +143,65 @@ static struct tevent_req *smbd_smb2_flush_send(TALLOC_CTX *mem_ctx,
                return tevent_req_post(req, ev);
        }
 
-       fsp = file_fsp(smbreq, (uint16_t)in_file_id_volatile);
-       if (fsp == NULL) {
-               tevent_req_nterror(req, NT_STATUS_FILE_CLOSED);
+       if (!CHECK_WRITE(fsp)) {
+               tevent_req_nterror(req, NT_STATUS_ACCESS_DENIED);
                return tevent_req_post(req, ev);
        }
-       if (smbreq->conn != fsp->conn) {
-               tevent_req_nterror(req, NT_STATUS_FILE_CLOSED);
+
+       if (fsp->fh->fd == -1) {
+               tevent_req_nterror(req, NT_STATUS_INVALID_HANDLE);
                return tevent_req_post(req, ev);
        }
-       if (smb2req->session->vuid != fsp->vuid) {
-               tevent_req_nterror(req, NT_STATUS_FILE_CLOSED);
+
+       if (!lp_strict_sync(SNUM(smbreq->conn))) {
+               /*
+                * No strict sync. Don't really do
+                * anything here.
+                */
+               tevent_req_done(req);
                return tevent_req_post(req, ev);
        }
 
-       if (!CHECK_WRITE(fsp)) {
-               tevent_req_nterror(req, NT_STATUS_ACCESS_DENIED);
+       ret = flush_write_cache(fsp, SAMBA_SYNC_FLUSH);
+       if (ret == -1) {
+               tevent_req_nterror(req,  map_nt_error_from_unix(errno));
                return tevent_req_post(req, ev);
        }
 
-       status = sync_file(smbreq->conn, fsp, true);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(5,("smbd_smb2_flush: sync_file for %s returned %s\n",
-                        fsp_str_dbg(fsp), nt_errstr(status)));
-               tevent_req_nterror(req, status);
+       subreq = SMB_VFS_FSYNC_SEND(state, ev, fsp);
+       if (tevent_req_nomem(subreq, req)) {
                return tevent_req_post(req, ev);
        }
 
+       tevent_req_set_callback(subreq, smbd_smb2_flush_done, req);
+
+       /* Ensure any close request knows about this outstanding IO. */
+       if (!aio_add_req_to_fsp(fsp, req)) {
+               tevent_req_nterror(req, NT_STATUS_NO_MEMORY);
+               return tevent_req_post(req, ev);
+       }
+
+       increment_outstanding_aio_calls();
+       return req;
+
+}
+
+static void smbd_smb2_flush_done(struct tevent_req *subreq)
+{
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       int ret;
+       struct vfs_aio_state vfs_aio_state;
+
+       decrement_outstanding_aio_calls();
+
+       ret = SMB_VFS_FSYNC_RECV(subreq, &vfs_aio_state);
+       TALLOC_FREE(subreq);
+       if (ret == -1) {
+               tevent_req_error(req, vfs_aio_state.error);
+               return;
+       }
        tevent_req_done(req);
-       return tevent_req_post(req, ev);
 }
 
 static NTSTATUS smbd_smb2_flush_recv(struct tevent_req *req)