libwbclient: Fix a few resource leak CIDs

[sfrench/samba-autobuild/.git] / nsswitch / libwbclient / tests / wbclient.c

diff --git a/nsswitch/libwbclient/tests/wbclient.c b/nsswitch/libwbclient/tests/wbclient.c
index e011efed0221f844fe8acc2f333d46ce2ed255d0..0de6096ee4632ec3d969f44a4dafcf253f54bca2 100644 (file)
--- a/nsswitch/libwbclient/tests/wbclient.c
+++ b/nsswitch/libwbclient/tests/wbclient.c
@@ -475,27 +475,30 @@ static bool test_wbc_lookup_rids(struct torture_context *tctx)
 {
        struct wbcDomainSid builtin;
        uint32_t rids[2] = { 544, 545 };
-       const char *domain_name, **names;
+       const char *domain_name = NULL;
+       const char **names = NULL;
        enum wbcSidType *types;
-       wbcErr ret;
+       wbcErr ret = false;
 
        wbcStringToSid("S-1-5-32", &builtin);
 
        ret = wbcLookupRids(&builtin, 2, rids, &domain_name, &names,
                            &types);
-       torture_assert_wbc_ok(tctx, ret, "%s", "wbcLookupRids for 544 and 545 failed");
+       torture_assert_wbc_ok_goto_fail(
+               tctx, ret, "%s", "wbcLookupRids for 544 and 545 failed");
 
        torture_assert_str_equal(
                tctx, names[0], "Administrators",
                "S-1-5-32-544 not mapped to 'Administrators'");
-       torture_assert_str_equal(
+       torture_assert_str_equal_goto_fail(
                tctx, names[1], "Users", "S-1-5-32-545 not mapped to 'Users'");
 
+       ret = true;
+fail:
        wbcFreeMemory(discard_const_p(char ,domain_name));
        wbcFreeMemory(names);
        wbcFreeMemory(types);
-
-       return true;
+       return ret;
 }
 
 static bool test_wbc_get_sidaliases(struct torture_context *tctx)