ASoC: SOF: Intel: hda: Make hdac_device device-managed
authorRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Wed, 26 Jun 2019 07:04:50 +0000 (00:04 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jul 2019 12:09:25 +0000 (13:09 +0100)
commitef9bec27485fefb6b93168fea73fda0dc9638046
tree49de86c5bcbafb400dd0ca46605a89b1f85c0ca8
parent5f9e832c137075045d15cd6899ab0505cfb2ca4b
ASoC: SOF: Intel: hda: Make hdac_device device-managed

snd_hdac_ext_bus_device_exit() has been recently modified
to no longer free the hdac device. SOF allocates memory for
hdac_device and hda_hda_priv with kzalloc. Make them
device-managed instead so that they will be freed when the
SOF driver is unloaded.

Because of the above change, hda_codec is device-managed and
it will be freed when the ASoC device is removed. Freeing
the codec in snd_hda_codec_dev_release() leads to kernel
panic while unloading and reloading the ASoC driver. So,
avoid freeing the hda_codec for ASoC driver. This is done in
the same patch to avoid bisect failure.

Signed-off-by: Libin Yang <libin.yang@intel.com>
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20190626070450.7229-1-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/pci/hda/hda_codec.c
sound/soc/sof/intel/hda-codec.c