spi: work around clang bug in SPI_BPW_RANGE_MASK()
authorArnd Bergmann <arnd@arndb.de>
Thu, 7 Mar 2019 15:54:21 +0000 (16:54 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 11 Mar 2019 16:43:24 +0000 (16:43 +0000)
commiteefffb42f6659c9510105f3e4ebf2a8499d56936
tree0498804ba6a9fe694b3a8e85874817cd49c791a8
parent14dbfb417bd80c96ec700c7a8414bb6f5db7ecd2
spi: work around clang bug in SPI_BPW_RANGE_MASK()

Clang-8 evaluates both sides of a ?: expression to check for
valid arithmetic even in the side that is never taken. This
results in a build warning:

drivers/spi/spi-sh-msiof.c:1052:24: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
        .bits_per_word_mask = SPI_BPW_RANGE_MASK(8, 32),
                              ^~~~~~~~~~~~~~~~~~~~~~~~~

Change the implementation to use the GENMASK() macro that does
what we want here but does not have a problem with the shift
count overflow.

Link: https://bugs.llvm.org/show_bug.cgi?id=38789
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/linux/spi/spi.h