net: sched: cls_u32: Undo refcount decrement in case update failed
authorVictor Nogueira <victor@mojatatu.com>
Thu, 13 Jul 2023 18:05:12 +0000 (15:05 -0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Jul 2023 06:33:38 +0000 (07:33 +0100)
commite8d3d78c19be0264a5692bed477c303523aead31
tree45f2c467ccc58414bee4fccf43708cd670fd7793
parent9cb36faedeafb9720ac236aeae2ea57091d90a09
net: sched: cls_u32: Undo refcount decrement in case update failed

In the case of an update, when TCA_U32_LINK is set, u32_set_parms will
decrement the refcount of the ht_down (struct tc_u_hnode) pointer
present in the older u32 filter which we are replacing. However, if
u32_replace_hw_knode errors out, the update command fails and that
ht_down pointer continues decremented. To fix that, when
u32_replace_hw_knode fails, check if ht_down's refcount was decremented
and undo the decrement.

Fixes: d34e3e181395 ("net: cls_u32: Add support for skip-sw flag to tc u32 classifier.")
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_u32.c