smack: use GFP_NOFS while holding inode_smack::smk_lock
authorEric Biggers <ebiggers@google.com>
Thu, 22 Aug 2019 05:54:41 +0000 (22:54 -0700)
committerCasey Schaufler <casey@schaufler-ca.com>
Wed, 4 Sep 2019 16:37:07 +0000 (09:37 -0700)
commite5bfad3d7acc5702f32aafeb388362994f4d7bd0
treec9daa0267c2dd110e5a8ccbed94ac8c8edb9c6e6
parent3f4287e7d98a2954f20bf96c567fdffcd2b63eb9
smack: use GFP_NOFS while holding inode_smack::smk_lock

inode_smack::smk_lock is taken during smack_d_instantiate(), which is
called during a filesystem transaction when creating a file on ext4.
Therefore to avoid a deadlock, all code that takes this lock must use
GFP_NOFS, to prevent memory reclaim from waiting for the filesystem
transaction to complete.

Reported-by: syzbot+0eefc1e06a77d327a056@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
security/smack/smack_access.c
security/smack/smack_lsm.c