jbd2: avoid -Wempty-body warnings
authorArnd Bergmann <arnd@arndb.de>
Mon, 22 Mar 2021 10:21:38 +0000 (11:21 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 6 Apr 2021 02:39:38 +0000 (22:39 -0400)
commitd556435156b7970b8ce61b355df558a5168927cc
treeb3d7e0a88cb1c78f8c1773e415707cea54e40042
parent1ae98e295fa2577fb5e492200c58d10230e00e99
jbd2: avoid -Wempty-body warnings

Building with 'make W=1' shows a harmless -Wempty-body warning:

fs/jbd2/recovery.c: In function 'fc_do_one_pass':
fs/jbd2/recovery.c:267:75: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
  267 |                 jbd_debug(3, "Fast commit replay failed, err = %d\n", err);
      |                                                                           ^

Change the empty dprintk() macros to no_printk(), which avoids this
warning and adds format string checking.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20210322102152.95684-1-arnd@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
include/linux/jbd2.h