ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Dec 2020 06:54:09 +0000 (09:54 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 11 Dec 2020 13:21:35 +0000 (13:21 +0000)
commit85a7555575a0e48f9b73db310d0d762a08a46d63
tree7f29aa1ff3e7b51a8058cd570fb785c6e769b245
parent718c406e1ffaca4eac987b957bbb36ce1090797a
ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control()

The error handling frees "ctl" but it's still on the "dsp->ctl_list"
list so that could result in a use after free.  Remove it from the list
before returning.

Fixes: 2323736dca72 ("ASoC: wm_adsp: Add basic support for rev 1 firmware file format")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/X9B0keV/02wrx9Xs@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c