seq_buf: Make DECLARE_SEQ_BUF() usable
authorNathan Lynch <nathanl@linux.ibm.com>
Tue, 16 Jan 2024 14:09:25 +0000 (08:09 -0600)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Thu, 18 Jan 2024 14:22:02 +0000 (09:22 -0500)
commit7a8e9cdf9405819105ae7405cd91e482bf574b01
tree5542d38879349906caa82bf87d9ada79f4c58112
parent1057066009c4325bb1d8430c9274894d0860e7c3
seq_buf: Make DECLARE_SEQ_BUF() usable

Using the address operator on the array doesn't work:

./include/linux/seq_buf.h:27:27: error: initialization of ‘char *’
  from incompatible pointer type ‘char (*)[128]’
  [-Werror=incompatible-pointer-types]
   27 |                 .buffer = &__ ## NAME ## _buffer,       \
      |                           ^

Apart from fixing that, we can improve DECLARE_SEQ_BUF() by using a
compound literal to define the buffer array without attaching a name
to it. This makes the macro a single statement, allowing constructs
such as:

  static DECLARE_SEQ_BUF(my_seq_buf, MYSB_SIZE);

to work as intended.

Link: https://lkml.kernel.org/r/20240116-declare-seq-buf-fix-v1-1-915db4692f32@linux.ibm.com
Cc: stable@vger.kernel.org
Acked-by: Kees Cook <keescook@chromium.org>
Fixes: dcc4e5728eea ("seq_buf: Introduce DECLARE_SEQ_BUF and seq_buf_str()")
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
include/linux/seq_buf.h