ALSA: Convert strlcpy to strscpy when return value is unused
authorJoe Perches <joe@perches.com>
Mon, 4 Jan 2021 17:17:34 +0000 (09:17 -0800)
committerTakashi Iwai <tiwai@suse.de>
Fri, 8 Jan 2021 08:30:05 +0000 (09:30 +0100)
commit75b1a8f9d62e50f05d0e4e9f3c8bcde32527ffc1
tree75959ffde6616d98dbcdecf3bf30024da5c8cd3f
parent6dcb8bf9a1d7f6d137a17b76177cd67e9b8e023d
ALSA: Convert strlcpy to strscpy when return value is unused

strlcpy is deprecated.  see: Documentation/process/deprecated.rst

Change the calls that do not use the strlcpy return value to the
preferred strscpy.

Done with cocci script:

@@
expression e1, e2, e3;
@@

- strlcpy(
+ strscpy(
e1, e2, e3);

This cocci script leaves the instances where the return value is
used unchanged.

After this patch, sound/ has 3 uses of strlcpy() that need to be
manually inspected for conversion and changed one day.

$ git grep -w strlcpy sound/
sound/usb/card.c:               len = strlcpy(card->longname, s, sizeof(card->longname));
sound/usb/mixer.c:      return strlcpy(buf, p->name, buflen);
sound/usb/mixer.c:                      return strlcpy(buf, p->names[index], buflen);

Miscellenea:

o Remove trailing whitespace in conversion of sound/core/hwdep.c

Link: https://lore.kernel.org/lkml/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/22b393d1790bb268769d0bab7bacf0866dcb0c14.camel@perches.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
79 files changed:
sound/aoa/codecs/onyx.c
sound/aoa/codecs/tas.c
sound/aoa/codecs/toonie.c
sound/aoa/core/alsa.c
sound/aoa/fabrics/layout.c
sound/aoa/soundbus/sysfs.c
sound/arm/aaci.c
sound/arm/pxa2xx-ac97.c
sound/core/compress_offload.c
sound/core/control.c
sound/core/ctljack.c
sound/core/hwdep.c
sound/core/init.c
sound/core/oss/mixer_oss.c
sound/core/pcm.c
sound/core/pcm_native.c
sound/core/rawmidi.c
sound/core/seq/oss/seq_oss_midi.c
sound/core/seq/oss/seq_oss_synth.c
sound/core/seq/seq_clientmgr.c
sound/core/seq/seq_ports.c
sound/core/timer.c
sound/core/timer_compat.c
sound/drivers/opl3/opl3_oss.c
sound/drivers/opl3/opl3_synth.c
sound/firewire/bebob/bebob_hwdep.c
sound/firewire/dice/dice-hwdep.c
sound/firewire/digi00x/digi00x-hwdep.c
sound/firewire/fireface/ff-hwdep.c
sound/firewire/fireworks/fireworks_hwdep.c
sound/firewire/motu/motu-hwdep.c
sound/firewire/oxfw/oxfw-hwdep.c
sound/firewire/tascam/tascam-hwdep.c
sound/i2c/i2c.c
sound/isa/ad1848/ad1848.c
sound/isa/cs423x/cs4231.c
sound/isa/cs423x/cs4236.c
sound/isa/es1688/es1688.c
sound/isa/sb/sb16_csp.c
sound/isa/sb/sb_mixer.c
sound/oss/dmasound/dmasound_core.c
sound/pci/cs5535audio/cs5535audio_olpc.c
sound/pci/ctxfi/ctpcm.c
sound/pci/emu10k1/emu10k1.c
sound/pci/emu10k1/emu10k1_main.c
sound/pci/emu10k1/emufx.c
sound/pci/es1968.c
sound/pci/fm801.c
sound/pci/hda/hda_auto_parser.c
sound/pci/hda/hda_codec.c
sound/pci/hda/hda_controller.c
sound/pci/hda/hda_eld.c
sound/pci/hda/hda_generic.c
sound/pci/hda/hda_intel.c
sound/pci/hda/hda_jack.c
sound/pci/ice1712/juli.c
sound/pci/ice1712/psc724.c
sound/pci/ice1712/quartet.c
sound/pci/ice1712/wm8776.c
sound/pci/lola/lola.c
sound/pci/lola/lola_pcm.c
sound/pci/rme9652/hdspm.c
sound/ppc/keywest.c
sound/soc/qcom/qdsp6/q6afe.c
sound/soc/sh/rcar/core.c
sound/usb/bcd2000/bcd2000.c
sound/usb/caiaq/audio.c
sound/usb/caiaq/device.c
sound/usb/caiaq/midi.c
sound/usb/card.c
sound/usb/hiface/chip.c
sound/usb/hiface/pcm.c
sound/usb/mixer.c
sound/usb/mixer_quirks.c
sound/usb/mixer_scarlett.c
sound/usb/mixer_scarlett_gen2.c
sound/usb/mixer_us16x08.c
sound/x86/intel_hdmi_audio.c
sound/xen/xen_snd_front_cfg.c