net: mtk_eth_soc: add fixme comment for state->speed use
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 18 May 2022 14:55:07 +0000 (15:55 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 20 May 2022 01:14:30 +0000 (18:14 -0700)
commit650a49bc65df6b0e0051a8f62d7c22d95a8f350d
treec203cf30d2c640b16ec22805b01e77a4d89039c4
parent1ec619ee4a052fb9ac48b57554ac2722a0bfe73c
net: mtk_eth_soc: add fixme comment for state->speed use

Add a fixme comment for the last remaining incorrect usage of
state->speed in the mac_config() method, which is strangely in a code
path which is only run when the PHY interface mode changes.

This means if we are in RGMII mode, changes in state->speed will not
cause the INTF_MODE, TRGMII_RCK_CTRL and TRGMII_TCK_CTRL registers to
be set according to the speed, nor will the TRGPLL clock be set to the
correct value.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c