crypto: omap-sham - drop pm_runtime_irqsafe() usage
authorTony Lindgren <tony@atomide.com>
Tue, 27 Jul 2021 10:23:39 +0000 (13:23 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 6 Aug 2021 11:45:24 +0000 (19:45 +0800)
commit1dd0d7fe4b7a50f3a9580e994060e8a8a1c3263e
tree9464cd167792aa904f88b618853cab5618a0fc49
parent70c68d163986985a41fb86979d379212e11f007f
crypto: omap-sham - drop pm_runtime_irqsafe() usage

Commit b0a3d8986a76 ("crypto: omap-sham - Use pm_runtime_irq_safe()") added
the use of pm_runtime_irq_safe() as pm_runtime_get_sync() was called
from a tasklet.

We now use the crypto engine queue instead of a custom queue since
commit 33c3d434d91 ("crypto: omap-sham - convert to use crypto engine").

We want to drop the use of pm_runtime_irq_safe() in general as it takes a
permanent usage count on the parent device causing issues for power
management.

Based on testing with CONFIG_DEBUG_ATOMIC_SLEEP=y, modprobe omap-sham,
followed by modprobe tcrypt sec=1 mode=423, I have not been able to
reproduce the scheduling while atomic issue seen earlier with current
kernels and we can just drop the call to pm_runtime_irq_safe().

Cc: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Tero Kristo <kristo@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-sham.c