btrfs: prevent __btrfs_dump_space_info() to underflow its free space
authorQu Wenruo <wqu@suse.com>
Thu, 16 Sep 2021 12:43:29 +0000 (20:43 +0800)
committerDavid Sterba <dsterba@suse.com>
Fri, 17 Sep 2021 17:29:54 +0000 (19:29 +0200)
commit0619b7901473c380abc05d45cf9c70bee0707db3
treef42753a4a43efeab084230366f5ef47eba8d81d6
parent6b225baababf1e3d41a4250e802cbd193e1343fb
btrfs: prevent __btrfs_dump_space_info() to underflow its free space

It's not uncommon where __btrfs_dump_space_info() gets called
under over-commit situations.

In that case free space would underflow as total allocated space is not
enough to handle all the over-committed space.

Such underflow values can sometimes cause confusion for users enabled
enospc_debug mount option, and takes some seconds for developers to
convert the underflow value to signed result.

Just output the free space as s64 to avoid such problem.

Reported-by: Eli V <eliventer@gmail.com>
Link: https://lore.kernel.org/linux-btrfs/CAJtFHUSy4zgyhf-4d9T+KdJp9w=UgzC2A0V=VtmaeEpcGgm1-Q@mail.gmail.com/
CC: stable@vger.kernel.org # 5.4+
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/space-info.c