Merge branches 'core/futexes', 'core/locking', 'core/rcu' and 'linus' into core/urgent
[sfrench/cifs-2.6.git] / lib / percpu_counter.c
index a8663890a88c2e358f21b8cdc6f23a8ebb9d77e5..4bb0ed350e73a60aef1524335de4daf36455a36b 100644 (file)
@@ -62,20 +62,17 @@ s64 __percpu_counter_sum(struct percpu_counter *fbc)
        for_each_online_cpu(cpu) {
                s32 *pcount = per_cpu_ptr(fbc->counters, cpu);
                ret += *pcount;
-               *pcount = 0;
        }
-       fbc->count = ret;
-
        spin_unlock(&fbc->lock);
        return ret;
 }
 EXPORT_SYMBOL(__percpu_counter_sum);
 
-static struct lock_class_key percpu_counter_irqsafe;
-
-int percpu_counter_init(struct percpu_counter *fbc, s64 amount)
+int __percpu_counter_init(struct percpu_counter *fbc, s64 amount,
+                         struct lock_class_key *key)
 {
        spin_lock_init(&fbc->lock);
+       lockdep_set_class(&fbc->lock, key);
        fbc->count = amount;
        fbc->counters = alloc_percpu(s32);
        if (!fbc->counters)
@@ -87,30 +84,20 @@ int percpu_counter_init(struct percpu_counter *fbc, s64 amount)
 #endif
        return 0;
 }
-EXPORT_SYMBOL(percpu_counter_init);
-
-int percpu_counter_init_irq(struct percpu_counter *fbc, s64 amount)
-{
-       int err;
-
-       err = percpu_counter_init(fbc, amount);
-       if (!err)
-               lockdep_set_class(&fbc->lock, &percpu_counter_irqsafe);
-       return err;
-}
+EXPORT_SYMBOL(__percpu_counter_init);
 
 void percpu_counter_destroy(struct percpu_counter *fbc)
 {
        if (!fbc->counters)
                return;
 
-       free_percpu(fbc->counters);
-       fbc->counters = NULL;
 #ifdef CONFIG_HOTPLUG_CPU
        mutex_lock(&percpu_counters_lock);
        list_del(&fbc->list);
        mutex_unlock(&percpu_counters_lock);
 #endif
+       free_percpu(fbc->counters);
+       fbc->counters = NULL;
 }
 EXPORT_SYMBOL(percpu_counter_destroy);