jmayer [Wed, 15 Mar 2006 10:53:33 +0000 (10:53 +0000)]
Update/add some Cisco multicast addresses
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17633
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 15 Mar 2006 08:26:21 +0000 (08:26 +0000)]
lookupnames2 takes a different sid structure compared to lookupnames
update it to dissect it as such and create new helpers for the new structure that takes one extra guint32 at the end of the previous structure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17632
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 15 Mar 2006 06:20:23 +0000 (06:20 +0000)]
Start implementing the variable binding part.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17631
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 15 Mar 2006 06:19:15 +0000 (06:19 +0000)]
From Motonori Shindo:
The code assumes Template FlowSet contains only one Template Record, which is not necessarily true. Please find attached the patch to fix it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17630
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 15 Mar 2006 06:17:35 +0000 (06:17 +0000)]
From Martin Mathieson:
> This patch:
> - adds a few filterable fields (currently there are only hidden
> boolean fields for request and response).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17629
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 15 Mar 2006 06:16:12 +0000 (06:16 +0000)]
From Martin Mathieson
>>>This patch:
>>>- makes it possible to turn off use of the XML AVP dictionary (which
>>>relies upon the XML lib being installed). A failed load results in 3
>>>annoying dialogs popping up the first time a diameter packet is read.
>>>Default is previous behaviour.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17628
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Wed, 15 Mar 2006 01:41:39 +0000 (01:41 +0000)]
Fix bug 710 and avoid having it crash when more than one instance are open at once.
I think that whoever wrote the whole stats_tree thing should rewrite it ASAP, because it sucks!
I did ?!?!??
ooops!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17627
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Mar 2006 08:11:18 +0000 (08:11 +0000)]
coverity bug 139
actually allow dissection of RELEASE_LOCKOWNER call
instead of letting it hang as dead code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17626
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Mar 2006 07:47:19 +0000 (07:47 +0000)]
coverity bug 68
prevent a very very long loop
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17625
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Mar 2006 07:38:43 +0000 (07:38 +0000)]
coverity bug 43
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17624
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 14 Mar 2006 06:42:58 +0000 (06:42 +0000)]
Add strptime.obj to outfiles as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17623
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 14 Mar 2006 05:49:15 +0000 (05:49 +0000)]
From Laurent Rabret,
2 patches for the "flow graph" display. It is better not to insert invalid packets into the list than to control the list is correct while using it...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17622
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Mar 2006 05:38:47 +0000 (05:38 +0000)]
coverity bug 44
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17621
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Mar 2006 05:30:26 +0000 (05:30 +0000)]
handle coverity bug 36
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17620
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Mar 2006 04:56:40 +0000 (04:56 +0000)]
put the opcode as a generated field inside data pdus for scsi
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17619
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Mar 2006 01:18:43 +0000 (01:18 +0000)]
prettifu getconfiguration response
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17618
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 14 Mar 2006 00:17:22 +0000 (00:17 +0000)]
missed to add strptime.obj to the editcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17617
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 13 Mar 2006 22:35:14 +0000 (22:35 +0000)]
set current_proto to SCSI so that the exception handler will show the correct protocol
fix length in getconfiguration() so that we provide the proper one (+4)
to avoid marking valid packets as malformed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17616
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 13 Mar 2006 22:22:17 +0000 (22:22 +0000)]
Use checkTextWindow instead of shiftTextWindow to fetch the window object from the stack, shiftXxx will happily (and rightfully) return a null pointer without an error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17615
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 13 Mar 2006 22:20:07 +0000 (22:20 +0000)]
Add -A <start time> and -B <stop time> options to editcap
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17614
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 13 Mar 2006 22:19:36 +0000 (22:19 +0000)]
remove a compiler warning
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17613
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 13 Mar 2006 20:50:50 +0000 (20:50 +0000)]
if tcp checksum validation is enabled
and if the checksum is wrong
and if the checksum field is 0x0000
mark the packet as [Checksum Offloaded] and still allow reassembly of
tcp segmetns
since it is most likely just a tco checksum offload engine and not a real checksum error
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17612
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 13 Mar 2006 10:29:00 +0000 (10:29 +0000)]
SCSI is fairly unique among the ethereal protocols in that it is sometimes normal for a PDU we receive back froma device to be truncated.
(report luns with allocation length 8 for example)
Therefore it is a bit wrong to mark these packets as [malformed packets]
Since they are truncated by scsi and this is NOTY an error condition.
Add a new exception type : ScsiBoundsError
If this exception is caught by packet-frame, then print an appropriate message
instead of [malformed packet]
For SCSI, add helper macros TRY_SCSI_SHORT_PACKET and END_...
If the packet was not short in the normal sense (snaplen < packetlen) then intercept the exception for BoundsError and rethrow it as ScsiBoundsError instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17611
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 13 Mar 2006 06:23:59 +0000 (06:23 +0000)]
From Ming Zhang
added another command preventallowmediaremoval besides those 3.
> enhanced packet-scsi.c a bit to decode 3 more scsi commands
>
> getperformance
> setcdspeed
> readdiscstructure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17610
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 13 Mar 2006 00:31:04 +0000 (00:31 +0000)]
Expert info is going to be used in runtime.
For the sake of speed use integers instead of strings to then be converted into integers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17609
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 13 Mar 2006 00:30:51 +0000 (00:30 +0000)]
fix bug #803: sync pipe on Win32 wasn't set to binary mode, so error message transport failed between Ethereal and dumpcap.
I've also changed the way the secondary error message is transported from former "header message 0 secondary 0" to "header header message 0 header secondary 0" as that might be a bit more clearer, and I'll need it for further development anyway.
I was using this while debugging and not recognizing the real problem - for about four hours :-(. I'll need this feature when doing the interface (and link layer type) browsing later (transferring this data from dumpcap to Ethereal) to get a full blown privilege seperation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17608
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 21:45:18 +0000 (21:45 +0000)]
This time, should be the good one!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17607
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 12 Mar 2006 21:15:01 +0000 (21:15 +0000)]
is that what you meant?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17606
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 20:48:14 +0000 (20:48 +0000)]
Let's see if at the third attempt I get it right...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17605
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 19:47:29 +0000 (19:47 +0000)]
Let's try again!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17604
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 18:57:38 +0000 (18:57 +0000)]
I Hope this works
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17603
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 17:39:46 +0000 (17:39 +0000)]
Move make-init-lua.pl and family to plugins/lua and have init.lua installed in the right place
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17602
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 12 Mar 2006 16:42:10 +0000 (16:42 +0000)]
Assure that pinfo is a valid pointer. Related to Coverity CID 112
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17601
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 16:41:34 +0000 (16:41 +0000)]
Move init.lua and family to plugins/lua
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17600
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 15:31:33 +0000 (15:31 +0000)]
reenable TreeItem,
shiftXXX() was broken
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17599
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 12 Mar 2006 13:03:18 +0000 (13:03 +0000)]
Protocols are now invoked.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17598
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 23:16:34 +0000 (23:16 +0000)]
revert back to svn 17587
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17597
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 22:40:52 +0000 (22:40 +0000)]
oops removed one check too many
when we lookup grandparent, check that we actually have a grandparent.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17596
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 22:26:08 +0000 (22:26 +0000)]
Remove debug code...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17595
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 22:05:40 +0000 (22:05 +0000)]
Protocols register OK.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17594
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 11 Mar 2006 20:19:20 +0000 (20:19 +0000)]
mark parser error messages as Ethereal generated
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17593
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 11 Mar 2006 18:51:57 +0000 (18:51 +0000)]
add dumpcap to the list of new features
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17592
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 18:19:48 +0000 (18:19 +0000)]
Close the files after reading!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17591
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 15:30:52 +0000 (15:30 +0000)]
use se_trees instead of GHashTables,
rename binding into assoc(iation) which is the AOC name.
move the definition of sccp_assoc_t to packet-sccp.h so that information regarding sccp associations it can be used by user protocols
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17590
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 13:36:22 +0000 (13:36 +0000)]
remove some redundant calls and checks and pass the required pointers as parameters instead to make it slightly faster
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17589
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 13:21:41 +0000 (13:21 +0000)]
document the char *name parameter to the create tree functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17588
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 13:02:41 +0000 (13:02 +0000)]
give se_trees names so that it is easier to debug and to log how often certain trees are accessed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17587
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 12:33:15 +0000 (12:33 +0000)]
remove some unusued parameters
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17586
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 12:12:10 +0000 (12:12 +0000)]
Avoid a coverity false positive (CID 38) from being considered.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17585
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 12:07:00 +0000 (12:07 +0000)]
Mark coverity CID 117 as a false positive.
Lex code is often hard for humans to understand... neither of the error conditions found would be happening...
One was marked as error because coverity does not understand that yyterminate() breaks execution.
The other marked as an error because coverity is not able to figure out that the error appears in an actions against two different rules that will not ever match toghether.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17584
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 12:03:28 +0000 (12:03 +0000)]
second try to fix the bug
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17583
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 12:00:59 +0000 (12:00 +0000)]
the code forgot to update offset *offset++ is not the same as offset++ :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17582
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 11:55:49 +0000 (11:55 +0000)]
Mark coverity's CID 105 as a false positive.
(The macro GET_MSG_TYPE does propper bounds checking but coverity doesn't consider it (may not be able to resolve the ?: operator) )
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17581
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 11:48:35 +0000 (11:48 +0000)]
Remove an entire horde of off-by-one errors pointed out by Coverity's CID: 83
(Coverity finds just one at a time...)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17580
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 11 Mar 2006 11:45:36 +0000 (11:45 +0000)]
replace GHashTables with se_trees
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17579
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 11:18:56 +0000 (11:18 +0000)]
include emem.h
otherwise ep_strdup() defaults to int which will break
if pointers are bigger than integers.
this should fix bugs 797 802 805 806
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17578
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 11 Mar 2006 09:09:55 +0000 (09:09 +0000)]
... and don't forget to include emem.h!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17577
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 11 Mar 2006 09:08:18 +0000 (09:08 +0000)]
replace g_malloc and alike by their corresponding ep_ functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17576
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 06:12:36 +0000 (06:12 +0000)]
forgot to paint a node causing massively unbalanced tree
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17575
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 11 Mar 2006 01:45:42 +0000 (01:45 +0000)]
propset...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17574
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 11 Mar 2006 00:58:16 +0000 (00:58 +0000)]
dont declare variables in the middle of a code block. many compilers do not like that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17573
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Fri, 10 Mar 2006 22:05:23 +0000 (22:05 +0000)]
Add a function that returns an unique guint32 for each dpc.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17572
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Fri, 10 Mar 2006 22:01:10 +0000 (22:01 +0000)]
fix coverity CIDs 113 and 114.
while at it change the h248 context analysis to use se_trees instead of GHashTables
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17571
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Fri, 10 Mar 2006 21:58:49 +0000 (21:58 +0000)]
avoid doing the lookup of a key twice while inserting items to a tree with an array key.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17570
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 10 Mar 2006 21:34:56 +0000 (21:34 +0000)]
various code cleanup (e.g. remove unrequired length parameter), should also fix coverity id 126
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17569
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Fri, 10 Mar 2006 14:14:39 +0000 (14:14 +0000)]
few warnings from GUID handling avoided
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17568
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Fri, 10 Mar 2006 12:57:22 +0000 (12:57 +0000)]
add guid-utils.h to Makefile.common
remove unused variables from tvbuff.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17567
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Fri, 10 Mar 2006 11:58:22 +0000 (11:58 +0000)]
new FT_GUID handling - big/little endian supported
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17566
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 10 Mar 2006 07:06:21 +0000 (07:06 +0000)]
Fix CID 6 - Unused code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17565
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 10 Mar 2006 05:41:40 +0000 (05:41 +0000)]
fix missing return bug from didier
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17564
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 10 Mar 2006 05:39:57 +0000 (05:39 +0000)]
make using canaries optional
default to use-canaries since that is the current behaviour
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17563
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 10 Mar 2006 05:15:52 +0000 (05:15 +0000)]
add a define that controls explicitely whether we want to use guard pages (if available) or not.
let it default to want-guard-pages since the existing code does that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17562
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Fri, 10 Mar 2006 03:03:06 +0000 (03:03 +0000)]
Remove a linebreak to emphasise the guid structure (doesn't change
the byte ordering).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17561
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 9 Mar 2006 23:13:49 +0000 (23:13 +0000)]
Fix Coverity CID 129: initialize a couple of variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17560
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 9 Mar 2006 22:13:51 +0000 (22:13 +0000)]
debugging helper: if (for whatever reason) the message from dumpcap was invalid, try to print it. This was already helpful e.g. as a GLib warning was confusing the pipe handling
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17559
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 9 Mar 2006 22:06:25 +0000 (22:06 +0000)]
fix two bugs causing crashes on Win32:
- fix buggy g_snprintf call (Win32 fails if %s is called with a NULL pointer)
- don't call file close if file wasn't open before (Win32 crashes if eth_unlink is called with a NULL pointer)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17558
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 9 Mar 2006 21:18:44 +0000 (21:18 +0000)]
don't use g_message() inside dissector code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17557
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 9 Mar 2006 20:48:17 +0000 (20:48 +0000)]
Fix a possible NULL dereference (Coverity CID 33).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17556
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 9 Mar 2006 19:38:51 +0000 (19:38 +0000)]
Make sure we can't pass NULL to strcmp. Fixes Coverity CID 34. Fix up
whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17555
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 9 Mar 2006 17:58:20 +0000 (17:58 +0000)]
There is a one-to-one mapping between each graph and its "toplevel" and
drawing_area widgets. Instead of canoodling around with a global list
of graphs, simply associate a graph to its widgets using OBJECT_SET_DATA.
This should take care of Coverity CIDs 50 - 59.
Clean up whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17554
f5534014-38df-0310-8fa8-
9805f1628bb7
obiot [Thu, 9 Mar 2006 16:21:39 +0000 (16:21 +0000)]
Fix coverity Error CID: 15.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17553
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 9 Mar 2006 16:17:52 +0000 (16:17 +0000)]
Add lua:s nmakefile.nmake to the distribution.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17552
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 9 Mar 2006 16:00:33 +0000 (16:00 +0000)]
Remove MIN and MAX defines, which GLib provides.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17551
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 9 Mar 2006 14:39:44 +0000 (14:39 +0000)]
Take care of one last UTF-8 <-> UTF-16 conversion (assuming there aren't any
hiding behind casts). Fixes bug 798.
Clean up whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17550
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 9 Mar 2006 12:16:53 +0000 (12:16 +0000)]
coverity #62
potential null dereference
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17549
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 9 Mar 2006 12:11:21 +0000 (12:11 +0000)]
coverity bug#42
dereverencing a null variable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17548
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 9 Mar 2006 12:05:53 +0000 (12:05 +0000)]
propset ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17547
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 9 Mar 2006 11:44:56 +0000 (11:44 +0000)]
coverity #40
fix null dereference
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17546
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 9 Mar 2006 11:34:08 +0000 (11:34 +0000)]
coverity #5
bug causing cosmetic " " spaces to be missing between fields printed to the screen.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17545
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 9 Mar 2006 11:06:21 +0000 (11:06 +0000)]
add documentation on how to use the binary trees
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17544
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 9 Mar 2006 07:07:35 +0000 (07:07 +0000)]
From Laurant Rabret:
Please find enclosed 2 patches.
- Voip_calls_dlg.c.patch fixes a problem that appears with a release
compiled with GTK 2.8 + Visual Studio 2003. It seems g_snprintf can
corrupt memory when a length bigger than the array size is provided in
the second parameter (even if the generated string is smaller than the
array actual size!!)
- graph_analysis.c.patch fixes a memory corruption problem easy to
reproduce. Just open the pcap file enclosed, select "Statistics"->"Flow
Graph" and activate the "Network source/destination addresses" radio
button before pressing OK. You'll see a crash dump.
Thanks to check in
Best Regards
Laurent
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17543
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 9 Mar 2006 06:02:42 +0000 (06:02 +0000)]
Fix Bug 725:
0.10.14 shows "malformed packet" when showing H323 CS: FACILITY message with opcode "Calltransfer initiate"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17542
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Thu, 9 Mar 2006 04:31:10 +0000 (04:31 +0000)]
Display more info for some PXE DHCP options:
- Display UUID for tag #97 (Client machine identifier)
- Display UNDI major and minor version for tag #94 (Client network
interface identifier)
- Use value strings for tag #93 (Client system architecture)
The byte ordering is messed up for the GUID though.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17541
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Thu, 9 Mar 2006 00:50:05 +0000 (00:50 +0000)]
Actually fix that leak!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17540
f5534014-38df-0310-8fa8-
9805f1628bb7
obiot [Wed, 8 Mar 2006 22:52:31 +0000 (22:52 +0000)]
Fix Coverity issue CID: 14 in wkh_accept_encoding().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17539
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 8 Mar 2006 22:42:24 +0000 (22:42 +0000)]
Fix a couple of compilation warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17538
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 8 Mar 2006 22:13:21 +0000 (22:13 +0000)]
Include tchar.h only if we're running Windows. Fixup whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17537
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 8 Mar 2006 21:48:36 +0000 (21:48 +0000)]
Consolidate duration decoding and presentation
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17536
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 8 Mar 2006 21:39:25 +0000 (21:39 +0000)]
fix bug 772: and again, don't pass a NULL pointer to a printf like function on WIN32
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17535
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 8 Mar 2006 20:55:32 +0000 (20:55 +0000)]
Use Unicode for all native Win32 calls. Unicode Windows applications
use UTF-16 internally and GTK+ 2.x uses UTF-8, which means we have to
do a lots of conversions.
Add utf_8to16() and utf_16to8 convenience functions to strutil.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17534
f5534014-38df-0310-8fa8-
9805f1628bb7