obnox/wireshark/wip.git
19 years agoFrom Luis Ontanon:
lroland [Fri, 7 Jan 2005 18:07:18 +0000 (18:07 +0000)]
From Luis Ontanon:

A new patch for mate

- changed the default config file name to ""
- avoid trying to confgure mate when the config filename is ""
- add filename and line to config errors, that way one can actually
find errors in config files
- teady up the config error strings ( made them uniform )
- fixed a crash when missing index AVPs (Name,For,On etc) in config AVPLS
- make sure we do not delete the config AVPs and AVPLs to avoid
references to unsubscribed strings been left arround
- fixed the len on LoALs
- changed the way loal_from_file reports an error.
- matelib/sip.mate was missing the Name in a PduDef  (from Julien Leproust)
- matelib/h225_ras had a wrong field name (from Julien Leproust)

At this point mate is silent when it's not expressely configured by the user.

From me:
reduce compiler noise on MSVC

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12985 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDefine data_handle at startup.
gerald [Fri, 7 Jan 2005 15:08:24 +0000 (15:08 +0000)]
Define data_handle at startup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12984 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Boehne: fix a call to use errmsg_len rather than sizeof
guy [Fri, 7 Jan 2005 13:33:21 +0000 (13:33 +0000)]
From Thomas Boehne: fix a call to use errmsg_len rather than sizeof
errmsg - errmsg is a pointer, so sizeof errmsg is the size of the
pointer, not the size of what it points to.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12983 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Mike Duigou: JXTA protocol support.
guy [Fri, 7 Jan 2005 12:58:43 +0000 (12:58 +0000)]
From Mike Duigou: JXTA protocol support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12982 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoConstify a pointer, so that the array of pointers to ett_ values can be
guy [Fri, 7 Jan 2005 12:56:21 +0000 (12:56 +0000)]
Constify a pointer, so that the array of pointers to ett_ values can be
const, although the pointers can't point to consts (as the values get
filled in as they're registered).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12981 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDoxygen cleanups, from Mike Duigou.
guy [Fri, 7 Jan 2005 12:00:01 +0000 (12:00 +0000)]
Doxygen cleanups, from Mike Duigou.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12980 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGrammar and typo fix from Mike Duigou.
guy [Fri, 7 Jan 2005 11:59:05 +0000 (11:59 +0000)]
Grammar and typo fix from Mike Duigou.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12979 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoInclude <epan/address.h>, as per a suggestion by Thomas Boehne - not all
guy [Fri, 7 Jan 2005 11:56:00 +0000 (11:56 +0000)]
Include <epan/address.h>, as per a suggestion by Thomas Boehne - not all
dissectors using the address resolution routines need to know about the
"address" structure, so not all of them would include <epan/address.h>
themselves.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12978 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Carlos Pignataro:
guy [Fri, 7 Jan 2005 11:43:05 +0000 (11:43 +0000)]
From Carlos Pignataro:

o BGPv4 SAFI-Specific Attribute support
  - draft-kapoor-nalawade-idr-bgp-ssa-00.txt
o Tunnel SAFI support for BGP
  - draft-nalawade-kapoor-tunnel-safi-02.txt
o Small length fix

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12977 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut back the declaration of hostspath on Windows.
guy [Fri, 7 Jan 2005 11:22:18 +0000 (11:22 +0000)]
Put back the declaration of hostspath on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12976 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free strings fetched with "tvb_get_string()" when
guy [Fri, 7 Jan 2005 10:49:05 +0000 (10:49 +0000)]
From Chris Maynard: free strings fetched with "tvb_get_string()" when
we're done with them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12975 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free strings fetched with "tvb_fake_unicode()" when
guy [Fri, 7 Jan 2005 10:44:44 +0000 (10:44 +0000)]
From Chris Maynard: free strings fetched with "tvb_fake_unicode()" when
we're done with them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12974 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free mallocated strings when we're done with them.
guy [Fri, 7 Jan 2005 10:39:51 +0000 (10:39 +0000)]
From Chris Maynard: free mallocated strings when we're done with them.
(There's still the risk of a leak if we throw an exception before we
free the string.)

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12973 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove the open and close of the hosts file into "read_hosts_file()".
guy [Fri, 7 Jan 2005 10:20:17 +0000 (10:20 +0000)]
Move the open and close of the hosts file into "read_hosts_file()".

On Windows, if we don't get the SYSTEMROOT environment variable, try
various locations where the hosts file is known to exist.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12972 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free strings fetched with "tvb_get_string()".
guy [Fri, 7 Jan 2005 10:09:34 +0000 (10:09 +0000)]
From Chris Maynard: free strings fetched with "tvb_get_string()".

Use "format_text()" or "tvb_format_text()" with the %s format, to handle
non-printable characters.

When uncompressing data into a new tvbuff, add it to the list of data
sources as we do elsewhere.

When putting items into the protocol tree from an uncompressed tvbuff,
use the offset into the tvbuff and the length of the item.

Fetch string lengths into a variable and use the variable rather than
repeatedly fetching the length from a tvbuff.

Use -1 rather than tvb_length_remaining() when putting a "to the end of
the tvbuff" item into the protocol tree.

Use "proto_tree_add_item()" to put items into the tree, rather than
"proto_tree_add_xxx" calls with a "tvb_get_yyy" call as the argument.

If we've fetched a value into a variable, don't re-fetch it in
"proto_tree_add_xxx" calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12971 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCheck return value of getenv().
lroland [Fri, 7 Jan 2005 03:19:39 +0000 (03:19 +0000)]
Check return value of getenv().
It can return NULL, which would lead here to strcpy(hostspath, NULL);
*Very* bad.

replace g_malloc(), strcpy() and strcat() with one single g_strconcat().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12970 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Luis Ontanon:
lroland [Thu, 6 Jan 2005 23:21:10 +0000 (23:21 +0000)]
From Luis Ontanon:

Fix some MSVC warnings in MATE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12969 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Luis Ontanon:
lroland [Thu, 6 Jan 2005 12:39:54 +0000 (12:39 +0000)]
From Luis Ontanon:

Another patch for mate:
 - adds a "GopTree={TRUE|FALSE}" attribute to Gogs
 - changes "ShowPduTree={NoTree|PduTree|FrameTree}"
 - adds "implicit stop" to Gops with no Stop declared

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12968 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a dissector to handle IEEE 802a's OUI Extended Ethertype; dissectors
guy [Thu, 6 Jan 2005 08:37:43 +0000 (08:37 +0000)]
Add a dissector to handle IEEE 802a's OUI Extended Ethertype; dissectors
can register an OUI, and PIDs for that OUI, in the same fashion that
they can do so for SNAP (after which the 802a OUI Extended Ethertype is
clearly modeled).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12967 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoHandle the case where nobody registers any OUIs and oui_info_table is
guy [Thu, 6 Jan 2005 08:21:25 +0000 (08:21 +0000)]
Handle the case where nobody registers any OUIs and oui_info_table is
thus null.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12966 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: catch a case where a string allocated with
guy [Wed, 5 Jan 2005 11:00:11 +0000 (11:00 +0000)]
From Chris Maynard: catch a case where a string allocated with
"tvb_get_string()" wasn't freed.  (It appears there can also be leaks if
an exception is thrown while dissecting.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12965 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse tvb_format_text() with %s format items, to handle non-printable
guy [Wed, 5 Jan 2005 10:55:00 +0000 (10:55 +0000)]
Use tvb_format_text() with %s format items, to handle non-printable
characters.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12964 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: don't extract strings with "tvb_get_string()" if
guy [Wed, 5 Jan 2005 10:51:05 +0000 (10:51 +0000)]
From Chris Maynard: don't extract strings with "tvb_get_string()" if
we're not going to use them, and free them when we're done with them.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12963 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free strings allocated by "tvb_get_string()" after
guy [Wed, 5 Jan 2005 10:45:43 +0000 (10:45 +0000)]
From Chris Maynard: free strings allocated by "tvb_get_string()" after
we're done with them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12962 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free strings allocated by "tvb_fake_unicode()" after
guy [Wed, 5 Jan 2005 10:42:26 +0000 (10:42 +0000)]
From Chris Maynard: free strings allocated by "tvb_fake_unicode()" after
we're done with them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12961 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free mallocated data.
guy [Wed, 5 Jan 2005 10:38:50 +0000 (10:38 +0000)]
From Chris Maynard: free mallocated data.

Don't assign the result of a routine that mallocates data to a const
pointer - that forces us to cast the pointer when freeing the data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12960 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free strings even if we don't put them into the
guy [Wed, 5 Jan 2005 10:27:22 +0000 (10:27 +0000)]
From Chris Maynard: free strings even if we don't put them into the
protocol tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12959 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free a string obtained with "tvb_get_string()".
guy [Wed, 5 Jan 2005 10:23:26 +0000 (10:23 +0000)]
From Chris Maynard: free a string obtained with "tvb_get_string()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12958 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free up the z_stream we've allocated before failure
guy [Wed, 5 Jan 2005 10:19:36 +0000 (10:19 +0000)]
From Chris Maynard: free up the z_stream we've allocated before failure
returns.  (The error returns shouldn't happen in practice, as the GLib
memory allocators never return a null pointer, they just abort the
program, but if we're going to be checking for failure and returning, we
should do the right thing anyway.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12957 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: free strings fetched with "tvb_fake_unicode()".
guy [Wed, 5 Jan 2005 10:17:09 +0000 (10:17 +0000)]
From Chris Maynard: free strings fetched with "tvb_fake_unicode()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12956 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFree the image type string as soon as we're done with it, so that we
guy [Wed, 5 Jan 2005 10:13:24 +0000 (10:13 +0000)]
Free the image type string as soon as we're done with it, so that we
don't leak it (even if we throw an exception processing the image).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12955 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: add a missing free of a string fetched with
guy [Wed, 5 Jan 2005 10:05:03 +0000 (10:05 +0000)]
From Chris Maynard: add a missing free of a string fetched with
tvb_get_string().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12954 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Maynard: don't fetch a string if we're not going to use it.
guy [Wed, 5 Jan 2005 10:01:04 +0000 (10:01 +0000)]
From Chris Maynard: don't fetch a string if we're not going to use it.

Also, move up the freeing of the tag string to immediately after we're
done with it, so we don't leak it if we throw an exception getting the
value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12953 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "tvb_format_text()" with %s format strings, so that we handle
guy [Wed, 5 Jan 2005 09:53:03 +0000 (09:53 +0000)]
Use "tvb_format_text()" with %s format strings, so that we handle
non-printable strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12952 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "tvb_format_text()" to generate the text to use in
guy [Wed, 5 Jan 2005 09:46:43 +0000 (09:46 +0000)]
Use "tvb_format_text()" to generate the text to use in
"proto_tree_add_text()" calls, so that we handle non-printable
characters if they happen to appear in the strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12951 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "tvb_format_text()" to extract and format the buddy name string in
guy [Wed, 5 Jan 2005 09:41:20 +0000 (09:41 +0000)]
Use "tvb_format_text()" to extract and format the buddy name string in
the top-level item for the buddy name, rather than extracting the string
into a mallocated buffer (and not freeing it...).

Put all the code to put stuff into the protocol tree inside "if(tree)".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12950 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFixed value string names in field array when NO_PROT_PREFIX option is used
kukosa [Wed, 5 Jan 2005 07:09:06 +0000 (07:09 +0000)]
Fixed value string names in field array when NO_PROT_PREFIX option is used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12949 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix broken parts of the new h225 dissector:
lroland [Wed, 5 Jan 2005 02:25:34 +0000 (02:25 +0000)]
Fix broken parts of the new h225 dissector:
- add more data to the Info structure of the h225 taps.
- Fix the output to the Info Column

This patch is not complete, but statistics should basically work now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12948 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"dissect_h225_H323UserInformation()" returns the number of bytes
guy [Tue, 4 Jan 2005 21:05:56 +0000 (21:05 +0000)]
"dissect_h225_H323UserInformation()" returns the number of bytes
dissected, so register it as a new-style dissector.

As we register it by name, we don't need to create a dissector handle
for it to register it in a dissector table - just use "find_dissector()"
to find the handle.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12947 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoReplace a "cp" with three "xcopy"s.
gerald [Tue, 4 Jan 2005 17:25:38 +0000 (17:25 +0000)]
Replace a "cp" with three "xcopy"s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12946 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoLet capinfos print statistics for more than one file. Normalize
gerald [Mon, 3 Jan 2005 21:11:53 +0000 (21:11 +0000)]
Let capinfos print statistics for more than one file.  Normalize
capitalization.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12945 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove "c:\cygwin\bin" to the end of the PATH. The latest Cygwin includes a
gerald [Mon, 3 Jan 2005 20:03:16 +0000 (20:03 +0000)]
Move "c:\cygwin\bin" to the end of the PATH.  The latest Cygwin includes a
"link" command which collides with the MSVC linker.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12944 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the version and library information in the about box copy-and-paste-able
gerald [Mon, 3 Jan 2005 19:58:04 +0000 (19:58 +0000)]
Make the version and library information in the about box copy-and-paste-able
under GTK+ 2.x.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12943 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDirectives #.FN_* can be used for Ethereal types as well as for ASN.1 types
kukosa [Mon, 3 Jan 2005 14:41:02 +0000 (14:41 +0000)]
Directives #.FN_* can be used for Ethereal types as well as for ASN.1 types

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12942 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- names for value_string tables are generated with protocol name prefix
kukosa [Mon, 3 Jan 2005 12:54:31 +0000 (12:54 +0000)]
- names for value_string tables are generated with protocol name prefix
- FROM constraint for PER supported

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12941 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange e-mail address of Olivier Biot.
obiot [Mon, 3 Jan 2005 11:26:45 +0000 (11:26 +0000)]
Change e-mail address of Olivier Biot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12940 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd some more comments about the FCS issue.
guy [Mon, 3 Jan 2005 10:27:20 +0000 (10:27 +0000)]
Add some more comments about the FCS issue.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12939 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGive a bit more information on the "are there FCSes in the frame?"
guy [Mon, 3 Jan 2005 10:10:23 +0000 (10:10 +0000)]
Give a bit more information on the "are there FCSes in the frame?"
issue.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12938 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRename the CAPTYPE_ definitions as appropriate - many of them are
guy [Mon, 3 Jan 2005 05:27:35 +0000 (05:27 +0000)]
Rename the CAPTYPE_ definitions as appropriate - many of them are
specific to particular types of captures, and the same value might
correspond to more than one CAPTYPE_ definition.

Add an additional CAPTYPE_ for some non-gigabit Ethereal capture seen by
Bill Meier, and fix the range check the time stamp units value as per
his mail.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12937 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom James Fields and Kevin Johnson: fix the handling of time stamps in
guy [Mon, 3 Jan 2005 03:42:23 +0000 (03:42 +0000)]
From James Fields and Kevin Johnson: fix the handling of time stamps in
a number of Windows Sniffer captures - apparently the time stamp units
are in a field in the file header.

Add a capture type value seen in at least one ATM capture.

Update some comments, and add some comments.

Get rid of some redundant setting of "timeunit".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12936 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRewrap a paragraph, for the benefit of us old-timers who typically use
guy [Mon, 3 Jan 2005 01:36:35 +0000 (01:36 +0000)]
Rewrap a paragraph, for the benefit of us old-timers who typically use
80-column wide terminal windows (which also lets more windows fit than
would fit with wider windows).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12935 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf the ICMP code is present, put it in the Info column.
gerald [Mon, 3 Jan 2005 00:08:40 +0000 (00:08 +0000)]
If the ICMP code is present, put it in the Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12934 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofix a typo in new packet-h225.h
lroland [Sun, 2 Jan 2005 22:56:25 +0000 (22:56 +0000)]
fix a typo in new packet-h225.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12933 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange the dissectors to asn2eth generated ones.
etxrab [Sun, 2 Jan 2005 22:05:47 +0000 (22:05 +0000)]
Change the dissectors to asn2eth generated ones.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12932 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThis file is needed if h225 or h245 is generated separately.
etxrab [Sun, 2 Jan 2005 22:03:12 +0000 (22:03 +0000)]
This file is needed if h225 or h245 is generated separately.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12931 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoasn2eth generated h225 dissector
etxrab [Sun, 2 Jan 2005 22:01:32 +0000 (22:01 +0000)]
asn2eth generated h225 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12930 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoasn2eth generated h225 dissector
etxrab [Sun, 2 Jan 2005 22:00:32 +0000 (22:00 +0000)]
asn2eth generated h225 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12929 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoasn2eth generated h245 dissector
etxrab [Sun, 2 Jan 2005 21:58:45 +0000 (21:58 +0000)]
asn2eth generated h245 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12928 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoasn2eth generated h245 dissector
etxrab [Sun, 2 Jan 2005 21:58:06 +0000 (21:58 +0000)]
asn2eth generated h245 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12927 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago*Correctly* append to the filter string.
guy [Sun, 2 Jan 2005 10:01:05 +0000 (10:01 +0000)]
*Correctly* append to the filter string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12926 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUnlike the detailed description of resource record types, the
guy [Sun, 2 Jan 2005 09:40:26 +0000 (09:40 +0000)]
Unlike the detailed description of resource record types, the
detailed description of classes is pretty much redundant - remove it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12925 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't cast pointers passed as arguments - pass a pointer to the right
guy [Sun, 2 Jan 2005 04:01:00 +0000 (04:01 +0000)]
Don't cast pointers passed as arguments - pass a pointer to the right
type of variable and assign the value; that squelches "dereferencing
type-punned pointer will break strict-aliasing rules" warnings from some
versions of GCC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12924 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCast away the constness of the argument to "g_tree_lookup()" - another
guy [Sun, 2 Jan 2005 03:58:08 +0000 (03:58 +0000)]
Cast away the constness of the argument to "g_tree_lookup()" - another
GLib function with an unfortunate signature.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12923 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCast the values passed to the <ctype.h> macros so as to avoid
guy [Sun, 2 Jan 2005 00:23:50 +0000 (00:23 +0000)]
Cast the values passed to the <ctype.h> macros so as to avoid
sign-extending 8-bit characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12922 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd casts of OBJECT_SET_DATA() arguments in cases where that's
guy [Sat, 1 Jan 2005 23:54:32 +0000 (23:54 +0000)]
Add casts of OBJECT_SET_DATA() arguments in cases where that's
appropriate.

Use %u, not %d, to convert unsigned values to strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12921 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"inet_pton()" isn't getting declared on Windows; include "inet_v6defs.h"
guy [Sat, 1 Jan 2005 23:40:56 +0000 (23:40 +0000)]
"inet_pton()" isn't getting declared on Windows; include "inet_v6defs.h"
if NEED_INET_V6DEFS_H is defined, as is done in "packet-sdp.c", the
other module using "inet_pton()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12920 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't explicitly cast the last argument to OBJECT_SET_DATA() to
guy [Sat, 1 Jan 2005 23:29:05 +0000 (23:29 +0000)]
Don't explicitly cast the last argument to OBJECT_SET_DATA() to
"gpointer" - callers should do that if appropriate (or perhaps change
the call to pass a different argument if that's more appropriate), and
even if casting it were the right thing to do, the argument needs to be
surrounded with parentheses so the correct value is cast.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12919 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCast away the constness of the geom_name argument to
guy [Sat, 1 Jan 2005 23:25:49 +0000 (23:25 +0000)]
Cast away the constness of the geom_name argument to
"window_new_with_geom()" - there's no way to tell the compiler that
we're not going to be modifying it, but we aren't.

The right way to check whether a pointer is null and get a Boolean is to
test it against null, not to cast it to a Boolean type - as Boolean
types in C89/C90, at least, are just integral types, that cast might
just throw away the upper 32 bits; that probably yields the results you
want, but the compiler might well justifiably warn about that on an LP64
platform.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12918 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix the signature of "iostat_packet()" - the pointer to data supplied by
guy [Sat, 1 Jan 2005 23:22:10 +0000 (23:22 +0000)]
Fix the signature of "iostat_packet()" - the pointer to data supplied by
the dissector is a const pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12917 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen computing a hash value based on, among other things, a
guy [Sat, 1 Jan 2005 23:21:05 +0000 (23:21 +0000)]
When computing a hash value based on, among other things, a
conversation, use the "index" member of the conversation_t - that lets
you get a value that fits in a guint, but without provoking the warning
you might get from a compiler if you cast a pointer to the conversation
to a guint.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12916 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe right way to check whether a pointer is null and get a Boolean is to
guy [Sat, 1 Jan 2005 23:19:11 +0000 (23:19 +0000)]
The right way to check whether a pointer is null and get a Boolean is to
test it against null, not to cast it to a Boolean type - as Boolean
types in C89/C90, at least, are just integral types, that cast might
just throw away the upper 32 bits; that probably yields the results you
want, but the compiler might well justifiably warn about that on an LP64
platform.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12915 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of some warnings about variables whose values might be lost in a
guy [Sat, 1 Jan 2005 23:11:46 +0000 (23:11 +0000)]
Get rid of some warnings about variables whose values might be lost in a
longjmp, by properly qualifying those variables as volatile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12914 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the signatures of functions passed to "register_tap_listener()"
guy [Sat, 1 Jan 2005 12:49:54 +0000 (12:49 +0000)]
Make the signatures of functions passed to "register_tap_listener()"
match what "register_tap_listener()" expects (rather than squelching
warnings about the differences by casting function pointers to "void
*").

Make static some functions not used outside the module in which they're
defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12913 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThrow in a cast to squelch an (unavoidable, and probably harmless -
guy [Sat, 1 Jan 2005 12:32:28 +0000 (12:32 +0000)]
Throw in a cast to squelch an (unavoidable, and probably harmless -
GTK+'s function signatures aren't necessarily what they should be)
warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12912 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"address_to_str()" and "address_to_str_buf()" don't modify the "address"
guy [Sat, 1 Jan 2005 12:29:26 +0000 (12:29 +0000)]
"address_to_str()" and "address_to_str_buf()" don't modify the "address"
structure pointed to them by reference, so make the argument a "const"
pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12911 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAs we've made the tap_specific_data field of a tap_packet_t structure a
guy [Sat, 1 Jan 2005 02:57:02 +0000 (02:57 +0000)]
As we've made the tap_specific_data field of a tap_packet_t structure a
const pointer (so that we don't get complaints when we make the
tap-specific data argument to "tap_queue_packet()" a const pointer,
allowing dissectors to hand const data to a tap without a complaint), we
should make the tap per-packet function take a const pointer as an
argument as well.  Do so.

In some taps, use _U_, or actually use the argument, rather than
sticking in dummy "X = X" assignments to fake use of parameters.  (This
means that the tap functions in question no longer have the notion that
they act on a particular static structure wired in.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12910 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote what Fibre Channel spec documents this protocol.
guy [Fri, 31 Dec 2004 22:00:44 +0000 (22:00 +0000)]
Note what Fibre Channel spec documents this protocol.

Don't assign the const pointers passed to hash routines to non-const
pointers.

In "zonenm_to_str()", don't assume there's a null terminator in the
packet - use "tvb_get_string()" so that the buffer into which it's
copied is explicitly null-terminated.

Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string,
rather than as a string with one blank in it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12909 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't bother copying the switch name to a buffer - we can just use
guy [Fri, 31 Dec 2004 21:40:22 +0000 (21:40 +0000)]
Don't bother copying the switch name to a buffer - we can just use
"tvb_get_ptr()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12908 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a bug introduced in the previous checkin.
guy [Fri, 31 Dec 2004 21:36:08 +0000 (21:36 +0000)]
Fix a bug introduced in the previous checkin.

Make the names for list record types match the names used before the
previous checkin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12907 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFC-over-IP is now covered by RFCs; update the specification references.
guy [Fri, 31 Dec 2004 21:20:46 +0000 (21:20 +0000)]
FC-over-IP is now covered by RFCs; update the specification references.

Make the protcol/version information an array of 8 bytes, not 2 guints;
not all the world's a (little-endian) PC!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12906 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote what Fibre Channel spec documents this protocol.
guy [Fri, 31 Dec 2004 20:58:23 +0000 (20:58 +0000)]
Note what Fibre Channel spec documents this protocol.

Don't assign the const pointers passed to hash routines to non-const
pointers.

Don't use "tvb_get_ptr()" to get a pointer to a data structure, and
dereference that pointer - there's no guarantee that the structure in
question will be located on an appropriate boundary in the data from the
packet (regardless of whether it's properly aligned within the data for
the protocol being dissected).

Put the record length for an EFP request into the protocol tree.

Check the sanity of the payload length for that request.

In "zonenm_to_str()", don't assume there's a null terminator in the
packet - use "tvb_get_string()" so that the buffer into which it's
copied is explicitly null-terminated.

Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string,
rather than as a string with one blank in it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12905 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote what Fibre Channel spec documents this protocol.
guy [Fri, 31 Dec 2004 20:35:55 +0000 (20:35 +0000)]
Note what Fibre Channel spec documents this protocol.

Don't assign the const pointers passed to hash routines to non-const
pointers.

Don't assume that strings the spec says are null-terminated are
necessarily null-terminated in the packet - use "tvb_strsize()" to find
the length of the purported null-terminated string; it'll throw the
appropriate exception if no null is found.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12904 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate some function declarations in the plugin api
lroland [Fri, 31 Dec 2004 14:53:17 +0000 (14:53 +0000)]
Update some function declarations in the plugin api

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12903 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Luis Ontanon for Mate:
lroland [Fri, 31 Dec 2004 14:27:38 +0000 (14:27 +0000)]
From Luis Ontanon for Mate:
- moved gop and gog indexes into gopcfgs, which is a propedeutic
change for upcoming changes in the way gops are to be grouped
-  changed the way gog-keys are kept in memory
- every gopkey attribute is copied into the gop->extras to avoid
redundancy in the configuration
- added timers to gogs mate.gog_type.StartTime and mate.gog_type.Time
- fixed a bug in scs_subscribe that mangled some strings
- minor interface improvement to scs propedeutic to having types avp
values in a future
- changed medium and large into mate_medium and mate_large in the
scs_collection
- fixed Mode=Replace in Transforms, now it works
- fixed a crash at reinit due to impropper initialization of mate_items

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12902 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix from Luis Ontanon:
lroland [Fri, 31 Dec 2004 14:14:44 +0000 (14:14 +0000)]
Fix from Luis Ontanon:
Bring tap-h225counter.c in sync with newest revision of the h225 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12901 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "proto_tree_add_item()" to add a chunk of bytes to the protocol
guy [Fri, 31 Dec 2004 03:18:13 +0000 (03:18 +0000)]
Use "proto_tree_add_item()" to add a chunk of bytes to the protocol
tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12900 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't assign const pointers to non-const pointers, especially if the
guy [Fri, 31 Dec 2004 03:17:00 +0000 (03:17 +0000)]
Don't assign const pointers to non-const pointers, especially if the
object pointed to by the non-const pointer won't be modified.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12899 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"string_to_hex()" doesn't modify its first argument, so make it a
guy [Fri, 31 Dec 2004 03:14:18 +0000 (03:14 +0000)]
"string_to_hex()" doesn't modify its first argument, so make it a
"const" pointer, and don't cast away the constness of "tvb_get_ptr()"s
result when passing it to "string_to_hex()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12898 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't cast away the constness of pointers passed to "ip_to_str()" -
guy [Fri, 31 Dec 2004 03:12:51 +0000 (03:12 +0000)]
Don't cast away the constness of pointers passed to "ip_to_str()" -
"ip_to_str()" takes a "const guint8 *" argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12897 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThere are no guarantees that "strncasecmp()" works with
guy [Fri, 31 Dec 2004 03:10:11 +0000 (03:10 +0000)]
There are no guarantees that "strncasecmp()" works with
non-null-terminated strings, so be safe and fetch the metatag string
with "tvb_get_string()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12896 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "tvb_memeql()" to check whether specified bytes in a packet have a
guy [Fri, 31 Dec 2004 02:48:53 +0000 (02:48 +0000)]
Use "tvb_memeql()" to check whether specified bytes in a packet have a
specified value.

Make a constant array "const".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12895 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't cast away the constness of argument pointers.
guy [Fri, 31 Dec 2004 02:16:05 +0000 (02:16 +0000)]
Don't cast away the constness of argument pointers.

Don't supply our own definition of AF_INET or our own declaration of
"inet_pton()" - use the system ones if they're available.

"mkipv4_address()" doesn't modify the string passed to it - make it a
const pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12894 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't roll our own code to display IPv4 or IPv6 addresses, use
guy [Fri, 31 Dec 2004 02:13:42 +0000 (02:13 +0000)]
Don't roll our own code to display IPv4 or IPv6 addresses, use
"ip_to_str()" and "ip6_to_str()".

Check the length of items for IPv4 and IPv6 addresses before displaying
them as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12893 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't assign the const pointers passed to hash routines to non-const
guy [Fri, 31 Dec 2004 02:11:13 +0000 (02:11 +0000)]
Don't assign the const pointers passed to hash routines to non-const
pointers.

Now that "col_set_str()" takes a "const char *" as the second argument,
we don't have to cast away the constness of strings passed to it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12892 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't assign a const pointer argument to a non-const pointer variable.
guy [Fri, 31 Dec 2004 02:09:48 +0000 (02:09 +0000)]
Don't assign a const pointer argument to a non-const pointer variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12891 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't assign the const pointers passed to hash routines to non-const
guy [Fri, 31 Dec 2004 02:08:01 +0000 (02:08 +0000)]
Don't assign the const pointers passed to hash routines to non-const
pointers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12890 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoProperly cast the pointer assigned to col_info->col_data.
guy [Fri, 31 Dec 2004 02:03:16 +0000 (02:03 +0000)]
Properly cast the pointer assigned to col_info->col_data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12889 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"proto_registrar_get_byname()" doesn't modify its argument, so make it
guy [Fri, 31 Dec 2004 02:02:19 +0000 (02:02 +0000)]
"proto_registrar_get_byname()" doesn't modify its argument, so make it
"const char *".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12888 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake arguments "const *" if the routine doesn't modify the object to
guy [Fri, 31 Dec 2004 02:01:03 +0000 (02:01 +0000)]
Make arguments "const *" if the routine doesn't modify the object to
which they point.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12887 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake sure print_buff is \0-terminated
jmayer [Fri, 31 Dec 2004 01:56:22 +0000 (01:56 +0000)]
Make sure print_buff is \0-terminated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12886 f5534014-38df-0310-8fa8-9805f1628bb7