nivanova/samba-autobuild/.git
8 years agopyldb: Fixes and Python3 compat for Dn component accessors
Petr Viktorin [Fri, 21 Aug 2015 08:10:28 +0000 (10:10 +0200)]
pyldb: Fixes and Python3 compat for Dn component accessors

Use "s#"/"z#" argument specifiers in set_component and
set_extended_component instead of converting strings manually.
(Under Python 3, This means both text strings and bytes are accepted.)

Raise error on set_component(None), instead of crashing.

Return text strings from get_{extended}_component under Python 3.

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agopyldb: Prevent segfault when first module is NULL
Petr Viktorin [Fri, 21 Aug 2015 08:07:17 +0000 (10:07 +0200)]
pyldb: Prevent segfault when first module is NULL

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agoldb: Build for two Python versions at once
Petr Viktorin [Fri, 14 Aug 2015 10:43:41 +0000 (12:43 +0200)]
ldb: Build for two Python versions at once

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agopyldb: Adapt tests to Python 3
Petr Viktorin [Wed, 29 Jul 2015 10:45:43 +0000 (12:45 +0200)]
pyldb: Adapt tests to Python 3

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agopyldb: Split text/byte strings for compatibility with Python 3
Petr Viktorin [Tue, 9 Jun 2015 15:44:40 +0000 (17:44 +0200)]
pyldb: Split text/byte strings for compatibility with Python 3

Compatibility with Python 2, and backwards compatibility on Python 2,
is kept.

Under Python 3, DNs, attribute names, filters, controls are always text
(unicode) strings, encoded to/from UTF-8 for storage.
Attribute values are byte strings.

When creating DNs and attribute values, both text and bytes are accepted.
This allows creating messages from homogeneous dicts.

LDB Messages and MessageElements have a .text attribute, which offers
a text view on the contents: any value retrieved from it will be a text
string. The wrapper is implemented in a new Python module.

Thanks to Stefan Metzmacher for const warning fixes

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 years agopyldb: Modernize test suite
Petr Viktorin [Wed, 10 Jun 2015 08:21:24 +0000 (10:21 +0200)]
pyldb: Modernize test suite

This gets rid of deprecation warnings for the old method names.

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agopyldb: Add Python 3 compatibility (except strings)
Petr Viktorin [Tue, 9 Jun 2015 08:36:26 +0000 (10:36 +0200)]
pyldb: Add Python 3 compatibility (except strings)

- Use a macro for adding constants to module
(This also ensures that the Python constants have the same
name as the C ones. One existing misspelling is retained.)

- Use new module initialization for Python 3

- Use rich comparison for ldb objects

- Prepare tests for Python 3

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agopyldb: DECREF old debug function when resetting it
Petr Viktorin [Wed, 10 Jun 2015 13:40:34 +0000 (15:40 +0200)]
pyldb: DECREF old debug function when resetting it

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agopyldb: Don't use the internal macro PyObject_REPR
Petr Viktorin [Wed, 10 Jun 2015 13:41:57 +0000 (15:41 +0200)]
pyldb: Don't use the internal macro PyObject_REPR

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agopyldb: Properly increase refcount of returned values
Petr Viktorin [Thu, 11 Jun 2015 08:16:48 +0000 (10:16 +0200)]
pyldb: Properly increase refcount of returned values

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agoldb: Run the Python testsuite
Petr Viktorin [Mon, 8 Jun 2015 12:17:12 +0000 (14:17 +0200)]
ldb: Run the Python testsuite

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agotevent: version 0.9.26 tevent-0.9.26
Stefan Metzmacher [Mon, 24 Aug 2015 13:47:51 +0000 (15:47 +0200)]
tevent: version 0.9.26

* New tevent_thread_proxy API
* Minor build fixes

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agolib: tevent: docs: Add tutorial on thread usage.
Jeremy Allison [Wed, 22 Jul 2015 18:52:06 +0000 (11:52 -0700)]
lib: tevent: docs: Add tutorial on thread usage.

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
8 years agolib: tevent: tests: Add a second thread test that does request/reply.
Jeremy Allison [Fri, 24 Jul 2015 16:27:21 +0000 (09:27 -0700)]
lib: tevent: tests: Add a second thread test that does request/reply.

Both tests run cleanly with valgrind --tool=drd and
valgrind --tool=helgrind

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
8 years agolib: tevent: Initial test of tevent threaded context code.
Jeremy Allison [Fri, 24 Jul 2015 15:50:31 +0000 (08:50 -0700)]
lib: tevent: Initial test of tevent threaded context code.

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
8 years agolib: tevent: Initial checkin of threaded tevent context calling code.
Jeremy Allison [Thu, 23 Jul 2015 22:23:50 +0000 (15:23 -0700)]
lib: tevent: Initial checkin of threaded tevent context calling code.

Adds 2 new functions:

struct tevent_thread_proxy *tevent_thread_proxy_create(
                struct tevent_context *dest_ev_ctx);

void tevent_thread_proxy_schedule(struct tevent_thread_proxy *tp,
struct tevent_immediate **pp_im,
tevent_immediate_handler_t handler,
void *pp_private_data);

Brief doc included. Tests, docs and tutorial to follow.

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agotdb: version 1.3.8 tdb-1.3.8
Stefan Metzmacher [Mon, 24 Aug 2015 13:41:33 +0000 (15:41 +0200)]
tdb: version 1.3.8

* Fix broken build with --disable-python
* Minor build fixes

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agotalloc: version 2.1.5 talloc-2.1.5
Stefan Metzmacher [Mon, 24 Aug 2015 13:47:18 +0000 (15:47 +0200)]
talloc: version 2.1.5

* Minor build fixes

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Bump version to 1.2.0
Andreas Schneider [Wed, 4 Nov 2015 11:54:05 +0000 (12:54 +0100)]
uwrap: Bump version to 1.2.0

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov  5 12:30:02 CET 2015 on sn-devel-104

8 years agouwrap: Fix build warning with release build
Andreas Schneider [Fri, 30 Oct 2015 12:41:47 +0000 (13:41 +0100)]
uwrap: Fix build warning with release build

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Add the EINVAL check to setegid()
Andreas Schneider [Fri, 30 Oct 2015 12:41:18 +0000 (13:41 +0100)]
uwrap: Add the EINVAL check to setegid()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Allow setgid calls only for privileged users
Andreas Schneider [Fri, 30 Oct 2015 12:40:45 +0000 (13:40 +0100)]
uwrap: Allow setgid calls only for privileged users

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Allow setregid calls only for privileged users
Andreas Schneider [Fri, 30 Oct 2015 12:40:18 +0000 (13:40 +0100)]
uwrap: Allow setregid calls only for privileged users

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Allow setresgid calls only for privileged users
Andreas Schneider [Fri, 30 Oct 2015 12:39:55 +0000 (13:39 +0100)]
uwrap: Allow setresgid calls only for privileged users

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Move the EINVAL check down in seteuid()
Andreas Schneider [Fri, 30 Oct 2015 12:39:30 +0000 (13:39 +0100)]
uwrap: Move the EINVAL check down in seteuid()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Allow setuid calls only for privileged users
Andreas Schneider [Fri, 30 Oct 2015 12:39:02 +0000 (13:39 +0100)]
uwrap: Allow setuid calls only for privileged users

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Allow setreuid calls only for privileged users
Andreas Schneider [Fri, 30 Oct 2015 12:38:32 +0000 (13:38 +0100)]
uwrap: Allow setreuid calls only for privileged users

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Allow setresuid calls only for privileged users
Andreas Schneider [Fri, 30 Oct 2015 12:37:51 +0000 (13:37 +0100)]
uwrap: Allow setresuid calls only for privileged users

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Fix a possible null pointer dereference
Andreas Schneider [Fri, 30 Oct 2015 12:37:11 +0000 (13:37 +0100)]
uwrap: Fix a possible null pointer dereference

If uid_wrapper is loaded but not enabled (UID_WRAPPER environment
variable not set), then we dereference a NULL pointer while forking.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Improve debug output
Andreas Schneider [Fri, 30 Oct 2015 12:36:39 +0000 (13:36 +0100)]
uwrap: Improve debug output

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agouwrap: Fix debug line in uwrap_init()
Andreas Schneider [Fri, 30 Oct 2015 12:36:04 +0000 (13:36 +0100)]
uwrap: Fix debug line in uwrap_init()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agontvfs: Add error debug statements for set_unix_security
Andreas Schneider [Tue, 13 Oct 2015 12:43:08 +0000 (14:43 +0200)]
ntvfs: Add error debug statements for set_unix_security

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agoselftest: Start Samba AD DC as root
Andreas Schneider [Tue, 13 Oct 2015 11:02:07 +0000 (13:02 +0200)]
selftest: Start Samba AD DC as root

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agos4-rpc_server: Get the real initial uid for selftest
Andreas Schneider [Wed, 4 Nov 2015 09:15:13 +0000 (10:15 +0100)]
s4-rpc_server: Get the real initial uid for selftest

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agoselftest: Start smbd, nmbd and winbindd as root
Andreas Schneider [Fri, 30 Oct 2015 13:30:58 +0000 (14:30 +0100)]
selftest: Start smbd, nmbd and winbindd as root

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-lib: Get the real initial uid for selftest
Andreas Schneider [Fri, 30 Oct 2015 13:31:33 +0000 (14:31 +0100)]
s3-lib: Get the real initial uid for selftest

We need this that if we connect as the user who started smbd, we are
able to perform privileged operation like creating a user.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agovfs_offline: add documentation
Uri Simchoni [Wed, 4 Nov 2015 19:18:20 +0000 (21:18 +0200)]
vfs_offline: add documentation

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov  5 01:22:48 CET 2015 on sn-devel-104

8 years agovfs_offline: add a blackbox test
Uri Simchoni [Wed, 4 Nov 2015 10:06:03 +0000 (12:06 +0200)]
vfs_offline: add a blackbox test

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 years agovfs_offline: add vfs_offline module
Uri Simchoni [Wed, 4 Nov 2015 06:44:29 +0000 (08:44 +0200)]
vfs_offline: add vfs_offline module

This module marks all file in the share as offline.
It can be useful for shares mounted on top of a remote file
system (either through a samba VFS module or via FUSE).

Offline files change the behavior of Windows explorer, and
prevent it from peeking inside folders just for the sake of
drawing a nice icon of them. This greatly reduces the number
of requests Windows Explorer makes, and improves user experience
when dealing with remote file systems.

The offline bit also has an effect on the behavior of Windows
redirector.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 years agos3: rpcclient: Prevent null ptr access by returning error if no creds available
Noel Power [Mon, 2 Nov 2015 09:59:12 +0000 (09:59 +0000)]
s3: rpcclient: Prevent null ptr access by returning error if no creds available

Prevent rpccli_netlogon_password_logon being called with 'NULL' credentials.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agos3: winbind: Prevent null ptr access by returning error if no creds available
Noel Power [Thu, 22 Oct 2015 11:37:17 +0000 (12:37 +0100)]
s3: winbind: Prevent null ptr access by returning error if no creds available

Prevent rpccli_netlogon_network_logon/rpccli_netlogon_password_logon
being called with 'NULL' credentials

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 years agos3: smbd: If EA's are turned off on a share don't allow an SMB2 create containing...
Jeremy Allison [Wed, 4 Nov 2015 17:34:57 +0000 (09:34 -0800)]
s3: smbd: If EA's are turned off on a share don't allow an SMB2 create containing them.

Otherwise a create that should have failed may succeed.

Based on an original patch from John Mulligan <phlogistonjohn@asynchrono.us>
and comments from Uri Simchoni <uri@samba.org>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11589

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Wed Nov  4 22:14:22 CET 2015 on sn-devel-104

8 years agowafsamba: detect programmer errors in CHECK_BUNDLED_SYSTEM()
Stefan Metzmacher [Thu, 27 Aug 2015 08:47:05 +0000 (10:47 +0200)]
wafsamba: detect programmer errors in CHECK_BUNDLED_SYSTEM()

All prerequisite libraries of CHECK_BUNDLED_SYSTEM[_PKG](onlyif='lib1 lib2')
need to be checked before.

That means conf.env['FOUND_SYSTEMLIB_lib1'] and conf.env['FOUND_SYSTEMLIB_lib2']
need to exist independed of its value (True or False). Otherwise this is a logic error.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11458

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Nov  4 18:38:18 CET 2015 on sn-devel-104

8 years agotests: Add tests for net ads (join|leave)
Andreas Schneider [Tue, 20 Oct 2015 13:54:39 +0000 (15:54 +0200)]
tests: Add tests for net ads (join|leave)

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Wed Nov  4 15:35:57 CET 2015 on sn-devel-104

8 years agoctdb-build: Add ctdb/ directory to include path for top-level build
Amitay Isaacs [Thu, 29 Oct 2015 07:28:29 +0000 (18:28 +1100)]
ctdb-build: Add ctdb/ directory to include path for top-level build

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Nov  4 03:52:27 CET 2015 on sn-devel-104

8 years agoctdb-include: Use new protocol definitions
Amitay Isaacs [Thu, 29 Oct 2015 06:51:52 +0000 (17:51 +1100)]
ctdb-include: Use new protocol definitions

This gets rid of the duplicate definitions from ctdb_protocol.h.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-protocol: Rename G_LOCK_READ/WRITE to CTDB_G_LOCK_READ/WRITE
Amitay Isaacs [Thu, 29 Oct 2015 07:37:42 +0000 (18:37 +1100)]
ctdb-protocol: Rename G_LOCK_READ/WRITE to CTDB_G_LOCK_READ/WRITE

to avoid clash with definitions from source3/include/g_lock.h.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-client: Rename g_lock datatypes as per new protocol.h
Amitay Isaacs [Thu, 29 Oct 2015 06:55:35 +0000 (17:55 +1100)]
ctdb-client: Rename g_lock datatypes as per new protocol.h

struct server_id => ctdb_server_id
enum g_lock_type => ctdb_g_lock_type
struct g_lock_rec => ctdb_g_lock
struct g_lock_recs => ctdb_g_lock_list

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-include: Remove unused definitions
Amitay Isaacs [Thu, 29 Oct 2015 06:36:23 +0000 (17:36 +1100)]
ctdb-include: Remove unused definitions

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-tools: Use replace headers instead of system headers
Amitay Isaacs [Wed, 28 Oct 2015 08:52:02 +0000 (19:52 +1100)]
ctdb-tools: Use replace headers instead of system headers

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Remove explicit include of ctdb_protocol.h
Amitay Isaacs [Wed, 28 Oct 2015 08:52:53 +0000 (19:52 +1100)]
ctdb-daemon: Remove explicit include of ctdb_protocol.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_get_ifaces to ctdb_iface_list_old
Amitay Isaacs [Wed, 28 Oct 2015 08:43:48 +0000 (19:43 +1100)]
ctdb-daemon: Rename struct ctdb_control_get_ifaces to ctdb_iface_list_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_public_ip_info to ctdb_public_ip_info_old
Amitay Isaacs [Wed, 28 Oct 2015 08:39:51 +0000 (19:39 +1100)]
ctdb-daemon: Rename struct ctdb_control_public_ip_info to ctdb_public_ip_info_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_iface_info to ctdb_iface
Amitay Isaacs [Wed, 28 Oct 2015 08:37:17 +0000 (19:37 +1100)]
ctdb-daemon: Rename struct ctdb_control_iface_info to ctdb_iface

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_transdb to ctdb_transdb
Amitay Isaacs [Wed, 28 Oct 2015 08:22:23 +0000 (19:22 +1100)]
ctdb-daemon: Rename struct ctdb_control_transdb to ctdb_transdb

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_set_tunable to ctdb_tunable_old
Amitay Isaacs [Wed, 28 Oct 2015 08:18:02 +0000 (19:18 +1100)]
ctdb-daemon: Rename struct ctdb_control_set_tunable to ctdb_tunable_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_pulldb to ctdb_pulldb
Amitay Isaacs [Wed, 28 Oct 2015 08:10:53 +0000 (19:10 +1100)]
ctdb-daemon: Rename struct ctdb_control_pulldb to ctdb_pulldb

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_gratious_arp to ctdb_addr_info_old
Amitay Isaacs [Thu, 29 Oct 2015 03:47:54 +0000 (14:47 +1100)]
ctdb-daemon: Rename struct ctdb_control_gratious_arp to ctdb_addr_info_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_ip_iface to ctdb_addr_info_old
Amitay Isaacs [Thu, 29 Oct 2015 03:46:21 +0000 (14:46 +1100)]
ctdb-daemon: Rename struct ctdb_control_ip_iface to ctdb_addr_info_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_tunable to ctdb_tunable_list
Amitay Isaacs [Wed, 28 Oct 2015 07:51:22 +0000 (18:51 +1100)]
ctdb-daemon: Rename struct ctdb_tunable to ctdb_tunable_list

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_tcp_tickle_list to ctdb_tickle_list_old
Amitay Isaacs [Wed, 28 Oct 2015 07:44:19 +0000 (18:44 +1100)]
ctdb-daemon: Rename struct ctdb_control_tcp_tickle_list to ctdb_tickle_list_old

Also remove unnecessary struct ctdb_tcp_wire_array.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct srvid_request_data to ctdb_disable_message
Amitay Isaacs [Wed, 28 Oct 2015 07:23:13 +0000 (18:23 +1100)]
ctdb-daemon: Rename struct srvid_request_data to ctdb_disable_message

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct srvid_request to ctdb_srvid_message
Amitay Isaacs [Thu, 29 Oct 2015 03:32:49 +0000 (14:32 +1100)]
ctdb-daemon: Rename struct srvid_request to ctdb_srvid_message

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_ban_time to ctdb_ban_state
Amitay Isaacs [Wed, 28 Oct 2015 07:18:33 +0000 (18:18 +1100)]
ctdb-daemon: Rename struct ctdb_ban_time to ctdb_ban_state

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_tcp_connection to ctdb_connection
Amitay Isaacs [Wed, 28 Oct 2015 07:14:21 +0000 (18:14 +1100)]
ctdb-daemon: Rename struct ctdb_tcp_connection to ctdb_connection

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_control_tcp_addr to ctdb_connection
Amitay Isaacs [Thu, 29 Oct 2015 03:25:34 +0000 (14:25 +1100)]
ctdb-daemon: Rename struct ctdb_control_tcp_addr to ctdb_connection

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_server_id_list to ctdb_client_id_list_old
Amitay Isaacs [Thu, 29 Oct 2015 03:16:45 +0000 (14:16 +1100)]
ctdb-daemon: Rename struct ctdb_server_id_list to ctdb_client_id_list_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_server_id to ctdb_client_id
Amitay Isaacs [Wed, 28 Oct 2015 06:47:03 +0000 (17:47 +1100)]
ctdb-daemon: Rename struct ctdb_server_id to ctdb_client_id

This is to avoid clash with samba structure server_id.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename enum ctdb_server_id_type to ctdb_client_id_type
Amitay Isaacs [Thu, 29 Oct 2015 03:12:11 +0000 (14:12 +1100)]
ctdb-daemon: Rename enum ctdb_server_id_type to ctdb_client_id_type

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_dbid_map to ctdb_dbid_map_old
Amitay Isaacs [Thu, 29 Oct 2015 06:46:05 +0000 (17:46 +1100)]
ctdb-daemon: Rename struct ctdb_dbid_map to ctdb_dbid_map_old

Match struct ctdb_dbid as per protocol/protocol.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Remove struct ctdb_client_notify_deregister
Amitay Isaacs [Wed, 28 Oct 2015 06:47:03 +0000 (17:47 +1100)]
ctdb-daemon: Remove struct ctdb_client_notify_deregister

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_client_notify_register to ctdb_notify_data_old
Amitay Isaacs [Wed, 28 Oct 2015 06:43:20 +0000 (17:43 +1100)]
ctdb-daemon: Rename struct ctdb_client_notify_register to ctdb_notify_data_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-include: Remove unused structure definitions
Amitay Isaacs [Wed, 28 Oct 2015 06:36:14 +0000 (17:36 +1100)]
ctdb-include: Remove unused structure definitions

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_iface to ctdb_interface
Amitay Isaacs [Wed, 28 Oct 2015 06:34:24 +0000 (17:34 +1100)]
ctdb-daemon: Rename struct ctdb_iface to ctdb_interface

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_db_statistics to ctdb_db_statistics_old
Amitay Isaacs [Thu, 29 Oct 2015 06:33:09 +0000 (17:33 +1100)]
ctdb-daemon: Rename struct ctdb_db_statistics to ctdb_db_statistics_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_statistics_wire to ctdb_statistics_list_old
Amitay Isaacs [Wed, 28 Oct 2015 09:09:40 +0000 (20:09 +1100)]
ctdb-daemon: Rename struct ctdb_statistics_wire to ctdb_statistics_list_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_rec_data to ctdb_rec_data_old
Amitay Isaacs [Thu, 29 Oct 2015 06:30:30 +0000 (17:30 +1100)]
ctdb-daemon: Rename struct ctdb_rec_data to ctdb_rec_data_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct latency_counter to ctdb_latency_counter
Amitay Isaacs [Wed, 28 Oct 2015 06:18:24 +0000 (17:18 +1100)]
ctdb-daemon: Rename struct latency_counter to ctdb_latency_counter

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_all_public_ips to ctdb_public_ip_list_old
Amitay Isaacs [Wed, 28 Oct 2015 06:16:24 +0000 (17:16 +1100)]
ctdb-daemon: Rename struct ctdb_all_public_ips to ctdb_public_ip_list_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_public_ip_list to public_ip_list
Amitay Isaacs [Wed, 28 Oct 2015 06:10:54 +0000 (17:10 +1100)]
ctdb-daemon: Rename struct ctdb_public_ip_list to public_ip_list

A private structure need not have ctdb_ prefix.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_node_map to ctdb_node_map_old
Amitay Isaacs [Thu, 29 Oct 2015 06:22:48 +0000 (17:22 +1100)]
ctdb-daemon: Rename struct ctdb_node_map to ctdb_node_map_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-include: Remove unnecessary typedefs
Amitay Isaacs [Wed, 28 Oct 2015 05:58:02 +0000 (16:58 +1100)]
ctdb-include: Remove unnecessary typedefs

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_req_keepalive to ctdb_req_keepalive_old
Amitay Isaacs [Thu, 29 Oct 2015 05:45:41 +0000 (16:45 +1100)]
ctdb-daemon: Rename struct ctdb_req_keepalive to ctdb_req_keepalive_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_reply_control to ctdb_reply_control_old
Amitay Isaacs [Thu, 29 Oct 2015 05:44:08 +0000 (16:44 +1100)]
ctdb-daemon: Rename struct ctdb_reply_control to ctdb_reply_control_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_req_control to ctdb_req_control_old
Amitay Isaacs [Thu, 29 Oct 2015 05:42:05 +0000 (16:42 +1100)]
ctdb-daemon: Rename struct ctdb_req_control to ctdb_req_control_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_req_message to ctdb_req_message_old
Amitay Isaacs [Thu, 29 Oct 2015 05:36:30 +0000 (16:36 +1100)]
ctdb-daemon: Rename struct ctdb_req_message to ctdb_req_message_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_reply_dmaster to ctdb_reply_dmaster_old
Amitay Isaacs [Thu, 29 Oct 2015 05:34:01 +0000 (16:34 +1100)]
ctdb-daemon: Rename struct ctdb_reply_dmaster to ctdb_reply_dmaster_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_req_dmaster to ctdb_req_dmaster_old
Amitay Isaacs [Thu, 29 Oct 2015 05:32:09 +0000 (16:32 +1100)]
ctdb-daemon: Rename struct ctdb_req_dmaster to ctdb_req_dmaster_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_reply_error to ctdb_reply_error_old
Amitay Isaacs [Thu, 29 Oct 2015 05:30:31 +0000 (16:30 +1100)]
ctdb-daemon: Rename struct ctdb_reply_error to ctdb_reply_error_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_reply_call to ctdb_reply_call_old
Amitay Isaacs [Thu, 29 Oct 2015 05:29:01 +0000 (16:29 +1100)]
ctdb-daemon: Rename struct ctdb_reply_call to ctdb_reply_call_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_req_call to ctdb_req_call_old
Amitay Isaacs [Thu, 29 Oct 2015 05:26:29 +0000 (16:26 +1100)]
ctdb-daemon: Rename struct ctdb_req_call to ctdb_req_call_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename enum ctdb_eventscript_call to ctdb_event
Amitay Isaacs [Wed, 28 Oct 2015 05:54:10 +0000 (16:54 +1100)]
ctdb-daemon: Rename enum ctdb_eventscript_call to ctdb_event

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_scripts_wire to ctdb_script_list_old
Amitay Isaacs [Wed, 28 Oct 2015 09:02:45 +0000 (20:02 +1100)]
ctdb-daemon: Rename struct ctdb_scripts_wire to ctdb_script_list_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoctdb-daemon: Rename struct ctdb_script_wire to ctdb_script
Amitay Isaacs [Wed, 28 Oct 2015 05:49:47 +0000 (16:49 +1100)]
ctdb-daemon: Rename struct ctdb_script_wire to ctdb_script

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
8 years agoChanging log level of two entries to DBG_NOTICE
Marc Muehlfeld [Tue, 3 Nov 2015 09:09:13 +0000 (10:09 +0100)]
Changing log level of two entries to DBG_NOTICE

On domain members using RFC2307, machine acccounts without an uidNumber
attribute are not retrieved via idmap_ad. This leads to many of the following
two error messages:
   Username DOMAIN\machineaccountname$ is invalid on this system
and
   Failed to map kerberos principal to system user (NT_STATUS_LOGON_FAILURE)
Machine accounts don't have an uidNumber attribute, if not set manually. To
avoid flooding the logs, setting message from debug level 1 to DBG_NOTICE.

Bugreport: https://bugzilla.samba.org/show_bug.cgi?id=9912

Signed-off-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov  4 00:46:15 CET 2015 on sn-devel-104

8 years agobackupkey: Fix CID 1338078 (RESOURCE_LEAK)
Volker Lendecke [Tue, 3 Nov 2015 11:00:56 +0000 (12:00 +0100)]
backupkey: Fix CID 1338078 (RESOURCE_LEAK)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 years agonotifyd: Do not include CTDB headers without CLUSTER_SUPPORT enabled
Amitay Isaacs [Tue, 3 Nov 2015 01:14:41 +0000 (12:14 +1100)]
notifyd: Do not include CTDB headers without CLUSTER_SUPPORT enabled

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Nov  3 15:15:56 CET 2015 on sn-devel-104

8 years agosmbd: Do not include CTDB headers without CLUSTER_SUPPORT enabled
Amitay Isaacs [Tue, 3 Nov 2015 01:37:38 +0000 (12:37 +1100)]
smbd: Do not include CTDB headers without CLUSTER_SUPPORT enabled

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
8 years agos4.torture.smb2/session : Replace CHECK_VAL with torture macros
Anoop C S [Tue, 13 Oct 2015 08:55:20 +0000 (14:25 +0530)]
s4.torture.smb2/session : Replace CHECK_VAL with torture macros

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov  3 03:17:14 CET 2015 on sn-devel-104

8 years agos3:smb2_server: make the logic of SMB2_CANCEL DLIST_REMOVE() clearer
Stefan Metzmacher [Mon, 2 Nov 2015 12:40:24 +0000 (13:40 +0100)]
s3:smb2_server: make the logic of SMB2_CANCEL DLIST_REMOVE() clearer

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11581

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>